On 4 August 2012 20:27, Aakanksha Pudipeddi wrote:
> I came across this while working with qemu for a project. It looks like
> there is no support for mrrc/mcrr in qemu which results in the linux
> arch_timer code throwing a reserved instruction exception. Could you please
> let me know if anybody
On 6 August 2012 03:16, Peter A. G. Crosthwaite
wrote:
> Added VMSD stub for SSI slaves. Fields may be added to this VMSD for generic
> SSI slave state (e.g. the CS line state).
This is more me being confused about how this should work than a
review comment, but it seems a bit odd that we have a
On 6 August 2012 10:13, Peter Maydell wrote:
> On 6 August 2012 03:16, Peter A. G. Crosthwaite
> wrote:
>> Added VMSD stub for SSI slaves. Fields may be added to this VMSD for generic
>> SSI slave state (e.g. the CS line state).
>
> This is more me being confused about h
On 6 August 2012 03:16, Peter A. G. Crosthwaite
wrote:
> Added default CS behaviour for SSI slaves. SSI devices can set a property
> to enable CS behaviour which will create a GPIO on the device which is the
> CS. Tristating of the bus on SSI transfers is implemented.
>
> Signed-off-by: Peter A. G
On 6 August 2012 03:16, Peter A. G. Crosthwaite
wrote:
> Slave creation function that can be used to create an SSI slave without
> qdev_init() being called. This give machine models a change to set properties.
Not convinced about this one -- I think that if machine models need to
do more complica
On 6 August 2012 03:16, Peter A. G. Crosthwaite
wrote:
> Allow multiple qdev_init_gpio_in() calls for the one device. The first call
> will
> define GPIOs 0-N-1, the next GPIOs N- ... . Allows different GPIOs to be
> handled
> with different handlers. Needed when two levels of the QOM class heir
On 6 August 2012 03:16, Peter A. G. Crosthwaite
wrote:
> To be more consistent with the newer ways of error signalling. That and SIGABT
> is easier to debug with than exit(1).
>
> Signed-off-by: Peter A. G. Crosthwaite
Reviewed-by: Peter Maydell
-- PMM
On 6 August 2012 03:16, Peter A. G. Crosthwaite
wrote:
> Added a FIFO API that can be used to create and operate byte FIFOs.
I'm not asking for actual conversions, but it would be nice to see a
list of some devices that could in principle be moved to using this FIFO,
as an indication of its gener
On 6 August 2012 03:16, Peter A. G. Crosthwaite
wrote:
> Added SPI controller to the reference design, with two n25q128 spi-flashes
> connected.
>
> Signed-off-by: Peter A. G. Crosthwaite
> ---
> hw/petalogix_ml605_mmu.c | 28 +++-
> 1 files changed, 27 insertions(+), 1
On 6 August 2012 04:25, Peter A. G. Crosthwaite
wrote:
> +static void sdhci_sdma_transfer_multi_blocks(SDHCIState *s)
> +{
> +bool page_aligned = false;
> +unsigned int n, begin;
> +const uint16_t block_size = s->blksize & 0x0fff;
> +uint32_t boundary_chk = 1 << (((s->blksize & 0x
On 6 August 2012 04:25, Peter A. G. Crosthwaite
wrote:
> +static uint64_t
> +exynos4210_sdhci_readfn(void *opaque, target_phys_addr_t offset, unsigned
> size)
> +{
> +Exynos4SDHCIState *s = (Exynos4SDHCIState *)opaque;
> +uint32_t ret;
> +
> +switch (offset & ~0x3) {
> +case SDHC
On 6 August 2012 04:25, Peter A. G. Crosthwaite
wrote:
> From: Igor Mitsyanko
>
> Device model for standard SD Host Controller Interface (SDHCI) compliant with
> version 2.00 of SD association specification.
> +typedef struct ADMADescr {
> +target_phys_addr_t addr;
> +uint16_t length;
>
On 6 August 2012 12:28, Igor Mitsyanko wrote:
> On 08/06/2012 02:30 PM, Peter Maydell wrote:
>>> +static void get_adma_description(SDHCIState *s, ADMADescr *dscr)
>>> +{
>>> +uint32_t adma1 = 0;
>>> +uint64_t adma2 = 0;
>>> +targe
Ping? Patchwork url: http://patchwork.ozlabs.org/patch/172731/
-- PMM
On 23 July 2012 19:06, Peter Maydell wrote:
> Fix the SNDCTL_DSP_MAP{IN,OUT}BUF ioctl definitions so that they
> refer to a suitably defined target struct layout rather than hardcoding
> the ioctl number. T
Ping?
Patchwork url: http://patchwork.ozlabs.org/patch/172732/
-- PMM
On 23 July 2012 19:07, Peter Maydell wrote:
> The code to initialise the target_to_host_errno_table[] array was
> accidentally inside the loop through checking and initialising all
> the supported ioctls. This was
Ping? Patchwork URL: http://patchwork.ozlabs.org/patch/172730/
let me know if you want a v2 patch rather than just hand-fixing
the signed-off-by line snafu.
thanks
-- PMM
On 23 July 2012 19:05, Peter Maydell wrote:
> The definitions for the ioctl numbers TARGET_BLKBSZGET and
> TARGET_BLK
e are a few other things that can cause us to terminate
> - the TB in the middel of an IT block:
> + the TB in the middle of an IT block:
> - Exception generating instructions (bkpt, swi, undefined).
> - Page boundaries.
> - H
Fix a variety of typos in comments in target-arm files.
Signed-off-by: Peter Maydell
---
Includes all the ones I spotted but not the 'middel' fix which
Peter C has already submitted a patch for, so the two patches
shouldn't conflict.
target-arm/arm-semi.c|2 +-
t
On 6 August 2012 17:33, Peter Maydell wrote:
> Fix a variety of typos in comments in target-arm files.
> -/* Handling addition overflow with 64 bits inputs values is more
> - * tricky than with 32 bits values. */
> +/* Handling addition overflow with 64 bit inputs values is more
Fix a variety of typos in comments in target-arm files.
Signed-off-by: Peter Maydell
---
Changes v1->v2: s/inputs values/input values/
target-arm/arm-semi.c|2 +-
target-arm/cpu.h |2 +-
target-arm/helper.c |6 +++---
target-arm/neon_helper.c |
Move the init of the irqchip_inject_ioctl field of KVMState out of
kvm_irqchip_create() and into kvm_init(), so that kvm_set_irq()
can be used even when no irqchip is created (for architectures
that support async interrupt notification even without an in
kernel irqchip).
Signed-off-by: Peter
On 7 August 2012 01:12, Peter Crosthwaite
wrote:
> On Mon, Aug 6, 2012 at 7:38 PM, Peter Maydell
> wrote:
>> On 6 August 2012 03:16, Peter A. G. Crosthwaite
>> wrote:
>>> +qemu_irq *all_irqs = g_new(qemu_irq, n + dev->num_gpio_in);
>>> +
On 6 August 2012 19:21, Phil Staub wrote:
> On Tue, Jun 12, 2012 at 10:28:14AM -0400, qemu-devel-requ...@nongnu.org wrote:
>> From: Richard Henderson
>> On 2012-06-07 18:04, Maciej W. Rozycki wrote:
>> > I have verified this change with system emulation running the GDB test
>> > suite for the mi
On 7 August 2012 13:19, Christian Borntraeger wrote:
> +#if defined(TARGET_HAS_USB) && (TARGET_HAS_USB == 1)
> /* init USB devices */
> if (usb_enabled) {
> if (foreach_device_config(DEV_USB, usb_parse) < 0)
> exit(1);
> }
> +#endif
Whether there is USB or not
allows us to remove
some ugly TARGET_I386 ifdefs from target-independent code.
I've also implemented the DUMP_FPU flag for ARM, by reinstating
(somewhat modified) some code which had been #if'd out for years.
There should be no behaviour change for other architectures.
Peter
printouts include FPU register contents and info about
QEMU's condition-code optimisations.
Signed-off-by: Peter Maydell
---
cpu-all.h|3 +++
cpu-exec.c |2 +-
cpus.c |6 +-
exec.c | 12 ++--
moni
s not done by eg the i386 cpu_dump_state().
This display is gated on the CPU_DUMP_FPU flag, as for x86.
Signed-off-by: Peter Maydell
---
target-arm/translate.c | 42 --
1 file changed, 16 insertions(+), 26 deletions(-)
diff --git a/target-arm/translate.c
On 2 August 2012 10:14, Jan Kiszka wrote:
> On 2012-07-26 16:35, Peter Maydell wrote:
>> This patch series removes all uses of kvm_irqchip_in_kernel()
>> from architecture-independent code, by creating a set of more
>> specific functions instead to test for the particular as
On 7 August 2012 20:26, Markus Armbruster wrote:
> qemu-system-arm lm3s811evb
> qemu-system-arm lm3s6965evb
> qemu-system-arm: /work/armbru/qemu/hw/qdev.c:310: qdev_get_gpio_in:
> Assertion `n >= 0 && n < dev->num_gpio_in' failed.
This is fixed by http://patchwork.ozlabs.org/patch/1728
On 7 August 2012 20:55, Markus Armbruster wrote:
> Anthony Liguori writes:
>> Perhaps we could add a QEMUMachine parameter that indicates that the
>> machine doesn't start without special options.
>
> Recommend to make it a string that lists the mandatory options.
How are you going to say "need
On 8 August 2012 01:00, Anthony Liguori wrote:
>
> They need a per machine hook before and after devices are created. This is
> okay and it turns out it can be handy for other machines too that do
> similiar could not exist outside of a simulator features.
If it's 'before and after device creati
On 8 August 2012 08:50, Markus Armbruster wrote:
> Markus Armbruster writes:
>> The string should be suitable for inserting into -help.
>
> Sufficiently common cases can also be delegated to generic code:
>
> * Maximum number of CPUs
>
> Got that: QEMUMachine member max_cpus, main() enforces it
On 8 August 2012 08:38, 陳韋任 (Wei-Ren Chen) wrote:
> Just for research, we are studying if we can leave the guest page
> table walk to underlying hardware rather than using software emulation
> (like current approach). So, maybe (if *doable*) we can use x86 hardware
> to help us to walk guest (li
On 7 August 2012 15:52, Cornelia Huck wrote:
> +static void sch_handle_clear_func(SubchDev *sch)
> +{
> +struct pmcw *p = &sch->curr_status.pmcw;
> +struct scsw *s = &sch->curr_status.scsw;
> +int path;
> +
> +/* Path management: In our simple css, we always choose the only path. *
On 8 August 2012 10:04, Markus Armbruster wrote:
> Next problem: minimum RAM size.
>
> For instance, -M pc -m X, where X < 32KiB dies "qemu: fatal: Trying to
> execute code outside RAM or ROM at [...] Aborted (core dumped)" with
> TCG, and "KVM internal error. Suberror: 1" with KVM.
>
> Should a m
On 8 August 2012 07:25, Liu Ping Fan wrote:
> +static inline void atomic_sub(int i, Atomic *v)
> +{
> +asm volatile("lock; subl %1,%0"
> + : "+m" (v->counter)
> + : "ir" (i));
> +}
NAK. We don't want random inline assembly implementations of locking
primitives in QEMU,
On 8 August 2012 07:25, Liu Ping Fan wrote:
> From: Liu Ping Fan
>
> lock:
> qemu_device_tree_mutex
Looking at where it's used, this doesn't seem to have anything to do
with device trees (ie dtb, see www.devicetree.org) : poorly named lock?
-- PMM
Ping?
patchwork url: http://patchwork.ozlabs.org/patch/173202/
-- PMM
On 25 July 2012 16:29, Peter Maydell wrote:
> Add asm-generic/kvm_para.h to the set of non-architecture specific
> KVM kernel headers we copy into QEMU. This header may be included
> by an architecture's kvm
On 8 August 2012 14:18, Paolo Bonzini wrote:
> Il 08/08/2012 15:09, Stefan Hajnoczi ha scritto:
>> No need to roll our own or copy the implementation from the kernel.
>
> To some extent we need to because:
>
> 1. GCC atomics look ugly, :) do not provide rmb/wmb, and in some
> versions of GCC mb is
On 31 July 2012 19:18, Igor Mitsyanko wrote:
> On 07/31/2012 06:56 PM, Peter Maydell wrote:
>> On 27 July 2012 20:29, Igor Mitsyanko wrote:
>>>
>>> +VMSTATE_BUFFER_MULTIPLY(wp_groups, SDState, 1, NULL, 0,
>>> wpgrps_size,
>>> +
On 8 August 2012 20:16, Blue Swirl wrote:
> On Wed, Aug 8, 2012 at 8:17 AM, Cornelia Huck
> wrote:
>> On Tue, 7 Aug 2012 21:00:59 +
>> Blue Swirl wrote:
>>> Please use more descriptive names instead of acronyms, for example
>>> SubChStatus.
>>
>> I'd rather leave these at the well-known sc
On 24 June 2012 00:07, Alexander Graf wrote:
> Due to popular demand, we're updating the way we generate the MPIC
> node and interrupt lines based on what the current state of art is.
Any chance of a slightly more detailed commit message?
thanks
-- PMM
On 8 August 2012 23:40, Peter Maydell wrote:
> On 24 June 2012 00:07, Alexander Graf wrote:
>> Due to popular demand, we're updating the way we generate the MPIC
>> node and interrupt lines based on what the current state of art is.
>
> Any chance of a slightly mo
Add support for saving/loading bitmap.h bitmaps in vmstate.
Signed-off-by: Peter Maydell
---
This will be needed for saving/restoring the bitmap in sd.c which
is introduced by Igor's latest patchset; the relevant VMSTATE line is:
VMSTATE_BITMAP(wp_groups, SDState, 1, wpgrps_size),
From: Christoffer Dall
Add basic support for KVM on ARM architecture.
Signed-off-by: Christoffer Dall
[Rusty: updates to use KVM_ARM_VCPU_INIT, KVM_GET/SET_MSRS]
Signed-off-by: Rusty Russell
[PMM: Minor tweaks and code cleanup]
Signed-off-by: Peter Maydell
---
hw/arm_pic.c
Add presave/postload hooks to the ARM GIC common base class.
These will be used by the KVM in-kernel GIC subclass to sync
state between kernel and userspace when migrating.
Signed-off-by: Peter Maydell
---
hw/arm_gic_common.c | 10 ++
hw/arm_gic_internal.h |2 ++
2 files changed
)
* the kernel ABI for sending per-CPU interrupts for VGIC vs non-VGIC
is inconsistent (the former uses a vcpu ioctl, the latter encodes
cpu number in the irq number), and we should standardise on one
approach or the other
Christoffer Dall (1):
ARM: KVM: Add support for KVM on ARM arch
Implement support for using the KVM in-kernel GIC for ARM.
Signed-off-by: Peter Maydell
---
hw/a15mpcore.c | 11 +++-
hw/arm/Makefile.objs |1 +
hw/kvm/arm_gic.c | 153 ++
3 files changed, 164 insertions(+), 1 deletion(-)
create
This commit adds the ARM KVM headers. This is not to go to QEMU
upstream -- the correct path there is that the KVM code will be
committed to a mainline upstream kernel, and then upstream QEMU
can do a bulk header update from the upstream kernel, which will
allow us to drop this temporary commit.
T
Enable KVM on ARM hosts, now that all the necessary components
for it exist.
Signed-off-by: Peter Maydell
---
configure |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/configure b/configure
index b9a0b27..f7a825a 100755
--- a/configure
+++ b/configure
@@ -3797,7 +3797,7
On 9 August 2012 14:31, Markus Armbruster wrote:
> We create a number of default drives for machines to use: floppy,
> CD-ROM, SD card. Machines can suppress the ones they don't use, but
> few do. Fix that.
For clarity: what are the negative effects that result from
machines not saying no_flopp
On 9 August 2012 15:08, Markus Armbruster wrote:
> Peter Maydell writes:
>> For clarity: what are the negative effects that result from
>> machines not saying no_floppy &c ?
>
> "info block" shows the unused default drives. For instance,
>
> $
On 4 August 2012 18:57, Blue Swirl wrote:
> On Sat, Jul 28, 2012 at 1:48 PM, Peter Maydell
> wrote:
>> On 28 July 2012 13:31, Blue Swirl wrote:
>>> I'm getting this error, probably because now Valgrind support is enabled:
>>> CCcoroutine-ucontext.o
On 9 August 2012 21:01, Phil Staub wrote:
> On 08/09/2012 12:57 PM, Blue Swirl wrote:
>> On Tue, Aug 7, 2012 at 12:10 PM, Peter Maydell
>> wrote:
>>> For this purpose the usual approach is to follow up to the patch
>>> mail saying "Ping" and giving a u
On 9 August 2012 21:31, Blue Swirl wrote:
> Configuring with Clang compiler with -Werror would not work after
> improved checks:
> /tmp/qemu-conf--25992-.c:4:32: error: self-comparison always evaluates
> to true [-Werror,-Wtautological-compare]
> int main(void) { return preadv == preadv; }
> /tmp/
On 9 August 2012 20:25, Eduardo Habkost wrote:
> On Fri, Aug 03, 2012 at 03:42:39PM -0500, Anthony Liguori wrote:
>> Peter Maydell writes:
>> > For command line options which permit '?' meaning 'please list the
>> > permitted values', add support f
On 10 August 2012 09:48, Andreas Färber wrote:
> Am 09.08.2012 22:36, schrieb Peter Maydell:
>> Maciej submitted some other MIPS patches at about the same time:
>> http://patchwork.ozlabs.org/project/qemu-devel/list/?submitter=4977
>> at least some of which got reviewed by
On 10 August 2012 09:53, Andreas Färber wrote:
> Am 10.08.2012 03:27, schrieb Peter A. G. Crosthwaite:
>> A -kernel argument must be specified for this machine. Gaurd against no
>> -kernel
>
> "Guard"
>
>> argument. Previously gave an unhelpful "bad address" error message.
>>
>> Signed-off-by: Pe
cumented and not used by libvirt,
simply drop them completely rather than reinstating them
with new style syntax. Instead, we fold the ?model and ?cpuid
output into the output of the plain "-cpu help" output. The
detailed output produced by ?dump is dropped.
Signed-of
Since the only user of the extended cpu_list_id() format
was the x86 ?model/?dump/?cpuid output, we can drop it
completely.
Signed-off-by: Peter Maydell
---
cpus.c|6 ++
linux-user/main.c |6 ++
target-i386/cpu.c |4 ++--
target-i386/cpu.h |4 ++--
4 files
are undocumented and not used by libvirt,
simply drop them completely rather than reinstating them
with new style syntax. Instead, we fold the ?model and ?cpuid
output into the output of the plain "-cpu help" output. The
detailed output produced by ?dump is dropped.
Peter Maydell (2):
targ
On 27 July 2012 20:29, Igor Mitsyanko wrote:
> Igor Mitsyanko (12):
> hw/sd.c: convert wp_groups in SDState to bitfield
> hw/sd.c: make sd_wp_addr() accept 64 bit address argument
> hw/sd.c: introduce wrapper for conversion address to wp group
> hw/sd.c: favour SD card type (SDSC or SDHC)
On 10 August 2012 03:11, Steven wrote:
> The function definition has a return address type tb_page_addr_t.
> tb_page_addr_t get_page_addr_code(CPUArchState *env1, target_ulong addr)
>
> I am wondering is this address the guest physical address or the host
> virtual address.
In linux-user mode the
The comment about the return address from get_page_addr_code() was
well out of date as phys_ram_base has not existed for some time.
Signed-off-by: Peter Maydell
---
cputlb.c |4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/cputlb.c b/cputlb.c
index 0d1e252..d3e7b25
Last call for any ARM related patches to go into 1.2. My current
queue looks like this:
59cbd70 hw/sd.c: make sd_wp_addr() return bool
8b4cc14 hw/sd.c: make sd_dataready() return bool
025caa6 hw/sd.c: convert binary variables to bool
38d24e6 hw/sd.c: introduce wrapper for conversion address to wp
On 10 August 2012 17:22, Igor Mitsyanko wrote:
> On 08/09/2012 03:54 PM, Peter Maydell wrote:
>> --- a/vmstate.h
>> +++ b/vmstate.h
>> @@ -139,6 +139,7 @@ extern const VMStateInfo vmstate_info_uint64;
>> extern const VMStateInfo vmstate_info_timer;
&g
On 10 August 2012 19:53, Steven wrote:
> On Fri, Aug 10, 2012 at 11:47 AM, Peter Maydell
> wrote:
>> On 10 August 2012 03:11, Steven wrote:
>>> The function definition has a return address type tb_page_addr_t.
>>> tb_page_addr_t get_page_addr_code(CPUArch
On 10 August 2012 20:48, Stefan Weil wrote:
> One more...
No problem with the patch but your commit message summary
implies a rather wider effect than the patch actually has :-)
-- PMM
On 18 July 2012 10:28, Peter Maydell wrote:
> On 12 March 2012 20:12, Stefan Weil wrote:
>> We also need more resources for technical maintenance of the
>> QEMU infrastructure. For example, the official mirror of the
>> QEMU git repository (https://github.com/qemu/QEMU)
[Karl: I've cc'd you because I think you were the person asking about this
on #qemu IRC yesterday. Apologies if I have the wrong person...]
I just had a go at building qemu on macos X (mountain lion). The good news
is I got something working, but I had to fiddle with stuff a bit:
* block/raw-posi
lf [-Werror,-Wself-assign]
> environ = environ;
>
> Avoid the errors by adjusting the tests.
>
> Signed-off-by: Blue Swirl
Reviewed-by: Peter Maydell
-- PMM
On 11 August 2012 00:31, Peter Crosthwaite
wrote:
> On Mon, Aug 6, 2012 at 7:41 PM, Peter Maydell
> wrote:
>> On 6 August 2012 03:16, Peter A. G. Crosthwaite
>> wrote:
>>> To be more consistent with the newer ways of error signalling. That and
>>> SIGABT
&
On 10 August 2012 18:15, Andreas Färber wrote:
> Am 02.08.2012 15:48, schrieb Peter Maydell:
>> On 2 August 2012 02:16, Andreas Färber wrote:
>>> +hw-obj-$(CONFIG_STELLARIS_ENET) += stellaris_enet.o
>>
>> Why just this stellaris device and not the others?
>
&g
.
Signed-off-by: Peter Maydell
---
This is what was causing 'make check' to fail on MacOS X.
The other option was to declare that a zero bytecount was illegal, I guess.
iov.c | 7 +++
1 file changed, 7 insertions(+)
diff --git a/iov.c b/iov.c
index b333061..60705c7 100644
--- a/i
default to clang
if we have it, otherwise whatever CC is (since gcc
might be the Apple gcc which does support Blocks).
Signed-off-by: Peter Maydell
---
configure | 12
rules.mak | 2 +-
2 files changed, 13 insertions(+), 1 deletion(-)
diff --git a/configure b/configure
index be4a2bb..
Frameworks/IOKit.framework/Headers/IOKitLib.h:56,
from block/raw-posix.c:35:
/System/Library/Frameworks/Foundation.framework/Headers/NSObjCRuntime.h:409:1:
error: stray ‘@’ in program
[with a large number of further run-on errors]
Signed-off-by: Peter Maydell
---
configure | 3 +++
1 file
n the cocoa ui frontend use the
'Blocks' Apple extension, so won't build except with clang or
the (now rapidly aging) Apple gcc, so to do a build with a
modern gcc we need to support specifying the Objective-C compiler
separately.
Peter Maydell (2):
configure: Define OS_O
On 12 August 2012 06:29, Michael Tokarev wrote:
> On 12.08.2012 01:24, Peter Maydell wrote:
>> POSIX allows sendmsg() and recvmsg() to fail EMSGSIZE if passed a zero
>> msg.msg_iovlen (in particular the MacOS X implementation will do this).
>
>> Handle the case where iov
Yes, threading does not work for i386 guests; this is a long-standing
issue. (See also bug 739785.)
--
You received this bug notification because you are a member of qemu-
devel-ml, which is subscribed to QEMU.
https://bugs.launchpad.net/bugs/1035572
Title:
Bug in Qemu User Mode
Status in QEM
Ping? I don't think this one quite made it into Avi's pullreq...
thanks
-- PMM
On 6 August 2012 18:05, Peter Maydell wrote:
> Move the init of the irqchip_inject_ioctl field of KVMState out of
> kvm_irqchip_create() and into kvm_init(), so that kvm_set_irq()
> can be used e
On 10 August 2012 17:04, Anthony Liguori wrote:
> This lets us provide a default implementation of a symbol which targets can
> override.
>
> Signed-off-by: Anthony Liguori
I'm sure you'll be thrilled to hear that this doesn't seem to break MacOS
builds :-)
-- PMM
Ping^2?
On 3 August 2012 13:55, Peter Maydell wrote:
> Ping?
>
> patchwork url: http://patchwork.ozlabs.org/patch/171628/
>
> -- PMM
>
> On 18 July 2012 11:11, Peter Maydell wrote:
>> Rather than hardcoding the list of architectures in the kernel
>> header updat
Ping^2 ?
On 8 August 2012 13:34, Peter Maydell wrote:
> Ping?
>
> patchwork url: http://patchwork.ozlabs.org/patch/173202/
>
> -- PMM
>
> On 25 July 2012 16:29, Peter Maydell wrote:
>> Add asm-generic/kvm_para.h to the set of non-architecture specific
>> KVM
On 27 July 2012 03:50, Meador Inge wrote:
> Signed-off-by: Meador Inge
Reviewed-by: Peter Maydell
-- PMM
way we can allocate it.
> + */
> +if (test_page_addr >= guest_base
> + && test_page_addr <= (guest_base + guest_size)) {
> + return -1;
> +}
The indent here is busted (hardcoded tabs), as checkpatch.pl will
tell you. Otherwise
Reviewed-by: Peter M
since most have implicit or explicit
>> dependencies on the CPU.
>>
>> Signed-off-by: Andreas Färber
>
> Err sorry, should be SoB . (Muphry's law!)
Reviewed-by: Peter Maydell
...last patch to make it under the wire for ARM for 1.2. Pullreq
coming out later today.
-- PMM
From: Mitsyanko Igor
Add wrapper function sd_addr_to_wpnum() to replace long address-->wg_group
conversion line.
Signed-off-by: Igor Mitsyanko
Signed-off-by: Peter Maydell
---
hw/sd.c | 27 +--
1 file changed, 13 insertions(+), 14 deletions(-)
diff --git a/hw/s
From: Mitsyanko Igor
Representing each group write protection flag with only one bit instead of int
variable significantly reduces memory consumption.
Signed-off-by: Igor Mitsyanko
Signed-off-by: Peter Maydell
---
hw/sd.c | 33 +++--
1 file changed, 19
On 13 August 2012 15:24, Anthony Liguori wrote:
> Peter Maydell writes:
>> [re patchwork url: http://patchwork.ozlabs.org/patch/173202/ ]
>> Ping^2 ?
>
> In a previous thread, we all agreed that all changes to linux headers
> would come in through uq/master to ensure that
From: "Peter A. G. Crosthwaite"
To be more consistent with the newer ways of error signalling. That and SIGABT
is easier to debug with than exit(1).
Signed-off-by: Peter A. G. Crosthwaite
Reviewed-by: Peter Maydell
Signed-off-by: Peter Maydell
---
hw/ssd0323.c |4 +++-
1 file
parent's Property array, we
define an instance_init function which runs after default setup
but before user property setting and can just fix up the default
value in the gic_state struct.
Reported-by: Peter Crosthwaite
Tested-by: Peter Crosthwaite
Signed-off-by: Peter Maydell
---
hw/armv7m_n
From: Mitsyanko Igor
Currently sd_wp_addr() accepts 32 bit address arguments therefore implicitly
restricting SD card address range. Change address argument type to uint64_t.
Signed-off-by: Igor Mitsyanko
Signed-off-by: Peter Maydell
---
hw/sd.c |2 +-
1 file changed, 1 insertion(+), 1
l argument
ssd0323: abort() instead of exit(1) on error.
Peter Maydell (1):
hw/armv7m_nvic: Fix incorrect default for num-irqs property
default-configs/arm-softmmu.mak | 18 ++
hw/Makefile.objs| 20 +++
hw/arm/Makefile.objs| 15 ++
From: Mitsyanko Igor
For the sake of code clarity
Signed-off-by: Igor Mitsyanko
Signed-off-by: Peter Maydell
---
hw/sd.c |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/hw/sd.c b/hw/sd.c
index 209bc19..ec26407 100644
--- a/hw/sd.c
+++ b/hw/sd.c
@@ -542,7 +542,7
From: Mitsyanko Igor
Several members of SDState have type int when they actually are binary
variables.
Change type of these variables to bool to improve code readability. Change SD
API
to be in consistency with new variables type.
Signed-off-by: Igor Mitsyanko
Reviewed-by: Peter Maydell
From: Andreas Färber
Avoids some unnecessary dependencies on cpu.h and prepares for
a future armeb-softmmu where most machines would not be built.
Defer touching the SoC devices since most have implicit or explicit
dependencies on the CPU.
Signed-off-by: Andreas Färber
Signed-off-by: Peter
From: "Peter A. G. Crosthwaite"
A -kernel argument must be specified for this machine. Guard against no -kernel
argument. Previously gave an unhelpful "bad address" error message.
Signed-off-by: Peter A. G. Crosthwaite
Tested-by: Markus Armbruster
Signed-off-by: Pe
From: Mitsyanko Igor
For the sake of code clarity
Signed-off-by: Igor Mitsyanko
Reviewed-by: Peter Maydell
Signed-off-by: Peter Maydell
---
hw/sd.c |2 +-
hw/sd.h |2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/hw/sd.c b/hw/sd.c
index ebc4e7c..209bc19 100644
On 13 August 2012 21:45, Marcelo Tosatti wrote:
> On Sun, Aug 12, 2012 at 02:13:52PM +0100, Peter Maydell wrote:
>> Ping? I don't think this one quite made it into Avi's pullreq...
>
> Please post this with the rest of the code to support the new
> s->irqchip_inj
On 14 August 2012 08:33, Jan Kiszka wrote:
> Either you move both or none.
OK.
> KVM_IRQ_LINE is old-style, deprecated, KVM_IRQ_LINE_STATUS (i.e
> injection with feedback to allow lost-tick compensation) is the current
> standard that other archs should pick up.
Can it be documented in the kern
1 - 100 of 55231 matches
Mail list logo
