RE: [PATCH 2/2] igb: Add Function Level Reset to PF and VF

2023-08-30 Thread Sriram Yagnaraman
> -Original Message- > From: Cédric Le Goater > Sent: Tuesday, 29 August 2023 11:05 > To: qemu-devel@nongnu.org > Cc: Akihiko Odaki ; Sriram Yagnaraman > ; Jason Wang ; Cédric > Le Goater > Subject: [PATCH 2/2] igb: Add Function Level Reset to PF and VF >

RE: [PATCH 1/2] igb: Add a VF reset handler

2023-08-30 Thread Sriram Yagnaraman
> -Original Message- > From: Cédric Le Goater > Sent: Tuesday, 29 August 2023 11:05 > To: qemu-devel@nongnu.org > Cc: Akihiko Odaki ; Sriram Yagnaraman > ; Jason Wang ; Cédric > Le Goater > Subject: [PATCH 1/2] igb: Add a VF reset handler > > From:

[PATCH 5/5] hw/net/igb: build support for igb/igbvf devices

2022-12-22 Thread Sriram Yagnaraman
Signed-off-by: Sriram Yagnaraman --- hw/i386/Kconfig| 1 + hw/net/Kconfig | 5 + hw/net/igb_core.c | 4 +--- hw/net/meson.build | 2 ++ 4 files changed, 9 insertions(+), 3 deletions(-) diff --git a/hw/i386/Kconfig b/hw/i386/Kconfig index d22ac4a4b9..97a0b08842 100644 --- a/hw/i386

[PATCH 0/5] hw/net/igb: emulated network device with SR-IOV

2022-12-22 Thread Sriram Yagnaraman
=xcbr3_t2,queues=1 \ -device igb,bus=pcie_port.3,netdev=net3,mac=00:00:00:01:03:02 Load IGB/IGBVF modules if needed. modprobe igb modprobe igbvf Create VFs via /sys ls /sys/bus/pci/devices/:01:00.0/ echo 2 > /sys/bus/pci/devices/:01:00.0/sriov_numvfs Sriram Yagnaraman (5): p

[PATCH 2/5] hw/net/net_tx_pkt: helper function to get l2 hdr

2022-12-22 Thread Sriram Yagnaraman
Also add return value for to send functions Signed-off-by: Sriram Yagnaraman --- hw/net/net_tx_pkt.c | 17 +++-- hw/net/net_tx_pkt.h | 8 2 files changed, 19 insertions(+), 6 deletions(-) diff --git a/hw/net/net_tx_pkt.c b/hw/net/net_tx_pkt.c index 1cb1125d9f..f2e14008b6

[PATCH 3/5] hw/net/igb: register definitions

2022-12-22 Thread Sriram Yagnaraman
Signed-off-by: Sriram Yagnaraman --- hw/net/e1000_regs.h| 363 + hw/net/e1000x_common.c | 13 ++ hw/net/e1000x_common.h | 29 3 files changed, 376 insertions(+), 29 deletions(-) diff --git a/hw/net/e1000_regs.h b/hw/net/e1000_regs.h index

[PATCH 1/5] pcie: add helper function to get number of VFs

2022-12-22 Thread Sriram Yagnaraman
Signed-off-by: Sriram Yagnaraman --- hw/pci/pcie_sriov.c | 6 ++ include/hw/pci/pcie_sriov.h | 5 + 2 files changed, 11 insertions(+) diff --git a/hw/pci/pcie_sriov.c b/hw/pci/pcie_sriov.c index 8e3faf1f59..88ba642a20 100644 --- a/hw/pci/pcie_sriov.c +++ b/hw/pci/pcie_sriov.c

[PATCH v2 5/6] hw/net/igb: build support for igb/igbvf devices

2022-12-29 Thread Sriram Yagnaraman
Signed-off-by: Sriram Yagnaraman --- hw/i386/Kconfig| 1 + hw/net/Kconfig | 5 + hw/net/igb_core.c | 4 +--- hw/net/meson.build | 2 ++ 4 files changed, 9 insertions(+), 3 deletions(-) diff --git a/hw/i386/Kconfig b/hw/i386/Kconfig index d22ac4a4b9..97a0b08842 100644 --- a/hw/i386

[PATCH v2 3/6] hw/net/igb: register definitions

2022-12-29 Thread Sriram Yagnaraman
Signed-off-by: Sriram Yagnaraman --- hw/net/e1000_regs.h| 363 + hw/net/e1000x_common.c | 13 ++ hw/net/e1000x_common.h | 29 3 files changed, 376 insertions(+), 29 deletions(-) diff --git a/hw/net/e1000_regs.h b/hw/net/e1000_regs.h index

RE: [PATCH 0/5] hw/net/igb: emulated network device with SR-IOV

2022-12-29 Thread Sriram Yagnaraman
> -Original Message- > From: Jason Wang > Sent: Friday, 23 December 2022 04:24 > To: Sriram Yagnaraman > Cc: qemu-devel@nongnu.org; Dmitry Fleytman > ; Michael S . Tsirkin ; > Marcel Apfelbaum > Subject: Re: [PATCH 0/5] hw/net/igb: emulated network device with SR

[PATCH v2 0/6] hw/net/igb: emulated network device with SR-IOV

2022-12-29 Thread Sriram Yagnaraman
est for igb Sriram Yagnaraman (6): pcie: add helper function to get number of VFs hw/net/net_tx_pkt: helper function to get l2 hdr hw/net/igb: register definitions hw/net/igb: emulated intel IGB (82576EB) network device hw/net/igb: build support for igb/igbvf devices tests/qtest/igb-t

[PATCH v2 1/6] pcie: add helper function to get number of VFs

2022-12-29 Thread Sriram Yagnaraman
Signed-off-by: Sriram Yagnaraman --- hw/pci/pcie_sriov.c | 6 ++ include/hw/pci/pcie_sriov.h | 5 + 2 files changed, 11 insertions(+) diff --git a/hw/pci/pcie_sriov.c b/hw/pci/pcie_sriov.c index 8e3faf1f59..88ba642a20 100644 --- a/hw/pci/pcie_sriov.c +++ b/hw/pci/pcie_sriov.c

RE: [PATCH 0/5] hw/net/igb: emulated network device with SR-IOV

2022-12-29 Thread Sriram Yagnaraman
> -Original Message- > From: Akihiko Odaki > Sent: Thursday, 29 December 2022 03:43 > To: Jason Wang ; Sriram Yagnaraman > > Cc: qemu-devel@nongnu.org; Dmitry Fleytman > ; Michael S . Tsirkin ; > Marcel Apfelbaum ; Yan Vugenfirer > > Subject: Re: [PATCH 0/5

[PATCH v2 6/6] tests/qtest/igb-test: introduce qtest for igb

2022-12-29 Thread Sriram Yagnaraman
: + * Sriram Yagnaraman + * + * Based on work done by: + * Knut Omang. + * + * This library is free software; you can redistribute it and/or + * modify it under the terms of the GNU Lesser General Public + * License as published by the Free Software Foundation; either + * version 2.1 of the License

[PATCH v2 2/6] hw/net/net_tx_pkt: helper function to get l2 hdr

2022-12-29 Thread Sriram Yagnaraman
Also add return value for to send functions Signed-off-by: Sriram Yagnaraman --- hw/net/net_tx_pkt.c | 17 +++-- hw/net/net_tx_pkt.h | 8 2 files changed, 19 insertions(+), 6 deletions(-) diff --git a/hw/net/net_tx_pkt.c b/hw/net/net_tx_pkt.c index 1cb1125d9f..f2e14008b6

RE: [PATCH 0/5] hw/net/igb: emulated network device with SR-IOV

2022-12-30 Thread Sriram Yagnaraman
> -Original Message- > From: Jason Wang > Sent: Friday, 30 December 2022 04:45 > To: Sriram Yagnaraman > Cc: qemu-devel@nongnu.org; Dmitry Fleytman > ; Michael S . Tsirkin ; > Marcel Apfelbaum > Subject: Re: [PATCH 0/5] hw/net/igb: emulated network device with SR

RE: [PATCH v2 00/13] Introduce igb

2023-01-17 Thread Sriram Yagnaraman
ntation. > > > > Note that there is another effort to bring 82576 emulation. This > > series was developed independently by Sriram Yagnaraman. > > https://lists.gnu.org/archive/html/qemu-devel/2022-12/msg04670.html > > > > It is possible to merge the work from Sriram Yagnaraman

RE: [PATCH v2 00/13] Introduce igb

2023-01-24 Thread Sriram Yagnaraman
> -Original Message- > From: Akihiko Odaki > Sent: Tuesday, 24 January 2023 05:54 > To: Jason Wang ; Sriram Yagnaraman > > Cc: Dmitry Fleytman ; Michael S. Tsirkin > ; Marcel Apfelbaum ; > Alex Bennée ; Philippe Mathieu-Daudé > ; Thomas Huth ; Wainer dos S

RE: [PATCH v2 00/13] Introduce igb

2023-01-26 Thread Sriram Yagnaraman
> -Original Message- > From: Sriram Yagnaraman > Sent: Tuesday, 24 January 2023 09:54 > To: Akihiko Odaki ; Jason Wang > > Cc: Dmitry Fleytman ; Michael S. Tsirkin > ; Marcel Apfelbaum ; > Alex Bennée ; Philippe Mathieu-Daudé > ; Thomas Huth ; Wainer dos Santos

[PATCH v2 6/9] igb: respect E1000_VMOLR_RSSE

2023-01-30 Thread Sriram Yagnaraman
RSS for VFs is only enabled if VMOLR[n].RSSE is set. Signed-off-by: Sriram Yagnaraman --- hw/net/igb_core.c | 9 - 1 file changed, 8 insertions(+), 1 deletion(-) diff --git a/hw/net/igb_core.c b/hw/net/igb_core.c index 89650fcfd4..b41b1a5d21 100644 --- a/hw/net/igb_core.c +++ b/hw/net

[PATCH v2 4/9] igb: add ICR_RXDW

2023-01-30 Thread Sriram Yagnaraman
IGB uses RXDW ICR bit to indicate that rx descriptor has been written back. This is the same as RXT0 bit in older HW. Signed-off-by: Sriram Yagnaraman --- hw/net/e1000x_regs.h | 4 hw/net/igb_core.c| 28 ++-- 2 files changed, 18 insertions(+), 14 deletions

[PATCH v2 1/9] MAINTAINERS: Add Sriram Yagnaraman as a igb reviewer

2023-01-30 Thread Sriram Yagnaraman
I would like to review and be informed on changes to igb device Signed-off-by: Sriram Yagnaraman --- MAINTAINERS | 1 + 1 file changed, 1 insertion(+) diff --git a/MAINTAINERS b/MAINTAINERS index ece23b2b15..7d0e84ce37 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -2224,6 +2224,7 @@ F: tests

[PATCH v2 9/9] igb: respect VMVIR and VMOLR for VLAN

2023-01-30 Thread Sriram Yagnaraman
Add support for stripping/inserting VLAN for VFs. Signed-off-by: Sriram Yagnaraman --- hw/net/igb_core.c | 84 ++- 1 file changed, 54 insertions(+), 30 deletions(-) diff --git a/hw/net/igb_core.c b/hw/net/igb_core.c index 5ca666229e..a511c64773

[PATCH v2 3/9] igb: implement VFRE and VFTE registers

2023-01-30 Thread Sriram Yagnaraman
Also add checks for RXDCTL/TXDCTL queue enable bits Signed-off-by: Sriram Yagnaraman --- hw/net/igb_core.c | 41 ++--- hw/net/igb_regs.h | 4 +++- 2 files changed, 33 insertions(+), 12 deletions(-) diff --git a/hw/net/igb_core.c b/hw/net/igb_core.c index

[PATCH v2 2/9] igb: handle PF/VF reset properly

2023-01-30 Thread Sriram Yagnaraman
Use PFRSTD to reset RSTI bit for VFs, and raise VFLRE interrupt when VF is reset. Signed-off-by: Sriram Yagnaraman --- hw/net/e1000x_regs.h | 1 + hw/net/igb_core.c| 33 + hw/net/trace-events | 2 ++ 3 files changed, 24 insertions(+), 12 deletions(-) diff

[PATCH v2 5/9] igb: check oversized packets for VMDq

2023-01-30 Thread Sriram Yagnaraman
Signed-off-by: Sriram Yagnaraman --- hw/net/igb_core.c | 48 +++ 1 file changed, 40 insertions(+), 8 deletions(-) diff --git a/hw/net/igb_core.c b/hw/net/igb_core.c index cea7c036f0..89650fcfd4 100644 --- a/hw/net/igb_core.c +++ b/hw/net/igb_core.c

RE: [PATCH 3/9] igb: implement VFRE and VFTE registers

2023-01-30 Thread Sriram Yagnaraman
> -Original Message- > From: Akihiko Odaki > Sent: Sunday, 29 January 2023 10:16 > To: Sriram Yagnaraman > Cc: qemu-devel@nongnu.org; Jason Wang ; Dmitry > Fleytman ; Michael S . Tsirkin > ; Marcel Apfelbaum > Subject: Re: [PATCH 3/9] igb: implement

[PATCH v2 8/9] igb: respect VT_CTL ignore MAC field

2023-01-30 Thread Sriram Yagnaraman
Also trace out a warning if replication mode is disabled, since we only support replication mode enabled. Signed-off-by: Sriram Yagnaraman --- hw/net/igb_core.c | 9 + hw/net/trace-events | 2 ++ 2 files changed, 11 insertions(+) diff --git a/hw/net/igb_core.c b/hw/net/igb_core.c

[PATCH v2 0/9] igb: merge changes from <20221229190817.25500-1-sriram.yagnara...@est.tech>

2023-01-30 Thread Sriram Yagnaraman
s from Akihiko Sriram Yagnaraman (9): MAINTAINERS: Add Sriram Yagnaraman as a igb reviewer igb: handle PF/VF reset properly igb: implement VFRE and VFTE registers igb: add ICR_RXDW igb: check oversized packets for VMDq igb: respect E1000_VMOLR_RSSE igb: implement VF Tx and Rx stats

[PATCH v2 7/9] igb: implement VF Tx and Rx stats

2023-01-30 Thread Sriram Yagnaraman
Please note that loopback counters for VM to VM traffic is not implemented yet: VFGOTLBC, VFGPTLBC, VFGORLBC and VFGPRLBC. Signed-off-by: Sriram Yagnaraman --- hw/net/igb_core.c | 26 ++ 1 file changed, 22 insertions(+), 4 deletions(-) diff --git a/hw/net/igb_core.c b

RE: [PATCH 5/9] igb: respect E1000_VMOLR_RSSE

2023-01-30 Thread Sriram Yagnaraman
> -Original Message- > From: Akihiko Odaki > Sent: Sunday, 29 January 2023 08:25 > To: Sriram Yagnaraman > Cc: qemu-devel@nongnu.org; Jason Wang ; Dmitry > Fleytman ; Michael S . Tsirkin > ; Marcel Apfelbaum > Subject: Re: [PATCH 5/9] igb: respect E1000_VMOLR_RS

[PATCH v3 5/9] igb: check oversized packets for VMDq

2023-01-31 Thread Sriram Yagnaraman
Signed-off-by: Sriram Yagnaraman --- hw/net/igb_core.c | 48 +++ 1 file changed, 40 insertions(+), 8 deletions(-) diff --git a/hw/net/igb_core.c b/hw/net/igb_core.c index 4a1b98bf0e..2f6f30341f 100644 --- a/hw/net/igb_core.c +++ b/hw/net/igb_core.c

[PATCH v3 4/9] igb: implement VFRE and VFTE registers

2023-01-31 Thread Sriram Yagnaraman
Also add checks for RXDCTL/TXDCTL queue enable bits Signed-off-by: Sriram Yagnaraman --- hw/net/igb_core.c | 30 +- hw/net/igb_core.h | 1 + hw/net/igb_regs.h | 3 +++ 3 files changed, 29 insertions(+), 5 deletions(-) diff --git a/hw/net/igb_core.c b/hw/net

[PATCH v3 0/9] igb: merge changes from <20221229190817.25500-1-sriram.yagnara...@est.tech>

2023-01-31 Thread Sriram Yagnaraman
Akhiko - Reordered the patches to make changes easier to understand Changes since v1: - Fix review comments from Akihiko Sriram Yagnaraman (9): MAINTAINERS: Add Sriram Yagnaraman as a igb reviewer igb: handle PF/VF reset properly igb: add ICR_RXDW igb: implement VFRE and VFTE registers

[PATCH v3 8/9] igb: respect VT_CTL ignore MAC field

2023-01-31 Thread Sriram Yagnaraman
Also trace out a warning if replication mode is disabled, since we only support replication mode enabled. Signed-off-by: Sriram Yagnaraman --- hw/net/igb_core.c | 9 + hw/net/trace-events | 2 ++ 2 files changed, 11 insertions(+) diff --git a/hw/net/igb_core.c b/hw/net/igb_core.c

[PATCH v3 6/9] igb: respect E1000_VMOLR_RSSE

2023-01-31 Thread Sriram Yagnaraman
RSS for VFs is only enabled if VMOLR[n].RSSE is set. Signed-off-by: Sriram Yagnaraman --- hw/net/igb_core.c | 9 - 1 file changed, 8 insertions(+), 1 deletion(-) diff --git a/hw/net/igb_core.c b/hw/net/igb_core.c index 2f6f30341f..31a325d374 100644 --- a/hw/net/igb_core.c +++ b/hw/net

[PATCH v3 1/9] MAINTAINERS: Add Sriram Yagnaraman as a igb reviewer

2023-01-31 Thread Sriram Yagnaraman
I would like to review and be informed on changes to igb device Signed-off-by: Sriram Yagnaraman --- MAINTAINERS | 1 + 1 file changed, 1 insertion(+) diff --git a/MAINTAINERS b/MAINTAINERS index ece23b2b15..7d0e84ce37 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -2224,6 +2224,7 @@ F: tests

[PATCH v3 7/9] igb: implement VF Tx and Rx stats

2023-01-31 Thread Sriram Yagnaraman
Please note that loopback counters for VM to VM traffic is not implemented yet: VFGOTLBC, VFGPTLBC, VFGORLBC and VFGPRLBC. Signed-off-by: Sriram Yagnaraman --- hw/net/igb_core.c | 26 ++ 1 file changed, 22 insertions(+), 4 deletions(-) diff --git a/hw/net/igb_core.c b

[PATCH v3 3/9] igb: add ICR_RXDW

2023-01-31 Thread Sriram Yagnaraman
IGB uses RXDW ICR bit to indicate that rx descriptor has been written back. This is the same as RXT0 bit in older HW. Signed-off-by: Sriram Yagnaraman --- hw/net/e1000x_regs.h | 4 hw/net/igb_core.c| 46 +--- 2 files changed, 22 insertions

[PATCH v3 2/9] igb: handle PF/VF reset properly

2023-01-31 Thread Sriram Yagnaraman
Use PFRSTD to reset RSTI bit for VFs, and raise VFLRE interrupt when VF is reset. Signed-off-by: Sriram Yagnaraman --- hw/net/igb_core.c | 33 + hw/net/igb_regs.h | 3 +++ hw/net/trace-events | 2 ++ 3 files changed, 26 insertions(+), 12 deletions(-) diff

[PATCH v3 9/9] igb: respect VMVIR and VMOLR for VLAN

2023-01-31 Thread Sriram Yagnaraman
Add support for stripping/inserting VLAN for VFs. Signed-off-by: Sriram Yagnaraman --- hw/net/igb_core.c | 51 ++- 1 file changed, 42 insertions(+), 9 deletions(-) diff --git a/hw/net/igb_core.c b/hw/net/igb_core.c index 8115be2d76..a697fcf56a 100644

RE: [PATCH v2 00/13] Introduce igb

2023-01-31 Thread Sriram Yagnaraman
> -Original Message- > From: Akihiko Odaki > Sent: Monday, 30 January 2023 15:39 > To: Sriram Yagnaraman ; Jason Wang > > Cc: Dmitry Fleytman ; Michael S. Tsirkin > ; Marcel Apfelbaum ; > Alex Bennée ; Philippe Mathieu-Daudé > ; Thomas Huth ; Wainer dos S

[PATCH 8/9] igb: respect VT_CTL ignore MAC field

2023-01-28 Thread Sriram Yagnaraman
Also trace out a warning if replication mode is disabled, since we only support replication mode enabled. Signed-off-by: Sriram Yagnaraman --- hw/net/igb_core.c | 9 + hw/net/trace-events | 2 ++ 2 files changed, 11 insertions(+) diff --git a/hw/net/igb_core.c b/hw/net/igb_core.c

[PATCH 2/9] igb: handle PF/VF reset properly

2023-01-28 Thread Sriram Yagnaraman
Use PFRSTD to reset RSTI bit for VFs, and raise VFLRE interrupt when VF is reset. Signed-off-by: Sriram Yagnaraman --- hw/net/e1000x_regs.h | 1 + hw/net/igb_core.c| 33 + hw/net/trace-events | 2 ++ 3 files changed, 24 insertions(+), 12 deletions(-) diff

[PATCH 5/9] igb: respect E1000_VMOLR_RSSE

2023-01-28 Thread Sriram Yagnaraman
RSS for VFs is only enabled if VMOLR[n].RSSE is set. Signed-off-by: Sriram Yagnaraman --- hw/net/igb_core.c | 18 +- 1 file changed, 13 insertions(+), 5 deletions(-) diff --git a/hw/net/igb_core.c b/hw/net/igb_core.c index 1eb7ba168f..e4fd4a1a5f 100644 --- a/hw/net/igb_core.c

[PATCH 6/9] igb: add ICR_RXDW

2023-01-28 Thread Sriram Yagnaraman
IGB uses RXDW ICR bit to indicate that rx descriptor has been written back. This is the same as RXT0 bit in older HW. Signed-off-by: Sriram Yagnaraman --- hw/net/e1000x_regs.h | 4 hw/net/igb_core.c| 4 ++-- 2 files changed, 6 insertions(+), 2 deletions(-) diff --git a/hw/net

[PATCH 9/9] igb: respect VMVIR and VMOLR for VLAN

2023-01-28 Thread Sriram Yagnaraman
Add support for stripping/inserting VLAN for VFs. Signed-off-by: Sriram Yagnaraman --- hw/net/igb_core.c | 100 ++ 1 file changed, 65 insertions(+), 35 deletions(-) diff --git a/hw/net/igb_core.c b/hw/net/igb_core.c index 8e33e15505..96a5c5eca3

RE: [PATCH v2 00/13] Introduce igb

2023-01-28 Thread Sriram Yagnaraman
> -Original Message- > From: Akihiko Odaki > Sent: Thursday, 26 January 2023 12:32 > To: Sriram Yagnaraman ; Jason Wang > > Cc: Dmitry Fleytman ; Michael S. Tsirkin > ; Marcel Apfelbaum ; > Alex Bennée ; Philippe Mathieu-Daudé > ; Thomas Huth ; Wainer dos S

[PATCH 1/9] MAINTAINERS: Add Sriram Yagnaraman as a igb reviewer

2023-01-28 Thread Sriram Yagnaraman
I would like to review and be informed on changes to igb device Signed-off-by: Sriram Yagnaraman --- MAINTAINERS | 1 + 1 file changed, 1 insertion(+) diff --git a/MAINTAINERS b/MAINTAINERS index ece23b2b15..7d0e84ce37 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -2224,6 +2224,7 @@ F: tests

[PATCH 3/9] igb: implement VFRE and VFTE registers

2023-01-28 Thread Sriram Yagnaraman
Also add checks for RXDCTL/TXDCTL queue enable bits Signed-off-by: Sriram Yagnaraman --- hw/net/igb_core.c | 42 +++--- hw/net/igb_regs.h | 3 ++- 2 files changed, 33 insertions(+), 12 deletions(-) diff --git a/hw/net/igb_core.c b/hw/net/igb_core.c index

[PATCH 4/9] igb: check oversized packets for VMDq

2023-01-28 Thread Sriram Yagnaraman
Signed-off-by: Sriram Yagnaraman --- hw/net/igb_core.c | 74 ++- 1 file changed, 54 insertions(+), 20 deletions(-) diff --git a/hw/net/igb_core.c b/hw/net/igb_core.c index 6bca5459b9..1eb7ba168f 100644 --- a/hw/net/igb_core.c +++ b/hw/net/igb_core.c

[PATCH 7/9] igb: implement VF Tx and Rx stats

2023-01-28 Thread Sriram Yagnaraman
Please note that loopback counters for VM to VM traffic is not implemented yet: VFGOTLBC, VFGPTLBC, VFGORLBC and VFGPRLBC. Signed-off-by: Sriram Yagnaraman --- hw/net/igb_core.c | 31 ++- 1 file changed, 26 insertions(+), 5 deletions(-) diff --git a/hw/net

[PATCH 0/9] igb: add missing feature set from

2023-01-28 Thread Sriram Yagnaraman
Based-on: <20230126111943.38695-1-akihiko.od...@daynix.com> ([PATCH v4 00/13] Introduce igb) Rebased on latest changes from Akihiko, and merged changes from my original patchset: https://lists.gnu.org/archive/html/qemu-devel/2022-12/msg04670.html Sriram Yagnaraman (9): MAINTAINERS: Add

[PATCH v4 3/9] igb: add ICR_RXDW

2023-02-01 Thread Sriram Yagnaraman
IGB uses RXDW ICR bit to indicate that rx descriptor has been written back. This is the same as RXT0 bit in older HW. Signed-off-by: Sriram Yagnaraman --- hw/net/e1000x_regs.h | 4 hw/net/igb_core.c| 2 +- 2 files changed, 5 insertions(+), 1 deletion(-) diff --git a/hw/net

[PATCH v4 2/9] igb: handle PF/VF reset properly

2023-02-01 Thread Sriram Yagnaraman
Use PFRSTD to reset RSTI bit for VFs, and raise VFLRE interrupt when VF is reset. Signed-off-by: Sriram Yagnaraman --- hw/net/igb_core.c | 33 + hw/net/igb_regs.h | 3 +++ hw/net/trace-events | 2 ++ 3 files changed, 26 insertions(+), 12 deletions(-) diff

RE: [PATCH v3 8/9] igb: respect VT_CTL ignore MAC field

2023-02-01 Thread Sriram Yagnaraman
> -Original Message- > From: Akihiko Odaki > Sent: Wednesday, 1 February 2023 14:03 > To: Sriram Yagnaraman > Cc: qemu-devel@nongnu.org; Jason Wang ; Dmitry > Fleytman ; Michael S . Tsirkin > ; Marcel Apfelbaum > Subject: Re: [PATCH v3 8/9] igb: respect

[PATCH v5 3/8] igb: add ICR_RXDW

2023-02-01 Thread Sriram Yagnaraman
IGB uses RXDW ICR bit to indicate that rx descriptor has been written back. This is the same as RXT0 bit in older HW. Signed-off-by: Sriram Yagnaraman --- hw/net/e1000x_regs.h | 4 hw/net/igb_core.c| 2 +- 2 files changed, 5 insertions(+), 1 deletion(-) diff --git a/hw/net

[PATCH v5 2/8] igb: handle PF/VF reset properly

2023-02-01 Thread Sriram Yagnaraman
Use PFRSTD to reset RSTI bit for VFs, and raise VFLRE interrupt when VF is reset. Signed-off-by: Sriram Yagnaraman --- hw/net/igb_core.c | 33 + hw/net/igb_regs.h | 3 +++ hw/net/trace-events | 2 ++ 3 files changed, 26 insertions(+), 12 deletions(-) diff

[PATCH v5 0/8] igb: merge changes from <20221229190817.25500-1-sriram.yagnara...@est.tech>

2023-02-01 Thread Sriram Yagnaraman
Akhiko - Reordered the patches to make changes easier to understand Changes since v1: - Fix review comments from Akihiko Sriram Yagnaraman (8): MAINTAINERS: Add Sriram Yagnaraman as a igb reviewer igb: handle PF/VF reset properly igb: add ICR_RXDW igb: implement VFRE and VFTE registers igb:

[PATCH v5 6/8] igb: respect E1000_VMOLR_RSSE

2023-02-01 Thread Sriram Yagnaraman
RSS for VFs is only enabled if VMOLR[n].RSSE is set. Signed-off-by: Sriram Yagnaraman --- hw/net/igb_core.c | 9 - 1 file changed, 8 insertions(+), 1 deletion(-) diff --git a/hw/net/igb_core.c b/hw/net/igb_core.c index eab140070b..9bedaa1e5f 100644 --- a/hw/net/igb_core.c +++ b/hw/net

[PATCH v5 7/8] igb: implement VF Tx and Rx stats

2023-02-01 Thread Sriram Yagnaraman
Please note that loopback counters for VM to VM traffic is not implemented yet: VFGOTLBC, VFGPTLBC, VFGORLBC and VFGPRLBC. Signed-off-by: Sriram Yagnaraman --- hw/net/igb_core.c | 26 ++ 1 file changed, 22 insertions(+), 4 deletions(-) diff --git a/hw/net/igb_core.c b

[PATCH v5 1/8] MAINTAINERS: Add Sriram Yagnaraman as a igb reviewer

2023-02-01 Thread Sriram Yagnaraman
I would like to review and be informed on changes to igb device Signed-off-by: Sriram Yagnaraman --- MAINTAINERS | 1 + 1 file changed, 1 insertion(+) diff --git a/MAINTAINERS b/MAINTAINERS index ece23b2b15..7d0e84ce37 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -2224,6 +2224,7 @@ F: tests

[PATCH v5 4/8] igb: implement VFRE and VFTE registers

2023-02-01 Thread Sriram Yagnaraman
Also introduce: - Checks for RXDCTL/TXDCTL queue enable bits - IGB_NUM_VM_POOLS enum (Sec 1.5: Table 1-7) Signed-off-by: Sriram Yagnaraman --- hw/net/igb_core.c | 39 +++ hw/net/igb_core.h | 1 + hw/net/igb_regs.h | 3 +++ 3 files changed, 35 insertions

[PATCH v6 6/8] igb: respect E1000_VMOLR_RSSE

2023-02-02 Thread Sriram Yagnaraman
RSS for VFs is only enabled if VMOLR[n].RSSE is set. Signed-off-by: Sriram Yagnaraman --- hw/net/igb_core.c | 9 - 1 file changed, 8 insertions(+), 1 deletion(-) diff --git a/hw/net/igb_core.c b/hw/net/igb_core.c index 03139c76f7..9994724a39 100644 --- a/hw/net/igb_core.c +++ b/hw/net

[PATCH v6 7/8] igb: implement VF Tx and Rx stats

2023-02-02 Thread Sriram Yagnaraman
Please note that loopback counters for VM to VM traffic is not implemented yet: VFGOTLBC, VFGPTLBC, VFGORLBC and VFGPRLBC. Signed-off-by: Sriram Yagnaraman --- hw/net/igb_core.c | 26 ++ 1 file changed, 22 insertions(+), 4 deletions(-) diff --git a/hw/net/igb_core.c b

[PATCH v6 4/8] igb: implement VFRE and VFTE registers

2023-02-02 Thread Sriram Yagnaraman
Also introduce: - Checks for RXDCTL/TXDCTL queue enable bits - IGB_NUM_VM_POOLS enum (Sec 1.5: Table 1-7) Signed-off-by: Sriram Yagnaraman --- hw/net/igb_core.c | 38 +++--- hw/net/igb_core.h | 1 + hw/net/igb_regs.h | 3 +++ 3 files changed, 35 insertions

[PATCH v5 8/8] igb: respect VMVIR and VMOLR for VLAN

2023-02-01 Thread Sriram Yagnaraman
. Signed-off-by: Sriram Yagnaraman --- hw/net/igb_core.c | 54 ++- 1 file changed, 44 insertions(+), 10 deletions(-) diff --git a/hw/net/igb_core.c b/hw/net/igb_core.c index 42e3517695..d85f39a25f 100644 --- a/hw/net/igb_core.c +++ b/hw/net/igb_core.c

[PATCH v5 5/8] igb: check oversized packets for VMDq

2023-02-01 Thread Sriram Yagnaraman
Signed-off-by: Sriram Yagnaraman --- hw/net/igb_core.c | 41 - 1 file changed, 36 insertions(+), 5 deletions(-) diff --git a/hw/net/igb_core.c b/hw/net/igb_core.c index 8437cd6829..eab140070b 100644 --- a/hw/net/igb_core.c +++ b/hw/net/igb_core.c

[PATCH v6 8/8] igb: respect VMVIR and VMOLR for VLAN

2023-02-02 Thread Sriram Yagnaraman
. Signed-off-by: Sriram Yagnaraman --- hw/net/igb_core.c | 54 ++- 1 file changed, 44 insertions(+), 10 deletions(-) diff --git a/hw/net/igb_core.c b/hw/net/igb_core.c index 25a5e0ec87..cd4fba383c 100644 --- a/hw/net/igb_core.c +++ b/hw/net/igb_core.c

[PATCH v6 5/8] igb: check oversized packets for VMDq

2023-02-02 Thread Sriram Yagnaraman
Signed-off-by: Sriram Yagnaraman --- hw/net/igb_core.c | 41 - 1 file changed, 36 insertions(+), 5 deletions(-) diff --git a/hw/net/igb_core.c b/hw/net/igb_core.c index c4a2bff4c1..03139c76f7 100644 --- a/hw/net/igb_core.c +++ b/hw/net/igb_core.c

[PATCH v6 2/8] igb: handle PF/VF reset properly

2023-02-02 Thread Sriram Yagnaraman
Use PFRSTD to reset RSTI bit for VFs, and raise VFLRE interrupt when VF is reset. Signed-off-by: Sriram Yagnaraman --- hw/net/igb_core.c | 33 + hw/net/igb_regs.h | 3 +++ hw/net/trace-events | 2 ++ 3 files changed, 26 insertions(+), 12 deletions(-) diff

[PATCH v6 0/8] igb: merge changes from <20221229190817.25500-1-sriram.yagnara...@est.tech>

2023-02-02 Thread Sriram Yagnaraman
to his patchset Changes since v2: - Fixed more comments from Akhiko - Reordered the patches to make changes easier to understand Changes since v1: - Fix review comments from Akihiko Sriram Yagnaraman (8): MAINTAINERS: Add Sriram Yagnaraman as a igb reviewer igb: handle PF/VF reset properly ig

[PATCH v6 1/8] MAINTAINERS: Add Sriram Yagnaraman as a igb reviewer

2023-02-02 Thread Sriram Yagnaraman
I would like to review and be informed on changes to igb device Signed-off-by: Sriram Yagnaraman --- MAINTAINERS | 1 + 1 file changed, 1 insertion(+) diff --git a/MAINTAINERS b/MAINTAINERS index ece23b2b15..7d0e84ce37 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -2224,6 +2224,7 @@ F: tests

RE: [PATCH for 8.0 v2] igb: Save the entire Tx context descriptor

2023-03-16 Thread Sriram Yagnaraman
> -Original Message- > From: qemu-devel-bounces+sriram.yagnaraman=est.t...@nongnu.org > On Behalf > Of Akihiko Odaki > Sent: Thursday, 16 March 2023 16:57 > Cc: qemu-devel@nongnu.org; Jason Wang ; Dmitry > Fleytman ; quint...@redhat.com; Philippe > Mathieu-Daudé ; Akihiko Odaki > >

RE: [PATCH for 8.0 v2] igb: Save the entire Tx context descriptor

2023-03-17 Thread Sriram Yagnaraman
> -Original Message- > From: Akihiko Odaki > Sent: Friday, 17 March 2023 06:46 > To: Sriram Yagnaraman > Cc: qemu-devel@nongnu.org; Jason Wang ; Dmitry > Fleytman ; quint...@redhat.com; Philippe > Mathieu-Daudé > Subject: Re: [PATCH for 8.0 v2] igb: Sa

RE: [PATCH for 8.0 v2] igb: Save the entire Tx context descriptor

2023-03-17 Thread Sriram Yagnaraman
> -Original Message- > From: Akihiko Odaki > Sent: Friday, 17 March 2023 12:13 > To: Sriram Yagnaraman > Cc: qemu-devel@nongnu.org; Jason Wang ; Dmitry > Fleytman ; quint...@redhat.com; Philippe > Mathieu-Daudé > Subject: Re: [PATCH for 8.0 v2] igb: Sa

RE: [PATCH for 8.0] igb: Save more Tx states

2023-03-17 Thread Sriram Yagnaraman
> -Original Message- > From: Akihiko Odaki > Sent: Friday, 17 March 2023 13:25 > Cc: qemu-devel@nongnu.org; Jason Wang ; Dmitry > Fleytman ; quint...@redhat.com; Philippe > Mathieu-Daudé ; Sriram Yagnaraman > ; Akihiko Odaki > Subject: [PATCH for 8.0]

RE: [PATCH for 8.0] igb: Save more Tx states

2023-03-17 Thread Sriram Yagnaraman
> -Original Message- > From: Akihiko Odaki > Sent: Friday, 17 March 2023 15:21 > To: Sriram Yagnaraman > Cc: qemu-devel@nongnu.org; Jason Wang ; Dmitry > Fleytman ; quint...@redhat.com; Philippe > Mathieu-Daudé > Subject: Re: [PATCH for 8.0] igb: Save more Tx s

[PATCH v7 0/8] igb: merge changes from <20221229190817.25500-1-sriram.yagnara...@est.tech>

2023-03-12 Thread Sriram Yagnaraman
Changes since v1: - Fix review comments from Akihiko Sriram Yagnaraman (8): MAINTAINERS: Add Sriram Yagnaraman as a igb reviewer igb: handle PF/VF reset properly igb: add ICR_RXDW igb: implement VFRE and VFTE registers igb: check oversized packets for VMDq igb: respect E1000_VMOLR_RSSE igb

[PATCH v7 3/8] igb: add ICR_RXDW

2023-03-12 Thread Sriram Yagnaraman
IGB uses RXDW ICR bit to indicate that rx descriptor has been written back. This is the same as RXT0 bit in older HW. Signed-off-by: Sriram Yagnaraman --- hw/net/e1000x_regs.h | 4 hw/net/igb_core.c| 2 +- 2 files changed, 5 insertions(+), 1 deletion(-) diff --git a/hw/net

[PATCH v7 5/8] igb: check oversized packets for VMDq

2023-03-12 Thread Sriram Yagnaraman
Signed-off-by: Sriram Yagnaraman --- hw/net/igb_core.c | 41 - 1 file changed, 36 insertions(+), 5 deletions(-) diff --git a/hw/net/igb_core.c b/hw/net/igb_core.c index b2ea3a18ed..cb6993dd3b 100644 --- a/hw/net/igb_core.c +++ b/hw/net/igb_core.c

[PATCH v7 2/8] igb: handle PF/VF reset properly

2023-03-12 Thread Sriram Yagnaraman
Use PFRSTD to reset RSTI bit for VFs, and raise VFLRE interrupt when VF is reset. Signed-off-by: Sriram Yagnaraman --- hw/net/igb_core.c | 33 + hw/net/igb_regs.h | 3 +++ hw/net/trace-events | 2 ++ 3 files changed, 26 insertions(+), 12 deletions(-) diff

[PATCH v7 7/8] igb: implement VF Tx and Rx stats

2023-03-12 Thread Sriram Yagnaraman
Please note that loopback counters for VM to VM traffic is not implemented yet: VFGOTLBC, VFGPTLBC, VFGORLBC and VFGPRLBC. Signed-off-by: Sriram Yagnaraman --- hw/net/igb_core.c | 26 ++ 1 file changed, 22 insertions(+), 4 deletions(-) diff --git a/hw/net/igb_core.c b

[PATCH v7 4/8] igb: implement VFRE and VFTE registers

2023-03-12 Thread Sriram Yagnaraman
Also introduce: - Checks for RXDCTL/TXDCTL queue enable bits - IGB_NUM_VM_POOLS enum (Sec 1.5: Table 1-7) Signed-off-by: Sriram Yagnaraman --- hw/net/igb_core.c | 38 +++--- hw/net/igb_core.h | 1 + hw/net/igb_regs.h | 3 +++ 3 files changed, 35 insertions

[PATCH v7 1/8] MAINTAINERS: Add Sriram Yagnaraman as a igb reviewer

2023-03-12 Thread Sriram Yagnaraman
I would like to review and be informed on changes to igb device Signed-off-by: Sriram Yagnaraman --- MAINTAINERS | 1 + 1 file changed, 1 insertion(+) diff --git a/MAINTAINERS b/MAINTAINERS index 95c957d587..70685c9dab 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -2251,6 +2251,7 @@ F: tests

[PATCH v7 8/8] igb: respect VMVIR and VMOLR for VLAN

2023-03-12 Thread Sriram Yagnaraman
. Signed-off-by: Sriram Yagnaraman --- hw/net/igb_core.c | 51 +++ 1 file changed, 43 insertions(+), 8 deletions(-) diff --git a/hw/net/igb_core.c b/hw/net/igb_core.c index 86de73afc8..3c0fb19b1e 100644 --- a/hw/net/igb_core.c +++ b/hw/net/igb_core.c

[PATCH v7 6/8] igb: respect E1000_VMOLR_RSSE

2023-03-13 Thread Sriram Yagnaraman
RSS for VFs is only enabled if VMOLR[n].RSSE is set. Signed-off-by: Sriram Yagnaraman --- hw/net/igb_core.c | 9 - 1 file changed, 8 insertions(+), 1 deletion(-) diff --git a/hw/net/igb_core.c b/hw/net/igb_core.c index cb6993dd3b..f91cea20e5 100644 --- a/hw/net/igb_core.c +++ b/hw/net

[PATCH v10 7/8] igb: implement VF Tx and Rx stats

2023-03-24 Thread Sriram Yagnaraman
Please note that loopback counters for VM to VM traffic is not implemented yet: VFGOTLBC, VFGPTLBC, VFGORLBC and VFGPRLBC. Signed-off-by: Sriram Yagnaraman --- hw/net/igb_core.c | 26 ++ 1 file changed, 22 insertions(+), 4 deletions(-) diff --git a/hw/net/igb_core.c b

[PATCH v10 2/8] igb: handle PF/VF reset properly

2023-03-24 Thread Sriram Yagnaraman
Use PFRSTD to reset RSTI bit for VFs, and raise VFLRE interrupt when VF is reset. Signed-off-by: Sriram Yagnaraman --- hw/net/igb_core.c | 38 ++ hw/net/igb_regs.h | 3 +++ hw/net/trace-events | 2 ++ 3 files changed, 31 insertions(+), 12 deletions

[PATCH v10 8/8] igb: respect VMVIR and VMOLR for VLAN

2023-03-24 Thread Sriram Yagnaraman
. Signed-off-by: Sriram Yagnaraman --- hw/net/igb_core.c | 62 +-- 1 file changed, 49 insertions(+), 13 deletions(-) diff --git a/hw/net/igb_core.c b/hw/net/igb_core.c index 162ba8becf..d733fed6cf 100644 --- a/hw/net/igb_core.c +++ b/hw/net/igb_core.c

[PATCH v10 6/8] igb: respect E1000_VMOLR_RSSE

2023-03-24 Thread Sriram Yagnaraman
RSS for VFs is only enabled if VMOLR[n].RSSE is set. Signed-off-by: Sriram Yagnaraman --- hw/net/igb_core.c | 9 - 1 file changed, 8 insertions(+), 1 deletion(-) diff --git a/hw/net/igb_core.c b/hw/net/igb_core.c index 38aa4596b1..fd61c6c550 100644 --- a/hw/net/igb_core.c +++ b/hw/net

[PATCH v10 1/8] MAINTAINERS: Add Sriram Yagnaraman as a igb reviewer

2023-03-24 Thread Sriram Yagnaraman
I would like to review and be informed on changes to igb device Signed-off-by: Sriram Yagnaraman --- MAINTAINERS | 1 + 1 file changed, 1 insertion(+) diff --git a/MAINTAINERS b/MAINTAINERS index 9b56ccdd92..a9ed6143f5 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -2252,6 +2252,7 @@ F: tests

[PATCH v10 5/8] igb: check oversized packets for VMDq

2023-03-24 Thread Sriram Yagnaraman
Signed-off-by: Sriram Yagnaraman --- hw/net/igb_core.c | 41 - 1 file changed, 36 insertions(+), 5 deletions(-) diff --git a/hw/net/igb_core.c b/hw/net/igb_core.c index 753f17b40c..38aa4596b1 100644 --- a/hw/net/igb_core.c +++ b/hw/net/igb_core.c

[PATCH v10 3/8] igb: add ICR_RXDW

2023-03-24 Thread Sriram Yagnaraman
IGB uses RXDW ICR bit to indicate that rx descriptor has been written back. This is the same as RXT0 bit in older HW. Signed-off-by: Sriram Yagnaraman --- hw/net/e1000x_regs.h | 4 hw/net/igb_core.c| 2 +- 2 files changed, 5 insertions(+), 1 deletion(-) diff --git a/hw/net

[PATCH v10 0/8] igb: merge changes from <20221229190817.25500-1-sriram.yagnara...@est.tech>

2023-03-24 Thread Sriram Yagnaraman
patches to make changes easier to understand Changes since v1: - Fix review comments from Akihiko Sriram Yagnaraman (8): MAINTAINERS: Add Sriram Yagnaraman as a igb reviewer igb: handle PF/VF reset properly igb: add ICR_RXDW igb: implement VFRE and VFTE registers igb: check oversized

[PATCH v10 4/8] igb: implement VFRE and VFTE registers

2023-03-24 Thread Sriram Yagnaraman
Also introduce: - Checks for RXDCTL/TXDCTL queue enable bits - IGB_NUM_VM_POOLS enum (Sec 1.5: Table 1-7) Signed-off-by: Sriram Yagnaraman --- hw/net/igb_core.c | 38 +++--- hw/net/igb_core.h | 1 + hw/net/igb_regs.h | 3 +++ 3 files changed, 35 insertions

RE: [PATCH for 8.0] igb: Save more Tx states

2023-03-21 Thread Sriram Yagnaraman
> -Original Message- > From: qemu-devel-bounces+sriram.yagnaraman=est.t...@nongnu.org > On Behalf > Of Sriram Yagnaraman > Sent: Friday, 17 March 2023 16:26 > To: Akihiko Odaki > Cc: qemu-devel@nongnu.org; Jason Wang ; Dmitry > Fleytman ; quint...@redhat.com;

[PATCH v8 0/8] igb: merge changes from <20221229190817.25500-1-sriram.yagnara...@est.tech>

2023-03-22 Thread Sriram Yagnaraman
nts from Akihiko Sriram Yagnaraman (8): MAINTAINERS: Add Sriram Yagnaraman as a igb reviewer igb: handle PF/VF reset properly igb: add ICR_RXDW igb: implement VFRE and VFTE registers igb: check oversized packets for VMDq igb: respect E1000_VMOLR_RSSE igb: implement VF Tx and Rx stat

[PATCH v8 1/8] MAINTAINERS: Add Sriram Yagnaraman as a igb reviewer

2023-03-22 Thread Sriram Yagnaraman
I would like to review and be informed on changes to igb device Signed-off-by: Sriram Yagnaraman --- MAINTAINERS | 1 + 1 file changed, 1 insertion(+) diff --git a/MAINTAINERS b/MAINTAINERS index 9b56ccdd92..a9ed6143f5 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -2252,6 +2252,7 @@ F: tests

[PATCH v8 5/8] igb: check oversized packets for VMDq

2023-03-22 Thread Sriram Yagnaraman
Signed-off-by: Sriram Yagnaraman --- hw/net/igb_core.c | 41 - 1 file changed, 36 insertions(+), 5 deletions(-) diff --git a/hw/net/igb_core.c b/hw/net/igb_core.c index 7c8f665f07..1de24ffde2 100644 --- a/hw/net/igb_core.c +++ b/hw/net/igb_core.c

  1   2   >