-off-by: Stefan Weil
---
Hello Michael,
thank you for the report and your hint for a possible fix.
This is still not the final solution which should build
version.o at link time, but it is a minimal fix for the
broken build.
Regards,
Stefan
Makefile |2 ++
1 file changed, 2 insertions
The QEMU mascot which was already used for the NSIS installer
is now used for all QEMU executables.
Signed-off-by: Stefan Weil
---
version.rc |2 ++
1 file changed, 2 insertions(+)
diff --git a/version.rc b/version.rc
index 82e10ec..a50d62f 100644
--- a/version.rc
+++ b/version.rc
@@ -26,3
These include files don't exist for MinGW and are not needed for Linux
(and hopefully for other hosts as well), so remove them.
Signed-off-by: Stefan Weil
---
ui/gtk.c |4
1 file changed, 4 deletions(-)
diff --git a/ui/gtk.c b/ui/gtk.c
index c38146f..b5f4f0b 100644
--- a/ui/
Most typos were found using a modified version of codespell:
accross -> across
issueing -> issuing
TICNT_THRESHHOLD -> TICNT_THRESHOLD
bandwith -> bandwidth
VCARD_7816_PROPIETARY -> VCARD_7816_PROPRIETARY
occured -> occurred
gaurantee -> guarantee
sofware -> software
Si
Am 18.08.2013 20:23, schrieb Liu, Jinsong:
> From 1273f8b2e5464ec987facf9942fd3ccc0b69087e Mon Sep 17 00:00:00 2001
> From: Liu Jinsong
> Date: Mon, 19 Aug 2013 09:33:30 +0800
> Subject: [PATCH] qemu-kvm bugfix for IA32_FEATURE_CONTROL
>
> This patch is to fix the bug https://bugs.launchpad.net/qe
is based on a rather old version)? It only
supports Intel based hosts, is restricted to 32 bit guests (?)
and free, but not open source.
Regards,
Stefan Weil
e and must be disabled to
avoid warnings: -Wno-missing-field-initializers, -Wno-override-init,
-Wno-sign-compare and -Wno-unused-parameter.
Signed-off-by: Stefan Weil
---
This is a rather old and long tested patch: I use -Wextra in my
QEMU builds for more than a year now. At least one bug was fou
Am 21.08.2013 11:11, schrieb Paolo Bonzini:
> Still, I must say merging Xen has given us zero headaches. It's taken a
> while, but (at least from the QEMU project's POV) the wait has been
> worthwhile.
>
> I would hope that HAXN support would be almost as easy as adding
> haxn-all.c and haxn-stub.
Hi Stefan,
this patch was committed yesterday. It breaks MinGW builds:
aio-win32.c: In function ‘aio_poll’:
aio-win32.c:128:21: error: ‘AioHandler’ has no member named ‘opaque’
aio-win32.c:191:25: error: ‘AioHandler’ has no member named ‘opaque’
Regards,
Stefan
Am 19.08.2013 16:17, schrieb Ste
Am 22.08.2013 15:28, schrieb Stefan Hajnoczi:
> Stefan Weil noticed that the win32 build is broken with my io_flush changes
> applied. The issues are simple build failures that should have been avoided
> by
> test building Windows, which I didn't.
>
> To make amends I&
Function expr_error gets a format string and variable arguments like printf.
It also never returns. Add the necessary attributes.
Signed-off-by: Stefan Weil
---
monitor.c |3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/monitor.c b/monitor.c
index da9c9a2..6413d44 100644
See my comment below.
Am 23.08.2013 09:06, schrieb Christoffer Dall:
> The printf args are uint64_t and with -Werr QEMU doesn't compile with
> migration debugging turned on unless this is fixed. Fix it.
>
> Signed-off-by: Christoffer Dall
> ---
> migration.c |2 +-
> 1 file changed, 1 inser
DPRINTF("pending size %" PRIu64 " max %" PRIu64 "\n",
> +pending_size, max_size);
> if (pending_size && pending_size >= max_size) {
> qemu_savevm_state_iterate(s->file);
> } e
Am 23.08.2013 21:47, schrieb Richard Henderson:
> I've been thinking for a while about how to reliably test TCG backends, and
> maybe how to do regression testing on them. Having to begin the test from a
> guest binary, especially considering the vast cross-compilation problem, is
> pretty much a
Am 24.08.2013 15:43, schrieb Taimoor Mirza:
> Hi guys,
>
> I am using QEMU with SDL support to run some demo applications.
> Problem I am facing is that fonts in my SDL window are not displayed
> properly. I have to press Ctrl+Alt+u to undo scaling. After that fonts
> display correctly.
> Is there
Am 25.08.2013 07:58, schrieb Taimoor Mirza:
> Hi Stefan,
>
> Thanks for your reply. Is there any way I can disable scaling in SDL
> library? I've not used SDL before and I am not sure whether there is
> some configuration option for it or not?
>
> -Taimoor
>
Scaling is implemented in QEMU's code,
Am 23.08.2013 23:18, schrieb Richard Henderson:
>
> I don't see how TCI really comes into this except as Yet Another Backend to be
> tested. Indeed, such unit testing could show that TCI is in fact broken wrt
> helpers, depending on the host abi.
TCI is special because it is the only TCG backend
-off-by: Stefan Weil
Tested-by: Michael Roth
---
Makefile |2 ++
1 file changed, 2 insertions(+)
diff --git a/Makefile b/Makefile
index 4d257f1..806946e 100644
--- a/Makefile
+++ b/Makefile
@@ -168,7 +168,9 @@ recurse-all: $(SUBDIR_RULES) $(ROMSUBDIR_RULES)
bt-host.o: QEMU_CFLAGS
The QEMU mascot which was already used for the NSIS installer
is now used for all QEMU executables.
Signed-off-by: Stefan Weil
---
version.rc |2 ++
1 file changed, 2 insertions(+)
diff --git a/version.rc b/version.rc
index 82e10ec..a50d62f 100644
--- a/version.rc
+++ b/version.rc
@@ -26,3
nges up to 92f1623663a8797e68a043ec401a740746439f29:
gtk: Remove unused include statements which are not portable (2013-08-27
14:21:16 +0200)
--------
Stefan Weil (3):
w32: Fix broken out-of-tree builds (missing version.o)
w32: Add an ico
These include files don't exist for MinGW and are not needed for Linux
(and hopefully for other hosts as well), so remove them.
Signed-off-by: Stefan Weil
---
ui/gtk.c |4
1 file changed, 4 deletions(-)
diff --git a/ui/gtk.c b/ui/gtk.c
index c38146f..b5f4f0b 100644
--- a/ui/
only called a few times.
Python's option -B disables writing of .pyc files. QEMU now uses "python -B"
as default, but it is still possible to choose a different call by passing
--python=PYTHON to configure.
Signed-off-by: Stefan Weil
---
It was necessary to change from "$pyt
Am 27.08.2013 17:56, schrieb Kevin Wolf:
> The failing condition is checked immediately before the assertion, so
> keeping the assertion is kind of redundant.
Are you sure that it is not the check which is redundant?
Is file == NULL allowed in this 'else' branch?
Regards,
Stefan
>
> Signed-off-b
For existing libraries, pkg-config --cflags and pkg-config --libs won't
print error messages to stderr, so redirecting stderr is not necessary.
Signed-off-by: Stefan Weil
---
configure | 36 ++--
1 file changed, 18 insertions(+), 18 deletions(-)
diff --
ff-by: Stefan Weil
---
configure | 30 ++
1 file changed, 14 insertions(+), 16 deletions(-)
diff --git a/configure b/configure
index a47381c..0315cf0 100755
--- a/configure
+++ b/configure
@@ -1469,7 +1469,7 @@ libs_softmmu="$libs_softmmu -lz"
# libseccomp c
These unimplemented opcodes are handled like illegal opcodes, but
they are used in existing code. We should at least report when they
are executed.
Signed-off-by: Stefan Weil
---
When running a QEMU system emulation of an ARM system
(Raspberry PI), Linux booted, but when I tried to run a
user
Commit ac26eb69a311396668809eadbf7ff4e623447d4c added tcg_out64 to tcg/tcg.c.
tcg/tci/tcg-target.c already had a nearly identical implementation which is
now removed to fix a compiler error.
Signed-off-by: Stefan Weil
---
tcg/tci/tcg-target.c |7 ---
1 file changed, 7 deletions(-)
diff
Am 28.08.2013 18:38, schrieb Peter Maydell:
> On 28 August 2013 16:26, Richard Henderson wrote:
>
>> (D) Profit! I'm not sure what will be left of TARGET_WORDS_BIGENDIAN at this
>> point. Possibly only if we leave the current translator interface in place
>> in
>> step A.
> I think there are a
Am 30.07.2013 00:35, schrieb Laszlo Ersek:
> On 07/29/13 20:18, Stefan Weil wrote:
>> Am 29.07.2013 20:05, schrieb Anthony Liguori:
>>> Stefan Weil writes:
>>>
>>>> Hello,
>>>>
>>>> maybe most developers will already have notice
Am 29.08.2013 20:19, schrieb Alex Bligh:
> sleep() apparently doesn't exist under mingw. Use g_usleep for
> portability.
>
> Signed-off-by: Alex Bligh
> ---
> tests/test-aio.c |6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/tests/test-aio.c b/tests/test-aio.c
> i
} while (qemu_clock_get_ns(data.clock_type) <= expiry);
> -sleep(1);
> +g_usleep(1 * G_USEC_PER_SEC);
> g_main_context_iteration(NULL, false);
>
> g_assert_cmpint(data.n, ==, 2);
Reviewed-by: Stefan Weil
I cc'ed the mail to qemu-trivial, so it can be applied there.
Stefan
Am 01.09.2013 17:46, schrieb Michael Tokarev:
> 30.08.2013 15:04, Jan Kiszka wrote:
>> On 2013-08-15 21:25, Taimoor wrote:
>>> From: Taimoor Mirza
>>>
>>> port redirection code uses SO_REUSEADDR socket option before binding to
>>> host port. Behavior of SO_REUSEADDR is different on Windows and Lin
7; doesn't support the option 'filename'
Duplicate code from raw_open to fix this.
Signed-off-by: Stefan Weil
---
This bug was reported by David Brenner.
It should be fixed in QEMU 1.6 as well.
Stefan
block/raw-win32.c | 36 +---
1 file cha
Am 21.08.2013 07:44, schrieb Stefan Weil:
> Compiler option -Wextra enables an additional set of compiler warnings.
>
> Some of these warnings were already enabled explicitly in QEMU:
> -Wold-style-declaration, -Wtype-limits, -Wignored-qualifiers and
> -Wempty-body are now redun
Am 04.09.2013 16:41, schrieb Peter Maydell:
> On 4 September 2013 15:27, Paolo Bonzini wrote:
>> Il 04/09/2013 16:22, Sebastian Ottlik ha scritto:
>>> This patchset disabels all use of SO_REUSEADDR on Windows. On
>>> Windows systems the default behavior is equivalent to SO_REUSEADDR
>>> on other o
It is used by qemu-ppc64 when running Debian's busybox-static.
Signed-off-by: Stefan Weil
---
This patch is also useful for QEMU 1.6.
tcg/tci/tcg-target.c |1 -
tci.c| 10 +-
2 files changed, 9 insertions(+), 2 deletions(-)
diff --git a/tcg/tci/tcg-targe
Am 04.09.2013 22:49, schrieb Stefan Weil:
> It is used by qemu-ppc64 when running Debian's busybox-static.
>
> Signed-off-by: Stefan Weil
> ---
>
> This patch is also useful for QEMU 1.6.
... so I should have added qemu-stable. Done now.
>
> tcg/tci/t
Commit c261d774fb9093d00e0938a19f502fb220f62718 added one more binutils
tool: nm also needs a cross prefix.
Signed-off-by: Stefan Weil
---
configure |2 ++
rules.mak |2 +-
2 files changed, 3 insertions(+), 1 deletion(-)
diff --git a/configure b/configure
index 1a9daa5..5eb95a3 100755
This fixes a warning from smatch (static code analysis).
Signed-off-by: Stefan Weil
---
hw/i386/pc.c |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/hw/i386/pc.c b/hw/i386/pc.c
index 2c2e9dc..82a7daa 100644
--- a/hw/i386/pc.c
+++ b/hw/i386/pc.c
@@ -75,7 +75,7 @@
/* Leave
ned-off-by: Stefan Weil
---
Peter, could you please apply this bug fix directly without pull request?
Thanks
Stefan
include/hw/virtio/virtio_ring.h |4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/include/hw/virtio/virtio_ring.h b/include/hw/virtio/virtio_ring.h
in
Am 09.04.2013 18:21, schrieb Paolo Bonzini:
> Il 20/02/2013 14:43, Paolo Bonzini ha scritto:
>> These are needed for any of the Win32 alarm timer implementations.
>> They are not tied to mmtimer exclusively.
>>
>> Jacob tested this patch with both mmtimer and Win32 timers.
>>
>> Cc: qemu-sta...@non
Hello Anthony,
please pull these five patches for TCI. They fix a regression caused
by commit 378df4b23753a11be650af7664ca76bc75cb9f01 and include
some improvements.
Thanks,
Stefan Weil
The following changes since commit 93b48c201eb6c0404d15550a0eaa3c0f7937e35e:
virtio-9p: Fix virtio-9p no
From: Richard Henderson
Signed-off-by: Richard Henderson
Signed-off by: Stefan Weil
---
tcg/tci/tcg-target.c |6 +-
1 file changed, 1 insertion(+), 5 deletions(-)
diff --git a/tcg/tci/tcg-target.c b/tcg/tci/tcg-target.c
index a85095c..b096a84 100644
--- a/tcg/tci/tcg-target.c
+++ b
From: Richard Henderson
Since the change to tcg_exit_req, the first insn of every TB is
a load with a negative offset from env.
Signed-off-by: Richard Henderson
Signed-off by: Stefan Weil
---
tcg/tci/tcg-target.c |4 ++--
tci.c| 36
From: Richard Henderson
Since we have total conversion away from global AREG0, we do not
need a global variable named "env". Retain that name as the
function parameter inside the interpreter.
Signed-off-by: Richard Henderson
Signed-off by: Stefan Weil
---
tci.c |8 +-
chard Henderson
Signed-off by: Stefan Weil
---
tcg/tci/tcg-target.c | 12 ++--
tcg/tci/tcg-target.h |8 +++-
tci.c|6 ++
3 files changed, 19 insertions(+), 7 deletions(-)
diff --git a/tcg/tci/tcg-target.c b/tcg/tci/tcg-target.c
index b096a84..d1241b5 1
On 09.04.2013 18:16, Paolo Bonzini wrote:
Reviewed-by: Paolo Bonzini
Do we need an additional Signed-off from the author (Olivier Hainque)?
Currently, only Fabien signed these patches.
I'm preparing a pull request and was not sure about this point.
Regards,
Stefan W.
From: Richard Henderson
This only valid with c99 extensions enabled, and easy to avoid.
Signed-off-by: Richard Henderson
Signed-off by: Stefan Weil
---
tci.c |7 ---
1 file changed, 4 insertions(+), 3 deletions(-)
diff --git a/tci.c b/tci.c
index 77e0980..70f8308 100644
--- a/tci.c
Am 10.04.2013 13:48, schrieb Jan Kiszka:
On 2013-03-30 15:21, Stefan Weil wrote:
The QEMU icon which is already used for SDL
is now also loaded by GTK.
Signed-off-by: Stefan Weil
---
ui/gtk.c | 13 +
1 file changed, 13 insertions(+)
diff --git a/ui/gtk.c b/ui/gtk.c
index
From: Olivier Hainque
On multi-core systems, SuspendThread does not guaranty immediate thread
suspension. We add busy loop to wait for effective thread suspension
after call to ThreadSuspend().
Signed-off-by: Fabien Chouteau
Reviewed-by: Paolo Bonzini
Signed-off-by: Stefan Weil
---
cpus.c
Hello Anthony,
please pull these patches for QEMU git master.
All of them were reviewed on qemu-devel.
Thanks,
Stefan W.
The following changes since commit 93b48c201eb6c0404d15550a0eaa3c0f7937e35e:
virtio-9p: Fix virtio-9p no longer building after hw-dirs branch merge
(2013-04-09 07:47:00 -0
From: Fabien Chouteau
The previous patches make QEMU SMP safe on Windows, we can now release
the restriction.
Signed-off-by: Fabien Chouteau
Reviewed-by: Paolo Bonzini
Signed-off-by: Stefan Weil
---
os-win32.c | 18 --
1 file changed, 18 deletions(-)
diff --git a/os-win32
: Fabien Chouteau
Reviewed-by: Paolo Bonzini
Signed-off-by: Stefan Weil
---
cpu-exec.c |8
1 file changed, 8 insertions(+)
diff --git a/cpu-exec.c b/cpu-exec.c
index e74e556..aa8fa89 100644
--- a/cpu-exec.c
+++ b/cpu-exec.c
@@ -217,6 +217,14 @@ int cpu_exec(CPUArchState *env
From: Paolo Bonzini
These are needed for any of the Win32 alarm timer implementations.
They are not tied to mmtimer exclusively.
Jacob tested this patch with both mmtimer and Win32 timers.
Cc: qemu-sta...@nongnu.org
Tested-by: Jacob Kroon
Signed-off-by: Paolo Bonzini
Signed-off-by: Stefan
Am 12.04.2013 18:47, schrieb David Gibson:
> On Fri, Apr 12, 2013 at 12:51:51PM +0200, Andreas Färber wrote:
>> Am 12.04.2013 03:41, schrieb Alexey Kardashevskiy:
>>> The bswap functions use memcpy but the bswap.h header itself does not seem
>>> to
>>> include it in some configuration such as cros
cpu_physical_memory_read, cpu_physical_memory_write take any pointer
as 2nd argument without needing a type cast.
Signed-off-by: Stefan Weil
---
hw/arm/armv7m.c| 12 ++--
hw/arm/boot.c |4 ++--
hw/arm/musicpal.c |8
hw/arm/nseries.c
Am 12.04.2013 22:23, schrieb Alexey Kardashevskiy:
> On 04/13/2013 03:36 AM, Stefan Weil wrote:
>> Am 12.04.2013 18:47, schrieb David Gibson:
>>> On Fri, Apr 12, 2013 at 12:51:51PM +0200, Andreas Färber wrote:
>>>> Am 12.04.2013 03:41, schrieb Alexey Kardashevskiy:
GetLastError() returns a DWORD value which is unsigned long,
so the correct format specifier is %lu.
Signed-off-by: Stefan Weil
---
Debian's w32 cross compiler does not complain about the wrong
specifiers, but the w64 cross compiler does.
I'm sorry that I did not notice this before s
Commit 0434e30afb6175212389811e0b28b948eb3c1e40 accidentally removed
the compilation of arm11mpcore.c.
Signed-off-by: Stefan Weil
---
default-configs/arm-softmmu.mak |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/default-configs/arm-softmmu.mak b/default-configs/arm
Am 15.04.2013 17:55, schrieb Paolo Bonzini:
Il 13/03/2013 13:23, Pavel Dovgaluk ha scritto:
Added cleanup for Win32 TAP interface. Signed-off-by: Pavel
Dovgalyuk
Stefan, did this slip? Paolo
Yes, I had not noticed this patch before. But there was a comment
from Stefan H. which is still unan
Now gcc will check whether format string and variable arguments match.
Signed-off-by: Stefan Weil
---
Please note: I could only run limited tests with the new code
because ssh.c is currently not compiled in my w32/w64 environment.
Regards,
Stefan W.
block/ssh.c |4 ++--
1 file changed, 2
Am 18.04.2013 22:21, schrieb Stefan Weil:
> Now gcc will check whether format string and variable arguments match.
>
> Signed-off-by: Stefan Weil
> ---
>
> Please note: I could only run limited tests with the new code
> because ssh.c is currently not compiled in m
gt; -if (strlen(host_key_check) >= 5 &&
> -strncmp(host_key_check, "sha1:", 5) == 0) {
> +if (strncmp(host_key_check, "sha1:", 5) == 0) {
> return check_host_key_hash(s, &host_key_check[5],
> LIBSSH2_HOSTKEY_HASH_SHA1, 20);
> }
Reviewed-by: Stefan Weil
Am 18.04.2013 23:08, schrieb Richard W.M. Jones:
> On Thu, Apr 18, 2013 at 10:42:09PM +0200, Stefan Weil wrote:
>> The test fails on current Debian (squeeze), not because of wrong
>> format specifiers, but because of an "old" libssh2-1-dev.
>>
>> ssh.c call
Am 22.04.2013 20:53, schrieb Paolo Bonzini:
> Commit e9d8fbf (qemu-file: do not use stdio for qemu_fdopen, 2013-03-27)
> introduced a usage of writev, which mingw32 does not have. Even though
> qemu_fdopen itself is not used on mingw32, the future-proof solution is
> to add an implementation of it
Am 19.04.2013 16:24, schrieb Paolo Bonzini:
> The following changes since commit 09dada400328d75daf79e3eca1e48e024fec148d:
>
> configure: remove duplicate test (2013-04-18 14:12:31 +0200)
>
> are available in the git repository at:
>
> git://github.com/bonzini/qemu.git scsi-next
>
> for you to
Am 24.04.2013 10:19, schrieb Paolo Bonzini:
> Il 24/04/2013 06:56, Stefan Weil ha scritto:
>> Hi Paolo, the latest QEMU build is broken when CONFIG_VHOST_SCSI is
>> undefined.
> --verbose, please. :)
Sorry, I thought it was obvious. The error occurs in a cross build for
w64 w
out-of-bounds write access with index 8.
The patch adds the missing shift operation also for IOMMU_CTRL where
it is needed only for cosmetic reasons.
Signed-off-by: Stefan Weil
---
Any reason why the array is declared with 3 elements when only the first 2
are used?
Regards,
Stefan
hw/pci-host
Am 09.06.2014 16:19, schrieb Stefan Weil:
> The array regs is declared with IOMMU_NREGS (3) elements and accessed
> using IOMMU_CTRL (0) and IOMMU_BASE (8). In most cases, those values
> are right shifted before being used as an index which results in indices
> 0 and 1. In one case
Am 13.06.2014 13:49, schrieb Lb peace:
> It is funny that we have two sigbus_handler in our QEMU.(exec.c &
> cpus.c)Change one's name.
>
> Signed-off-by: Peace
> ---
> cpus.c |4 ++--
> 1 files changed, 2 insertions(+), 2 deletions(-)
>
Technically it does not matter whether two functions
* accomodate -> accommodate
* aquiring -> acquiring
* beacuse -> because
* loosing -> losing
* prefering -> preferring
* threshhold -> threshold
Signed-off-by: Stefan Weil
---
block/iscsi.c |2 +-
hw/input/hid.c |2 +-
t
is compiled with -DNDEBUG.
Using g_assert_not_reached better documents the intention and does not
have these problems.
Signed-off-by: Stefan Weil
---
target-ppc/dfp_helper.c |3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/target-ppc/dfp_helper.c b/target-ppc/dfp_helper.c
This helps detecting wrong format strings.
Signed-off-by: Stefan Weil
---
This patch is not intended to be applied before fixing some potential errors.
Addings the GNU gcc format attribute results in lots of compiler errors like
these ones:
CXX disas/libvixl/a64/disasm-a64.o
disas
Am 18.06.2014 00:09, schrieb Peter Maydell:
> On 17 June 2014 22:07, Stefan Weil wrote:
>> This helps detecting wrong format strings.
>>
>> Signed-off-by: Stefan Weil
>> ---
>>
>> This patch is not intended to be applied before fixing some potential e
Am 18.06.2014 06:28, schrieb Richard Henderson:
>> I don't know the reason, because all locations seem to have arguments
>> which are function calls, and the called function returns Instr which
>> is uint32_t, not int64_t.
> ...
>> + void GCC_FMT_ATTR(2, 3) AppendToOutput(const char* string, ...);
Am 18.06.2014 06:31, schrieb Stefan Weil:
> Am 18.06.2014 06:28, schrieb Richard Henderson:
>>> I don't know the reason, because all locations seem to have arguments
>>> which are function calls, and the called function returns Instr which
>>> is uint32
Am 18.06.2014 17:19, schrieb Richard Henderson:
>
> On 06/17/2014 09:45 PM, Stefan Weil wrote:
>>
>> Variable arguments usually are not converted to 64 bit values: if
>> they are smaller than int, they are expanded to int, and larger
>> values are passed as th
.
Signed-off-by: Stefan Weil
---
Hello Peter,
if you want to fix the format strings before upstream updates the code,
you can use this patch.
It fails with checkpatch.pl, but that's normal in this case.
Regards
Stefan
disas/libvixl/a64/disasm-a64.cc | 20 ++--
1
Am 19.06.2014 10:55, schrieb Peter Maydell:
> On 28 May 2014 16:42, Stefan Weil wrote:
>> Commit 5a007547df76446ab891df93ebc55749716609bf tried to fix a
>> performance degradation caused by bad handling of small timeouts
>> in the original implementation of g_poll.
>>
Am 18.06.2014 19:49, schrieb Stefan Weil:
> When the compiler is told to check the arguments of AppendToOutput,
> it reports several errors of this kind:
>
> error: format ‘%d’ expects argument of type ‘int’,
> but argument 3 has type ‘int64_t {aka long int}’ [-Werror=format]
>
'hpagesize' is now set and
used in a block without any call of sigsetjmp or similar functions.
Signed-off-by: Stefan Weil
---
util/oslib-posix.c | 30 --
1 file changed, 16 insertions(+), 14 deletions(-)
diff --git a/util/oslib-posix.c b/util/oslib-posix.c
ind
;name)))
> {
> +if (!xs_write(state->xenstore, 0, path, mr_name, strlen(mr_name))) {
> return -1;
> }
> }
>
Otherwise ok. Below is my own variant which I tested before I noticed
your patch.
Reviewed-by: Stefan Weil
@@ -69,11 +69,11 @@
Signed-off-by: Stefan Weil
---
libdecnumber/decNumber.c | 21 +++--
1 file changed, 11 insertions(+), 10 deletions(-)
diff --git a/libdecnumber/decNumber.c b/libdecnumber/decNumber.c
index a30632f..58211e7 100644
--- a/libdecnumber/decNumber.c
+++ b/libdecnumber/decNumber.c
Am 18.07.2014 um 16:52 schrieb Stefan Weil:
> Adding 'update' to the phony targets fixes this error:
>
> $ LANG=C make -C po update
> make: Entering directory `/qemu/po'
> LINK update
> /qemu/po/de_DE.po: file not recognized: File format not recognized
>
Am 24.08.2014 11:21, schrieb Michael Tokarev:
Applied to -trivial, thank you!
But I've a small concern - should we really do this on "external" sources,
and divirge from upstream needlessly?
Thanks,
/mjt
In general, I agree. In this case, the code was part of gcc, and newer
versions of gcc
ame = (char *)mr->name;
> +physmap->name = mr->name;
> physmap->phys_offset = phys_offset;
>
> QLIST_INSERT_HEAD(&state->physmap, physmap, list);
>
Thanks.
Reviewed-by: Stefan Weil
The macro g_assert_not_reached is a better self documenting replacement
for assert(0) or assert(false).
Signed-off-by: Stefan Weil
---
The patch replaces [g_]assert(0), [g_]assert(false) by
g_assert_not_reached().
It did not remove some code like assignments, break or return
statements after
Signed-off-by: Stefan Weil
---
Makefile |4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/Makefile b/Makefile
index 29f1043..80aeb18 100644
--- a/Makefile
+++ b/Makefile
@@ -237,7 +237,8 @@ clean:
find . -name '*.[oda]' -type f -exec rm -f {} +
Am 15.07.2013 23:52, schrieb Stefan Weil:
> The new rules in Makefile allow building installers for QEMU on Windows
> using NSIS, a package which is also available for Linux distributions
> (so cross builds are possible).
>
> The rules for NSIS are in qemu.nsi which also uses
Passing a CPUState pointer instead of a CPUArchState pointer eliminates
the last target dependent data type in sysemu/kvm.h.
It also simplifies the code.
Signed-off-by: Stefan Weil
---
With this patch (and a previous one which is already queued),
kvm.h can be included without errors from
This assignment causes a compiler warning for compilations with the compiler
option -Wunused-but-set-variable (which is included with -Wextra).
Removing it allows using -Wextra for QEMU code without suppressing too many
extra warnings.
Signed-off-by: Stefan Weil
---
target-mips/op_helper.c
Am 26.07.2013 04:03, schrieb jean-christophe manciot:
> Public bug reported:
>
> Environment: Ubuntu 13.04
>
> "hw/ide/macio.c: In function ‘pmac_ide_atapi_transfer_cb’:
> hw/ide/macio.c:134:9: error: format ‘%lx’ expects argument of type ‘long
> unsigned int’, but argument 3 has type ‘hwaddr’ [-W
Am 26.07.2013 14:33, schrieb Andreas Färber:
> Am 25.07.2013 20:50, schrieb Stefan Weil:
>> Passing a CPUState pointer instead of a CPUArchState pointer eliminates
>> the last target dependent data type in sysemu/kvm.h.
>>
>> It also simplifies the code.
>&
Am 27.07.2013 19:43, schrieb Peter Maydell:
> On 27 July 2013 17:18, Hervé Poussineau wrote:
>> Another solution would be to add a big dummy memory regions on all MIPS
>> boards
>> to catch memory accesses and not raise an exception. However, this means that
>> each MIPS board will have its own u
Am 27.07.2013 22:43, schrieb Andreas Färber:
> Am 27.07.2013 21:37, schrieb Stefan Weil:
>> Am 27.07.2013 19:43, schrieb Peter Maydell:
>>> On 27 July 2013 17:18, Hervé Poussineau wrote:
>>>> Another solution would be to add a big dummy memory regions on all MIPS
&g
changes up to 5f5c967458535966ac98a5084c9e5d4838d6e9a6:
w32, w64: Add build rule for installer (2013-07-27 22:36:17 +0200)
--------
Stefan Weil (1):
w32, w64: Add build rule for installer
Makefile | 55 +
The new rules in Makefile allow building installers for QEMU on Windows
using NSIS, a package which is also available for Linux distributions
(so cross builds are possible).
The rules for NSIS are in qemu.nsi which also uses two new images.
Signed-off-by: Stefan Weil
---
Makefile
The misspelling was spotted by Andreas Färber.
Signed-off-by: Stefan Weil
---
hw/arm/musicpal.c |4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/hw/arm/musicpal.c b/hw/arm/musicpal.c
index b06d442..d27 100644
--- a/hw/arm/musicpal.c
+++ b/hw/arm/musicpal.c
Am 28.07.2013 11:46, schrieb Andreas Färber:
> Am 28.07.2013 07:54, schrieb Stefan Weil:
>> The misspelling was spotted by Andreas Färber.
>>
>> Signed-off-by: Stefan Weil
>> ---
>> hw/arm/musicpal.c |4 ++--
>> 1 file changed, 2 insertions(+), 2 del
Hello,
maybe most developers will already have noticed that the terminal output
in QEMU's GTK user interface is broken. As far as I know, it never worked,
but as there are working alternatives, I did not care much and forgot to
report the issues.
See these snapshots which show the problems with Q
401 - 500 of 4008 matches
Mail list logo
