=1
To fix this issue, we've got to make sure to disable huge page support,
too, when there is a NUMA node that is not using a memory backend with
huge page support.
Fixes: 86b50f2e1befc33407bdfeb6f45f7b0d2439a740
Signed-off-by: Thomas Huth <th...@redhat.com>
---
target-ppc/kvm.c | 10 +++---
1
Add "hcall-sprg0" (for H_SET_SPRG0), "hcall-copy" (for H_PAGE_INIT)
and "hcall-debug" (for H_LOGICAL_CI_LOAD/STORE) to the property
"ibm,hypertas-functions" to indicate that we support these hypercalls.
Signed-off-by: Thomas Huth <th...@redhat.com>
ck whether there are any
bug tickets that could be moved from "Fix committed" (or another
state if the author of the patch forgot to update the bug ticket)
to "Fix released".
Signed-off-by: Thomas Huth <th...@redhat.com>
---
Note: I'm sending this as an RFC patch only since I
rst. However, at two spots, the memset() was not removed
from the calling function, so it currently done twice in these code
paths. Thus let's delete these superfluous memsets in the calling
functions now.
Signed-off-by: Thomas Huth <th...@redhat.com>
---
slirp/tftp.c | 4
1 file changed, 4
On 05.08.2016 09:49, David Gibson wrote:
> On Thu, Aug 04, 2016 at 10:41:16AM +0200, Laurent Vivier wrote:
> 1;4402;0c>
>>
>> On 04/08/2016 04:38, David Gibson wrote:
>>> On Wed, Aug 03, 2016 at 09:55:07PM +0200, Laurent Vivier wrote:
If we don't provide the page size in
On 09.08.2016 10:25, Cédric Le Goater wrote:
> The sPAPR CPU core typename is already available in the upper
> block.
>
> Signed-off-by: Cédric Le Goater
> ---
> hw/ppc/spapr.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/hw/ppc/spapr.c b/hw/ppc/spapr.c
> index
ct_property_set_int(core, smp_threads, "nr-threads",
> _fatal);
> object_property_set_int(core, core_id, CPU_CORE_PROP_CORE_ID,
>
Reviewed-by: Thomas Huth <th...@redhat.com>
registration before
the spapr cpu core registration code.
Signed-off-by: Thomas Huth <th...@redhat.com>
---
target-ppc/kvm.c | 14 +++---
1 file changed, 7 insertions(+), 7 deletions(-)
diff --git a/target-ppc/kvm.c b/target-ppc/kvm.c
index 84764ed..82b1df9 100644
--- a/target-ppc/kvm.c
We will need this function to look up the aliases in the
spapr-cpu-core code, too.
Signed-off-by: Thomas Huth <th...@redhat.com>
---
target-ppc/cpu.h| 1 +
target-ppc/translate_init.c | 13 +
2 files changed, 14 insertions(+)
diff --git a/target-ppc/cpu.h b/targ
, and
if not by trying to look up the given model as an alias name instead).
Signed-off-by: Thomas Huth <th...@redhat.com>
---
hw/ppc/spapr.c | 2 +-
hw/ppc/spapr_cpu_core.c | 38 +-
2 files changed, 22 insertions(+), 18 deletions(-)
diff --gi
erface.
Let's fix it by supporting a CPU family type for the spapr-cpu-core
on KVM, too.
Buglink: https://bugzilla.redhat.com/show_bug.cgi?id=1363812
Signed-off-by: Thomas Huth <th...@redhat.com>
---
target-ppc/kvm.c | 7 +--
1 file changed, 5 insertions(+), 2 deletions(-)
diff --g
The type string is allocated in spapr_get_cpu_core_type()
with g_strdup_printf(), so we should free this memory when we're
done with it.
Signed-off-by: Thomas Huth <th...@redhat.com>
---
hw/ppc/spapr.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/hw/ppc/spapr.c b/hw/ppc/spapr.c
sure that we do not mess up the generic
CPU family type registration anymore (which was another regression
introduced with the spapr CPU hotplug code).
Buglink: https://bugzilla.redhat.com/show_bug.cgi?id=1363812
Thomas Huth (5):
ppc: Introduce a function to look up CPU alias strings
hw/ppc/spa
On 09.08.2016 11:17, Thomas Huth wrote:
> There is a regression with the "-cpu" parameter which has been
> introduced by the spapr CPU hotplug code: We used to allow to specify
> a "CPU family" name with the "-cpu" parameter when running on KVM so
> th
registration before
the spapr cpu core registration code.
Signed-off-by: Thomas Huth <th...@redhat.com>
---
target-ppc/kvm.c | 14 +++---
1 file changed, 7 insertions(+), 7 deletions(-)
diff --git a/target-ppc/kvm.c b/target-ppc/kvm.c
index 84764ed..82b1df9 100644
--- a/target-ppc/kvm.c
On 29.06.2016 17:14, alar...@ddci.com wrote:
> David Gibson wrote on 06/28/2016 08:42:01
> PM:
>
>> On Tue, Jun 28, 2016 at 06:50:05AM -0700, Aaron Larson wrote:
>>>
>>> Eliminate redundant and incorrect booke206_page_size_to_tlb function
>>> from ppce500_spin.c in
On 29.06.2016 13:37, Bharata B Rao wrote:
> Introduction of core based CPU hotplug for PowerPC sPAPR didn't
> add support for 970MP and POWER8NVL based core types. Add support for
> the same.
>
> While we are here, add support for explicit specification of POWER5+_v2.1
> core type.
>
>
On 18.06.2016 06:02, Anton Blanchard wrote:
> Hi,
>
Bother. I've tentatively put a revert into ppc-for-2.7. Richard,
do you have a better idea how to fix it?
>>>
>>> Please try the following.
>>
>> Thanks! This passes my tests. Feel free to add:
>>
>> Tested-by: Anton Blanchard
s fine again with the 32-bit qemu-system-sparc64 binary, so:
Tested-by: Thomas Huth <th...@redhat.com>
On 20.06.2016 10:56, Peter Maydell wrote:
> On 20 June 2016 at 09:21, Thomas Huth <th...@redhat.com> wrote:
>> Would it maybe make sense to add some tests for this stuff to the
>> tests/tcg/ folder to make sure that such regressions do not sneak back
>> in in the futu
On 10.06.2016 16:46, Peter Maydell wrote:
> We've noticed recently that the GPG keyservers have fake keys for
> some of the QEMU maintainers, which have keys which have been
> deliberately constructed to have collisions on the 32-bit "short ID"
> field which gpg shows you by default.
>
>
On 02.02.2017 23:44, David Gibson wrote:
> On Wed, Feb 01, 2017 at 11:41:40PM -0800, no-re...@patchew.org wrote:
>> Hi,
>>
>> Your series seems to have some coding style problems. See output below for
>> more information:
[...]
>> Checking PATCH 103/107: tcg/POWER9: NOOP the cp_abort
Triaging old bug tickets... QEMU 1.1 is pretty much outdated, can we
close this bug nowadays? Can you still reproduce the issue with the
latest version of QEMU?
** Changed in: qemu
Status: New => Incomplete
--
You received this bug notification because you are a member of qemu-
devel-ml,
Has the fix mentioned in comment #1 been included in the QEMU
repository?
** Changed in: qemu
Status: New => Incomplete
--
You received this bug notification because you are a member of qemu-
devel-ml, which is subscribed to QEMU.
https://bugs.launchpad.net/bugs/1031920
Title:
Linux
() and SDL_UnlockAudio() to sync
with the sound playback thread instead.
Signed-off-by: Thomas Huth <th...@redhat.com>
---
audio/sdlaudio.c | 48
1 file changed, 48 insertions(+)
diff --git a/audio/sdlaudio.c b/audio/sdlaudio.c
index db69fe1..e
** Changed in: qemu
Status: New => Incomplete
--
You received this bug notification because you are a member of qemu-
devel-ml, which is subscribed to QEMU.
https://bugs.launchpad.net/bugs/1253465
Title:
qemu-img: 'image' uses a vmdk feature which is not supported by this
qemu
This is not a QEMU bug ... for virt-install related problems, please see
https://virt-manager.org/bugs/ instead.
** Changed in: qemu
Status: New => Invalid
--
You received this bug notification because you are a member of qemu-
devel-ml, which is subscribed to QEMU.
Ok, so let's close this now. Thanks for your reply!
** Changed in: qemu
Status: Incomplete => Won't Fix
--
You received this bug notification because you are a member of qemu-
devel-ml, which is subscribed to QEMU.
https://bugs.launchpad.net/bugs/1250360
Title:
qcow2 image logical
Could we close this bug now - I think most people are using 64-bit host
systems nowadays?
** Changed in: qemu
Status: Confirmed => Incomplete
--
You received this bug notification because you are a member of qemu-
devel-ml, which is subscribed to QEMU.
On 01.02.2017 01:10, David Gibson wrote:
> On Tue, Jan 31, 2017 at 02:11:58PM +0100, Thomas Huth wrote:
>> When running with KVM on POWER, we are registering a "family" CPU
>> type for the host CPU that we are running on. For example, on all
>> POWER8-compatible ho
Please always specify the exact version (git commit ID) that you are
using... can you still reproduce this issue with the latest version of
QEMU?
** Changed in: qemu
Status: New => Incomplete
--
You received this bug notification because you are a member of qemu-
devel-ml, which is
ning QEMU with "-cpu ?" on POWER8E or POWER8NVL, you always
get a wrong and confusing entry for the "POWER8" alias.
Please see the description of the first patch for more details.
Thomas Huth (2):
ppc/kvm: Handle the "family" CPU via alias instead of registering new
e the two problems, we should rather update the "family" alias
instead of registering a new types. We then only have one "POWER8"
CPU definition around, an alias, which also points to the right
destination.
Buglink: https://bugzilla.redhat.com/show_bug.cgi?id=1396536
Signed-off-by: Thomas
with "-cpu ?" or "-cpu help".
Signed-off-by: Thomas Huth <th...@redhat.com>
---
vl.c | 10 +-
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/vl.c b/vl.c
index 0b72b12..315c5c3 100644
--- a/vl.c
+++ b/vl.c
@@ -4055,11 +4055,6 @@ int mai
On 01.02.2017 13:11, Shubham Kumar wrote:
>
> I'm a third year Indian engineering student looking for experience in open
> source development. I read about QEMU and I want to be a contributor for this
> organisation.Can you guide me where exactly to start since I'm new to this ??
> Thanks in
hw_error() is for CPU related errors only (it dumps the CPU registers
and calls abort()!), so using error_report() is the better choice
of reporting an error in case we simply did not find a file.
Signed-off-by: Thomas Huth <th...@redhat.com>
---
hw/ppc/pnv.c | 6 +++---
1 file chan
s are only compiled and included when they are
really required.
Signed-off-by: Thomas Huth <th...@redhat.com>
---
default-configs/arm-softmmu.mak | 2 ++
hw/vfio/Makefile.objs | 4 ++--
2 files changed, 4 insertions(+), 2 deletions(-)
diff --git a/default-configs/arm-softmmu.mak b
On 01.02.2017 14:25, Gerd Hoffmann wrote:
> On Di, 2017-01-31 at 09:46 +0100, Thomas Huth wrote:
>> When compiling with SDL2, the semaphore trick used in sdlaudio.c
>> does not work - QEMU locks up completely in this case. To avoid
>> the hang and get at least some audio pl
On 31.01.2017 18:30, Alex Williamson wrote:
> On Tue, 31 Jan 2017 17:36:35 +0100
> Thomas Huth <th...@redhat.com> wrote:
>
>> Both devices seem to be specific to the ARM platform. It's confusing
>> for the users if they show up on other target architectures, too
>&
On 03.02.2017 19:10, Alex Williamson wrote:
> On Tue, 24 Jan 2017 09:02:38 +0100
> Thomas Huth <th...@redhat.com> wrote:
>
>> The device has "bridge" in its name, so it should obviously be in
>> the category DEVICE_CATEGORY_BRIDGE.
>
> Well, physical
The calling function never uses "->fields", so I do not see a real
vulnerability here, is there? Did you use a code analyser for this, or
how did you come across this issue?
--
You received this bug notification because you are a member of qemu-
devel-ml, which is subscribed to QEMU.
The W3 HTML validator (https://validator.w3.org/) complains about
missing "alt" attributes and a missing "" tag for the
new QEMU website. Here are two patches to fix the issues.
Thomas Huth (2):
Add missing HTML tag to close the screenshots section
Add "alt&qu
The final "" tag is missing here.
Signed-off-by: Thomas Huth <th...@redhat.com>
---
index.html | 1 +
1 file changed, 1 insertion(+)
diff --git a/index.html b/index.html
index cf31912..ab33b8a 100644
--- a/index.html
+++ b/index.html
@@ -59,6 +59,7 @@ $('.colorbox').on("c
The "alt" attribute is mandatory for the img tags according to
the HTML standard, so we need this to get valid HTML.
Signed-off-by: Thomas Huth <th...@redhat.com>
---
_includes/screenshot.html | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/_includes/s
** Changed in: qemu
Importance: Undecided => Wishlist
--
You received this bug notification because you are a member of qemu-
devel-ml, which is subscribed to QEMU.
https://bugs.launchpad.net/bugs/1662468
Title:
[feature request] qemu-img convert should respond to control-T like dd
Status
Can't you simply do a "cp delta.qcow2 new.qcow2" ?
--
You received this bug notification because you are a member of qemu-
devel-ml, which is subscribed to QEMU.
https://bugs.launchpad.net/bugs/1662050
Title:
qemu-img convert a overlay qcow2 image into a entire image
Status in QEMU:
Can you still reproduce this issue with the latest version of QEMU
(currently v2.8), or could we close this ticket nowadays?
** Changed in: qemu
Status: New => Incomplete
--
You received this bug notification because you are a member of qemu-
devel-ml, which is subscribed to QEMU.
On 07.02.2017 03:56, Sam Bobroff wrote:
> This provides some new definitions needed by ISA 3.00 guests.
>
> It is a large change because this is the first import since
> some kernel header files have become autogenerated.
>
> Note: update-linux-headers.sh currently generates a change that
>
Sounds like your problem only occurs on older versions of Ubuntu, so
moving this to the QEMU-Ubuntu bug tracker.
** Project changed: qemu => qemu (Ubuntu)
--
You received this bug notification because you are a member of qemu-
devel-ml, which is subscribed to QEMU.
Can you still reproduce this issue with the latest version of QEMU
(currently v2.8)?
** Changed in: qemu
Status: New => Incomplete
--
You received this bug notification because you are a member of qemu-
devel-ml, which is subscribed to QEMU.
https://bugs.launchpad.net/bugs/855800
Title:
On 07.02.2017 11:40, Paolo Bonzini wrote:
>
>
> On 07/02/2017 11:23, Thomas Huth wrote:
>> The W3 HTML validator (https://validator.w3.org/) complains about
>> missing "alt" attributes and a missing "" tag for the
>> new QEMU website. Here are two
QEMU 0.12 is completely outdated nowadays ... can you still reproduce
this issue with the latest version of QEMU (currently v2.8)? If yes,
which graphical backend are you using? SDL1? SDL2? GTK?
** Changed in: qemu
Status: New => Incomplete
--
You received this bug notification because
It took a while 'til I understood the encoding / length calculation of
the property here, but I think you're right. According to LoPAPR the
total length of the property is n+2 where n is the value of the first
byte. Since n is vec_len-1 in the QEMU code, vec_len+1 is the right
value for the property length.
Reviewed-by: Thomas Huth <th...@redhat.com>
error_report() already puts a prefix with the program name in front
of the error strings, so the "qemu:" prefix is not necessary here
anymore.
Reported-by: Markus Armbruster <arm...@redhat.com>
Signed-off-by: Thomas Huth <th...@redhat.com>
---
hw/ppc/pnv.c | 6 +++
The "qemu,register" device needs to be wired up in source code, there
is no way the user can make any real use of this device with the
"-device" parameter or the "device_add" monitor command yet.
Signed-off-by: Thomas Huth <th...@redhat.com>
---
v3: Ano
The "or-irq" device needs to be wired up in source code, there is no
way the user can make any real use of this device with the "-device"
parameter or the "device_add" monitor command yet.
Signed-off-by: Thomas Huth <th...@redhat.com>
---
v3: Another update
Triaging old bug tickets ... QEMU 0.11 and 0.14 are pretty much outdated
nowadays... can you still reproduce this problem with the latest version
of QEMU?
** Changed in: qemu
Status: New => Incomplete
--
You received this bug notification because you are a member of qemu-
devel-ml, which
http://git.qemu.org/?p=qemu.git;a=commitdiff;h=66f6b82bf26cc15e33
** Changed in: qemu
Status: In Progress => Fix Committed
--
You received this bug notification because you are a member of qemu-
devel-ml, which is subscribed to QEMU.
https://bugs.launchpad.net/bugs/1656710
Title:
The patch mentioned in comment #3 had been included in the kernel here:
http://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/commit/?id=7734f6e6bcd7ba78b00e93e74a4ddafd9886cdea
So I guess we can close this bug nowadays? Or can you still reproduce this
issue with the current kernel and
** No longer affects: qemu
--
You received this bug notification because you are a member of qemu-
devel-ml, which is subscribed to QEMU.
https://bugs.launchpad.net/bugs/785668
Title:
bonding inside a bridge does not update ARP correctly when bridged net
accessed from within a VM
Status in
I meant to copy B, not A ... but I likely just haven't really understood
what you're really trying to do here, so never mind.
--
You received this bug notification because you are a member of qemu-
devel-ml, which is subscribed to QEMU.
https://bugs.launchpad.net/bugs/1662050
Title:
qemu-img
On 07.02.2017 18:47, Peter Maydell wrote:
> On 7 February 2017 at 07:50, Juan Quintela wrote:
>> Peter Maydell wrote:
>>> On 6 February 2017 at 16:51, Juan Quintela wrote:
>>
>>> I get a test failure on aarch64 host on one of
Hmm, I'm not aware of a way to disable the PS2 mouse in QEMU yet.
Looking at your other related bug
(https://bugs.launchpad.net/qemu/+bug/813546), I think you might need to
discuss that patch on the qemu-devel mailing list.
--
You received this bug notification because you are a member of qemu-
Sorry, we don't take any patches from the bug tracker... Could you
please post patches on the qemu-devel mailing list instead? Thanks!
** Changed in: qemu
Importance: Undecided => Wishlist
--
You received this bug notification because you are a member of qemu-
devel-ml, which is subscribed
On 03.02.2017 11:36, Ashijeet Acharya wrote:
> Migration of a "none" machine with no RAM crashes abruptly as
> bitmap_new() fails and thus aborts. Instead place zero RAM checks at
> appropriate places to skip migration of RAM in this case and complete
> migration successfully for devices only.
>
On 03.02.2017 10:46, Peter Maydell wrote:
> On 3 February 2017 at 08:36, Thomas Huth <th...@redhat.com> wrote:
>> We've got lot's of C++ comments in the QEMU sources already, and the
>> CODING_STYLE document even does not mention this ... maybe this is just
>> a left-o
** Changed in: qemu
Status: New => Invalid
--
You received this bug notification because you are a member of qemu-
devel-ml, which is subscribed to QEMU.
https://bugs.launchpad.net/bugs/1241569
Title:
qemu-system-alpha console unresponsive
Status in QEMU:
Invalid
Bug description:
Did this issue happen ever again with a recent version of QEMU? ... if
not, should we close this bug nowadays?
** Changed in: qemu
Status: New => Incomplete
--
You received this bug notification because you are a member of qemu-
devel-ml, which is subscribed to QEMU.
The "Machine core" section sounds like a good match for this file.
Signed-off-by: Thomas Huth <th...@redhat.com>
---
MAINTAINERS | 1 +
1 file changed, 1 insertion(+)
diff --git a/MAINTAINERS b/MAINTAINERS
index b5ebfab..5be2033 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -8
Can you still reproduce this issue with the latest version of QEMU, or
could we close this ticket nowadays?
** Changed in: qemu
Status: New => Incomplete
--
You received this bug notification because you are a member of qemu-
devel-ml, which is subscribed to QEMU.
This apparently has nothing to do with QEMU. Closing.
** Changed in: qemu
Status: New => Invalid
--
You received this bug notification because you are a member of qemu-
devel-ml, which is subscribed to QEMU.
https://bugs.launchpad.net/bugs/886147
Title:
Cannot make program Icon on my
Is there still something left to do here, or could we close this ticket
nowadays?
** Changed in: qemu
Status: New => Incomplete
--
You received this bug notification because you are a member of qemu-
devel-ml, which is subscribed to QEMU.
https://bugs.launchpad.net/bugs/1192499
Title:
What does comment #5 mean? Is this issue now fixed with the latest
version of QEMU?
** Changed in: qemu
Status: New => Incomplete
--
You received this bug notification because you are a member of qemu-
devel-ml, which is subscribed to QEMU.
https://bugs.launchpad.net/bugs/1253777
Title:
Looks like your test code from comment #1 still prints out a wrong
value, so the bug has apparently not been fixed by the FPU updates...
** Changed in: qemu
Status: Incomplete => Triaged
--
You received this bug notification because you are a member of qemu-
devel-ml, which is subscribed
On 24.01.2017 08:42, Michael Tokarev wrote:
> 20.01.2017 18:53, Thomas Huth wrote:
>> It has "bridge" in its name, so it should be in the category
>> DEVICE_CATEGORY_BRIDGE.
>>
>> Signed-off-by: Thomas Huth <th...@redhat.com>
>> ---
>>
The device has "bridge" in its name, so it should obviously be in
the category DEVICE_CATEGORY_BRIDGE.
Signed-off-by: Thomas Huth <th...@redhat.com>
---
hw/vfio/pci-quirks.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/hw/vfio/pci-quirks.c b/hw/vfio/pci-quirks.c
index
' parameter as deprecated and informing the users to use the
'netdev' parameter instead.
Signed-off-by: Thomas Huth <th...@redhat.com>
---
net/net.c | 6 ++
1 file changed, 6 insertions(+)
diff --git a/net/net.c b/net/net.c
index 939fe31..fb7af3a 100644
--- a/net/net.c
+++ b/net/net.c
@@
There is no CPU model called "7447_v1.2" in our list, so the
"7447" alias should point to "7447_v1.1" instead. Let's also
remove the "codename" aliases that point to non-implemented
CPU models - they are really of no use here.
Signed-off-by: Thomas Hut
We do not support POWER1 CPUs in QEMU, so it does not make sense
to keep this stub around.
Signed-off-by: Thomas Huth <th...@redhat.com>
---
target/ppc/translate_init.c | 22 --
1 file changed, 22 deletions(-)
diff --git a/target/ppc/translate_init.c b/targ
On 24.01.2017 19:56, Valentin Plotkin wrote:
>
> Hi everyone,
>
> I looked at the "qemu-system-ppc -nographic -cpu G2leGP3 -M ppce500" on
> the BiteSizedTasks page. The segfault was caused by machine
> initialization code which expected a certain MMU model, checked, so
> unused SPR were read,
Can you still reproduce this problem with the latest version of QEMU, or
could we close this ticket nowadays?
** Changed in: qemu
Status: New => Incomplete
--
You received this bug notification because you are a member of qemu-
devel-ml, which is subscribed to QEMU.
** Changed in: qemu
Status: New => Incomplete
--
You received this bug notification because you are a member of qemu-
devel-ml, which is subscribed to QEMU.
https://bugs.launchpad.net/bugs/1254940
Title:
qemu-KVM guest OS occurs many ext3-fs errors after multiple forced
shutdown
On 25.01.2017 08:50, Jason Wang wrote:
>
>
> On 2017年01月24日 17:42, Thomas Huth wrote:
>> The 'vlan' parameter is a continuous source of confusion for the users,
>> many people mix it up with the more common term VLAN (the link layer
>> packet encapsulation
On 24.01.2017 22:41, Valentin Plotkin wrote:
> On Tue, 24 Jan 2017, Thomas Huth wrote:
>
>> Date: Tue, 24 Jan 2017 21:32:44 +0100
>> From: Thomas Huth <th...@redhat.com>
>> To: Valentin Plotkin <calib...@sdf.org>, qemu-triv...@nongnu.org
>> Cc:
t;
machine is likely not suitable for using it as an instruction set
simulator board anyway).
Signed-off-by: Thomas Huth <th...@redhat.com>
---
PS: If we can't agree on using the generic loader here, I can also
prepare a patch instead that simply prints out an error message
if the user
/* for use with drive_add() only */
> /*
> - * IF_IDE must be zero, because we want MachineClass member
> - * block_default_type to default-initialize to IF_IDE
> + * IF_NONE must be zero, because we want MachineClass member
> + * block_default_type to default-initialize to IF_NONE
> */
> -IF_IDE = 0,
> -IF_NONE,
> -IF_SCSI, IF_FLOPPY, IF_PFLASH, IF_MTD, IF_SD, IF_VIRTIO, IF_XEN,
> +IF_NONE = 0,
> +IF_IDE, IF_SCSI, IF_FLOPPY, IF_PFLASH, IF_MTD, IF_SD, IF_VIRTIO, IF_XEN,
> IF_COUNT
> } BlockInterfaceType;
>
>
Makes sense.
Reviewed-by: Thomas Huth <th...@redhat.com>
that is introduced there).
Thomas Huth (5):
checkpatch: add a check for utf-8 in commit logs
checkpatch: check utf-8 content from a commit log when it's missing
from charset
checkpatch: ignore email headers better
checkpatch: emit a reminder about MAINTAINERS on file add/move/delete
checkpatch
On 26.01.2017 14:28, Paolo Bonzini wrote:
>
>
> On 26/01/2017 14:11, Thomas Huth wrote:
>> This is a port of the following commit from the Linux kernel:
>>
>> commit e0d975b1b439c4fef58fbc306c542c94f48bb849
>> Author: Joe Perches <j...@perches.com>
&g
ned-off-by: Andrew Morton <a...@linux-foundation.org>
Signed-off-by: Linus Torvalds <torva...@linux-foundation.org>
Note: I've changed the "WARNING:" into a "NOTE:" since this is often
caused by false positives, so a warning seems too harsh to me.
Signed-o
-off-by: Andrew Morton <a...@linux-foundation.org>
Signed-off-by: Linus Torvalds <torva...@linux-foundation.org>
Signed-off-by: Thomas Huth <th...@redhat.com>
---
scripts/checkpatch.pl | 6 ++
1 file changed, 6 insertions(+)
diff --git a/scripts/checkpatch.pl b/scripts/che
ndrew Morton <a...@linux-foundation.org>
Signed-off-by: Linus Torvalds <torva...@linux-foundation.org>
Signed-off-by: Thomas Huth <th...@redhat.com>
---
scripts/checkpatch.pl | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/scripts/checkpatch.pl b/scrip
Torvalds <torva...@linux-foundation.org>
Signed-off-by: Thomas Huth <th...@redhat.com>
---
scripts/checkpatch.pl | 30 ++
1 file changed, 26 insertions(+), 4 deletions(-)
diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
index f084542..5da4
ter set does not seem to be given
in quotes.
Signed-off-by: Thomas Huth <th...@redhat.com>
---
scripts/checkpatch.pl | 13 +++--
1 file changed, 11 insertions(+), 2 deletions(-)
diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
index 5da423a..0f88e3b 100755
--- a/scripts/check
f --git a/hw/arm/xilinx_zynq.c b/hw/arm/xilinx_zynq.c
> index 7dac20d..3985356 100644
> --- a/hw/arm/xilinx_zynq.c
> +++ b/hw/arm/xilinx_zynq.c
> @@ -323,7 +323,6 @@ static void zynq_machine_init(MachineClass *mc)
> {
> mc->desc = "Xilinx Zynq Platform Baseboard for Cortex-A9";
> mc->init = zynq_init;
> -mc->block_default_type = IF_SCSI;
> mc->max_cpus = 1;
> mc->no_sdcard = 1;
> }
Right, that looks like old copy-n-paste bugs from other machine types.
Reviewed-by: Thomas Huth <th...@redhat.com>
X-2000)";
> mc->init = midway_init;
> -mc->block_default_type = IF_SCSI;
> +mc->block_default_type = IF_IDE;
> +mc->units_per_default_bus = 1;
> mc->max_cpus = 4;
> }
>
>
Reviewed-by: Thomas Huth <th...@redhat.com>
; hw/mips/mips_malta.c| 1 +
> hw/mips/mips_r4k.c | 1 +
> hw/ppc/mac_newworld.c | 1 +
> hw/ppc/mac_oldworld.c | 1 +
> hw/ppc/prep.c | 1 +
> hw/sh4/r2d.c| 1 +
> hw/sparc64/sun4u.c | 2 ++
> 12 files changed, 15 insertions(+)
Patch looks right to me.
Reviewed-by: Thomas Huth <th...@redhat.com>
On 26.01.2017 21:45, Laurent Vivier wrote:
> This is a port to ppc of the i386 commit:
> 00f4d64 kvmclock: clock should count only if vm is running
>
> We remove timebase_/pre_save/post_load/ functions,
> and use the VM state change handler to save and restore
> the guest_timebase (on stop
On 27.01.2017 11:21, Yongbok Kim wrote:
>
>>> Slightly off-topic, but: Is fulong2e still maintained? I did not spot an
>>> entry in MAINTAINERS...?
>>
>> It's covered by the general MIPS stanza:
>>
>> $ scripts/get_maintainer.pl -f hw/mips/mips_fulong2e.c
>> Aurelien Jarno
The "or-irq" device is just used internally. It's strange to
see this device showing up in the "-device ?" help text. Let's mark it
with cannot_instantiate_with_device_add_yet to hide it from the users.
Signed-off-by: Thomas Huth <th...@redhat.com>
---
hw/core/or-irq.c
The "qemu,register" device is just used internally. It's strange to
see this device showing up in the "-device ?" help text. Let's mark it
with cannot_instantiate_with_device_add_yet to hide it from the users.
Signed-off-by: Thomas Huth <th...@redhat.com>
---
hw/core/r
901 - 1000 of 17635 matches
Mail list logo