[Qemu-devel] [qemu devel] disable shared memory is not available with this QEMU binary

Commit 49d2e648e8087d154d8bf8b91f27c8e05e79d5a6 removed the QemuOptDesc elements from the *desc* field of the *qemu_machine_opts *array defined in vl.c. Since applying that patch to qemu on my system, I can not start a guest from libvirt when certain machine options are configured for the

Re: [Qemu-devel] [PATCH for-2.3] util/qemu-config fix regression of qmp_query_command_line_options

all machines properties. We need to find a better fix for 2.4. Reported-by: Tony Krowiak akrow...@linux.vnet.ibm.com Hi Tony, I'll appreciate if you check that it works now. I checked query-command-line-options and it returns the machine options for now. No further changes should be necessary

Re: [Qemu-devel] [RFC 00/19] KVM: s390/crypto/vfio: guest dedicated crypto adapters

On 10/30/2017 04:57 AM, Christian Borntraeger wrote: adding qemu devel and add Daniel and Erik from libvirt to keep them in the loop. On 10/29/2017 12:11 PM, Cornelia Huck wrote: On Fri, 13 Oct 2017 13:38:45 -0400 Tony Krowiak <akrow...@linux.vnet.ibm.com> wrote: Tony Krowiak (19):

Re: [Qemu-devel] [RFC 00/19] KVM: s390/crypto/vfio: guest dedicated crypto adapters

On 10/30/2017 04:57 AM, Christian Borntraeger wrote: adding qemu devel and add Daniel and Erik from libvirt to keep them in the loop. On 10/29/2017 12:11 PM, Cornelia Huck wrote: On Fri, 13 Oct 2017 13:38:45 -0400 Tony Krowiak <akrow...@linux.vnet.ibm.com> wrote: Tony Krowiak (19):

Re: [Qemu-devel] [PATCH v5 4/6] s390x/vfio: ap: Introduce VFIO AP device

On 05/11/2018 06:29 AM, Halil Pasic wrote: On 05/10/2018 03:10 PM, Tony Krowiak wrote: If I did not. I think this is a big problem. We need to at least zeroize the queues (e.g. on system reset) to avoid leaking sensitive information. Without this, there is no sane way to use ap-passthrough

Re: [Qemu-devel] [PATCH v5 4/6] s390x/vfio: ap: Introduce VFIO AP device

On 05/11/2018 05:02 AM, Pierre Morel wrote: On 10/05/2018 15:10, Tony Krowiak wrote: On 05/09/2018 10:28 AM, Halil Pasic wrote: On 05/08/2018 02:25 PM, Tony Krowiak wrote: Introduces a VFIO based AP device. The device is defined via the QEMU command line by specifying: -device vfio-ap

Re: [Qemu-devel] [PATCH v5 6/6] MAINTAINERS: add entries for AP

On 05/08/2018 09:47 AM, Halil Pasic wrote: On 05/08/2018 02:46 PM, Cornelia Huck wrote: On Tue, 8 May 2018 08:25:03 -0400 Tony Krowiak <akrow...@linux.vnet.ibm.com> wrote: Added entries for the s390 adjunct processor (AP) support. Signed-off-by: Tony Krowiak <akrow...@linux.vne

Re: [Qemu-devel] [PATCH v5 6/6] MAINTAINERS: add entries for AP

On 05/08/2018 08:46 AM, Cornelia Huck wrote: On Tue, 8 May 2018 08:25:03 -0400 Tony Krowiak <akrow...@linux.vnet.ibm.com> wrote: Added entries for the s390 adjunct processor (AP) support. Signed-off-by: Tony Krowiak <akrow...@linux.vnet.ibm.com> --- MAINTAINERS | 14 ++

Re: [Qemu-devel] [PATCH v5 6/6] MAINTAINERS: add entries for AP

On 05/08/2018 08:47 AM, Cornelia Huck wrote: On Tue, 8 May 2018 14:46:08 +0200 Cornelia Huck <coh...@redhat.com> wrote: On Tue, 8 May 2018 08:25:03 -0400 Tony Krowiak <akrow...@linux.vnet.ibm.com> wrote: Added entries for the s390 adjunct processor (AP) support. Signed-off-by:

Re: [Qemu-devel] [PATCH v5 4/6] s390x/vfio: ap: Introduce VFIO AP device

On 05/09/2018 10:28 AM, Halil Pasic wrote: On 05/08/2018 02:25 PM, Tony Krowiak wrote: Introduces a VFIO based AP device. The device is defined via the QEMU command line by specifying: -device vfio-ap,sysfsdev= There may be only one vfio-ap device configured for a guest. The mediated

Re: [Qemu-devel] [PATCH v4 3/5] s390x/cpumodel: Set up CPU model for AP device support

On 04/22/2018 12:01 PM, Halil Pasic wrote: On 04/22/2018 05:43 PM, Tony Krowiak wrote: +FEAT_INIT_MISC("ap", "AP facilities installed"), Why plural ('facilities')? Would not s/facilities/instructions be more end-user friendly? It's a matter of opinion. I prefer f

[Qemu-devel] [PATCH v5 3/6] s390x/cpumodel: Set up CPU model for AP device support

if the QCI is installed on the host. 2. The S390_FEAT_AP_FACILITY_TEST feature indicates that the AP Facility Test (APFT) facility is installed. This feature will be enabled by the kernel only if the APFT facility is installed on the host. Signed-off-by: Tony Krowiak <ak

[Qemu-devel] [PATCH v5 0/6] s390x: vfio-ap: guest dedicated crypto adapters

log: === * Added MAINTAINERS entries for VFIO AP * Added explanation for why we are only supporting zEC12 and newer CPU models. * Changed CPU model feature qci=on|off to apqci=on|off * Misc. minor changes Tony Krowiak (6): linux-headers: linux header updates for AP support s390x/ap: b

[Qemu-devel] [PATCH v5 6/6] MAINTAINERS: add entries for AP

Added entries for the s390 adjunct processor (AP) support. Signed-off-by: Tony Krowiak <akrow...@linux.vnet.ibm.com> --- MAINTAINERS | 14 ++ 1 files changed, 14 insertions(+), 0 deletions(-) diff --git a/MAINTAINERS b/MAINTAINERS index 459e359..c9e8d7b 100644 --- a/MAINT

[Qemu-devel] [PATCH v5 5/6] s390: doc: detailed specifications for AP virtualization

This patch provides documentation describing the AP architecture and design concepts behind the virtualization of AP devices. It also includes an example of how to configure AP devices for exclusive use of KVM guests. Signed-off-by: Tony Krowiak <akrow...@linux.vnet.ibm.com> --- docs/vfio-

[Qemu-devel] [PATCH v5 1/6] linux-headers: linux header updates for AP support

information for AP devices Signed-off-by: Tony Krowiak <akrow...@linux.vnet.ibm.com> --- linux-headers/asm-s390/kvm.h |2 ++ linux-headers/linux/vfio.h |2 ++ 2 files changed, 4 insertions(+), 0 deletions(-) diff --git a/linux-headers/asm-s390/kvm.h b/linux-headers/asm-s390/kvm.h index 1

[Qemu-devel] [PATCH v5 2/6] s390x/ap: base Adjunct Processor (AP) object

This patch introduces the base object for an AP device. Signed-off-by: Tony Krowiak <akrow...@linux.vnet.ibm.com> --- hw/s390x/Makefile.objs |1 + hw/s390x/ap-device.c | 39 +++ include/hw/s390x/ap-device.h

[Qemu-devel] [PATCH v5 4/6] s390x/vfio: ap: Introduce VFIO AP device

to be signaled. The vfio_ap device driver's group notification handler will get called at which time the device driver will configure the the AP devices to which the guest will be granted access. Signed-off-by: Tony Krowiak <akrow...@linux.vnet.ibm.com> --- default-configs/s390x-softmmu.mak |1

Re: [Qemu-devel] [PATCH v5 3/6] s390x/cpumodel: Set up CPU model for AP device support

On 05/15/2018 08:00 AM, Pierre Morel wrote: On 08/05/2018 14:25, Tony Krowiak wrote: A new CPU model feature and two new CPU model facilities are introduced to support AP devices for a KVM guest. CPU model features: 1. The KVM_S390_VM_CPU_FEAT_AP CPU model feature indicates that AP

Re: [Qemu-devel] [PATCH v5 4/6] s390x/vfio: ap: Introduce VFIO AP device

On 05/15/2018 03:55 AM, Pierre Morel wrote: On 14/05/2018 21:26, Tony Krowiak wrote: On 05/11/2018 05:02 AM, Pierre Morel wrote: On 10/05/2018 15:10, Tony Krowiak wrote: On 05/09/2018 10:28 AM, Halil Pasic wrote: On 05/08/2018 02:25 PM, Tony Krowiak wrote: Introduces a VFIO based AP

Re: [Qemu-devel] [PATCH v5 3/6] s390x/cpumodel: Set up CPU model for AP device support

On 05/16/2018 05:23 AM, David Hildenbrand wrote: On 16.05.2018 11:05, Pierre Morel wrote: On 15/05/2018 17:03, Tony Krowiak wrote: On 05/15/2018 08:00 AM, Pierre Morel wrote: On 08/05/2018 14:25, Tony Krowiak wrote: A new CPU model feature and two new CPU model facilities are introduced

Re: [Qemu-devel] [PATCH v5 4/6] s390x/vfio: ap: Introduce VFIO AP device

On 05/16/2018 05:09 AM, Pierre Morel wrote: On 15/05/2018 17:09, Tony Krowiak wrote: On 05/15/2018 03:55 AM, Pierre Morel wrote: On 14/05/2018 21:26, Tony Krowiak wrote: On 05/11/2018 05:02 AM, Pierre Morel wrote: On 10/05/2018 15:10, Tony Krowiak wrote: On 05/09/2018 10:28 AM, Halil Pasic

[Qemu-devel] [PATCH v6 3/5] s390x/ap: base Adjunct Processor (AP) object model

From: Tony Krowiak Introduces the base object model for virtualizing AP devices. Signed-off-by: Tony Krowiak --- MAINTAINERS | 12 +++ hw/s390x/Makefile.objs |2 + hw/s390x/ap-bridge.c | 76 ++ hw/s390x/ap

[Qemu-devel] [PATCH v6 2/5] s390x/cpumodel: Set up CPU model for AP device support

if the QCI is installed on the host. 2. The S390_FEAT_AP_FACILITY_TEST feature indicates that the AP Facility Test (APFT) facility is installed. This feature will be enabled by the kernel only if the APFT facility is installed on the host. Signed-off-by: Tony Krowiak Signed-off

[Qemu-devel] [PATCH v6 1/5] linux-headers: linux header updates for AP support

information for AP devices Signed-off-by: Tony Krowiak Signed-off-by: Tony Krowiak --- linux-headers/asm-s390/kvm.h |2 ++ linux-headers/linux/vfio.h |2 ++ 2 files changed, 4 insertions(+), 0 deletions(-) diff --git a/linux-headers/asm-s390/kvm.h b/linux-headers/asm-s390/kvm.h index 11def14

[Qemu-devel] [PATCH v6 5/5] s390: doc: detailed specifications for AP virtualization

This patch provides documentation describing the AP architecture and design concepts behind the virtualization of AP devices. It also includes an example of how to configure AP devices for exclusive use of KVM guests. Signed-off-by: Tony Krowiak Signed-off-by: Tony Krowiak --- MAINTAINERS

[Qemu-devel] [PATCH v6 0/5] s390x: vfio-ap: guest dedicated crypto adapters

From: Tony Krowiak This patch series is the QEMU counterpart to the KVM/kernel support for guest dedicated crypto adapters. The KVM/kernel model is built on the VFIO mediated device framework and provides the infrastructure for granting exclusive guest access to crypto devices installed

[Qemu-devel] [PATCH v6 4/5] s390x/vfio: ap: Introduce VFIO AP device

to be signaled. The vfio_ap device driver's group notification handler will get called at which time the device driver will configure the the AP devices to which the guest will be granted access. Signed-off-by: Tony Krowiak Signed-off-by: Tony Krowiak --- MAINTAINERS |1

Re: [Qemu-devel] [PATCH v4 3/5] s390x/cpumodel: Set up CPU model for AP device support

On 04/18/2018 04:59 AM, David Hildenbrand wrote: On 18.04.2018 09:40, Cornelia Huck wrote: On Tue, 17 Apr 2018 20:21:31 +0200 Christian Borntraeger wrote: On 04/16/2018 05:44 PM, David Hildenbrand wrote: diff --git a/target/s390x/gen-features.c

Re: [Qemu-devel] [PATCH v6 0/5] s390x: vfio-ap: guest dedicated crypto adapters

Ping On 06/29/2018 06:47 PM, Tony Krowiak wrote: From: Tony Krowiak This patch series is the QEMU counterpart to the KVM/kernel support for guest dedicated crypto adapters. The KVM/kernel model is built on the VFIO mediated device framework and provides the infrastructure for granting

Re: [Qemu-devel] [PATCH v6 0/5] s390x: vfio-ap: guest dedicated crypto adapters

On 08/08/2018 03:34 AM, Cornelia Huck wrote: On Tue, 7 Aug 2018 18:41:29 -0400 Tony Krowiak wrote: Ping Maybe send a new version when the kernel part is sent again? I don't think I had any further comments. I'll consider that. On 06/29/2018 06:47 PM, Tony Krowiak wrote: From: Tony

Re: [Qemu-devel] [PATCH v6 4/5] s390x/vfio: ap: Introduce VFIO AP device

On 07/04/2018 01:24 PM, Cornelia Huck wrote: On Fri, 29 Jun 2018 18:48:02 -0400 Tony Krowiak wrote: Introduces a VFIO based AP device. The device is defined via the QEMU command line by specifying: -device vfio-ap,sysfsdev= There may be only one vfio-ap device configured for a guest

Re: [Qemu-devel] [PATCH v2 5/5] s390x/cpumodel: Set up CPU model for AP device support

On 03/07/2018 09:41 AM, Cornelia Huck wrote: On Wed, 7 Mar 2018 11:09:46 +0100 Pierre Morel wrote: What I mean is the reverse implication ECA_APIE => ap=on But you can have ap = on and ECA_APIE = off This is interception or emulation. and the second thing is that

[Qemu-devel] [PATCH v2 5/5] s390x/cpumodel: Set up CPU model for AP device support

only if the KVM_S390_VM_CPU_FEAT_AP CPU model feature is turned on. (see CPU model features above) Signed-off-by: Tony Krowiak <akrow...@linux.vnet.ibm.com> --- hw/vfio/ap.c|9 + linux-headers/asm-s390/kvm.h|1 + target/s390x/cpu_features.c

[Qemu-devel] [PATCH v2 4/5] s390x/vfio: ap: Introduce VFIO AP device

will get called at which time the device driver will configure the the AP devices to which the guest will be granted access. Signed-off-by: Tony Krowiak <akrow...@linux.vnet.ibm.com> --- default-configs/s390x-softmmu.mak |1 + hw/vfio/Makefile.objs |1 + hw/vfi

[Qemu-devel] [PATCH v2 1/5] s390: doc: detailed specifications for AP virtualization

This patch provides documentation describing the AP architecture and design concepts behind the virtualization of AP devices. It also includes an example of how to configure AP devices for exclusive use of KVM guests. Signed-off-by: Tony Krowiak <akrow...@linux.vnet.ibm.com> --- docs/vfio-

[Qemu-devel] [PATCH v2 2/5] s390x/ap: base Adjunct Processor (AP) object

This patch introduces the base object for an AP device. Signed-off-by: Tony Krowiak <akrow...@linux.vnet.ibm.com> --- hw/s390x/Makefile.objs |1 + hw/s390x/ap-device.c | 38 ++ include/hw/s390x/ap-device.h

[Qemu-devel] [PATCH v2 0/5] s390x: vfio-ap: guest dedicated crypto adapters

rix-device.c to ap-device.c (in hw/s390x) * ap-matrix-device.h to ap-device.h (in include/hw/s390x) * Added CPU model feature for AP facilities installed on guest and facilities features for QCI Instructions Available (STFLE.12) and AP Facilities Test facility installed (STFLE.15). Tony Krowiak

[Qemu-devel] [PATCH v2 3/5] s390x/vfio: ap: VFIO: linux header updates

Updates the vfio header files in preparation for introduction of the VFIO AP device. Signed-off-by: Tony Krowiak <akrow...@linux.vnet.ibm.com> --- linux-headers/linux/vfio.h |2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git a/linux-headers/linux/vfio.h b/linux-headers

Re: [Qemu-devel] [PATCH v2 5/5] s390x/cpumodel: Set up CPU model for AP device support

On 02/27/2018 12:52 PM, David Hildenbrand wrote: vfio_group = vfio_ap_get_group(vapdev, _err); if (!vfio_group) { goto out_err; diff --git a/linux-headers/asm-s390/kvm.h b/linux-headers/asm-s390/kvm.h index 11def14..35a6d04 100644 --- a/linux-headers/asm-s390/kvm.h +++

Re: [Qemu-devel] [PATCH v2 5/5] s390x/cpumodel: Set up CPU model for AP device support

On 02/27/2018 11:27 AM, Cornelia Huck wrote: On Tue, 27 Feb 2018 10:44:19 -0500 Tony Krowiak <akrow...@linux.vnet.ibm.com> wrote: A new CPU model feature and two new CPU model facilities are introduced to support AP devices for a KVM guest. CPU model features: 1. The KVM_S390_VM_CPU_F

Re: [Qemu-devel] [PATCH v2 5/5] s390x/cpumodel: Set up CPU model for AP device support

On 02/27/2018 11:49 AM, Halil Pasic wrote: On 02/27/2018 05:27 PM, Cornelia Huck wrote: On Tue, 27 Feb 2018 10:44:19 -0500 Tony Krowiak <akrow...@linux.vnet.ibm.com> wrote: A new CPU model feature and two new CPU model facilities are introduced to support AP devices for a KVM guest

Re: [Qemu-devel] [PATCH v2 4/5] s390x/vfio: ap: Introduce VFIO AP device

On 02/27/2018 12:04 PM, Cornelia Huck wrote: On Tue, 27 Feb 2018 10:44:18 -0500 Tony Krowiak <akrow...@linux.vnet.ibm.com> wrote: Introduces a VFIO based AP device. The device is defined via the QEMU command line by specifying: -device vfio-ap,sysfsdev= The mediated matrix

[Qemu-devel] [PATCH v3 4/7] s390x/kvm: interface to interpret AP instructions

The VFIO AP device exploits interpretive execution of AP instructions (APIE). APIE is enabled by setting a device attribute via the KVM_SET_DEVICE_ATTR ioctl. Signed-off-by: Tony Krowiak <akrow...@linux.vnet.ibm.com> --- target/s390x/kvm.c | 16 target/s390x/kvm_s

[Qemu-devel] [PATCH v3 6/7] s390x/kvm: handle AP instruction interception

injected into the guest and the AP bus will not initialize on the guest. That is commensurate with how things work today. Signed-off-by: Tony Krowiak <akrow...@linux.vnet.ibm.com> --- hw/vfio/ap.c | 45 ++ include/hw/s390x/ap-device.h

[Qemu-devel] [PATCH v3 3/7] s390x/cpumodel: Set up CPU model for AP device support

. This feature will be enabled by the kernel only if the APFT facility is installed on the host. Signed-off-by: Tony Krowiak <akrow...@linux.vnet.ibm.com> --- target/s390x/cpu_features.c |3 +++ target/s390x/cpu_features_def.h |3 +++ target/s390x/cpu_models.c

[Qemu-devel] [PATCH v3 7/7] s390: doc: detailed specifications for AP virtualization

This patch provides documentation describing the AP architecture and design concepts behind the virtualization of AP devices. It also includes an example of how to configure AP devices for exclusive use of KVM guests. Signed-off-by: Tony Krowiak <akrow...@linux.vnet.ibm.com> --- docs/vfio-

[Qemu-devel] [PATCH v3 2/7] s390x/ap: base Adjunct Processor (AP) object

This patch introduces the base object for an AP device. Signed-off-by: Tony Krowiak <akrow...@linux.vnet.ibm.com> --- hw/s390x/Makefile.objs |1 + hw/s390x/ap-device.c | 38 ++ include/hw/s390x/ap-device.h

[Qemu-devel] [PATCH v3 5/7] s390x/vfio: ap: Introduce VFIO AP device

will get called at which time the device driver will configure the the AP devices to which the guest will be granted access. Signed-off-by: Tony Krowiak <akrow...@linux.vnet.ibm.com> --- default-configs/s390x-softmmu.mak |1 + hw/vfio/Makefile.objs |1 + hw/vfi

[Qemu-devel] [PATCH v3 1/7] linux-headers: linux header updates for AP support

information for AP devices Signed-off-by: Tony Krowiak <akrow...@linux.vnet.ibm.com> --- linux-headers/asm-s390/kvm.h |2 ++ linux-headers/linux/vfio.h |2 ++ 2 files changed, 4 insertions(+), 0 deletions(-) diff --git a/linux-headers/asm-s390/kvm.h b/linux-headers/asm-s390/kvm.h index 1

[Qemu-devel] [PATCH v3 0/7] s390x: vfio-ap: guest dedicated crypto adapters

ich case the AP bus would not initialize. This is the same behavior as exists prior to the introduction of this patch series. * Miscellaneous code formatting and other trivial changes. Tony Krowiak (7): linux-headers: linux header updates for AP support s390x/ap: base Adjunct Proces

Re: [Qemu-devel] [PATCH v3 3/7] s390x/cpumodel: Set up CPU model for AP device support

On 04/06/2018 10:51 AM, Pierre Morel wrote: On 16/03/2018 00:24, Tony Krowiak wrote: A new CPU model feature and two new CPU model facilities are introduced to support AP devices for a KVM guest. CPU model features: 1. The KVM_S390_VM_CPU_FEAT_AP CPU model feature indicates that AP

Re: [Qemu-devel] [PATCH v3 6/7] s390x/kvm: handle AP instruction interception

On 04/04/2018 07:09 AM, Pierre Morel wrote: On 02/04/2018 18:36, Tony Krowiak wrote: On 03/26/2018 05:03 AM, Pierre Morel wrote: On 26/03/2018 10:32, David Hildenbrand wrote: On 16.03.2018 00:24, Tony Krowiak wrote: If the CPU model indicates that AP facility is installed on the guest (i.e

Re: [Qemu-devel] [PATCH v3 6/7] s390x/kvm: handle AP instruction interception

On 04/04/2018 07:09 AM, Pierre Morel wrote: On 02/04/2018 18:36, Tony Krowiak wrote: On 03/26/2018 05:03 AM, Pierre Morel wrote: On 26/03/2018 10:32, David Hildenbrand wrote: On 16.03.2018 00:24, Tony Krowiak wrote: If the CPU model indicates that AP facility is installed on the guest (i.e

Re: [Qemu-devel] [PATCH v3 6/7] s390x/kvm: handle AP instruction interception

On 04/03/2018 05:36 AM, Cornelia Huck wrote: On Mon, 2 Apr 2018 12:36:27 -0400 Tony Krowiak <akrow...@linux.vnet.ibm.com> wrote: On 03/26/2018 05:03 AM, Pierre Morel wrote: On 26/03/2018 10:32, David Hildenbrand wrote: On 16.03.2018 00:24, Tony Krowiak wrote: +/* + * The

Re: [Qemu-devel] [PATCH v3 6/7] s390x/kvm: handle AP instruction interception

On 04/03/2018 05:36 AM, Cornelia Huck wrote: On Mon, 2 Apr 2018 12:36:27 -0400 Tony Krowiak <akrow...@linux.vnet.ibm.com> wrote: On 03/26/2018 05:03 AM, Pierre Morel wrote: On 26/03/2018 10:32, David Hildenbrand wrote: On 16.03.2018 00:24, Tony Krowiak wrote: +/* + * The

Re: [Qemu-devel] [PATCH v3 6/7] s390x/kvm: handle AP instruction interception

On 04/09/2018 06:51 AM, Cornelia Huck wrote: On Mon, 9 Apr 2018 12:37:42 +0200 Halil Pasic wrote: On 04/09/2018 11:32 AM, Cornelia Huck wrote: We can kind of (i.e. modulo EECA.28) ensure this in a different fashion I think. How about proclaiming a 'has ap

Re: [Qemu-devel] [PATCH v3 6/7] s390x/kvm: handle AP instruction interception

On 04/09/2018 05:32 AM, Cornelia Huck wrote: On Fri, 6 Apr 2018 18:07:56 +0200 Halil Pasic <pa...@linux.vnet.ibm.com> wrote: On 04/05/2018 06:38 PM, Tony Krowiak wrote: On 04/03/2018 05:36 AM, Cornelia Huck wrote: On Mon, 2 Apr 2018 12:36:27 -0400 Tony Krowiak <akrow...@linux.vne

Re: [Qemu-devel] [PATCH v3 6/7] s390x/kvm: handle AP instruction interception

On 04/11/2018 09:50 AM, Halil Pasic wrote: On 04/11/2018 03:20 PM, Tony Krowiak wrote: I may be all wrong, though... can we at least have a translation of ECA.28 and EECA.28 (the "ap is there" bit and the "ap instructions are interpreted" bit?) I think we have a misu

Re: [Qemu-devel] [PATCH v3 6/7] s390x/kvm: handle AP instruction interception

On 04/04/2018 09:43 AM, Pierre Morel wrote: On 04/04/2018 15:33, Tony Krowiak wrote: On 04/04/2018 07:09 AM, Pierre Morel wrote: On 02/04/2018 18:36, Tony Krowiak wrote: On 03/26/2018 05:03 AM, Pierre Morel wrote: On 26/03/2018 10:32, David Hildenbrand wrote: On 16.03.2018 00:24, Tony

[Qemu-devel] [PATCH v4 4/5] s390x/vfio: ap: Introduce VFIO AP device

to be signaled. The vfio_ap device driver's group notification handler will get called at which time the device driver will configure the the AP devices to which the guest will be granted access. Signed-off-by: Tony Krowiak <akrow...@linux.vnet.ibm.com> --- default-configs/s390x-softmmu.mak |1

[Qemu-devel] [PATCH v4 1/5] linux-headers: linux header updates for AP support

information for AP devices Signed-off-by: Tony Krowiak <akrow...@linux.vnet.ibm.com> --- linux-headers/asm-s390/kvm.h |2 ++ linux-headers/linux/vfio.h |2 ++ 2 files changed, 4 insertions(+), 0 deletions(-) diff --git a/linux-headers/asm-s390/kvm.h b/linux-headers/asm-s390/kvm.h index 1

[Qemu-devel] [PATCH v4 3/5] s390x/cpumodel: Set up CPU model for AP device support

. This feature will be enabled by the kernel only if the APFT facility is installed on the host. Signed-off-by: Tony Krowiak <akrow...@linux.vnet.ibm.com> --- target/s390x/cpu_features.c |3 +++ target/s390x/cpu_features_def.h |3 +++ target/s390x/cpu_models.c

[Qemu-devel] [PATCH v4 0/5] s390x: vfio-ap: guest dedicated crypto adapters

check to ensure only one vfio-ap device can be configured per guest * Removed AP instruction interception handlers: AP instructions will be interpreted by default if AP facilities are installed to handle the case where feature ap=on and no vfio-ap device is configured for the guest. Tony Krow

[Qemu-devel] [PATCH v4 2/5] s390x/ap: base Adjunct Processor (AP) object

This patch introduces the base object for an AP device. Signed-off-by: Tony Krowiak <akrow...@linux.vnet.ibm.com> --- hw/s390x/Makefile.objs |1 + hw/s390x/ap-device.c | 39 +++ include/hw/s390x/ap-device.h

[Qemu-devel] [PATCH v4 5/5] s390: doc: detailed specifications for AP virtualization

This patch provides documentation describing the AP architecture and design concepts behind the virtualization of AP devices. It also includes an example of how to configure AP devices for exclusive use of KVM guests. Signed-off-by: Tony Krowiak <akrow...@linux.vnet.ibm.com> --- docs/vfio-

Re: [Qemu-devel] [PATCH v4 0/5] s390x: vfio-ap: guest dedicated crypto adapters

On 04/19/2018 07:51 AM, Cornelia Huck wrote: On Sun, 15 Apr 2018 15:07:19 -0400 Tony Krowiak <akrow...@linux.vnet.ibm.com> wrote: default-configs/s390x-softmmu.mak |1 + docs/vfio-ap.txt | 649 + hw/s390x/Makefil

Re: [Qemu-devel] [PATCH v4 3/5] s390x/cpumodel: Set up CPU model for AP device support

On 04/22/2018 12:01 PM, Halil Pasic wrote: On 04/22/2018 05:43 PM, Tony Krowiak wrote: +FEAT_INIT_MISC("ap", "AP facilities installed"), Why plural ('facilities')? Would not s/facilities/instructions be more end-user friendly? It's a matter of opinion. I prefer f

Re: [Qemu-devel] [PATCH v4 2/5] s390x/ap: base Adjunct Processor (AP) object

On 04/18/2018 05:16 AM, Pierre Morel wrote: On 15/04/2018 21:07, Tony Krowiak wrote: This patch introduces the base object for an AP device. Signed-off-by: Tony Krowiak <akrow...@linux.vnet.ibm.com> --- hw/s390x/Makefile.objs |1 + hw/s390x/ap-device.c

Re: [Qemu-devel] [PATCH v4 3/5] s390x/cpumodel: Set up CPU model for AP device support

On 04/18/2018 04:59 AM, David Hildenbrand wrote: On 18.04.2018 09:40, Cornelia Huck wrote: On Tue, 17 Apr 2018 20:21:31 +0200 Christian Borntraeger wrote: On 04/16/2018 05:44 PM, David Hildenbrand wrote: diff --git a/target/s390x/gen-features.c

Re: [Qemu-devel] [PATCH v4 3/5] s390x/cpumodel: Set up CPU model for AP device support

On 04/18/2018 03:40 AM, Cornelia Huck wrote: On Tue, 17 Apr 2018 20:21:31 +0200 Christian Borntraeger wrote: On 04/16/2018 05:44 PM, David Hildenbrand wrote: diff --git a/target/s390x/gen-features.c b/target/s390x/gen-features.c index 0cdbc15..0d5b0f7 100644

Re: [Qemu-devel] [PATCH v4 3/5] s390x/cpumodel: Set up CPU model for AP device support

On 04/18/2018 06:55 AM, Halil Pasic wrote: On 04/15/2018 09:07 PM, Tony Krowiak wrote: A new CPU model feature and two new CPU model facilities are introduced to support AP devices for a KVM guest. [..] diff --git a/target/s390x/cpu_features.c b/target/s390x/cpu_features.c index 3b9e274

Re: [Qemu-devel] [PATCH v4 3/5] s390x/cpumodel: Set up CPU model for AP device support

On 04/18/2018 07:03 AM, David Hildenbrand wrote: On 18.04.2018 12:55, Halil Pasic wrote: On 04/15/2018 09:07 PM, Tony Krowiak wrote: A new CPU model feature and two new CPU model facilities are introduced to support AP devices for a KVM guest. [..] diff --git a/target/s390x/cpu_features.c b

Re: [Qemu-devel] [PATCH v4 3/5] s390x/cpumodel: Set up CPU model for AP device support

On 04/18/2018 06:55 AM, Halil Pasic wrote: On 04/15/2018 09:07 PM, Tony Krowiak wrote: A new CPU model feature and two new CPU model facilities are introduced to support AP devices for a KVM guest. [..] diff --git a/target/s390x/cpu_features.c b/target/s390x/cpu_features.c index 3b9e274

Re: [Qemu-devel] [PATCH v4 4/5] s390x/vfio: ap: Introduce VFIO AP device

On 04/18/2018 05:11 AM, Pierre Morel wrote: On 15/04/2018 21:07, Tony Krowiak wrote: Introduces a VFIO based AP device. The device is defined via the QEMU command line by specifying: -device vfio-ap,sysfsdev= There may be only one vfio-ap device configured for a guest. The mediated

Re: [Qemu-devel] [PATCH v4 4/5] s390x/vfio: ap: Introduce VFIO AP device

On 04/19/2018 08:03 AM, Cornelia Huck wrote: On Sun, 15 Apr 2018 15:07:23 -0400 Tony Krowiak <akrow...@linux.vnet.ibm.com> wrote: Introduces a VFIO based AP device. The device is defined via the QEMU command line by specifying: -device vfio-ap,sysfsdev= There may be only one v

Re: [Qemu-devel] [PATCH v4 3/5] s390x/cpumodel: Set up CPU model for AP device support

On 04/16/2018 11:44 AM, David Hildenbrand wrote: diff --git a/target/s390x/gen-features.c b/target/s390x/gen-features.c index 0cdbc15..0d5b0f7 100644 --- a/target/s390x/gen-features.c +++ b/target/s390x/gen-features.c @@ -447,6 +447,9 @@ static uint16_t full_GEN12_GA1[] = {

Re: [Qemu-devel] [PATCH v3 6/7] s390x/kvm: handle AP instruction interception

On 03/26/2018 04:32 AM, David Hildenbrand wrote: On 16.03.2018 00:24, Tony Krowiak wrote: If the CPU model indicates that AP facility is installed on the guest (i.e., -cpu ,ap=on), then the expectation is that the AP bus running in the guest will initialize; however, if the AP instructions

Re: [Qemu-devel] [PATCH v3 6/7] s390x/kvm: handle AP instruction interception

On 03/26/2018 05:03 AM, Pierre Morel wrote: On 26/03/2018 10:32, David Hildenbrand wrote: On 16.03.2018 00:24, Tony Krowiak wrote: If the CPU model indicates that AP facility is installed on the guest (i.e., -cpu ,ap=on), then the expectation is that the AP bus running in the guest

Re: [Qemu-devel] [PATCH v3 4/7] s390x/kvm: interface to interpret AP instructions

On 03/26/2018 04:38 AM, David Hildenbrand wrote: On 16.03.2018 00:24, Tony Krowiak wrote: The VFIO AP device exploits interpretive execution of AP instructions (APIE). APIE is enabled by setting a device attribute via the KVM_SET_DEVICE_ATTR ioctl. Signed-off-by: Tony Krowiak <ak

Re: [Qemu-devel] [PATCH v3 5/7] s390x/vfio: ap: Introduce VFIO AP device

On 03/27/2018 08:02 AM, Cornelia Huck wrote: On Fri, 16 Mar 2018 14:22:52 +0100 Halil Pasic <pa...@linux.vnet.ibm.com> wrote: On 03/16/2018 11:42 AM, Pierre Morel wrote: On 16/03/2018 00:24, Tony Krowiak wrote: Introduces a VFIO based AP device. The device is defined via the QEMU c

Re: [Qemu-devel] [PATCH v3 6/7] s390x/kvm: handle AP instruction interception

On 03/26/2018 08:01 AM, Halil Pasic wrote: On 03/26/2018 11:03 AM, Pierre Morel wrote: +int ap_device_handle_pqap(S390CPU *cpu) +{ +CPUS390XState *env = >env; +int fc = 4 & (env->regs[0] >> 24); + +/* + * The Query Configuration Information (QCI) function (fc == 4) does not +

Re: [Qemu-devel] [PATCH v3 7/7] s390: doc: detailed specifications for AP virtualization

On 03/16/2018 06:03 AM, Pierre Morel wrote: On 16/03/2018 00:25, Tony Krowiak wrote: This patch provides documentation describing the AP architecture and design concepts behind the virtualization of AP devices. It also includes an example of how to configure AP devices for exclusive use of KVM

Re: [Qemu-devel] [PATCH v3 5/7] s390x/vfio: ap: Introduce VFIO AP device

On 04/02/2018 01:05 PM, Tony Krowiak wrote: On 03/27/2018 08:02 AM, Cornelia Huck wrote: On Fri, 16 Mar 2018 14:22:52 +0100 Halil Pasic <pa...@linux.vnet.ibm.com> wrote: On 03/16/2018 11:42 AM, Pierre Morel wrote: On 16/03/2018 00:24, Tony Krowiak wrote: Introduces a VFIO based AP

Re: [Qemu-devel] [PATCH v3 7/7] s390: doc: detailed specifications for AP virtualization

On 03/16/2018 06:03 AM, Pierre Morel wrote: On 16/03/2018 00:25, Tony Krowiak wrote: This patch provides documentation describing the AP architecture and design concepts behind the virtualization of AP devices. It also includes an example of how to configure AP devices for exclusive use of KVM

Re: [Qemu-devel] [PATCH v3 2/7] s390x/ap: base Adjunct Processor (AP) object

On 03/16/2018 06:38 AM, Pierre Morel wrote: On 16/03/2018 00:24, Tony Krowiak wrote: This patch introduces the base object for an AP device. Signed-off-by: Tony Krowiak <akrow...@linux.vnet.ibm.com> --- hw/s390x/Makefile.objs |1 + hw/s390x/ap-device.c

Re: [Qemu-devel] [PATCH v3 4/7] s390x/kvm: interface to interpret AP instructions

On 03/16/2018 06:36 AM, Pierre Morel wrote: On 16/03/2018 00:24, Tony Krowiak wrote: The VFIO AP device exploits interpretive execution of AP instructions (APIE). APIE is enabled by setting a device attribute via the KVM_SET_DEVICE_ATTR ioctl. Signed-off-by: Tony Krowiak <ak

Re: [Qemu-devel] [PATCH v3 5/7] s390x/vfio: ap: Introduce VFIO AP device

On 03/16/2018 09:22 AM, Halil Pasic wrote: On 03/16/2018 11:42 AM, Pierre Morel wrote: On 16/03/2018 00:24, Tony Krowiak wrote: Introduces a VFIO based AP device. The device is defined via the QEMU command line by specifying: -device vfio-ap,sysfsdev= The mediated matrix device

Re: [Qemu-devel] [PATCH v3 5/7] s390x/vfio: ap: Introduce VFIO AP device

On 03/16/2018 11:36 AM, Halil Pasic wrote: On 03/16/2018 04:29 PM, Tony Krowiak wrote: However it is a general switch for the VM. It looks strange to have this inside the realize callback I kind of semi agree. The previous solution (having this transparent for QEMU) had benefits. Why did we

Re: [Qemu-devel] [PATCH v3 6/7] s390x/kvm: handle AP instruction interception

On 03/16/2018 04:03 AM, Pierre Morel wrote: On 16/03/2018 00:24, Tony Krowiak wrote: If the CPU model indicates that AP facility is installed on the guest (i.e., -cpu ,ap=on), then the expectation is that the AP bus running in the guest will initialize; however, if the AP instructions

Re: [Qemu-devel] [PATCH v3 3/7] s390x/cpumodel: Set up CPU model for AP device support

On 03/16/2018 05:36 AM, Pierre Morel wrote: On 16/03/2018 00:24, Tony Krowiak wrote: A new CPU model feature and two new CPU model facilities are introduced to support AP devices for a KVM guest. CPU model features: 1. The KVM_S390_VM_CPU_FEAT_AP CPU model feature indicates that AP

Re: [Qemu-devel] [PATCH v3 5/7] s390x/vfio: ap: Introduce VFIO AP device

On 03/16/2018 06:42 AM, Pierre Morel wrote: On 16/03/2018 00:24, Tony Krowiak wrote: Introduces a VFIO based AP device. The device is defined via the QEMU command line by specifying: -device vfio-ap,sysfsdev= The mediated matrix device is created by the VFIO AP device driver by writing

Re: [Qemu-devel] [PATCH v3 4/7] s390x/kvm: interface to interpret AP instructions

On 03/15/2018 07:24 PM, Tony Krowiak wrote: The VFIO AP device exploits interpretive execution of AP instructions (APIE). APIE is enabled by setting a device attribute via the KVM_SET_DEVICE_ATTR ioctl. Signed-off-by: Tony Krowiak <akrow...@linux.vnet.ibm.com> --- target/s390x

Re: [Qemu-devel] [PATCH v2 5/5] s390x/cpumodel: Set up CPU model for AP device support

On 03/01/2018 09:36 AM, David Hildenbrand wrote: On 01.03.2018 15:12, Pierre Morel wrote: On 28/02/2018 12:40, Cornelia Huck wrote: On Wed, 28 Feb 2018 11:26:30 +0100 David Hildenbrand wrote: Then I request the following change in KVM: If KVM_S390_VM_CPU_FEAT_AP is

Re: [Qemu-devel] [PATCH v2 5/5] s390x/cpumodel: Set up CPU model for AP device support

On 03/01/2018 09:12 AM, Pierre Morel wrote: On 28/02/2018 12:40, Cornelia Huck wrote: On Wed, 28 Feb 2018 11:26:30 +0100 David Hildenbrand wrote: Then I request the following change in KVM: If KVM_S390_VM_CPU_FEAT_AP is enabled in KVM, ECA.28 is _always_ set (not just if

Re: [Qemu-devel] [PATCH v2 5/5] s390x/cpumodel: Set up CPU model for AP device support

On 03/01/2018 09:36 AM, David Hildenbrand wrote: On 01.03.2018 15:12, Pierre Morel wrote: On 28/02/2018 12:40, Cornelia Huck wrote: On Wed, 28 Feb 2018 11:26:30 +0100 David Hildenbrand wrote: Then I request the following change in KVM: If KVM_S390_VM_CPU_FEAT_AP is

Re: [Qemu-devel] [PATCH v4 4/5] s390x/vfio: ap: Introduce VFIO AP device

On 04/23/2018 03:00 AM, Cornelia Huck wrote: On Sun, 22 Apr 2018 12:05:44 -0400 Tony Krowiak <akrow...@linux.vnet.ibm.com> wrote: On 04/19/2018 08:03 AM, Cornelia Huck wrote: On Sun, 15 Apr 2018 15:07:23 -0400 Tony Krowiak <akrow...@linux.vnet.ibm.com> wrote: Introduces a V

Re: [Qemu-devel] [qemu-s390x] [PATCH v9 4/6] s390x/ap: base Adjunct Processor (AP) object model

On 10/08/2018 10:35 AM, Cornelia Huck wrote: On Mon, 8 Oct 2018 16:22:27 +0200 David Hildenbrand wrote: On 08/10/2018 16:20, Tony Krowiak wrote: On 09/27/2018 08:52 AM, Cornelia Huck wrote: On Thu, 27 Sep 2018 14:29:01 +0200 Thomas Huth wrote: On 2018-09-27 00:54, Tony Krowiak wrote

Re: [Qemu-devel] [qemu-s390x] [PATCH v9 4/6] s390x/ap: base Adjunct Processor (AP) object model

On 09/27/2018 08:52 AM, Cornelia Huck wrote: On Thu, 27 Sep 2018 14:29:01 +0200 Thomas Huth wrote: On 2018-09-27 00:54, Tony Krowiak wrote: From: Tony Krowiak Introduces the base object model for virtualizing AP devices. Signed-off-by: Tony Krowiak --- +typedef struct APBridge

Re: [Qemu-devel] [qemu-s390x] [PATCH v9 4/6] s390x/ap: base Adjunct Processor (AP) object model

On 10/08/2018 10:44 AM, Thomas Huth wrote: On 2018-10-08 16:20, Tony Krowiak wrote: On 09/27/2018 08:52 AM, Cornelia Huck wrote: On Thu, 27 Sep 2018 14:29:01 +0200 Thomas Huth wrote: On 2018-09-27 00:54, Tony Krowiak wrote: From: Tony Krowiak Introduces the base object model

  1   2   >