Re: [Qemu-devel] [PATCH] virtio-pci: Add subsystem-vendor-id property

2017-12-19 Thread Ben Warren via Qemu-devel
Hi Michael, > On Dec 19, 2017, at 8:27 PM, Michael S. Tsirkin <m...@redhat.com> wrote: > > On Wed, Dec 13, 2017 at 12:26:44AM -0800, b...@skyportsystems.com wrote: >> From: Ben Warren <b...@skyportsystems.com> >> >> Now that virtio-win guest drivers provid

Re: [Qemu-devel] [PATCH v4 12/43] misc: remove headers implicitly included

2017-12-15 Thread Ben Warren via Qemu-devel
y: Stefan Hajnoczi <stefa...@redhat.com> Reviewed-by: Ben Warren <b...@skyportsystems.com> > --- > hw/audio/fmopl.h | 1 - > bsd-user/main.c | 1 - > chardev/wctablet.c | 4 > hw/scsi/vhost-user-scsi.c| 1 - > linux-user/main.c

[Qemu-devel] [PATCH] virtio-pci: Add subsystem-vendor-id property

2017-12-13 Thread Ben Warren via Qemu-devel
From: Ben Warren <b...@skyportsystems.com> Now that virtio-win guest drivers provided by non-Redhat vendors need to use a different Subsystem Vendor ID value, a way is needed to set this parameter on the host. This works with all of the PCI-based devices, such as NetKVM, viostor, v

Re: [Qemu-devel] [PATCH v2 2/2] vmgenid: use UUID property type

2017-11-27 Thread Ben Warren via Qemu-devel
It looks like you dropped Marc-André and my Reviewed-by lines. Please put them back. > On Nov 27, 2017, at 5:05 AM, Roman Kagan wrote: > > Switch vmgenid device to use the UUID property type introduced in the > previous patch for its 'guid' property. > > One semantic

Re: [Qemu-devel] [PATCH 1/2] qdev-properties: add UUID property type

2017-11-24 Thread Ben Warren via Qemu-devel
> On Nov 24, 2017, at 7:36 AM, Roman Kagan <rka...@virtuozzo.com> wrote: > > UUIDs (GUIDs) are widely used in VMBus-related stuff, so a dedicated > property type becomes helpful. > > Signed-off-by: Roman Kagan <rka...@virtuozzo.com> Reviewed-by: Ben W

Re: [Qemu-devel] [PATCH 2/2] vmgenid: use UUID property type

2017-11-24 Thread Ben Warren via Qemu-devel
ts 'guid' property. > > One semantic change it introduces is that post-realize modification of > 'guid' via HMP or QMP will now be rejected with an error; however, > according to docs/specs/vmgenid.txt this is actually desirable. > > Signed-off-by: Roman Kagan <rka...@vi

Re: [Qemu-devel] [PATCH 81/88] hw/acpi: use g_new() family of functions

2017-10-09 Thread Ben Warren via Qemu-devel
> On Oct 6, 2017, at 4:50 PM, Philippe Mathieu-Daudé <f4...@amsat.org> wrote: > > Signed-off-by: Philippe Mathieu-Daudé <f4...@amsat.org> Reviewed-by: Ben Warren <b...@skyportsystems.com> > --- > hw/acpi/vmgenid.c | 2 +- > 1 file changed, 1 insertion(+), 1 d

Re: [Qemu-devel] [PATCH v2] vmgenid-test: use boot-sector infrastructure

2017-07-14 Thread Ben Warren via Qemu-devel
e but VM GEN ID isn't. > > To fix, switch to common boot sector infrastructure. > > Cc: Laszlo Ersek <ler...@redhat.com> > Cc: Peter Maydell <peter.mayd...@linaro.org> > Cc: Ben Warren <b...@skyportsystems.com> > Signed-off-by: Michael S. Tsirkin <m...@redhat.c

Re: [Qemu-devel] [PULL 19/21] tests: Add unit tests for the VM Generation ID feature

2017-07-13 Thread Ben Warren via Qemu-devel
Hi, > On Jul 13, 2017, at 4:51 AM, Marc-André Lureau <marcandre.lur...@gmail.com> > wrote: > > Hi > > On Thu, Jul 13, 2017 at 1:32 PM Laszlo Ersek <ler...@redhat.com > <mailto:ler...@redhat.com>> wrote: > On 07/13/17 12:47, Peter Maydell wrote: &

Re: [Qemu-devel] [PULL 19/21] tests: Add unit tests for the VM Generation ID feature

2017-07-11 Thread Ben Warren via Qemu-devel
Hi Laszlo, > On Jul 11, 2017, at 3:13 PM, Laszlo Ersek wrote: > > On 07/11/17 22:42, Peter Maydell wrote: >> On 11 July 2017 at 20:10, Michael S. Tsirkin wrote: >>> On Tue, Jul 11, 2017 at 05:49:07PM +0100, Peter Maydell wrote: The good news is it's not

Re: [Qemu-devel] [PULL 19/21] tests: Add unit tests for the VM Generation ID feature

2017-07-11 Thread Ben Warren via Qemu-devel
Hi Peter, > On Jul 11, 2017, at 6:32 AM, Peter Maydell <peter.mayd...@linaro.org> wrote: > > On 3 July 2017 at 20:45, Michael S. Tsirkin <m...@redhat.com> wrote: >> From: Ben Warren <b...@skyportsystems.com> >> >> The following tests are implemente

[Qemu-devel] [PATCH v2] tests: Add unit tests for the VM Generation ID feature

2017-07-01 Thread Ben Warren via Qemu-devel
From: Ben Warren <b...@skyportsystems.com> The following tests are implemented: * test that a GUID passed in by command line is propagated to the guest. Read the GUID from guest memory * test that the "auto" argument to the GUID generates a valid GUID, as seen by the guest. *

Re: [Qemu-devel] [PATCH 1/7] vmgenid: replace x-write-pointer-available hack

2017-07-01 Thread Ben Warren via Qemu-devel
x-2.6 -global > fw_cfg.dma_enabled=on > [boots normally] > > Suggested-by: Eduardo Habkost <ehabk...@redhat.com> > Signed-off-by: Marc-André Lureau <marcandre.lur...@redhat.com> Reviewed-by: Ben Warren <b...@skyportsystems.com <mailto:m...@redhat.com>> > --- >

Re: [Qemu-devel] [PATCH] tests: Add unit tests for the VM Generation ID feature

2017-06-01 Thread Ben Warren via Qemu-devel
> On Jun 1, 2017, at 7:52 AM, Michael S. Tsirkin <m...@redhat.com> wrote: > > On Thu, Jun 01, 2017 at 07:46:24AM -0700, Ben Warren wrote: >> >>> On Jun 1, 2017, at 7:21 AM, Michael S. Tsirkin <m...@redhat.com> wrote: >>> >>> On Thu, Jun

Re: [Qemu-devel] [PATCH] tests: Add unit tests for the VM Generation ID feature

2017-06-01 Thread Ben Warren via Qemu-devel
> On Jun 1, 2017, at 7:21 AM, Michael S. Tsirkin <m...@redhat.com> wrote: > > On Thu, Jun 01, 2017 at 08:10:27AM +, Marc-André Lureau wrote: >> Hi >> >> On Mon, May 29, 2017 at 7:18 PM Ben Warren via Qemu-devel < >> qemu-devel@nongnu

[Qemu-devel] [PATCH] tests: Add unit tests for the VM Generation ID feature

2017-05-29 Thread Ben Warren via Qemu-devel
From: Ben Warren <b...@skyportsystems.com> The following tests are implemented: * test that a GUID passed in by command line is propagated to the guest. Read the GUID from guest memory * test that the "auto" argument to the GUID generates a valid GUID, as seen by the guest. *

Re: [Qemu-devel] [PATCH v8 7/8] tests: Add unit tests for the VM Generation ID feature

2017-04-21 Thread Ben Warren via Qemu-devel
Hi, > On Apr 21, 2017, at 3:14 AM, Marc-André Lureau > wrote: > > Hi, > > Was this patch intentionally dropped from the series? > Good question. I thought the whole patch series was pulled in, but it looks like this one was not. I guess we’ll see what Michael

Re: [Qemu-devel] [PULL 02/15] docs: VM Generation ID device description

2017-04-12 Thread Ben Warren via Qemu-devel
> On Apr 12, 2017, at 1:47 PM, Marc-André Lureau <marcandre.lur...@gmail.com> > wrote: > > Hi > > On Thu, Apr 13, 2017 at 12:25 AM Ben Warren <b...@skyportsystems.com > <mailto:b...@skyportsystems.com>> wrote: >> On Apr 12, 2017, at 1:22 PM,

Re: [Qemu-devel] [PULL 02/15] docs: VM Generation ID device description

2017-04-12 Thread Ben Warren via Qemu-devel
> On Apr 12, 2017, at 1:22 PM, Marc-André Lureau <marcandre.lur...@gmail.com> > wrote: > > Hi > > On Thu, Apr 13, 2017 at 12:17 AM Ben Warren <b...@skyportsystems.com > <mailto:b...@skyportsystems.com>> wrote: >> On Apr 12, 2017, at 1:06 PM,

Re: [Qemu-devel] [PULL 02/15] docs: VM Generation ID device description

2017-04-12 Thread Ben Warren via Qemu-devel
> On Apr 12, 2017, at 1:06 PM, Marc-André Lureau <marcandre.lur...@gmail.com> > wrote: > > Hi > > On Thu, Mar 2, 2017 at 10:22 AM Michael S. Tsirkin <m...@redhat.com > <mailto:m...@redhat.com>> wrote: > From: Ben Warren <b...@skypo

Re: [Qemu-devel] [PATCH v2 1/2] hw/acpi/vmgenid: prevent device realization on pre-2.5 machine types

2017-03-21 Thread Ben Warren
> > DMA for fw_cfg is enabled in 2.5+ machine types only (see commit > e6915b5f3a87, "fw_cfg: unbreak migration compatibility for 2.4 and earlier > machines", 2016-02-18). > > Cc: "Michael S. Tsirkin" <m...@redhat.com> > Cc: Ben Warren <b...@skyport

Re: [Qemu-devel] [PATCH v2 2/2] hw/acpi/vmgenid: prevent more than one vmgenid device

2017-03-20 Thread Ben Warren
Thanks Laszlo! > On Mar 20, 2017, at 10:05 AM, Laszlo Ersek <ler...@redhat.com> wrote: > > A system with multiple VMGENID devices is undefined in the VMGENID spec by > omission. > > Cc: "Michael S. Tsirkin" <m...@redhat.com> > Cc: Ben Warren <b...@

Re: [Qemu-devel] [PULL 05/15] qmp/hmp: add query-vm-generation-id and 'info vm-generation-id' commands

2017-03-02 Thread Ben Warren
counter. >>>>> >>>>> QMP command example: >>>>>{ "execute": "query-vm-generation-id" } >>>>> >>>>> HMP command example: >>>>>info vm-generation-id >>>>> >>>>> Sign

Re: [Qemu-devel] [PATCH v8 0/8] Add support for VM Generation ID

2017-02-20 Thread Ben Warren
> On Feb 20, 2017, at 7:41 AM, Laszlo Ersek <ler...@redhat.com> wrote: > > On 02/20/17 15:57, Igor Mammedov wrote: >> On Thu, 16 Feb 2017 15:15:32 -0800 >> b...@skyportsystems.com wrote: >> >>> From: Ben Warren <b...@skyportsystems.com> >>

Re: [Qemu-devel] [PATCH v8 4/8] ACPI: Add Virtual Machine Generation ID support

2017-02-17 Thread Ben Warren
> On Feb 17, 2017, at 12:07 PM, Laszlo Ersek <ler...@redhat.com> wrote: > > On 02/17/17 17:03, Laszlo Ersek wrote: >> On 02/17/17 16:33, Ben Warren wrote: >>> >>>> On Feb 17, 2017, at 2:43 AM, Igor Mammedov <imamm...@redhat.com >>>> <m

Re: [Qemu-devel] [PATCH v8 4/8] ACPI: Add Virtual Machine Generation ID support

2017-02-17 Thread Ben Warren
> On Feb 17, 2017, at 2:43 AM, Igor Mammedov <imamm...@redhat.com> wrote: > > On Thu, 16 Feb 2017 15:15:36 -0800 > b...@skyportsystems.com wrote: > >> From: Ben Warren <b...@skyportsystems.com> >> >> This implements the VM Generation ID feature

Re: [Qemu-devel] [PATCH v7 4/8] ACPI: Add Virtual Machine Generation ID support

2017-02-16 Thread Ben Warren
> On Feb 16, 2017, at 11:03 AM, Laszlo Ersek <ler...@redhat.com> wrote: > > On 02/16/17 19:32, Ben Warren wrote: >> >>> On Feb 16, 2017, at 1:56 AM, Igor Mammedov <imamm...@redhat.com> wrote: >>> >>> On Wed, 15 Feb 2017 22:18:14 -0800

Re: [Qemu-devel] [PATCH v7 4/8] ACPI: Add Virtual Machine Generation ID support

2017-02-16 Thread Ben Warren
> On Feb 16, 2017, at 1:56 AM, Igor Mammedov <imamm...@redhat.com> wrote: > > On Wed, 15 Feb 2017 22:18:14 -0800 > b...@skyportsystems.com wrote: > >> From: Ben Warren <b...@skyportsystems.com> >> >> This implements the VM Generation ID feature

Re: [Qemu-devel] [PATCH v7 7/8] tests: Add unit tests for the VM Generation ID feature

2017-02-16 Thread Ben Warren
> On Feb 16, 2017, at 2:36 AM, Igor Mammedov <imamm...@redhat.com> wrote: > > On Wed, 15 Feb 2017 22:18:17 -0800 > b...@skyportsystems.com <mailto:b...@skyportsystems.com> wrote: > >> From: Ben Warren <b...@skyportsystems.com> >> >> The fol

Re: [Qemu-devel] [PATCH v7 1/8] linker-loader: Add new 'write pointer' command

2017-02-16 Thread Ben Warren
> On Feb 16, 2017, at 9:01 AM, Laszlo Ersek <ler...@redhat.com> wrote: > > On 02/16/17 07:18, b...@skyportsystems.com <mailto:b...@skyportsystems.com> > wrote: >> From: Ben Warren <b...@skyportsystems.com> >> >> This is similar to the e

Re: [Qemu-devel] [PATCH v7 0/8] Add support for VM Generation ID

2017-02-16 Thread Ben Warren
> On Feb 16, 2017, at 6:29 AM, Igor Mammedov <imamm...@redhat.com> wrote: > > On Wed, 15 Feb 2017 22:18:10 -0800 > b...@skyportsystems.com wrote: > >> From: Ben Warren <b...@skyportsystems.com> >> >> This patch set adds support for pas

Re: [Qemu-devel] [PATCH v6 5/7] qmp/hmp: add query-vm-generation-id and 'info vm-generation-id' commands

2017-02-15 Thread Ben Warren
ommands to query Virtual Machine Generation ID counter. >> >> QMP command example: >>{ "execute": "query-vm-generation-id" } >> >> HMP command example: >>info vm-generation-id >> >> Signed-off-by: Igor Mammedov

Re: [Qemu-devel] [PATCH v6 4/7] ACPI: Add Virtual Machine Generation ID support

2017-02-15 Thread Ben Warren
> On Feb 15, 2017, at 7:24 AM, Laszlo Ersek <ler...@redhat.com> wrote: > > On 02/15/17 13:19, Igor Mammedov wrote: >> On Tue, 14 Feb 2017 22:15:46 -0800 >> b...@skyportsystems.com wrote: >> >>> From: Ben Warren <b...@skyportsystems.com> >&

Re: [Qemu-devel] [PATCH v6 3/7] ACPI: Add vmgenid blob storage to the build tables

2017-02-15 Thread Ben Warren
> On Feb 15, 2017, at 6:30 AM, Laszlo Ersek <ler...@redhat.com> wrote: > > On 02/15/17 07:15, b...@skyportsystems.com wrote: >> From: Ben Warren <b...@skyportsystems.com> >> >> This allows them to be centrally initialized and destroyed >> >&g

Re: [Qemu-devel] [PATCH v6 6/7] tests: Move reusable ACPI macros into a new header file

2017-02-15 Thread Ben Warren
> On Feb 15, 2017, at 2:56 PM, Eric Blake <ebl...@redhat.com> wrote: > > On 02/15/2017 03:58 PM, Ben Warren wrote: > >>> >>> --- >>> tests/acpi-utils.h | 75 >>>

Re: [Qemu-devel] [PATCH v6 6/7] tests: Move reusable ACPI macros into a new header file

2017-02-15 Thread Ben Warren
> On Feb 15, 2017, at 1:35 PM, Eric Blake <ebl...@redhat.com> wrote: > > On 02/15/2017 12:15 AM, b...@skyportsystems.com > <mailto:b...@skyportsystems.com> wrote: >> From: Ben Warren <b...@skyportsystems.com> >> >> Also usable by upcoming VM Gene

Re: [Qemu-devel] [PATCH v6 1/7] linker-loader: Add new 'write pointer' command

2017-02-15 Thread Ben Warren
> On Feb 15, 2017, at 11:14 AM, Ben Warren <b...@skyportsystems.com> wrote: > >> >> On Feb 15, 2017, at 10:24 AM, Igor Mammedov <imamm...@redhat.com >> <mailto:imamm...@redhat.com>> wrote: >> >> On Wed, 15 Feb 2017 20:04:40 +0

Re: [Qemu-devel] [PATCH v6 1/7] linker-loader: Add new 'write pointer' command

2017-02-15 Thread Ben Warren
;> Laszlo Ersek <ler...@redhat.com> wrote: >>>>> >>>>>> Commenting under Igor's reply for simplicity >>>>>> >>>>>> On 02/15/17 11:57, Igor Mammedov wrote: >>>>>>> On Tue, 14 Feb 2017 22:15:43 -

Re: [Qemu-devel] [PATCH v6 4/7] ACPI: Add Virtual Machine Generation ID support

2017-02-15 Thread Ben Warren
> On Feb 15, 2017, at 8:40 AM, Michael S. Tsirkin wrote: > > On Wed, Feb 15, 2017 at 05:07:57PM +0100, Igor Mammedov wrote: >>> Those improvements can be added later, IMO -- but please do work out >>> with Igor whether he really wants a v7 for those. >> since it's minor fixes

Re: [Qemu-devel] [PATCH v5 08/10] PC: Support dynamic sysbus on pc_i440fx

2017-02-12 Thread Ben Warren
Hi > On Feb 12, 2017, at 11:55 AM, Marcel Apfelbaum <marcel.apfelb...@gmail.com> > wrote: > > On 02/06/2017 06:31 PM, Michael S. Tsirkin wrote: >> On Sun, Feb 05, 2017 at 01:12:03AM -0800, b...@skyportsystems.com wrote: >>> From: Ben Warren <b...@skyp

Re: [Qemu-devel] [PATCH v5 05/10] ACPI: Add Virtual Machine Generation ID support

2017-02-09 Thread Ben Warren
> On Feb 9, 2017, at 12:24 PM, Laszlo Ersek <ler...@redhat.com> wrote: > > On 02/09/17 21:02, Ben Warren wrote: >> >>> On Feb 9, 2017, at 11:27 AM, Laszlo Ersek <ler...@redhat.com >>> <mailto:ler...@redhat.com>> wrote: >>> >>&g

Re: [Qemu-devel] [PATCH v5 05/10] ACPI: Add Virtual Machine Generation ID support

2017-02-09 Thread Ben Warren
> On Feb 9, 2017, at 11:27 AM, Laszlo Ersek <ler...@redhat.com> wrote: > > On 02/09/17 18:23, Igor Mammedov wrote: >> On Wed, 8 Feb 2017 01:48:42 +0100 >> Laszlo Ersek <ler...@redhat.com> wrote: >> >>> On 02/05/17 10:12, b...@sk

Re: [Qemu-devel] [PATCH v5 05/10] ACPI: Add Virtual Machine Generation ID support

2017-02-08 Thread Ben Warren
> On Feb 7, 2017, at 4:48 PM, Laszlo Ersek <ler...@redhat.com> wrote: > > On 02/05/17 10:12, b...@skyportsystems.com <mailto:b...@skyportsystems.com> > wrote: >> From: Ben Warren <b...@skyportsystems.com> >> >> This implements the VM Ge

Re: [Qemu-devel] [PATCH v5 01/10] ACPI: Add a function for building named qword entries

2017-02-08 Thread Ben Warren
: >>>> On Sun, 5 Feb 2017 01:11:56 -0800 >>>> b...@skyportsystems.com wrote: >>>> >>>>> From: Ben Warren <b...@skyportsystems.com> >>>>> >>>>> This is initially used to patch a 64-bit address

Re: [Qemu-devel] [PATCH v5 05/10] ACPI: Add Virtual Machine Generation ID support

2017-02-08 Thread Ben Warren
Thanks for reviewing Igor. > On Feb 7, 2017, at 5:48 AM, Igor Mammedov <imamm...@redhat.com> wrote: > > On Sun, 5 Feb 2017 01:12:00 -0800 > b...@skyportsystems.com <mailto:b...@skyportsystems.com> wrote: > >> From: Ben Warren <b...@skyportsystems.com> &

Re: [Qemu-devel] [PATCH v5 05/10] ACPI: Add Virtual Machine Generation ID support

2017-02-06 Thread Ben Warren
> On Feb 6, 2017, at 11:04 AM, Michael S. Tsirkin <m...@redhat.com> wrote: > > On Mon, Feb 06, 2017 at 10:48:05AM -0800, Ben Warren wrote: >> >>> On Feb 6, 2017, at 10:17 AM, Michael S. Tsirkin <m...@redhat.com> wrote: >>> >>> On M

Re: [Qemu-devel] [PATCH v5 05/10] ACPI: Add Virtual Machine Generation ID support

2017-02-06 Thread Ben Warren
> On Feb 6, 2017, at 10:17 AM, Michael S. Tsirkin <m...@redhat.com> wrote: > > On Mon, Feb 06, 2017 at 09:59:55AM -0800, Ben Warren wrote: >> +void vmgenid_add_fw_cfg(FWCfgState *s, GArray *guid) >> +{ >> +Ob

Re: [Qemu-devel] [PATCH v5 05/10] ACPI: Add Virtual Machine Generation ID support

2017-02-06 Thread Ben Warren
> On Feb 6, 2017, at 9:41 AM, Michael S. Tsirkin <m...@redhat.com> wrote: > > On Mon, Feb 06, 2017 at 09:29:30AM -0800, Ben Warren wrote: >> >>On Feb 6, 2017, at 8:15 AM, Michael S. Tsirkin <m...@redhat.com> wrote: >> >>On Sun, Feb 05, 2017

Re: [Qemu-devel] [PATCH v5 05/10] ACPI: Add Virtual Machine Generation ID support

2017-02-06 Thread Ben Warren
> On Feb 6, 2017, at 8:15 AM, Michael S. Tsirkin <m...@redhat.com> wrote: > > On Sun, Feb 05, 2017 at 01:12:00AM -0800, b...@skyportsystems.com > <mailto:b...@skyportsystems.com> wrote: >> From: Ben Warren <b...@skyportsystems.com <mailto:b...@skyportsystems

Re: [Qemu-devel] [PATCH v5 02/10] linker-loader: Add new 'write pointer' command

2017-02-06 Thread Ben Warren
> On Feb 6, 2017, at 6:56 AM, Michael S. Tsirkin <m...@redhat.com> wrote: > > On Sun, Feb 05, 2017 at 01:11:57AM -0800, b...@skyportsystems.com wrote: >> From: Ben Warren <b...@skyportsystems.com> >> >> This adds to the existing 'add pointer' function

Re: [Qemu-devel] [PATCH v4 1/9] ACPI: Add a function for building named qword entries

2017-01-27 Thread Ben Warren
> On Jan 27, 2017, at 8:12 AM, Laszlo Ersek wrote: > > On 01/27/17 16:43, Kevin O'Connor wrote: >> On Fri, Jan 27, 2017 at 03:46:33PM +0100, Laszlo Ersek wrote: >>> On 01/27/17 15:18, Kevin O'Connor wrote: If an offset is going to be added, shouldn't both a source offset

Re: [Qemu-devel] [PATCH v4 1/9] ACPI: Add a function for building named qword entries

2017-01-25 Thread Ben Warren
> On Jan 25, 2017, at 4:48 PM, Laszlo Ersek <ler...@redhat.com> wrote: > > On 01/25/17 19:35, Michael S. Tsirkin wrote: >> On Wed, Jan 25, 2017 at 09:36:52AM -0800, Ben Warren wrote: >>> Hi Laszlo, >>> >>> >>>On Jan 24,

Re: [Qemu-devel] [PATCH v4 1/9] ACPI: Add a function for building named qword entries

2017-01-25 Thread Ben Warren
that the next version will be merged at once. > > With all that said: > > On 01/25/17 02:43, b...@skyportsystems.com <mailto:b...@skyportsystems.com> > wrote: >> From: Ben Warren <b...@skyportsystems.com <mailto:b...@skyportsystems.com>> >> >> T

Re: [Qemu-devel] Virtual Machine Generation ID

2017-01-19 Thread Ben Warren
Thanks Laszlo! > On Jan 19, 2017, at 1:25 AM, Laszlo Ersek <ler...@redhat.com> wrote: > > On 01/19/17 08:09, Ben Warren wrote: >> >>> On Jan 18, 2017, at 4:02 PM, Ben Warren <b...@skyportsystems.com> >>> wrote: >>> >>> Hi M

Re: [Qemu-devel] Virtual Machine Generation ID

2017-01-18 Thread Ben Warren
> On Jan 18, 2017, at 4:02 PM, Ben Warren <b...@skyportsystems.com> wrote: > > Hi Michael, >> On Jan 17, 2017, at 9:45 AM, Michael S. Tsirkin <m...@redhat.com> wrote: >> >> On Mon, Jan 16, 2017 at 10:57:42AM -0800, Ben Warren wrote: >>> I thi

Re: [Qemu-devel] Virtual Machine Generation ID

2017-01-18 Thread Ben Warren
Hi Michael, > On Jan 17, 2017, at 9:45 AM, Michael S. Tsirkin <m...@redhat.com> wrote: > > On Mon, Jan 16, 2017 at 10:57:42AM -0800, Ben Warren wrote: >> I think we have a misunderstanding here. I’m storing the VM >> Generation ID __data__ (a GUID) in a fw_cfg blob, n

Re: [Qemu-devel] [PATCH v2 5/6] qmp/hmp: add set-vm-generation-id commands

2017-01-18 Thread Ben Warren
b9bb6c91fb87" >> } >>} >> >> HMP command example: >>set-vm-generation-id guid=324e6eaf-d1d1-4bf6-bf41-b9bb6c91fb87 >> >> Signed-off-by: Ben Warren <b...@skyportsystems.com> >> Cc: Igor Mammedov <imamm...@redhat.com&g

Re: [Qemu-devel] [PATCH v2 3/6] ACPI: Add Virtual Machine Generation ID support

2017-01-17 Thread Ben Warren
Hi Igor, > On Jan 17, 2017, at 5:00 AM, Igor Mammedov <imamm...@redhat.com> wrote: > > On Mon, 16 Jan 2017 11:20:55 -0800 > b...@skyportsystems.com wrote: > >> From: Ben Warren <b...@skyportsystems.com> >> >> This implements the VM Generation ID feat

Re: [Qemu-devel] Virtual Machine Generation ID

2017-01-17 Thread Ben Warren
> On Jan 17, 2017, at 7:21 AM, Michael S. Tsirkin wrote: > > Let's not top-post anymore pls. > > On Tue, Jan 17, 2017 at 07:01:27AM -0800, Ed Swierk wrote: >> You mean what causes the guest to re-read the vmgenid guid? The >> vmgenid ACPI table defines a notify method, and

Re: [Qemu-devel] [PATCH v2 1/6] docs: vm generation id device's description

2017-01-16 Thread Ben Warren
> On Jan 16, 2017, at 11:51 AM, Eric Blake <ebl...@redhat.com> wrote: > > On 01/16/2017 01:20 PM, b...@skyportsystems.com > <mailto:b...@skyportsystems.com> wrote: >> From: Ben Warren <b...@skyportsystems.com <mailto:b...@skyportsystems.com>>

Re: [Qemu-devel] Virtual Machine Generation ID

2017-01-16 Thread Ben Warren
> On Jan 16, 2017, at 6:21 AM, Michael S. Tsirkin <m...@redhat.com> wrote: > > On Sat, Jan 14, 2017 at 10:17:53PM -0800, Ben Warren wrote: >> Hi Michael, >> >> >>On Dec 10, 2016, at 7:28 PM, Michael S. Tsirkin <m...@redhat.com> wrote: >>

Re: [Qemu-devel] Virtual Machine Generation ID

2017-01-14 Thread Ben Warren
Hi Michael, > On Dec 10, 2016, at 7:28 PM, Michael S. Tsirkin <m...@redhat.com> wrote: > > On Tue, Dec 06, 2016 at 06:15:34PM -0800, Ben Warren wrote: >> Hi Michael, >> >> I’m well on my way to implementing this, but I am really new to the QEMU >> code ba

[Qemu-devel] uncached memory access in qtest

2017-01-04 Thread Ben Warren
Hi, I’m trying to write a unit test to access a fw_cfg device via ACPI memory. When I access the memory from qtest using the readx() functions, I get the right values. If I change the contents on the host side, though, then access from the guest, the contents are unchanged. If I register a

Re: [Qemu-devel] [PATCH 5/5] qmp/hmp: add set-vm-generation-id commands

2016-12-20 Thread Ben Warren
guid": "324e6eaf-d1d1-4bf6-bf41-b9bb6c91fb87" >> } >>} >> >> HMP command example: >>set-vm-generation-id changed=true >> guid=324e6eaf-d1d1-4bf6-bf41-b9bb6c91fb87 >> >> Signed-off-by: Ben Warren <b...@skyportsystems.com&

Re: [Qemu-devel] Virtual Machine Generation ID

2016-12-06 Thread Ben Warren
Hi Michael, I’m well on my way to implementing this, but I am really new to the QEMU code base and am struggling with some concepts. Please see below: > On Oct 5, 2016, at 6:29 PM, Michael S. Tsirkin wrote: > > On Tue, Oct 04, 2016 at 03:51:40PM -0700, Ed Swierk wrote: >> On