Re: [Qemu-devel] [PATCH v3 0/3] Use SDL to create an OpenGL ES context for virglrenderer.

2018-04-20 Thread Elie Tournier
On Fri, Apr 20, 2018 at 12:44:44PM +0200, Gerd Hoffmann wrote: > On Fri, Apr 20, 2018 at 10:32:53AM +0100, Elie Tournier wrote: > > On Fri, Apr 13, 2018 at 02:58:39PM +0100, Elie Tournier wrote: > > > Hi, > > > > > Hello, > > > > Humble ping. > >

Re: [Qemu-devel] [PATCH v3 0/3] Use SDL to create an OpenGL ES context for virglrenderer.

2018-04-20 Thread Elie Tournier
On Fri, Apr 13, 2018 at 02:58:39PM +0100, Elie Tournier wrote: > Hi, > Hello, Humble ping. This series is unreviewed. BR, Elie > v2: Rebase on top of master > v3: Fix the json format (Eric Blake) > Move DisplayOptions from ui/sdl2.c to include/ui/sdl2.h (Gerd Hoff

[Qemu-devel] [PATCH v3 1/3] qapi: Parameter gl of DisplayType now accept an enum

2018-04-13 Thread Elie Tournier
v2: Rebase on top of master v3: Fix the json format (Eric Blake) Fix a comparison issue (Gerd Hoffmann) Signed-off-by: Elie Tournier <elie.tourn...@collabora.com> --- qapi/ui.json | 20 +++- vl.c | 10 +- 2 files changed, 24 insertions(+), 6 deletions(-)

[Qemu-devel] [PATCH v3 0/3] Use SDL to create an OpenGL ES context for virglrenderer.

2018-04-13 Thread Elie Tournier
in QEMU, we need to create an OpenGL ES context. This is possible thanks to the following option `-display sdl,gl=es`. Have a nice day, Elie [1] https://cgit.freedesktop.org/virglrenderer [2] https://gitlab.collabora.com/virgl-es/virglrenderer-gles/tree/hacks Elie Tournier (3): qapi: Parameter gl

[Qemu-devel] [PATCH v3 3/3] sdl: Allow OpenGL ES context creation

2018-04-13 Thread Elie Tournier
Signed-off-by: Elie Tournier <elie.tourn...@collabora.com> --- qemu-options.hx | 2 +- ui/sdl2-gl.c| 19 +-- vl.c| 4 3 files changed, 22 insertions(+), 3 deletions(-) diff --git a/qemu-options.hx b/qemu-options.hx index ca4e412f2f..333dd1f1c8

[Qemu-devel] [PATCH v3 2/3] sdl: Move DisplayOptions global to sdl2_console

2018-04-13 Thread Elie Tournier
Suggested-by: Gerd Hoffmann <kra...@redhat.com> Signed-off-by: Elie Tournier <elie.tourn...@collabora.com> --- include/ui/sdl2.h | 1 + ui/sdl2.c | 10 +- 2 files changed, 6 insertions(+), 5 deletions(-) diff --git a/include/ui/sdl2.h b/include/ui/sdl2.h inde

Re: [Qemu-devel] [PATCH v2 1/2 for-2.12?] qapi: Parameter gl of DisplayType now accept an enum

2018-04-13 Thread Elie Tournier
On Fri, Apr 13, 2018 at 08:15:29AM +0200, Gerd Hoffmann wrote: > On Thu, Apr 12, 2018 at 03:11:53PM +0100, Elie Tournier wrote: > > Hello, > > > > On Tue, Apr 10, 2018 at 03:33:35PM +0200, Gerd Hoffmann wrote: > > > > # @off: Disable OpenGL (default). > &

Re: [Qemu-devel] [PATCH v2 1/2 for-2.12?] qapi: Parameter gl of DisplayType now accept an enum

2018-04-12 Thread Elie Tournier
Hello, On Tue, Apr 10, 2018 at 03:33:35PM +0200, Gerd Hoffmann wrote: > > # @off: Disable OpenGL (default). Just to be sure, I have to add @ in front of all parameter, right? > > > > > + # 'on'Use OpenGL, pick context type automatically. > > > + # Would better be named 'auto' but

Re: [Qemu-devel] [PATCH v2 1/2 for-2.12?] qapi: Parameter gl of DisplayType now accept an enum

2018-04-10 Thread Elie Tournier
On Tue, Apr 10, 2018 at 08:13:00AM -0500, Eric Blake wrote: > On 04/10/2018 07:02 AM, Elie Tournier wrote: > > Signed-off-by: Elie Tournier <elie.tourn...@collabora.com> > > --- > > qapi/ui.json | 21 - > > vl.c | 10 +- > >

[Qemu-devel] [PATCH v2 2/2] sdl: Allow OpenGL ES context creation

2018-04-10 Thread Elie Tournier
Signed-off-by: Elie Tournier <elie.tourn...@collabora.com> --- include/ui/sdl2.h | 1 + qemu-options.hx | 2 +- ui/sdl2-gl.c | 17 +++-- ui/sdl2.c | 1 + vl.c | 4 5 files changed, 22 insertions(+), 3 deletions(-) diff --git a/include/ui/sd

[Qemu-devel] [PATCH v2 1/2] qapi: Parameter gl of DisplayType now accept an enum

2018-04-10 Thread Elie Tournier
Signed-off-by: Elie Tournier <elie.tourn...@collabora.com> --- qapi/ui.json | 21 - vl.c | 10 +- 2 files changed, 25 insertions(+), 6 deletions(-) diff --git a/qapi/ui.json b/qapi/ui.json index 5d01ad4304..c8005867e5 100644 --- a/qapi/ui.json +++

[Qemu-devel] [PATCH v2 0/2] Use SDL to create an OpenGL ES context for virglrenderer.

2018-04-10 Thread Elie Tournier
`-display sdl,gl=es`. Have a nice day, Elie [1] https://cgit.freedesktop.org/virglrenderer [2] https://gitlab.collabora.com/virgl-es/virglrenderer-gles/tree/hacks Elie Tournier (2): qapi: Parameter gl of DisplayType now accept an enum sdl: Allow OpenGL ES context creation include/ui/sdl2.h | 1

[Qemu-devel] [PATCH] sdl2: Remove unused epoxy include

2018-04-04 Thread Elie Tournier
Signed-off-by: Elie Tournier <elie.tourn...@collabora.com> --- Can someone push this patch for me please. I don't have commit access. ui/sdl2-gl.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/ui/sdl2-gl.c b/ui/sdl2-gl.c index 5e1073a084..c3683e6b65 100644 --- a/ui/sdl2-gl.c +++ b/u

Re: [Qemu-devel] [RFC 0/2] Use SDL to create an OpenGL ES context for virglrenderer.

2018-01-30 Thread Elie Tournier
On Tue, Jan 30, 2018 at 04:22:33PM +0100, Gerd Hoffmann wrote: > Hi, > > > > Well, display configuration is going to be rewritten, and while that is > > > in flight adding new config options isn't a good idea b/c things will > > > conflict ... > > I'm wondering how extensive this rewrite is

Re: [Qemu-devel] [RFC 0/2] Use SDL to create an OpenGL ES context for virglrenderer.

2018-01-30 Thread Elie Tournier
On Mon, Jan 29, 2018 at 07:08:30PM +0100, Gerd Hoffmann wrote: Hello, First, thanks for your reply. I added some comments and questions below. Cheers, Elie > Hi, > > > > In order to use this feature, we need to create a gles context. > > > This series add an option (`-display sdl,gles=on`)

Re: [Qemu-devel] [RFC 0/2] Use SDL to create an OpenGL ES context for virglrenderer.

2018-01-29 Thread Elie Tournier
On Wed, Jan 17, 2018 at 02:50:27PM +, Elie Tournier wrote: > Hello everyone, > > At Collabora, we are working on adding an OpenGL ES backend on virglrenderer > [1]. > I submit these patches as an RFC because our work didn't land in > virglrenderer yet. > Currently, we

[Qemu-devel] [RFC 1/2] sdl2: Add gles options

2018-01-17 Thread Elie Tournier
This commit add an option to the sdl display: `-display sdl,gles=on` This will allow the user to create an OpenGL ES context. Signed-off-by: Elie Tournier <elie.tourn...@collabora.com> --- qemu-options.hx | 5 - ui/sdl2.c | 1 + vl.c| 11 ++- 3 files chang

[Qemu-devel] [RFC 2/2] sdl2: gles option will create a gles context

2018-01-17 Thread Elie Tournier
Create an OpenGL ES context if the option `-display sdl,gles=on` is set. Signed-off-by: Elie Tournier <elie.tourn...@collabora.com> --- include/sysemu/sysemu.h | 1 + include/ui/sdl2.h | 1 + ui/sdl2-gl.c| 8 ++-- ui/sdl2.c | 7 +++

[Qemu-devel] [RFC 0/2] Use SDL to create an OpenGL ES context for virglrenderer.

2018-01-17 Thread Elie Tournier
/tree/gles-option Elie Tournier (2): sdl2: Add gles options sdl2: gles option will create a gles context include/sysemu/sysemu.h | 1 + include/ui/sdl2.h | 1 + qemu-options.hx | 5 - ui/sdl2-gl.c| 8 ++-- ui/sdl2.c | 8 vl.c