Re: [Qemu-devel] [PATCH] MAINTAINERS: update RBD block maintainer

2019-06-28 Thread Josh Durgin
insertion(+), 1 deletion(-) diff --git a/MAINTAINERS b/MAINTAINERS index cad58b9487..47694cd02f 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -2367,7 +2367,7 @@ S: Supported F: block/vmdk.c RBD -M: Josh Durgin +M: Jason Dillaman L: qemu-bl...@nongnu.org S: Supported F: block/rbd.c

Re: [Qemu-devel] [PATCH] rbd : disable rbd_cache_writethrough_until_flush for cache=unsafe

2016-09-21 Thread Josh Durgin
default Signed-off-by: Alexandre Derumier Sorry for the delay - this is correct and needed since this option appeared by default in Ceph hammer. Reviewed-by: Josh Durgin --- block/rbd.c | 4 1 file changed, 4 insertions(+) diff --git a/block/rbd.c b/block/rbd.c index 0106fea..f3af6c8

Re: [Qemu-devel] [PATCH v2] rbd:change error_setg() to error_setg_errno()

2016-05-17 Thread Josh Durgin
, 23 insertions(+), 15 deletions(-) Looks good, thanks! Reviewed-by: Josh Durgin diff --git a/block/rbd.c b/block/rbd.c index 5bc5b32..5226b6f 100644 --- a/block/rbd.c +++ b/block/rbd.c @@ -290,7 +290,8 @@ static int qemu_rbd_set_conf(rados_t cluster, const char *conf, if

Re: [Qemu-devel] [PATCH] block/rbd: add .bdrv_reopen_prepare() stub

2016-05-17 Thread Josh Durgin
On 05/17/2016 03:03 AM, Sebastian Färber wrote: Hi Kevin, A correct reopen implementation must consider all options and flags that .bdrv_open() looked at. The options are okay, as both "filename" and "password-secret" aren't things that we want to allow a reopen to change. However, in the flag

[Qemu-devel] [Bug 1581334] Re: qemu + librbd takes high %sy cpu under high random io workload

2016-05-13 Thread Josh Durgin
Since this works fine with krbd, it sounds like the bug may be in librbd. Could you install debug symbols (the librbd1-dbg package) and when this occurs, attach to the qemu process with gdb and get a backtrace of all threads (there will be a lot of them) via 'gdb -p $pid' and in gdb 'thread apply a

Re: [Qemu-devel] [PATCH v2 1/3] rbd: add support for getting password from QCryptoSecret object

2015-12-21 Thread Josh Durgin
ey.b64 $QEMU -object secret,id=secret0,file=poolkey.b64,format=base64 \ -drive driver=rbd,filename=rbd:pool/image:id=myname:\ auth_supported=cephx,passwordid=secret0 Signed-off-by: Daniel P. Berrange Looks good to me, thanks! Reviewed-by: Josh Durgin

Re: [Qemu-devel] [PATCH 03/17] rbd: add support for getting password from QCryptoSecret object

2015-10-19 Thread Josh Durgin
On 10/19/2015 08:09 AM, Daniel P. Berrange wrote: Currently RBD passwords must be provided on the command line via $QEMU -drive file=rbd:pool/image:id=myname:\ key=QVFDVm41aE82SHpGQWhBQXEwTkN2OGp0SmNJY0UrSE9CbE1RMUE=:\ auth_supported=cephx This is insecure because the key is visibl

Re: [Qemu-devel] where can i customize rbd object size?

2015-09-08 Thread Josh Durgin
EFAULT_OBJ_ORDER <https://lxr.missinglinkelectronics.com/qemu+v2.1.0/+code=OBJ_DEFAULT_OBJ_ORDER>, if someone knows , please tell me. Thanks a lot. I have CCed the rbd.c maintainer for you: $ scripts/get_maintainer.pl -f block/rbd.c Josh Durgin (supporter:RBD) Thanks for CCing me, I missed it before. You can s

Re: [Qemu-devel] is there a limit on the number of in-flight I/O operations?

2015-08-27 Thread Josh Durgin
On 08/27/2015 09:49 AM, Stefan Hajnoczi wrote: On Mon, Aug 25, 2014 at 03:50:02PM -0600, Chris Friesen wrote: The only limit I see in the whole call chain from virtio_blk_handle_request() on down is the call to bdrv_io_limits_intercept() in bdrv_co_do_writev(). However, that doesn't provide any

Re: [Qemu-devel] is there a limit on the number of in-flight I/O operations?

2015-08-26 Thread Josh Durgin
On 08/26/2015 04:47 PM, Andrey Korolyov wrote: On Thu, Aug 27, 2015 at 2:31 AM, Josh Durgin wrote: On 08/26/2015 10:10 AM, Andrey Korolyov wrote: On Thu, May 14, 2015 at 4:42 PM, Andrey Korolyov wrote: On Wed, Aug 27, 2014 at 9:43 AM, Chris Friesen wrote: On 08/25/2014 03:50 PM, Chris

Re: [Qemu-devel] is there a limit on the number of in-flight I/O operations?

2015-08-26 Thread Josh Durgin
On 08/26/2015 10:10 AM, Andrey Korolyov wrote: On Thu, May 14, 2015 at 4:42 PM, Andrey Korolyov wrote: On Wed, Aug 27, 2014 at 9:43 AM, Chris Friesen wrote: On 08/25/2014 03:50 PM, Chris Friesen wrote: I think I might have a glimmering of what's going on. Someone please correct me if I get

Re: [Qemu-devel] [Qemu-block] [PATCH 0/4] rbd cleanup and settings precedence fixes

2015-07-14 Thread Josh Durgin
On 07/14/2015 07:20 AM, Kevin Wolf wrote: Am 09.07.2015 um 11:59 hat Stefan Hajnoczi geschrieben: On Tue, Jun 30, 2015 at 11:28:18AM -0700, Josh Durgin wrote: Ping On 06/10/2015 08:28 PM, Josh Durgin wrote: Patches 1 and 2 are simple cleanups. 3 and 4 fix the precedence of cache options and

Re: [Qemu-devel] [PATCH 0/4] rbd cleanup and settings precedence fixes

2015-06-30 Thread Josh Durgin
Ping On 06/10/2015 08:28 PM, Josh Durgin wrote: Patches 1 and 2 are simple cleanups. 3 and 4 fix the precedence of cache options and ceph settings. The cache option precedence in particular is important due to the potential for misconfigurations (ceph.conf setting rbd_cache=true, qemu setting

[Qemu-devel] [PATCH 2/4] MAINTAINERS: update email address

2015-06-11 Thread Josh Durgin
The old one still works for now, but will not work indefinitely. Signed-off-by: Josh Durgin --- MAINTAINERS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/MAINTAINERS b/MAINTAINERS index 4ed8215..34eeb88 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -1135,7 +1135,7 @@ S

[Qemu-devel] [PATCH 1/4] rbd: remove unused constants and fields

2015-06-11 Thread Josh Durgin
RBDAIOCB.status was only used for cancel, which was removed in 7691e24dbebb46658e89b3f950fda6ec78bbb823. RBDAIOCB.sector_num was never used. RADOSCB.done and rcbid were never used. RBD_FD* are obsolete since the pipe was removed in e04fb07fd1676e9facd7f3f878c1bbe03bccd26b. Signed-off-by: Josh

[Qemu-devel] [PATCH 4/4] rbd: fix ceph settings precedence

2015-06-11 Thread Josh Durgin
Apply the ceph settings from a config file before any ceph settings from the command line. Since the ceph config file location may be specified on the command line, parse it once to read the config file, and do a second pass to apply the rest of the command line ceph options. Signed-off-by: Josh

[Qemu-devel] [PATCH 3/4] rbd: make qemu's cache setting override any ceph setting

2015-06-11 Thread Josh Durgin
, although this would just be a performance problem. Fix this by changing rbd's cache setting to match qemu after all other ceph settings have been applied. Signed-off-by: Josh Durgin --- block/rbd.c | 24 1 file changed, 12 insertions(+), 12 deletions(-) diff --git a/

[Qemu-devel] [PATCH 0/4] rbd cleanup and settings precedence fixes

2015-06-11 Thread Josh Durgin
Patches 1 and 2 are simple cleanups. 3 and 4 fix the precedence of cache options and ceph settings. The cache option precedence in particular is important due to the potential for misconfigurations (ceph.conf setting rbd_cache=true, qemu setting cache=none) to accidentally put data at risk. Josh

Re: [Qemu-devel] [PATCH] rbd: print a clear error message when write beyond EOF

2014-12-10 Thread Josh Durgin
On 12/10/2014 07:47 AM, Jun Li wrote: Currently, as rbd driver do not support dynamic growth when write beyond EOF, so just print a clear error message. Signed-off-by: Jun Li --- block/rbd.c | 14 ++ 1 file changed, 14 insertions(+) diff --git a/block/rbd.c b/block/rbd.c index 5

Re: [Qemu-devel] qcow2: Can create qcow2 image format on rbd server

2014-12-09 Thread Josh Durgin
On 12/09/2014 01:49 AM, Stefan Hajnoczi wrote: On Tue, Dec 9, 2014 at 3:52 AM, Josh Durgin wrote: On 12/08/2014 05:58 AM, Jun Li wrote: On Fri, 12/05 18:01, Max Reitz wrote: On 2014-12-05 at 16:32, Jun Li wrote: Currently, qemu-img can not create qcow2 image format on rbd server

Re: [Qemu-devel] qcow2: Can create qcow2 image format on rbd server

2014-12-08 Thread Josh Durgin
On 12/08/2014 05:58 AM, Jun Li wrote: On Fri, 12/05 18:01, Max Reitz wrote: On 2014-12-05 at 16:32, Jun Li wrote: Currently, qemu-img can not create qcow2 image format on rbd server. Analysis the code as followings: when create qcow2 format image: qcow2_create2 bdrv_create_file(filename, opt

Re: [Qemu-devel] [PATCH] rbd: Add support for bdrv_invalidate_cache

2014-10-09 Thread Josh Durgin
) +{ +BDRVRBDState *s = bs->opaque; +int r = rbd_invalidate_cache(s->image); +if (r < 0) { +error_setg_errno(errp, -r, "Failed to invalidate the cache"); +} +return r; No return needed here. With that fixed: Reviewed-by: Josh Durgin +} +#endif +

Re: [Qemu-devel] [PATCH v2] rbd: Fix leaks in rbd_start_aio() error path

2014-06-05 Thread Josh Durgin
o_release(acb); return NULL; } Reviewed-by: Josh Durgin FWIW this error path can only happen in certain combinations of odd circumstances, including specific forms of disk corruption of certain objects in concert with other factors, so it's quite unlikely to occur in practice.

Re: [Qemu-devel] [PATCH v3 18/25] rbd: use BlockDriverState's AioContext

2014-05-08 Thread Josh Durgin
imers, or BHs stay registered when requests have been drained. Cc: Josh Durgin Signed-off-by: Stefan Hajnoczi --- block/rbd.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/block/rbd.c b/block/rbd.c index dbc79f4..41f7bdc 100644 --- a/block/rbd.c +++ b/block/

Re: [Qemu-devel] [ceph-users] qemu + rbd block driver with cache=writeback, is live migration safe ?

2014-04-18 Thread Josh Durgin
On 04/18/2014 10:47 AM, Alexandre DERUMIER wrote: Thanks Kevin for for the full explain! cache.writeback=on,cache.direct=off,cache.no-flush=off I didn't known about the cache options split,thanks. rbd does, to my knowledge, not use the kernel page cache, so we're safe >from that part. It

Re: [Qemu-devel] ?????? ?????? ?????? ?????? ?????? ?????? qemu vm big network latency when met heavy io

2014-01-16 Thread Josh Durgin
On 01/15/2014 10:12 PM, ?? wrote: Hi Josh # strings /usr/bin/qemu-system-x86_64 | grep rbd_aio rbd_aio_write rbd_aio_flush rbd_aio_read rbd_aio_create_completion rbd_aio_release rbd_aio_discard rbd_aio_get_return_value So, librbd's asynchronous flush is being used. I set log settings, fetc

Re: [Qemu-devel] ?????? ?????? ?????? ?????? ?????? qemu vm big network latency when met heavy io

2014-01-15 Thread Josh Durgin
On 01/15/2014 01:40 AM, ?? wrote: Hi Josh there is some issues 1. use 'none' cache mode in xml, and unset 'rbd cache=true' in ceph.conf, the network latency issue not show. 2. use 'writethrough' cache mode in xml, and unset 'rbd cache=true' in ceph.conf, the network latency issue not show.

Re: [Qemu-devel] ?????? ?????? ?????? ?????? qemu vm big network latency when met heavy io

2014-01-13 Thread Josh Durgin
x.x.x.x:6789;x.x.x.x:6789 Regards Alan ye -- ?? Alan Ye -- ???? ------ *??:* "Josh Durgin";; *:* 2014??1??14??(??) 2:24 *??:* "Stefan Hajnoczi"; "??" ; *:* "qemu-devel"; *???

Re: [Qemu-devel] 回复: 回复: 回复: qemu vm big network latency when met heavy io

2014-01-13 Thread Josh Durgin
On 01/12/2014 06:39 PM, Stefan Hajnoczi wrote: > On Fri, Jan 10, 2014 at 11:50 AM, 叶绍琛 wrote: > > Please use Reply-all to keep the CC list in tact. That way the > conversation stays on the mailing list and others can participate. > >>> Is the sum of guests' RAM less than the total physical RAM

Re: [Qemu-devel] [PATCH v2] discard rbd error output when not relevant in qemu-iotests

2014-01-08 Thread Josh Durgin
able releases are 0.67 and 0.72). Reviewed-by: Josh Durgin

Re: [Qemu-devel] [PATCH] rbd: switch from pipe to QEMUBH completion notification

2013-12-27 Thread Josh Durgin
noczi --- Josh: This patch has not been tested. I have just compiled it. Sorry for the delay. This is a great simplification, and it passed my tests. Thanks! Reviewed- and Tested-by: Josh Durgin

Re: [Qemu-devel] [PATCH] MAINTAINERS: add block driver sub-maintainers

2013-10-21 Thread Josh Durgin
00644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -857,3 +857,41 @@ Stable 0.10 L: qemu-sta...@nongnu.org T: git git://git.qemu-project.org/qemu-stable-0.10.git S: Orphan + +Block drivers +- +VMDK +M: Fam Zheng +S: Supported +F: block/vmdk.c + +RBD +M: Josh Durgin +S: Supported +F:

Re: [Qemu-devel] [ceph-users] qemu-1.4.0 and onwards, linux kernel 3.2.x, ceph-RBD, heavy I/O leads to kernel_hung_tasks_timout_secs message and unresponsive qemu-process, [Bug 1207686]

2013-08-10 Thread Josh Durgin
On 08/09/2013 08:03 AM, Stefan Hajnoczi wrote: On Fri, Aug 09, 2013 at 03:05:22PM +0100, Andrei Mikhailovsky wrote: I can confirm that I am having similar issues with ubuntu vm guests using fio with bs=4k direct=1 numjobs=4 iodepth=16. Occasionally i see hang tasks, occasionally guest vm stops

Re: [Qemu-devel] [ceph-users] qemu-1.4.0 and onwards, linux kernel 3.2.x, ceph-RBD, heavy I/O leads to kernel_hung_tasks_timout_secs message and unresponsive qemu-process, [Bug 1207686]

2013-08-08 Thread Josh Durgin
On 08/08/2013 05:40 AM, Oliver Francke wrote: Hi Josh, I have a session logged with: debug_ms=1:debug_rbd=20:debug_objectcacher=30 as you requested from Mike, even if I think, we do have another story here, anyway. Host-kernel is: 3.10.0-rc7, qemu-client 1.6.0-rc2, client-kernel is 3.2.0

Re: [Qemu-devel] block: Review of .has_zero_init use

2013-06-25 Thread Josh Durgin
On 06/25/2013 04:39 AM, Kevin Wolf wrote: Can you please review for the gluster, rbd, sheepdog and ssh driver whether it's safe to assume that the image reads back as zeros after bdrv_create? This is always safe for rbd.

Re: [Qemu-devel] [Qemu-stable] Patch Round-up for stable 1.4.2, freeze on Monday

2013-05-17 Thread Josh Durgin
Could you add the patch: commit dc7588c1eb3008bda53dde1d6b890cd299758155 Author: Josh Durgin Date: Fri Mar 29 13:03:23 2013 -0700 rbd: add an asynchronous flush The existing bdrv_co_flush_to_disk implementation uses rbd_flush(), which is sychronous and causes the main qemu thread to block u

Re: [Qemu-devel] [PATCH v2] rbd: add an asynchronous flush

2013-04-11 Thread Josh Durgin
On 04/11/2013 01:48 AM, Kevin Wolf wrote: Am 11.04.2013 um 10:02 hat Stefan Hajnoczi geschrieben: On Wed, Apr 10, 2013 at 07:03:39AM -0700, Josh Durgin wrote: On 04/02/2013 07:10 AM, Kevin Wolf wrote: Am 29.03.2013 um 21:03 hat Josh Durgin geschrieben: The existing bdrv_co_flush_to_disk

Re: [Qemu-devel] runtime Block driver modules (was Re: [PATCH v3 2/2] rbd: link and load librbd dynamically)

2013-04-10 Thread Josh Durgin
On 04/10/2013 01:09 AM, Stefan Hajnoczi wrote: On Wed, Apr 10, 2013 at 2:05 AM, Josh Durgin wrote: This allows the rbd block driver to detect symbols in the installed version of librbd, and enable or disable features appropriately. This obviates the #ifdefs regarding librbd versions. Loading

Re: [Qemu-devel] [PATCH v2] rbd: add an asynchronous flush

2013-04-10 Thread Josh Durgin
On 04/02/2013 07:10 AM, Kevin Wolf wrote: Am 29.03.2013 um 21:03 hat Josh Durgin geschrieben: The existing bdrv_co_flush_to_disk implementation uses rbd_flush(), which is sychronous and causes the main qemu thread to block until it is complete. This results in unresponsiveness and extra latency

[Qemu-devel] [PATCH v3 2/2] rbd: link and load librbd dynamically

2013-04-09 Thread Josh Durgin
ad librbd, and explicitly make it resident. Signed-off-by: Josh Durgin --- block/Makefile.objs |3 +- block/rbd.c | 292 --- block/rbd_types.h | 95 + configure | 41 +--- 4 files changed, 309 ins

Re: [Qemu-devel] [PATCH 2/2] rbd: disable unsupported librbd functions at runtime

2013-04-04 Thread Josh Durgin
On 04/04/2013 03:10 AM, Kevin Wolf wrote: Am 04.04.2013 um 10:35 hat Josh Durgin geschrieben: QEMU may be compiled against a newer version of librbd, but run and dynamically linked with an older version that does not support these functions. Declare them as weak symbols so they can be checked

[Qemu-devel] [PATCH 2/2] rbd: disable unsupported librbd functions at runtime

2013-04-04 Thread Josh Durgin
initial version of librbd, so only they need to be checked. Signed-off-by: Josh Durgin --- block/rbd.c | 19 +++ 1 file changed, 19 insertions(+) diff --git a/block/rbd.c b/block/rbd.c index 037d82b..69a339a 100644 --- a/block/rbd.c +++ b/block/rbd.c @@ -44,6 +44,15

[Qemu-devel] [PATCH v3 1/2] rbd: add an asynchronous flush

2013-04-04 Thread Josh Durgin
asynchronous version is available. Reported-by: Oliver Francke Signed-off-by: Josh Durgin --- Since v2: * remove #ifdefs around bdrv_aio_flush and qemu_rbd_aio_flush, since they are dealt with at runtime in the next patch block/rbd.c | 30 ++ 1 file changed, 26

[Qemu-devel] [PATCH v2] rbd: add an asynchronous flush

2013-03-29 Thread Josh Durgin
asynchronous version is available. Reported-by: Oliver Francke Signed-off-by: Josh Durgin --- v2: * include hunk treating write, discard, and flush completions the same, since they have no result data block/rbd.c | 37 + 1 file changed, 33 insertions(+), 4

[Qemu-devel] [PATCH] rbd: add an asynchronous flush

2013-03-29 Thread Josh Durgin
asynchronous version is available. Reported-by: Oliver Francke Signed-off-by: Josh Durgin --- block/rbd.c | 34 -- 1 file changed, 32 insertions(+), 2 deletions(-) diff --git a/block/rbd.c b/block/rbd.c index 1a8ea6d..568b279 100644 --- a/block/rbd.c +++ b/block/rbd.c

Re: [Qemu-devel] [PATCH] rbd block driver fix race between aio completition and aio cancel

2012-11-27 Thread Josh Durgin
On 11/22/2012 02:00 AM, Stefan Priebe wrote: This one fixes a race which qemu had also in iscsi block driver between cancellation and io completition. qemu_rbd_aio_cancel was not synchronously waiting for the end of the command. To archieve this it introduces a new status flag which uses -EINPR

Re: [Qemu-devel] [PATCH] rbd block driver fix race between aio completition and aio cancel

2012-11-21 Thread Josh Durgin
On 11/19/2012 12:39 PM, Stefan Priebe wrote: From: Stefan Priebe This one fixes a race qemu also had in iscsi block driver between cancellation and io completition. qemu_rbd_aio_cancel was not synchronously waiting for the end of the command. It also removes the useless cancelled flag and int

Re: [Qemu-devel] [PATCH] rbd: hook up cache options

2012-05-22 Thread Josh Durgin
On 05/22/2012 02:18 AM, Paolo Bonzini wrote: Il 17/05/2012 22:42, Josh Durgin ha scritto: + * Fallback to more conservative semantics if setting cache + * options fails. Ignore errors from setting rbd_cache because the + * only possible error is that the option does not exist, and

[Qemu-devel] [PATCH] rbd: hook up cache options

2012-05-17 Thread Josh Durgin
Writeback caching was added in Ceph 0.46, and writethrough will be in 0.47. These are controlled by general config options, so there's no need to check for librbd version. Signed-off-by: Josh Durgin --- block/rbd.c | 19 +++ 1 files changed, 19 insertions(+), 0 dele

[Qemu-devel] [PATCH] rbd: add discard support

2012-04-30 Thread Josh Durgin
ff-by: Josh Durgin --- block/rbd.c | 89 -- 1 files changed, 73 insertions(+), 16 deletions(-) diff --git a/block/rbd.c b/block/rbd.c index 6cd8448..1280d66 100644 --- a/block/rbd.c +++ b/block/rbd.c @@ -44,6 +44,13 @@ * le

Re: [Qemu-devel] [PATCH] vhost-net: Move asserts to after check for end < start

2012-03-30 Thread Josh Durgin
On 12/16/2011 12:33 PM, Bruce Rogers wrote: When migrating a vm using vhost-net we hit the following assertion: qemu-kvm: /usr/src/packages/BUILD/qemu-kvm-0.15.1/hw/vhost.c:30: vhost_dev_sync_region: Assertion `start / (0x1000 * (8 * sizeof(vhost_log_chunk_t)))< dev->log_size' failed. I consi

[Qemu-devel] [PATCH] rbd: always set out parameter in qemu_rbd_snap_list

2011-12-06 Thread Josh Durgin
The caller expects psn_tab to be NULL when there are no snapshots or an error occurs. This results in calling g_free on an invalid address. Reported-by: Oliver Francke Signed-off-by: Josh Durgin --- block/rbd.c |3 ++- 1 files changed, 2 insertions(+), 1 deletions(-) diff --git a/block

[Qemu-devel] [RFC 1/2] block: let bdrv_set_key be used for authentication

2011-11-09 Thread Josh Durgin
Add a BlockDriverState member 'needs_auth' to distinguish between drives that require authentication and those that are encrypted. Update the block_passwd monitor command and error strings to be about generic passwords instead of encryption. Signed-off-by: Josh Durgin --

[Qemu-devel] [RFC 2/2] rbd: implement bdrv_set_key

2011-11-09 Thread Josh Durgin
We can't connect to the cluster before the key is set, so this step is moved to qemu_rbd_open_finish. Each bdrv function will fail before the key is set. Signed-off-by: Josh Durgin --- block/rbd.c | 160 +- 1 files changed, 113 inser

[Qemu-devel] [RFC 0/2] rbd authentication

2011-11-09 Thread Josh Durgin
point, the size can be refreshed as if the device were resized. This works fine with the virtio driver, but other drivers, like ide, don't implement the resize callback. What do you think is the best way to solve this? Josh Durgin (2): block: let bdrv_set_key be used for authentication

Re: [Qemu-devel] passing secrets to block devices

2011-10-20 Thread Josh Durgin
On 10/20/2011 12:24 PM, Daniel P. Berrange wrote: On Thu, Oct 20, 2011 at 11:30:42AM -0700, Josh Durgin wrote: We're working on libvirt support for block device authentication [1]. To authenticate, rbd needs a username and a secret. Normally, to avoid putting the secret on the command line

[Qemu-devel] passing secrets to block devices

2011-10-20 Thread Josh Durgin
We're working on libvirt support for block device authentication [1]. To authenticate, rbd needs a username and a secret. Normally, to avoid putting the secret on the command line, you can store the secret in a file and pass the file to qemu, but when this is automated, there's no good way to know

Re: [Qemu-devel] [PATCH v2] block/rbd: Remove unused local variable

2011-06-13 Thread Josh Durgin
ons->name) { Looks good to me: Reviewed-by: Josh Durgin

[Qemu-devel] [PATCH v6 3/4] rbd: check return values when scheduling aio

2011-05-26 Thread Josh Durgin
If scheduling fails, the number of outstanding I/Os must be correct, or there will be a hang when waiting for everything to be flushed. Reviewed-by: Christian Brunner Reported-by: Stefan Hajnoczi Signed-off-by: Josh Durgin --- block/rbd.c | 24 1 files changed, 20

[Qemu-devel] [PATCH v6 1/4] rbd: use the higher level librbd instead of just librados

2011-05-26 Thread Josh Durgin
librbd stacks on top of librados to provide access to rbd images. Using librbd simplifies the qemu code, and allows qemu to use new versions of the rbd format with few (if any) changes. Reviewed-by: Christian Brunner Signed-off-by: Josh Durgin Signed-off-by: Yehuda Sadeh --- block/rbd.c

[Qemu-devel] [PATCH v6 2/4] rbd: allow configuration of rados from the rbd filename

2011-05-26 Thread Josh Durgin
luster to be used by specifying different monitor addresses, as well as having different logging levels or locations for different volumes. Reviewed-by: Christian Brunner Signed-off-by: Josh Durgin --- block/rbd.c | 119 ++ 1 files changed, 1

[Qemu-devel] [PATCH v6 4/4] rbd: Add bdrv_truncate implementation

2011-05-26 Thread Josh Durgin
Reviewed-by: Christian Brunner Signed-off-by: Josh Durgin --- block/rbd.c | 14 ++ 1 files changed, 14 insertions(+), 0 deletions(-) diff --git a/block/rbd.c b/block/rbd.c index f4da6ab..bdc448a 100644 --- a/block/rbd.c +++ b/block/rbd.c @@ -688,6 +688,19 @@ static int64_t

[Qemu-devel] [PATCH v6 0/4] rbd improvements

2011-05-26 Thread Josh Durgin
ristian Brunner Changes since v3: * trivially rebased * updated copyright header Changes since v2: * return values are checked in rbd_aio_rw_vector * bdrv_truncate added Josh Durgin (4): rbd: use the higher level librbd instead of just librados rbd: allow configuration of rados from the rbd

Re: [Qemu-devel] [PATCH v5 4/4] rbd: Add bdrv_truncate implementation

2011-05-26 Thread Josh Durgin
On 05/26/2011 01:05 AM, Kevin Wolf wrote: Am 25.05.2011 22:34, schrieb Josh Durgin: Signed-off-by: Josh Durgin --- block/rbd.c | 15 +++ 1 files changed, 15 insertions(+), 0 deletions(-) diff --git a/block/rbd.c b/block/rbd.c index a44d160..b95b1eb 100644 --- a/block/rbd.c

Re: [Qemu-devel] [PATCH v5 2/4] rbd: allow configuration of rados from the rbd filename

2011-05-26 Thread Josh Durgin
On 05/26/2011 01:13 AM, Kevin Wolf wrote: Am 25.05.2011 22:34, schrieb Josh Durgin: The new format is rbd:pool/image[@snapshot][:option1=value1[:option2=value2...]] Each option is used to configure rados, and may be any Ceph option, or "conf". The "conf" option specifies

Re: [Qemu-devel] [PATCH v4 1/4] rbd: use the higher level librbd instead of just librados

2011-05-25 Thread Josh Durgin
On 05/25/2011 12:18 PM, Christian Brunner wrote: Apart from two cosmetic issues (see below), I think this patch is ready to replace the old rbd driver. You can add: Reviewed-by: Christian Brunner Regards Christian Thanks, I fixed these in v5. Josh 2011/5/24 Josh Durgin: librbd stacks on

[Qemu-devel] [PATCH v5 1/4] rbd: use the higher level librbd instead of just librados

2011-05-25 Thread Josh Durgin
librbd stacks on top of librados to provide access to rbd images. Using librbd simplifies the qemu code, and allows qemu to use new versions of the rbd format with few (if any) changes. Signed-off-by: Josh Durgin Signed-off-by: Yehuda Sadeh --- block/rbd.c | 795

[Qemu-devel] [PATCH v5 4/4] rbd: Add bdrv_truncate implementation

2011-05-25 Thread Josh Durgin
Signed-off-by: Josh Durgin --- block/rbd.c | 15 +++ 1 files changed, 15 insertions(+), 0 deletions(-) diff --git a/block/rbd.c b/block/rbd.c index a44d160..b95b1eb 100644 --- a/block/rbd.c +++ b/block/rbd.c @@ -688,6 +688,20 @@ static int64_t qemu_rbd_getlength(BlockDriverState

[Qemu-devel] [PATCH v5 2/4] rbd: allow configuration of rados from the rbd filename

2011-05-25 Thread Josh Durgin
luster to be used by specifying different monitor addresses, as well as having different logging levels or locations for different volumes. Signed-off-by: Josh Durgin --- block/rbd.c | 119 ++ 1 files changed, 102 insertions(+), 17 deletions(-)

[Qemu-devel] [PATCH v5 3/4] rbd: check return values when scheduling aio

2011-05-25 Thread Josh Durgin
If scheduling fails, the number of outstanding I/Os must be correct, or there will be a hang when waiting for everything to be flushed. Reported-by: Stefan Hajnoczi Signed-off-by: Josh Durgin --- block/rbd.c | 24 1 files changed, 20 insertions(+), 4 deletions

[Qemu-devel] [PATCH v5 0/4] rbd improvements

2011-05-25 Thread Josh Durgin
rbd_aio_rw_vector * bdrv_truncate added Josh Durgin (4): rbd: use the higher level librbd instead of just librados rbd: allow configuration of rados from the rbd filename rbd: check return values when scheduling aio rbd: Add bdrv_truncate implementation block/rbd.c | 897

[Qemu-devel] [PATCH v4 1/4] rbd: use the higher level librbd instead of just librados

2011-05-24 Thread Josh Durgin
librbd stacks on top of librados to provide access to rbd images. Using librbd simplifies the qemu code, and allows qemu to use new versions of the rbd format with few (if any) changes. Signed-off-by: Josh Durgin Signed-off-by: Yehuda Sadeh --- block/rbd.c | 790

[Qemu-devel] [PATCH v4 3/4] rbd: check return values when scheduling aio

2011-05-24 Thread Josh Durgin
If scheduling fails, the number of outstanding I/Os must be correct, or there will be a hang when waiting for everything to be flushed. Reported-by: Stefan Hajnoczi Signed-off-by: Josh Durgin --- block/rbd.c | 24 1 files changed, 20 insertions(+), 4 deletions

[Qemu-devel] [PATCH v4 4/4] rbd: Add bdrv_truncate implementation

2011-05-24 Thread Josh Durgin
Signed-off-by: Josh Durgin --- block/rbd.c | 15 +++ 1 files changed, 15 insertions(+), 0 deletions(-) diff --git a/block/rbd.c b/block/rbd.c index c9f32e4..015ae8e 100644 --- a/block/rbd.c +++ b/block/rbd.c @@ -687,6 +687,20 @@ static int64_t qemu_rbd_getlength(BlockDriverState

[Qemu-devel] [PATCH v4 2/4] rbd: allow configuration of rados from the rbd filename

2011-05-24 Thread Josh Durgin
luster to be used by specifying different monitor addresses, as well as having different logging levels or locations for different volumes. Signed-off-by: Josh Durgin --- block/rbd.c | 119 ++ 1 files changed, 102 insertions(+), 17 deletions(-)

[Qemu-devel] [PATCH v4 0/4] rbd improvements

2011-05-24 Thread Josh Durgin
This patchset moves the complexity of the rbd format into librbd and adds truncation support. Changes since v3: * trivially rebased * updated copyright header Changes since v2: * return values are checked in rbd_aio_rw_vector * bdrv_truncate added Josh Durgin (4): rbd: use the higher

Re: [Qemu-devel] Qemu + RBD = ceph::buffer::end_of_buffer

2011-05-06 Thread Josh Durgin
CCing the ceph list. On 05/06/2011 12:23 PM, Dyweni - Qemu-Devel wrote: Hi List! I upgraded Ceph to the latest development version Commit: 0edbc75a5fe8c3028faf85546f3264d28653ea3f Pulled from: git://ceph.newdream.net/ceph.git I recompiled the latest GIT version of QEMU-KVM (wit

Re: [Qemu-devel] [qemu-iotests][PATCH] Update rbd support

2011-04-12 Thread Josh Durgin
On Wed, 13 Apr 2011 04:43:39 +0200, Christoph Hellwig wrote: >> @@ -43,6 +43,10 @@ _supported_fmt raw >> _supported_proto generic >> _supported_os Linux >> >> +# rbd images are not growable >> +if [ "$IMGPROTO" = "rbd" ]; then >> +_notrun "image protocol $IMGPROTO does not support growable i

[Qemu-devel] [PATCH v3 1/4] rbd: use the higher level librbd instead of just librados

2011-04-12 Thread Josh Durgin
librbd stacks on top of librados to provide access to rbd images. Using librbd simplifies the qemu code, and allows qemu to use new versions of the rbd format with few (if any) changes. Signed-off-by: Josh Durgin Signed-off-by: Yehuda Sadeh --- block/rbd.c | 787

[Qemu-devel] [PATCH v3 2/4] rbd: allow configuration of rados from the rbd filename

2011-04-12 Thread Josh Durgin
luster to be used by specifying different monitor addresses, as well as having different logging levels or locations for different volumes. Signed-off-by: Josh Durgin --- block/rbd.c | 119 ++ 1 files changed, 102 insertions(+), 17 deletions(-)

[Qemu-devel] [PATCH v3 3/4] rbd: check return values when scheduling aio

2011-04-12 Thread Josh Durgin
If scheduling fails, the number of outstanding I/Os must be correct, or there will be a hang when waiting for everything to be flushed. Reported-by: Stefan Hajnoczi Signed-off-by: Josh Durgin --- block/rbd.c | 24 1 files changed, 20 insertions(+), 4 deletions

[Qemu-devel] [PATCH v3 4/4] rbd: Add bdrv_truncate implementation

2011-04-12 Thread Josh Durgin
Signed-off-by: Josh Durgin --- block/rbd.c | 15 +++ 1 files changed, 15 insertions(+), 0 deletions(-) diff --git a/block/rbd.c b/block/rbd.c index ac20282..4514dbd 100644 --- a/block/rbd.c +++ b/block/rbd.c @@ -686,6 +686,20 @@ static int64_t qemu_rbd_getlength(BlockDriverState

[Qemu-devel] [qemu-iotests][PATCH] Update rbd support

2011-04-12 Thread Josh Durgin
rbd is not growable, so test 016 is skipped. rbd implements bdrv_truncate, so test 025 will work. Signed-off-by: Josh Durgin --- 016 |4 025 |2 +- 2 files changed, 5 insertions(+), 1 deletions(-) diff --git a/016 b/016 index 16f151f..8fa921f 100755 --- a/016 +++ b/016 @@ -43,6

[Qemu-devel] [PATCH v3 0/4] rbd improvements

2011-04-12 Thread Josh Durgin
This patchset moves the complexity of the rbd format into librbd and adds truncation support. This passes qemu-iotests when 016 is skipped. A patch for this is in a separate email. Changes since v2: * return values are checked in rbd_aio_rw_vector * bdrv_truncate added Josh Durgin (4): rbd

Re: [Qemu-devel] [PATCH v2 1/2] rbd: use the higher level librbd instead of just librados

2011-04-12 Thread Josh Durgin
On 04/12/2011 01:54 AM, Stefan Hajnoczi wrote: Is qemu-iotests passing for you now? Yes, they all pass when 016 is skipped. Josh

Re: [Qemu-devel] [PATCH v2 1/2] rbd: use the higher level librbd instead of just librados

2011-04-11 Thread Josh Durgin
On 04/08/2011 01:43 AM, Stefan Hajnoczi wrote: On Mon, Mar 28, 2011 at 04:15:57PM -0700, Josh Durgin wrote: librbd stacks on top of librados to provide access to rbd images. Using librbd simplifies the qemu code, and allows qemu to use new versions of the rbd format with few (if any) changes

[Qemu-devel] Re: [PATCH v2 1/2] rbd: use the higher level librbd instead of just librados

2011-04-08 Thread Josh Durgin
On 04/08/2011 01:43 AM, Stefan Hajnoczi wrote: On Mon, Mar 28, 2011 at 04:15:57PM -0700, Josh Durgin wrote: librbd stacks on top of librados to provide access to rbd images. Using librbd simplifies the qemu code, and allows qemu to use new versions of the rbd format with few (if any) changes

Re: [Qemu-devel] Re: [PATCH 1/2] rbd: use the higher level librbd instead of just librados

2011-03-28 Thread Josh Durgin
On 03/28/2011 02:08 PM, Stefan Hajnoczi wrote: > You have sent a malformed patch. Please send patches that follow the > guidelines at http://wiki.qemu.org/Contribute/SubmitAPatch and test that > your mail client is not line wrapping or mangling whitespace. Sorry about that. I've fixed the style i

[Qemu-devel] [PATCH v2 1/2] rbd: use the higher level librbd instead of just librados

2011-03-28 Thread Josh Durgin
librbd stacks on top of librados to provide access to rbd images. Using librbd simplifies the qemu code, and allows qemu to use new versions of the rbd format with few (if any) changes. Signed-off-by: Josh Durgin Signed-off-by: Yehuda Sadeh --- block/rbd.c | 785

[Qemu-devel] [PATCH v2 2/2] rbd: allow configuration of rados from the rbd filename

2011-03-28 Thread Josh Durgin
luster to be used by specifying different monitor addresses, as well as having different logging levels or locations for different volumes. Signed-off-by: Josh Durgin --- block/rbd.c | 119 ++ 1 files changed, 102 insertions(+), 17 deletions(-)

[Qemu-devel] [PATCH 1/2] rbd: use the higher level librbd instead of just librados

2011-03-24 Thread Josh Durgin
librbd stacks on top of librados to provide access to rbd images. Using librbd simplifies the qemu code, and allows qemu to use new versions of the rbd format with few (if any) changes. Signed-off-by: Josh Durgin Signed-off-by: Yehuda Sadeh --- block/rbd.c | 784

[Qemu-devel] [PATCH 2/2] rbd: allow configuration of rados from the rbd filename

2011-03-24 Thread Josh Durgin
luster to be used by specifying different monitor addresses, as well as having different logging levels or locations for different volumes. Signed-off-by: Josh Durgin --- block/rbd.c | 96 -- 1 files changed, 86 insertions(+), 10 deletions(-)