Re: [Qemu-devel] [PATCH 5/7] sockets: Rename SocketAddressFlat to SocketAddress

2017-04-26 Thread Prasanna Kalever
On Wed, Apr 26, 2017 at 1:06 PM, Markus Armbruster wrote: > Signed-off-by: Markus Armbruster > --- > block/gluster.c| 48 > block/nbd.c| 26 +- > block/sheepdog.c

Re: [Qemu-devel] [PATCH 14/31] gluster: Switch to .bdrv_co_block_status()

2017-04-19 Thread Prasanna Kalever
oops! That's 'bytes'. On Wed, Apr 19, 2017 at 7:36 PM, Prasanna Kalever <pkale...@redhat.com> wrote: > On Tue, Apr 18, 2017 at 7:03 AM, Eric Blake <ebl...@redhat.com> wrote: >> We are gradually moving away from sector-based interfaces, towards >> byte-based.

Re: [Qemu-devel] [PATCH 14/31] gluster: Switch to .bdrv_co_block_status()

2017-04-19 Thread Prasanna Kalever
On Tue, Apr 18, 2017 at 7:03 AM, Eric Blake wrote: > We are gradually moving away from sector-based interfaces, towards > byte-based. Update the gluster driver accordingly. > > Signed-off-by: Eric Blake > --- > block/gluster.c | 47

Re: [Qemu-devel] [PATCH v1 1/1] qemu-doc: update gluster protocol usage guide

2016-11-02 Thread Prasanna Kalever
On Wed, Nov 2, 2016 at 9:02 PM, Eric Blake <ebl...@redhat.com> wrote: > On 11/02/2016 07:03 AM, Prasanna Kalever wrote: > >>> "debug":"N" does not match the schema; the parameter is named >>> "debug-level", and it is an integer not a

Re: [Qemu-devel] [PATCH v2 1/1] qemu-doc: update gluster protocol usage guide

2016-11-02 Thread Prasanna Kalever
On Wed, Nov 2, 2016 at 5:46 PM, Prasanna Kumar Kalever wrote: > Document: > 1. The new debug and logfile options with their usages > 2. New json format and its usage and > 3. update "GlusterFS, Device URL Syntax" section in "Invocation" > > Signed-off-by: Prasanna

Re: [Qemu-devel] [PATCH v1 1/1] qemu-doc: update gluster protocol usage guide

2016-11-02 Thread Prasanna Kalever
On Tue, Nov 1, 2016 at 11:32 PM, Eric Blake wrote: > On 11/01/2016 07:29 AM, Prasanna Kumar Kalever wrote: >> Document: >> 1. The new debug and logfile options with their usages and >> 2. New json format and its usage. >> >> Signed-off-by: Prasanna Kumar Kalever

Re: [Qemu-devel] [PATCH v1 1/1] block/gluster: memory usage: use one glfs instance per volume

2016-10-27 Thread Prasanna Kalever
On Thu, Oct 27, 2016 at 6:38 PM, Jeff Cody wrote: > On Thu, Oct 27, 2016 at 04:16:03PM +0530, Prasanna Kumar Kalever wrote: >> Currently, for every drive accessed via gfapi we create a new glfs >> instance (call glfs_new() followed by glfs_init()) which could consume >> memory

Re: [Qemu-devel] [PATCH v3] block/gluster: add support to choose libgfapi logfile

2016-07-22 Thread Prasanna Kalever
On Fri, Jul 22, 2016 at 7:37 PM, Eric Blake wrote: > On 07/22/2016 06:01 AM, Prasanna Kumar Kalever wrote: >> currently all the libgfapi logs defaults to '/dev/stderr' as it was hardcoded >> in a call to glfs logging api, in case if debug level is chosen to >> DEBUG/TRACE > >

Re: [Qemu-devel] [PATCH for-2.7 v2] block/gluster: fix doc in the qapi schema and member name

2016-07-22 Thread Prasanna Kalever
On Fri, Jul 22, 2016 at 8:16 PM, Eric Blake wrote: > On 07/22/2016 08:34 AM, Prasanna Kumar Kalever wrote: >> 1. qapi @BlockdevOptionsGluster schema member name s/debug_level/debug-level/ >> 2. rearrange the versioning >> 3. s/server description/servers description/ >> >>

Re: [Qemu-devel] [PATCH] block/gluster: fix doc in the qapi schema

2016-07-22 Thread Prasanna Kalever
On Fri, Jul 22, 2016 at 7:39 PM, Eric Blake wrote: > > On 07/22/2016 04:05 AM, Prasanna Kumar Kalever wrote: > > 1. s/@debug-level/@debug_level/ > > Wrong. I asked for the opposite, s/debug_level/debug-level/ oops! > > > 2. rearrange the versioning > > 3. s/server

Re: [Qemu-devel] [PATCH v20 5/5] block/gluster: add support for multiple gluster servers

2016-07-19 Thread Prasanna Kalever
On Wed, Jul 20, 2016 at 12:03 AM, Markus Armbruster wrote: > > One more... > > Prasanna Kumar Kalever writes: > > > This patch adds a way to specify multiple volfile servers to the gluster > > block backend of QEMU with tcp|rdma transport types and

Re: [Qemu-devel] [PATCH v19 5/5] block/gluster: add support for multiple gluster servers

2016-07-18 Thread Prasanna Kalever
On Mon, Jul 18, 2016 at 8:09 PM, Markus Armbruster <arm...@redhat.com> wrote: > Prasanna Kalever <pkale...@redhat.com> writes: > >> On Mon, Jul 18, 2016 at 3:47 PM, Markus Armbruster <arm...@redhat.com> wrote: >>> Prasanna Kumar Kalever <prasanna.kale.

Re: [Qemu-devel] [PATCH v19 4/5] block/gluster: using new qapi schema

2016-07-18 Thread Prasanna Kalever
On Mon, Jul 18, 2016 at 6:41 PM, Markus Armbruster <arm...@redhat.com> wrote: > Prasanna Kalever <pkale...@redhat.com> writes: > >> On Mon, Jul 18, 2016 at 2:59 PM, Markus Armbruster <arm...@redhat.com> wrote: >>> Prasanna Kumar Kalever <prasanna.kale.

Re: [Qemu-devel] [PATCH v19 3/5] block/gluster: remove rdma transport

2016-07-18 Thread Prasanna Kalever
On Mon, Jul 18, 2016 at 7:05 PM, Raghavendra Talur <rta...@redhat.com> wrote: > > > On Mon, Jul 18, 2016 at 5:48 PM, Markus Armbruster <arm...@redhat.com> > wrote: >> >> Prasanna Kalever <pkale...@redhat.com> writes: >> >> > On Mon, Jul

Re: [Qemu-devel] [PATCH v19 5/5] block/gluster: add support for multiple gluster servers

2016-07-18 Thread Prasanna Kalever
On Mon, Jul 18, 2016 at 3:47 PM, Markus Armbruster wrote: > Prasanna Kumar Kalever writes: > >> This patch adds a way to specify multiple volfile servers to the gluster >> block backend of QEMU with tcp|rdma transport types and their port numbers.

Re: [Qemu-devel] [PATCH v19 4/5] block/gluster: using new qapi schema

2016-07-18 Thread Prasanna Kalever
On Mon, Jul 18, 2016 at 2:59 PM, Markus Armbruster wrote: > Prasanna Kumar Kalever writes: > >> this patch adds 'GlusterServer' related schema in qapi/block-core.json >> >> Signed-off-by: Prasanna Kumar Kalever >> ---

Re: [Qemu-devel] [PATCH v19 3/5] block/gluster: remove rdma transport

2016-07-18 Thread Prasanna Kalever
On Mon, Jul 18, 2016 at 2:23 PM, Markus Armbruster wrote: > Prasanna Kumar Kalever writes: > >> gluster volfile server fetch happens through unix and/or tcp, it doesn't >> support volfile fetch over rdma, hence removing the dead code >> >>

Re: [Qemu-devel] [PATCH v18 4/4] block/gluster: add support for multiple gluster servers

2016-07-15 Thread Prasanna Kalever
On Thu, Jul 14, 2016 at 5:35 PM, Markus Armbruster wrote: > Interface and error message review only. > > Prasanna Kumar Kalever writes: > >> This patch adds a way to specify multiple volfile servers to the gluster >> block backend of QEMU with

Re: [Qemu-devel] [PATCH v18 3/4] block/gluster: using new qapi schema

2016-07-14 Thread Prasanna Kalever
On Thu, Jul 14, 2016 at 1:22 PM, Markus Armbruster wrote: > Prasanna Kumar Kalever writes: > >> this patch adds 'GlusterServer' related schema in qapi/block-core.json >> >> Signed-off-by: Prasanna Kumar Kalever > >

Re: [Qemu-devel] Regarding the status of Gluster's multi volfile server patches

2016-06-15 Thread Prasanna Kalever
On Wed, Jun 15, 2016 at 12:34 PM, Prasanna Kalever <pkale...@redhat.com> wrote: > On Wed, Jun 15, 2016 at 3:30 AM, Eric Blake <ebl...@redhat.com> wrote: >> On 06/14/2016 06:36 AM, Jeff Cody wrote: >>> On Tue, Jun 14, 2016 at 03:27:55PM +0530, Prasanna Kalever wr

Re: [Qemu-devel] Regarding the status of Gluster's multi volfile server patches

2016-06-15 Thread Prasanna Kalever
On Wed, Jun 15, 2016 at 3:30 AM, Eric Blake <ebl...@redhat.com> wrote: > On 06/14/2016 06:36 AM, Jeff Cody wrote: >> On Tue, Jun 14, 2016 at 03:27:55PM +0530, Prasanna Kalever wrote: >>> Hello, >>> >>> Can someone please help me in tracking the QAPI ch

[Qemu-devel] Regarding the status of Gluster's multi volfile server patches

2016-06-14 Thread Prasanna Kalever
Hello, Can someone please help me in tracking the QAPI changes for union discriminator addition, the below [1] gluster related patches are awaiting from very long, because of the dependency with QMP design changes. These patches [1] also stuck changes in libvirt/vdsm. It will be really helpful

Re: [Qemu-devel] [PATCH 4/4] block/gluster: add support for multiple gluster servers

2016-03-23 Thread Prasanna Kalever
On Wed, Mar 23, 2016 at 5:46 PM, Prasanna Kalever <pkale...@redhat.com> wrote: > On Fri, Feb 5, 2016 at 6:47 PM, Prasanna Kumar Kalever > <pkale...@redhat.com> wrote: >> >> On Thursday, February 4, 2016 6:52:15 PM Kevin Wolf Wrote: >> > Am 12.11.2

Re: [Qemu-devel] [PATCH 4/4] block/gluster: add support for multiple gluster servers

2016-03-23 Thread Prasanna Kalever
On Fri, Feb 5, 2016 at 6:47 PM, Prasanna Kumar Kalever wrote: > > On Thursday, February 4, 2016 6:52:15 PM Kevin Wolf Wrote: > > Am 12.11.2015 um 23:36 hat Eric Blake geschrieben: > > > On 11/12/2015 03:22 AM, Prasanna Kumar Kalever wrote: > > > > +static struct glfs

Re: [Qemu-devel] [PATCH v5 1/1] block/gluster: add support for multiple gluster backup volfile servers

2015-10-07 Thread Prasanna Kalever
Hi Peter & Kevin, Thanks for your detailed review comments. I shall try to incorporate these changes as a next patch-set. - Prasanna Kumar Kalever > On Mon, Sep 28, 2015 at 18:06:12 +0530, Prasanna Kumar Kalever wrote: > > This patch adds a way to specify multiple volfile servers to the

Re: [Qemu-devel] [PATCH v3 1/1] block/gluster: add support for multiple gluster backup volfile servers

2015-09-25 Thread Prasanna Kalever
> On Tue, Sep 22, 2015 at 04:06:54 -0400, Prasanna Kalever wrote: > > > > > On 09/21/2015 05:24 AM, Prasanna Kumar Kalever wrote: > > > > This patch adds a way to specify multiple backup volfile servers to the > > > > gluster > > > &g

Re: [Qemu-devel] [PATCH v3 1/1] block/gluster: add support for multiple gluster backup volfile servers

2015-09-22 Thread Prasanna Kalever
> On 09/21/2015 05:24 AM, Prasanna Kumar Kalever wrote: > > This patch adds a way to specify multiple backup volfile servers to the > > gluster > > block backend of QEMU with tcp|rdma transport types and their port numbers. > > > > > > > This patch gives a mechanism to provide all the server