Re: [PATCH v4 03/12] {linux,bsd}-user: Update ts_tid after fork()

by: Alex Bennée > Signed-off-by: Ilya Leoshkevich > Reviewed-by: Warner Losh Warner > --- > bsd-user/main.c | 1 + > linux-user/main.c | 1 + > 2 files changed, 2 insertions(+) > > diff --git a/bsd-user/main.c b/bsd-user/main.c > index e5efb7b8458..72289673a94 10064

Re: [PATCH v4 02/12] {linux,bsd}-user: Introduce get_task_state()

igned-off-by: Ilya Leoshkevich > Reviewed-by: Warner Losh The bsd-user stuff is definitely good. The linux-user seems good, but I didn't look at it as closely. Warner > bsd-user/bsd-file.h | 2 +- > bsd-user/qemu.h | 5 + > bsd-

Re: [PATCH v3 29/29] user: Prefer fast cpu_env() over slower CPU QOM cast macro

ser/signal.c | 3 +-- > linux-user/signal.c | 6 ++ > 2 files changed, 3 insertions(+), 6 deletions(-) > Reviewed-by: Warner Losh > diff --git a/bsd-user/signal.c b/bsd-user/signal.c > index ca31470772..c6f0b1be38 100644 > --- a/bsd-user/signal.c > +++ b/bsd-user/sign

Re: [PATCH v2 08/14] meson: Link with libinotify on FreeBSD

essage-Id: <20240206002344.12372-5-...@linux.ibm.com> > Signed-off-by: Alex Bennée > --- > meson.build | 23 +++ > util/meson.build | 6 +++++- > 2 files changed, 24 insertions(+), 5 deletions(-) > Reviewed-by: Warner Losh > diff --git a/

Re: [PATCH v2 06/14] tests/vm/freebsd: Reload the sshd configuration

t. > > Reviewed-by: Thomas Huth > Signed-off-by: Ilya Leoshkevich > Message-Id: <20240206002344.12372-3-...@linux.ibm.com> > Signed-off-by: Alex Bennée > --- > tests/vm/freebsd | 1 + > 1 file changed, 1 insertion(+) > Reviewed-by: Warner Losh > diff

Re: [PATCH v2 07/14] test-util-filemonitor: Adapt to the FreeBSD inotify rename semantics

real users, so > teach the test to accept it. > Reviewed-by: Warner Losh Suggested-by: Daniel P. Berrange > Signed-off-by: Ilya Leoshkevich > Message-Id: <20240206002344.12372-4-...@linux.ibm.com> > Signed-off-by: Alex Bennée > --- > tests/unit/test-util-filemonito

Re: [PATCH 3/3] meson: Disable CONFIG_NOTIFY1 on FreeBSD

On Wed, Jan 31, 2024 at 9:42 AM Daniel P. Berrangé wrote: > On Wed, Jan 31, 2024 at 05:24:10PM +0100, Philippe Mathieu-Daudé wrote: > > Hi, > > > > Warner, do you remember what this is about? > > > > ( >

Re: [PATCH] {linux,bsd}-user: Fail mmap() if size doesn't fit into host's size_t

long > start, abi_ulong size, > > size = HOST_PAGE_ALIGN(size); > > +if (size != (size_t)size) { > +return (abi_ulong)(-1); > +} > + > if (reserved_va) { > return mmap_find_vma_reserved(start, size, > (alignment != 0

Re: Qemu resets terminal to crazy defaults

On Tue, Dec 19, 2023, 1:55 PM Peter Maydell wrote: > On Tue, 19 Dec 2023 at 19:40, Fabiano Rosas wrote: > > > > Dave Blanchard writes: > > > > > Hello all, can you please help me to understand what Qemu is doing > here? > > > > > > When connecting to the guest for example using a

Re: Qemu resets terminal to crazy defaults

On Tue, Dec 19, 2023, 12:20 PM Dave Blanchard wrote: > Hello all, can you please help me to understand what Qemu is doing here? > > When connecting to the guest for example using a serial/tcp/telnet link, > some kind of code is being immediately transmitted over the link which > screws up my

Re: [PATCH 24/24] target: Restrict 'sysemu/reset.h' to system emulation

s(+), 1 deletion(-) > Reviewed-by: Warner Losh

Re: [PATCH 14/24] gdbstub: Include missing 'hw/core/cpu.h' header

return cpu->cluster_index + 1; > } > > Signed-off-by: Philippe Mathieu-Daudé > --- > gdbstub/gdbstub.c | 1 + > 1 file changed, 1 insertion(+) > Reviewed-by: Warner Losh

Re: [PATCH 02/24] exec: Expose 'target_page.h' API to user emulation

+- > page-target.c| 43 +++ > system/physmem.c | 35 --- > 3 files changed, 44 insertions(+), 36 deletions(-) > create mode 100644 page-target.c > Reviewed-by: Warner Losh

Re: [PATCH 01/24] exec: Include 'cpu.h' before validating CPUArchState placement

On Mon, Dec 11, 2023 at 2:53 PM Warner Losh wrote: > > > On Mon, Dec 11, 2023 at 2:20 PM Philippe Mathieu-Daudé > wrote: > >> CPUArchState 'env' field is defined within the ArchCPU structure, >> so we need to include each target "cpu.h" header which defi

Re: [PATCH 01/24] exec: Include 'cpu.h' before validating CPUArchState placement

cpu-all.h | 9 + > 1 file changed, 5 insertions(+), 4 deletions(-) > Signed-off-by: Warner Losh

Re: QEMU Summit Minutes 2023

On Wed, Nov 29, 2023 at 8:44 AM Daniel P. Berrangé wrote: > On Tue, Nov 28, 2023 at 06:54:42PM +0100, Cédric Le Goater wrote: > > On 11/21/23 18:11, Alex Bennée wrote: > > > Peter Maydell writes: > > > > > > > QEMU Summit Minutes 2023 > > > > > > > > > > > > As usual,

Re: QEMU Summit Minutes 2023

On Wed, Nov 29, 2023 at 8:33 AM Philippe Mathieu-Daudé wrote: > On 28/11/23 19:06, Daniel P. Berrangé wrote: > > On Tue, Nov 28, 2023 at 06:54:42PM +0100, Cédric Le Goater wrote: > > > Anyway, when a maintainer wants to merge a tree, I would expect to > > have a MR opened against 'master' in

Re: [PATCH trivial 01/21] bsd-user: spelling fixes: necesary, agrument, undocummented

Implement stat related syscalls" > Cc: Stacey Son > Cc: Warner Losh > Cc: Kyle Evans > Signed-off-by: Michael Tokarev > --- > bsd-user/bsd-mem.h | 2 +- > bsd-user/freebsd/os-proc.c | 2 +- > bsd-user/freebsd/os-stat.h | 6 +++--- > 3 files changed, 5 ins

Re: [PATCH 0/1] Enable -Wshadow=local

On Wed, Oct 25, 2023, 11:31 PM Markus Armbruster wrote: > Requires Brian's pull request and two patches from Thomas to compile: > > [PULL 0/2] hex queue - GETPC() fixes, shadowing fixes > [PATCH v2] block/snapshot: Fix compiler warning with -Wshadow=local > [PATCH v2] migration/ram:

Re: [PATCH 1/1] meson: Enable -Wshadow=local

On Wed, Oct 25, 2023, 11:31 PM Markus Armbruster wrote: > Local variables shadowing other local variables or parameters make the > code needlessly hard to understand. Bugs love to hide in such code. > Evidence: commit bbde656263d (migration/rdma: Fix save_page method to > fail on polling

Re: [PATCH] tests/vm/freebsd: Add additional library paths for libfdt

t; > Signed-off-by: Thomas Huth > --- > tests/vm/freebsd | 5 +++-- > 1 file changed, 3 insertions(+), 2 deletions(-) > Reviewed-by: Warner Losh diff --git a/tests/vm/freebsd b/tests/vm/freebsd > index ac51376c82..b581bd17fb 100755 > --- a/tests/vm/freebsd > +++ b/tes

Re: [RFC PATCH 06/11] tests/avocado: Add FreeBSD distro boot tests for ppc

On Tue, Oct 10, 2023 at 8:23 PM Nicholas Piggin wrote: > On Wed Oct 11, 2023 at 7:55 AM AEST, Warner Losh wrote: > > On Tue, Oct 10, 2023 at 1:53 AM Nicholas Piggin > wrote: > > > > > FreeBSD project provides qcow2 images that work well for testing QEMU. >

Re: [RFC PATCH 06/11] tests/avocado: Add FreeBSD distro boot tests for ppc

On Tue, Oct 10, 2023 at 6:36 PM Nicholas Piggin wrote: > On Wed Oct 11, 2023 at 7:55 AM AEST, Warner Losh wrote: > > On Tue, Oct 10, 2023 at 1:53 AM Nicholas Piggin > wrote: > > > > > FreeBSD project provides qcow2 images that work well for testing QEMU. >

Re: [RFC PATCH 06/11] tests/avocado: Add FreeBSD distro boot tests for ppc

named similarly to boot_linux. > > Cc: Warner Losh > Signed-off-by: Nicholas Piggin > > CC'ing Warner to check if it's okay for us to use these images and > any comments or suggestions. avocado tests have many Linux boots so we'd > do much better to expand test coverage by adding some o

Re: [v3] Help wanted for enabling -Wshadow=local

On Fri, Oct 6, 2023, 11:55 AM Thomas Huth wrote: > On 06/10/2023 18.18, Thomas Huth wrote: > > On 06/10/2023 16.45, Markus Armbruster wrote: > >> Local variables shadowing other local variables or parameters make the > >> code needlessly hard to understand. Bugs love to hide in such code. > >>

Re: Wshadow: Better name for 'optarg'?

On Wed, Oct 4, 2023, 11:44 AM Philippe Mathieu-Daudé wrote: > On 4/10/23 19:35, Thomas Huth wrote: > > On 04/10/2023 19.23, Richard Henderson wrote: > >> On 10/4/23 03:05, Philippe Mathieu-Daudé wrote: > >>> Hi, > >>> > >>> I'm getting a bunch of errors for 'optarg' declared in : > >> > >> I

Re: Wshadow: Better name for 'optarg'?

On Wed, Oct 4, 2023, 4:16 AM Daniel P. Berrangé wrote: > On Wed, Oct 04, 2023 at 12:05:04PM +0200, Philippe Mathieu-Daudé wrote: > > Hi, > > > > I'm getting a bunch of errors for 'optarg' declared in : > > > > NAME > > getopt – get option character from command line argument list > > > >

[PULL 51/51] bsd-user: Add stubs for vadvise(), sbrk() and sstk()

The above system calls are not supported by qemu. Signed-off-by: Warner Losh Signed-off-by: Karim Taha Reviewed-by: Richard Henderson Message-Id: <20230925182709.4834-24-kariem.taha...@gmail.com> --- bsd-user/bsd-mem.h| 18 ++ bsd-user/freebsd/os-syscall.

[PULL 49/51] bsd-user: Implement shmctl(2)

From: Stacey Son Signed-off-by: Stacey Son Signed-off-by: Karim Taha Reviewed-by: Richard Henderson Message-Id: <20230925182709.4834-22-kariem.taha...@gmail.com> --- bsd-user/bsd-mem.h| 39 +++ bsd-user/freebsd/os-syscall.c | 4 2 files

[PULL 44/51] bsd-user: Implment madvise(2) to match the linux-user implementation.

From: Karim Taha Signed-off-by: Karim Taha Reviewed-by: Richard Henderson Message-Id: <20230925182709.4834-17-kariem.taha...@gmail.com> --- bsd-user/bsd-mem.h| 53 +++ bsd-user/freebsd/os-syscall.c | 4 +++ bsd-user/syscall_defs.h | 2 ++ 3

[PULL 35/51] bsd-user: Add bsd-mem.c to meson.build

From: Karim Taha Signed-off-by: Karim Taha Reviewed-by: Richard Henderson Reviewed-by: Warner Losh Message-Id: <20230925182709.4834-8-kariem.taha...@gmail.com> --- bsd-user/bsd-mem.c | 0 bsd-user/meson.build | 1 + 2 files changed, 1 insertion(+) create mode 100644 bsd-user/bsd

[PULL 02/51] bsd-user: Define procctl(2) related structs

Reviewed-by: Warner Losh Message-Id: <20230925182425.3163-3-kariem.taha...@gmail.com> --- bsd-user/syscall_defs.h | 42 + 1 file changed, 42 insertions(+) diff --git a/bsd-user/syscall_defs.h b/bsd-user/syscall_defs.h index ddd38c13e08..a3bc738ff89

[PULL 40/51] bsd-user: Implement mmap(2) and munmap(2)

From: Stacey Son Signed-off-by: Stacey Son Signed-off-by: Karim Taha Reviewed-by: Warner Losh Reviewed-by: Richard Henderson Message-Id: <20230925182709.4834-13-kariem.taha...@gmail.com> --- bsd-user/bsd-mem.h| 20 bsd-user/freebsd/os-syscall.

[PULL 31/51] bsd-user: Declarations for ipc_perm and shmid_ds conversion functions

From: Stacey Son Signed-off-by: Stacey Son Signed-off-by: Karim Taha Reviewed-by: Richard Henderson Reviewed-by: Warner Losh Message-Id: <20230925182709.4834-4-kariem.taha...@gmail.com> --- bsd-user/qemu-bsd.h | 20 1 file changed, 20 insertions(+) diff --git

[PULL 28/51] bsd-user: Implement pdfork(2) system call.

From: Stacey Son Signed-off-by: Stacey Son Signed-off-by: Karim Taha Acked-by: Richard Henderson Reviewed-by: Warner Losh Message-Id: <20230925182425.3163-29-kariem.taha...@gmail.com> --- bsd-user/freebsd/os-proc.h| 32 bsd-user/freebsd/os-syscall.

[PULL 27/51] bsd-user: Implement rfork(2) system call.

From: Stacey Son Signed-off-by: Stacey Son Signed-off-by: Karim Taha Reviewed-by: Richard Henderson Reviewed-by: Warner Losh Message-Id: <20230925182425.3163-28-kariem.taha...@gmail.com> --- bsd-user/freebsd/os-proc.h| 39 +++ bsd-user/free

[PULL 46/51] bsd-user: Implement do_obreak function

From: Stacey Son Match linux-user, by manually applying the following commits, in order: d28b3c90cfad1a7e211ae2bce36ecb9071086129 linux-user: Make sure initial brk(0) is page-aligned 15ad98536ad9410fb32ddf1ff09389b677643faa linux-user: Fix qemu brk() to not zero bytes on current page

[PULL 19/51] bsd-user: Implement get_filename_from_fd.

From: Karim Taha Signed-off-by: Stacey Son Signed-off-by: Karim Taha Reviewed-by: Richard Henderson Reviewed-by: Warner Losh Message-Id: <20230925182425.3163-20-kariem.taha...@gmail.com> --- bsd-user/freebsd/meson.build | 1 + bsd-user/freebsd/os-proc.c

[PULL 30/51] bsd-user: Implement struct target_shmid_ds

From: Stacey Son Signed-off-by: Stacey Son Signed-off-by: Karim Taha Reviewed-by: Richard Henderson Reviewed-by: Warner Losh Message-Id: <20230925182709.4834-3-kariem.taha...@gmail.com> --- bsd-user/syscall_defs.h | 20 1 file changed, 20 insertions(+) diff --git

[PULL 15/51] bsd-user: Implement several get/set system calls:

From: Stacey Son getpid(2), getppid(2), getpgrp(2) setreuid(2), setregid(2) getuid(2), geteuid(2), getgid(2), getegid(2), getpgid(2) setuid(2), seteuid(2), setgid(2), setegid(2), setpgid(2) Signed-off-by: Stacey Son Signed-off-by: Karim Taha Reviewed-by: Richard Henderson Reviewed-by: Warner

[PULL 25/51] bsd-user: Implement pdgetpid(2) and the undocumented setugid.

From: Stacey Son Signed-off-by: Stacey Son Signed-off-by: Karim Taha Reviewed-by: Richard Henderson Reviewed-by: Warner Losh Message-Id: <20230925182425.3163-26-kariem.taha...@gmail.com> --- bsd-user/freebsd/os-proc.h| 23 +++ bsd-user/freebsd/os-syscall.

[PULL 47/51] bsd-user: Implement shm_open(2)

From: Stacey Son Co-authored-by: Kyle Evans Signed-off-by: Stacey Son Signed-off-by: Kyle Evans Signed-off-by: Karim Taha Reviewed-by: Richard Henderson Message-Id: <20230925182709.4834-20-kariem.taha...@gmail.com> --- bsd-user/bsd-mem.h| 25 +

[PULL 16/51] bsd-user: Implement get/set[resuid/resgid/sid] and issetugid.

From: Stacey Son Signed-off-by: Stacey Son Signed-off-by: Karim Taha Reviewed-by: Richard Henderson Reviewed-by: Warner Losh Message-Id: <20230925182425.3163-17-kariem.taha...@gmail.com> --- bsd-user/bsd-proc.h | 76 +++ bsd-user/free

[PULL 08/51] bsd-user: Implement host_to_target_rusage and host_to_target_wrusage.

From: Stacey Son Signed-off-by: Stacey Son Signed-off-by: Karim Taha Reviewed-by: Richard Henderson Reviewed-by: Warner Losh Message-Id: <20230925182425.3163-9-kariem.taha...@gmail.com> --- bsd-user/bsd-proc.c | 54 + 1 file changed, 54 inse

[PULL 33/51] bsd-user: Implement shm_open2(2) system call

From: Karim Taha Signed-off-by: Kyle Evans Signed-off-by: Karim Taha Reviewed-by: Richard Henderson Message-Id: <20230925182709.4834-6-kariem.taha...@gmail.com> --- bsd-user/freebsd/os-misc.h| 46 +++ bsd-user/freebsd/os-syscall.c | 22 - 2

[PULL 36/51] bsd-user: Implement target_set_brk function in bsd-mem.c instead of os-syscall.c

From: Stacey Son The definitions and variables names matches the corresponding ones in linux-user/syscall.c, for making later implementation of do_obreak easier Co-authored-by: Mikaël Urankar Signed-off-by: Mikaël Urankar Signed-off-by: Karim Taha Reviewed-by: Warner Losh Reviewed

[PULL 24/51] bsd-user: Implement setloginclass(2) and getloginclass(2) system calls.

From: Stacey Son Signed-off-by: Stacey Son Signed-off-by: Karim Taha Reviewed-by: Warner Losh Message-Id: <20230925182425.3163-25-kariem.taha...@gmail.com> --- bsd-user/freebsd/os-proc.h| 32 bsd-user/freebsd/os-syscall.c | 8 2 files c

[PULL 48/51] bsd-user: Implement shm_unlink(2) and shmget(2)

From: Stacey Son Signed-off-by: Stacey Son Signed-off-by: Karim Taha Reviewed-by: Warner Losh Reviewed-by: Richard Henderson Message-Id: <20230925182709.4834-21-kariem.taha...@gmail.com> --- bsd-user/bsd-mem.h| 23 +++ bsd-user/freebsd/os-syscall.

[PULL 05/51] bsd-user: add extern declarations for bsd-proc.c conversion functions

From: Stacey Son Signed-off-by: Stacey Son Signed-off-by: Karim Taha Reviewed-by: Richard Henderson Reviewed-by: Warner Losh Message-Id: <20230925182425.3163-6-kariem.taha...@gmail.com> --- bsd-user/qemu-bsd.h | 38 ++ 1 file changed, 38 inse

[PULL 39/51] bsd-user: Introduce bsd-mem.h to the source tree

From: Stacey Son Preserve the copyright notice and help with the 'Author' info for subsequent changes to the file. Signed-off-by: Stacey Son Signed-off-by: Karim Taha Reviewed-by: Warner Losh Reviewed-by: Richard Henderson Message-Id: <20230925182709.4834-12-kariem.taha...@gmail.

[PULL 32/51] bsd-user: Introduce freebsd/os-misc.h to the source tree

From: Stacey Son To preserve the copyright notice and help with the 'Author' info for subsequent changes to the file. Signed-off-by: Stacey Son Signed-off-by: Karim Taha Reviewed-by: Richard Henderson Reviewed-by: Warner Losh Message-Id: <20230925182709.4834-5-kariem.taha...@gmail.

[PULL 03/51] bsd-user: Implement host_to_target_siginfo.

From: Stacey Son Used in wait6 system call Signed-off-by: Stacey Son Signed-off-by: Karim Taha Reviewed-by: Richard Henderson Reviewed-by: Warner Losh Message-Id: <20230925182425.3163-4-kariem.taha...@gmail.com> --- bsd-user/signal-common.h | 1 + bsd-user/signal.c| 6 +++

[PULL 10/51] bsd-user: Get number of cpus.

From: Kyle Evans Signed-off-by: Kyle Evans Signed-off-by: Karim Taha Reviewed-by: Warner Losh Message-Id: <20230925182425.3163-11-kariem.taha...@gmail.com> --- bsd-user/bsd-proc.c | 24 bsd-user/bsd-proc.h | 2 ++ 2 files changed, 26 insertions(+) diff --git

[PULL 21/51] bsd-user: Implement procctl(2) along with necessary conversion functions.

From: Stacey Son Implement t2h_procctl_cmd, h2t_reaper_status, h2t_reaper_pidinfo and h2t/t2h reaper_kill conversion functions. Signed-off-by: Stacey Son Signed-off-by: Karim Taha Reviewed-by: Warner Losh Message-Id: <20230925182425.3163-22-kariem.taha...@gmail.com> --- bsd-user/free

[PULL 34/51] bsd-user: Implement shm_rename(2) system call

From: Kyle Evans Signed-off-by: Kyle Evans Signed-off-by: Karim Taha Reviewed-by: Richard Henderson Reviewed-by: Warner Losh Message-Id: <20230925182709.4834-7-kariem.taha...@gmail.com> --- bsd-user/freebsd/os-misc.h| 24 bsd-user/freebsd/os-syscall.

[PULL 13/51] bsd-user: Implement getrusage(2).

From: Stacey Son Signed-off-by: Stacey Son Signed-off-by: Karim Taha Reviewed-by: Richard Henderson Reviewed-by: Warner Losh Message-Id: <20230925182425.3163-14-kariem.taha...@gmail.com> --- bsd-user/bsd-proc.h | 13 + bsd-user/freebsd/os-syscall.c | 4 2

[PULL 37/51] bsd-user: Implement ipc_perm conversion between host and target.

From: Stacey Son Signed-off-by: Stacey Son Signed-off-by: Karim Taha Reviewed-by: Richard Henderson Message-Id: <20230925182709.4834-10-kariem.taha...@gmail.com> --- bsd-user/bsd-mem.c | 25 + 1 file changed, 25 insertions(+) diff --git a/bsd-user/bsd-mem.c

[PULL 07/51] bsd-user: Implement target_to_host_rlim and host_to_target_rlim conversion.

From: Stacey Son Signed-off-by: Stacey Son Signed-off-by: Karim Taha Reviewed-by: Richard Henderson Reviewed-by: Warner Losh Message-Id: <20230925182425.3163-8-kariem.taha...@gmail.com> --- bsd-user/bsd-proc.c | 10 ++ 1 file changed, 10 insertions(+) diff --git a/bsd-us

[PULL 12/51] bsd-user: Implement umask(2), setlogin(2) and getlogin(2)

From: Stacey Son Signed-off-by: Stacey Son Signed-off-by: Karim Taha Reviewed-by: Warner Losh Message-Id: <20230925182425.3163-13-kariem.taha...@gmail.com> --- bsd-user/bsd-proc.h | 39 +++ bsd-user/freebsd/os-syscall.c | 12 +++ 2

[PULL 38/51] bsd-user: Implement shmid_ds conversion between host and target.

From: Stacey Son Signed-off-by: Stacey Son Signed-off-by: Karim Taha Reviewed-by: Richard Henderson Message-Id: <20230925182709.4834-11-kariem.taha...@gmail.com> --- bsd-user/bsd-mem.c | 47 ++ 1 file changed, 47 insertions(+) diff --git

[PULL 06/51] bsd-user: Implement target_to_host_resource conversion function

From: Stacey Son Signed-off-by: Stacey Son Signed-off-by: Karim Taha Reviewed-by: Warner Losh Message-Id: <20230925182425.3163-7-kariem.taha...@gmail.com> --- bsd-user/bsd-proc.c | 40 bsd-user/bsd-proc.h | 4 bsd-user/meson.buil

[PULL 50/51] bsd-user: Implement shmat(2) and shmdt(2)

From: Stacey Son Use `WITH_MMAP_LOCK_GUARD` instead of mmap_lock() and mmap_unlock(), to match linux-user implementation, according to the following commits: 69fa2708a216df715ba5102a0f98468b540a464e linux-user: Use WITH_MMAP_LOCK_GUARD in target_{shmat,shmdt}

[PULL 42/51] bsd-user: Implement msync(2)

From: Stacey Son Co-authored-by: Kyle Evans Signed-off-by: Stacey Son Signed-off-by: Kyle Evans Signed-off-by: Karim Taha Reviewed-by: Warner Losh Reviewed-by: Richard Henderson Message-Id: <20230925182709.4834-15-kariem.taha...@gmail.com> --- bsd-user/bsd-mem.h

[PULL 41/51] bsd-user: Implement mprotect(2)

From: Stacey Son Signed-off-by: Stacey Son Signed-off-by: Karim Taha Reviewed-by: Richard Henderson Reviewed-by: Warner Losh Message-Id: <20230925182709.4834-14-kariem.taha...@gmail.com> --- bsd-user/bsd-mem.h| 7 +++ bsd-user/freebsd/os-syscall.c | 4 2 files c

[PULL 20/51] bsd-user: Implement freebsd_exec_common, used in implementing execve/fexecve.

From: Stacey Son Signed-off-by: Stacey Son Signed-off-by: Karim Taha Reviewed-by: Warner Losh Message-Id: <20230925182425.3163-21-kariem.taha...@gmail.com> --- bsd-user/freebsd/os-proc.c | 181 - bsd-user/main.c| 2 +- bsd-user/

[PULL 18/51] bsd-user: Implement getpriority(2) and setpriority(2).

From: Stacey Son Signed-off-by: Stacey Son Signed-off-by: Karim Taha Reviewed-by: Warner Losh Message-Id: <20230925182425.3163-19-kariem.taha...@gmail.com> --- bsd-user/bsd-proc.h | 24 bsd-user/freebsd/os-syscall.c | 8 2 files chang

[PULL 45/51] bsd-user: Implement mincore(2)

From: Stacey Son Signed-off-by: Stacey Son Signed-off-by: Karim Taha Reviewed-by: Richard Henderson Message-Id: <20230925182709.4834-18-kariem.taha...@gmail.com> --- bsd-user/bsd-mem.h| 23 +++ bsd-user/freebsd/os-syscall.c | 4 2 files changed, 27

[PULL 26/51] bsd-user: Implement fork(2) and vfork(2) system calls.

From: Stacey Son Signed-off-by: Stacey Son Signed-off-by: Karim Taha Reviewed-by: Richard Henderson Reviewed-by: Warner Losh Message-Id: <20230925182425.3163-27-kariem.taha...@gmail.com> --- bsd-user/freebsd/os-proc.h| 34 ++ bsd-user/freebsd/os-sys

[PULL 01/51] bsd-user: define TARGET_RFSPAWN for rfork to use vfork(2) semantics, and fix RLIM_INFINITY

From: Karim Taha RLIM_INFINITY on FreeBSD, OpenBSD and NetBSD has value of ~(1<<63), caculated one way or another. Signed-off-by: Kyle Evans Signed-off-by: Karim Taha Reviewed-by: Richard Henderson Reviewed-by: Warner Losh Message-Id: <20230925182425.3163-2-kariem.taha...@

[PULL 04/51] bsd-user: Add freebsd_exec_common and do_freebsd_procctl to qemu.h.

From: Stacey Son Signed-off-by: Stacey Son Signed-off-by: Karim Taha Reviewed-by: Richard Henderson Reviewed-by: Warner Losh Message-Id: <20230925182425.3163-5-kariem.taha...@gmail.com> --- bsd-user/qemu.h | 6 ++ 1 file changed, 6 insertions(+) diff --git a/bsd-user/qemu.h b/bs

[PULL 43/51] bsd-user: Implement mlock(2), munlock(2), mlockall(2), munlockall(2), minherit(2)

From: Stacey Son Signed-off-by: Stacey Son Signed-off-by: Karim Taha Reviewed-by: Richard Henderson Message-Id: <20230925182709.4834-16-kariem.taha...@gmail.com> --- bsd-user/bsd-mem.h| 37 +++ bsd-user/freebsd/os-syscall.c | 20 +++

[PULL 29/51] bsd-user: Implement struct target_ipc_perm

From: Stacey Son Signed-off-by: Stacey Son Signed-off-by: Karim Taha Reviewed-by: Richard Henderson Reviewed-by: Warner Losh Message-Id: <20230925182709.4834-2-kariem.taha...@gmail.com> --- bsd-user/syscall_defs.h | 17 + 1 file changed, 17 insertions(+) diff --git

[PULL 09/51] bsd-user: Implement host_to_target_waitstatus conversion.

From: Stacey Son Signed-off-by: Stacey Son Signed-off-by: Karim Taha Reviewed-by: Richard Henderson Reviewed-by: Warner Losh Message-Id: <20230925182425.3163-10-kariem.taha...@gmail.com> --- bsd-user/bsd-proc.c | 17 + 1 file changed, 17 insertions(+) diff --git a/bs

[PULL 00/51] Bsd user mmap patches

shmctl(2) bsd-user: Implement shmat(2) and shmdt(2) Warner Losh (1): bsd-user: Add stubs for vadvise(), sbrk() and sstk() bsd-user/bsd-mem.c| 104 bsd-user/bsd-mem.h| 452 bsd-user/bsd-proc.c | 145 ++ bsd

[PULL 17/51] bsd-user: Add stubs for profil(2), ktrace(2), utrace(2) and ptrace(2).

From: Stacey Son Signed-off-by: Stacey Son Signed-off-by: Karim Taha Reviewed-by: Richard Henderson Reviewed-by: Warner Losh Message-Id: <20230925182425.3163-18-kariem.taha...@gmail.com> --- bsd-user/bsd-proc.h | 28 bsd-user/freebsd/os-syscall.

[PULL 11/51] bsd-user: Implement getgroups(2) and setgroups(2) system calls.

From: Stacey Son Signed-off-by: Stacey Son Signed-off-by: Karim Taha Reviewed-by: Warner Losh Message-Id: <20230925182425.3163-12-kariem.taha...@gmail.com> --- bsd-user/bsd-proc.h | 44 +++ bsd-user/freebsd/os-syscall.c | 9 +++ 2 files c

[PULL 14/51] bsd-user: Implement getrlimit(2) and setrlimit(2)

From: Stacey Son Signed-off-by: Stacey Son Signed-off-by: Karim Taha Reviewed-by: Richard Henderson Reviewed-by: Warner Losh Message-Id: <20230925182425.3163-15-kariem.taha...@gmail.com> --- bsd-user/bsd-proc.h | 59 +++ bsd-user/free

[PULL 22/51] bsd-user: Implement execve(2) and fexecve(2) system calls.

From: Karim Taha Signed-off-by: Stacey Son Signed-off-by: Karim Taha Reviewed-by: Richard Henderson Reviewed-by: Warner Losh Message-Id: <20230925182425.3163-23-kariem.taha...@gmail.com> --- bsd-user/freebsd/os-proc.h| 49 +++ bsd-user/free

[PULL 23/51] bsd-user: Implement wait4(2) and wait6(2) system calls.

From: Stacey Son Signed-off-by: Stacey Son Signed-off-by: Karim Taha Reviewed-by: Warner Losh Message-Id: <20230925182425.3163-24-kariem.taha...@gmail.com> --- bsd-user/freebsd/os-proc.h| 84 +++ bsd-user/freebsd/os-syscall.c | 15 +++ 2 files c

Re: [PATCH v6 00/23] bsd-user: Implement mmap related system calls for FreeBSD.

2), munlockall(2), > minherit(2) > bsd-user: Implement mincore(2) > bsd-user: Implement do_obreak function > bsd-user: Implement shm_open(2) > bsd-user: Implement shm_unlink(2) and shmget(2) > bsd-user: Implement shmctl(2) > bsd-user: Implement shmat(2) and s

Re: [PATCH v5 00/28] bsd-user: Implement freebsd process related system calls.

On Mon, Sep 25, 2023 at 12:25 PM Karim Taha wrote: > > > Karim Taha (3): > bsd-user: define TARGET_RFSPAWN for rfork to use vfork(2) semantics, > and fix RLIM_INFINITY > bsd-user: Implement get_filename_from_fd. > bsd-user: Implement execve(2) and fexecve(2) system calls. > > Kyle

Re: [v2] Help wanted for enabling -Wshadow=local

On Tue, Sep 26, 2023 at 8:43 AM Markus Armbruster wrote: > Brian, Gerd, Jason, Marc-André, Michael, we need your help to enable > -Wshadow=local. > > Paolo, you already took care of several subsystems (thanks!), except you > left a few warnings in target/i386/tcg/seg_helper.c. > > > Local

Re: Help wanted for enabling -Wshadow=local

On Sat, Sep 23, 2023 at 6:33 AM Peter Maydell wrote: > On Fri, 22 Sept 2023 at 19:59, Warner Losh wrote: > > The third one, though, makes me ask the question: When should we > > pass in cpu_env to functions and when should we use the global value? > > > > I have a lo

Re: [PATCH v4 25/28] bsd-user: Implement pdgetpid(2) and the undocumented setugid.

| 8 > 2 files changed, 31 insertions(+) > Reviewed-by: Warner Losh

Re: [PATCH v4 24/28] bsd-user: Implement setloginclass(2) and getloginclass(2) system calls.

s changed, 40 insertions Reviewed-by: Warner Losh

Re: [PATCH v4 23/28] bsd-user: Implement wait4(2) and wait6(2) system calls.

s changed, 99 insertions(+) > Reviewed-by: Warner Losh

Re: [PATCH v4 21/28] bsd-user: Implement procctl(2) along with necessary conversion functions.

/freebsd/os-proc.c| 222 ++ > bsd-user/freebsd/os-syscall.c | 3 + > 2 files changed, 225 insertions(+) > Reviewed-by: Warner Losh This appears to line up, but if Richard has time for only one review, this one would be the best place to spend it in cas

Re: [PATCH v4 12/28] bsd-user: Implement umask(2), setlogin(2) and getlogin(2)

s changed, 51 insertions(+) > Reviewed-by: Warner Losh

Re: [PATCH v4 06/28] bsd-user: Implement target_to_host_resource conversion function

+ > 3 files changed, 50 insertions(+) > create mode 100644 bsd-user/bsd-proc.c > This looks good. The extra libraries relative to linux-user are for the stuff bsd-user does to support some additional things than linux-user supports. Reviewed-by: Warner Losh > diff --git a/bsd-u

Re: Help wanted for enabling -Wshadow=local

On Fri, Sep 22, 2023 at 11:49 AM Peter Maydell wrote: > On Fri, 22 Sept 2023 at 18:43, Daniel Henrique Barboza > wrote: > > Can you publish your branch with the current -Wshadow=local patches in > > gitlab/github? I'm hitting (and fixing) a lot of errors that aren't > listed > > here, meaning

Re: [PATCH v2 28/28] bsd-user: Implement pdfork(2) system call.

l.c | 4 > 2 files changed, 36 insertions(+) > Reviewed-by: Warner Losh I chased down pdfork recently for other reasons, and I'm pretty sure this is good. Warner

Re: [PATCH v2 27/28] bsd-user: Implement rfork(2) system call.

syscall.c | 4 > 2 files changed, 43 insertions(+) > Reviewed-by: Warner Losh > diff --git a/bsd-user/freebsd/os-proc.h b/bsd-user/freebsd/os-proc.h > index 14478d4bb5..a406ef7db8 100644 > --- a/bsd-user/freebsd/os-proc.h > +++ b/bsd-user/freebsd/os-proc.h >

Re: [PATCH v2 26/28] bsd-user: Implement fork(2) and vfork(2) system calls.

all.c | 8 > 2 files changed, 42 insertions(+) > Reviewed-by: Warner Losh Though i have minor qualms about vfork == fork, for bsd-user it's fine since I don't think the performance difference will be that large for the typical case where vfork + exec exists for older (now kinda

Re: [PATCH v2 25/28] bsd-user: Implement pdgetpid(2) and the undocumented setugid.

On Sun, Sep 17, 2023 at 10:39 PM Karim Taha wrote: > From: Stacey Son > > Signed-off-by: Stacey Son > Signed-off-by: Karim Taha > Reviewed-by: Richard Henderson > --- > bsd-user/freebsd/os-proc.h| 23 +++ > bsd-user/freebsd/os-syscall.c | 8 > 2 files

Re: [PATCH v2 24/28] bsd-user: Implement setloginclass(2) and getloginclass(2) system calls.

On Sun, Sep 17, 2023 at 10:39 PM Karim Taha wrote: > From: Stacey Son > > Signed-off-by: Stacey Son > Signed-off-by: Karim Taha > Reviewed-by: Richard Henderson > --- > bsd-user/freebsd/os-proc.h| 32 > bsd-user/freebsd/os-syscall.c | 8 > 2

Re: [PATCH v2 23/28] bsd-user: Implement wait4(2) and wait6(2) system calls.

On Sun, Sep 17, 2023 at 10:39 PM Karim Taha wrote: > From: Stacey Son > > Signed-off-by: Stacey Son > Signed-off-by: Karim Taha > Reviewed-by: Richard Henderson > --- > bsd-user/freebsd/os-proc.h| 77 +++ > bsd-user/freebsd/os-syscall.c | 15 +++ > 2

Re: [PATCH v2 22/28] bsd-user: Implement execve(2) and fexecve(2) system calls.

2 files changed, 59 insertions(+), 1 deletion(-) > create mode 100644 bsd-user/freebsd/os-proc.h > Reviewed-by: Warner Losh But make sure that the guard variable name is correct, I think with scripts/ clean-header-guards.pl > diff --git a/bsd-user/freebsd/os-proc.h b/bsd-user/freebsd/os

Re: [PATCH v2 21/28] bsd-user: Implement procctl(2) along with necessary conversion functions.

On Sun, Sep 17, 2023 at 10:39 PM Karim Taha wrote: > From: Stacey Son > > Implement t2h_procctl_cmd, h2t_reaper_status, h2t_reaper_pidinfo and > h2t/t2h reaper_kill conversion functions. > > Signed-off-by: Stacey Son > Signed-off-by: Karim Taha > --- > bsd-user/freebsd/os-proc.c| 223

Re: [PATCH v2 20/28] bsd-user: Implement freebsd_exec_common, used in implementing execve/fexecve.

| 1 + > 3 files changed, 179 insertions(+), 1 deletion(-) > Reviewed-by: Warner Losh But see comment below. > diff --git a/bsd-user/freebsd/os-proc.c b/bsd-user/freebsd/os-proc.c > index cb35f29f10..12d78b7fc9 100644 > --- a/bsd-user/freebsd/os-proc.c > +++ b/bsd

Re: [PATCH v2 19/28] bsd-user: Implement get_filename_from_fd.

hanged, 81 insertions(+) > create mode 100644 bsd-user/freebsd/os-proc.c > Reviewed-by: Warner Losh

  1   2   3   4   5   6   7   8   9   10   >