Re: [Qemu-devel] [RESEND PATCH v2 0/4] QOM'ify hw/audio files

[zxq_yx_007]

At 2016-03-17 17:06:12, "xiaoqiang zhao"  wrote:
>This patch set QOM'ify some files under hw/audio directory.
>See each patch's commit message for details.
>
>Changes in v2:
>Move AUD_open_in/out function into device realize stage
>
>Sorry for the misoperation before, so I resend this version.
>
>xiaoqiang zhao (4):
>  hw/audio: QOM'ify cs4231.c
>  hw/audio: QOM cleanup for intel-hda
>  hw/audio: QOM'ify intel-hda
>  hw/audio: QOM'ify milkymist-ac97.c
>
> hw/audio/cs4231.c | 12 +---
> hw/audio/intel-hda.c  | 30 --
> hw/audio/milkymist-ac97.c | 26 +++---
> 3 files changed, 36 insertions(+), 32 deletions(-)
>
>-- 
>2.1.4

>
ping ???

Re: [Qemu-devel] [PATCH v2 0/4] QOM'ify hw/audio files

[zxq_yx_007]

At 2016-03-17 16:15:13, "xiaoqiang zhao"  wrote:
>This patch set QOM'ify some files under hw/audio directory.
>See each patch's commit message for details.
>
>Changes in v2:
>move AUD_open_out/in function calls to device realize 
>stage suggested by Paolo.
>
>xiaoqiang zhao (4):
>  hw/audio: QOM'ify cs4231.c
>  hw/audio: QOM cleanup for intel-hda
>  hw/audio: QOM'ify intel-hda
>  hw/audio: QOM'ify milkymist-ac97.c
>
> hw/audio/cs4231.c | 12 +---
> hw/audio/intel-hda.c  | 30 --
> hw/audio/milkymist-ac97.c | 13 +
> 3 files changed, 26 insertions(+), 29 deletions(-)
>
>-- 
>2.1.4
>

Sorry guys, misoperation happend . Please do not reply to this thread 
and I will resend a correct one soon.

Re: [Qemu-devel] [PATCH 5/6] hw/char: QOM'ify sclpconsole-lm.c

[zxq_yx_007]

At 2016-03-17 18:08:52, "Cornelia Huck"  wrote:
>On Thu, 17 Mar 2016 17:20:29 +0800
>xiaoqiang zhao  wrote:
>
>> Drop the DO_UPCAST macro
>> 
>> Signed-off-by: xiaoqiang zhao 
>> ---
>>  hw/char/sclpconsole-lm.c | 14 +-
>>  1 file changed, 9 insertions(+), 5 deletions(-)
>> 
>> diff --git a/hw/char/sclpconsole-lm.c b/hw/char/sclpconsole-lm.c
>> index 7d4ff81..3dcc5a5 100644
>> --- a/hw/char/sclpconsole-lm.c
>> +++ b/hw/char/sclpconsole-lm.c
>> @@ -44,6 +44,10 @@ typedef struct SCLPConsoleLM {
>>  uint8_t buf[SIZE_CONSOLE_BUFFER];
>>  } SCLPConsoleLM;
>> 
>> +#define TYPE_SCLP_LM_CONSOLE "sclplmconsole"
>> +#define SCLP_LM_CONSOLE(obj) \
>> +OBJECT_CHECK(SCLPConsoleLM, (obj), TYPE_SCLP_LM_CONSOLE)
>
>I'd prefer SCLPLM over SCLP_LM (don't know, but the 'LM' looks a bit
>lonely ;)
>

>
Maybe better!

Re: [Qemu-devel] [PATCH 0/9] some QOM'ify work under hw/arm

[zxq_yx_007]

At 2016-03-07 15:05:41, "xiaoqiang zhao"  wrote:
>This patch set trying to QOM'ify code under hw/arm directory.
>As previous patches to hw/timer/*, we use instance_init instead of
>the SysBus's init function. 
>
>
>xiaoqiang zhao (9):
>  hw/arm: QOM'ify armv7m.c
>  hw/arm: QOM'ify highbank.c
>  hw/arm: QOM'ify integratorcp.c
>  hw/arm: QOM'ify pxa2xx.c
>  hw/arm: QOM'ify pxa2xx_pic.c
>  hw/arm: QOM'ify spitz.c
>  hw/arm: QOM'ify stellaris.c
>  hw/arm: QOM'ify strongarm.c
>  hw/arm: QOM'ify versatilepb.c
>
> hw/arm/armv7m.c   | 11 -
> hw/arm/highbank.c | 12 --
> hw/arm/integratorcp.c | 32 ++---
> hw/arm/pxa2xx.c   | 26 +---
> hw/arm/pxa2xx_pic.c   |  7 --
> hw/arm/spitz.c| 23 +++---
> hw/arm/stellaris.c| 48 ++---
> hw/arm/strongarm.c| 66 ++-
> hw/arm/versatilepb.c  | 13 +-
> 9 files changed, 100 insertions(+), 138 deletions(-)
>
>-- 
>2.1.4

>
ping !

[Qemu-devel] 回复：Re: Re[2]: [PATCH v3 12/16] hw/timer: QOM'ify pl031

[zxq_yx_007]

What "top-post" mean?
在2016年02月18日 22:31，Peter Maydell 写道:
On 18 February 2016 at 14:26,   wrote:
> Thanks Peter!
> Sorry for that！I will correct this in next version. I also have one
> question：Why the patch I have sent to this list does not have a title begin
> with "[Qemu-devel]" ?

It depends entirely which copy you see. For example the list
archive's copy does:
https://lists.nongnu.org/archive/html/qemu-devel/2016-02/msg03400.html

If your mail client sees the copy that went via the mailing list
server first, that's the subject you'll see. If it sees some other
copy first (perhaps you were personally cc'd on the mail, or if
you sent the mail yourself there's the copy you actually sent)
then it won't have the subject tag. If it was sent to several
mailing lists then you might first see the copy from one of the
other lists with that list's tag.

(PS: please don't top-post list email.)

thanks
-- PMM

Re: [Qemu-devel] [PATCH v3 16/16] hw/timer: QOM'ify tusb6010

[zxq_yx_007]

Ok, I will take a look!



2016年2月18日 星期四 +0800 21:48 发件人 peter.mayd...@linaro.org  
:
>On 16 February 2016 at 11:10, xiaoqiang zhao < zxq_yx_...@163.com > wrote:
>> assign tusb6010_init to tusb6010_info.instance_init and drop
>> the SysBusDeviceClass::init
>>
>> Reviewed-by: Peter Maydell < peter.mayd...@linaro.org >
>> Signed-off-by: xiaoqiang zhao < zxq_yx_...@163.com >
>
>(Again, I didn't review this patch.)
>
>> ---
>>  hw/timer/tusb6010.c | 13 ++---
>>  1 file changed, 6 insertions(+), 7 deletions(-)
>>
>> diff --git a/hw/timer/tusb6010.c b/hw/timer/tusb6010.c
>> index 9f6af90..205127c 100644
>> --- a/hw/timer/tusb6010.c
>> +++ b/hw/timer/tusb6010.c
>> @@ -776,29 +776,27 @@ static void tusb6010_reset(DeviceState *dev)
>>  musb_reset(s->musb);
>>  }
>>
>> -static int tusb6010_init(SysBusDevice *sbd)
>> +static void tusb6010_init(Object *obj)
>>  {
>> -DeviceState *dev = DEVICE(sbd);
>> -TUSBState *s = TUSB(dev);
>> +DeviceState *dev = DEVICE(obj);
>> +TUSBState *s = TUSB(obj);
>> +SysBusDevice *sbd = SYS_BUS_DEVICE(obj);
>>
>>  s->otg_timer = timer_new_ns(QEMU_CLOCK_VIRTUAL, tusb_otg_tick, s);
>>  s->pwr_timer = timer_new_ns(QEMU_CLOCK_VIRTUAL, tusb_power_tick, s);
>> -memory_region_init_io(>iomem[1], OBJECT(s), _async_ops, s,
>> +memory_region_init_io(>iomem[1], obj, _async_ops, s,
>>"tusb-async", UINT32_MAX);
>>  sysbus_init_mmio(sbd, >iomem[0]);
>>  sysbus_init_mmio(sbd, >iomem[1]);
>>  sysbus_init_irq(sbd, >irq);
>>  qdev_init_gpio_in(dev, tusb6010_irq, musb_irq_max + 1);
>>  s->musb = musb_init(dev, 1);
>> -return 0;
>>  }
>>
>>  static void tusb6010_class_init(ObjectClass *klass, void *data)
>>  {
>>  DeviceClass *dc = DEVICE_CLASS(klass);
>> -SysBusDeviceClass *k = SYS_BUS_DEVICE_CLASS(klass);
>>
>> -k->init = tusb6010_init;
>>  dc->reset = tusb6010_reset;
>>  }
>>
>> @@ -806,6 +804,7 @@ static const TypeInfo tusb6010_info = {
>>  .name  = TYPE_TUSB6010,
>>  .parent= TYPE_SYS_BUS_DEVICE,
>>  .instance_size = sizeof(TUSBState),
>> +.instance_init = tusb6010_init,
>>  .class_init= tusb6010_class_init,
>>  };
>
>This patch seems to break "make check":
>
>TEST: tests/device-introspect-test... (pid=6070)
>  /arm/device/introspect/list: OK
>  /arm/device/introspect/none: OK
>  /arm/device/introspect/abstract: OK
>  /arm/device/introspect/concrete: **
>ERROR:/home/petmay01/linaro/qemu-from-laptop/qemu/qom/object.c:1576:object_get_canonical_path_component:
>assertion failed: (obj->parent != NULL)
>Broken pipe
>FAIL
>GTester: last random seed: R02S57c9475befd55374bcf61f6f190cd8ad
>(pid=6093)
>FAIL: tests/device-introspect-test
>
>thanks
>-- PMM

Re: [Qemu-devel] [PATCH v3 12/16] hw/timer: QOM'ify pl031

[zxq_yx_007]

Thanks Peter!
Sorry for that！I will correct this in next version. I also have one 
question：Why the patch I have sent to this list does not have a title begin 
with "[Qemu-devel]" ?



2016年2月18日 星期四 +0800 21:02 发件人 peter.mayd...@linaro.org  
:
>On 16 February 2016 at 11:10, xiaoqiang zhao < zxq_yx_...@163.com > wrote:
>> assign pl031_init to pl031_info.instance_init and drop the
>> SysBusDeviceClass::init
>>
>> Reviewed-by: Peter Maydell < peter.mayd...@linaro.org >
>> Signed-off-by: xiaoqiang zhao < zxq_yx_...@163.com >
>
>I didn't review this patch! Please be more careful
>about only applying reviewed-by: tags to the correct
>patches when you're sending out new versions. (You seem
>to have got this wrong for some of the others in this
>series too.)
>
>thanks
>-- PMM