Re: [Qemu-devel] [PATCH 3/3] pc: Don't make CPU properties mandatory unless necessary

2019-08-28 Thread Igor Mammedov
On Tue, 27 Aug 2019 18:15:53 +0200 Markus Armbruster wrote: > Igor Mammedov writes: > > > On Sat, 17 Aug 2019 08:17:48 +0200 > > Markus Armbruster wrote: > > > >> Eduardo Habkost writes: > >> > >> > On Fri, Aug 16, 2019 at 03:20:11PM +0200, Igor Mammedov wrote: > >> >> On Thu, 15

Re: [Qemu-devel] [PATCH 3/3] pc: Don't make CPU properties mandatory unless necessary

2019-08-27 Thread Markus Armbruster
Igor Mammedov writes: > On Sat, 17 Aug 2019 08:17:48 +0200 > Markus Armbruster wrote: > >> Eduardo Habkost writes: >> >> > On Fri, Aug 16, 2019 at 03:20:11PM +0200, Igor Mammedov wrote: >> >> On Thu, 15 Aug 2019 15:38:03 -0300 >> >> Eduardo Habkost wrote: >> >> >> >> > We have this

Re: [Qemu-devel] [PATCH 3/3] pc: Don't make CPU properties mandatory unless necessary

2019-08-26 Thread Igor Mammedov
On Sat, 17 Aug 2019 08:17:48 +0200 Markus Armbruster wrote: > Eduardo Habkost writes: > > > On Fri, Aug 16, 2019 at 03:20:11PM +0200, Igor Mammedov wrote: > >> On Thu, 15 Aug 2019 15:38:03 -0300 > >> Eduardo Habkost wrote: > >> > >> > We have this issue reported when using libvirt to

Re: [Qemu-devel] [PATCH 3/3] pc: Don't make CPU properties mandatory unless necessary

2019-08-20 Thread Eduardo Habkost
On Fri, Aug 16, 2019 at 05:07:10PM -0400, Yash Mankad wrote: > On 8/16/19 1:42 PM, Eduardo Habkost wrote: > > On Fri, Aug 16, 2019 at 02:22:58PM +0200, Markus Armbruster wrote: > >> Erik Skultety writes: > >> > >>> On Fri, Aug 16, 2019 at 08:10:20AM +0200, Markus Armbruster wrote: > Eduardo

Re: [Qemu-devel] [PATCH 3/3] pc: Don't make CPU properties mandatory unless necessary

2019-08-17 Thread Markus Armbruster
Eduardo Habkost writes: > On Fri, Aug 16, 2019 at 03:20:11PM +0200, Igor Mammedov wrote: >> On Thu, 15 Aug 2019 15:38:03 -0300 >> Eduardo Habkost wrote: >> >> > We have this issue reported when using libvirt to hotplug CPUs: >> > https://bugzilla.redhat.com/show_bug.cgi?id=1741451 >> > >> >

Re: [Qemu-devel] [PATCH 3/3] pc: Don't make CPU properties mandatory unless necessary

2019-08-16 Thread Markus Armbruster
Eduardo Habkost writes: > On Fri, Aug 16, 2019 at 02:22:58PM +0200, Markus Armbruster wrote: >> Erik Skultety writes: >> >> > On Fri, Aug 16, 2019 at 08:10:20AM +0200, Markus Armbruster wrote: >> >> Eduardo Habkost writes: >> >> >> >> > We have this issue reported when using libvirt to

Re: [Qemu-devel] [PATCH 3/3] pc: Don't make CPU properties mandatory unless necessary

2019-08-16 Thread Yash Mankad
On 8/16/19 1:42 PM, Eduardo Habkost wrote: > On Fri, Aug 16, 2019 at 02:22:58PM +0200, Markus Armbruster wrote: >> Erik Skultety writes: >> >>> On Fri, Aug 16, 2019 at 08:10:20AM +0200, Markus Armbruster wrote: Eduardo Habkost writes: > We have this issue reported when using

Re: [Qemu-devel] [PATCH 3/3] pc: Don't make CPU properties mandatory unless necessary

2019-08-16 Thread Eduardo Habkost
On Fri, Aug 16, 2019 at 02:22:58PM +0200, Markus Armbruster wrote: > Erik Skultety writes: > > > On Fri, Aug 16, 2019 at 08:10:20AM +0200, Markus Armbruster wrote: > >> Eduardo Habkost writes: > >> > >> > We have this issue reported when using libvirt to hotplug CPUs: > >> >

Re: [Qemu-devel] [PATCH 3/3] pc: Don't make CPU properties mandatory unless necessary

2019-08-16 Thread Eduardo Habkost
On Fri, Aug 16, 2019 at 03:20:11PM +0200, Igor Mammedov wrote: > On Thu, 15 Aug 2019 15:38:03 -0300 > Eduardo Habkost wrote: > > > We have this issue reported when using libvirt to hotplug CPUs: > > https://bugzilla.redhat.com/show_bug.cgi?id=1741451 > > > > Basically, libvirt is not copying

Re: [Qemu-devel] [PATCH 3/3] pc: Don't make CPU properties mandatory unless necessary

2019-08-16 Thread Eduardo Habkost
On Fri, Aug 16, 2019 at 08:10:20AM +0200, Markus Armbruster wrote: > Eduardo Habkost writes: > > > We have this issue reported when using libvirt to hotplug CPUs: > > https://bugzilla.redhat.com/show_bug.cgi?id=1741451 > > > > Basically, libvirt is not copying die-id from > >

Re: [Qemu-devel] [PATCH 3/3] pc: Don't make CPU properties mandatory unless necessary

2019-08-16 Thread Igor Mammedov
On Thu, 15 Aug 2019 15:38:03 -0300 Eduardo Habkost wrote: > We have this issue reported when using libvirt to hotplug CPUs: > https://bugzilla.redhat.com/show_bug.cgi?id=1741451 > > Basically, libvirt is not copying die-id from > query-hotpluggable-cpus, but die-id is now mandatory. this

Re: [Qemu-devel] [PATCH 3/3] pc: Don't make CPU properties mandatory unless necessary

2019-08-16 Thread Markus Armbruster
Erik Skultety writes: > On Fri, Aug 16, 2019 at 08:10:20AM +0200, Markus Armbruster wrote: >> Eduardo Habkost writes: >> >> > We have this issue reported when using libvirt to hotplug CPUs: >> > https://bugzilla.redhat.com/show_bug.cgi?id=1741451 >> > >> > Basically, libvirt is not copying

Re: [Qemu-devel] [PATCH 3/3] pc: Don't make CPU properties mandatory unless necessary

2019-08-16 Thread Erik Skultety
On Fri, Aug 16, 2019 at 08:10:20AM +0200, Markus Armbruster wrote: > Eduardo Habkost writes: > > > We have this issue reported when using libvirt to hotplug CPUs: > > https://bugzilla.redhat.com/show_bug.cgi?id=1741451 > > > > Basically, libvirt is not copying die-id from > >

Re: [Qemu-devel] [PATCH 3/3] pc: Don't make CPU properties mandatory unless necessary

2019-08-16 Thread Markus Armbruster
Eduardo Habkost writes: > We have this issue reported when using libvirt to hotplug CPUs: > https://bugzilla.redhat.com/show_bug.cgi?id=1741451 > > Basically, libvirt is not copying die-id from > query-hotpluggable-cpus, but die-id is now mandatory. Uh-oh, "is now mandatory": making an optional

[Qemu-devel] [PATCH 3/3] pc: Don't make CPU properties mandatory unless necessary

2019-08-15 Thread Eduardo Habkost
We have this issue reported when using libvirt to hotplug CPUs: https://bugzilla.redhat.com/show_bug.cgi?id=1741451 Basically, libvirt is not copying die-id from query-hotpluggable-cpus, but die-id is now mandatory. We could blame libvirt and say it is not following the documented interface,