Re: [Qemu-devel] [PATCH v8 1/2] block/vxhs.c: Add support for a new block device type called "vxhs"

On Wed, Mar 22, 2017 at 5:03 PM, ashish mittal wrote: > On Mon, Mar 20, 2017 at 5:55 AM, Daniel P. Berrange > wrote: >> On Fri, Mar 17, 2017 at 06:44:56PM -0700, ashish mittal wrote: >>> On Thu, Mar 16, 2017 at 5:29 PM, ashish mittal

Re: [Qemu-devel] [PATCH v8 1/2] block/vxhs.c: Add support for a new block device type called "vxhs"

On Mon, Mar 20, 2017 at 5:55 AM, Daniel P. Berrange wrote: > On Fri, Mar 17, 2017 at 06:44:56PM -0700, ashish mittal wrote: >> On Thu, Mar 16, 2017 at 5:29 PM, ashish mittal wrote: >> > On Mon, Mar 13, 2017 at 2:57 AM, Daniel P. Berrange

Re: [Qemu-devel] [PATCH v8 1/2] block/vxhs.c: Add support for a new block device type called "vxhs"

On Fri, Mar 17, 2017 at 06:44:56PM -0700, ashish mittal wrote: > On Thu, Mar 16, 2017 at 5:29 PM, ashish mittal wrote: > > On Mon, Mar 13, 2017 at 2:57 AM, Daniel P. Berrange > > wrote: > >> On Tue, Mar 07, 2017 at 05:27:55PM -0800, ashish mittal wrote:

Re: [Qemu-devel] [PATCH v8 1/2] block/vxhs.c: Add support for a new block device type called "vxhs"

On Thu, Mar 16, 2017 at 5:29 PM, ashish mittal wrote: > On Mon, Mar 13, 2017 at 2:57 AM, Daniel P. Berrange > wrote: >> On Tue, Mar 07, 2017 at 05:27:55PM -0800, ashish mittal wrote: >>> Thanks! There is one more input I need some help with! >>> >>>

Re: [Qemu-devel] [PATCH v8 1/2] block/vxhs.c: Add support for a new block device type called "vxhs"

On Mon, Mar 13, 2017 at 2:57 AM, Daniel P. Berrange wrote: > On Tue, Mar 07, 2017 at 05:27:55PM -0800, ashish mittal wrote: >> Thanks! There is one more input I need some help with! >> >> VxHS network library opens a fixed number of connection channels to a >> given host, and

Re: [Qemu-devel] [PATCH v8 1/2] block/vxhs.c: Add support for a new block device type called "vxhs"

On Tue, Mar 07, 2017 at 05:27:55PM -0800, ashish mittal wrote: > Thanks! There is one more input I need some help with! > > VxHS network library opens a fixed number of connection channels to a > given host, and all the vdisks (that connect to the same host) share > these connection channels. >

Re: [Qemu-devel] [PATCH v8 1/2] block/vxhs.c: Add support for a new block device type called "vxhs"

On Fri, Mar 10, 2017 at 07:04:38PM -0800, ashish mittal wrote: > On Wed, Mar 8, 2017 at 10:11 AM, Daniel P. Berrange > wrote: > > On Wed, Mar 08, 2017 at 09:59:32AM -0800, ashish mittal wrote: > >> On Wed, Mar 8, 2017 at 5:04 AM, Ketan Nilangekar > >>

Re: [Qemu-devel] [PATCH v8 1/2] block/vxhs.c: Add support for a new block device type called "vxhs"

On Wed, Mar 8, 2017 at 10:11 AM, Daniel P. Berrange wrote: > On Wed, Mar 08, 2017 at 09:59:32AM -0800, ashish mittal wrote: >> On Wed, Mar 8, 2017 at 5:04 AM, Ketan Nilangekar >> wrote: >> > >> > >> >> On Mar 8, 2017, at 1:13 AM, Daniel P.

Re: [Qemu-devel] [PATCH v8 1/2] block/vxhs.c: Add support for a new block device type called "vxhs"

On Wed, Mar 08, 2017 at 09:59:32AM -0800, ashish mittal wrote: > On Wed, Mar 8, 2017 at 5:04 AM, Ketan Nilangekar > wrote: > > > > > >> On Mar 8, 2017, at 1:13 AM, Daniel P. Berrange wrote: > >> > >>> On Tue, Mar 07, 2017 at 05:27:55PM -0800,

Re: [Qemu-devel] [PATCH v8 1/2] block/vxhs.c: Add support for a new block device type called "vxhs"

On Wed, Mar 8, 2017 at 5:04 AM, Ketan Nilangekar wrote: > > >> On Mar 8, 2017, at 1:13 AM, Daniel P. Berrange wrote: >> >>> On Tue, Mar 07, 2017 at 05:27:55PM -0800, ashish mittal wrote: >>> Thanks! There is one more input I need some help with!

Re: [Qemu-devel] [PATCH v8 1/2] block/vxhs.c: Add support for a new block device type called "vxhs"

> On Mar 8, 2017, at 1:13 AM, Daniel P. Berrange wrote: > >> On Tue, Mar 07, 2017 at 05:27:55PM -0800, ashish mittal wrote: >> Thanks! There is one more input I need some help with! >> >> VxHS network library opens a fixed number of connection channels to a >> given host,

Re: [Qemu-devel] [PATCH v8 1/2] block/vxhs.c: Add support for a new block device type called "vxhs"

On Tue, Mar 07, 2017 at 05:27:55PM -0800, ashish mittal wrote: > Thanks! There is one more input I need some help with! > > VxHS network library opens a fixed number of connection channels to a > given host, and all the vdisks (that connect to the same host) share > these connection channels. >

Re: [Qemu-devel] [PATCH v8 1/2] block/vxhs.c: Add support for a new block device type called "vxhs"

Thanks! There is one more input I need some help with! VxHS network library opens a fixed number of connection channels to a given host, and all the vdisks (that connect to the same host) share these connection channels. Therefore, we need to open secure channels to a specific target host only

Re: [Qemu-devel] [PATCH v8 1/2] block/vxhs.c: Add support for a new block device type called "vxhs"

On Sun, Mar 05, 2017 at 04:26:05PM -0800, ashish mittal wrote: > On Wed, Mar 1, 2017 at 1:18 AM, Daniel P. Berrange > wrote: > > > > Yes, that's how other parts of QEMU deal with SSL > > > > NB, QEMU needs to pass 3 paths to libqnoio - the client cert, the > > client key,

Re: [Qemu-devel] [PATCH v8 1/2] block/vxhs.c: Add support for a new block device type called "vxhs"

On Wed, Mar 1, 2017 at 1:18 AM, Daniel P. Berrange wrote: > On Tue, Feb 28, 2017 at 02:51:39PM -0800, ashish mittal wrote: >> On Mon, Feb 27, 2017 at 1:22 AM, Daniel P. Berrange >> wrote: > >> >> +ret = -EINVAL; >> >> +goto out; >> >> +

Re: [Qemu-devel] [PATCH v8 1/2] block/vxhs.c: Add support for a new block device type called "vxhs"

On Tue, Feb 28, 2017 at 02:51:39PM -0800, ashish mittal wrote: > On Mon, Feb 27, 2017 at 1:22 AM, Daniel P. Berrange > wrote: > >> +ret = -EINVAL; > >> +goto out; > >> +} > >> + > >> +secretid = qemu_opt_get(opts, VXHS_OPT_SECRETID); > >> +if

Re: [Qemu-devel] [PATCH v8 1/2] block/vxhs.c: Add support for a new block device type called "vxhs"

On Mon, Feb 27, 2017 at 1:22 AM, Daniel P. Berrange wrote: > On Fri, Feb 24, 2017 at 03:30:21PM -0800, ashish mittal wrote: >> Thanks! >> >> I hope the following is in line with what you suggested - > > Yes, that looks suitable for password auth > Thanks! >> >> We will error

Re: [Qemu-devel] [PATCH v8 1/2] block/vxhs.c: Add support for a new block device type called "vxhs"

On Fri, Feb 24, 2017 at 03:30:21PM -0800, ashish mittal wrote: > Thanks! > > I hope the following is in line with what you suggested - Yes, that looks suitable for password auth > > We will error out in case either of username, secret-id, or password > are missing. > > Good case, passing

Re: [Qemu-devel] [PATCH v8 1/2] block/vxhs.c: Add support for a new block device type called "vxhs"

Thanks! I hope the following is in line with what you suggested - We will error out in case either of username, secret-id, or password are missing. Good case, passing password via a file - $ ./qemu-io --trace enable=vxhs* --object secret,id=xvxhspasswd,file=/tmp/some/file/path -c 'read 66000

Re: [Qemu-devel] [PATCH v8 1/2] block/vxhs.c: Add support for a new block device type called "vxhs"

On Thu, Feb 23, 2017 at 08:19:29PM -0800, ashish mittal wrote: > Hi, > > Just want to check if the following mechanism for accepting the secret > password looks OK? > > We have yet to internally discuss the semantics of how we plan to use > the user-ID/password for authentication. This diff is

Re: [Qemu-devel] [PATCH v8 1/2] block/vxhs.c: Add support for a new block device type called "vxhs"

Hi, Just want to check if the following mechanism for accepting the secret password looks OK? We have yet to internally discuss the semantics of how we plan to use the user-ID/password for authentication. This diff is just to understand how I am expected to accept the secret from the command

Re: [Qemu-devel] [PATCH v8 1/2] block/vxhs.c: Add support for a new block device type called "vxhs"

On Wed, Feb 22, 2017 at 02:22:30PM +, Daniel P. Berrange wrote: > On Wed, Feb 22, 2017 at 02:09:20PM +, Stefan Hajnoczi wrote: > > On Tue, Feb 21, 2017 at 11:33:53AM +, Daniel P. Berrange wrote: > > > On Tue, Feb 21, 2017 at 10:59:18AM +, Stefan Hajnoczi wrote: > > > > On Mon, Feb

Re: [Qemu-devel] [PATCH v8 1/2] block/vxhs.c: Add support for a new block device type called "vxhs"

On Tue, Feb 21, 2017 at 05:21:46PM +, Ketan Nilangekar wrote: > > > On 2/21/17, 5:59 AM, "Stefan Hajnoczi" wrote: > > On Mon, Feb 20, 2017 at 03:34:57AM -0800, ashish mittal wrote: > > On Mon, Feb 20, 2017 at 3:02 AM, Stefan Hajnoczi >

Re: [Qemu-devel] [PATCH v8 1/2] block/vxhs.c: Add support for a new block device type called "vxhs"

On Wed, Feb 22, 2017 at 02:09:20PM +, Stefan Hajnoczi wrote: > On Tue, Feb 21, 2017 at 11:33:53AM +, Daniel P. Berrange wrote: > > On Tue, Feb 21, 2017 at 10:59:18AM +, Stefan Hajnoczi wrote: > > > On Mon, Feb 20, 2017 at 03:34:57AM -0800, ashish mittal wrote: > > > > On Mon, Feb 20,

Re: [Qemu-devel] [PATCH v8 1/2] block/vxhs.c: Add support for a new block device type called "vxhs"

On Tue, Feb 21, 2017 at 11:33:53AM +, Daniel P. Berrange wrote: > On Tue, Feb 21, 2017 at 10:59:18AM +, Stefan Hajnoczi wrote: > > On Mon, Feb 20, 2017 at 03:34:57AM -0800, ashish mittal wrote: > > > On Mon, Feb 20, 2017 at 3:02 AM, Stefan Hajnoczi > > > wrote: > > >

Re: [Qemu-devel] [PATCH v8 1/2] block/vxhs.c: Add support for a new block device type called "vxhs"

On Tue, Feb 21, 2017 at 02:25:53PM -0500, Jeff Cody wrote: > On Tue, Feb 21, 2017 at 06:56:24PM +, Daniel P. Berrange wrote: > > On Tue, Feb 21, 2017 at 01:06:58PM -0500, Jeff Cody wrote: > > > On Tue, Feb 21, 2017 at 05:39:12PM +, Daniel P. Berrange wrote: > > > > On Tue, Feb 21, 2017 at

Re: [Qemu-devel] [PATCH v8 1/2] block/vxhs.c: Add support for a new block device type called "vxhs"

On Tue, Feb 21, 2017 at 06:56:24PM +, Daniel P. Berrange wrote: > On Tue, Feb 21, 2017 at 01:06:58PM -0500, Jeff Cody wrote: > > On Tue, Feb 21, 2017 at 05:39:12PM +, Daniel P. Berrange wrote: > > > On Tue, Feb 21, 2017 at 05:21:46PM +, Ketan Nilangekar wrote: > > > > > > > > > > > >

Re: [Qemu-devel] [PATCH v8 1/2] block/vxhs.c: Add support for a new block device type called "vxhs"

On Tue, Feb 21, 2017 at 01:06:58PM -0500, Jeff Cody wrote: > On Tue, Feb 21, 2017 at 05:39:12PM +, Daniel P. Berrange wrote: > > On Tue, Feb 21, 2017 at 05:21:46PM +, Ketan Nilangekar wrote: > > > > > > > > > On 2/21/17, 5:59 AM, "Stefan Hajnoczi" wrote: > > > > > >

Re: [Qemu-devel] [PATCH v8 1/2] block/vxhs.c: Add support for a new block device type called "vxhs"

On 2/21/17, 5:59 AM, "Stefan Hajnoczi" wrote: On Mon, Feb 20, 2017 at 03:34:57AM -0800, ashish mittal wrote: > On Mon, Feb 20, 2017 at 3:02 AM, Stefan Hajnoczi wrote: > > On Sat, Feb 18, 2017 at 12:30:31AM +, Ketan Nilangekar wrote:

Re: [Qemu-devel] [PATCH v8 1/2] block/vxhs.c: Add support for a new block device type called "vxhs"

On Tue, Feb 21, 2017 at 05:39:12PM +, Daniel P. Berrange wrote: > On Tue, Feb 21, 2017 at 05:21:46PM +, Ketan Nilangekar wrote: > > > > > > On 2/21/17, 5:59 AM, "Stefan Hajnoczi" wrote: > > > > On Mon, Feb 20, 2017 at 03:34:57AM -0800, ashish mittal wrote: > >

Re: [Qemu-devel] [PATCH v8 1/2] block/vxhs.c: Add support for a new block device type called "vxhs"

On Tue, Feb 21, 2017 at 05:21:46PM +, Ketan Nilangekar wrote: > > > On 2/21/17, 5:59 AM, "Stefan Hajnoczi" wrote: > > On Mon, Feb 20, 2017 at 03:34:57AM -0800, ashish mittal wrote: > > On Mon, Feb 20, 2017 at 3:02 AM, Stefan Hajnoczi >

Re: [Qemu-devel] [PATCH v8 1/2] block/vxhs.c: Add support for a new block device type called "vxhs"

On Tue, Feb 21, 2017 at 10:59:18AM +, Stefan Hajnoczi wrote: > On Mon, Feb 20, 2017 at 03:34:57AM -0800, ashish mittal wrote: > > On Mon, Feb 20, 2017 at 3:02 AM, Stefan Hajnoczi wrote: > > > On Sat, Feb 18, 2017 at 12:30:31AM +, Ketan Nilangekar wrote: > > >> On

Re: [Qemu-devel] [PATCH v8 1/2] block/vxhs.c: Add support for a new block device type called "vxhs"

On Mon, Feb 20, 2017 at 03:34:57AM -0800, ashish mittal wrote: > On Mon, Feb 20, 2017 at 3:02 AM, Stefan Hajnoczi wrote: > > On Sat, Feb 18, 2017 at 12:30:31AM +, Ketan Nilangekar wrote: > >> On 2/17/17, 1:42 PM, "Jeff Cody" wrote: > >> > >> On Thu,

Re: [Qemu-devel] [PATCH v8 1/2] block/vxhs.c: Add support for a new block device type called "vxhs"

On Mon, Feb 20, 2017 at 3:02 AM, Stefan Hajnoczi wrote: > On Sat, Feb 18, 2017 at 12:30:31AM +, Ketan Nilangekar wrote: >> On 2/17/17, 1:42 PM, "Jeff Cody" wrote: >> >> On Thu, Feb 16, 2017 at 02:24:19PM -0800, ashish mittal wrote: >> > Hi, >>

Re: [Qemu-devel] [PATCH v8 1/2] block/vxhs.c: Add support for a new block device type called "vxhs"

On Sat, Feb 18, 2017 at 12:30:31AM +, Ketan Nilangekar wrote: > On 2/17/17, 1:42 PM, "Jeff Cody" wrote: > > On Thu, Feb 16, 2017 at 02:24:19PM -0800, ashish mittal wrote: > > Hi, > > > > I am getting the following error with checkpatch.pl > > > >

Re: [Qemu-devel] [PATCH v8 1/2] block/vxhs.c: Add support for a new block device type called "vxhs"

On Sat, Feb 18, 2017 at 12:30:31AM +, Ketan Nilangekar wrote: > On 2/17/17, 1:42 PM, "Jeff Cody" wrote: > > On Thu, Feb 16, 2017 at 02:24:19PM -0800, ashish mittal wrote: > > Hi, > > > > I am getting the following error with checkpatch.pl > > > >

Re: [Qemu-devel] [PATCH v8 1/2] block/vxhs.c: Add support for a new block device type called "vxhs"

On Fri, Feb 17, 2017 at 04:42:15PM -0500, Jeff Cody wrote: > On Thu, Feb 16, 2017 at 02:24:19PM -0800, ashish mittal wrote: > > Hi, > > > > I am getting the following error with checkpatch.pl > > > > ERROR: externs should be avoided in .c files > > #78: FILE: block/vxhs.c:28: > > +QemuUUID

Re: [Qemu-devel] [PATCH v8 1/2] block/vxhs.c: Add support for a new block device type called "vxhs"

On 2/17/17, 1:42 PM, "Jeff Cody" wrote: On Thu, Feb 16, 2017 at 02:24:19PM -0800, ashish mittal wrote: > Hi, > > I am getting the following error with checkpatch.pl > > ERROR: externs should be avoided in .c files > #78: FILE: block/vxhs.c:28:

Re: [Qemu-devel] [PATCH v8 1/2] block/vxhs.c: Add support for a new block device type called "vxhs"

On Thu, Feb 16, 2017 at 02:24:19PM -0800, ashish mittal wrote: > Hi, > > I am getting the following error with checkpatch.pl > > ERROR: externs should be avoided in .c files > #78: FILE: block/vxhs.c:28: > +QemuUUID qemu_uuid __attribute__ ((weak)); > > Is there any way to get around this, or

Re: [Qemu-devel] [PATCH v8 1/2] block/vxhs.c: Add support for a new block device type called "vxhs"

Hi, I am getting the following error with checkpatch.pl ERROR: externs should be avoided in .c files #78: FILE: block/vxhs.c:28: +QemuUUID qemu_uuid __attribute__ ((weak)); Is there any way to get around this, or does it mean that I would have to add a vxhs.h just for this one entry? Thanks,

Re: [Qemu-devel] [PATCH v8 1/2] block/vxhs.c: Add support for a new block device type called "vxhs"

On Tue, Feb 14, 2017 at 12:51 PM, Jeff Cody wrote: > On Thu, Feb 09, 2017 at 01:24:58AM -0800, ashish mittal wrote: >> On Wed, Feb 8, 2017 at 10:29 PM, Jeff Cody wrote: >> > On Wed, Feb 08, 2017 at 09:23:33PM -0800, Ashish Mittal wrote: >> >> From: Ashish

Re: [Qemu-devel] [PATCH v8 1/2] block/vxhs.c: Add support for a new block device type called "vxhs"

On Thu, Feb 09, 2017 at 01:24:58AM -0800, ashish mittal wrote: > On Wed, Feb 8, 2017 at 10:29 PM, Jeff Cody wrote: > > On Wed, Feb 08, 2017 at 09:23:33PM -0800, Ashish Mittal wrote: > >> From: Ashish Mittal > >> > >> Source code for the qnio library

Re: [Qemu-devel] [PATCH v8 1/2] block/vxhs.c: Add support for a new block device type called "vxhs"

On Thu, Feb 09, 2017 at 04:27:07PM -0800, ashish mittal wrote: > On Thu, Feb 9, 2017 at 10:45 AM, ashish mittal wrote: > > On Thu, Feb 9, 2017 at 10:08 AM, ashish mittal wrote: > >> On Thu, Feb 9, 2017 at 8:50 AM, Jeff Cody wrote: >

Re: [Qemu-devel] [PATCH v8 1/2] block/vxhs.c: Add support for a new block device type called "vxhs"

On Thu, Feb 9, 2017 at 10:45 AM, ashish mittal wrote: > On Thu, Feb 9, 2017 at 10:08 AM, ashish mittal wrote: >> On Thu, Feb 9, 2017 at 8:50 AM, Jeff Cody wrote: >>> On Thu, Feb 09, 2017 at 08:14:38AM -0800, ashish mittal wrote:

Re: [Qemu-devel] [PATCH v8 1/2] block/vxhs.c: Add support for a new block device type called "vxhs"

On Thu, Feb 9, 2017 at 10:08 AM, ashish mittal wrote: > On Thu, Feb 9, 2017 at 8:50 AM, Jeff Cody wrote: >> On Thu, Feb 09, 2017 at 08:14:38AM -0800, ashish mittal wrote: >>> On Thu, Feb 9, 2017 at 6:32 AM, Jeff Cody wrote: >>> > On Thu,

Re: [Qemu-devel] [PATCH v8 1/2] block/vxhs.c: Add support for a new block device type called "vxhs"

On Thu, Feb 9, 2017 at 8:50 AM, Jeff Cody wrote: > On Thu, Feb 09, 2017 at 08:14:38AM -0800, ashish mittal wrote: >> On Thu, Feb 9, 2017 at 6:32 AM, Jeff Cody wrote: >> > On Thu, Feb 09, 2017 at 01:24:58AM -0800, ashish mittal wrote: >> >> On Wed, Feb 8, 2017

Re: [Qemu-devel] [PATCH v8 1/2] block/vxhs.c: Add support for a new block device type called "vxhs"

On Thu, Feb 09, 2017 at 08:14:38AM -0800, ashish mittal wrote: > On Thu, Feb 9, 2017 at 6:32 AM, Jeff Cody wrote: > > On Thu, Feb 09, 2017 at 01:24:58AM -0800, ashish mittal wrote: > >> On Wed, Feb 8, 2017 at 10:29 PM, Jeff Cody wrote: > >> > On Wed, Feb 08,

Re: [Qemu-devel] [PATCH v8 1/2] block/vxhs.c: Add support for a new block device type called "vxhs"

On Thu, Feb 9, 2017 at 6:32 AM, Jeff Cody wrote: > On Thu, Feb 09, 2017 at 01:24:58AM -0800, ashish mittal wrote: >> On Wed, Feb 8, 2017 at 10:29 PM, Jeff Cody wrote: >> > On Wed, Feb 08, 2017 at 09:23:33PM -0800, Ashish Mittal wrote: >> >> From: Ashish Mittal

Re: [Qemu-devel] [PATCH v8 1/2] block/vxhs.c: Add support for a new block device type called "vxhs"

On Thu, Feb 09, 2017 at 01:24:58AM -0800, ashish mittal wrote: > On Wed, Feb 8, 2017 at 10:29 PM, Jeff Cody wrote: > > On Wed, Feb 08, 2017 at 09:23:33PM -0800, Ashish Mittal wrote: > >> From: Ashish Mittal > >> > >> Source code for the qnio library

Re: [Qemu-devel] [PATCH v8 1/2] block/vxhs.c: Add support for a new block device type called "vxhs"

On Wed, Feb 8, 2017 at 10:29 PM, Jeff Cody wrote: > On Wed, Feb 08, 2017 at 09:23:33PM -0800, Ashish Mittal wrote: >> From: Ashish Mittal >> >> Source code for the qnio library that this code loads can be downloaded from: >>

Re: [Qemu-devel] [PATCH v8 1/2] block/vxhs.c: Add support for a new block device type called "vxhs"

On Wed, Feb 08, 2017 at 09:23:33PM -0800, Ashish Mittal wrote: > From: Ashish Mittal > > Source code for the qnio library that this code loads can be downloaded from: > https://github.com/VeritasHyperScale/libqnio.git > > Sample command line using JSON syntax: >

[Qemu-devel] [PATCH v8 1/2] block/vxhs.c: Add support for a new block device type called "vxhs"

From: Ashish Mittal Source code for the qnio library that this code loads can be downloaded from: https://github.com/VeritasHyperScale/libqnio.git Sample command line using JSON syntax: ./x86_64-softmmu/qemu-system-x86_64 -name instance-0008 -S -vnc 0.0.0.0:0 -k