Re: [PATCH] hw/watchdog/wdt_diag288: Remove unnecessary includes

2020-11-24 Thread Cornelia Huck
On Mon, 23 Nov 2020 19:41:40 +0100 Thomas Huth wrote: > On 23/11/2020 16.59, Cornelia Huck wrote: > > On Mon, 23 Nov 2020 11:47:25 +0100 > > Markus Armbruster wrote: > > > >> Thomas Huth writes: > >> > >>> On 18/11/2020 15.30, Peter Maydell wrote: > On Wed, 18 Nov 2020 at 14:24,

Re: [PATCH] hw/watchdog/wdt_diag288: Remove unnecessary includes

2020-11-24 Thread Cornelia Huck
On Wed, 18 Nov 2020 10:03:44 +0100 Thomas Huth wrote: > Both headers, sysbus.h and module.h, are not required to compile this file. > > Signed-off-by: Thomas Huth > --- > hw/watchdog/wdt_diag288.c | 2 -- > 1 file changed, 2 deletions(-) > > diff --git a/hw/watchdog/wdt_diag288.c

Re: [PATCH] hw/watchdog/wdt_diag288: Remove unnecessary includes

2020-11-23 Thread Thomas Huth
On 23/11/2020 16.59, Cornelia Huck wrote: > On Mon, 23 Nov 2020 11:47:25 +0100 > Markus Armbruster wrote: > >> Thomas Huth writes: >> >>> On 18/11/2020 15.30, Peter Maydell wrote: On Wed, 18 Nov 2020 at 14:24, Markus Armbruster wrote: > > Philippe Mathieu-Daudé writes:

Re: [PATCH] hw/watchdog/wdt_diag288: Remove unnecessary includes

2020-11-23 Thread Cornelia Huck
On Mon, 23 Nov 2020 11:47:25 +0100 Markus Armbruster wrote: > Thomas Huth writes: > > > On 18/11/2020 15.30, Peter Maydell wrote: > >> On Wed, 18 Nov 2020 at 14:24, Markus Armbruster wrote: > >> > >>> > >>> Philippe Mathieu-Daudé writes: > >>> > On 11/18/20 10:03 AM, Thomas Huth

Re: [PATCH] hw/watchdog/wdt_diag288: Remove unnecessary includes

2020-11-23 Thread Markus Armbruster
Thomas Huth writes: > On 18/11/2020 15.30, Peter Maydell wrote: >> On Wed, 18 Nov 2020 at 14:24, Markus Armbruster wrote: >>> >>> Philippe Mathieu-Daudé writes: >>> On 11/18/20 10:03 AM, Thomas Huth wrote: > Both headers, sysbus.h and module.h, are not required to compile this >

Re: [PATCH] hw/watchdog/wdt_diag288: Remove unnecessary includes

2020-11-23 Thread Thomas Huth
On 18/11/2020 15.30, Peter Maydell wrote: > On Wed, 18 Nov 2020 at 14:24, Markus Armbruster wrote: >> >> Philippe Mathieu-Daudé writes: >> >>> On 11/18/20 10:03 AM, Thomas Huth wrote: Both headers, sysbus.h and module.h, are not required to compile this file. >> >> module.h is: it defines

Re: [PATCH] hw/watchdog/wdt_diag288: Remove unnecessary includes

2020-11-18 Thread Peter Maydell
On Wed, 18 Nov 2020 at 14:24, Markus Armbruster wrote: > > Philippe Mathieu-Daudé writes: > > > On 11/18/20 10:03 AM, Thomas Huth wrote: > >> Both headers, sysbus.h and module.h, are not required to compile this file. > > module.h is: it defines type_init(). > >> #include "qemu/timer.h" > >>

Re: [PATCH] hw/watchdog/wdt_diag288: Remove unnecessary includes

2020-11-18 Thread Markus Armbruster
Philippe Mathieu-Daudé writes: > On 11/18/20 10:03 AM, Thomas Huth wrote: >> Both headers, sysbus.h and module.h, are not required to compile this file. module.h is: it defines type_init(). >> >> Signed-off-by: Thomas Huth >> --- >> hw/watchdog/wdt_diag288.c | 2 -- >> 1 file changed, 2

Re: [PATCH] hw/watchdog/wdt_diag288: Remove unnecessary includes

2020-11-18 Thread Philippe Mathieu-Daudé
On 11/18/20 10:03 AM, Thomas Huth wrote: > Both headers, sysbus.h and module.h, are not required to compile this file. > > Signed-off-by: Thomas Huth > --- > hw/watchdog/wdt_diag288.c | 2 -- > 1 file changed, 2 deletions(-) > > diff --git a/hw/watchdog/wdt_diag288.c

Re: [PATCH] hw/watchdog/wdt_diag288: Remove unnecessary includes

2020-11-18 Thread Christian Borntraeger
On 18.11.20 10:03, Thomas Huth wrote: > Both headers, sysbus.h and module.h, are not required to compile this file. > > Signed-off-by: Thomas Huth It is not a sysbus device and not a module. Reviewed-by: Christian Borntraeger > --- > hw/watchdog/wdt_diag288.c | 2 -- > 1 file changed, 2

[PATCH] hw/watchdog/wdt_diag288: Remove unnecessary includes

2020-11-18 Thread Thomas Huth
Both headers, sysbus.h and module.h, are not required to compile this file. Signed-off-by: Thomas Huth --- hw/watchdog/wdt_diag288.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/hw/watchdog/wdt_diag288.c b/hw/watchdog/wdt_diag288.c index 71a945f0bd..4c4b6a6ab7 100644 ---