Re: [PATCH] pc: add property for Linux setup_data seed

2022-08-04 Thread Paolo Bonzini
On 8/4/22 16:31, Jason A. Donenfeld wrote: I'm still not really keen on adding a knob for this. I understand ARM has a knob for it for different reasons (better named "dtb-randomness"). If this knob thing is to live on here, maybe it should have "-randomness" in the name also. Ok, I just reused

Re: [PATCH] pc: add property for Linux setup_data seed

2022-08-04 Thread Michael S. Tsirkin
On Thu, Aug 04, 2022 at 04:31:06PM +0200, Jason A. Donenfeld wrote: > Hi Daniel, > > On Thu, Aug 04, 2022 at 02:31:06PM +0100, Daniel P. Berrangé wrote: > > On Thu, Aug 04, 2022 at 03:20:59PM +0200, Jason A. Donenfeld wrote: > > > On Thu, Aug 04, 2022 at 03:13:20PM +0200, Paolo Bonzini wrote: > >

Re: [PATCH] pc: add property for Linux setup_data seed

2022-08-04 Thread Jason A. Donenfeld
Hi Daniel, On Thu, Aug 04, 2022 at 02:31:06PM +0100, Daniel P. Berrangé wrote: > On Thu, Aug 04, 2022 at 03:20:59PM +0200, Jason A. Donenfeld wrote: > > On Thu, Aug 04, 2022 at 03:13:20PM +0200, Paolo Bonzini wrote: > > > Using a property makes it possible to use the normal compat property > > > m

Re: [PATCH] pc: add property for Linux setup_data seed

2022-08-04 Thread Daniel P . Berrangé
On Thu, Aug 04, 2022 at 03:20:59PM +0200, Jason A. Donenfeld wrote: > On Thu, Aug 04, 2022 at 03:13:20PM +0200, Paolo Bonzini wrote: > > Using a property makes it possible to use the normal compat property > > mechanism instead of ad hoc code; it avoids parameter proliferation > > in x86_load_linux

Re: [PATCH] pc: add property for Linux setup_data seed

2022-08-04 Thread Jason A. Donenfeld
On Thu, Aug 04, 2022 at 03:13:20PM +0200, Paolo Bonzini wrote: > Using a property makes it possible to use the normal compat property > mechanism instead of ad hoc code; it avoids parameter proliferation > in x86_load_linux; and allows shipping the code even if it is > disabled by default. Strong

Re: [PATCH] pc: add property for Linux setup_data seed

2022-08-04 Thread Daniel P . Berrangé
On Thu, Aug 04, 2022 at 03:13:20PM +0200, Paolo Bonzini wrote: > Using a property makes it possible to use the normal compat property > mechanism instead of ad hoc code; it avoids parameter proliferation > in x86_load_linux; and allows shipping the code even if it is > disabled by default. > > Cc:

[PATCH] pc: add property for Linux setup_data seed

2022-08-04 Thread Paolo Bonzini
Using a property makes it possible to use the normal compat property mechanism instead of ad hoc code; it avoids parameter proliferation in x86_load_linux; and allows shipping the code even if it is disabled by default. Cc: Jason A. Donenfeld Cc: Michael S. Tsirkin Signed-off-by: Paolo Bonzini