Re: [PATCH 1/2] bsd-user: Only process meson rules on BSD host

2021-10-06 Thread Laurent Vivier
Le 05/10/2021 à 22:46, Warner Losh a écrit : > > > On Tue, Oct 5, 2021 at 2:41 PM Laurent Vivier > wrote: > > Le 05/10/2021 à 21:26, Paolo Bonzini a écrit : > > On 27/09/21 11:52, Daniel P. Berrangé wrote: > >>    bsd_user_ss.add(files('gdbstub.c')) >

Re: [PATCH 1/2] bsd-user: Only process meson rules on BSD host

2021-10-05 Thread Warner Losh
On Tue, Oct 5, 2021 at 2:41 PM Laurent Vivier wrote: > Le 05/10/2021 à 21:26, Paolo Bonzini a écrit : > > On 27/09/21 11:52, Daniel P. Berrangé wrote: > >>bsd_user_ss.add(files('gdbstub.c')) > >>specific_ss.add_all(when: 'CONFIG_BSD_USER', if_true: bsd_user_ss) > >> > >> > >> So without

Re: [PATCH 1/2] bsd-user: Only process meson rules on BSD host

2021-10-05 Thread Laurent Vivier
Le 05/10/2021 à 21:26, Paolo Bonzini a écrit : > On 27/09/21 11:52, Daniel P. Berrangé wrote: >>    bsd_user_ss.add(files('gdbstub.c')) >>    specific_ss.add_all(when: 'CONFIG_BSD_USER', if_true: bsd_user_ss) >> >> >> So without this change, we're already correctly dropping bsd_user_ss >> in its

Re: [PATCH 1/2] bsd-user: Only process meson rules on BSD host

2021-10-05 Thread Paolo Bonzini
On 27/09/21 11:52, Daniel P. Berrangé wrote: bsd_user_ss.add(files('gdbstub.c')) specific_ss.add_all(when: 'CONFIG_BSD_USER', if_true: bsd_user_ss) So without this change, we're already correctly dropping bsd_user_ss in its entirity, when not on BSD. With this change, we're dropping

Re: [PATCH 1/2] bsd-user: Only process meson rules on BSD host

2021-10-05 Thread Paolo Bonzini
On 27/09/21 11:54, Peter Maydell wrote: True, but "meson.build is evaluated but just does nothing or adds files to a sourceset that isn't used" is pretty common (hw/pci/meson.build is evaluated even if we're not building a system with PCI support, for example). Selection of files from

Re: [PATCH 1/2] bsd-user: Only process meson rules on BSD host

2021-10-05 Thread Paolo Bonzini
On 27/09/21 07:24, Philippe Mathieu-Daudé wrote: Why here and not in the parent meson.build? This is what Paolo recommended me to do last time I added a conditional inclusion. Personally I prefer having it in the call site rather than the callee (no need to read the callee to notice it isn't

Re: [PATCH 1/2] bsd-user: Only process meson rules on BSD host

2021-10-05 Thread Alex Bennée
Philippe Mathieu-Daudé writes: > On Mon, Sep 27, 2021 at 11:15 AM Peter Maydell > wrote: >> On Sun, 26 Sept 2021 at 23:04, Philippe Mathieu-Daudé >> wrote: >> > Reported-by: Warner Losh >> > Signed-off-by: Philippe Mathieu-Daudé >> > --- >> > bsd-user/meson.build | 4 >> > 1 file

Re: [PATCH 1/2] bsd-user: Only process meson rules on BSD host

2021-09-27 Thread Warner Losh
On Mon, Sep 27, 2021 at 4:08 AM Peter Maydell wrote: > On Mon, 27 Sept 2021 at 10:59, Daniel P. Berrangé > wrote: > > If we look at linux-user/meson.build though things are more complex. > > There we have alot of sub-dirs, and meson.biuld in those dirs adds > > generators for various files. So

Re: [PATCH 1/2] bsd-user: Only process meson rules on BSD host

2021-09-27 Thread Peter Maydell
On Mon, 27 Sept 2021 at 10:59, Daniel P. Berrangé wrote: > If we look at linux-user/meson.build though things are more complex. > There we have alot of sub-dirs, and meson.biuld in those dirs adds > generators for various files. So conceivably skipping linux-user > will mean we won't

Re: [PATCH 1/2] bsd-user: Only process meson rules on BSD host

2021-09-27 Thread Daniel P . Berrangé
On Mon, Sep 27, 2021 at 12:01:02AM +0200, Philippe Mathieu-Daudé wrote: > Reported-by: Warner Losh > Signed-off-by: Philippe Mathieu-Daudé > --- > bsd-user/meson.build | 4 > 1 file changed, 4 insertions(+) > > diff --git a/bsd-user/meson.build b/bsd-user/meson.build > index

Re: [PATCH 1/2] bsd-user: Only process meson rules on BSD host

2021-09-27 Thread Peter Maydell
On Mon, 27 Sept 2021 at 10:40, Philippe Mathieu-Daudé wrote: > > On Mon, Sep 27, 2021 at 11:15 AM Peter Maydell > wrote: > > On Sun, 26 Sept 2021 at 23:04, Philippe Mathieu-Daudé > > wrote: > > > Reported-by: Warner Losh > > > Signed-off-by: Philippe Mathieu-Daudé > > > --- > > >

Re: [PATCH 1/2] bsd-user: Only process meson rules on BSD host

2021-09-27 Thread Philippe Mathieu-Daudé
On Mon, Sep 27, 2021 at 11:15 AM Peter Maydell wrote: > On Sun, 26 Sept 2021 at 23:04, Philippe Mathieu-Daudé wrote: > > Reported-by: Warner Losh > > Signed-off-by: Philippe Mathieu-Daudé > > --- > > bsd-user/meson.build | 4 > > 1 file changed, 4 insertions(+) > > > > diff --git

Re: [PATCH 1/2] bsd-user: Only process meson rules on BSD host

2021-09-27 Thread Peter Maydell
On Sun, 26 Sept 2021 at 23:04, Philippe Mathieu-Daudé wrote: > > Reported-by: Warner Losh > Signed-off-by: Philippe Mathieu-Daudé > --- > bsd-user/meson.build | 4 > 1 file changed, 4 insertions(+) > > diff --git a/bsd-user/meson.build b/bsd-user/meson.build > index

Re: [PATCH 1/2] bsd-user: Only process meson rules on BSD host

2021-09-26 Thread Philippe Mathieu-Daudé
On 9/27/21 01:08, Richard Henderson wrote: > On 9/26/21 6:01 PM, Philippe Mathieu-Daudé wrote: >> Reported-by: Warner Losh >> Signed-off-by: Philippe Mathieu-Daudé >> --- >>   bsd-user/meson.build | 4 >>   1 file changed, 4 insertions(+) >> >> diff --git a/bsd-user/meson.build

Re: [PATCH 1/2] bsd-user: Only process meson rules on BSD host

2021-09-26 Thread WANG Xuerui
On 9/27/21 10:42, WANG Xuerui wrote: On 9/27/21 06:01, Philippe Mathieu-Daudé wrote: Reported-by: Warner Losh Signed-off-by: Philippe Mathieu-Daudé ---   bsd-user/meson.build | 4   1 file changed, 4 insertions(+) I'm newcomer here, but this is just 4 lines of Meson, and two similar

Re: [PATCH 1/2] bsd-user: Only process meson rules on BSD host

2021-09-26 Thread WANG Xuerui
On 9/27/21 06:01, Philippe Mathieu-Daudé wrote: Reported-by: Warner Losh Signed-off-by: Philippe Mathieu-Daudé --- bsd-user/meson.build | 4 1 file changed, 4 insertions(+) I'm newcomer here, but this is just 4 lines of Meson, and two similar usages already exist within QEMU proper

Re: [PATCH 1/2] bsd-user: Only process meson rules on BSD host

2021-09-26 Thread Warner Losh
On Sun, Sep 26, 2021 at 5:08 PM Richard Henderson < richard.hender...@linaro.org> wrote: > On 9/26/21 6:01 PM, Philippe Mathieu-Daudé wrote: > > Reported-by: Warner Losh > > Signed-off-by: Philippe Mathieu-Daudé > > --- > > bsd-user/meson.build | 4 > > 1 file changed, 4 insertions(+) >

Re: [PATCH 1/2] bsd-user: Only process meson rules on BSD host

2021-09-26 Thread Richard Henderson
On 9/26/21 6:01 PM, Philippe Mathieu-Daudé wrote: Reported-by: Warner Losh Signed-off-by: Philippe Mathieu-Daudé --- bsd-user/meson.build | 4 1 file changed, 4 insertions(+) diff --git a/bsd-user/meson.build b/bsd-user/meson.build index 03695493408..a7607e1c884 100644 ---

[PATCH 1/2] bsd-user: Only process meson rules on BSD host

2021-09-26 Thread Philippe Mathieu-Daudé
Reported-by: Warner Losh Signed-off-by: Philippe Mathieu-Daudé --- bsd-user/meson.build | 4 1 file changed, 4 insertions(+) diff --git a/bsd-user/meson.build b/bsd-user/meson.build index 03695493408..a7607e1c884 100644 --- a/bsd-user/meson.build +++ b/bsd-user/meson.build @@ -1,3 +1,7 @@