Re: [PATCH 1/5] configure: remove --with-git= option

2023-05-30 Thread Daniel P . Berrangé
On Sat, May 27, 2023 at 11:28:47AM +0200, Paolo Bonzini wrote: > There is not really any scenario where one would use any other git > binary than "the first git in the PATH" aka $(command -v git). In > fact for example "meson subprojects download" or scripts/checkpatch.pl > do not obey the GIT

Re: [PATCH 1/5] configure: remove --with-git= option

2023-05-30 Thread Daniel P . Berrangé
On Tue, May 30, 2023 at 02:03:11PM +0200, Paolo Bonzini wrote: > On Tue, May 30, 2023 at 1:58 PM Thomas Huth wrote: > > The commit cc84d63a42e31c2a that introduce this switch gave a > > rationale: > > > > Some users can't run a bare 'git' command, due to need for a > > transparent > >

Re: [PATCH 1/5] configure: remove --with-git= option

2023-05-30 Thread Paolo Bonzini
On Tue, May 30, 2023 at 1:58 PM Thomas Huth wrote: > The commit cc84d63a42e31c2a that introduce this switch gave a > rationale: > > Some users can't run a bare 'git' command, due to need for a transparent > proxying solution such as 'tsocks'. This adds an argument to configure to >

Re: [PATCH 1/5] configure: remove --with-git= option

2023-05-30 Thread Thomas Huth
On 27/05/2023 11.28, Paolo Bonzini wrote: There is not really any scenario where one would use any other git binary than "the first git in the PATH" aka $(command -v git). In fact for example "meson subprojects download" or scripts/checkpatch.pl do not obey the GIT environment variable. Remove

[PATCH 1/5] configure: remove --with-git= option

2023-05-27 Thread Paolo Bonzini
There is not really any scenario where one would use any other git binary than "the first git in the PATH" aka $(command -v git). In fact for example "meson subprojects download" or scripts/checkpatch.pl do not obey the GIT environment variable. Remove the unnecessary knob, but test for the