Re: [PATCH v2 05/17] iotests/040: Fix TestCommitWithFilters test

2022-03-31 Thread John Snow
On Thu, Mar 24, 2022 at 9:33 PM Eric Blake wrote: > > On Thu, Mar 24, 2022 at 02:30:06PM -0400, John Snow wrote: > > Without this change, asserting that qemu_io always returns 0 causes this > > test to fail in a way we happened not to be catching previously: > > > >

Re: [PATCH v2 05/17] iotests/040: Fix TestCommitWithFilters test

2022-03-25 Thread John Snow
On Fri, Mar 25, 2022, 9:40 AM Hanna Reitz wrote: > On 24.03.22 19:30, John Snow wrote: > > Without this change, asserting that qemu_io always returns 0 causes this > > test to fail in a way we happened not to be catching previously: > > > > qemu.utils.VerboseProcessError: Command > >

Re: [PATCH v2 05/17] iotests/040: Fix TestCommitWithFilters test

2022-03-25 Thread Hanna Reitz
On 24.03.22 19:30, John Snow wrote: Without this change, asserting that qemu_io always returns 0 causes this test to fail in a way we happened not to be catching previously: qemu.utils.VerboseProcessError: Command '('/home/jsnow/src/qemu/bin/git/tests/qemu-iotests/../../qemu-io',

Re: [PATCH v2 05/17] iotests/040: Fix TestCommitWithFilters test

2022-03-24 Thread Eric Blake
On Thu, Mar 24, 2022 at 02:30:06PM -0400, John Snow wrote: > Without this change, asserting that qemu_io always returns 0 causes this > test to fail in a way we happened not to be catching previously: > > qemu.utils.VerboseProcessError: Command >

[PATCH v2 05/17] iotests/040: Fix TestCommitWithFilters test

2022-03-24 Thread John Snow
Without this change, asserting that qemu_io always returns 0 causes this test to fail in a way we happened not to be catching previously: qemu.utils.VerboseProcessError: Command '('/home/jsnow/src/qemu/bin/git/tests/qemu-iotests/../../qemu-io', '--cache', 'writeback', '--aio', 'threads',