Re: [PATCH v2 10/28] serial: add "base" property

2019-10-22 Thread Peter Maydell
On Tue, 22 Oct 2019 at 17:23, Marc-André Lureau wrote: > > Signed-off-by: Marc-André Lureau > --- > hw/char/serial.c | 3 +++ > include/hw/char/serial.h | 1 + > 2 files changed, 4 insertions(+) > > diff --git a/hw/char/serial.c b/hw/char/serial.c > index 0ae52ec60c..4748a2b023 100644 >

Re: [PATCH v2 10/28] serial: add "base" property

2019-10-22 Thread Peter Maydell
On Tue, 22 Oct 2019 at 17:42, Marc-André Lureau wrote: > > Hi > > On Tue, Oct 22, 2019 at 6:32 PM Peter Maydell > wrote: > > > > On Tue, 22 Oct 2019 at 17:23, Marc-André Lureau > > wrote: > > Devices shouldn't have properties to set their MMIO base > > address -- instead the memory-mapped

Re: [PATCH v2 10/28] serial: add "base" property

2019-10-22 Thread Marc-André Lureau
Hi On Tue, Oct 22, 2019 at 6:32 PM Peter Maydell wrote: > > On Tue, 22 Oct 2019 at 17:23, Marc-André Lureau > wrote: > > > > Signed-off-by: Marc-André Lureau > > --- > > hw/char/serial.c | 3 +++ > > include/hw/char/serial.h | 1 + > > 2 files changed, 4 insertions(+) > > > > diff

[PATCH v2 10/28] serial: add "base" property

2019-10-22 Thread Marc-André Lureau
Signed-off-by: Marc-André Lureau --- hw/char/serial.c | 3 +++ include/hw/char/serial.h | 1 + 2 files changed, 4 insertions(+) diff --git a/hw/char/serial.c b/hw/char/serial.c index 0ae52ec60c..4748a2b023 100644 --- a/hw/char/serial.c +++ b/hw/char/serial.c @@ -990,6 +990,7 @@