Re: [PATCH v3 15/16] qapi/expr.py: move related checks inside check_xxx functions

2021-03-25 Thread Markus Armbruster
John Snow writes: > On 2/25/21 10:28 AM, Markus Armbruster wrote: >> John Snow writes: >> >>> There's not a big obvious difference between the types of checks that >>> happen in the main function versus the kind that happen in the >>> functions. Now they're in one place for each of the main

Re: [PATCH v3 15/16] qapi/expr.py: move related checks inside check_xxx functions

2021-03-24 Thread John Snow
On 2/25/21 10:28 AM, Markus Armbruster wrote: John Snow writes: There's not a big obvious difference between the types of checks that happen in the main function versus the kind that happen in the functions. Now they're in one place for each of the main types. As part of the move, spell out

Re: [PATCH v3 15/16] qapi/expr.py: move related checks inside check_xxx functions

2021-02-25 Thread Markus Armbruster
John Snow writes: > There's not a big obvious difference between the types of checks that > happen in the main function versus the kind that happen in the > functions. Now they're in one place for each of the main types. > > As part of the move, spell out the required and optional keywords so >

[PATCH v3 15/16] qapi/expr.py: move related checks inside check_xxx functions

2021-02-22 Thread John Snow
There's not a big obvious difference between the types of checks that happen in the main function versus the kind that happen in the functions. Now they're in one place for each of the main types. As part of the move, spell out the required and optional keywords so they're obvious at a glance.