Re: [PATCH v7 11/48] nvme: refactor device realization

2020-04-15 Thread Klaus Birkelund Jensen
On Apr 15 09:55, Philippe Mathieu-Daudé wrote: > On 4/15/20 9:25 AM, Klaus Birkelund Jensen wrote: > > On Apr 15 09:14, Philippe Mathieu-Daudé wrote: > > > Hi Klaus, > > > > > > This patch is a pain to review... Could you split it? I'd use one trivial > > > patch for each function extracted from

Re: [PATCH v7 11/48] nvme: refactor device realization

2020-04-15 Thread Philippe Mathieu-Daudé
On 4/15/20 9:25 AM, Klaus Birkelund Jensen wrote: On Apr 15 09:14, Philippe Mathieu-Daudé wrote: Hi Klaus, This patch is a pain to review... Could you split it? I'd use one trivial patch for each function extracted from nvme_realize(). Understood, I will split it up! Thanks, that will

Re: [PATCH v7 11/48] nvme: refactor device realization

2020-04-15 Thread Klaus Birkelund Jensen
On Apr 15 09:14, Philippe Mathieu-Daudé wrote: > Hi Klaus, > > This patch is a pain to review... Could you split it? I'd use one trivial > patch for each function extracted from nvme_realize(). > Understood, I will split it up!

Re: [PATCH v7 11/48] nvme: refactor device realization

2020-04-15 Thread Philippe Mathieu-Daudé
Hi Klaus, On 4/15/20 7:51 AM, Klaus Jensen wrote: From: Klaus Jensen This patch splits up nvme_realize into multiple individual functions, each initializing a different subset of the device. Signed-off-by: Klaus Jensen Signed-off-by: Klaus Jensen Acked-by: Keith Busch ---

[PATCH v7 11/48] nvme: refactor device realization

2020-04-14 Thread Klaus Jensen
From: Klaus Jensen This patch splits up nvme_realize into multiple individual functions, each initializing a different subset of the device. Signed-off-by: Klaus Jensen Signed-off-by: Klaus Jensen Acked-by: Keith Busch --- hw/block/nvme.c | 178