Re: [Qemu-devel] [PATCH] eepro100: Fix memory leak and simplify code for VMStateDescription

2016-10-21 Thread Stefan Weil
Am 21.10.2016 um 10:06 schrieb Dr. David Alan Gilbert: The problem isn't the version of the contents of the section, it's the naming of the devices. I think you can work around it by adding aliases for the old names. Dave How should I add such aliases? Are there other devices with vmstate ali

Re: [Qemu-devel] [PATCH] eepro100: Fix memory leak and simplify code for VMStateDescription

2016-10-21 Thread Dr. David Alan Gilbert
* Jason Wang (jasow...@redhat.com) wrote: > > > On 2016年10月17日 17:01, Dr. David Alan Gilbert wrote: > > * Stefan Weil (s...@weilnetz.de) wrote: > > > On 10/14/16 10:25, Dr. David Alan Gilbert wrote: > > > > * Stefan Weil (s...@weilnetz.de) wrote: > > > > > Instead of allocating a VMStateDescripti

Re: [Qemu-devel] [PATCH] eepro100: Fix memory leak and simplify code for VMStateDescription

2016-10-20 Thread Jason Wang
On 2016年10月17日 17:01, Dr. David Alan Gilbert wrote: * Stefan Weil (s...@weilnetz.de) wrote: On 10/14/16 10:25, Dr. David Alan Gilbert wrote: * Stefan Weil (s...@weilnetz.de) wrote: Instead of allocating a VMStateDescription for each NIC instance, the code now uses a single constant VMStateDe

Re: [Qemu-devel] [PATCH] eepro100: Fix memory leak and simplify code for VMStateDescription

2016-10-17 Thread Dr. David Alan Gilbert
* Stefan Weil (s...@weilnetz.de) wrote: > On 10/14/16 10:25, Dr. David Alan Gilbert wrote: > > * Stefan Weil (s...@weilnetz.de) wrote: > > > Instead of allocating a VMStateDescription for each NIC instance, > > > the code now uses a single constant VMStateDescription for all > > > instances. That i

Re: [Qemu-devel] [PATCH] eepro100: Fix memory leak and simplify code for VMStateDescription

2016-10-14 Thread Stefan Weil
On 10/14/16 10:25, Dr. David Alan Gilbert wrote: * Stefan Weil (s...@weilnetz.de) wrote: Instead of allocating a VMStateDescription for each NIC instance, the code now uses a single constant VMStateDescription for all instances. That implies that the name field is always the same. Doesn't this

Re: [Qemu-devel] [PATCH] eepro100: Fix memory leak and simplify code for VMStateDescription

2016-10-14 Thread Dr. David Alan Gilbert
* Stefan Weil (s...@weilnetz.de) wrote: > Instead of allocating a VMStateDescription for each NIC instance, > the code now uses a single constant VMStateDescription for all > instances. That implies that the name field is always the same. Doesn't this break migration compatibility? You might be a

[Qemu-devel] [PATCH] eepro100: Fix memory leak and simplify code for VMStateDescription

2016-10-13 Thread Stefan Weil
Instead of allocating a VMStateDescription for each NIC instance, the code now uses a single constant VMStateDescription for all instances. That implies that the name field is always the same. Reported-by: Li Qiang Signed-off-by: Stefan Weil --- hw/net/eepro100.c | 13 +++-- 1 file chan