Re: [Qemu-devel] [PATCH] pseries: Add H_SET_MODE hcall to change guest exception endianness

2013-08-28 Thread Alexander Graf
On 19.08.2013, at 13:04, Anton Blanchard wrote: Hi Anthony, +if (resource == 4) { This ought to be a #define. There's no else here, is that expected? Should you return failure for a different resource? Good point, I made it a define. We were returning H_P2 for a different

[Qemu-devel] [PATCH] pseries: Add H_SET_MODE hcall to change guest exception endianness

2013-08-19 Thread Anton Blanchard
Hi Anthony, +if (resource == 4) { This ought to be a #define. There's no else here, is that expected? Should you return failure for a different resource? Good point, I made it a define. We were returning H_P2 for a different resource, but it was a bit of a twisted maze of return