On 24 January 2011 12:41, Christophe Lyon christophe.l...@st.com wrote:
Here is an updated patch with these minor fixes.
+uint64_t HELPER(neon_qadd_u64)(CPUState *env, uint64_t src1, uint64_t src2)
+{
+ uint64_t res;
+
+ res = src1 + src2;
+ if (res src1) {
+ SET_QC();
+ res =
On 24.01.2011 13:41, Christophe Lyon wrote:
Here is an updated patch with these minor fixes.
ping?
On 21.01.2011 18:58, Peter Maydell wrote:
I've reviewed this patch and tested it in the usual way
and can confirm that it now sets the right saturation bit;
mostly it is OK. However...
Thanks!
[...]
the indentation in this hunk is wrong -- qemu standard is four-space.
Oops. What is the
On 24 January 2011 12:41, Christophe Lyon christophe.l...@st.com wrote:
On 21.01.2011 18:58, Peter Maydell wrote:
the indentation in this hunk is wrong -- qemu standard is four-space.
Oops. What is the official emacs configuration to get the right qemu style?
I don't know about official, but
On 20 January 2011 17:16, Christophe Lyon christophe.l...@st.com wrote:
Set the right overflow bit for neon 32 and 64 bit saturating add/sub.
Also move the neon 64 bit saturating add/sub helpers to neon_helper.c
for consistency with the 32 bits versions.
There is probably still room for code
Set the right overflow bit for neon 32 and 64 bit saturating add/sub.
Also move the neon 64 bit saturating add/sub helpers to neon_helper.c
for consistency with the 32 bits versions.
There is probably still room for code commonalization though.
Peter, this patch is based upon your patch 6f83e7d
On 20 January 2011 17:16, Christophe Lyon christophe.l...@st.com wrote:
Set the right overflow bit for neon 32 and 64 bit saturating add/sub.
Also move the neon 64 bit saturating add/sub helpers to neon_helper.c
for consistency with the 32 bits versions.
There is probably still room for code