[Qemu-devel] [PATCH] target-i386: n270 can MOVBE

2013-02-08 Thread Borislav Petkov
From: Borislav Petkov b...@suse.de The Atom core (cpu name n270 in QEMU speak) supports MOVBE. This is needed when booting 3.8 and later linux kernels built with the MATOM target because we require MOVBE in order to boot properly now. Cc: H. Peter Anvin h...@zytor.com Cc: Richard Henderson

Re: [Qemu-devel] [PATCH] target-i386: n270 can MOVBE

2013-02-08 Thread Andreas Färber
Hi, Am 08.02.2013 10:30, schrieb Borislav Petkov: From: Borislav Petkov b...@suse.de The Atom core (cpu name n270 in QEMU speak) supports MOVBE. This is needed when booting 3.8 and later linux kernels built with the MATOM target because we require MOVBE in order to boot properly now. Cc:

Re: [Qemu-devel] [PATCH] target-i386: n270 can MOVBE

2013-02-08 Thread Borislav Petkov
Hi Andreas, On Fri, Feb 08, 2013 at 12:38:03PM +0100, Andreas Färber wrote: Am 08.02.2013 10:30, schrieb Borislav Petkov: From: Borislav Petkov b...@suse.de The Atom core (cpu name n270 in QEMU speak) supports MOVBE. This is needed when booting 3.8 and later linux kernels built with the

Re: [Qemu-devel] [PATCH] target-i386: n270 can MOVBE

2013-02-08 Thread Andreas Färber
Hi, Am 08.02.2013 13:17, schrieb Borislav Petkov: On Fri, Feb 08, 2013 at 12:38:03PM +0100, Andreas Färber wrote: Am 08.02.2013 10:30, schrieb Borislav Petkov: .ext2_features = (PPRO_FEATURES CPUID_EXT2_AMD_ALIASES) | CPUID_EXT2_NX, .ext3_features =

Re: [Qemu-devel] [PATCH] target-i386: n270 can MOVBE

2013-02-08 Thread Paolo Bonzini
Il 08/02/2013 14:44, Andreas Färber ha scritto: Otherwise if someone can ack (or if you can point me to a manual), this looks like a good bugfix for v1.4. Right, I don't know what v1.4 is It's the QEMU release that we're about to make in a week. :-) http://wiki.qemu.org/Planning/1.4

Re: [Qemu-devel] [PATCH] target-i386: n270 can MOVBE

2013-02-08 Thread Eduardo Habkost
On Fri, Feb 08, 2013 at 02:59:25PM +0100, Paolo Bonzini wrote: Il 08/02/2013 14:44, Andreas Färber ha scritto: Otherwise if someone can ack (or if you can point me to a manual), this looks like a good bugfix for v1.4. Right, I don't know what v1.4 is It's the QEMU release that

Re: [Qemu-devel] [PATCH] target-i386: n270 can MOVBE

2013-02-08 Thread Eduardo Habkost
On Fri, Feb 08, 2013 at 10:30:02AM +0100, Borislav Petkov wrote: From: Borislav Petkov b...@suse.de The Atom core (cpu name n270 in QEMU speak) supports MOVBE. This is needed when booting 3.8 and later linux kernels built with the MATOM target because we require MOVBE in order to boot

Re: [Qemu-devel] [PATCH] target-i386: n270 can MOVBE

2013-02-08 Thread Paolo Bonzini
Il 08/02/2013 16:10, Eduardo Habkost ha scritto: On Fri, Feb 08, 2013 at 02:59:25PM +0100, Paolo Bonzini wrote: Il 08/02/2013 14:44, Andreas Färber ha scritto: Otherwise if someone can ack (or if you can point me to a manual), this looks like a good bugfix for v1.4. Right, I don't know what

Re: [Qemu-devel] [PATCH] target-i386: n270 can MOVBE

2013-02-08 Thread Borislav Petkov
On Fri, Feb 08, 2013 at 01:19:02PM -0200, Eduardo Habkost wrote: -machine pc-1.3 -cpu n270 (and older machine-types) needs to keep MOVBE disabled, or you will break live migration. Personally I wouldn't mind declaring n270 as a non-migratable CPU model. But libvirt supports n270, so it

Re: [Qemu-devel] [PATCH] target-i386: n270 can MOVBE

2013-02-08 Thread Eduardo Habkost
On Fri, Feb 08, 2013 at 04:34:58PM +0100, Borislav Petkov wrote: On Fri, Feb 08, 2013 at 01:19:02PM -0200, Eduardo Habkost wrote: -machine pc-1.3 -cpu n270 (and older machine-types) needs to keep MOVBE disabled, or you will break live migration. Personally I wouldn't mind declaring n270

Re: [Qemu-devel] [PATCH] target-i386: n270 can MOVBE

2013-02-08 Thread Richard Henderson
On 2013-02-08 03:38, Andreas Färber wrote: Otherwise if someone can ack (or if you can point me to a manual), this looks like a good bugfix for v1.4. CC'ing some more CPU'ish people. It wouldn't be a bug fix without extracting the patch out of my x86-next tree that actually implements movbe.

Re: [Qemu-devel] [PATCH] target-i386: n270 can MOVBE

2013-02-08 Thread H. Peter Anvin
This is problematic since the n270 qemu model won't boot a real kernel compiled for that box. Eduardo Habkost ehabk...@redhat.com wrote: On Fri, Feb 08, 2013 at 10:30:02AM +0100, Borislav Petkov wrote: From: Borislav Petkov b...@suse.de The Atom core (cpu name n270 in QEMU speak) supports

Re: [Qemu-devel] [PATCH] target-i386: n270 can MOVBE

2013-02-08 Thread Borislav Petkov
On Fri, Feb 08, 2013 at 01:58:58PM -0200, Eduardo Habkost wrote: [ … ] As we don't have a decent method to do that today, we are using static variables and compatibility-setup functions called from the machine init function. See disable_kvm_pv_eoi() for example. One day we will be able to

Re: [Qemu-devel] [PATCH] target-i386: n270 can MOVBE

2013-02-08 Thread Eduardo Habkost
On Fri, Feb 08, 2013 at 06:35:56PM +0100, Borislav Petkov wrote: On Fri, Feb 08, 2013 at 01:58:58PM -0200, Eduardo Habkost wrote: [ … ] As we don't have a decent method to do that today, we are using static variables and compatibility-setup functions called from the machine init

Re: [Qemu-devel] [PATCH] target-i386: n270 can MOVBE

2013-02-08 Thread Borislav Petkov
On Fri, Feb 08, 2013 at 04:23:04PM -0200, Eduardo Habkost wrote: If you don't have the implementation of MOVBE working (and included on TCG_EXT_FEATURES), neither your patch or +movbe can help you. Yes, running -cpu n270,+movbe with Richard's patchset merged works. Thanks. -- Regards/Gruss,