Here is the patch series implementing the idea I mentioned a while ago.
The first 14 introduce small changes to group pieces of code together
and help understanding/reviewing the next changes. Most of them are
just cosmetic changes, though some of them have small behavioral changes.
After these
On Tue, 12 Oct 2010, Paolo Bonzini wrote:
On 10/12/2010 03:22 PM, malc wrote:
19 files changed, 3729 insertions(+), 456 deletions(-)
I don't think the explanation above justified net plus of 3273 lines of new
code.
The part you forgot to quote is:
Yes, failed to notice that,
On Tue, 12 Oct 2010, Paolo Bonzini wrote:
Here is the patch series implementing the idea I mentioned a while ago.
The first 14 introduce small changes to group pieces of code together
and help understanding/reviewing the next changes. Most of them are
just cosmetic changes, though some of
On 10/12/2010 03:22 PM, malc wrote:
19 files changed, 3729 insertions(+), 456 deletions(-)
I don't think the explanation above justified net plus of 3273 lines of new
code.
The part you forgot to quote is:
Makefile | 54 +-
Makefile.dis |6 +-
On 10/12/2010 04:30 PM, Anthony Liguori wrote:
I think there's a fair bit of value in looking like autoconf but a 39
patch series is a bit to digest at once.
I'll try to do a thorough review but I'd suggest keeping patch series
down to about 20 patches whenever possible and do multiple rounds
On 10/12/2010 08:32 AM, malc wrote:
On Tue, 12 Oct 2010, Paolo Bonzini wrote:
On 10/12/2010 03:22 PM, malc wrote:
19 files changed, 3729 insertions(+), 456 deletions(-)
I don't think the explanation above justified net plus of 3273 lines of new
code.
The part
