Re: [Qemu-devel] [PATCH 06/14] exec.c: Make address_space_rw take transaction attributes

2015-04-09 Thread Edgar E. Iglesias
On Tue, Apr 07, 2015 at 09:09:52PM +0100, Peter Maydell wrote: Make address_space_rw take transaction attributes, rather than always using the 'unspecified' attributes. Reviewed-by: Edgar E. Iglesias edgar.igles...@xilinx.com I guess that we eventually will need to convert the dma_ functions?

Re: [Qemu-devel] [PATCH 06/14] exec.c: Make address_space_rw take transaction attributes

2015-04-09 Thread Paolo Bonzini
On 09/04/2015 12:43, Peter Maydell wrote: At this point, some memory barriers, basically. So what distinguishes a device that needs the memory barriers and does its accesses via dma_* from a device that doesn't and uses address_space_* or ld/st*_phys ? (Or for that matter a non-device

Re: [Qemu-devel] [PATCH 06/14] exec.c: Make address_space_rw take transaction attributes

2015-04-09 Thread Peter Maydell
On 9 April 2015 at 11:21, Paolo Bonzini pbonz...@redhat.com wrote: On 09/04/2015 12:14, Peter Maydell wrote: On 9 April 2015 at 10:59, Edgar E. Iglesias edgar.igles...@gmail.com wrote: On Tue, Apr 07, 2015 at 09:09:52PM +0100, Peter Maydell wrote: Make address_space_rw take transaction

Re: [Qemu-devel] [PATCH 06/14] exec.c: Make address_space_rw take transaction attributes

2015-04-09 Thread Paolo Bonzini
On 09/04/2015 12:14, Peter Maydell wrote: On 9 April 2015 at 10:59, Edgar E. Iglesias edgar.igles...@gmail.com wrote: On Tue, Apr 07, 2015 at 09:09:52PM +0100, Peter Maydell wrote: Make address_space_rw take transaction attributes, rather than always using the 'unspecified' attributes.

Re: [Qemu-devel] [PATCH 06/14] exec.c: Make address_space_rw take transaction attributes

2015-04-09 Thread Peter Maydell
On 9 April 2015 at 12:40, Paolo Bonzini pbonz...@redhat.com wrote: On 09/04/2015 12:43, Peter Maydell wrote: At this point, some memory barriers, basically. So what distinguishes a device that needs the memory barriers and does its accesses via dma_* from a device that doesn't and uses

Re: [Qemu-devel] [PATCH 06/14] exec.c: Make address_space_rw take transaction attributes

2015-04-09 Thread Peter Maydell
On 9 April 2015 at 10:59, Edgar E. Iglesias edgar.igles...@gmail.com wrote: On Tue, Apr 07, 2015 at 09:09:52PM +0100, Peter Maydell wrote: Make address_space_rw take transaction attributes, rather than always using the 'unspecified' attributes. Reviewed-by: Edgar E. Iglesias

Re: [Qemu-devel] [PATCH 06/14] exec.c: Make address_space_rw take transaction attributes

2015-04-08 Thread Paolo Bonzini
On 07/04/2015 22:09, Peter Maydell wrote: Make address_space_rw take transaction attributes, rather than always using the 'unspecified' attributes. Signed-off-by: Peter Maydell peter.mayd...@linaro.org --- dma-helpers.c| 3 ++- exec.c | 51

[Qemu-devel] [PATCH 06/14] exec.c: Make address_space_rw take transaction attributes

2015-04-07 Thread Peter Maydell
Make address_space_rw take transaction attributes, rather than always using the 'unspecified' attributes. Signed-off-by: Peter Maydell peter.mayd...@linaro.org --- dma-helpers.c| 3 ++- exec.c | 51 ++--