Re: [Qemu-devel] [PATCH 10/16] Introduce OS specific cmdline argument handling and move SMB arg to os-posix.c

2010-06-04 Thread Markus Armbruster
jes.soren...@redhat.com writes: From: Jes Sorensen jes.soren...@redhat.com Introduce OS specific cmdline argument handling by calling os_parse_cmd_args() at the end of switch() statement. In addition move SMB argument to os-posix.c Signed-off-by: Jes Sorensen jes.soren...@redhat.com ---

Re: [Qemu-devel] [PATCH 10/16] Introduce OS specific cmdline argument handling and move SMB arg to os-posix.c

2010-06-04 Thread Jes Sorensen
On 06/04/10 10:15, Markus Armbruster wrote: jes.soren...@redhat.com writes: + * Parse OS specific command line options. + * return 0 if option handled, -1 otherwise + */ +int os_parse_cmd_args(const QEMUOption *popt, const char *optarg) +{ +int ret = 0; +switch (popt-index) {

Re: [Qemu-devel] [PATCH 10/16] Introduce OS specific cmdline argument handling and move SMB arg to os-posix.c

2010-06-04 Thread Markus Armbruster
Jes Sorensen jes.soren...@redhat.com writes: On 06/04/10 10:15, Markus Armbruster wrote: jes.soren...@redhat.com writes: + * Parse OS specific command line options. + * return 0 if option handled, -1 otherwise + */ +int os_parse_cmd_args(const QEMUOption *popt, const char *optarg) +{ +

Re: [Qemu-devel] [PATCH 10/16] Introduce OS specific cmdline argument handling and move SMB arg to os-posix.c

2010-06-04 Thread Jes Sorensen
On 06/04/10 14:04, Markus Armbruster wrote: Jes Sorensen jes.soren...@redhat.com writes: On 06/04/10 10:15, Markus Armbruster wrote: What do you mean? The real ugh! here is that it was created as a typedef. I can change the function to pass in just the index, but I don't know if we will

Re: [Qemu-devel] [PATCH 10/16] Introduce OS specific cmdline argument handling and move SMB arg to os-posix.c

2010-06-04 Thread Richard Henderson
On 06/03/2010 11:47 PM, Jes Sorensen wrote: On 06/03/10 22:58, Richard Henderson wrote: On 06/03/2010 09:48 AM, jes.soren...@redhat.com wrote: +/* + * Duplicate definition from vl.c to avoid messing up the entire build + */ +enum { +#define DEF(option, opt_arg, opt_enum, opt_help,

Re: [Qemu-devel] [PATCH 10/16] Introduce OS specific cmdline argument handling and move SMB arg to os-posix.c

2010-06-04 Thread Jes Sorensen
On 06/04/10 16:49, Richard Henderson wrote: On 06/03/2010 11:47 PM, Jes Sorensen wrote: The problem is that it requires qemu-options.h to be included, which isn't included per default for all the files. If I put it into sysemu.h at least it's going to require making every .c file build with

[Qemu-devel] [PATCH 10/16] Introduce OS specific cmdline argument handling and move SMB arg to os-posix.c

2010-06-03 Thread Jes . Sorensen
From: Jes Sorensen jes.soren...@redhat.com Introduce OS specific cmdline argument handling by calling os_parse_cmd_args() at the end of switch() statement. In addition move SMB argument to os-posix.c Signed-off-by: Jes Sorensen jes.soren...@redhat.com --- os-posix.c | 34

Re: [Qemu-devel] [PATCH 10/16] Introduce OS specific cmdline argument handling and move SMB arg to os-posix.c

2010-06-03 Thread Richard Henderson
On 06/03/2010 09:48 AM, jes.soren...@redhat.com wrote: +/* + * Duplicate definition from vl.c to avoid messing up the entire build + */ +enum { +#define DEF(option, opt_arg, opt_enum, opt_help, arch_mask) \ +opt_enum, +#define DEFHEADING(text) +#include qemu-options.h +#undef DEF