Re: [Qemu-devel] [PATCH 2/2] iotests: add 208 nbd-server + blockdev-snapshot-sync test case

2018-03-12 Thread Max Reitz
On 2018-03-06 21:48, Stefan Hajnoczi wrote: > This test case adds an NBD server export and then invokes > blockdev-snapshot-sync, which changes the BlockDriverState node that the > NBD server's BlockBackend points to. This is an interesting scenario to > test and exercises the code path fixed by

Re: [Qemu-devel] [PATCH 2/2] iotests: add 208 nbd-server + blockdev-snapshot-sync test case

2018-03-09 Thread Eric Blake
On 03/06/2018 02:48 PM, Stefan Hajnoczi wrote: This test case adds an NBD server export and then invokes blockdev-snapshot-sync, which changes the BlockDriverState node that the Do we want to test 'blockdev-snapshot' instead (or in addition), given the subthread discussion about

Re: [Qemu-devel] [PATCH 2/2] iotests: add 208 nbd-server + blockdev-snapshot-sync test case

2018-03-06 Thread Stefano Panella
I have applied this patch and when I run the following qmp commands I I do not see the crash anymore but there is still something wrong because only /root/a is opened from qemu. It looks like nbd-server-stop is also getting rid of the nodes added with blockdev-snapshot-sync, therfore is than not

[Qemu-devel] [PATCH 2/2] iotests: add 208 nbd-server + blockdev-snapshot-sync test case

2018-03-06 Thread Stefan Hajnoczi
This test case adds an NBD server export and then invokes blockdev-snapshot-sync, which changes the BlockDriverState node that the NBD server's BlockBackend points to. This is an interesting scenario to test and exercises the code path fixed by the previous commit. Signed-off-by: Stefan Hajnoczi