On Tue, 29 Oct 2013 10:09:40 -0600
Eric Blake wrote:
> On 10/28/2013 11:22 PM, Wenchao Xia wrote:
>
> >>
> > MONITOR_EVENT seems tide to monitor too much, since it will be present
> > in qapi-schema, I think Q_EVENT_ or QMP_EVENT_KIND would be better?
>
> I don't have a strong enough opinion
于 2013/10/30 19:55, Paolo Bonzini 写道:
Il 30/10/2013 08:27, Wenchao Xia ha scritto:
于 2013/10/30 2:18, Kevin Wolf 写道:
Am 21.10.2013 um 22:41 hat Eric Blake geschrieben:
On 10/21/2013 03:16 AM, Wenchao Xia wrote:
The define will be moved to qapi-schema.json later, so rename the
prefix to match
Il 30/10/2013 08:27, Wenchao Xia ha scritto:
> 于 2013/10/30 2:18, Kevin Wolf 写道:
>> Am 21.10.2013 um 22:41 hat Eric Blake geschrieben:
>>> On 10/21/2013 03:16 AM, Wenchao Xia wrote:
The define will be moved to qapi-schema.json later, so rename the
prefix to match its naming style.
>>> Wou
于 2013/10/30 2:18, Kevin Wolf 写道:
Am 21.10.2013 um 22:41 hat Eric Blake geschrieben:
On 10/21/2013 03:16 AM, Wenchao Xia wrote:
The define will be moved to qapi-schema.json later, so rename the
prefix to match its naming style.
Wouldn't it be simpler to fix the code generator to special case Q
于 2013/10/30 0:09, Eric Blake 写道:
On 10/28/2013 11:22 PM, Wenchao Xia wrote:
MONITOR_EVENT seems tide to monitor too much, since it will be present
in qapi-schema, I think Q_EVENT_ or QMP_EVENT_KIND would be better?
I don't have a strong enough opinion on the bikeshed color.
MONITOR_EVENT i
Am 21.10.2013 um 22:41 hat Eric Blake geschrieben:
> On 10/21/2013 03:16 AM, Wenchao Xia wrote:
> > The define will be moved to qapi-schema.json later, so rename the
> > prefix to match its naming style.
>
> Wouldn't it be simpler to fix the code generator to special case QEvent
> to turn into QEV
On 10/28/2013 11:22 PM, Wenchao Xia wrote:
>>
> MONITOR_EVENT seems tide to monitor too much, since it will be present
> in qapi-schema, I think Q_EVENT_ or QMP_EVENT_KIND would be better?
I don't have a strong enough opinion on the bikeshed color.
MONITOR_EVENT implies the event is always asso
于 2013/10/28 18:44, Paolo Bonzini 写道:
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA1
Il 21/10/2013 22:41, Eric Blake ha scritto:
On 10/21/2013 03:16 AM, Wenchao Xia wrote:
The define will be moved to qapi-schema.json later, so rename
the prefix to match its naming style.
Wouldn't it be simpler
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA1
Il 21/10/2013 22:41, Eric Blake ha scritto:
> On 10/21/2013 03:16 AM, Wenchao Xia wrote:
>> The define will be moved to qapi-schema.json later, so rename
>> the prefix to match its naming style.
>
> Wouldn't it be simpler to fix the code generator to
于 2013/10/22 4:41, Eric Blake 写道:
On 10/21/2013 03:16 AM, Wenchao Xia wrote:
The define will be moved to qapi-schema.json later, so rename the
prefix to match its naming style.
Wouldn't it be simpler to fix the code generator to special case QEvent
to turn into QEVENT, instead of having to go t
On 10/21/2013 03:16 AM, Wenchao Xia wrote:
> The define will be moved to qapi-schema.json later, so rename the
> prefix to match its naming style.
Wouldn't it be simpler to fix the code generator to special case QEvent
to turn into QEVENT, instead of having to go through this churn? But if
we _li
The define will be moved to qapi-schema.json later, so rename the
prefix to match its naming style.
Also fixed code style error reported in spice-core.c.
Signed-off-by: Wenchao Xia
---
balloon.c |2 +-
block.c |4 +-
block/qcow2-refcount.c|2 +-
12 matches
Mail list logo
