Re: [Qemu-devel] [PATCH v1] migration: skip sending ram pages released by virtio-balloon driver.

2016-03-21 Thread Jitendra Kolhe
On 3/18/2016 4:57 PM, Roman Kagan wrote: > [ Sorry I've lost this thread with email setup changes on my side; > catching up ] > > On Tue, Mar 15, 2016 at 06:50:45PM +0530, Jitendra Kolhe wrote: >> On 3/11/2016 8:09 PM, Jitendra Kolhe wrote: >>> Here is what >>> I tried, let’s say we have 3

Re: [Qemu-devel] [PATCH v1] migration: skip sending ram pages released by virtio-balloon driver.

2016-03-19 Thread Roman Kagan
[ Sorry I've lost this thread with email setup changes on my side; catching up ] On Tue, Mar 15, 2016 at 06:50:45PM +0530, Jitendra Kolhe wrote: > On 3/11/2016 8:09 PM, Jitendra Kolhe wrote: > > Here is what > >I tried, let’s say we have 3 versions of qemu (below timings are for > >16GB idle

Re: [Qemu-devel] [PATCH v1] migration: skip sending ram pages released by virtio-balloon driver.

2016-03-15 Thread Jitendra Kolhe
On 3/11/2016 8:09 PM, Jitendra Kolhe wrote: You mean the total live migration time for the unmodified qemu and the 'you modified for test' qemu are almost the same? Not sure I understand the question, but if 'you modified for test' means below modifications to save_zero_page(), then answer is

Re: [Qemu-devel] [PATCH v1] migration: skip sending ram pages released by virtio-balloon driver.

2016-03-11 Thread Jitendra Kolhe
On 3/11/2016 4:24 PM, Li, Liang Z wrote: I wonder if it is the scanning for zeros or sending the whiteout which affects the total migration time more. If it is the former (as I would expect) then a rather local change to is_zero_range() to make use of the mapping information before scanning

Re: [Qemu-devel] [PATCH v1] migration: skip sending ram pages released by virtio-balloon driver.

2016-03-11 Thread Li, Liang Z
> >>> I wonder if it is the scanning for zeros or sending the whiteout > >>> which affects the total migration time more. If it is the former > >>> (as I would > >>> expect) then a rather local change to is_zero_range() to make use of > >>> the mapping information before scanning would get you

Re: [Qemu-devel] [PATCH v1] migration: skip sending ram pages released by virtio-balloon driver.

2016-03-11 Thread Jitendra Kolhe
On 3/11/2016 12:55 PM, Li, Liang Z wrote: On 3/10/2016 3:19 PM, Roman Kagan wrote: On Fri, Mar 04, 2016 at 02:32:47PM +0530, Jitendra Kolhe wrote: Even though the pages which are returned to the host by virtio-balloon driver are zero pages, the migration algorithm will still end up scanning

Re: [Qemu-devel] [PATCH v1] migration: skip sending ram pages released by virtio-balloon driver.

2016-03-10 Thread Li, Liang Z
> On 3/10/2016 3:19 PM, Roman Kagan wrote: > > On Fri, Mar 04, 2016 at 02:32:47PM +0530, Jitendra Kolhe wrote: > >> Even though the pages which are returned to the host by > >> virtio-balloon driver are zero pages, the migration algorithm will > >> still end up scanning the entire page

Re: [Qemu-devel] [PATCH v1] migration: skip sending ram pages released by virtio-balloon driver.

2016-03-10 Thread Jitendra Kolhe
On 3/10/2016 3:19 PM, Roman Kagan wrote: On Fri, Mar 04, 2016 at 02:32:47PM +0530, Jitendra Kolhe wrote: Even though the pages which are returned to the host by virtio-balloon driver are zero pages, the migration algorithm will still end up scanning the entire page ram_find_and_save_block() ->

Re: [Qemu-devel] [PATCH v1] migration: skip sending ram pages released by virtio-balloon driver.

2016-03-10 Thread Jitendra Kolhe
On 3/10/2016 10:57 PM, Eric Blake wrote: On 03/10/2016 01:57 AM, Jitendra Kolhe wrote: +++ b/qapi-schema.json @@ -544,11 +544,14 @@ # been migrated, pulling the remaining pages along as needed. NOTE: If # the migration fails during postcopy the VM will fail. (since 2.5)

Re: [Qemu-devel] [PATCH v1] migration: skip sending ram pages released by virtio-balloon driver.

2016-03-10 Thread Eric Blake
On 03/10/2016 01:57 AM, Jitendra Kolhe wrote: >>> +++ b/qapi-schema.json >>> @@ -544,11 +544,14 @@ >>> # been migrated, pulling the remaining pages along as needed. >>> NOTE: If >>> # the migration fails during postcopy the VM will fail. (since >>> 2.5) >>> # >>> +#

Re: [Qemu-devel] [PATCH v1] migration: skip sending ram pages released by virtio-balloon driver.

2016-03-10 Thread Roman Kagan
On Fri, Mar 04, 2016 at 02:32:47PM +0530, Jitendra Kolhe wrote: > Even though the pages which are returned to the host by virtio-balloon > driver are zero pages, the migration algorithm will still end up > scanning the entire page ram_find_and_save_block() -> ram_save_page/ >

Re: [Qemu-devel] [PATCH v1] migration: skip sending ram pages released by virtio-balloon driver.

2016-03-10 Thread Jitendra Kolhe
On 3/7/2016 10:35 PM, Eric Blake wrote: > On 03/04/2016 02:02 AM, Jitendra Kolhe wrote: >> While measuring live migration performance for qemu/kvm guest, it >> was observed that the qemu doesn’t maintain any intelligence for the >> guest ram pages which are release by the guest balloon driver and

Re: [Qemu-devel] [PATCH v1] migration: skip sending ram pages released by virtio-balloon driver.

2016-03-07 Thread Eric Blake
On 03/04/2016 02:02 AM, Jitendra Kolhe wrote: > While measuring live migration performance for qemu/kvm guest, it > was observed that the qemu doesn’t maintain any intelligence for the > guest ram pages which are release by the guest balloon driver and > treat such pages as any other normal guest

[Qemu-devel] [PATCH v1] migration: skip sending ram pages released by virtio-balloon driver.

2016-03-04 Thread Jitendra Kolhe
While measuring live migration performance for qemu/kvm guest, it was observed that the qemu doesn’t maintain any intelligence for the guest ram pages which are release by the guest balloon driver and treat such pages as any other normal guest ram pages. This has direct impact on overall migration