Re: [Qemu-devel] [PATCH v2 06/28] s390x/tcg: MVC: Use is_destructive_overlap()

2019-09-11 Thread David Hildenbrand
On 11.09.19 16:54, Richard Henderson wrote: > On 9/6/19 3:57 AM, David Hildenbrand wrote: >> if (dest == src + 1) { >> fast_memset(env, dest, cpu_ldub_data_ra(env, src, ra), l, ra); >> -} else if (dest < src || src + l <= dest) { >> +} else if (!is_destructive_overlap(env, des

Re: [Qemu-devel] [PATCH v2 06/28] s390x/tcg: MVC: Use is_destructive_overlap()

2019-09-11 Thread Richard Henderson
On 9/6/19 3:57 AM, David Hildenbrand wrote: > if (dest == src + 1) { > fast_memset(env, dest, cpu_ldub_data_ra(env, src, ra), l, ra); > -} else if (dest < src || src + l <= dest) { > +} else if (!is_destructive_overlap(env, dest, src, l)) { > fast_memmove(env, dest, s

[Qemu-devel] [PATCH v2 06/28] s390x/tcg: MVC: Use is_destructive_overlap()

2019-09-06 Thread David Hildenbrand
Let's use the new helper, that also detects destructive overlaps when wrapping. Signed-off-by: David Hildenbrand --- target/s390x/mem_helper.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/target/s390x/mem_helper.c b/target/s390x/mem_helper.c index 2bc2cd09c1..3c23c403cd 10