Re: [Qemu-devel] [PATCH v4] s390: diagnose 318 info reset and migration support

2019-05-16 Thread Collin Walling
On 5/14/19 5:04 AM, Christian Borntraeger wrote: On 14.05.19 11:00, David Hildenbrand wrote: On 14.05.19 10:56, Christian Borntraeger wrote: On 14.05.19 10:50, David Hildenbrand wrote: On 14.05.19 10:37, Christian Borntraeger wrote: On 14.05.19 09:28, David Hildenbrand wrote: But that

Re: [Qemu-devel] [PATCH v4] s390: diagnose 318 info reset and migration support

2019-05-14 Thread Christian Borntraeger
On 14.05.19 11:20, David Hildenbrand wrote: > On 14.05.19 11:10, Christian Borntraeger wrote: >> >> >> On 14.05.19 10:59, David Hildenbrand wrote: >>> On 14.05.19 10:49, Cornelia Huck wrote: On Tue, 14 May 2019 10:37:32 +0200 Christian Borntraeger wrote: > On 14.05.19 09:28,

Re: [Qemu-devel] [PATCH v4] s390: diagnose 318 info reset and migration support

2019-05-14 Thread David Hildenbrand
On 14.05.19 11:10, Christian Borntraeger wrote: > > > On 14.05.19 10:59, David Hildenbrand wrote: >> On 14.05.19 10:49, Cornelia Huck wrote: >>> On Tue, 14 May 2019 10:37:32 +0200 >>> Christian Borntraeger wrote: >>> On 14.05.19 09:28, David Hildenbrand wrote: But that can be

Re: [Qemu-devel] [PATCH v4] s390: diagnose 318 info reset and migration support

2019-05-14 Thread Cornelia Huck
On Tue, 14 May 2019 11:07:41 +0200 Christian Borntraeger wrote: > On 14.05.19 10:59, David Hildenbrand wrote: > > We can > > > > 1. Fail to start with #cpus > 240 when diag318=on > > 2. Remove the error once we support more than one SCLP response page > > > > Or > > > > 1. Allow to start

Re: [Qemu-devel] [PATCH v4] s390: diagnose 318 info reset and migration support

2019-05-14 Thread Christian Borntraeger
On 14.05.19 10:59, David Hildenbrand wrote: > On 14.05.19 10:49, Cornelia Huck wrote: >> On Tue, 14 May 2019 10:37:32 +0200 >> Christian Borntraeger wrote: >> >>> On 14.05.19 09:28, David Hildenbrand wrote: >>> But that can be tested using the runability information if I am not >>>

Re: [Qemu-devel] [PATCH v4] s390: diagnose 318 info reset and migration support

2019-05-14 Thread David Hildenbrand
On 14.05.19 11:03, David Hildenbrand wrote: > On 14.05.19 11:00, Cornelia Huck wrote: >> On Tue, 14 May 2019 10:56:43 +0200 >> Christian Borntraeger wrote: >> >>> On 14.05.19 10:50, David Hildenbrand wrote: >> Another idea for temporary handling: Simply only indicate 240 CPUs to the

Re: [Qemu-devel] [PATCH v4] s390: diagnose 318 info reset and migration support

2019-05-14 Thread David Hildenbrand
On 14.05.19 11:00, Cornelia Huck wrote: > On Tue, 14 May 2019 10:56:43 +0200 > Christian Borntraeger wrote: > >> On 14.05.19 10:50, David Hildenbrand wrote: > >>> Another idea for temporary handling: Simply only indicate 240 CPUs to >>> the guest if the response does not fit into a page. Once

Re: [Qemu-devel] [PATCH v4] s390: diagnose 318 info reset and migration support

2019-05-14 Thread Christian Borntraeger
On 14.05.19 10:59, David Hildenbrand wrote: > On 14.05.19 10:49, Cornelia Huck wrote: >> On Tue, 14 May 2019 10:37:32 +0200 >> Christian Borntraeger wrote: >> >>> On 14.05.19 09:28, David Hildenbrand wrote: >>> But that can be tested using the runability information if I am not >>>

Re: [Qemu-devel] [PATCH v4] s390: diagnose 318 info reset and migration support

2019-05-14 Thread Christian Borntraeger
On 14.05.19 11:00, David Hildenbrand wrote: > On 14.05.19 10:56, Christian Borntraeger wrote: >> >> >> On 14.05.19 10:50, David Hildenbrand wrote: >>> On 14.05.19 10:37, Christian Borntraeger wrote: On 14.05.19 09:28, David Hildenbrand wrote: But that can be tested using

Re: [Qemu-devel] [PATCH v4] s390: diagnose 318 info reset and migration support

2019-05-14 Thread David Hildenbrand
On 14.05.19 10:56, Christian Borntraeger wrote: > > > On 14.05.19 10:50, David Hildenbrand wrote: >> On 14.05.19 10:37, Christian Borntraeger wrote: >>> >>> >>> On 14.05.19 09:28, David Hildenbrand wrote: >>> But that can be tested using the runability information if I am not >>> wrong.

Re: [Qemu-devel] [PATCH v4] s390: diagnose 318 info reset and migration support

2019-05-14 Thread David Hildenbrand
On 14.05.19 10:49, Cornelia Huck wrote: > On Tue, 14 May 2019 10:37:32 +0200 > Christian Borntraeger wrote: > >> On 14.05.19 09:28, David Hildenbrand wrote: >> But that can be tested using the runability information if I am not >> wrong. > > You mean the cpu level information,

Re: [Qemu-devel] [PATCH v4] s390: diagnose 318 info reset and migration support

2019-05-14 Thread Cornelia Huck
On Tue, 14 May 2019 10:56:43 +0200 Christian Borntraeger wrote: > On 14.05.19 10:50, David Hildenbrand wrote: > > Another idea for temporary handling: Simply only indicate 240 CPUs to > > the guest if the response does not fit into a page. Once we have that > > SCLP thingy, this will be fixed.

Re: [Qemu-devel] [PATCH v4] s390: diagnose 318 info reset and migration support

2019-05-14 Thread Christian Borntraeger
On 14.05.19 10:50, David Hildenbrand wrote: > On 14.05.19 10:37, Christian Borntraeger wrote: >> >> >> On 14.05.19 09:28, David Hildenbrand wrote: >> But that can be tested using the runability information if I am not >> wrong. > > You mean the cpu level information, right? >>>

Re: [Qemu-devel] [PATCH v4] s390: diagnose 318 info reset and migration support

2019-05-14 Thread Christian Borntraeger
On 14.05.19 10:49, Cornelia Huck wrote: > On Tue, 14 May 2019 10:37:32 +0200 > Christian Borntraeger wrote: > >> On 14.05.19 09:28, David Hildenbrand wrote: >> But that can be tested using the runability information if I am not >> wrong. > > You mean the cpu level

Re: [Qemu-devel] [PATCH v4] s390: diagnose 318 info reset and migration support

2019-05-14 Thread David Hildenbrand
On 14.05.19 10:37, Christian Borntraeger wrote: > > > On 14.05.19 09:28, David Hildenbrand wrote: > But that can be tested using the runability information if I am not wrong. You mean the cpu level information, right? >> >> Yes, query-cpu-definition includes for each model

Re: [Qemu-devel] [PATCH v4] s390: diagnose 318 info reset and migration support

2019-05-14 Thread Cornelia Huck
On Tue, 14 May 2019 10:37:32 +0200 Christian Borntraeger wrote: > On 14.05.19 09:28, David Hildenbrand wrote: > But that can be tested using the runability information if I am not > wrong. > >>> > >>> You mean the cpu level information, right? > > > > Yes, query-cpu-definition

Re: [Qemu-devel] [PATCH v4] s390: diagnose 318 info reset and migration support

2019-05-14 Thread Christian Borntraeger
On 14.05.19 09:28, David Hildenbrand wrote: But that can be tested using the runability information if I am not wrong. >>> >>> You mean the cpu level information, right? > > Yes, query-cpu-definition includes for each model runability information > via "unavailable-features" (valid under

Re: [Qemu-devel] [PATCH v4] s390: diagnose 318 info reset and migration support

2019-05-14 Thread David Hildenbrand
>>> But that can be tested using the runability information if I am not wrong. >> >> You mean the cpu level information, right? Yes, query-cpu-definition includes for each model runability information via "unavailable-features" (valid under the started QEMU machine). >> >>> and others that

Re: [Qemu-devel] [PATCH v4] s390: diagnose 318 info reset and migration support

2019-05-14 Thread Christian Borntraeger
On 13.05.19 13:46, Cornelia Huck wrote: > On Mon, 13 May 2019 13:34:35 +0200 > David Hildenbrand wrote: > >> On 13.05.19 12:55, Christian Borntraeger wrote: >>> >>> >>> On 13.05.19 11:57, David Hildenbrand wrote: On 13.05.19 11:51, Christian Borntraeger wrote: > > > On

Re: [Qemu-devel] [PATCH v4] s390: diagnose 318 info reset and migration support

2019-05-13 Thread Cornelia Huck
On Mon, 13 May 2019 13:34:35 +0200 David Hildenbrand wrote: > On 13.05.19 12:55, Christian Borntraeger wrote: > > > > > > On 13.05.19 11:57, David Hildenbrand wrote: > >> On 13.05.19 11:51, Christian Borntraeger wrote: > >>> > >>> > >>> On 13.05.19 11:40, David Hildenbrand wrote: >

Re: [Qemu-devel] [PATCH v4] s390: diagnose 318 info reset and migration support

2019-05-13 Thread David Hildenbrand
On 13.05.19 12:55, Christian Borntraeger wrote: > > > On 13.05.19 11:57, David Hildenbrand wrote: >> On 13.05.19 11:51, Christian Borntraeger wrote: >>> >>> >>> On 13.05.19 11:40, David Hildenbrand wrote: On 13.05.19 11:34, Christian Borntraeger wrote: > > > On 13.05.19 10:03,

Re: [Qemu-devel] [PATCH v4] s390: diagnose 318 info reset and migration support

2019-05-13 Thread Christian Borntraeger
On 13.05.19 11:57, David Hildenbrand wrote: > On 13.05.19 11:51, Christian Borntraeger wrote: >> >> >> On 13.05.19 11:40, David Hildenbrand wrote: >>> On 13.05.19 11:34, Christian Borntraeger wrote: On 13.05.19 10:03, David Hildenbrand wrote: >>> +if ((SCCB_SIZE -

Re: [Qemu-devel] [PATCH v4] s390: diagnose 318 info reset and migration support

2019-05-13 Thread David Hildenbrand
On 13.05.19 11:51, Christian Borntraeger wrote: > > > On 13.05.19 11:40, David Hildenbrand wrote: >> On 13.05.19 11:34, Christian Borntraeger wrote: >>> >>> >>> On 13.05.19 10:03, David Hildenbrand wrote: >> +if ((SCCB_SIZE - sizeof(ReadInfo)) / sizeof(CPUEntry) < >> S390_MAX_CPUS)

Re: [Qemu-devel] [PATCH v4] s390: diagnose 318 info reset and migration support

2019-05-13 Thread Christian Borntraeger
On 13.05.19 11:40, David Hildenbrand wrote: > On 13.05.19 11:34, Christian Borntraeger wrote: >> >> >> On 13.05.19 10:03, David Hildenbrand wrote: > +if ((SCCB_SIZE - sizeof(ReadInfo)) / sizeof(CPUEntry) < > S390_MAX_CPUS) > +mc->max_cpus = S390_MAX_CPUS - 8;

Re: [Qemu-devel] [PATCH v4] s390: diagnose 318 info reset and migration support

2019-05-13 Thread David Hildenbrand
On 13.05.19 11:34, Christian Borntraeger wrote: > > > On 13.05.19 10:03, David Hildenbrand wrote: +if ((SCCB_SIZE - sizeof(ReadInfo)) / sizeof(CPUEntry) < S390_MAX_CPUS) +mc->max_cpus = S390_MAX_CPUS - 8; >>> >>> This is too complicated, just set it always to 240. >>> >>>

Re: [Qemu-devel] [PATCH v4] s390: diagnose 318 info reset and migration support

2019-05-13 Thread Christian Borntraeger
On 13.05.19 10:03, David Hildenbrand wrote: >>> +if ((SCCB_SIZE - sizeof(ReadInfo)) / sizeof(CPUEntry) < S390_MAX_CPUS) >>> +mc->max_cpus = S390_MAX_CPUS - 8; >> >> This is too complicated, just set it always to 240. >> >> However, I am still not sure how to best handle this

Re: [Qemu-devel] [PATCH v4] s390: diagnose 318 info reset and migration support

2019-05-13 Thread David Hildenbrand
On 13.05.19 09:46, David Hildenbrand wrote: > On 02.05.19 00:31, Collin Walling wrote: >> DIAGNOSE 0x318 (diag318) is a privileged s390x instruction that must >> be intercepted by SIE and handled via KVM. Let's introduce some >> functions to communicate between QEMU and KVM via ioctls. These >>

Re: [Qemu-devel] [PATCH v4] s390: diagnose 318 info reset and migration support

2019-05-13 Thread David Hildenbrand
On 02.05.19 00:31, Collin Walling wrote: > DIAGNOSE 0x318 (diag318) is a privileged s390x instruction that must > be intercepted by SIE and handled via KVM. Let's introduce some > functions to communicate between QEMU and KVM via ioctls. These > will be used to get/set the diag318 related

Re: [Qemu-devel] [PATCH v4] s390: diagnose 318 info reset and migration support

2019-05-09 Thread Collin Walling
On 5/9/19 5:58 AM, Christian Borntraeger wrote: On 02.05.19 00:31, Collin Walling wrote: DIAGNOSE 0x318 (diag318) is a privileged s390x instruction that must be intercepted by SIE and handled via KVM. Let's introduce some functions to communicate between QEMU and KVM via ioctls. These will be

Re: [Qemu-devel] [PATCH v4] s390: diagnose 318 info reset and migration support

2019-05-09 Thread David Hildenbrand
On 09.05.19 11:58, Christian Borntraeger wrote: > > > On 02.05.19 00:31, Collin Walling wrote: >> DIAGNOSE 0x318 (diag318) is a privileged s390x instruction that must >> be intercepted by SIE and handled via KVM. Let's introduce some >> functions to communicate between QEMU and KVM via ioctls.

Re: [Qemu-devel] [PATCH v4] s390: diagnose 318 info reset and migration support

2019-05-09 Thread Christian Borntraeger
On 02.05.19 00:31, Collin Walling wrote: > DIAGNOSE 0x318 (diag318) is a privileged s390x instruction that must > be intercepted by SIE and handled via KVM. Let's introduce some > functions to communicate between QEMU and KVM via ioctls. These > will be used to get/set the diag318 related

[Qemu-devel] [PATCH v4] s390: diagnose 318 info reset and migration support

2019-05-01 Thread Collin Walling
DIAGNOSE 0x318 (diag318) is a privileged s390x instruction that must be intercepted by SIE and handled via KVM. Let's introduce some functions to communicate between QEMU and KVM via ioctls. These will be used to get/set the diag318 related information (also known as the "Control Program Code" or