Re: [Qemu-devel] [PATCH v8 00/13] Interactive Boot Menu for DASD and SCSI Guests on s390x

2018-02-23 Thread Collin L. Walling
On 02/23/2018 08:33 AM, Thomas Huth wrote: On 23.02.2018 12:50, Viktor Mihajlovski wrote: On 23.02.2018 11:17, Thomas Huth wrote: On 23.02.2018 09:53, Christian Borntraeger wrote: Hmmm, on my ubuntu 16.04 guest, I get the boot menu with no timeout even if I do not specify loadparm or boot men

Re: [Qemu-devel] [PATCH v8 00/13] Interactive Boot Menu for DASD and SCSI Guests on s390x

2018-02-23 Thread Thomas Huth
On 23.02.2018 12:50, Viktor Mihajlovski wrote: > On 23.02.2018 11:17, Thomas Huth wrote: >> On 23.02.2018 09:53, Christian Borntraeger wrote: >>> Hmmm, on my ubuntu 16.04 guest, I get the boot menu with no timeout even if >>> I do not >>> specify loadparm or boot menu: >>> >>> qemu-kvm -drive fil

Re: [Qemu-devel] [PATCH v8 00/13] Interactive Boot Menu for DASD and SCSI Guests on s390x

2018-02-23 Thread Viktor Mihajlovski
On 23.02.2018 11:17, Thomas Huth wrote: > On 23.02.2018 09:53, Christian Borntraeger wrote: >> Hmmm, on my ubuntu 16.04 guest, I get the boot menu with no timeout even if >> I do not >> specify loadparm or boot menu: >> >> qemu-kvm -drive file=/var/lib/libvirt/qemu/image.zhyp140,if=none,id=d1 >>

Re: [Qemu-devel] [PATCH v8 00/13] Interactive Boot Menu for DASD and SCSI Guests on s390x

2018-02-23 Thread Thomas Huth
On 23.02.2018 09:53, Christian Borntraeger wrote: > Hmmm, on my ubuntu 16.04 guest, I get the boot menu with no timeout even if I > do not > specify loadparm or boot menu: > > qemu-kvm -drive file=/var/lib/libvirt/qemu/image.zhyp140,if=none,id=d1 > -device virtio-blk-ccw,drive=d1,bootindex=1

Re: [Qemu-devel] [PATCH v8 00/13] Interactive Boot Menu for DASD and SCSI Guests on s390x

2018-02-23 Thread Christian Borntraeger
Hmmm, on my ubuntu 16.04 guest, I get the boot menu with no timeout even if I do not specify loadparm or boot menu: qemu-kvm -drive file=/var/lib/libvirt/qemu/image.zhyp140,if=none,id=d1 -device virtio-blk-ccw,drive=d1,bootindex=1 LOADPARM=[] Using virtio-blk. Using SCSI scheme. s390x

Re: [Qemu-devel] [PATCH v8 00/13] Interactive Boot Menu for DASD and SCSI Guests on s390x

2018-02-22 Thread Viktor Mihajlovski
On 22.02.2018 12:51, Christian Borntraeger wrote: > Series > Acked-by: Christian Borntraeger > > > menu on scsi and dasd bootmaps tested successfully. > > There is one thing that we might want to fix (can be an addon patch since > this is a non-customer > scenario (no libvirt)). > > If you st

Re: [Qemu-devel] [PATCH v8 00/13] Interactive Boot Menu for DASD and SCSI Guests on s390x

2018-02-22 Thread Christian Borntraeger
Series Acked-by: Christian Borntraeger menu on scsi and dasd bootmaps tested successfully. There is one thing that we might want to fix (can be an addon patch since this is a non-customer scenario (no libvirt)). If you start QEMU manually without a bootindex, the -boot menu=on is ignored if n

[Qemu-devel] [PATCH v8 00/13] Interactive Boot Menu for DASD and SCSI Guests on s390x

2018-02-21 Thread Collin L. Walling
Due to the introduction of the QemuIplParameter block and taking some time to revist some areas, a few chunks of code have been reworked to better align with those changes. I also think the reworkings improve readability. The same functionality is still there, the code just looks a little differen