Re: [Qemu-devel] [PATCHv2] block: add native support for NFS

2014-01-03 Thread Peter Lieven
On 20.12.2013 17:27, Stefan Hajnoczi wrote: On Fri, Dec 20, 2013 at 4:57 PM, Peter Lieven wrote: On 20.12.2013 16:54, Stefan Hajnoczi wrote: On Fri, Dec 20, 2013 at 4:49 PM, Peter Lieven wrote: On 20.12.2013 16:30, Stefan Hajnoczi wrote: On Fri, Dec 20, 2013 at 3:43 PM, Peter Lieven wrote:

Re: [Qemu-devel] [PATCHv2] block: add native support for NFS

2013-12-20 Thread Stefan Hajnoczi
On Fri, Dec 20, 2013 at 4:57 PM, Peter Lieven wrote: > On 20.12.2013 16:54, Stefan Hajnoczi wrote: >> >> On Fri, Dec 20, 2013 at 4:49 PM, Peter Lieven wrote: >>> >>> On 20.12.2013 16:30, Stefan Hajnoczi wrote: On Fri, Dec 20, 2013 at 3:43 PM, Peter Lieven wrote: > > On 20.12.20

Re: [Qemu-devel] [PATCHv2] block: add native support for NFS

2013-12-20 Thread Peter Lieven
On 20.12.2013 16:54, Stefan Hajnoczi wrote: On Fri, Dec 20, 2013 at 4:49 PM, Peter Lieven wrote: On 20.12.2013 16:30, Stefan Hajnoczi wrote: On Fri, Dec 20, 2013 at 3:43 PM, Peter Lieven wrote: On 20.12.2013 15:38, Stefan Hajnoczi wrote: On Fri, Dec 20, 2013 at 3:07 PM, Peter Lieven wrote:

Re: [Qemu-devel] [PATCHv2] block: add native support for NFS

2013-12-20 Thread Stefan Hajnoczi
On Fri, Dec 20, 2013 at 4:49 PM, Peter Lieven wrote: > On 20.12.2013 16:30, Stefan Hajnoczi wrote: >> >> On Fri, Dec 20, 2013 at 3:43 PM, Peter Lieven wrote: >>> >>> On 20.12.2013 15:38, Stefan Hajnoczi wrote: On Fri, Dec 20, 2013 at 3:07 PM, Peter Lieven wrote: > > On 20.12.20

Re: [Qemu-devel] [PATCHv2] block: add native support for NFS

2013-12-20 Thread Peter Lieven
On 20.12.2013 16:30, Stefan Hajnoczi wrote: On Fri, Dec 20, 2013 at 3:43 PM, Peter Lieven wrote: On 20.12.2013 15:38, Stefan Hajnoczi wrote: On Fri, Dec 20, 2013 at 3:07 PM, Peter Lieven wrote: On 20.12.2013 14:57, Stefan Hajnoczi wrote: On Fri, Dec 20, 2013 at 1:53 PM, Peter Lieven wrote:

Re: [Qemu-devel] [PATCHv2] block: add native support for NFS

2013-12-20 Thread Stefan Hajnoczi
On Fri, Dec 20, 2013 at 3:43 PM, Peter Lieven wrote: > On 20.12.2013 15:38, Stefan Hajnoczi wrote: >> >> On Fri, Dec 20, 2013 at 3:07 PM, Peter Lieven wrote: >>> >>> On 20.12.2013 14:57, Stefan Hajnoczi wrote: On Fri, Dec 20, 2013 at 1:53 PM, Peter Lieven wrote: > > On 20.12.20

Re: [Qemu-devel] [PATCHv2] block: add native support for NFS

2013-12-20 Thread ronnie sahlberg
The sync calls uses a trivial eventloop built into libnfs using poll(). Mixing the _async() and _sync() interfaces in libnfs means you may risk running nested eventloops. Pain and tears lie behind that door. On Fri, Dec 20, 2013 at 6:43 AM, Peter Lieven wrote: > On 20.12.2013 15:38, Stefan Hajno

Re: [Qemu-devel] [PATCHv2] block: add native support for NFS

2013-12-20 Thread Peter Lieven
On 20.12.2013 15:38, Stefan Hajnoczi wrote: On Fri, Dec 20, 2013 at 3:07 PM, Peter Lieven wrote: On 20.12.2013 14:57, Stefan Hajnoczi wrote: On Fri, Dec 20, 2013 at 1:53 PM, Peter Lieven wrote: On 20.12.2013 13:19, Stefan Hajnoczi wrote: On Fri, Dec 20, 2013 at 10:48:41AM +0100, Peter Lieve

Re: [Qemu-devel] [PATCHv2] block: add native support for NFS

2013-12-20 Thread Stefan Hajnoczi
On Fri, Dec 20, 2013 at 3:07 PM, Peter Lieven wrote: > On 20.12.2013 14:57, Stefan Hajnoczi wrote: >> >> On Fri, Dec 20, 2013 at 1:53 PM, Peter Lieven wrote: >>> >>> On 20.12.2013 13:19, Stefan Hajnoczi wrote: On Fri, Dec 20, 2013 at 10:48:41AM +0100, Peter Lieven wrote: > > On

Re: [Qemu-devel] [PATCHv2] block: add native support for NFS

2013-12-20 Thread Peter Lieven
On 20.12.2013 14:57, Stefan Hajnoczi wrote: On Fri, Dec 20, 2013 at 1:53 PM, Peter Lieven wrote: On 20.12.2013 13:19, Stefan Hajnoczi wrote: On Fri, Dec 20, 2013 at 10:48:41AM +0100, Peter Lieven wrote: On 17.12.2013 17:47, Stefan Hajnoczi wrote: On Tue, Dec 17, 2013 at 10:15:25AM +0100, Pet

Re: [Qemu-devel] [PATCHv2] block: add native support for NFS

2013-12-20 Thread Stefan Hajnoczi
On Fri, Dec 20, 2013 at 1:53 PM, Peter Lieven wrote: > On 20.12.2013 13:19, Stefan Hajnoczi wrote: >> >> On Fri, Dec 20, 2013 at 10:48:41AM +0100, Peter Lieven wrote: >>> >>> On 17.12.2013 17:47, Stefan Hajnoczi wrote: On Tue, Dec 17, 2013 at 10:15:25AM +0100, Peter Lieven wrote: > +

Re: [Qemu-devel] [PATCHv2] block: add native support for NFS

2013-12-20 Thread Peter Lieven
On 20.12.2013 13:19, Stefan Hajnoczi wrote: On Fri, Dec 20, 2013 at 10:48:41AM +0100, Peter Lieven wrote: On 17.12.2013 17:47, Stefan Hajnoczi wrote: On Tue, Dec 17, 2013 at 10:15:25AM +0100, Peter Lieven wrote: This patch adds native support for accessing images on NFS shares without the requ

Re: [Qemu-devel] [PATCHv2] block: add native support for NFS

2013-12-20 Thread Stefan Hajnoczi
On Fri, Dec 20, 2013 at 10:48:41AM +0100, Peter Lieven wrote: > On 17.12.2013 17:47, Stefan Hajnoczi wrote: > >On Tue, Dec 17, 2013 at 10:15:25AM +0100, Peter Lieven wrote: > >>This patch adds native support for accessing images on NFS shares without > >>the requirement to actually mount the entire

Re: [Qemu-devel] [PATCHv2] block: add native support for NFS

2013-12-20 Thread Peter Lieven
On 17.12.2013 17:47, Stefan Hajnoczi wrote: On Tue, Dec 17, 2013 at 10:15:25AM +0100, Peter Lieven wrote: This patch adds native support for accessing images on NFS shares without the requirement to actually mount the entire NFS share on the host. NFS Images can simply be specified by an url of

Re: [Qemu-devel] [PATCHv2] block: add native support for NFS

2013-12-19 Thread Paolo Bonzini
Il 18/12/2013 18:21, Peter Lieven ha scritto: > Not completely I think, but please correct me if I am wrong. > > If cache=writeback is set we issue just a write. In libnfs or libiscsi case > that guarantees that the request has been successfully executed > on the target / server. This is enough to

Re: [Qemu-devel] [PATCHv2] block: add native support for NFS

2013-12-18 Thread Peter Lieven
Am 18.12.2013 um 18:50 schrieb ronnie sahlberg : > On Wed, Dec 18, 2013 at 9:42 AM, Peter Lieven wrote: >> >> Am 18.12.2013 um 18:33 schrieb ronnie sahlberg : >> >>> On Wed, Dec 18, 2013 at 8:59 AM, Peter Lieven wrote: Am 18.12.2013 um 15:42 schrieb ronnie sahlberg : > On

Re: [Qemu-devel] [PATCHv2] block: add native support for NFS

2013-12-18 Thread ronnie sahlberg
On Wed, Dec 18, 2013 at 9:42 AM, Peter Lieven wrote: > > Am 18.12.2013 um 18:33 schrieb ronnie sahlberg : > >> On Wed, Dec 18, 2013 at 8:59 AM, Peter Lieven wrote: >>> >>> Am 18.12.2013 um 15:42 schrieb ronnie sahlberg : >>> On Wed, Dec 18, 2013 at 2:00 AM, Orit Wasserman wrote: >

Re: [Qemu-devel] [PATCHv2] block: add native support for NFS

2013-12-18 Thread Peter Lieven
Am 18.12.2013 um 18:33 schrieb ronnie sahlberg : > On Wed, Dec 18, 2013 at 8:59 AM, Peter Lieven wrote: >> >> Am 18.12.2013 um 15:42 schrieb ronnie sahlberg : >> >>> On Wed, Dec 18, 2013 at 2:00 AM, Orit Wasserman wrote: On 12/18/2013 01:03 AM, Peter Lieven wrote: > > > >>

Re: [Qemu-devel] [PATCHv2] block: add native support for NFS

2013-12-18 Thread ronnie sahlberg
On Wed, Dec 18, 2013 at 8:59 AM, Peter Lieven wrote: > > Am 18.12.2013 um 15:42 schrieb ronnie sahlberg : > >> On Wed, Dec 18, 2013 at 2:00 AM, Orit Wasserman wrote: >>> On 12/18/2013 01:03 AM, Peter Lieven wrote: > Am 17.12.2013 um 18:32 schrieb "Daniel P. Berrange" > : >>

Re: [Qemu-devel] [PATCHv2] block: add native support for NFS

2013-12-18 Thread Peter Lieven
Am 18.12.2013 um 11:38 schrieb Paolo Bonzini : > Il 18/12/2013 11:24, Orit Wasserman ha scritto: For live migration we need the sync option (async ignores O_SYNC and O_DIRECT sadly), will it be supported? or will it be the default? >>> >>> Since this is bypassing the client

Re: [Qemu-devel] [PATCHv2] block: add native support for NFS

2013-12-18 Thread Peter Lieven
Am 18.12.2013 um 15:42 schrieb ronnie sahlberg : > On Wed, Dec 18, 2013 at 2:00 AM, Orit Wasserman wrote: >> On 12/18/2013 01:03 AM, Peter Lieven wrote: >>> >>> >>> Am 17.12.2013 um 18:32 schrieb "Daniel P. Berrange" : > On Tue, Dec 17, 2013 at 10:15:25AM +0100, Peter Liev

Re: [Qemu-devel] [PATCHv2] block: add native support for NFS

2013-12-18 Thread ronnie sahlberg
On Wed, Dec 18, 2013 at 2:00 AM, Orit Wasserman wrote: > On 12/18/2013 01:03 AM, Peter Lieven wrote: >> >> >> >>> Am 17.12.2013 um 18:32 schrieb "Daniel P. Berrange" >>> : >>> On Tue, Dec 17, 2013 at 10:15:25AM +0100, Peter Lieven wrote: This patch adds native support for accessing image

Re: [Qemu-devel] [PATCHv2] block: add native support for NFS

2013-12-18 Thread Orit Wasserman
On 12/18/2013 01:11 PM, Peter Lieven wrote: Am 18.12.2013 um 11:00 schrieb Orit Wasserman : On 12/18/2013 01:03 AM, Peter Lieven wrote: Am 17.12.2013 um 18:32 schrieb "Daniel P. Berrange" : On Tue, Dec 17, 2013 at 10:15:25AM +0100, Peter Lieven wrote: This patch adds native support for a

Re: [Qemu-devel] [PATCHv2] block: add native support for NFS

2013-12-18 Thread Peter Lieven
> Am 18.12.2013 um 11:00 schrieb Orit Wasserman : > >> On 12/18/2013 01:03 AM, Peter Lieven wrote: >> >> Am 17.12.2013 um 18:32 schrieb "Daniel P. Berrange" : On Tue, Dec 17, 2013 at 10:15:25AM +0100, Peter Lieven wrote: This patch adds native support for accessing images

Re: [Qemu-devel] [PATCHv2] block: add native support for NFS

2013-12-18 Thread Paolo Bonzini
Il 18/12/2013 11:24, Orit Wasserman ha scritto: >>> >>> For live migration we need the sync option (async ignores O_SYNC and >>> O_DIRECT sadly), >>> will it be supported? or will it be the default? >> >> Since this is bypassing the client kernel FS I/O layer question around >> support of things li

Re: [Qemu-devel] [PATCHv2] block: add native support for NFS

2013-12-18 Thread Orit Wasserman
On 12/18/2013 12:18 PM, Daniel P. Berrange wrote: On Wed, Dec 18, 2013 at 12:00:03PM +0200, Orit Wasserman wrote: On 12/18/2013 01:03 AM, Peter Lieven wrote: Am 17.12.2013 um 18:32 schrieb "Daniel P. Berrange" : On Tue, Dec 17, 2013 at 10:15:25AM +0100, Peter Lieven wrote: This patch adds

Re: [Qemu-devel] [PATCHv2] block: add native support for NFS

2013-12-18 Thread Daniel P. Berrange
On Wed, Dec 18, 2013 at 12:00:03PM +0200, Orit Wasserman wrote: > On 12/18/2013 01:03 AM, Peter Lieven wrote: > > > > > >>Am 17.12.2013 um 18:32 schrieb "Daniel P. Berrange" : > >> > >>>On Tue, Dec 17, 2013 at 10:15:25AM +0100, Peter Lieven wrote: > >>>This patch adds native support for accessing i

Re: [Qemu-devel] [PATCHv2] block: add native support for NFS

2013-12-18 Thread Orit Wasserman
On 12/18/2013 01:03 AM, Peter Lieven wrote: Am 17.12.2013 um 18:32 schrieb "Daniel P. Berrange" : On Tue, Dec 17, 2013 at 10:15:25AM +0100, Peter Lieven wrote: This patch adds native support for accessing images on NFS shares without the requirement to actually mount the entire NFS share on

Re: [Qemu-devel] [PATCHv2] block: add native support for NFS

2013-12-18 Thread Daniel P. Berrange
On Wed, Dec 18, 2013 at 12:03:24AM +0100, Peter Lieven wrote: > > > > Am 17.12.2013 um 18:32 schrieb "Daniel P. Berrange" : > > > >> On Tue, Dec 17, 2013 at 10:15:25AM +0100, Peter Lieven wrote: > >> This patch adds native support for accessing images on NFS shares without > >> the requirement t

Re: [Qemu-devel] [PATCHv2] block: add native support for NFS

2013-12-17 Thread Peter Lieven
> Am 17.12.2013 um 18:32 schrieb "Daniel P. Berrange" : > >> On Tue, Dec 17, 2013 at 10:15:25AM +0100, Peter Lieven wrote: >> This patch adds native support for accessing images on NFS shares without >> the requirement to actually mount the entire NFS share on the host. >> >> NFS Images can sim

Re: [Qemu-devel] [PATCHv2] block: add native support for NFS

2013-12-17 Thread Peter Lieven
> Am 17.12.2013 um 17:53 schrieb ronnie sahlberg : > > NFSTask > > Task is a very scsi-ish term. Maybe RPC is better ? > > NFSrpc ? will change it in v3 > > > >> On Tue, Dec 17, 2013 at 1:15 AM, Peter Lieven wrote: >> This patch adds native support for accessing images on NFS shares with

Re: [Qemu-devel] [PATCHv2] block: add native support for NFS

2013-12-17 Thread Peter Lieven
> Am 17.12.2013 um 18:28 schrieb ronnie sahlberg : > >> On Tue, Dec 17, 2013 at 9:03 AM, Peter Lieven wrote: >>> On 17.12.2013 17:47, Stefan Hajnoczi wrote: >>> >>> On Tue, Dec 17, 2013 at 10:15:25AM +0100, Peter Lieven wrote: > > ... +if (nfs_pwrite_async(client->context, client->fh

Re: [Qemu-devel] [PATCHv2] block: add native support for NFS

2013-12-17 Thread Peter Lieven
> Am 17.12.2013 um 23:51 schrieb ronnie sahlberg : > >> On Tue, Dec 17, 2013 at 2:36 PM, Peter Lieven wrote: >> >> Am 17.12.2013 um 18:13 schrieb ronnie sahlberg : On Tue, Dec 17, 2013 at 9:03 AM, Peter Lieven wrote: On 17.12.2013 17:47, Stefan Hajnoczi wrote: >>> ... >>

Re: [Qemu-devel] [PATCHv2] block: add native support for NFS

2013-12-17 Thread ronnie sahlberg
On Tue, Dec 17, 2013 at 2:36 PM, Peter Lieven wrote: > > >> Am 17.12.2013 um 18:13 schrieb ronnie sahlberg : >> >>> On Tue, Dec 17, 2013 at 9:03 AM, Peter Lieven wrote: >>> On 17.12.2013 17:47, Stefan Hajnoczi wrote: >> ... Which NFS protocol versions are supported by current libnfs? >>> >>>

Re: [Qemu-devel] [PATCHv2] block: add native support for NFS

2013-12-17 Thread Eric Blake
On 12/17/2013 03:36 PM, Peter Lieven wrote: > > >> Am 17.12.2013 um 18:13 schrieb ronnie sahlberg : >> >>> On Tue, Dec 17, 2013 at 9:03 AM, Peter Lieven wrote: >>> On 17.12.2013 17:47, Stefan Hajnoczi wrote: >> ... Which NFS protocol versions are supported by current libnfs? >>> >>> Will ch

Re: [Qemu-devel] [PATCHv2] block: add native support for NFS

2013-12-17 Thread Peter Lieven
> Am 17.12.2013 um 18:13 schrieb ronnie sahlberg : > >> On Tue, Dec 17, 2013 at 9:03 AM, Peter Lieven wrote: >> On 17.12.2013 17:47, Stefan Hajnoczi wrote: > ... >>> Which NFS protocol versions are supported by current libnfs? >> >> Will check that out. Ronnie? > > It uses NFS v3 only. shoul

Re: [Qemu-devel] [PATCHv2] block: add native support for NFS

2013-12-17 Thread Daniel P. Berrange
On Tue, Dec 17, 2013 at 10:15:25AM +0100, Peter Lieven wrote: > This patch adds native support for accessing images on NFS shares without > the requirement to actually mount the entire NFS share on the host. > > NFS Images can simply be specified by an url of the form: > nfs: > > For example:

Re: [Qemu-devel] [PATCHv2] block: add native support for NFS

2013-12-17 Thread ronnie sahlberg
On Tue, Dec 17, 2013 at 9:03 AM, Peter Lieven wrote: > On 17.12.2013 17:47, Stefan Hajnoczi wrote: >> >> On Tue, Dec 17, 2013 at 10:15:25AM +0100, Peter Lieven wrote: ... >>> +if (nfs_pwrite_async(client->context, client->fh, >>> + sector_num * BDRV_SECTOR_SIZE, >>> +

Re: [Qemu-devel] [PATCHv2] block: add native support for NFS

2013-12-17 Thread ronnie sahlberg
On Tue, Dec 17, 2013 at 9:03 AM, Peter Lieven wrote: > On 17.12.2013 17:47, Stefan Hajnoczi wrote: ... >> Which NFS protocol versions are supported by current libnfs? > > Will check that out. Ronnie? > It uses NFS v3 only.

Re: [Qemu-devel] [PATCHv2] block: add native support for NFS

2013-12-17 Thread Peter Lieven
On 17.12.2013 17:47, Stefan Hajnoczi wrote: On Tue, Dec 17, 2013 at 10:15:25AM +0100, Peter Lieven wrote: This patch adds native support for accessing images on NFS shares without the requirement to actually mount the entire NFS share on the host. NFS Images can simply be specified by an url of

Re: [Qemu-devel] [PATCHv2] block: add native support for NFS

2013-12-17 Thread ronnie sahlberg
NFSTask Task is a very scsi-ish term. Maybe RPC is better ? NFSrpc ? On Tue, Dec 17, 2013 at 1:15 AM, Peter Lieven wrote: > This patch adds native support for accessing images on NFS shares without > the requirement to actually mount the entire NFS share on the host. > > NFS Images can simply

Re: [Qemu-devel] [PATCHv2] block: add native support for NFS

2013-12-17 Thread Stefan Hajnoczi
On Tue, Dec 17, 2013 at 10:15:25AM +0100, Peter Lieven wrote: > This patch adds native support for accessing images on NFS shares without > the requirement to actually mount the entire NFS share on the host. > > NFS Images can simply be specified by an url of the form: > nfs: > > For example:

[Qemu-devel] [PATCHv2] block: add native support for NFS

2013-12-17 Thread Peter Lieven
This patch adds native support for accessing images on NFS shares without the requirement to actually mount the entire NFS share on the host. NFS Images can simply be specified by an url of the form: nfs: For example: qemu-img create -f qcow2 nfs://10.0.0.1/qemu-images/test.qcow2 You need li