Re: [Qemu-devel] [Qemu-arm] [PATCH v2 18/23] target/arm: Move CPU state dumping routines to helper.c

2019-06-17 Thread Peter Maydell
On Mon, 17 Jun 2019 at 15:41, Alex Bennée wrote: > Hmm so helper is a mix of non-TCG and TCG bits whereas helper-a64.c is > basically just TCG helpers. It makes me wonder if we are breaking a > convention here as helper.c is traditionally only TCG helpers. The original convention was: *

Re: [Qemu-devel] [Qemu-arm] [PATCH v2 18/23] target/arm: Move CPU state dumping routines to helper.c

2019-06-17 Thread Alex Bennée
Philippe Mathieu-Daudé writes: > From: Samuel Ortiz > > They're not TCG specific and should be living the generic helper file > instead. > > Signed-off-by: Samuel Ortiz > Reviewed-by: Robert Bradford > [PMD: Rebased] > Signed-off-by: Philippe Mathieu-Daudé > --- > target/arm/helper.c

Re: [Qemu-devel] [Qemu-arm] [PATCH v2 18/23] target/arm: Move CPU state dumping routines to helper.c

2019-06-17 Thread Philippe Mathieu-Daudé
On 6/17/19 4:41 PM, Alex Bennée wrote: > > Philippe Mathieu-Daudé writes: > >> From: Samuel Ortiz >> >> They're not TCG specific and should be living the generic helper file >> instead. >> >> Signed-off-by: Samuel Ortiz >> Reviewed-by: Robert Bradford >> [PMD: Rebased] >> Signed-off-by: