Re: [RFC v4 01/11] build: Implement logic for sharing cross-building config files

Yeqi Fu writes: > Signed-off-by: Yeqi Fu > --- > configure | 57 +-- > 1 file changed, 34 insertions(+), 23 deletions(-) > > diff --git a/configure b/configure > index 2b41c49c0d..a076583141 100755 > --- a/configure > +++ b/configure > >

Re: [RFC v4 01/11] build: Implement logic for sharing cross-building config files

Alex Bennée writes: > Yeqi Fu writes: > >> Signed-off-by: Yeqi Fu >> --- >> configure | 57 +-- >> 1 file changed, 34 insertions(+), 23 deletions(-) >> >> diff --git a/configure b/configure >> index 2b41c49c0d..a076583141 100755 >> ---

Re: [RFC v4 01/11] build: Implement logic for sharing cross-building config files

Yeqi Fu writes: > Signed-off-by: Yeqi Fu > --- > configure | 57 +-- > 1 file changed, 34 insertions(+), 23 deletions(-) > > diff --git a/configure b/configure > index 2b41c49c0d..a076583141 100755 > --- a/configure > +++ b/configure > @@

Re: [RFC v4 01/11] build: Implement logic for sharing cross-building config files

This patch needs a detailed commit message, since it's not obvious why these changes are made at all. It'd also be helpful for reviewing. General style comment for shell scripts: Always put curly braces around variables even if they are unnecessary. a $source_path could become

[RFC v4 01/11] build: Implement logic for sharing cross-building config files

Signed-off-by: Yeqi Fu --- configure | 57 +-- 1 file changed, 34 insertions(+), 23 deletions(-) diff --git a/configure b/configure index 2b41c49c0d..a076583141 100755 --- a/configure +++ b/configure @@ -1751,56 +1751,67 @@ if test