Re: [for-5.0 PATCH] ppc: Make PPCVirtualHypervisor an incomplete type

2019-12-10 Thread Markus Armbruster
Philippe Mathieu-Daudé writes: > On 12/9/19 2:28 PM, Greg Kurz wrote: >> PPCVirtualHypervisor is an interface instance. It should never be >> dereferenced. Drop the dummy type definition for extra safety, which >> is the common practice with QOM interfaces. > > This "common practice" is also refe

Re: [for-5.0 PATCH] ppc: Make PPCVirtualHypervisor an incomplete type

2019-12-09 Thread David Gibson
On Mon, Dec 09, 2019 at 02:28:00PM +0100, Greg Kurz wrote: > PPCVirtualHypervisor is an interface instance. It should never be > dereferenced. Drop the dummy type definition for extra safety, which > is the common practice with QOM interfaces. > > Signed-off-by: Greg Kurz Applied to ppc-for-5.0.

Re: [for-5.0 PATCH] ppc: Make PPCVirtualHypervisor an incomplete type

2019-12-09 Thread Greg Kurz
On Mon, 9 Dec 2019 16:42:39 + Peter Maydell wrote: > On Mon, 9 Dec 2019 at 16:28, Greg Kurz wrote: > > > > On Mon, 9 Dec 2019 15:02:38 +0100 > > Philippe Mathieu-Daudé wrote: > > > > > On 12/9/19 2:28 PM, Greg Kurz wrote: > > > > PPCVirtualHypervisor is an interface instance. It should neve

Re: [for-5.0 PATCH] ppc: Make PPCVirtualHypervisor an incomplete type

2019-12-09 Thread no-reply
Patchew URL: https://patchew.org/QEMU/157589808041.21182.18121655959115011353.st...@bahia.lan/ Hi, This series failed the docker-mingw@fedora build test. Please find the testing commands and their output below. If you have Docker installed, you can probably reproduce it locally. === TEST SCR

Re: [for-5.0 PATCH] ppc: Make PPCVirtualHypervisor an incomplete type

2019-12-09 Thread no-reply
Patchew URL: https://patchew.org/QEMU/157589808041.21182.18121655959115011353.st...@bahia.lan/ Hi, This series failed the docker-quick@centos7 build test. Please find the testing commands and their output below. If you have Docker installed, you can probably reproduce it locally. === TEST SC

Re: [for-5.0 PATCH] ppc: Make PPCVirtualHypervisor an incomplete type

2019-12-09 Thread Peter Maydell
On Mon, 9 Dec 2019 at 16:28, Greg Kurz wrote: > > On Mon, 9 Dec 2019 15:02:38 +0100 > Philippe Mathieu-Daudé wrote: > > > On 12/9/19 2:28 PM, Greg Kurz wrote: > > > PPCVirtualHypervisor is an interface instance. It should never be > > > dereferenced. Drop the dummy type definition for extra safet

Re: [for-5.0 PATCH] ppc: Make PPCVirtualHypervisor an incomplete type

2019-12-09 Thread Greg Kurz
On Mon, 9 Dec 2019 15:02:38 +0100 Philippe Mathieu-Daudé wrote: > On 12/9/19 2:28 PM, Greg Kurz wrote: > > PPCVirtualHypervisor is an interface instance. It should never be > > dereferenced. Drop the dummy type definition for extra safety, which > > is the common practice with QOM interfaces. >

Re: [for-5.0 PATCH] ppc: Make PPCVirtualHypervisor an incomplete type

2019-12-09 Thread Philippe Mathieu-Daudé
On 12/9/19 2:28 PM, Greg Kurz wrote: PPCVirtualHypervisor is an interface instance. It should never be dereferenced. Drop the dummy type definition for extra safety, which is the common practice with QOM interfaces. This "common practice" is also referenced in commit 00ed3da9b5: xics: Mino

[for-5.0 PATCH] ppc: Make PPCVirtualHypervisor an incomplete type

2019-12-09 Thread Greg Kurz
PPCVirtualHypervisor is an interface instance. It should never be dereferenced. Drop the dummy type definition for extra safety, which is the common practice with QOM interfaces. Signed-off-by: Greg Kurz --- target/ppc/cpu.h |4 1 file changed, 4 deletions(-) diff --git a/target/ppc/cp