[Qemu-devel] Re: [PATCH] mips-dis: Add missing static attributes

2010-05-09 Thread Blue Swirl
Thanks, applied. On 5/8/10, Stefan Weil w...@mail.berlios.de wrote: mips_abi_choices and mips_arch_choices are only used locally. Signed-off-by: Stefan Weil w...@mail.berlios.de --- mips-dis.c |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/mips-dis.c

[Qemu-devel] Re: [PATCH 1/2] Pad iommu with an empty slot (necessary for SunOS 4.1.4)

2010-05-09 Thread Blue Swirl
On 5/8/10, Artyom Tarasenko atar4q...@googlemail.com wrote: On the real hardware (SS-5, LX) the MMU is not padded, but aliased. Software shouldn't use aliased addresses, neither should it crash when it uses (on the real hardware it wouldn't). Using empty_slot instead of aliasing can help

[Qemu-devel] Re: [PATCH 2/2] reformatted SS-5 and LX definitions

2010-05-09 Thread Blue Swirl
On 5/8/10, Artyom Tarasenko atar4q...@googlemail.com wrote: --- hw/sun4m.c | 66 ++-- 1 files changed, 33 insertions(+), 33 deletions(-) In general, formatting changes cause git blame information loss so those are not appreciated

[Qemu-devel] Re: vmstate: Useless post_save?

2010-05-09 Thread Juan Quintela
Jan Kiszka jan.kis...@web.de wrote: Hi all, I wondered why we have the post_save callback in vmstate. Conceptually, it made no sense to me. So I grep'ed for its users - and found exactly one: tmp105. As suspected, only strange code was found: static void tmp105_post_save(void *opaque) {

[Qemu-devel] Re: [PATCH 1/2] Pad iommu with an empty slot (necessary for SunOS 4.1.4)

2010-05-09 Thread Artyom Tarasenko
2010/5/9 Blue Swirl blauwir...@gmail.com: On 5/8/10, Artyom Tarasenko atar4q...@googlemail.com wrote: On the real hardware (SS-5, LX) the MMU is not padded, but aliased.  Software shouldn't use aliased addresses, neither should it crash  when it uses (on the real hardware it wouldn't). Using

[Qemu-devel] Re: [PATCH 1/2] Pad iommu with an empty slot (necessary for SunOS 4.1.4)

2010-05-09 Thread Blue Swirl
On 5/9/10, Artyom Tarasenko atar4q...@googlemail.com wrote: 2010/5/9 Blue Swirl blauwir...@gmail.com: On 5/8/10, Artyom Tarasenko atar4q...@googlemail.com wrote: On the real hardware (SS-5, LX) the MMU is not padded, but aliased. Software shouldn't use aliased addresses, neither should

Re: [Qemu-devel] [RFC][MIPS][PATCH 1/6] Initial support of bonito north bridge used by fulong mini pc

2010-05-09 Thread Stefan Weil
Am 09.05.2010 04:00, schrieb chen huacai: This patch add initial support of bonito north bridge used by fulong mini pc Signed-off-by: Huacai Chenzltjiang...@gmail.com - diff --git a/Makefile.target b/Makefile.target index c092900..fc4c59f 100644 --- a/Makefile.target +++ b/Makefile.target

Re: [Qemu-devel] [RFC][MIPS][PATCH 1/6] Initial support of bonito north bridge used by fulong mini pc

2010-05-09 Thread Stefan Weil
Am 09.05.2010 04:00, schrieb chen huacai: This patch add initial support of bonito north bridge used by fulong mini pc Signed-off-by: Huacai Chenzltjiang...@gmail.com ... + +} BonitoState; + +BonitoState * bonito_state; Add static attribute? With DEBUG enabled, I get a lot of

[Qemu-devel] Re: [PATCH] vdi: Fix image opening and creation for odd disk sizes

2010-05-09 Thread Stefan Weil
Am 07.05.2010 13:55, schrieb François Revol: Le Fri, 07 May 2010 09:55:23 +0200, Kevin Wolf a écrit : Am 06.05.2010 20:29, schrieb Stefan Weil: This patch fixes a regression introduced by commit 95a2f9bc588c3f83375d87b0a9394f89a1bcfada. The fix is based on a patch from Kevin Wolf. Here his

Re: [Qemu-devel] [RFC][MIPS][PATCH 1/6] Initial support of bonito north bridge used by fulong mini pc

2010-05-09 Thread chen huacai
 obj-mips-y += mips_addr.o mips_timer.o mips_int.o  obj-mips-y += dma.o vga.o i8259.o  obj-mips-y += g364fb.o jazz_led.o -obj-mips-y += gt64xxx.o pckbd.o mc146818rtc.o +obj-mips-y += gt64xxx.o bonito.o pckbd.o mc146818rtc.o Is fulong 64 bit only? Maybe it would be better to add a new

[Qemu-devel] [PATCH] Fix overflow in i440fx_init()

2010-05-09 Thread Avi Kivity
The ram_size parameter can be larger than an int, so it may be truncated. Fix by using the correct type. Signed-off-by: Avi Kivity a...@redhat.com --- hw/pc.h |2 +- hw/piix_pci.c |2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/hw/pc.h b/hw/pc.h index

[Qemu-devel] Re: [PATCH] fix migration with large mem

2010-05-09 Thread Izik Eidus
On Tue, 13 Apr 2010 12:33:18 +0300 Izik Eidus iei...@redhat.com wrote: From f881b371e08760a67bf1f5b992a586c3de600f7a Mon Sep 17 00:00:00 2001 From: Izik Eidus iei...@redhat.com Date: Tue, 13 Apr 2010 12:24:57 +0300 Subject: [PATCH] fix migration with large mem Anyone ??? In cases of

[Qemu-devel] Re: [PATCH][RESEND] exec: optimize lduw_phys and stw_phys

2010-05-09 Thread Bernhard Kohl
Am 06.05.2010 15:55, schrieb Bernhard Kohl: Implementation of the optimized code for these two functions. This is necessary for virtio which reads and writes VirtQueue index fields using these functions. The assumption is that this are atomic operations, which is not the case, if the memcpy()

[Qemu-devel] Re: [PATCH] fix migration with large mem

2010-05-09 Thread Paolo Bonzini
On 05/09/2010 02:29 PM, Izik Eidus wrote: On Tue, 13 Apr 2010 12:33:18 +0300 Izik Eidusiei...@redhat.com wrote: From f881b371e08760a67bf1f5b992a586c3de600f7a Mon Sep 17 00:00:00 2001 From: Izik Eidusiei...@redhat.com Date: Tue, 13 Apr 2010 12:24:57 +0300 Subject: [PATCH] fix migration with

[Qemu-devel] Re: [PATCH] fix migration with large mem

2010-05-09 Thread Avi Kivity
On 05/09/2010 04:57 PM, Paolo Bonzini wrote: On 05/09/2010 02:29 PM, Izik Eidus wrote: On Tue, 13 Apr 2010 12:33:18 +0300 Izik Eidusiei...@redhat.com wrote: From f881b371e08760a67bf1f5b992a586c3de600f7a Mon Sep 17 00:00:00 2001 From: Izik Eidusiei...@redhat.com Date: Tue, 13 Apr 2010

[Qemu-devel] [PATCH] Support for booting from virtio disks

2010-05-09 Thread Gleb Natapov
This patch adds native support for booting from virtio disks to Seabios. Signed-off-by: Gleb Natapov g...@redhat.com diff --git a/Makefile b/Makefile index 327a1bf..d0b8881 100644 --- a/Makefile +++ b/Makefile @@ -14,7 +14,8 @@ OUT=out/ SRCBOTH=misc.c pmm.c stacks.c output.c util.c block.c

[Qemu-devel] AHCI support integration

2010-05-09 Thread Sebastian Herbszt
The ICH6 AHCI implementation submitted by Chong is an all-in-one attempt (ahci.c). It includes all needed parts of the ICH6, AHCI, SATA and ATA specification. The code in hw/ide/* on the other hand is split (or could be split) into smaller parts like port based and bus master access, IDE and

[Qemu-devel] [PATCH master+0.12] pci: irq_state vmstate breakage

2010-05-09 Thread Michael S. Tsirkin
Code for saving irq_state got vm_state macros wrong, passing in the wrong parameter. As a result, we both saved a wrong value and restored it to a wrong offset. This leads to device and bus irq counts getting out of sync, which in turn leads to interrupts getting lost or never cleared, such as

[Qemu-devel] Re: [SeaBIOS] [PATCH] Support for booting from virtio disks

2010-05-09 Thread Stefan Hajnoczi
On Sun, May 9, 2010 at 4:23 PM, Gleb Natapov g...@redhat.com wrote: Neat! I believe SeaBIOS will see virtio-blk devices as harddisks and not attempt to boot ISOs? Many existing OS installers probably cannot boot from virtio-blk, but in the longer term folks might like to get rid of ATAPI CD-ROMs

[Qemu-devel] [PATCH] virtio: invoke set_features on load

2010-05-09 Thread Michael S. Tsirkin
After migration, vhost was not getting features acked because set_features callback was never invoked. The fix is just to invoke that callback. Reported-by: David L Stevens dlstev...@us.ibm.com Signed-off-by: Michael S. Tsirkin m...@redhat.com --- David, a tested-by tag would be appreciated.

[Qemu-devel] Re: [SeaBIOS] [PATCH] Support for booting from virtio disks

2010-05-09 Thread Gleb Natapov
On Sun, May 09, 2010 at 05:31:16PM +0100, Stefan Hajnoczi wrote: On Sun, May 9, 2010 at 4:23 PM, Gleb Natapov g...@redhat.com wrote: Neat! I believe SeaBIOS will see virtio-blk devices as harddisks and not attempt to boot ISOs? Many existing OS installers probably cannot boot from

[Qemu-devel] Re: Webcam solution for QEMU

2010-05-09 Thread Arnon Gilboa
Hello Albert, First of all, I have done nothing in the qemu project for more than two years now. My last contribution to qemu were some usb 1.1 uhci/ohci patches for very basic support of webcams and other isochronous devices (accepted), and a preliminary patch for usb 2.0 ehci (rejected due

Re: [Qemu-devel] [RFC][MIPS][PATCH 1/6] Initial support of bonito north bridge used by fulong mini pc

2010-05-09 Thread Stefan Weil
Am 09.05.2010 13:25, schrieb chen huacai: obj-mips-y += mips_addr.o mips_timer.o mips_int.o obj-mips-y += dma.o vga.o i8259.o obj-mips-y += g364fb.o jazz_led.o -obj-mips-y += gt64xxx.o pckbd.o mc146818rtc.o +obj-mips-y += gt64xxx.o bonito.o pckbd.o mc146818rtc.o Is fulong 64 bit only?

[Qemu-devel] Re: AHCI support integration

2010-05-09 Thread Alexander Graf
Sebastian Herbszt wrote: The ICH6 AHCI implementation submitted by Chong is an all-in-one attempt (ahci.c). It includes all needed parts of the ICH6, AHCI, SATA and ATA specification. The code in hw/ide/* on the other hand is split (or could be split) into smaller parts like port based and

[Qemu-devel] Re: [RFC] [PATCH] add ahci support into qemu

2010-05-09 Thread Alexander Graf
Hi Chong, 乔崇 wrote: Alexander Graf 写道: Hi Chong (or Qiao? Which one is your first name?), Thanks your advice,My first name is Chong. Upfront - please don't top post. Top posting is when you write your reply at the top of the mail. This is considered bad style on most open source

Re: [Qemu-devel] Re: QEMU-KVM and video performance

2010-05-09 Thread Gerhard Wiesinger
On Thu, 22 Apr 2010, Avi Kivity wrote: On 04/22/2010 09:04 AM, Gerhard Wiesinger wrote: On Wed, 21 Apr 2010, Avi Kivity wrote: On 04/21/2010 09:50 PM, Gerhard Wiesinger wrote: I don't think changing VGA window is a problem because there are 500.000-1Mio changes/s possible. 1MB/s, 500k-1M

[Qemu-devel] Re: sparc64 lazy conditional codes evaluation

2010-05-09 Thread Blue Swirl
On 5/8/10, Igor Kovalenko igor.v.kovale...@gmail.com wrote: On Thu, May 6, 2010 at 10:51 PM, Blue Swirl blauwir...@gmail.com wrote: On 5/5/10, Igor Kovalenko igor.v.kovale...@gmail.com wrote: On Wed, May 5, 2010 at 12:21 AM, Blue Swirl blauwir...@gmail.com wrote: On 5/3/10, Igor

[Qemu-devel] Re: [PATCH RFC] virtio: put last seen used index into ring itself

2010-05-09 Thread Michael S. Tsirkin
On Fri, May 07, 2010 at 01:03:28PM +0930, Rusty Russell wrote: On Thu, 6 May 2010 03:49:46 pm Michael S. Tsirkin wrote: Now, I also added an mb() in guest between read and write so that last used index write can not get ahead of used index read. It does feel good to have it there, but I can

[Qemu-devel] Re: [PATCH master+0.12] pci: irq_state vmstate breakage

2010-05-09 Thread Michael S. Tsirkin
On Sun, May 09, 2010 at 08:07:14PM +0200, Juan Quintela wrote: Michael S. Tsirkin m...@redhat.com wrote: Code for saving irq_state got vm_state macros wrong, passing in the wrong parameter. As a result, we both saved a wrong value and restored it to a wrong offset. This leads to

[Qemu-devel] Re: [PATCH 1/2] Pad iommu with an empty slot (necessary for SunOS 4.1.4)

2010-05-09 Thread Artyom Tarasenko
2010/5/9 Blue Swirl blauwir...@gmail.com: On 5/9/10, Artyom Tarasenko atar4q...@googlemail.com wrote: 2010/5/9 Blue Swirl blauwir...@gmail.com: On 5/8/10, Artyom Tarasenko atar4q...@googlemail.com wrote:   On the real hardware (SS-5, LX) the MMU is not padded, but aliased.    Software

[Qemu-devel] Qemu arm emulator reports Unsupported syscall and Unsupported ioctl errors

2010-05-09 Thread Yang, Yi Y
Hi, When I use qemu-arm-static (0.12.3) on my x86 machine (Fedora 10) inside of ARM chroot environment, it reported Unsupported syscall on running losetup -a, it reported Unsupported ioctl on running kpartx -a /dev/loop0, anybody encountered such an issue? How to fix it? Thanks in advance.

[Qemu-devel] how could I see boot message in qemu without -nographic

2010-05-09 Thread daniel tian
hi, all: I just finished a mips qemu with framebuffer graphic display. graphics card is not based on Cirrus. I defined a virtual graphic card with features following: 1. support only 32bpp (true color)framebuffer. 2. display resolution only support width X height = 640 X 480. 3. with only register

Re: [Qemu-devel] Re: Webcam solution for QEMU

2010-05-09 Thread Natalia Portillo
Hello Arnon, Hola Albert, Wouldn't be easier to implement a custom video capture device? You can always emulate a simple one, like (to say) OV511 webcam, and feed that emulated device with video taken from any V4L2/DirectShow/BDA supported device (real host webcam). I think this way, timing

[Qemu-devel] Re: ehci fixes

2010-05-09 Thread David S. Ahern
On 05/09/2010 08:32 PM, Vincent Palatin wrote: Dear developers, While using the EHCI patchset, I have found 2 minor issues. So, I send in this email thread 2 fix proposals. Changes look good to me. Are you looking at any particular device or EHCI in general? David Those patches

[Qemu-devel] Re: [PATCH] Support for booting from virtio disks

2010-05-09 Thread Kevin O'Connor
On Sun, May 09, 2010 at 06:23:49PM +0300, Gleb Natapov wrote: This patch adds native support for booting from virtio disks to Seabios. Thanks Gleb - it looks good to me. One thing I noticed - the virtio-pci.c file is missing a license statement and virtio-ring.c states GPL instead of LGPL.

[Qemu-devel] Re: [SeaBIOS] [PATCH] smbios: avoid counting io hole as ram

2010-05-09 Thread Kevin O'Connor
On Fri, May 07, 2010 at 01:38:55PM -0600, Alex Williamson wrote: Avoid counting the io hole as part of ram, a vm started with 4G should report 4G in smbios, not 4.5G. Signed-off-by: Alex Williamson alex.william...@redhat.com Looks okay to me. If there are no other comments, I'll commit in

Re: [Qemu-devel] [RFC][MIPS][PATCH 1/6] Initial support of bonito north bridge used by fulong mini pc

2010-05-09 Thread yajin
'long long unsigned int', but argument 2 has type 'target_phys_addr_t' /home/stefan/src/qemu/hw/bonito.c: In function 'bonito_spciconf_readw': I think TARGET_FMT_plx should be used instead of using %llx to avoid this warning. yajin http://vm-kernel.org 2010/5/9 Stefan Weil

[Qemu-devel] Re: [SeaBIOS] [PATCH] smbios: avoid counting io hole as ram

2010-05-09 Thread Gleb Natapov
On Sun, May 09, 2010 at 11:03:37PM -0400, Kevin O'Connor wrote: On Fri, May 07, 2010 at 01:38:55PM -0600, Alex Williamson wrote: Avoid counting the io hole as part of ram, a vm started with 4G should report 4G in smbios, not 4.5G. Signed-off-by: Alex Williamson alex.william...@redhat.com