Re: [Qemu-devel] [PATCH] sh4: Fix serial line access for Linux kernels later than 3.2

2013-09-29 Thread Paolo Bonzini
sh4 is ~orphan so nobody should complain if qemu-trivial picks this up as well. Paolo Il 14/09/2013 06:04, Guenter Roeck ha scritto: On 09/08/2013 12:39 AM, Guenter Roeck wrote: With Linux kernel version 3.3 or later, qemu fails with the following message: sh_serial: unsupported read from

Re: [Qemu-devel] [Qemu-trivial] [PATCH v3 1/2] tests: Fix schema parser test for in-tree build

2013-09-29 Thread Michael Tokarev
24.09.2013 11:43, arm...@redhat.com wrote: From: Markus Armbruster arm...@redhat.com Commit 4f193e3 added the test, but screwed up in-tree builds (SRCDIR=.): the tests's output overwrites the expected output, and is thus compared to itself. [] .PHONY: $(patsubst %, check-%,

Re: [Qemu-devel] [Qemu-trivial] [PATCH v3 2/2] tests: Update .gitignore for test-int128 and test-bitops

2013-09-29 Thread Michael Tokarev
Thanks, applied to the trivial patches queue. /mjt

Re: [Qemu-devel] [Qemu-trivial] [PATCH] exec: cleanup DEBUG_SUBPAGE

2013-09-29 Thread Michael Tokarev
27.09.2013 11:28, Paolo Bonzini wrote: Michael, want to pick this up for -trivial? Reviewed-by: Paolo Bonzini pbonz...@redhat.com Il 27/09/2013 03:25, Amos Kong ha scritto: Touched some error after enabling DEBUG_SUBPAGE. Thanks, applied to the trivial patches queue. /mjt

Re: [Qemu-devel] [Qemu-trivial] [PATCH] block: Remove unused assignment (fixes warning from clang)

2013-09-29 Thread Michael Tokarev
28.09.2013 13:55, Stefan Weil wrote: blockdev.c:1929:13: warning: Value stored to 'ret' is never read ret = 0; ^ ~ Applied to the trivial patches queue. Signed-off-by: Stefan Weil s...@weilnetz.de --- blockdev.c |1 - 1 file changed, 1 deletion(-) diff

Re: [Qemu-devel] [Qemu-trivial] [PATCH] target-i386: Fix compiler warning (integer constant is too large)

2013-09-29 Thread Michael Tokarev
29.09.2013 19:55, Stefan Weil wrote: From buildbot default_i386_rhel61: CCi386-softmmu/target-i386/arch_memory_mapping.o target-i386/arch_memory_mapping.c: In function 'walk_pde': target-i386/arch_memory_mapping.c:110: warning: integer constant is too large for 'long' type Thanks,

Re: [Qemu-devel] [Qemu-trivial] [PATCH] hw/alpha: Fix compiler warning (integer constant is too large)

2013-09-29 Thread Michael Tokarev
29.09.2013 19:51, Stefan Weil wrote: From buildbot default_i386_rhel61: CCalpha-softmmu/hw/alpha/typhoon.o hw/alpha/typhoon.c: In function 'typhoon_translate_iommu': hw/alpha/typhoon.c:703: warning: integer constant is too large for 'long' type hw/alpha/typhoon.c:703: warning: integer

Re: [Qemu-devel] [Qemu-trivial] [PATCH] sh4: Fix serial line access for Linux kernels later than 3.2

2013-09-29 Thread Michael Tokarev
29.09.2013 23:12, Paolo Bonzini wrote: sh4 is ~orphan so nobody should complain if qemu-trivial picks this up as well. Paolo Il 14/09/2013 06:04, Guenter Roeck ha scritto: On 09/08/2013 12:39 AM, Guenter Roeck wrote: With Linux kernel version 3.3 or later, qemu fails with the following

Re: [Qemu-devel] [Qemu-trivial] [PATCH] migration: Fix compiler warning ('caps' may be used uninitialized)

2013-09-29 Thread Michael Tokarev
29.09.2013 19:41, Stefan Weil wrote: The QEMU buildbot default_i386_debian_6_0 shows this warning: CCmigration.o migration.c: In function 'qmp_query_migrate_capabilities': migration.c:149: warning: 'caps' may be used uninitialized in this function Gah, how disgusting. The code is

Re: [Qemu-devel] [Qemu-trivial] [PATCH] pci-ohci: Add missing 'break' in ohci_service_td

2013-09-29 Thread Michael Tokarev
22.09.2013 00:26, Ján Veselý wrote: Device communication errors need to be reported to driver. Add a debug message while at it. Signed-off-by: Jan Vesely jano.ves...@gmail.com --- hw/usb/hcd-ohci.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/hw/usb/hcd-ohci.c b/hw/usb/hcd-ohci.c

Re: [Qemu-devel] [Qemu-trivial] [PATCH] block: Remove unused assignment (fixes warning from clang)

2013-09-29 Thread Stefan Weil
Am 29.09.2013 21:44, schrieb Michael Tokarev: 28.09.2013 13:55, Stefan Weil wrote: [...] diff --git a/blockdev.c b/blockdev.c index 8aa66a9..8c83f6f 100644 --- a/blockdev.c +++ b/blockdev.c @@ -1926,7 +1926,6 @@ void qmp_drive_mirror(const char *device, const char *target, } else {

Re: [Qemu-devel] [Qemu-trivial] [PATCH] migration: Fix compiler warning ('caps' may be used uninitialized)

2013-09-29 Thread Stefan Weil
Am 29.09.2013 22:13, schrieb Michael Tokarev: 29.09.2013 19:41, Stefan Weil wrote: The QEMU buildbot default_i386_debian_6_0 shows this warning: CCmigration.o migration.c: In function 'qmp_query_migrate_capabilities': migration.c:149: warning: 'caps' may be used uninitialized in

[Qemu-devel] drive-backup locks VM if target has issues?

2013-09-29 Thread Wolfgang Richter
I wanted to explore overhead with the new drive-backup command and I noticed if I set the target to something like '/dev/null' the guest VM starts having IO errors and loses write access to its root file system. Here is the qmp-shell command I'm using: drive-backup sync=none device=virtio0

[Qemu-devel] help me with qemu-img theory(snapshot and backing file)

2013-09-29 Thread yue-kvm
hi,all if there any documents about snapshot and backing file's theory. as we know vmware has composor which can upgrade images(top of backing chain ) by upgrading backing file so i think we can implement it anyway. now i need some infomations relevant to my idea. and hope qemu-img

Re: [Qemu-devel] [PATCH 03/17] blockdev: Introduce DriveInfo.enable_auto_del

2013-09-29 Thread Wenchao Xia
Reviewed-by: Wenchao Xia xiaw...@linux.vnet.ibm.com

Re: [Qemu-devel] KVM call for agenda for 2013-10-01

2013-09-29 Thread Michael S. Tsirkin
On Tue, Sep 24, 2013 at 04:09:56PM +0200, Juan Quintela wrote: Hi Please, send any topic that you are interested in covering. Last week I forgot to send the call for topics. We still have a topic there. Thanks, Juan. Agenda so far: - Talk about qemu reverse executing (1st

Re: [Qemu-devel] [PATCH 05/17] blockdev: Separate ID generation from DriveInfo creation

2013-09-29 Thread Wenchao Xia
Reviewed-by: Wenchao Xia xiaw...@linux.vnet.ibm.com

Re: [Qemu-devel] [PATCH v11 3/8] rule.mak: allow per object cflags and libs

2013-09-29 Thread Wenchao Xia
Some code are spent for nest case since the build system does not support subdir Makefile. It would be nice if qemu can change the build system like kernel's build system one day, then we can avoid these troubles. The code looks fine. Reviewed-by: Wenchao Xia xiaw...@linux.vnet.ibm.com

[Qemu-devel] [PULL 00/14] pc,pci,virtio fixes and cleanups

2013-09-29 Thread Michael S. Tsirkin
The following changes since commit 2d1fe1873a984d1c2c89ffa3d12949cafc718551: Merge remote-tracking branch 'pmaydell/tags/pull-target-arm-20130910' into staging (2013-09-11 14:46:52 -0500) are available in the git repository at: git://git.kernel.org/pub/scm/virt/kvm/mst/qemu.git

[Qemu-devel] [PULL 07/14] piix4: disable io on reset

2013-09-29 Thread Michael S. Tsirkin
io base register at 0x40 is cleared on reset, but io is not disabled until some other event happens to call pm_io_space_update. Invoke pm_io_space_update directly to make this consistent. Cc: qemu-sta...@nongnu.org Signed-off-by: Michael S. Tsirkin m...@redhat.com --- hw/acpi/piix4.c | 1 + 1

[Qemu-devel] [PULL 09/14] virtio-net: fix up HMP NIC info string on reset

2013-09-29 Thread Michael S. Tsirkin
When mac is updated on reset, info string has stale data. Fix it up. Signed-off-by: Michael S. Tsirkin m...@redhat.com --- hw/net/virtio-net.c | 1 + 1 file changed, 1 insertion(+) diff --git a/hw/net/virtio-net.c b/hw/net/virtio-net.c index dd41008..22dbd05 100644 --- a/hw/net/virtio-net.c +++

[Qemu-devel] [PULL 01/14] q35: make pci window address/size match guest cfg

2013-09-29 Thread Michael S. Tsirkin
For Q35, MMCFG address and size are guest configurable. Update w32 property to make it behave accordingly. Signed-off-by: Michael S. Tsirkin m...@redhat.com --- hw/pci-host/q35.c | 10 ++ 1 file changed, 10 insertions(+) diff --git a/hw/pci-host/q35.c b/hw/pci-host/q35.c index

[Qemu-devel] [PULL 03/14] range: add min/max operations on ranges

2013-09-29 Thread Michael S. Tsirkin
Signed-off-by: Michael S. Tsirkin m...@redhat.com --- include/qemu/range.h | 18 ++ 1 file changed, 18 insertions(+) diff --git a/include/qemu/range.h b/include/qemu/range.h index 4a0780d..aae9720 100644 --- a/include/qemu/range.h +++ b/include/qemu/range.h @@ -17,6 +17,24 @@

[Qemu-devel] [PULL 02/14] range: add Range to typedefs

2013-09-29 Thread Michael S. Tsirkin
will help simplify header dependencies. Signed-off-by: Michael S. Tsirkin m...@redhat.com --- include/qemu/range.h| 2 +- include/qemu/typedefs.h | 1 + 2 files changed, 2 insertions(+), 1 deletion(-) diff --git a/include/qemu/range.h b/include/qemu/range.h index b76cc0d..4a0780d 100644 ---

[Qemu-devel] [PULL 11/14] smbios: Convert to QemuOpts

2013-09-29 Thread Michael S. Tsirkin
From: Markus Armbruster arm...@redhat.com So that it can be set in config file for -readconfig. This tightens parsing of -smbios, and makes it more consistent with other options: unknown parameters are rejected, numbers with trailing junk are rejected, when a parameter is given multiple times,

[Qemu-devel] [PULL 05/14] q35: use 64 bit window programmed by guest

2013-09-29 Thread Michael S. Tsirkin
Detect the 64 bit window programmed by firmware and configure properties accordingly. Signed-off-by: Michael S. Tsirkin m...@redhat.com --- hw/pci-host/q35.c | 14 ++ 1 file changed, 10 insertions(+), 4 deletions(-) diff --git a/hw/pci-host/q35.c b/hw/pci-host/q35.c index

[Qemu-devel] [PULL 04/14] pci: add helper to retrieve the 64-bit range

2013-09-29 Thread Michael S. Tsirkin
Signed-off-by: Michael S. Tsirkin m...@redhat.com --- include/hw/pci/pci.h | 1 + hw/pci/pci.c | 50 ++ 2 files changed, 51 insertions(+) diff --git a/include/hw/pci/pci.h b/include/hw/pci/pci.h index 37979aa..4b90e5d 100644 ---

[Qemu-devel] [PULL 10/14] smbios: Normalize smbios_entry_add()'s error handling to exit(1)

2013-09-29 Thread Michael S. Tsirkin
From: Markus Armbruster arm...@redhat.com It exits on all error conditions but one, where it returns -1. Normalize, and return void. Signed-off-by: Markus Armbruster arm...@redhat.com Reviewed-by: Eric Blake ebl...@redhat.com Signed-off-by: Michael S. Tsirkin m...@redhat.com ---

[Qemu-devel] [PULL 06/14] piix: use 64 bit window programmed by guest

2013-09-29 Thread Michael S. Tsirkin
Detect the 64 bit window programmed by firmware and configure properties accordingly. Signed-off-by: Michael S. Tsirkin m...@redhat.com --- hw/pci-host/piix.c | 14 ++ 1 file changed, 10 insertions(+), 4 deletions(-) diff --git a/hw/pci-host/piix.c b/hw/pci-host/piix.c index

[Qemu-devel] [PULL 08/14] pci: remove explicit check to 64K ioport size

2013-09-29 Thread Michael S. Tsirkin
From: Hervé Poussineau hpous...@reactos.org This check is useless, as bigger addresses will be ignored when added to 'io' MemoryRegion, which has a size of 64K. However, some architectures don't use the 'io' MemoryRegion, like the alpha and versatile platforms. They create a PCI I/O region

[Qemu-devel] [PULL 13/14] smbios: Make multiple -smbios type= accumulate sanely

2013-09-29 Thread Michael S. Tsirkin
From: Markus Armbruster arm...@redhat.com Currently, -smbios type=T,NAME=VAL,... adds one field (T,NAME) with value VAL to fw_cfg for each unique NAME. If NAME occurs multiple times, the last one's VAL is used (before the QemuOpts conversion, the first one was used). Multiple -smbios can add

[Qemu-devel] [PULL 12/14] smbios: Improve diagnostics for conflicting entries

2013-09-29 Thread Michael S. Tsirkin
From: Markus Armbruster arm...@redhat.com We allow either tables or fields for the same type. Makes sense, because SeaBIOS uses fields only when no tables are present. We do this by searching the SMBIOS blob for a previously added table or field. Error messages look like this:

[Qemu-devel] [PULL 14/14] smbios: Factor out smbios_maybe_add_str()

2013-09-29 Thread Michael S. Tsirkin
From: Markus Armbruster arm...@redhat.com Signed-off-by: Markus Armbruster arm...@redhat.com Reviewed-by: Eric Blake ebl...@redhat.com Signed-off-by: Michael S. Tsirkin m...@redhat.com --- hw/i386/smbios.c | 61 +++- 1 file changed, 25

Re: [Qemu-devel] Virtio Polling Mode

2013-09-29 Thread Jason Wang
On 09/28/2013 02:56 AM, Hu Yaohui wrote: Hi All, I am wondering whether virtio has provided polling mode already. Instead of sending a event from guest to host through eventfd on guest side and inject an interrupt into guest on host side to notify each other? Could both sides keep polling the

[Qemu-devel] [PATCH v6 00/26] qemu: generate acpi tables for the guest

2013-09-29 Thread Michael S. Tsirkin
This code can also be found here: git://git.kernel.org/pub/scm/virt/kvm/mst/qemu.git acpi While this patch still uses info not available in QOM, I think it's reasonable to merge it and then refactor as QOM properties cover more ground. In particular, merging this patchset blocks other projects

[Qemu-devel] [PATCH v6 03/26] qom: cleanup struct Error references

2013-09-29 Thread Michael S. Tsirkin
now that a typedef for struct Error is available, use it in qom/object.h to match coding style rules. Reviewed-by: Paolo Bonzini pbonz...@redhat.com Signed-off-by: Michael S. Tsirkin m...@redhat.com --- include/qom/object.h | 51 +-- 1 file

[Qemu-devel] [PATCH v6 05/26] fw_cfg: interface to trigger callback on read

2013-09-29 Thread Michael S. Tsirkin
Signed-off-by: Michael S. Tsirkin m...@redhat.com --- include/hw/nvram/fw_cfg.h | 4 hw/nvram/fw_cfg.c | 33 - 2 files changed, 32 insertions(+), 5 deletions(-) diff --git a/include/hw/nvram/fw_cfg.h b/include/hw/nvram/fw_cfg.h index f60dd67..2ab0fc2

[Qemu-devel] [PATCH v6 01/26] qemu: add Error to typedefs

2013-09-29 Thread Michael S. Tsirkin
This is so qom headers can use it without pulling in extra headers. Reviewed-by: Paolo Bonzini pbonz...@redhat.com Signed-off-by: Michael S. Tsirkin m...@redhat.com --- include/qemu/typedefs.h | 1 + 1 file changed, 1 insertion(+) diff --git a/include/qemu/typedefs.h b/include/qemu/typedefs.h

[Qemu-devel] [PATCH v6 04/26] qom: add pointer to int property helpers

2013-09-29 Thread Michael S. Tsirkin
Make it easy to add read-only helpers for simple integer properties in memory. Reviewed-by: Paolo Bonzini pbonz...@redhat.com Signed-off-by: Michael S. Tsirkin m...@redhat.com --- include/qom/object.h | 21 ++ qom/object.c | 60

[Qemu-devel] [PATCH v6 02/26] qom: pull in qemu/typedefs

2013-09-29 Thread Michael S. Tsirkin
As usual so we can use typedefs without header dependencies. Reviewed-by: Paolo Bonzini pbonz...@redhat.com Signed-off-by: Michael S. Tsirkin m...@redhat.com --- include/qom/object.h | 1 + 1 file changed, 1 insertion(+) diff --git a/include/qom/object.h b/include/qom/object.h index

[Qemu-devel] [PATCH v6 06/26] loader: support for unmapped ROM blobs

2013-09-29 Thread Michael S. Tsirkin
Support ROM blobs not mapped into guest memory: same as ROM files really but use caller's buffer. Support incoking callback on access and return memory pointer making it easier for caller to update memory if necessary. Signed-off-by: Michael S. Tsirkin m...@redhat.com Reviewed-by: Laszlo Ersek

[Qemu-devel] [PATCH v6 09/26] q35: use macro for MCFG property name

2013-09-29 Thread Michael S. Tsirkin
Useful to make it accessible through QOM. Signed-off-by: Michael S. Tsirkin m...@redhat.com --- include/hw/pci/pcie_host.h | 2 ++ hw/pci-host/q35.c | 2 +- 2 files changed, 3 insertions(+), 1 deletion(-) diff --git a/include/hw/pci/pcie_host.h b/include/hw/pci/pcie_host.h index

[Qemu-devel] [PATCH v6 07/26] pcie_host: expose UNMAPPED macro

2013-09-29 Thread Michael S. Tsirkin
Make it possible to test unmapped status through QMP. Signed-off-by: Michael S. Tsirkin m...@redhat.com --- include/hw/pci/pcie_host.h | 3 +++ hw/pci/pcie_host.c | 3 --- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/include/hw/pci/pcie_host.h

[Qemu-devel] [PATCH v6 10/26] q35: expose mmcfg size as a property

2013-09-29 Thread Michael S. Tsirkin
Address is already exposed, expose size for symmetry. Signed-off-by: Michael S. Tsirkin m...@redhat.com --- include/hw/pci/pcie_host.h | 1 + hw/pci-host/q35.c | 14 ++ 2 files changed, 15 insertions(+) diff --git a/include/hw/pci/pcie_host.h b/include/hw/pci/pcie_host.h

[Qemu-devel] [PATCH v6 15/26] loader: use file path size from fw_cfg.h

2013-09-29 Thread Michael S. Tsirkin
Avoid a bit of code duplication, make max file path constant reusable. Suggested-by: Laszlo Ersek ler...@redhat.com Signed-off-by: Michael S. Tsirkin m...@redhat.com --- include/hw/nvram/fw_cfg.h | 4 +++- hw/core/loader.c | 2 +- 2 files changed, 4 insertions(+), 2 deletions(-) diff

[Qemu-devel] [PATCH v6 17/26] loader: allow adding ROMs in done callbacks

2013-09-29 Thread Michael S. Tsirkin
Don't abort if machine done callbacks add ROMs. Signed-off-by: Michael S. Tsirkin m...@redhat.com --- include/hw/loader.h | 1 + hw/core/loader.c| 6 +- vl.c| 3 +++ 3 files changed, 9 insertions(+), 1 deletion(-) diff --git a/include/hw/loader.h b/include/hw/loader.h

[Qemu-devel] [PATCH v6 08/26] pcie_host: expose address format

2013-09-29 Thread Michael S. Tsirkin
Callers pass in the address so it's helpful for them to be able to decode it. Signed-off-by: Michael S. Tsirkin m...@redhat.com --- include/hw/pci/pcie_host.h | 21 + hw/pci/pcie_host.c | 21 - 2 files changed, 21 insertions(+), 21 deletions(-)

[Qemu-devel] [PATCH v6 12/26] acpi: add rules to compile ASL source

2013-09-29 Thread Michael S. Tsirkin
Detect presence of IASL compiler and use it to process ASL source. If not there, use pre-compiled files in-tree. Add script to update the in-tree files. Note: distros are known to silently update iasl so detect correct iasl flags for the installed version on each run as opposed to at configure

[Qemu-devel] [PATCH v6 18/26] i386: define pc guest info

2013-09-29 Thread Michael S. Tsirkin
This defines a structure that will be used to fill in acpi tables where relevant properties are not yet available using QOM. Signed-off-by: Michael S. Tsirkin m...@redhat.com Reviewed-by: Laszlo Ersek ler...@redhat.com --- include/hw/i386/pc.h | 10 ++ hw/i386/pc.c | 35

[Qemu-devel] [PATCH v6 25/26] ssdt: fix PBLK length

2013-09-29 Thread Michael S. Tsirkin
We don't really support CPU throttling, so supply 0 PBLK length. Since this is the first patch that makes the ACPI tables different from the builtin ones in seabios, this patch is kept separate to allow easier bisecting in case of problems. Signed-off-by: Michael S. Tsirkin m...@redhat.com ---

[Qemu-devel] [PATCH v6 16/26] i386: add bios linker/loader

2013-09-29 Thread Michael S. Tsirkin
This adds a dynamic bios linker/loader. This will be used by acpi table generation code to: - load each table in the appropriate memory segment - link tables to each other - fix up checksums after said linking Signed-off-by: Michael S. Tsirkin m...@redhat.com ---

[Qemu-devel] [PATCH v6 23/26] hpet: add API to find it

2013-09-29 Thread Michael S. Tsirkin
Add API to find HPET using QOM. Signed-off-by: Michael S. Tsirkin m...@redhat.com --- include/hw/timer/hpet.h | 2 ++ hw/timer/hpet.c | 5 + 2 files changed, 7 insertions(+) diff --git a/include/hw/timer/hpet.h b/include/hw/timer/hpet.h index 757f79f..ab44bd3 100644 ---

[Qemu-devel] [PATCH v6 19/26] acpi/piix: add macros for acpi property names

2013-09-29 Thread Michael S. Tsirkin
Signed-off-by: Michael S. Tsirkin m...@redhat.com --- include/hw/i386/pc.h | 10 ++ hw/acpi/piix4.c | 6 +++--- 2 files changed, 13 insertions(+), 3 deletions(-) diff --git a/include/hw/i386/pc.h b/include/hw/i386/pc.h index 7a343f8..f966cef 100644 --- a/include/hw/i386/pc.h +++

[Qemu-devel] [PATCH v6 20/26] piix: APIs for pc guest info

2013-09-29 Thread Michael S. Tsirkin
This adds APIs that will be used to fill in guest acpi tables. Some required information is still lacking in QOM, so we fall back on lookups by type and returning explicit types. Signed-off-by: Michael S. Tsirkin m...@redhat.com --- include/hw/acpi/piix4.h | 8 include/hw/i386/pc.h

[Qemu-devel] [PATCH v6 22/26] pvpanic: add API to access io port

2013-09-29 Thread Michael S. Tsirkin
Add API to find pvpanic device and get its io port. Will be used to fill in guest info structure. Signed-off-by: Michael S. Tsirkin m...@redhat.com --- include/hw/i386/pc.h | 1 + hw/misc/pvpanic.c| 13 - 2 files changed, 13 insertions(+), 1 deletion(-) diff --git

[Qemu-devel] [PATCH v6 26/26] ssdt-proc: update generated file

2013-09-29 Thread Michael S. Tsirkin
Update generated ssdt proc hex file (used for systems lacking IASL) after P_BLK length change. Signed-off-by: Michael S. Tsirkin m...@redhat.com --- hw/i386/ssdt-proc.hex.generated | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/hw/i386/ssdt-proc.hex.generated

[Qemu-devel] [PATCH v6 21/26] ich9: APIs for pc guest info

2013-09-29 Thread Michael S. Tsirkin
This adds APIs that will be used to fill in acpi tables, implemented using QOM, to various ich9 components. Some information is still missing in QOM, so we fall back on lookups by type instead. Signed-off-by: Michael S. Tsirkin m...@redhat.com --- include/hw/acpi/ich9.h| 2 ++

[Qemu-devel] [PATCH v6 14/26] acpi: ssdt pcihp: updat generated file

2013-09-29 Thread Michael S. Tsirkin
update generated file, not sure what changed Signed-off-by: Michael S. Tsirkin m...@redhat.com --- hw/i386/ssdt-pcihp.hex.generated | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/hw/i386/ssdt-pcihp.hex.generated b/hw/i386/ssdt-pcihp.hex.generated index

[Qemu-devel] [Bug 1180777] Re: RDP traffic freeze on quiet network

2013-09-29 Thread Vasile Dumitrescu
I added a rtl8139c netcard to the VM and connected through it by RDP - no more freezes. It looks like kvm does not play well with virtio network cards and RDP. Red Hat virtio net windows driver version: 62.65.104.6500, 6/19/2013 I left the RH adapter on the VM, I just connect via RDP through

[Qemu-devel] [PATCH 3/3] hw: assert/deassert interrupts using pci_set_irq wrapper

2013-09-29 Thread Marcel Apfelbaum
pci_set_irq uses PCI_INTERRUPT_PIN config register to compute device INTx pin to assert/deassert. Signed-off-by: Marcel Apfelbaum marce...@redhat.com --- hw/audio/ac97.c| 4 ++-- hw/audio/es1370.c | 2 +- hw/audio/intel-hda.c | 2 +- hw/char/serial-pci.c | 2 +-

[Qemu-devel] [PATCH 2/3] hw/pci-bridge: set PCI_INTERRUPT_PIN register before shpc init

2013-09-29 Thread Marcel Apfelbaum
The PCI_INTERRUPT_PIN will be used by shpc init, so was moved before the call to shpc_init. Signed-off-by: Marcel Apfelbaum marce...@redhat.com --- hw/pci-bridge/pci_bridge_dev.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/pci-bridge/pci_bridge_dev.c

[Qemu-devel] [PATCH 0/3] hw: set irq without selecting INTx pin

2013-09-29 Thread Marcel Apfelbaum
Interrupt pin is selected and saved into PCI_INTERRUPT_PIN register during device initialization. Devices should not call directly qemu_set_irq and specify the INTx pin. Replaced the call to qemu_set_irq with a new wrapper pci_set_irq which triggers the irq based on PCI_INTERRUPT_PIN. Marcel

[Qemu-devel] [PATCH 1/3] hw/pci: set irq without selecting INTx pin

2013-09-29 Thread Marcel Apfelbaum
Interrupt pin is selected and saved into PCI_INTERRUPT_PIN register during device initialization. Devices should not call directly qemu_set_irq and specify the INTx pin on each call. Replaced the call to qemu_set_irq with a new wrapper pci_set_irq which triggers the irq based on

Re: [Qemu-devel] [PATCH 0/3] hw: set irq without selecting INTx pin

2013-09-29 Thread Michael S. Tsirkin
On Sun, Sep 29, 2013 at 05:40:54PM +0300, Marcel Apfelbaum wrote: Interrupt pin is selected and saved into PCI_INTERRUPT_PIN register during device initialization. Devices should not call directly qemu_set_irq and specify the INTx pin. Replaced the call to qemu_set_irq with a new wrapper

[Qemu-devel] qemu, numa: non-contiguous cpusets

2013-09-29 Thread Borislav Petkov
Btw, while I got your attention, on a not-really related topic: how do we feel about adding support for specifying a non-contiguous set of cpus for a numa node in qemu with the -numa option? I.e., like this, for example: x86_64-softmmu/qemu-system-x86_64 -smp 8 -numa node,nodeid=0,cpus=0\;2\;4-5

Re: [Qemu-devel] [PATCH v3 for 1.6 0/8] Guest memory allocation fixes cleanup

2013-09-29 Thread Stefan Weil
Am 31.07.2013 15:11, schrieb Markus Armbruster: All I wanted to do is exit(1) instead of abort() on guest memory allocation failure [07/08]. But that lead me into a minor #ifdef bog, and here's what I brought back. Enjoy! Testing: * Christian Borntraeger reports v1 works fine under LPAR

Re: [Qemu-devel] [PATCH 0/3] hw: set irq without selecting INTx pin

2013-09-29 Thread Marcel Apfelbaum
removed addresses: av1...@comtv.ru p...@codesourcery.com On Sun, 2013-09-29 at 18:06 +0300, Michael S. Tsirkin wrote: On Sun, Sep 29, 2013 at 05:40:54PM +0300, Marcel Apfelbaum wrote: Interrupt pin is selected and saved into PCI_INTERRUPT_PIN register during device initialization. Devices

Re: [Qemu-devel] [PATCH 0/3] hw: set irq without selecting INTx pin

2013-09-29 Thread Michael S. Tsirkin
On Sun, Sep 29, 2013 at 06:24:48PM +0300, Marcel Apfelbaum wrote: removed addresses: av1...@comtv.ru p...@codesourcery.com On Sun, 2013-09-29 at 18:06 +0300, Michael S. Tsirkin wrote: On Sun, Sep 29, 2013 at 05:40:54PM +0300, Marcel Apfelbaum wrote: Interrupt pin is selected and saved

[Qemu-devel] [PATCH] migration: Fix compiler warning ('caps' may be used uninitialized)

2013-09-29 Thread Stefan Weil
The QEMU buildbot default_i386_debian_6_0 shows this warning: CCmigration.o migration.c: In function 'qmp_query_migrate_capabilities': migration.c:149: warning: 'caps' may be used uninitialized in this function While changing this code, I also replaced g_malloc0 by the type safe g_new0.

[Qemu-devel] [PATCH] hw/alpha: Fix compiler warning (integer constant is too large)

2013-09-29 Thread Stefan Weil
From buildbot default_i386_rhel61: CCalpha-softmmu/hw/alpha/typhoon.o hw/alpha/typhoon.c: In function 'typhoon_translate_iommu': hw/alpha/typhoon.c:703: warning: integer constant is too large for 'long' type hw/alpha/typhoon.c:703: warning: integer constant is too large for 'long' type

[Qemu-devel] [PATCH] target-i386: Fix compiler warning (integer constant is too large)

2013-09-29 Thread Stefan Weil
From buildbot default_i386_rhel61: CCi386-softmmu/target-i386/arch_memory_mapping.o target-i386/arch_memory_mapping.c: In function 'walk_pde': target-i386/arch_memory_mapping.c:110: warning: integer constant is too large for 'long' type Signed-off-by: Stefan Weil s...@weilnetz.de ---

Re: [Qemu-devel] [PATCH] hw/alpha: Fix compiler warning (integer constant is too large)

2013-09-29 Thread Richard Henderson
On 09/29/2013 08:51 AM, Stefan Weil wrote: From buildbot default_i386_rhel61: CCalpha-softmmu/hw/alpha/typhoon.o hw/alpha/typhoon.c: In function 'typhoon_translate_iommu': hw/alpha/typhoon.c:703: warning: integer constant is too large for 'long' type hw/alpha/typhoon.c:703: warning:

Re: [Qemu-devel] [v2 00/71] Integrating Kconfig to Qemu

2013-09-29 Thread Antony Pavlov
On Fri, 27 Sep 2013 04:30:21 +0200 Ákos Kovács akoskov...@gmx.com wrote: I have just tryed 'kconfig' branch from your qemu github repo. Great work! But I have found new generated Kconfig.targets file in 'git status' 'Untracked files' section. Can we add it to the .gitignore file? This

[Qemu-devel] [PATCH] exec: Fix prototype of phys_mem_set_alloc and related functions

2013-09-29 Thread Stefan Weil
phys_mem_alloc and its assigned values qemu_anon_ram_alloc and legacy_s390_alloc must have identical argument lists. legacy_s390_alloc uses the size parameter to call mmap, so size_t is good enough for all of them. This patch fixes compiler errors on i686 Linux hosts: CC