Re: [Qemu-devel] [PATCH v2] pci-assign: Fix error_report of pci-stub message

2013-10-14 Thread Markus Armbruster
Cole Robinson crobi...@redhat.com writes: Using multiple calls to error_report here means every line is prefaced with the (potentially long) pci-assign command line arguments. Use a single error_printf to preserve the intended formatting. Since this code path is always preceded by an

[Qemu-devel] [PATCH] net/net: Change the default mac address of nic

2013-10-14 Thread y
From: Mike Qiu qiud...@linux.vnet.ibm.com The default mac address is 52:54:00:12:34:56 + index, this will cause problem that when we boot up more than one guest with all mac addresses unset by default, assume that each guest has one nic. In this situation, all the guest's nic has the same mac

[Qemu-devel] [PATCH v2] net/net: Change the default mac address of nic

2013-10-14 Thread Mike Qiu
The default mac address is 52:54:00:12:34:56 + index, this will cause problem that when we boot up more than one guest with all mac addresses unset by default, assume that each guest has one nic. In this situation, all the guest's nic has the same mac address. This patch is to solve this bug.

Re: [Qemu-devel] [PATCH v2] net/net: Change the default mac address of nic

2013-10-14 Thread mike
On 10/14/2013 03:30 PM, Mike Qiu wrote: Sorry for the first version make a mistake of the sender. There is no difference with v1. Thanks Mike The default mac address is 52:54:00:12:34:56 + index, this will cause problem that when we boot up more than one guest with all mac addresses unset by

Re: [Qemu-devel] [PATCH V3 0/7] qcow2: rollback the modification on fail in snapshot creation

2013-10-14 Thread Wenchao Xia
于 2013/10/2 20:28, Stefan Hajnoczi 写道: On Mon, Sep 09, 2013 at 10:57:55AM +0800, Wenchao Xia wrote: V2: 1: all fail case will goto fail section. 2: add the goto code. v3: Address Stefan's comments: 2: don't goto fail after allocation failure. 3: use sn-l1size correctly in

Re: [Qemu-devel] [PATCH V3 6/7] qcow2: print message for error path in snapshot creation

2013-10-14 Thread Wenchao Xia
于 2013/10/2 20:23, Stefan Hajnoczi 写道: On Mon, Sep 30, 2013 at 04:08:53PM -0600, Eric Blake wrote: On 09/08/2013 08:58 PM, Wenchao Xia wrote: The message will be print out with a macro enabled, which can s/print/printed/ be used to check which error path is taken. Signed-off-by: Wenchao

Re: [Qemu-devel] [PATCH] Python-lang gdb script to extract x86_64 guest vmcore from qemu coredump

2013-10-14 Thread Stefan Hajnoczi
On Thu, Sep 12, 2013 at 9:46 PM, Laszlo Ersek ler...@redhat.com wrote: +For simplicity, the paging, begin and end parameters of the QMP +command are not supported -- no attempt is made to get the guest's +internal paging structures (ie. paging=false is hard-wired), and guest +memory is always

Re: [Qemu-devel] [PATCH V3 7/7] qemu-iotests: add test for qcow2 snapshot

2013-10-14 Thread Wenchao Xia
于 2013/10/1 6:28, Eric Blake 写道: On 09/08/2013 08:58 PM, Wenchao Xia wrote: This test will focus on the low level procedure of qcow2 snapshot operations, now it covers only the create operation. Overlap error paths are not checked since no good way to trigger those errors. Signed-off-by:

Re: [Qemu-devel] bochs BIOS configuration and initialization

2013-10-14 Thread Rob Landley
On 09/30/2013 12:25:45 PM, Min LI wrote: Dear all, I am very interested in QEMU and trying to figure out the boot process of guest VM. According to my understanding about QEMU code, bochs BIOS is loaded into memory by pc_system_firmware_init(…). However, I notice QEMU handles

Re: [Qemu-devel] [SeaBIOS] [PATCH v2] map 64-bit PCI BARs at location provided by emulator

2013-10-14 Thread Gerd Hoffmann
Hi, But RamSizeOver4G still doesn't allow correctly place PCI window if large amount of memory present/reserved. BTW: I don't think it's good practice to change semantics of an old interface in general. It's less confusing to leave old interface as is (obsoleting it eventually)

Re: [Qemu-devel] [PATCH] Use qemu-project.org domain name

2013-10-14 Thread Stefan Hajnoczi
On Fri, Oct 11, 2013 at 06:39:09PM +0200, Stefan Weil wrote: Am 11.10.2013 09:55, schrieb Stefan Hajnoczi: On Thu, Oct 10, 2013 at 07:42:30PM +0200, Stefan Weil wrote: Am 10.10.2013 11:39, schrieb Stefan Hajnoczi: qemu.org is held by a third-party and no core community contributor has

Re: [Qemu-devel] [PULL 0/2] Correction of the TLB handling of the OpenRISC target

2013-10-14 Thread Jia Liu
Hi Anthony, Hi Peter, On Thu, Oct 3, 2013 at 5:00 PM, Peter Maydell peter.mayd...@linaro.org wrote: On 3 October 2013 17:41, Jia Liu pro...@gmail.com wrote: Hi Anthony, This is my OpenRISC patch queue. It originally come from Sebastian Macke, split by me, and I used some comment come from

Re: [Qemu-devel] kvm binary is deprecated

2013-10-14 Thread Stefan Hajnoczi
On Sat, Oct 12, 2013 at 05:45:52PM +0300, Alexander Binun wrote: The qemu used by me is the one installed using apt-get install qemu. The executable is in /usr/bin. The KVM driver is the one supplied with Ubuntu 13.04. The version of qemu is 1.4.0 (after running qemu --version I get the

Re: [Qemu-devel] [PATCH v2] map 64-bit PCI BARs at location provided by emulator

2013-10-14 Thread Igor Mammedov
On Sun, 13 Oct 2013 23:28:47 +0300 Michael S. Tsirkin m...@redhat.com wrote: On Sun, Oct 13, 2013 at 07:33:19PM +0200, Igor Mammedov wrote: On Sun, 13 Oct 2013 19:46:09 +0300 Michael S. Tsirkin m...@redhat.com wrote: On Sun, Oct 13, 2013 at 06:23:28PM +0200, Igor Mammedov wrote: On

Re: [Qemu-devel] kvm binary is deprecated

2013-10-14 Thread Alexander Binun
The workaround offered in bug trackers is: change the path associated with the emulation tag in the xml definition file. Change it to qemu-system-x86_64. Well, I am familiar with XML definition files for VMs: they are used manually when defining VMs in virsh (virsh define xmldef.xml and so on).

Re: [Qemu-devel] [PATCH 1/2] target-arm: sort TCG cpreg list by 64bit id version

2013-10-14 Thread alvise rigo
Sorry, I should have mentioned that an improper sorting of the cpreg_list could lead to a migration failure when cpu_post_load considers an incoming register as missing in the cpreg_indexes array. However, as long as the two lists are exactly the same, the problem does not occur. On Fri, Oct 11,

Re: [Qemu-devel] [PATCH v2] map 64-bit PCI BARs at location provided by emulator

2013-10-14 Thread Michael S. Tsirkin
On Mon, Oct 14, 2013 at 12:27:26PM +0200, Igor Mammedov wrote: On Sun, 13 Oct 2013 23:28:47 +0300 Michael S. Tsirkin m...@redhat.com wrote: On Sun, Oct 13, 2013 at 07:33:19PM +0200, Igor Mammedov wrote: On Sun, 13 Oct 2013 19:46:09 +0300 Michael S. Tsirkin m...@redhat.com wrote:

Re: [Qemu-devel] [PATCH 1/2] target-arm: sort TCG cpreg list by 64bit id version

2013-10-14 Thread Peter Maydell
On 14 October 2013 11:45, alvise rigo a.r...@virtualopensystems.com wrote: Sorry, I should have mentioned that an improper sorting of the cpreg_list could lead to a migration failure when cpu_post_load considers an incoming register as missing in the cpreg_indexes array. However, as long as

Re: [Qemu-devel] [ANNOUNCE] Key Signing Party at KVM Forum 2013

2013-10-14 Thread Stefan Hajnoczi
On Wed, Jul 24, 2013 at 2:50 PM, Anthony Liguori anth...@codemonkey.ws wrote: I will be hosting a key signing party at this year's KVM Forum. http://wiki.qemu.org/KeySigningParty2013 keyserver.cryptnet.net seems broken. I get connection refused when syncing to it. On port 80 it serves up a

Re: [Qemu-devel] [PATCH qom-cpu 00/21 v9] target-i386: convert CPU features into properties

2013-10-14 Thread Igor Mammedov
On Tue, 16 Jul 2013 00:25:53 +0200 Igor Mammedov imamm...@redhat.com wrote: It's reordered and rebased v8 plus CPUID feature bits conversion to properties and cleanups that are removing unused anymore *_feature_name arrays. dynamic = static properties conversion is still making sense as

Re: [Qemu-devel] [PATCH v2] map 64-bit PCI BARs at location provided by emulator

2013-10-14 Thread Gerd Hoffmann
Hi, And there is slight difference between PCI holes and PCI address space mappings represented by MemoryRegion-s in QEMU. Basically we only need to inform BIOS where to PCI address spaces start and simple etc/pcimem64-start + etc/pcimem32-start are just fine for that. And for

Re: [Qemu-devel] [PATCH v2] map 64-bit PCI BARs at location provided by emulator

2013-10-14 Thread Igor Mammedov
On Mon, 14 Oct 2013 14:00:12 +0300 Michael S. Tsirkin m...@redhat.com wrote: On Mon, Oct 14, 2013 at 12:27:26PM +0200, Igor Mammedov wrote: On Sun, 13 Oct 2013 23:28:47 +0300 Michael S. Tsirkin m...@redhat.com wrote: On Sun, Oct 13, 2013 at 07:33:19PM +0200, Igor Mammedov wrote: On

Re: [Qemu-devel] [PATCH v2] map 64-bit PCI BARs at location provided by emulator

2013-10-14 Thread Michael S. Tsirkin
On Mon, Oct 14, 2013 at 02:16:23PM +0200, Gerd Hoffmann wrote: Hi, And there is slight difference between PCI holes and PCI address space mappings represented by MemoryRegion-s in QEMU. Basically we only need to inform BIOS where to PCI address spaces start and simple

[Qemu-devel] [Bug 1239385] [NEW] qemu reboot when execute some SSE instruction

2013-10-14 Thread Zhou Yi Chao
Public bug reported: I'm using qemu-system-i386 on a x86-64 platform doing my OS homework. When qemu execute c0102f9a: 66 0f 6e 45 a0 movd -0x60(%ebp),%xmm0 c0102f9f: 66 0f d6 45 d0 movq %xmm0,-0x30(%ebp) My virtual OS reboots. Maybe the following old patch

[Qemu-devel] guest-dump-memory

2013-10-14 Thread Phi Debian
Hi All, I tried to subscribe to this list, but never got teh confirm mail. So I write here non subscribed, so add my email addr in replies. I am trying to use guest-dump-memory on arm (arm32, armv7* name it) with qemu 1.6.1. The command is 'implemented' i.e listed in the help, but it create an

Re: [Qemu-devel] [PATCH v2] map 64-bit PCI BARs at location provided by emulator

2013-10-14 Thread Gerd Hoffmann
Hi, To me it makes more sense to just go the direct route and say please put the 64bit bars at this location rather than indirect we might want hotplug $thatmuch memory and then expect the bios to leave that much room. Only if the newfeature address is not under bios control. I

Re: [Qemu-devel] [PATCH v2] Use qemu-project.org domain name

2013-10-14 Thread Peter Maydell
On 11 October 2013 13:52, Stefan Hajnoczi stefa...@redhat.com wrote: Note that git-submodule(1) does not detect URL changes. The following commands clear out and re-initialize all submodules to ensure you are using the latest URLs: $ git submodule deinit . # you'll be warned if you have

Re: [Qemu-devel] [PATCH v2] Use qemu-project.org domain name

2013-10-14 Thread Ademar de Souza Reis Jr.
On Fri, Oct 11, 2013 at 02:52:38PM +0200, Stefan Hajnoczi wrote: qemu.org is held by a third-party and no core community contributor has access to the DNS configuration. This leaves the website exposed to outages due to DNS issues or IP address changes. For example, if the web server IP

[Qemu-devel] [PATCH] hmp: Add '\n' in monitor_printf()

2013-10-14 Thread Mike Qiu
Without this, output of 'info block' scsi0-hd0: /images/f18-ppc64.qcow2 (qcow2) [not inserted] scsi0-cd2: [not inserted] Removable device: not locked, tray closed floppy0: [not inserted] Removable device: not locked, tray closed sd0: [not inserted] Removable device: not locked,

Re: [Qemu-devel] [RFC PATCH v2 2/4] kvm: Introduce kvm_arch_irqchip_create

2013-10-14 Thread Peter Maydell
On 26 September 2013 20:56, Christoffer Dall christoffer.d...@linaro.org wrote: Introduce kvm_arch_irqchip_create an arch-specific hook in preparation for architecture-specific use of the device control API to create IRQ chips. Following patches will implement the ARM irqchip create method to

Re: [Qemu-devel] [RFC PATCH v2 3/4] kvm: Common device control API functions

2013-10-14 Thread Peter Maydell
On 26 September 2013 20:56, Christoffer Dall christoffer.d...@linaro.org wrote: Introduces two simple functions: int kvm_device_ioctl(int fd, int type, ...); int kvm_create_device(KVMState *s, uint64_t type, bool test); These functions wrap the basic ioctl-based interactions with KVM

Re: [Qemu-devel] [RFC PATCH v2 4/4] arm: vgic device control api support

2013-10-14 Thread Peter Maydell
On 26 September 2013 20:56, Christoffer Dall christoffer.d...@linaro.org wrote: Support creating the ARM vgic device through the device control API and setting the base address for the distributor and cpu interfaces in KVM VMs using this API. Because the older KVM_CREATE_IRQCHIP interface

[Qemu-devel] [Bug 1239385] Re: qemu reboot when execute some SSE instruction

2013-10-14 Thread Zhou Yi Chao
** Changed in: qemu Status: New = Invalid -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1239385 Title: qemu reboot when execute some SSE instruction Status in QEMU: Invalid Bug

Re: [Qemu-devel] [PATCH] mirror: drop local_err in mirror_compelte

2013-10-14 Thread Eric Blake
On 10/12/2013 12:33 AM, Fam Zheng wrote: There is errp passed in, so no need for local_err and error_propagate. s/compelte/complete/ in the subject Signed-off-by: Fam Zheng f...@redhat.com --- block/mirror.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git

Re: [Qemu-devel] [PATCH v2] map 64-bit PCI BARs at location provided by emulator

2013-10-14 Thread Michael S. Tsirkin
On Mon, Oct 14, 2013 at 03:04:45PM +0200, Gerd Hoffmann wrote: Hi, To me it makes more sense to just go the direct route and say please put the 64bit bars at this location rather than indirect we might want hotplug $thatmuch memory and then expect the bios to leave that much

[Qemu-devel] qemu master build errors

2013-10-14 Thread Michael S. Tsirkin
/scm/qemu/exec.c:720:51: error: initialization from incompatible pointer type [-Werror] static void *(*phys_mem_alloc)(ram_addr_t size) = qemu_anon_ram_alloc; ^ /scm/qemu/exec.c: In function ‘qemu_ram_alloc_from_ptr’: /scm/qemu/exec.c:1107:32:

Re: [Qemu-devel] [PATCH v6 2/5] hpet: enable to entitle more irq pins for hpet

2013-10-14 Thread Michael S. Tsirkin
On Fri, Oct 11, 2013 at 05:18:30PM +0800, liu ping fan wrote: On Fri, Oct 11, 2013 at 4:38 PM, Paolo Bonzini pbonz...@redhat.com wrote: Il 11/10/2013 04:59, liu ping fan ha scritto: On Thu, Oct 10, 2013 at 7:41 PM, Michael S. Tsirkin m...@redhat.com wrote: On Thu, Oct 10, 2013 at

Re: [Qemu-devel] [PATCH v6 2/5] hpet: enable to entitle more irq pins for hpet

2013-10-14 Thread Michael S. Tsirkin
On Fri, Oct 11, 2013 at 10:59:40AM +0800, liu ping fan wrote: On Thu, Oct 10, 2013 at 7:41 PM, Michael S. Tsirkin m...@redhat.com wrote: On Thu, Oct 10, 2013 at 11:46:42AM +0200, Paolo Bonzini wrote: Il 10/10/2013 11:41, Michael S. Tsirkin ha scritto: Are you sure? This is not done for

Re: [Qemu-devel] kvm binary is deprecated

2013-10-14 Thread Stefan Hajnoczi
On Mon, Oct 14, 2013 at 12:36 PM, Alexander Binun bi...@cs.bgu.ac.il wrote: The workaround offered in bug trackers is: change the path associated with the emulation tag in the xml definition file. Change it to qemu-system-x86_64. Well, I am familiar with XML definition files for VMs: they

Re: [Qemu-devel] qemu master build errors

2013-10-14 Thread Michael S. Tsirkin
On Mon, Oct 14, 2013 at 05:08:58PM +0300, Michael S. Tsirkin wrote: /scm/qemu/exec.c:720:51: error: initialization from incompatible pointer type [-Werror] static void *(*phys_mem_alloc)(ram_addr_t size) = qemu_anon_ram_alloc; ^

Re: [Qemu-devel] [RFC PATCH v2 1/6] hw: arm_gic: Fix gic_set_irq handling

2013-10-14 Thread Peter Maydell
On 26 September 2013 22:03, Christoffer Dall christoffer.d...@linaro.org wrote: For some reason only edge-triggered or enabled level-triggered interrupts would set the pending state of a raised IRQ. This is not in compliance with the specs, which indicate that the pending state is separate

Re: [Qemu-devel] [PATCH] exec: Fix prototype of phys_mem_set_alloc and related functions

2013-10-14 Thread Michael S. Tsirkin
On Sun, Sep 29, 2013 at 08:56:45PM +0200, Stefan Weil wrote: phys_mem_alloc and its assigned values qemu_anon_ram_alloc and legacy_s390_alloc must have identical argument lists. legacy_s390_alloc uses the size parameter to call mmap, so size_t is good enough for all of them. This patch

Re: [Qemu-devel] [RFC PATCH v2 2/6] hw: arm_gic: Introduce GIC_SET_PRIORITY macro

2013-10-14 Thread Peter Maydell
On 26 September 2013 22:03, Christoffer Dall christoffer.d...@linaro.org wrote: To make the code slightly cleaner to look at and make the save/restore code easier to understand, introduce this macro to set the priority of interrupts. Signed-off-by: Christoffer Dall christoffer.d...@linaro.org

Re: [Qemu-devel] [PATCH] hmp: Add '\n' in monitor_printf()

2013-10-14 Thread Markus Armbruster
Mike Qiu qiud...@linux.vnet.ibm.com writes: Without this, output of 'info block' scsi0-hd0: /images/f18-ppc64.qcow2 (qcow2) [not inserted] scsi0-cd2: [not inserted] Removable device: not locked, tray closed floppy0: [not inserted] Removable device: not locked, tray closed sd0:

Re: [Qemu-devel] qemu master build errors

2013-10-14 Thread Markus Armbruster
Michael S. Tsirkin m...@redhat.com writes: /scm/qemu/exec.c:720:51: error: initialization from incompatible pointer type [-Werror] static void *(*phys_mem_alloc)(ram_addr_t size) = qemu_anon_ram_alloc; ^ /scm/qemu/exec.c: In function

Re: [Qemu-devel] qemu master build errors

2013-10-14 Thread Michael S. Tsirkin
On Mon, Oct 14, 2013 at 04:38:22PM +0200, Markus Armbruster wrote: Michael S. Tsirkin m...@redhat.com writes: /scm/qemu/exec.c:720:51: error: initialization from incompatible pointer type [-Werror] static void *(*phys_mem_alloc)(ram_addr_t size) = qemu_anon_ram_alloc;

[Qemu-devel] [PULL 04/43] hw/core: Add interface to allocate and free a single IRQ

2013-10-14 Thread Michael S. Tsirkin
From: Marcel Apfelbaum marce...@redhat.com qemu_allocate_irq returns a single qemu_irq. The interface allows to specify an interrupt number. qemu_free_irq frees it. Signed-off-by: Marcel Apfelbaum marce...@redhat.com Signed-off-by: Michael S. Tsirkin m...@redhat.com --- include/hw/irq.h | 7

[Qemu-devel] [PULL 01/43] memory: Change MemoryRegion priorities from unsigned to signed

2013-10-14 Thread Michael S. Tsirkin
From: Marcel Apfelbaum marce...@redhat.com When memory regions overlap, priority can be used to specify which of them takes priority. By making the priority values signed rather than unsigned, we make it more convenient to implement a situation where one background region should appear only where

[Qemu-devel] [PULL 03/43] hw/pci: partially handle pci master abort

2013-10-14 Thread Michael S. Tsirkin
From: Marcel Apfelbaum marce...@redhat.com A MemoryRegion with negative priority was created and it spans over all the pci address space. It intercepts the accesses to unassigned pci address space and will follow the pci spec: 1. returns -1 on read 2. does nothing on write Note: setting the

[Qemu-devel] [PULL 00/43] pci, pc, acpi fixes, enhancements

2013-10-14 Thread Michael S. Tsirkin
Anthony, I know you wanted to review some of the patches, since you didn't respond either all's well or you could not find the time. I think we are better off merging them for 1.7 and then - worst case, if major issues surface - disabling the functionality at the last minute than delaying the

[Qemu-devel] [PULL 02/43] docs/memory: Explictly state that MemoryRegion priority is signed

2013-10-14 Thread Michael S. Tsirkin
From: Marcel Apfelbaum marce...@redhat.com When memory regions overlap, priority can be used to specify which of them takes priority. By making the priority values signed rather than unsigned, we make it more convenient to implement a situation where one background region should appear only where

[Qemu-devel] [PULL 08/43] hw/vfio: set interrupts using pci irq wrappers

2013-10-14 Thread Michael S. Tsirkin
From: Marcel Apfelbaum marce...@redhat.com pci_set_irq and the other pci irq wrappers use PCI_INTERRUPT_PIN config register to compute device INTx pin to assert/deassert. save INTX pin into the config register before calling pci_set_irq Signed-off-by: Marcel Apfelbaum marce...@redhat.com

[Qemu-devel] [PULL 05/43] hw/pci: add pci wrappers for allocating and asserting irqs

2013-10-14 Thread Michael S. Tsirkin
From: Marcel Apfelbaum marce...@redhat.com Interrupt pin is selected and saved into PCI_INTERRUPT_PIN register during device initialization. Devices should not call directly qemu_set_irq and specify the INTx pin on each call. Added pci_* wrappers to replace qemu_set_irq, qemu_irq_raise,

[Qemu-devel] [PULL 09/43] hw: set interrupts using pci irq wrappers

2013-10-14 Thread Michael S. Tsirkin
From: Marcel Apfelbaum marce...@redhat.com pci_set_irq and the other pci irq wrappers use PCI_INTERRUPT_PIN config register to compute device INTx pin to assert/deassert. An irq is allocated using pci_allocate_irq wrapper only if is needed by non pci devices. Removed irq related fields from

[Qemu-devel] [PULL 07/43] hw/vmxnet3: set interrupts using pci irq wrappers

2013-10-14 Thread Michael S. Tsirkin
From: Marcel Apfelbaum marce...@redhat.com pci_set_irq uses PCI_INTERRUPT_PIN config register to compute device INTx pin to assert/deassert. An assert is used to ensure that intx received from the quest OS corresponds to PCI_INTERRUPT_PIN. Signed-off-by: Marcel Apfelbaum marce...@redhat.com

[Qemu-devel] [PULL 16/43] fw_cfg: interface to trigger callback on read

2013-10-14 Thread Michael S. Tsirkin
Reviewed-by: Gerd Hoffmann kra...@redhat.com Tested-by: Gerd Hoffmann kra...@redhat.com Reviewed-by: Igor Mammedov imamm...@redhat.com Tested-by: Igor Mammedov imamm...@redhat.com Signed-off-by: Michael S. Tsirkin m...@redhat.com --- include/hw/nvram/fw_cfg.h | 4 hw/nvram/fw_cfg.c

[Qemu-devel] [PULL 19/43] pcie_host: expose address format

2013-10-14 Thread Michael S. Tsirkin
Callers pass in the address so it's helpful for them to be able to decode it. Reviewed-by: Gerd Hoffmann kra...@redhat.com Tested-by: Gerd Hoffmann kra...@redhat.com Reviewed-by: Igor Mammedov imamm...@redhat.com Tested-by: Igor Mammedov imamm...@redhat.com Signed-off-by: Michael S. Tsirkin

[Qemu-devel] [PULL 10/43] hw/pcie: AER and hot-plug events must use device's interrupt

2013-10-14 Thread Michael S. Tsirkin
From: Marcel Apfelbaum marce...@redhat.com The fields hpev_intx and aer_intx were removed because both AER and hot-plug events must use device's interrupt. Assert/deassert interrupts using pci irq wrappers instead. Signed-off-by: Marcel Apfelbaum marce...@redhat.com Signed-off-by: Michael S.

[Qemu-devel] [PULL 17/43] loader: support for unmapped ROM blobs

2013-10-14 Thread Michael S. Tsirkin
Support ROM blobs not mapped into guest memory: same as ROM files really but use caller's buffer. Support invoking callback on access and return memory pointer making it easier for caller to update memory if necessary. Reviewed-by: Gerd Hoffmann kra...@redhat.com Tested-by: Gerd Hoffmann

[Qemu-devel] [PULL 25/43] acpi: ssdt pcihp: updat generated file

2013-10-14 Thread Michael S. Tsirkin
update generated file, not sure what changed Reviewed-by: Gerd Hoffmann kra...@redhat.com Tested-by: Gerd Hoffmann kra...@redhat.com Reviewed-by: Igor Mammedov imamm...@redhat.com Tested-by: Igor Mammedov imamm...@redhat.com Signed-off-by: Michael S. Tsirkin m...@redhat.com ---

[Qemu-devel] [PULL 13/43] qom: cleanup struct Error references

2013-10-14 Thread Michael S. Tsirkin
now that a typedef for struct Error is available, use it in qom/object.h to match coding style rules. Reviewed-by: Paolo Bonzini pbonz...@redhat.com Reviewed-by: Gerd Hoffmann kra...@redhat.com Tested-by: Gerd Hoffmann kra...@redhat.com Reviewed-by: Igor Mammedov imamm...@redhat.com Tested-by:

[Qemu-devel] [PULL 20/43] q35: use macro for MCFG property name

2013-10-14 Thread Michael S. Tsirkin
Useful to make it accessible through QOM. Reviewed-by: Gerd Hoffmann kra...@redhat.com Tested-by: Gerd Hoffmann kra...@redhat.com Reviewed-by: Igor Mammedov imamm...@redhat.com Tested-by: Igor Mammedov imamm...@redhat.com Signed-off-by: Michael S. Tsirkin m...@redhat.com ---

[Qemu-devel] [PULL 28/43] loader: allow adding ROMs in done callbacks

2013-10-14 Thread Michael S. Tsirkin
Don't abort if machine done callbacks add ROMs. Reviewed-by: Gerd Hoffmann kra...@redhat.com Tested-by: Gerd Hoffmann kra...@redhat.com Reviewed-by: Igor Mammedov imamm...@redhat.com Tested-by: Igor Mammedov imamm...@redhat.com Signed-off-by: Michael S. Tsirkin m...@redhat.com ---

[Qemu-devel] [PULL 35/43] acpi: add interface to access user-installed tables

2013-10-14 Thread Michael S. Tsirkin
Also add a new API to install builtin tables, so that we can distinguish between the two. Signed-off-by: Michael S. Tsirkin m...@redhat.com --- include/hw/acpi/acpi.h | 4 hw/acpi/core.c | 40 2 files changed, 44 insertions(+) diff --git

[Qemu-devel] [PULL 27/43] i386: add bios linker/loader

2013-10-14 Thread Michael S. Tsirkin
This adds a dynamic bios linker/loader. This will be used by acpi table generation code to: - load each table in the appropriate memory segment - link tables to each other - fix up checksums after said linking Reviewed-by: Gerd Hoffmann kra...@redhat.com Tested-by: Gerd Hoffmann

[Qemu-devel] [PULL 40/43] pci: add pci_for_each_bus_depth_first

2013-10-14 Thread Michael S. Tsirkin
Useful for ACPI hotplug. Signed-off-by: Michael S. Tsirkin m...@redhat.com --- include/hw/pci/pci.h | 14 ++ hw/pci/pci.c | 28 2 files changed, 42 insertions(+) diff --git a/include/hw/pci/pci.h b/include/hw/pci/pci.h index 37ffa53..3755b02

Re: [Qemu-devel] [PULL 00/43] pci, pc, acpi fixes, enhancements

2013-10-14 Thread Paolo Bonzini
Il 14/10/2013 16:57, Michael S. Tsirkin ha scritto: pci, pc, acpi fixes, enhancements This includes some pretty big changes: - pci master abort support by Marcel - pci IRQ API rework by Marcel - acpi generation and pci bridge hotplug support by myself Everything has gone through several

[Qemu-devel] [PULL 34/43] hpet: add API to find it

2013-10-14 Thread Michael S. Tsirkin
Add API to find HPET using QOM. Reviewed-by: Gerd Hoffmann kra...@redhat.com Tested-by: Gerd Hoffmann kra...@redhat.com Reviewed-by: Igor Mammedov imamm...@redhat.com Tested-by: Igor Mammedov imamm...@redhat.com Signed-off-by: Michael S. Tsirkin m...@redhat.com --- include/hw/timer/hpet.h | 2 ++

[Qemu-devel] [PULL 43/43] acpi-build: enable hotplug for PCI bridges

2013-10-14 Thread Michael S. Tsirkin
This enables support for device hotplug behind pci bridges. Bridge devices themselves need to be pre-configured on qemu command line. Design: - at machine init time, assign bsel property to bridges with hotplug support - dynamically (At ACPI table read) generate ACPI code to handle

[Qemu-devel] [PULL 39/43] ssdt-proc: update generated file

2013-10-14 Thread Michael S. Tsirkin
Update generated ssdt proc hex file (used for systems lacking IASL) after P_BLK length change. Reviewed-by: Gerd Hoffmann kra...@redhat.com Tested-by: Gerd Hoffmann kra...@redhat.com Reviewed-by: Igor Mammedov imamm...@redhat.com Tested-by: Igor Mammedov imamm...@redhat.com Signed-off-by: Michael

Re: [Qemu-devel] qemu master build errors

2013-10-14 Thread Anthony Liguori
On Oct 14, 2013 7:49 AM, Michael S. Tsirkin m...@redhat.com wrote: On Mon, Oct 14, 2013 at 04:38:22PM +0200, Markus Armbruster wrote: Michael S. Tsirkin m...@redhat.com writes: /scm/qemu/exec.c:720:51: error: initialization from incompatible pointer type [-Werror] static void

[Qemu-devel] [PULL 29/43] i386: define pc guest info

2013-10-14 Thread Michael S. Tsirkin
This defines a structure that will be used to fill in acpi tables where relevant properties are not yet available using QOM. Reviewed-by: Laszlo Ersek ler...@redhat.com Reviewed-by: Gerd Hoffmann kra...@redhat.com Tested-by: Gerd Hoffmann kra...@redhat.com Reviewed-by: Igor Mammedov

[Qemu-devel] [PULL 30/43] acpi/piix: add macros for acpi property names

2013-10-14 Thread Michael S. Tsirkin
Reviewed-by: Gerd Hoffmann kra...@redhat.com Tested-by: Gerd Hoffmann kra...@redhat.com Reviewed-by: Igor Mammedov imamm...@redhat.com Tested-by: Igor Mammedov imamm...@redhat.com Signed-off-by: Michael S. Tsirkin m...@redhat.com --- include/hw/i386/pc.h | 10 ++ hw/acpi/piix4.c | 6

[Qemu-devel] [PULL 41/43] pcihp: generalization of piix4 acpi

2013-10-14 Thread Michael S. Tsirkin
Add ACPI based PCI hotplug library with bridge hotplug support. Design - each bus gets assigned bsel property. - ACPI code writes this number to a new BNUM register, then uses existing UP/DOWN registers to probe slot status; to eject, write number to BNUM register, then

[Qemu-devel] [PULL 31/43] piix: APIs for pc guest info

2013-10-14 Thread Michael S. Tsirkin
This adds APIs that will be used to fill in guest acpi tables. Some required information is still lacking in QOM, so we fall back on lookups by type and returning explicit types. Reviewed-by: Gerd Hoffmann kra...@redhat.com Tested-by: Gerd Hoffmann kra...@redhat.com Reviewed-by: Igor Mammedov

[Qemu-devel] [PULL 32/43] ich9: APIs for pc guest info

2013-10-14 Thread Michael S. Tsirkin
This adds APIs that will be used to fill in acpi tables, implemented using QOM, to various ich9 components. Some information is still missing in QOM, so we fall back on lookups by type instead. Reviewed-by: Gerd Hoffmann kra...@redhat.com Tested-by: Gerd Hoffmann kra...@redhat.com Reviewed-by:

[Qemu-devel] [PULL 15/43] pci: fix up w64 size calculation helper

2013-10-14 Thread Michael S. Tsirkin
BAR base was calculated incorrectly. Use existing pci_bar_address to get it right. Tested-by: Igor Mammedov imamm...@redhat.com Reviewed-by: Igor Mammedov imamm...@redhat.com Signed-off-by: Michael S. Tsirkin m...@redhat.com --- hw/pci/pci.c | 20 1 file changed, 12

[Qemu-devel] [PULL 36/43] pc: use new api to add builtin tables

2013-10-14 Thread Michael S. Tsirkin
At this point the only builtin table we have is the DSDT used for Q35. Signed-off-by: Michael S. Tsirkin m...@redhat.com --- hw/i386/pc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/i386/pc.c b/hw/i386/pc.c index d17d1d9..f8a3f0b 100644 --- a/hw/i386/pc.c +++

[Qemu-devel] [PULL 38/43] ssdt: fix PBLK length

2013-10-14 Thread Michael S. Tsirkin
We don't really support CPU throttling, so supply 0 PBLK length. Reviewed-by: Gerd Hoffmann kra...@redhat.com Tested-by: Gerd Hoffmann kra...@redhat.com Reviewed-by: Igor Mammedov imamm...@redhat.com Tested-by: Igor Mammedov imamm...@redhat.com Signed-off-by: Michael S. Tsirkin m...@redhat.com

Re: [Qemu-devel] [PULL 00/43] pci, pc, acpi fixes, enhancements

2013-10-14 Thread Michael S. Tsirkin
On Mon, Oct 14, 2013 at 04:57:19PM +0200, Paolo Bonzini wrote: Il 14/10/2013 16:57, Michael S. Tsirkin ha scritto: pci, pc, acpi fixes, enhancements This includes some pretty big changes: - pci master abort support by Marcel - pci IRQ API rework by Marcel - acpi generation and pci

Re: [Qemu-devel] [PULL 00/43] pci, pc, acpi fixes, enhancements

2013-10-14 Thread Paolo Bonzini
Il 14/10/2013 17:12, Michael S. Tsirkin ha scritto: Are you going to do another pull request with the virtio and bus-reset fixes? I missed that you did the testing of the post-order changed. I'll put them on my branch but I'd rather this kind of change went through a bit more testing so -

[Qemu-devel] [PULL 33/43] pvpanic: add API to access io port

2013-10-14 Thread Michael S. Tsirkin
Add API to find pvpanic device and get its io port. Will be used to fill in guest info structure. Reviewed-by: Gerd Hoffmann kra...@redhat.com Tested-by: Gerd Hoffmann kra...@redhat.com Reviewed-by: Igor Mammedov imamm...@redhat.com Tested-by: Igor Mammedov imamm...@redhat.com Signed-off-by:

Re: [Qemu-devel] [RFC PATCH v2 3/6] hw: arm_gic: Keep track of SGI sources

2013-10-14 Thread Peter Maydell
On 26 September 2013 22:03, Christoffer Dall christoffer.d...@linaro.org wrote: Right now the arm gic emulation doesn't keep track of the source of an SGI (which apparently Linux guests don't use, or they're fine with assuming CPU 0 always). Add the necessary matrix on the GICState structure

Re: [Qemu-devel] [RFC PATCH v2 4/6] arm_gic: Support setting/getting binary point reg

2013-10-14 Thread Peter Maydell
On 26 September 2013 22:03, Christoffer Dall christoffer.d...@linaro.org wrote: @@ -606,10 +607,13 @@ static void gic_cpu_write(GICState *s, int cpu, int offset, uint32_t value) s-priority_mask[cpu] = (value 0xff); break; case 0x08: /* Binary Point */ -/* ???

Re: [Qemu-devel] [RFC PATCH v2 5/6] vmstate: Add uint32 2D-array support

2013-10-14 Thread Peter Maydell
On 26 September 2013 22:03, Christoffer Dall christoffer.d...@linaro.org wrote: Add support for saving VMtate of 2D arrays of uint32 values. VMState. Otherwise: Reviewed-by: Peter Maydell peter.mayd...@linaro.org -- PMM

Re: [Qemu-devel] [PULL 08/43] hw/vfio: set interrupts using pci irq wrappers

2013-10-14 Thread Alex Williamson
On Mon, 2013-10-14 at 17:58 +0300, Michael S. Tsirkin wrote: From: Marcel Apfelbaum marce...@redhat.com pci_set_irq and the other pci irq wrappers use PCI_INTERRUPT_PIN config register to compute device INTx pin to assert/deassert. save INTX pin into the config register before calling

[Qemu-devel] [PULL 26/43] loader: use file path size from fw_cfg.h

2013-10-14 Thread Michael S. Tsirkin
Avoid a bit of code duplication, make max file path constant reusable. Suggested-by: Laszlo Ersek ler...@redhat.com Reviewed-by: Gerd Hoffmann kra...@redhat.com Tested-by: Gerd Hoffmann kra...@redhat.com Reviewed-by: Igor Mammedov imamm...@redhat.com Tested-by: Igor Mammedov imamm...@redhat.com

[Qemu-devel] [PULL 18/43] pcie_host: expose UNMAPPED macro

2013-10-14 Thread Michael S. Tsirkin
Make it possible to test unmapped status through QMP. Reviewed-by: Gerd Hoffmann kra...@redhat.com Tested-by: Gerd Hoffmann kra...@redhat.com Reviewed-by: Igor Mammedov imamm...@redhat.com Tested-by: Igor Mammedov imamm...@redhat.com Signed-off-by: Michael S. Tsirkin m...@redhat.com ---

[Qemu-devel] [PATCH] virtio: Introduce virtio-testdev

2013-10-14 Thread Andrew Jones
This is a virtio version of hw/misc/debugexit and should evolve into a virtio version of pc-testdev. pc-testdev uses the PC's ISA bus, whereas this testdev can be plugged into a virtio-mmio transport, which is needed for kvm-unit-tests/arm. virtio-testdev uses the virtio device config space as a

[Qemu-devel] [PULL 12/43] cleanup object.h: include error.h directly

2013-10-14 Thread Michael S. Tsirkin
From: Igor Mammedov imamm...@redhat.com qapi/error.h is simple enough to be included in qom/object.h direcly and prepares qom/object.h to use Error typedef. Signed-off-by: Igor Mammedov imamm...@redhat.com Signed-off-by: Michael S. Tsirkin m...@redhat.com --- include/qom/object.h | 2 +- 1 file

[Qemu-devel] [PULL 23/43] acpi: add rules to compile ASL source

2013-10-14 Thread Michael S. Tsirkin
Detect presence of IASL compiler and use it to process ASL source. If not there, use pre-compiled files in-tree. Add script to update the in-tree files. Note: distros are known to silently update iasl so detect correct iasl flags for the installed version on each run as opposed to at configure

[Qemu-devel] [PULL 11/43] hw/pci: removed irq field from PCIDevice

2013-10-14 Thread Michael S. Tsirkin
From: Marcel Apfelbaum marce...@redhat.com Instead of exposing the the irq field, pci wrappers to qemu_set_irq or qemu_irq_* can be used. Signed-off-by: Marcel Apfelbaum marce...@redhat.com Signed-off-by: Michael S. Tsirkin m...@redhat.com --- include/hw/pci/pci.h | 3 --- hw/pci/pci.c

[Qemu-devel] [PULL 14/43] qom: add pointer to int property helpers

2013-10-14 Thread Michael S. Tsirkin
Make it easy to add read-only helpers for simple integer properties in memory. Reviewed-by: Paolo Bonzini pbonz...@redhat.com Reviewed-by: Gerd Hoffmann kra...@redhat.com Tested-by: Gerd Hoffmann kra...@redhat.com Reviewed-by: Igor Mammedov imamm...@redhat.com Tested-by: Igor Mammedov

[Qemu-devel] [PULL 42/43] piix4: add acpi pci hotplug support

2013-10-14 Thread Michael S. Tsirkin
Add support for acpi pci hotplug using the new infrastructure. PIIX4 legacy interface is maintained as is for machine types 1.6 and older. Signed-off-by: Michael S. Tsirkin m...@redhat.com --- include/hw/i386/pc.h | 5 hw/acpi/piix4.c | 75

[Qemu-devel] [PULL 06/43] hw/pci-bridge: set PCI_INTERRUPT_PIN register before shpc init

2013-10-14 Thread Michael S. Tsirkin
From: Marcel Apfelbaum marce...@redhat.com The PCI_INTERRUPT_PIN will be used by shpc init, so was moved before the call to shpc_init. Signed-off-by: Marcel Apfelbaum marce...@redhat.com Signed-off-by: Michael S. Tsirkin m...@redhat.com --- hw/pci-bridge/pci_bridge_dev.c | 2 +- 1 file changed,

[Qemu-devel] [PULL 21/43] q35: expose mmcfg size as a property

2013-10-14 Thread Michael S. Tsirkin
Address is already exposed, expose size for symmetry. Reviewed-by: Gerd Hoffmann kra...@redhat.com Tested-by: Gerd Hoffmann kra...@redhat.com Reviewed-by: Igor Mammedov imamm...@redhat.com Tested-by: Igor Mammedov imamm...@redhat.com Signed-off-by: Michael S. Tsirkin m...@redhat.com ---

Re: [Qemu-devel] [PATCH v2] map 64-bit PCI BARs at location provided by emulator

2013-10-14 Thread Igor Mammedov
On Mon, 14 Oct 2013 17:00:47 +0300 Michael S. Tsirkin m...@redhat.com wrote: On Mon, Oct 14, 2013 at 03:04:45PM +0200, Gerd Hoffmann wrote: Hi, To me it makes more sense to just go the direct route and say please put the 64bit bars at this location rather than indirect we

[Qemu-devel] [PATCH 12/11] virtio-pci: avoid extra pointer dereferences on fast path

2013-10-14 Thread Paolo Bonzini
We do not need to access vdev on the MSI-X fast path of virtio_pci_notify. Signed-off-by: Paolo Bonzini pbonz...@redhat.com --- It is possible to get rid of BusChild altogether, but even then this would be one less pointer dereference, and it's a simpler patch. So let's

[Qemu-devel] [PULL v2 00/11] target-lm32 updates

2013-10-14 Thread Michael Walle
Hi Anthony, Hi Blue, This is a pull for various updates and fixes for the LatticeMico32 target. Please pull. changes since v1: - rebased - dropped patch target-lm32: register helper functions. This is no longer needed. - added patch target-lm32: stop VM on illegal or unknown instruction.

[Qemu-devel] [PULL v2 03/11] milkymist-uart: use qemu_chr_fe_write_all() instead of qemu_chr_fe_write()

2013-10-14 Thread Michael Walle
From: Antony Pavlov antonynpav...@gmail.com qemu_chr_fe_write() is capable of returning 0 to indicate EAGAIN (and friends) and we don't handle this. Just change it to qemu_chr_fe_write_all() to fix. Reported-by: Peter Crosthwaite peter.crosthwa...@xilinx.com Acked-by: Peter Crosthwaite

  1   2   >