Re: [Qemu-devel] [Qemu-trivial] [PATCH] qapi: Fix comment for create-type to match code.

2013-11-06 Thread Michael Tokarev
Thanks, applied to the trivial-patches queue. /mjt

Re: [Qemu-devel] [Qemu-trivial] [PATCH v2] pci-assign: Fix error_report of pci-stub message

2013-11-06 Thread Michael Tokarev
On 10/11/2013 11:52 AM, Cole Robinson wrote: Using multiple calls to error_report here means every line is prefaced with the (potentially long) pci-assign command line arguments. Use a single error_printf to preserve the intended formatting. Since this code path is always preceded by an

[Qemu-devel] C99 loop vars? [was: gtk: Fix compiler warnings with -Werror=sign-compare]

2013-11-06 Thread Michael Tokarev
05.11.2013 00:38, Laszlo Ersek wrote: On 11/04/13 21:07, Peter Maydell wrote: On 4 November 2013 19:51, Stefan Weil s...@weilnetz.de wrote: With -Werror=sign-compare (not enabled by default), gcc shows these errors: ui/gtk.c: In function ‘gtk_release_modifiers’: ui/gtk.c:288:19: error:

[Qemu-devel] [PATCH] virtio-net: only delete bh that existed

2013-11-06 Thread Jason Wang
We delete without check whether it existed during exit. This will lead NULL pointer deference since it was created conditionally depends on guest driver status and features. So add a check of existence before trying to delete it. Cc: qemu-sta...@nongnu.org Signed-off-by: Jason Wang

Re: [Qemu-devel] [PATCH] migration: avoid starting a new migration task while the previous one still exist

2013-11-06 Thread Paolo Bonzini
Il 06/11/2013 02:50, Zhanghaoyu (A) ha scritto: Avoid starting a new migration task while the previous one still exist. Can you explain how to reproduce the problem? When network disconnection between source and destination happened, the migration thread stuck at below stack, Then I

Re: [Qemu-devel] [PATCH v4] net: Adding netmap network backend

2013-11-06 Thread Stefan Hajnoczi
On Tue, Nov 05, 2013 at 04:17:23PM +0100, Vincenzo Maffione wrote: +err = ioctl(fd, NIOCREGIF, req); +if (err) { +error_report(Unable to register %s: %s, me-ifname, strerror(err)); Did you mean strerror(errno)? +me-mem = mmap(0, l, PROT_WRITE | PROT_READ, MAP_SHARED, fd,

Re: [Qemu-devel] [PATCH] ossaudio: do not enable by default

2013-11-06 Thread Gerd Hoffmann
On Di, 2013-11-05 at 20:34 +, Peter Maydell wrote: On 5 November 2013 19:57, Anthony Liguori anth...@codemonkey.ws wrote: This patch just requires that you explicitly select oss so it's not breaking audio on BSD. That sounds to me like it's breaking audio for all the users for whom it

Re: [Qemu-devel] [PATCH] qga: Fix shutdown command of guest agent to work with SysV

2013-11-06 Thread Michael Tokarev
06.11.2013 05:54, whitearchey wrote: For now guest agent uses following command to shutdown system: shutdown -P +0 blabla but this syntax works only with shutdown command from systemd or upstart, because SysV shutdown requires -h switch. Following patch changes the command so it works with

Re: [Qemu-devel] [PATCH v5 2/2] sheepdog: support user-defined redundancy option

2013-11-06 Thread Stefan Hajnoczi
On Tue, Nov 05, 2013 at 08:46:07AM -0700, Eric Blake wrote: On 11/05/2013 07:37 AM, Stefan Hajnoczi wrote: + +copy = strtol(n1, NULL, 10); +if (copy SD_MAX_COPIES) { +return -EINVAL; +} The string manipulation can be simplified using sscanf(3) and

Re: [Qemu-devel] [PATCH 1.7] virtio-net: only delete bh that existed

2013-11-06 Thread Paolo Bonzini
Il 06/11/2013 09:58, Jason Wang ha scritto: We delete without check whether it existed during exit. This will lead NULL pointer deference since it was created conditionally depends on guest driver status and features. So add a check of existence before trying to delete it. Cc:

Re: [Qemu-devel] [PATCH 1.7] mips jazz: do not raise data bus exception when accessing invalid addresses

2013-11-06 Thread Paolo Bonzini
Il 04/11/2013 23:26, Hervé Poussineau ha scritto: MIPS Jazz chipset doesn't seem to raise data bus exceptions on invalid accesses. However, there is no easy way to prevent them. Creating a big memory region for the whole address space doesn't prevent memory core to directly call

Re: [Qemu-devel] [PATCH v5] net: Adding netmap network backend

2013-11-06 Thread Stefan Hajnoczi
On Tue, Nov 05, 2013 at 05:42:06PM +0100, Vincenzo Maffione wrote: This patch adds support for a network backend based on netmap. netmap is a framework for high speed packet I/O. You can use it to build extremely fast traffic generators, monitors, software switches or network middleboxes. Its

[Qemu-devel] TARGET_AARCH64

2013-11-06 Thread Phi Debian
Hi All, Browsing the qemu 'latest' src, I see some #define TARGET_AARCH64, does it mean we can boot a qemu-system-arm64 ? Is there some experiment? Cheers, Phi

Re: [Qemu-devel] [PATCH v3 0/7] qdev and blockdev refcount leak fixes

2013-11-06 Thread Stefan Hajnoczi
On Wed, Oct 30, 2013 at 02:54:29PM +0100, Stefan Hajnoczi wrote: v3: * I lost track of this patch, now I'm pushing it again * Rebase onto qemu.git/master * Add Patch 7 to do s/qdev_free()/object_unparent()/ [afaerber] It started with a bug report along these lines: (qemu) device_add

Re: [Qemu-devel] [PATCH] block: Save errno before error_setg_errno

2013-11-06 Thread Stefan Hajnoczi
On Tue, Nov 05, 2013 at 08:03:33PM +0100, Max Reitz wrote: error_setg_errno() may overwrite errno; therefore, its value should be read before calling that function and not afterwards. Signed-off-by: Max Reitz mre...@redhat.com --- block.c | 2 +- 1 file changed, 1 insertion(+), 1

Re: [Qemu-devel] [PATCH] block: Save errno before error_setg_errno

2013-11-06 Thread Stefan Hajnoczi
On Tue, Nov 05, 2013 at 12:26:41PM -0700, Eric Blake wrote: On 11/05/2013 12:03 PM, Max Reitz wrote: error_setg_errno() may overwrite errno; therefore, its value should be read before calling that function and not afterwards. Signed-off-by: Max Reitz mre...@redhat.com --- block.c |

Re: [Qemu-devel] USB Passthrough not working for Windows 7 guest

2013-11-06 Thread Frederich, Jens
-Original Message- From: qemu-devel-bounces+jens.frederich=vector@nongnu.org [mailto:qemu-devel-bounces+jens.frederich=vector@nongnu.org] On Behalf Of Jan Kiszka Sent: Wednesday, November 06, 2013 7:58 AM To: Jens Frederich; qemu-devel@nongnu.org Subject: Re: [Qemu-devel] USB

[Qemu-devel] [PATCH v2 1.7] pc: get rid of builtin pvpanic for -M pc-1.5

2013-11-06 Thread Paolo Bonzini
This causes two slight backwards-incompatibilities between -M pc-1.5 and 1.5's -M pc: (1) a fw_cfg file is removed with this patch. This is only a problem if migration stops the virtual machine exactly during fw_cfg enumeration. (2) after migration, a VM created without an explicit -device

[Qemu-devel] [PATCH v6] .travis.yml: basic compile and check recipes

2013-11-06 Thread alex . bennee
From: Alex Bennée a...@bennee.com This adds a build matrix definition for travis-ci.org continuous integration service. It is usable on any public repository hosted on GitHub. Once you have created an account signed into Travis you can enable it on selected projects via travis-ci.org/profile.

[Qemu-devel] [PATCH v6] Add .travis.yml metadata for CI

2013-11-06 Thread alex . bennee
From: Alex Bennée a...@bennee.com Hi, I think this patch is ready to be merged via trivial. While I was testing it last night it caught yet another regression (register_subpage: Assertion, since fixed) so I think it proves it's worth with that alone. Since v5 - Forced the python to 2.4

[Qemu-devel] [PATCH v6] net: Adding netmap network backend

2013-11-06 Thread Vincenzo Maffione
This patch adds support for a network backend based on netmap. netmap is a framework for high speed packet I/O. You can use it to build extremely fast traffic generators, monitors, software switches or network middleboxes. Its companion software switch VALE lets you interconnect virtual machines.

Re: [Qemu-devel] [PATCH] ossaudio: do not enable by default

2013-11-06 Thread Peter Maydell
On 6 November 2013 09:18, Gerd Hoffmann kra...@redhat.com wrote: I think the audio backend handling needs a serious makeover. Detect sound libraries (pulse, esd, alsa, ...) via configure like any other library. Zap the whole can_be_default logic. Replace it by walking the list of backends,

Re: [Qemu-devel] TARGET_AARCH64

2013-11-06 Thread Peter Maydell
On 6 November 2013 10:25, Phi Debian phi.deb...@gmail.com wrote: Hi All, Browsing the qemu 'latest' src, I see some #define TARGET_AARCH64, does it mean we can boot a qemu-system-arm64 ? Nope. This is preliminary foundation code which we can use to add v8 user-mode emulation (coming soon) and

Re: [Qemu-devel] [PATCH v5] net: Adding netmap network backend

2013-11-06 Thread Vincenzo Maffione
Hi, I'm sorry, the v5 patch doesn't fix the strerror(err) bug because I saw your reply on v4 after I sent v5 to fix what was pointed out by Eric Blake. The v6 patch should hopefully fix also that. Thanks, Vincenzo 2013/11/6 Stefan Hajnoczi stefa...@gmail.com On Tue, Nov 05, 2013 at

Re: [Qemu-devel] Multi-head support RFC

2013-11-06 Thread Gerd Hoffmann
Hi, In QEMU 1.3, there was a DisplayState list. We used one DisplayState per monitor. The DisplayChangeListener has a new hw_add_display vector, so that when the UI requests a second monitor the new display gets attached to the emulated hardware. (patch: add_display_ptr) I don't think

Re: [Qemu-devel] Multi-head support RFC

2013-11-06 Thread Gerd Hoffmann
Hi, It currently just adds multiple DisplaySurfaces to the QemuConsole, now Gerd said he thought I should be using multiple QemuConsoles but I really didn't think this was a good idea, Why? cheers, Gerd

Re: [Qemu-devel] USB Passthrough not working for Windows 7 guest

2013-11-06 Thread Gerd Hoffmann
On Mi, 2013-11-06 at 10:36 +, Frederich, Jens wrote: I'm not sure which mode it has been. I've used the virt-manager to configure the device. A usb controller is already configured in mode 'default'. Flip that to usb 2.

Re: [Qemu-devel] TARGET_AARCH64

2013-11-06 Thread Phi Debian
Exciting. Thanx Peter.

Re: [Qemu-devel] [PATCH] virtio-net: only delete bh that existed

2013-11-06 Thread Michael S. Tsirkin
On Wed, Nov 06, 2013 at 04:58:08PM +0800, Jason Wang wrote: We delete without check whether it existed during exit. This will lead NULL pointer deference since it was created conditionally depends on guest driver status and features. So add a check of existence before trying to delete it.

Re: [Qemu-devel] [PATCH v2] spapr: make sure RMA is in first mode of first memory node

2013-11-06 Thread Thomas Huth
On Wed, 6 Nov 2013 18:54:11 +1100 Alexey Kardashevskiy a...@ozlabs.ru wrote: The SPAPR specification says that the RMA starts at the LPAR's logical address 0 and is the first logical memory block reported in the LPAR’s device tree. So SLOF only maps the first block and that block needs to

Re: [Qemu-devel] [PATCH] ossaudio: do not enable by default

2013-11-06 Thread Gerd Hoffmann
On Mi, 2013-11-06 at 10:48 +, Peter Maydell wrote: That is clearly 1.8 material though. I think for 1.7 we should simply leave things as-is. Do you mean as-is with Anthony's patch applied, or as it was before that patch was applied ? Oh, it is in? I would suggest the latter (ie

Re: [Qemu-devel] USB Passthrough not working for Windows 7 guest

2013-11-06 Thread Frederich, Jens
-Original Message- From: Gerd Hoffmann [mailto:kra...@redhat.com] Sent: Wednesday, November 06, 2013 12:09 PM To: Frederich, Jens Cc: Jan Kiszka; Jens Frederich; qemu-devel@nongnu.org Subject: Re: [Qemu-devel] USB Passthrough not working for Windows 7 guest On Mi, 2013-11-06 at 10:36

Re: [Qemu-devel] [PATCH v2] spapr: make sure RMA is in first mode of first memory node

2013-11-06 Thread Alexander Graf
On 06.11.2013, at 12:13, Thomas Huth th...@linux.vnet.ibm.com wrote: On Wed, 6 Nov 2013 18:54:11 +1100 Alexey Kardashevskiy a...@ozlabs.ru wrote: The SPAPR specification says that the RMA starts at the LPAR's logical address 0 and is the first logical memory block reported in the LPAR’s

Re: [Qemu-devel] [PATCH v2] spapr: make sure RMA is in first mode of first memory node

2013-11-06 Thread Alexander Graf
On 06.11.2013, at 08:54, Alexey Kardashevskiy a...@ozlabs.ru wrote: The SPAPR specification says that the RMA starts at the LPAR's logical address 0 and is the first logical memory block reported in the LPAR’s device tree. So SLOF only maps the first block and that block needs to span the

Re: [Qemu-devel] USB Passthrough not working for Windows 7 guest

2013-11-06 Thread Gerd Hoffmann
the device. A usb controller is already configured in mode 'default'. Flip that to usb 2. Thanks, Gerd. Now I can see the usb controller on Win 7. But my device isn't there... Anything in the logs (/var/log/libvirt/qemu/$guest.log)? cheers, Gerd

Re: [Qemu-devel] [PATCH] spapr: add compat machine option

2013-11-06 Thread Igor Mammedov
On Tue, 05 Nov 2013 14:53:14 +0100 Andreas Färber afaer...@suse.de wrote: Am 05.11.2013 10:52, schrieb Paolo Bonzini: Il 05/11/2013 10:16, Alexander Graf ha scritto: On 05.11.2013, at 10:06, Paolo Bonzini pbonz...@redhat.com wrote: Il 30/09/2013 14:57, Alexey Kardashevskiy ha scritto:

[Qemu-devel] [PATCH] block: Round up total_sectors

2013-11-06 Thread Fam Zheng
Since b94a2610, bdrv_getlength() is omitted when probing image. VMDK monolithicFlat is broken by that because a file 512 bytes can't be read with its total_sectors truncated to 0. This patch round up the size to BDRV_SECTOR_SIZE, when a image size is not sector aligned. Signed-off-by: Fam Zheng

Re: [Qemu-devel] i386: pc: align gpa-hpa on 1GB boundary (v3)

2013-11-06 Thread Igor Mammedov
On Tue, 5 Nov 2013 23:55:43 -0200 Marcelo Tosatti mtosa...@redhat.com wrote: v2: condition enablement of new mapping to new machine types (Paolo) v3: fix changelog - Align guest physical address and host physical address beyond guest 4GB on a 1GB boundary. Otherwise 1GB TLBs

Re: [Qemu-devel] [PATCH v3] qemu-iotests: use blkdebug to make test deterministic

2013-11-06 Thread Stefan Hajnoczi
On Thu, Oct 31, 2013 at 10:18:08AM +0800, Fam Zheng wrote: This patch suspends the test image IO before starting block stream job so that it doesn't complete before we could check the status. Signed-off-by: Fam Zheng f...@redhat.com --- tests/qemu-iotests/030| 10 ++

Re: [Qemu-devel] [PATCH] spapr: add compat machine option

2013-11-06 Thread Alexander Graf
On 06.11.2013, at 06:48, Paul Mackerras pau...@samba.org wrote: On Mon, Sep 30, 2013 at 01:25:32PM +0200, Alexander Graf wrote: On 27.09.2013, at 10:06, Alexey Kardashevskiy wrote: To be able to boot on newer hardware that the software support, PowerISA defines a logical PVR, one per

Re: [Qemu-devel] i386: pc: align gpa-hpa on 1GB boundary (v3)

2013-11-06 Thread Paolo Bonzini
Il 06/11/2013 12:59, Igor Mammedov ha scritto: On Tue, 5 Nov 2013 23:55:43 -0200 Marcelo Tosatti mtosa...@redhat.com wrote: v2: condition enablement of new mapping to new machine types (Paolo) v3: fix changelog - Align guest physical address and host physical address beyond guest

Re: [Qemu-devel] [PATCH v3] qemu-iotests: use blkdebug to make test deterministic

2013-11-06 Thread Paolo Bonzini
Il 31/10/2013 03:18, Fam Zheng ha scritto: This patch suspends the test image IO before starting block stream job so that it doesn't complete before we could check the status. Signed-off-by: Fam Zheng f...@redhat.com --- tests/qemu-iotests/030| 10 ++

Re: [Qemu-devel] [PATCH v3] Fix pc migration from qemu = 1.5

2013-11-06 Thread Michael S. Tsirkin
On Tue, Nov 05, 2013 at 06:46:27PM -0500, Cole Robinson wrote: The following commit introduced a migration incompatibility: commit 568f0690fd9aa4d39d84b04c1a5dbb53a915c3fe Author: David Gibson da...@gibson.dropbear.id.au Date: Thu Jun 6 18:48:49 2013 +1000 pci: Replace

Re: [Qemu-devel] [PATCH] integrator/cp: add support for REFCNTregisterr

2013-11-06 Thread Jan Petrouš
BTW, I just cooked very simple support for PL030 RTC chip, but I guess there is zero interest on it as it seems that PL030 is somehow simplified predecessor of well-known PL031, which in turn, is used on all devboards but Integrator. So, I'm sending it here only for reference. I need to note that

[Qemu-devel] [PATCH 00/80] COW: Speed up writes

2013-11-06 Thread Charlie Shepherd
Following on from Paolo's commits 26ae980 and 276cbc7, this patchset implements some changes he recommended earlier which I didn't previously have time to do while on GSoC. Patch 2 was written initially I was intending to use cow_co_is_allocated in Patch 3 and needed it to consider all sectors

[Qemu-devel] [PATCH 01/80] pc: add etc/e820 fw_cfg file

2013-11-06 Thread Charlie Shepherd
From: Gerd Hoffmann kra...@redhat.com Unlike the existing FW_CFG_E820_TABLE entry which carries reservations only the new etc/e820 file also has entries for RAM. Format is simliar to the FW_CFG_E820_TABLE, it is a simple list of e820_entry structs. Unlike FW_CFG_E820_TABLE it has no count

[Qemu-devel] [PATCH 02/80] pc: register e820 entries for ram

2013-11-06 Thread Charlie Shepherd
From: Gerd Hoffmann kra...@redhat.com So RAM shows up in the new etc/e820 fw_cfg file. Cc: Andrea Arcangeli aarca...@redhat.com Signed-off-by: Gerd Hoffmann kra...@redhat.com Signed-off-by: Charlie Shepherd char...@ctshepherd.com --- hw/i386/pc.c | 8 +--- 1 file changed, 1 insertion(+), 7

Re: [Qemu-devel] [PATCH 01/80] pc: add etc/e820 fw_cfg file

2013-11-06 Thread Charlie Shepherd
Sorry all, some confusion using git-publish, apologies for the spam. Charlie

Re: [Qemu-devel] [PATCH] RFC: powerpc: add PVR compatibility check

2013-11-06 Thread Alexander Graf
On 06.11.2013, at 04:02, Paul Mackerras pau...@samba.org wrote: On Tue, Nov 05, 2013 at 05:16:33PM +0100, Andreas Färber wrote: Am 05.11.2013 07:05, schrieb Alexander Graf: Am 05.11.2013 um 05:00 schrieb Paul Mackerras pau...@samba.org: On Mon, Nov 04, 2013 at 10:05:58AM +0100,

Re: [Qemu-devel] i386: pc: align gpa-hpa on 1GB boundary (v3)

2013-11-06 Thread Igor Mammedov
On Wed, 06 Nov 2013 13:07:26 +0100 Paolo Bonzini pbonz...@redhat.com wrote: Il 06/11/2013 12:59, Igor Mammedov ha scritto: On Tue, 5 Nov 2013 23:55:43 -0200 Marcelo Tosatti mtosa...@redhat.com wrote: v2: condition enablement of new mapping to new machine types (Paolo) v3: fix

[Qemu-devel] [PATCH 2/3] COW: Extend checking allocated bits to beyond one sector

2013-11-06 Thread Charlie Shepherd
cow_co_is_allocated() only checks one sector's worth of allocated bits before returning. This is allowed but (slightly) inefficient, so extend it to check all of the file's metadata sectors. Signed-off-by: Charlie Shepherd char...@ctshepherd.com --- block/cow.c | 36

[Qemu-devel] [PATCH 1/3] COW: Speed up writes

2013-11-06 Thread Charlie Shepherd
Process a whole sector's worth of COW bits by reading a sector, setting the bits, then writing it out again. Make sure we only flush once, before writing metadata. Signed-off-by: Charlie Shepherd char...@ctshepherd.com --- block/cow.c | 79

[Qemu-devel] [PATCH 0/3] COW: Speed up writes

2013-11-06 Thread Charlie Shepherd
Following on from Paolo's commits 26ae980 and 276cbc7, this patchset implements some changes he recommended earlier which I didn't previously have time to do while on GSoC. Patch 2 was written initially I was intending to use cow_co_is_allocated in Patch 3 and needed it to consider all sectors

[Qemu-devel] [PATCH 3/3] COW: Skip setting already set bits

2013-11-06 Thread Charlie Shepherd
Rather than unnecessarily setting bits that are already set, re-use cow_find_streak to find how many bits are already set for this sector, and only set unset bits. Do this before the flush to avoid it if no bits need to be set at all. Signed-off-by: Charlie Shepherd char...@ctshepherd.com ---

Re: [Qemu-devel] i386: pc: align gpa-hpa on 1GB boundary (v3)

2013-11-06 Thread Paolo Bonzini
Il 06/11/2013 13:22, Igor Mammedov ha scritto: 'gb_align' is one shot usage, it would be better to just add it as an argument to pc_memory_init(). That would allow to avoid extending PcGuestInfo needlessly, since gb_align isn't reused. No, Marcelo's way is better.

Re: [Qemu-devel] [PATCH 1/3] COW: Speed up writes

2013-11-06 Thread Paolo Bonzini
Il 06/11/2013 13:23, Charlie Shepherd ha scritto: Process a whole sector's worth of COW bits by reading a sector, setting the bits, then writing it out again. Make sure we only flush once, before writing metadata. Signed-off-by: Charlie Shepherd char...@ctshepherd.com --- block/cow.c |

Re: [Qemu-devel] [PATCH 3/3] COW: Skip setting already set bits

2013-11-06 Thread Paolo Bonzini
Il 06/11/2013 13:23, Charlie Shepherd ha scritto: +set = cow_find_streak(bitmap, 1, bitnum, sector_bits); +if (set == sector_bits) { +continue; I think this shouldn't be a continue; these lines should be executed: bitnum += sector_bits; nb_sectors

Re: [Qemu-devel] [PATCH 2/3] COW: Extend checking allocated bits to beyond one sector

2013-11-06 Thread Paolo Bonzini
Il 06/11/2013 13:23, Charlie Shepherd ha scritto: cow_co_is_allocated() only checks one sector's worth of allocated bits before returning. This is allowed but (slightly) inefficient, so extend it to check all of the file's metadata sectors. Signed-off-by: Charlie Shepherd

Re: [Qemu-devel] [PATCH 3/3] COW: Skip setting already set bits

2013-11-06 Thread Charlie Shepherd
On 06/11/2013 12:29, Paolo Bonzini wrote: Il 06/11/2013 13:23, Charlie Shepherd ha scritto: +set = cow_find_streak(bitmap, 1, bitnum, sector_bits); +if (set == sector_bits) { +continue; I think this shouldn't be a continue; these lines should be executed:

Re: [Qemu-devel] [Qemu-trivial] [PATCH v6] .travis.yml: basic compile and check recipes

2013-11-06 Thread Michael Tokarev
06.11.2013 14:43, alex.ben...@linaro.org wrote: From: Alex Bennée a...@bennee.com This adds a build matrix definition for travis-ci.org [] Thanks, applied to the trivial-patches queue. With one tiny fix -- removed trailing whitespace in the line - TARGETS=m68k-softmmu /mjt

Re: [Qemu-devel] [PATCH 0/3] COW: Speed up writes

2013-11-06 Thread Paolo Bonzini
Il 06/11/2013 13:23, Charlie Shepherd ha scritto: Patch 2 was written initially I was intending to use cow_co_is_allocated in Patch 3 and needed it to consider all sectors but in the end cow_find_streak was sufficient, so it may not strictly be necessary. Patch 2 can still speed up reads that

Re: [Qemu-devel] [PATCH v2 5/6] xilinx_zynq: add pl353

2013-11-06 Thread vbalaji
Hi, I want to emulate PL35x SMC controller with Nand flash as a device. Though I got the patch from the following link. http://qemu.11.n7.nabble.com/Qemu-devel-PATCH-v1-0-7-QOMify-pflash-cfi0x-PL353-for-Xilinx-Zynq-td167995.html. I dont know how to test the nand flash with the SMC controller.

Re: [Qemu-devel] [PATCH] block/vpc: fix virtual size for images created with disk2vhd

2013-11-06 Thread Stefan Hajnoczi
On Mon, Oct 21, 2013 at 04:00:18PM +0200, Peter Lieven wrote: Signed-off-by: Peter Lieven p...@kamp.de --- block/vpc.c |9 + 1 file changed, 9 insertions(+) Thanks, applied to my block tree: https://github.com/stefanha/qemu/commits/block Stefan

[Qemu-devel] [PATCH for-1.7 v2] pc: disable pci-info

2013-11-06 Thread Igor Mammedov
The BIOS that we ship in 1.7 does not use pci info from host and so far isn't going to use it. Taking in account problems it caused see 9604f70fdf and to avoid future incompatibility issues, it's safest to disable that interface by default for all machine types including 1.7 as it was never

[Qemu-devel] [PATCH v2 2/3] COW: Extend checking allocated bits to beyond one sector

2013-11-06 Thread Charlie Shepherd
cow_co_is_allocated() only checks one sector's worth of allocated bits before returning. This is allowed but (slightly) inefficient, so extend it to check all of the file's metadata sectors. Signed-off-by: Charlie Shepherd char...@ctshepherd.com Reviewed-by: Paolo Bonzini pbonz...@redhat.com

[Qemu-devel] [PATCH v2 3/3] COW: Skip setting already set bits

2013-11-06 Thread Charlie Shepherd
Rather than unnecessarily setting bits that are already set, re-use cow_find_streak to find how many bits are already set for this sector, and only set unset bits. Do this before the flush to avoid it if no bits need to be set at all. Signed-off-by: Charlie Shepherd char...@ctshepherd.com ---

[Qemu-devel] [PATCH v2 1/3] COW: Speed up writes

2013-11-06 Thread Charlie Shepherd
Process a whole sector's worth of COW bits by reading a sector, setting the bits, then writing it out again. Make sure we only flush once, before writing metadata. Signed-off-by: Charlie Shepherd char...@ctshepherd.com --- block/cow.c | 79

[Qemu-devel] [PATCH v2 0/3] COW: Speed up writes

2013-11-06 Thread Charlie Shepherd
v2: - Fix bit position calculations in cow_update_bitmap - Add necessary check in cow_set_bits Following on from Paolo's commits 26ae980 and 276cbc7, this patchset implements some changes he recommended earlier which I didn't previously have time to do while on GSoC. Charlie Shepherd (3):

Re: [Qemu-devel] [PATCH v2 3/3] COW: Skip setting already set bits

2013-11-06 Thread Paolo Bonzini
Il 06/11/2013 13:56, Charlie Shepherd ha scritto: Rather than unnecessarily setting bits that are already set, re-use cow_find_streak to find how many bits are already set for this sector, and only set unset bits. Do this before the flush to avoid it if no bits need to be set at all.

[Qemu-devel] [PATCH 08/39] exec: simplify notdirty_mem_write()

2013-11-06 Thread Juan Quintela
We don't need to make special things for CODE, just set the other two bits Signed-off-by: Juan Quintela quint...@redhat.com --- exec.c | 8 ++-- 1 file changed, 2 insertions(+), 6 deletions(-) diff --git a/exec.c b/exec.c index 36b0a66..27e4540 100644 --- a/exec.c +++ b/exec.c @@ -1374,12

[Qemu-devel] [PATCH 06/39] exec: create function to get a single dirty bit

2013-11-06 Thread Juan Quintela
Signed-off-by: Juan Quintela quint...@redhat.com --- exec.c | 3 ++- include/exec/memory-internal.h | 6 ++ 2 files changed, 8 insertions(+), 1 deletion(-) diff --git a/exec.c b/exec.c index 7cf5634..36b0a66 100644 --- a/exec.c +++ b/exec.c @@ -1374,9 +1374,10 @@

[Qemu-devel] [PATCH 02/39] memory: cpu_physical_memory_set_dirty_flags() result is never used

2013-11-06 Thread Juan Quintela
So return void. Signed-off-by: Juan Quintela quint...@redhat.com --- include/exec/memory-internal.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/include/exec/memory-internal.h b/include/exec/memory-internal.h index d0e0633..c71a5e6 100644 ---

[Qemu-devel] [PATCH 05/39] memory: create function to set a single dirty bit

2013-11-06 Thread Juan Quintela
Signed-off-by: Juan Quintela quint...@redhat.com --- cputlb.c | 2 +- include/exec/memory-internal.h | 6 ++ 2 files changed, 7 insertions(+), 1 deletion(-) diff --git a/cputlb.c b/cputlb.c index fff0afb..72452e5 100644 --- a/cputlb.c +++ b/cputlb.c @@ -137,7 +137,7 @@

[Qemu-devel] [PATCH 04/39] exec: use accessor function to know if memory is dirty

2013-11-06 Thread Juan Quintela
Signed-off-by: Juan Quintela quint...@redhat.com --- exec.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/exec.c b/exec.c index 79610ce..7cf5634 100644 --- a/exec.c +++ b/exec.c @@ -1397,7 +1397,7 @@ static void notdirty_mem_write(void *opaque, hwaddr ram_addr,

[Qemu-devel] [PATCH 07/39] memory: make cpu_physical_memory_is_dirty return bool

2013-11-06 Thread Juan Quintela
Signed-off-by: Juan Quintela quint...@redhat.com --- include/exec/memory-internal.h | 7 +-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/include/exec/memory-internal.h b/include/exec/memory-internal.h index 9cd2f53..eefe501 100644 --- a/include/exec/memory-internal.h +++

[Qemu-devel] [PATCH 12/39] memory: cpu_physical_memory_mask_dirty_range() always clear a single flag

2013-11-06 Thread Juan Quintela
Document it Signed-off-by: Juan Quintela quint...@redhat.com --- exec.c | 4 ++-- include/exec/memory-internal.h | 12 ++-- 2 files changed, 8 insertions(+), 8 deletions(-) diff --git a/exec.c b/exec.c index 3fd7616..94076ae 100644 --- a/exec.c +++ b/exec.c @@

[Qemu-devel] [PATCH 03/39] memory: cpu_physical_memory_set_dirty_range() return void

2013-11-06 Thread Juan Quintela
Signed-off-by: Juan Quintela quint...@redhat.com --- memory.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/memory.c b/memory.c index 28f6449..9722f23 100644 --- a/memory.c +++ b/memory.c @@ -1182,7 +1182,7 @@ void memory_region_set_dirty(MemoryRegion *mr, hwaddr addr,

[Qemu-devel] [PATCH 20/39] memory: unfold cpu_physical_memory_clear_dirty_flag() in its only user

2013-11-06 Thread Juan Quintela
Signed-off-by: Juan Quintela quint...@redhat.com --- include/exec/memory-internal.h | 8 +--- 1 file changed, 1 insertion(+), 7 deletions(-) diff --git a/include/exec/memory-internal.h b/include/exec/memory-internal.h index 71f198e..d6d3537 100644 --- a/include/exec/memory-internal.h +++

[Qemu-devel] [PATCH 15/39] memory: make sure that client is always inside range

2013-11-06 Thread Juan Quintela
Signed-off-by: Juan Quintela quint...@redhat.com --- include/exec/memory-internal.h | 4 1 file changed, 4 insertions(+) diff --git a/include/exec/memory-internal.h b/include/exec/memory-internal.h index 3947caa..e08ac42 100644 --- a/include/exec/memory-internal.h +++

[Qemu-devel] [PATCH 13/39] memory: use DIRTY_MEMORY_* instead of *_DIRTY_FLAG

2013-11-06 Thread Juan Quintela
Instead of the bitmap, we use the bitmap number. Once this is done, we change all names from dirty_flag to memory regions naming of client. Signed-off-by: Juan Quintela quint...@redhat.com --- cputlb.c | 4 ++-- exec.c | 18 +-

[Qemu-devel] [PATCH 11/39] memory: cpu_physical_memory_set_dirty_range() allways dirty all flags

2013-11-06 Thread Juan Quintela
So remove the flag argument and do it directly. After this change, there is nothing else using cpu_physical_memory_set_dirty_flags() so remove it. Signed-off-by: Juan Quintela quint...@redhat.com --- exec.c | 2 +- include/exec/memory-internal.h | 11 ++-

[Qemu-devel] [PATCH 24/39] memory: cpu_physical_memory_get_dirty() is used as returning a bool

2013-11-06 Thread Juan Quintela
Signed-off-by: Juan Quintela quint...@redhat.com --- include/exec/memory-internal.h | 13 +++-- 1 file changed, 7 insertions(+), 6 deletions(-) diff --git a/include/exec/memory-internal.h b/include/exec/memory-internal.h index f66d2ce..de8f279 100644 --- a/include/exec/memory-internal.h

[Qemu-devel] [PATCH 18/39] bitmap: Add bitmap_zero_extend operation

2013-11-06 Thread Juan Quintela
Signed-off-by: Juan Quintela quint...@redhat.com --- include/qemu/bitmap.h | 9 + 1 file changed, 9 insertions(+) diff --git a/include/qemu/bitmap.h b/include/qemu/bitmap.h index 308bbb7..53f5f1f 100644 --- a/include/qemu/bitmap.h +++ b/include/qemu/bitmap.h @@ -219,4 +219,13 @@ unsigned

Re: [Qemu-devel] [PATCH] block: Round up total_sectors

2013-11-06 Thread Benoît Canet
Le Wednesday 06 Nov 2013 à 19:48:06 (+0800), Fam Zheng a écrit : Since b94a2610, bdrv_getlength() is omitted when probing image. VMDK monolithicFlat is broken by that because a file 512 bytes can't be read with its total_sectors truncated to 0. This patch round up the size to

[Qemu-devel] [PATCH 09/39] memory: all users of cpu_physical_memory_get_dirty used only one flag

2013-11-06 Thread Juan Quintela
So cpu_physical_memory_get_dirty_flags is not needed anymore Signed-off-by: Juan Quintela quint...@redhat.com --- include/exec/memory-internal.h | 9 ++--- 1 file changed, 2 insertions(+), 7 deletions(-) diff --git a/include/exec/memory-internal.h b/include/exec/memory-internal.h index

[Qemu-devel] [PATCH 25/39] memory: s/mask/clear/ cpu_physical_memory_mask_dirty_range

2013-11-06 Thread Juan Quintela
Now all functions use the same wording that bitops/bitmap operations Signed-off-by: Juan Quintela quint...@redhat.com --- exec.c | 2 +- include/exec/memory-internal.h | 6 +++--- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/exec.c b/exec.c index

[Qemu-devel] [PATCH 19/39] memory: split dirty bitmap into three

2013-11-06 Thread Juan Quintela
After all the previous patches, spliting the bitmap gets direct. ToDo: Why can't i include exec/memory.h into cpu-all.h? This is the reason that I have duplicated DIRTY_MEMORY_NUM. ToDo2: current bitmaps have one int as index, this limit us to 8TB RAM guest, Should we move to

[Qemu-devel] [PATCH 16/39] memory: only resize dirty bitmap when memory size increases

2013-11-06 Thread Juan Quintela
Signed-off-by: Juan Quintela quint...@redhat.com --- exec.c | 12 +--- 1 file changed, 9 insertions(+), 3 deletions(-) diff --git a/exec.c b/exec.c index 64a621f..38b5c1c 100644 --- a/exec.c +++ b/exec.c @@ -1100,6 +1100,9 @@ ram_addr_t qemu_ram_alloc_from_ptr(ram_addr_t size, void

Re: [Qemu-devel] [PATCHv7 00/17] block: logical block provisioning enhancements

2013-11-06 Thread Stefan Hajnoczi
On Thu, Oct 24, 2013 at 12:06:49PM +0200, Peter Lieven wrote: this patch adds the ability for targets to stay sparse during block migration (if the zero_blocks capability is set) and qemu-img convert even if the target does not have has_zero_init = 1. the series was especially developed for

[Qemu-devel] [PATCH 22/39] memory: unfold cpu_physical_memory_set_dirty_flag()

2013-11-06 Thread Juan Quintela
Signed-off-by: Juan Quintela quint...@redhat.com --- include/exec/memory-internal.h | 9 ++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/include/exec/memory-internal.h b/include/exec/memory-internal.h index 5fc4eb6..e56f43b 100644 --- a/include/exec/memory-internal.h +++

[Qemu-devel] [PATCH 26/39] memory: use find_next_bit() to find dirty bits

2013-11-06 Thread Juan Quintela
This operation is way faster than doing it bit by bit. Signed-off-by: Juan Quintela quint...@redhat.com --- include/exec/memory-internal.h | 15 ++- 1 file changed, 6 insertions(+), 9 deletions(-) diff --git a/include/exec/memory-internal.h b/include/exec/memory-internal.h index

[Qemu-devel] [PATCH 29/39] memory: s/dirty/clean/ in cpu_physical_memory_is_dirty()

2013-11-06 Thread Juan Quintela
All uses except one really want the other meaning. Signed-off-by: Juan Quintela quint...@redhat.com --- cputlb.c | 2 +- exec.c | 6 +++--- include/exec/memory-internal.h | 5 ++--- 3 files changed, 6 insertions(+), 7 deletions(-) diff --git

[Qemu-devel] [PATCH 30/39] memory: make cpu_physical_memory_reset_dirty() take a length parameter

2013-11-06 Thread Juan Quintela
We have an end parameter in all the callers, and this make it coherent with the rest of cpu_physical_memory_* functions, that also take a length parameter. Once here, move the start/end calculation to tlb_reset_dirty_range_all() as we don't need it here anymore. Signed-off-by: Juan Quintela

[Qemu-devel] [PATCH 27/39] memory: cpu_physical_memory_set_dirty_range() now uses bitmap operations

2013-11-06 Thread Juan Quintela
We were setting a range of bits, so use bitmap_set(). Note: xen has always been wrong, and should have used start instead of addr from the beggining. Signed-off-by: Juan Quintela quint...@redhat.com --- include/exec/memory-internal.h | 19 +++ 1 file changed, 7 insertions(+), 12

[Qemu-devel] [PATCH 34/39] kvm: use directly cpu_physical_memory_* api for tracking dirty pages

2013-11-06 Thread Juan Quintela
Performance is important in this function, and we want to optimize even further. Signed-off-by: Juan Quintela quint...@redhat.com --- kvm-all.c | 7 +-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/kvm-all.c b/kvm-all.c index 4478969..963c2d1 100644 --- a/kvm-all.c +++

[Qemu-devel] [PATCH 32/39] memory: split cpu_physical_memory_* functions to its own include

2013-11-06 Thread Juan Quintela
So we know who is using the bitmap directly Signed-off-by: Juan Quintela quint...@redhat.com --- cputlb.c | 1 + exec.c | 1 + include/exec/memory-internal.h | 69 include/exec/memory-physical.h | 90

[Qemu-devel] [PATCH 37/39] memory: syncronize kvm bitmap using bitmaps operations

2013-11-06 Thread Juan Quintela
If bitmaps are aligned properly, use bitmap operations. If they are not, just use old bit at a time code. Signed-off-by: Juan Quintela quint...@redhat.com --- include/exec/memory-physical.h | 54 +- 1 file changed, 38 insertions(+), 16 deletions(-) diff

[Qemu-devel] [PATCH 31/39] memory: cpu_physical_memory_set_dirty_tracking() should return void

2013-11-06 Thread Juan Quintela
Result was always 0, and not used anywhere. Once there, use bool type for the parameter. Signed-off-by: Juan Quintela quint...@redhat.com --- exec.c | 10 -- 1 file changed, 4 insertions(+), 6 deletions(-) diff --git a/exec.c b/exec.c index 984b417..11b434b 100644 --- a/exec.c +++

[Qemu-devel] [PATCH 33/39] memory: unfold memory_region_test_and_clear()

2013-11-06 Thread Juan Quintela
We are going to update the bitmap directly Signed-off-by: Juan Quintela quint...@redhat.com --- arch_init.c | 10 +++--- 1 file changed, 7 insertions(+), 3 deletions(-) diff --git a/arch_init.c b/arch_init.c index 7545d96..72ef993 100644 --- a/arch_init.c +++ b/arch_init.c @@ -48,6 +48,7 @@

[Qemu-devel] [PATCH 39/39] migration: synchronize memory bitmap 64bits at a time

2013-11-06 Thread Juan Quintela
We use the old code if the bitmaps are not aligned Signed-off-by: Juan Quintela quint...@redhat.com --- arch_init.c | 43 ++- 1 file changed, 34 insertions(+), 9 deletions(-) diff --git a/arch_init.c b/arch_init.c index fe88d64..0909531 100644 ---

  1   2   3   4   >