[Qemu-devel] [PATCH] PPC: KVM: Add missing address space to ldl_phys helper

2014-02-14 Thread Alexander Graf
We now have to pass an address space to our _phys helpers. During the transition apparently the EPR exit path missed out, so let's put it there. Signed-off-by: Alexander Graf ag...@suse.de --- target-ppc/kvm.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/target-ppc/kvm.c

Re: [Qemu-devel] Looking for project ideas and mentors for Google Summer of Code 2014

2014-02-14 Thread Jan Kiszka
On 2014-02-11 11:17, Stefan Hajnoczi wrote: On Mon, Feb 3, 2014 at 8:45 AM, Stefan Hajnoczi stefa...@gmail.com wrote: Project ideas Please post project ideas on the wiki page below. Project ideas should be suitable as a 12-week project that a student fluent in C/Python/etc can complete. No

Re: [Qemu-devel] [PATCH v4 0/8] spapr: bootindex support

2014-02-14 Thread Alexey Kardashevskiy
On 02/14/2014 06:29 PM, Paolo Bonzini wrote: Il 14/02/2014 04:25, Alexey Kardashevskiy ha scritto: Nobody seems picking up the bits I am interested in from this :-/ What can I possibly do to get this in upstream?... I feel I am doing something systematically wrong but nobody is telling me what

Re: [Qemu-devel] [PATCH v2] SPARC: Add and use CPU_FEATURE_CASA

2014-02-14 Thread Sebastian Huber
On 2014-02-13 16:50, Fabien Chouteau wrote: On 02/13/2014 03:55 PM, Fabien Chouteau wrote: On 02/13/2014 02:00 PM, Sebastian Huber wrote: On 2014-02-13 13:01, Fabien Chouteau wrote: On 02/13/2014 10:52 AM, Sebastian Huber wrote: The LEON3 processor has support for the CASA instruction which

Re: [Qemu-devel] [PATCH] PPC: KVM: Add missing address space to ldl_phys helper

2014-02-14 Thread Peter Maydell
On 14 February 2014 08:15, Alexander Graf ag...@suse.de wrote: We now have to pass an address space to our _phys helpers. During the transition apparently the EPR exit path missed out, so let's put it there. Signed-off-by: Alexander Graf ag...@suse.de I assume this is a compile failure -- do

Re: [Qemu-devel] [pve-devel] QEMU LIve Migration - swap_free: Bad swap file entry

2014-02-14 Thread Dr. David Alan Gilbert
* Stefan Priebe (s.pri...@profihost.ag) wrote: Am 13.02.2014 21:06, schrieb Dr. David Alan Gilbert: * Stefan Priebe (s.pri...@profihost.ag) wrote: Am 10.02.2014 17:07, schrieb Dr. David Alan Gilbert: * Stefan Priebe (s.pri...@profihost.ag) wrote: i could fix it by explicitly disable xbzrle

Re: [Qemu-devel] [PATCH] PPC: KVM: Add missing address space to ldl_phys helper

2014-02-14 Thread Alexander Graf
On 14.02.2014, at 09:53, Peter Maydell peter.mayd...@linaro.org wrote: On 14 February 2014 08:15, Alexander Graf ag...@suse.de wrote: We now have to pass an address space to our _phys helpers. During the transition apparently the EPR exit path missed out, so let's put it there.

Re: [Qemu-devel] [PATCH V6 03/10] qapi script: check correctness of discriminator values in union

2014-02-14 Thread Markus Armbruster
Wenchao Xia xiaw...@linux.vnet.ibm.com writes: 于 2014/2/13 23:14, Markus Armbruster 写道: Wenchao Xia xiaw...@linux.vnet.ibm.com writes: It will check whether the values specified are written correctly, and whether all enum values are covered, when discriminator is a pre-defined enum type

Re: [Qemu-devel] [Qemu-ppc] [PATCH] target-ppc: fix 32 bit build break in the page table lookup code

2014-02-14 Thread Alexander Graf
On 13.02.2014, at 17:54, Greg Kurz gk...@linux.vnet.ibm.com wrote: On Thu, 13 Feb 2014 15:53:16 +0100 Alexander Graf ag...@suse.de wrote: On 13.02.2014, at 04:00, Aneesh Kumar K.V aneesh.ku...@linux.vnet.ibm.com wrote: Greg Kurz gk...@linux.vnet.ibm.com writes: The 396bb9874 commit

Re: [Qemu-devel] [PATCH v3 0/3] spapr: fix H_SET_MODE

2014-02-14 Thread Alexey Kardashevskiy
On 02/11/2014 11:16 PM, Alexey Kardashevskiy wrote: On 02/11/2014 11:12 PM, Alexander Graf wrote: On 02/11/2014 08:44 AM, Alexey Kardashevskiy wrote: On 01/22/2014 04:43 PM, Alexey Kardashevskiy wrote: This fixes H_SET_MODE. Alexey Kardashevskiy (3): target-ppc: introduce

Re: [Qemu-devel] [PATCH] Fix two XBZRLE corruption issues

2014-02-14 Thread Gonglei (Arei)
Best regards, -Gonglei -Original Message- From: qemu-devel-bounces+arei.gonglei=huawei@nongnu.org [mailto:qemu-devel-bounces+arei.gonglei=huawei@nongnu.org] On Behalf Of Dr. David Alan Gilbert (git) Sent: Friday, February 14, 2014 3:45 AM To: qemu-devel@nongnu.org Cc:

Re: [Qemu-devel] [PATCH] Fix two XBZRLE corruption issues

2014-02-14 Thread Dr. David Alan Gilbert
* Gonglei (Arei) (arei.gong...@huawei.com) wrote: Best regards, -Gonglei snip } else if (!ram_bulk_stage migrate_use_xbzrle()) { -current_addr = block-offset + offset; bytes_sent = save_xbzrle_page(f, p, current_addr, block,

Re: [Qemu-devel] [PATCH 0/7] virtio endian-ambivalent target fixes.

2014-02-14 Thread Greg Kurz
On Thu, 17 Oct 2013 14:23:35 +1030 Rusty Russell ru...@rustcorp.com.au wrote: This is a re-transmit of the core of the virtio endian code. Since there seems to be some interest in ARM BE virtio, I've separated this from the direct problem I was solving: PowerPC LE. Please apply! Rusty.

Re: [Qemu-devel] [PATCH v3] QMP: Allow dot separated dict path arguments in qmp-shell

2014-02-14 Thread Stefan Hajnoczi
On Wed, Feb 12, 2014 at 11:05:13AM +0800, Fam Zheng wrote: As another convinience to allow using commands that expect a dict as argument, this patch adds support for foo.bar=value syntax, similar to command line argument style: (QEMU) blockdev-add options.driver=file options.id=drive1

Re: [Qemu-devel] [PATCH] Fix two XBZRLE corruption issues

2014-02-14 Thread Gonglei (Arei)
-Original Message- From: Dr. David Alan Gilbert [mailto:dgilb...@redhat.com] Sent: Friday, February 14, 2014 5:35 PM To: Gonglei (Arei) Cc: qemu-devel@nongnu.org; owass...@redhat.com; quint...@redhat.com Subject: Re: [Qemu-devel] [PATCH] Fix two XBZRLE corruption issues * Gonglei

Re: [Qemu-devel] [PATCH] Fix two XBZRLE corruption issues

2014-02-14 Thread Orit Wasserman
On 02/13/2014 09:44 PM, Dr. David Alan Gilbert (git) wrote: From: Dr. David Alan Gilbert dgilb...@redhat.com Push zero'd pages into the XBZRLE cache A page that was cached by XBZRLE, zero'd and then XBZRLE'd again was being compared against a stale cache value Don't use

Re: [Qemu-devel] net: Adding netmap network backend

2014-02-14 Thread Stefan Hajnoczi
On Wed, Feb 12, 2014 at 10:01:01PM +0400, Michael Tokarev wrote: After this patch, qemu fails to build on freebsd with the following error message: net/netmap.c: In function 'netmap_receive_iov': net/netmap.c:307: error: 'NS_MOREFRAG' undeclared (first use in this function)

Re: [Qemu-devel] [PATCH 0/2] Make open by reference use id then node-name

2014-02-14 Thread Kevin Wolf
[ CC Stefan ] Am 12.02.2014 um 17:15 hat Benoît Canet geschrieben: This series was asked by Kevin. It sit on top of the snapshot fix patch and max openv2 series. I have done the following tests. check qemu-iotest ok snapshot blockbackend by id ok open quorum by node-name reference and

Re: [Qemu-devel] [PATCH] blockdev: Fix wrong usage of QDECREF causing snapshoted quorum to crash on close.

2014-02-14 Thread Kevin Wolf
Am 13.02.2014 um 17:22 hat Benoît Canet geschrieben: As bdrv_open() documentation states: The reference to the QDict belongs to the block layer * after the call (even on failure), so if the caller intends to reuse the * dictionary, it needs to use QINCREF() before calling bdrv_open. the

Re: [Qemu-devel] Looking for project ideas and mentors for Google Summer of Code 2014

2014-02-14 Thread Stefan Hajnoczi
On Fri, Feb 14, 2014 at 09:16:19AM +0100, Jan Kiszka wrote: On 2014-02-11 11:17, Stefan Hajnoczi wrote: On Mon, Feb 3, 2014 at 8:45 AM, Stefan Hajnoczi stefa...@gmail.com wrote: Project ideas Please post project ideas on the wiki page below. Project ideas should be suitable as a 12-week

Re: [Qemu-devel] net: Adding netmap network backend

2014-02-14 Thread Vincenzo Maffione
Yes, for sure we need to do a check. However, this would involve - I think - some non-trivial modifications to net/netmap.c, because without NS_MOREFRAG you cannot split a packet over more netmap slots/descriptors (both tx and rx side) Therefore I would ask (manly Luigi, since netmap is in-tree

Re: [Qemu-devel] net: Adding netmap network backend

2014-02-14 Thread Luigi Rizzo
On Fri, Feb 14, 2014 at 2:20 AM, Vincenzo Maffione v.maffi...@gmail.comwrote: Yes, for sure we need to do a check. However, this would involve - I think - some non-trivial modifications to net/netmap.c, because without NS_MOREFRAG you cannot split a packet over more netmap slots/descriptors

Re: [Qemu-devel] [libvirt-users] Adjust disk image migration (NBD)

2014-02-14 Thread Michal Privoznik
On 14.02.2014 10:40, Joaquim Barrera wrote: Hi all, As I am doing some tests with qemu, I realized that the way it does 'migrate -i tcp:DEST:444' is not the same as 'libvirt migrate --copy-storage-inc'. Basically qemu uses the same stream as RAM migration and libvirt takes advantage of

Re: [Qemu-devel] [PATCH] PPC: KVM: Add missing address space to ldl_phys helper

2014-02-14 Thread Peter Maydell
On 14 February 2014 09:13, Alexander Graf ag...@suse.de wrote: On 14.02.2014, at 09:53, Peter Maydell peter.mayd...@linaro.org wrote: On 14 February 2014 08:15, Alexander Graf ag...@suse.de wrote: We now have to pass an address space to our _phys helpers. During the transition apparently the

Re: [Qemu-devel] [PATCH 0/7] virtio endian-ambivalent target fixes.

2014-02-14 Thread Andreas Färber
Hi, Am 14.02.2014 10:38, schrieb Greg Kurz: On Thu, 17 Oct 2013 14:23:35 +1030 Rusty Russell ru...@rustcorp.com.au wrote: This is a re-transmit of the core of the virtio endian code. Since there seems to be some interest in ARM BE virtio, I've separated this from the direct problem I was

Re: [Qemu-devel] [PATCH RFC] char: fix avail_connections init in qemu_chr_open_eventfd()

2014-02-14 Thread David Marchand
Hello Cam, On Thu, Feb 13, 2014 at 7:58 PM, Cam Macdonell c...@cs.ualberta.ca wrote: I'm not sure which is the correct approach. You could either do what you did or you could simply remove the qemu_chr_fe_claim_no_fail() from ivshmem.c. I'm not sure how your change impacts other devices.

Re: [Qemu-devel] who should I report this to?

2014-02-14 Thread Stefan Hajnoczi
On Sat, Feb 01, 2014 at 10:04:23PM -0500, Aryeh Friedman wrote: Under kvm (ubuntu 12.04.03 LTS) when logged in via VNC and installing 10-RELEASE the installer just boots you during the disk initialization phase. Who should this be reported to? Just came across this email. If you haven't

Re: [Qemu-devel] [PATCH 0/3] glib: move compat functions into glib-compat.h

2014-02-14 Thread Stefan Hajnoczi
On Mon, Feb 03, 2014 at 02:31:47PM +0100, Stefan Hajnoczi wrote: glib has deprecated APIs like GStaticMutex, g_thread_create(), and others. In QEMU support both old and new APIs since using deprecated APIs would flood us with warnings but legacy distros must continue to build the QEMU source

Re: [Qemu-devel] Improving patch tracking - something like gerrit?

2014-02-14 Thread Stefan Hajnoczi
On Mon, Feb 03, 2014 at 12:45:31PM +, Mark Cave-Ayland wrote: Is it time for QEMU to start looking at tools such as gerrit to help manage this process? This has been addressed by Daniel Berrange but I just wanted to add my vote *against* gerrit. Instead, look at tools that correlate

Re: [Qemu-devel] [PATCH] block: Add notes to iSCSI's .bdrv_open and .bdrv_reopen_prepare

2014-02-14 Thread Stefan Hajnoczi
On Tue, Feb 04, 2014 at 02:12:44PM -0500, Jeff Cody wrote: iSCSI currently does not need to do any actions to support the current usage of bdrv_reopen(). However, it is important to note a couple of things: 1.) A connection will not be re-established to an iSCSI target, and 2.) If

Re: [Qemu-devel] [Qemu-ppc] [PATCH V10] target-ppc: Fix htab_mask calculation

2014-02-14 Thread Alexander Graf
On 13.02.2014, at 15:51, Alexander Graf ag...@suse.de wrote: On 13.02.2014, at 11:40, Greg Kurz gk...@linux.vnet.ibm.com wrote: On Thu, 13 Feb 2014 08:29:28 +0530 Aneesh Kumar K.V aneesh.ku...@linux.vnet.ibm.com wrote: From: Aneesh Kumar K.V aneesh.ku...@linux.vnet.ibm.com Correctly

Re: [Qemu-devel] net: Adding netmap network backend

2014-02-14 Thread Vincenzo Maffione
Stefan, It is ok for you if I prepare a patch (touching configure and net/netmap.c) that makes sure the host kernel has the minimum netmap version required for QEMU to work (and if not just --disable-netmap)? Cheers, Vincenzo 2014-02-14 11:24 GMT+01:00 Luigi Rizzo ri...@iet.unipi.it:

[Qemu-devel] Make virtio-net.c ring size configurable?

2014-02-14 Thread Luke Gorrie
Howdy! Observation: virtio-net.c hard-codes the vring size to 256 buffers. Could this reasonably be made configurable, or would that be likely to cause a problem? In Snabb Switch we are creating a 1:1 mapping between Virtio-net descriptors and VMDq hardware receive descriptors. The VMDq queues

Re: [Qemu-devel] [PATCH v2] SPARC: Add and use CPU_FEATURE_CASA

2014-02-14 Thread Fabien Chouteau
On 02/14/2014 09:41 AM, Sebastian Huber wrote: On 2014-02-13 16:50, Fabien Chouteau wrote: This ASI 0x80 is really defined nowhere in Leon3 not even in the sources :) Maybe there's a bug in binutils... Did you try to run this program on a real board? Yes, I tested it on a NGMP board with

Re: [Qemu-devel] [Qemu-ppc] [PATCH V10] target-ppc: Fix htab_mask calculation

2014-02-14 Thread Alexander Graf
On 14.02.2014, at 14:06, Alexander Graf ag...@suse.de wrote: On 13.02.2014, at 15:51, Alexander Graf ag...@suse.de wrote: On 13.02.2014, at 11:40, Greg Kurz gk...@linux.vnet.ibm.com wrote: On Thu, 13 Feb 2014 08:29:28 +0530 Aneesh Kumar K.V aneesh.ku...@linux.vnet.ibm.com wrote:

Re: [Qemu-devel] [PATCH v2] SPARC: Add and use CPU_FEATURE_CASA

2014-02-14 Thread Andreas Färber
Am 14.02.2014 14:44, schrieb Fabien Chouteau: On 02/14/2014 09:41 AM, Sebastian Huber wrote: On 2014-02-13 16:50, Fabien Chouteau wrote: This ASI 0x80 is really defined nowhere in Leon3 not even in the sources :) Maybe there's a bug in binutils... Did you try to run this program on a real

Re: [Qemu-devel] [PATCH 1/2] block: gluster - code movements, state storage changes

2014-02-14 Thread Stefan Hajnoczi
On Tue, Feb 04, 2014 at 02:26:58PM -0500, Jeff Cody wrote: diff --git a/block/gluster.c b/block/gluster.c index a009b15..79af3fd 100644 --- a/block/gluster.c +++ b/block/gluster.c @@ -30,6 +30,8 @@ typedef struct GlusterAIOCB { typedef struct BDRVGlusterState { struct glfs *glfs;

[Qemu-devel] [PATCH qom-next] tests: Fix gcov paths for relocated device sources

2014-02-14 Thread Andreas Färber
Commit 49ab747f668f421138d5b40d83fa279c4c5e278d moved fdc.c, hd-geometry.c, m48t59.c, tmp105.c into hw/ subdirectories; commit 0ddfaf7fe4c8453446730328bf348b7c6438e4f8 did for mc146818rtc.c. Cc: Paolo Bonzini pbonz...@redhat.com Signed-off-by: Andreas Färber afaer...@suse.de --- tests/Makefile |

Re: [Qemu-devel] [PATCH 1/2] block: gluster - code movements, state storage changes

2014-02-14 Thread Stefan Hajnoczi
On Tue, Feb 04, 2014 at 02:26:58PM -0500, Jeff Cody wrote: @@ -291,23 +311,17 @@ static int qemu_gluster_open(BlockDriverState *bs, QDict *options, filename = qemu_opt_get(opts, filename); +s-filename = g_strdup(filename); It's not obvious to me that copying the filename is

Re: [Qemu-devel] [Qemu-ppc] [PATCH V10] target-ppc: Fix htab_mask calculation

2014-02-14 Thread Alexander Graf
On 14.02.2014, at 14:54, Alexander Graf ag...@suse.de wrote: On 14.02.2014, at 14:06, Alexander Graf ag...@suse.de wrote: On 13.02.2014, at 15:51, Alexander Graf ag...@suse.de wrote: On 13.02.2014, at 11:40, Greg Kurz gk...@linux.vnet.ibm.com wrote: On Thu, 13 Feb 2014 08:29:28

Re: [Qemu-devel] [PATCH] qtest: include system headers before user headers

2014-02-14 Thread Stefan Hajnoczi
On Sat, Feb 08, 2014 at 11:41:07AM +0100, Stefan Hajnoczi wrote: It is dangerous to include user headers before system headers since user macros can affect system headers. Signed-off-by: Stefan Hajnoczi stefa...@redhat.com --- tests/endianness-test.c | 2 +- tests/fw_cfg-test.c | 7

Re: [Qemu-devel] [PATCH v2] qcow2: Set zero flag for discarded clusters

2014-02-14 Thread Stefan Hajnoczi
On Sat, Feb 08, 2014 at 05:50:02PM +0100, Kevin Wolf wrote: Instead of making the backing file contents visible again after a discard request, set the zero flag if possible (i.e. on version = 3). Signed-off-by: Kevin Wolf kw...@redhat.com Reviewed-by: Max Reitz mre...@redhat.com ---

Re: [Qemu-devel] [PATCH] CODING_STYLE: Section about mixed declarations

2014-02-14 Thread Stefan Hajnoczi
On Sun, Feb 09, 2014 at 07:03:01AM -0200, Eduardo Habkost wrote: We had an unwritten rule about declarations having to be at beginning of blocks. Make it a written rule. Signed-off-by: Eduardo Habkost ehabk...@redhat.com --- CODING_STYLE | 7 +++ 1 file changed, 7 insertions(+) I

Re: [Qemu-devel] [PATCH 1/2] block: gluster - code movements, state storage changes

2014-02-14 Thread Jeff Cody
On Fri, Feb 14, 2014 at 03:21:28PM +0100, Stefan Hajnoczi wrote: On Tue, Feb 04, 2014 at 02:26:58PM -0500, Jeff Cody wrote: @@ -291,23 +311,17 @@ static int qemu_gluster_open(BlockDriverState *bs, QDict *options, filename = qemu_opt_get(opts, filename); +s-filename =

Re: [Qemu-devel] [PATCH] qtest: include system headers before user headers

2014-02-14 Thread Andreas Färber
Am 14.02.2014 15:32, schrieb Stefan Hajnoczi: On Sat, Feb 08, 2014 at 11:41:07AM +0100, Stefan Hajnoczi wrote: It is dangerous to include user headers before system headers since user macros can affect system headers. Signed-off-by: Stefan Hajnoczi stefa...@redhat.com ---

Re: [Qemu-devel] [Qemu-ppc] [PATCH V10] target-ppc: Fix htab_mask calculation

2014-02-14 Thread Alexander Graf
On 14.02.2014, at 15:28, Alexander Graf ag...@suse.de wrote: On 14.02.2014, at 14:54, Alexander Graf ag...@suse.de wrote: On 14.02.2014, at 14:06, Alexander Graf ag...@suse.de wrote: On 13.02.2014, at 15:51, Alexander Graf ag...@suse.de wrote: On 13.02.2014, at 11:40, Greg Kurz

Re: [Qemu-devel] [PATCH] qtest: Unlink pid file before reading from QMP

2014-02-14 Thread Stefan Hajnoczi
On Sun, Feb 09, 2014 at 12:21:41PM +0100, Andreas Färber wrote: Despite 1ad3c6abc0d67e00b84abaa5527bc64b70ca2205, supplying invalid arguments to the QEMU process still leaked a /tmp/qtest-*.pid file. Fix this by reordering the reading and unlinking to before reading from QMP socket, which

Re: [Qemu-devel] [PATCH 1/2] block: gluster - code movements, state storage changes

2014-02-14 Thread Jeff Cody
On Fri, Feb 14, 2014 at 03:12:41PM +0100, Stefan Hajnoczi wrote: On Tue, Feb 04, 2014 at 02:26:58PM -0500, Jeff Cody wrote: diff --git a/block/gluster.c b/block/gluster.c index a009b15..79af3fd 100644 --- a/block/gluster.c +++ b/block/gluster.c @@ -30,6 +30,8 @@ typedef struct

Re: [Qemu-devel] Multi GPU passthrough via VFIO

2014-02-14 Thread Maik Broemme
Hi Alex, Alex Williamson alex.william...@redhat.com wrote: On Fri, 2014-02-14 at 01:01 +0100, Maik Broemme wrote: Hi Alex, Maik Broemme mbroe...@parallels.com wrote: Hi Alex, Alex Williamson alex.william...@redhat.com wrote: On Fri, 2014-02-07 at 01:22 +0100, Maik Broemme

Re: [Qemu-devel] [PATCHv2 1/2] sun4m: Add Sun CG3 framebuffer and corresponding OpenBIOS FCode ROM

2014-02-14 Thread Peter Crosthwaite
On Sun, Feb 9, 2014 at 11:35 PM, Mark Cave-Ayland mark.cave-ayl...@ilande.co.uk wrote: On 09/02/14 04:14, Peter Crosthwaite wrote: Hi Peter, Thanks for the review! (cut) +/* #define DEBUG_CG3 */ + +#define CG3_ROM_FILE QEMU,cgthree.bin +#define FCODE_MAX_ROM_SIZE 0x1 + +#define

Re: [Qemu-devel] memory allocation of migration changed?

2014-02-14 Thread Stefan Hajnoczi
On Tue, Feb 11, 2014 at 07:32:46PM +0100, Stefan Priebe wrote: Am 11.02.2014 17:22, schrieb Peter Lieven: Am 11.02.2014 um 16:44 schrieb Stefan Hajnoczi stefa...@gmail.com: On Tue, Feb 11, 2014 at 3:54 PM, Stefan Priebe - Profihost AG s.pri...@profihost.ag wrote: in the past (Qemu 1.5)

Re: [Qemu-devel] memory allocation of migration changed?

2014-02-14 Thread Stefan Hajnoczi
On Tue, Feb 11, 2014 at 07:30:54PM +0100, Stefan Priebe wrote: Am 11.02.2014 16:44, schrieb Stefan Hajnoczi: On Tue, Feb 11, 2014 at 3:54 PM, Stefan Priebe - Profihost AG s.pri...@profihost.ag wrote: in the past (Qemu 1.5) a migration failed if there was not enogh memory on the target host

Re: [Qemu-devel] Regarding QEMU API's to interact with hardware peripherals like Memory

2014-02-14 Thread Stefan Hajnoczi
On Wed, Feb 12, 2014 at 12:14:58PM +0530, Brajesh Sharma wrote: I am new to Qemu Emulator i need some Info regarding this . I am working on something which needs Qemu to interact with hardware peripherals . I want to know what are those API to communicate with hardware and how can i find and

Re: [Qemu-devel] qemu-1.7.0 vm migration with nbd usage

2014-02-14 Thread Stefan Hajnoczi
On Wed, Feb 12, 2014 at 04:35:19PM +0800, xuanmao_001 wrote: Hi, Is there a document describe vm migration with nbd server or any example about it? NBD supports migration because it is a network storage protocol. Imagine you have a source host and a destination host. The source host is

Re: [Qemu-devel] [PATCH] block: Don't throw away errno via error_setg

2014-02-14 Thread Stefan Hajnoczi
On Wed, Feb 12, 2014 at 02:46:24PM -0500, Jeff Cody wrote: There are a handful of places in the block layer where a failure path has a valid -errno value, yet error_setg() is used. Those instances should instead use error_setg_errno(), to preserve as much error information as possible.

Re: [Qemu-devel] [PATCH] block: mirror - insure that errp is not NULL

2014-02-14 Thread Stefan Hajnoczi
On Thu, Feb 13, 2014 at 09:41:45AM +0100, Kevin Wolf wrote: Am 12.02.2014 um 20:46 hat Jeff Cody geschrieben: When starting a block job, commit_active_start() relies on whether *errp is set by mirror_start_job. This allows it to determine if the mirror job start failed, so that it can

[Qemu-devel] [PATCH v3] target-sparc: Add and use CPU_FEATURE_CASA

2014-02-14 Thread Sebastian Huber
The LEON3 processor has support for the CASA instruction which is normally only available for SPARC V9 processors. Binutils 2.24 and GCC 4.9 will support this instruction for LEON3. GCC uses it to generate C11 atomic operations. The CAS synthetic instruction uses an ASI of 0x80. If

Re: [Qemu-devel] [PATCH 0/2] qemu-iotest fixes and updates for 070

2014-02-14 Thread Stefan Hajnoczi
On Wed, Feb 12, 2014 at 04:30:51PM -0500, Jeff Cody wrote: This fixes a bug with test 070 (incorrect output expectation), and adds additional test for log replay. Jeff Cody (2): block: qemu-iotests - fix test 070 (vhdx) block: qemu-iotests - add vhdx log replay tests for qemu-img

Re: [Qemu-devel] [PATCH] block: mirror - insure that errp is not NULL

2014-02-14 Thread Stefan Hajnoczi
On Wed, Feb 12, 2014 at 02:46:47PM -0500, Jeff Cody wrote: It doesn't really matter, but: http://public.wsu.edu/~brians/errors/assure.html “ensure” that something happens is to make certain that it does, and to “insure” is to issue an insurance policy. Other authorities, however, consider

[Qemu-devel] [Bug 1279500] Re: system_powerdown causes SMP OpenBSD guest to freeze

2014-02-14 Thread Robert Urban
If someone needs to coordinate with someone from the OpenBSD team, please talk to Mike Larkin mlar...@openbsd.org. He expressed an intention to look into this problem from the OpenBSD side. I would be delighted if I could supply Mike with a qemu contact person, of if someone could contact him

Re: [Qemu-devel] Trying to write a new device / virtio-i2c ?

2014-02-14 Thread Stefan Hajnoczi
On Thu, Feb 13, 2014 at 02:26:16PM +0100, Alex David wrote: I'm new to QEMU and kinda new to driver QEMU programming in general, so please excuse my questions... I want to develop a new QEMU i2c device (qemu x86), that would get/send data to an application running on the guest. Thing is : I

Re: [Qemu-devel] [PATCH v2] block: mirror - use local_err to avoid NULL errp

2014-02-14 Thread Stefan Hajnoczi
On Thu, Feb 13, 2014 at 09:23:38AM -0500, Jeff Cody wrote: When starting a block job, commit_active_start() relies on whether *errp is set by mirror_start_job. This allows it to determine if the mirror job start failed, so that it can clean up any changes to open flags from the bdrv_reopen().

Re: [Qemu-devel] [PATCH] blockdev: Fix wrong usage of QDECREF causing snapshoted quorum to crash on close.

2014-02-14 Thread Stefan Hajnoczi
On Thu, Feb 13, 2014 at 05:22:33PM +0100, Benoît Canet wrote: As bdrv_open() documentation states: The reference to the QDict belongs to the block layer * after the call (even on failure), so if the caller intends to reuse the * dictionary, it needs to use QINCREF() before calling bdrv_open.

Re: [Qemu-devel] [PATCH v3] target-sparc: Add and use CPU_FEATURE_CASA

2014-02-14 Thread Andreas Färber
Am 14.02.2014 16:16, schrieb Sebastian Huber: The LEON3 processor has support for the CASA instruction which is normally only available for SPARC V9 processors. Binutils 2.24 and GCC 4.9 will support this instruction for LEON3. GCC uses it to generate C11 atomic operations. The CAS

Re: [Qemu-devel] [PATCH 1/2] block: gluster - code movements, state storage changes

2014-02-14 Thread Stefan Hajnoczi
On Fri, Feb 14, 2014 at 09:41:46AM -0500, Jeff Cody wrote: On Fri, Feb 14, 2014 at 03:21:28PM +0100, Stefan Hajnoczi wrote: On Tue, Feb 04, 2014 at 02:26:58PM -0500, Jeff Cody wrote: @@ -291,23 +311,17 @@ static int qemu_gluster_open(BlockDriverState *bs, QDict *options,

Re: [Qemu-devel] [PATCH] qtest: Unlink pid file before reading from QMP

2014-02-14 Thread Andreas Färber
Am 14.02.2014 15:43, schrieb Stefan Hajnoczi: On Sun, Feb 09, 2014 at 12:21:41PM +0100, Andreas Färber wrote: Despite 1ad3c6abc0d67e00b84abaa5527bc64b70ca2205, supplying invalid arguments to the QEMU process still leaked a /tmp/qtest-*.pid file. Fix this by reordering the reading and

Re: [Qemu-devel] net: Adding netmap network backend

2014-02-14 Thread Stefan Hajnoczi
On Fri, Feb 14, 2014 at 02:41:24PM +0100, Vincenzo Maffione wrote: It is ok for you if I prepare a patch (touching configure and net/netmap.c) that makes sure the host kernel has the minimum netmap version required for QEMU to work (and if not just --disable-netmap)? Absolutely. Stefan

Re: [Qemu-devel] [PATCH] qtest: include system headers before user headers

2014-02-14 Thread Stefan Hajnoczi
On Fri, Feb 14, 2014 at 03:42:41PM +0100, Andreas Färber wrote: Am 14.02.2014 15:32, schrieb Stefan Hajnoczi: On Sat, Feb 08, 2014 at 11:41:07AM +0100, Stefan Hajnoczi wrote: Is anyone willing to be qtest maintainer, i.e. you understand qtest, can review patches, and will send pull

Re: [Qemu-devel] [PATCH 0/7] virtio endian-ambivalent target fixes.

2014-02-14 Thread Thomas Huth
On Fri, 14 Feb 2014 10:38:02 +0100 Greg Kurz gk...@linux.vnet.ibm.com wrote: On Thu, 17 Oct 2013 14:23:35 +1030 Rusty Russell ru...@rustcorp.com.au wrote: This is a re-transmit of the core of the virtio endian code. Since there seems to be some interest in ARM BE virtio, I've separated

Re: [Qemu-devel] Trying to write a new device / virtio-i2c ?

2014-02-14 Thread Paolo Bonzini
Il 13/02/2014 14:26, Alex David ha scritto: After reading code, documentation and available things, I've been trying to write something like a virtio-i2c : I wrote a virtio-i2c module for my kernel (I used some examples from virtio-pci and virtio-console), it seems that it created a i2c-1 device

Re: [Qemu-devel] [libvirt] Looking for project ideas and mentors for Google Summer of Code 2014

2014-02-14 Thread Stefan Hajnoczi
On Fri, Feb 14, 2014 at 03:22:04PM +0100, Cedric Bosdonnat wrote: On Fri, 2014-02-14 at 09:16 +0100, Jan Kiszka wrote: I need to submit our organization application (including our project ideas) on Friday. Hope it's not too late: just added the VT-d emulation proposal. It's not too

Re: [Qemu-devel] [PATCH 0/2] Make open by reference use id then node-name

2014-02-14 Thread Stefan Hajnoczi
On Wed, Feb 12, 2014 at 05:15:05PM +0100, Benoît Canet wrote: This series was asked by Kevin. It sit on top of the snapshot fix patch and max openv2 series. I have done the following tests. check qemu-iotest ok snapshot blockbackend by id ok open quorum by node-name reference and id

Re: [Qemu-devel] [PATCH v3] target-sparc: Add and use CPU_FEATURE_CASA

2014-02-14 Thread Sebastian Huber
On 2014-02-14 16:33, Andreas Färber wrote: @@ -5120,6 +5119,20 @@ static void disas_sparc_insn(DisasContext * dc, unsigned int insn) case 0x37: /* stdc */ goto ncp_insn; #endif +#if !defined(CONFIG_USER_ONLY) || defined(TARGET_SPARC64) +

Re: [Qemu-devel] net: Adding netmap network backend

2014-02-14 Thread Vincenzo Maffione
Ok, this patch should preferably go in before the offloadings. 2014-02-14 16:40 GMT+01:00 Stefan Hajnoczi stefa...@redhat.com: On Fri, Feb 14, 2014 at 02:41:24PM +0100, Vincenzo Maffione wrote: It is ok for you if I prepare a patch (touching configure and net/netmap.c) that makes sure

Re: [Qemu-devel] [PATCH v3] target-sparc: Add and use CPU_FEATURE_CASA

2014-02-14 Thread Andreas Färber
Am 14.02.2014 16:43, schrieb Sebastian Huber: On 2014-02-14 16:33, Andreas Färber wrote: @@ -5120,6 +5119,20 @@ static void disas_sparc_insn(DisasContext * dc, unsigned int insn) case 0x37: /* stdc */ goto ncp_insn; #endif +#if

[Qemu-devel] [PATCH v4] target-sparc: Add and use CPU_FEATURE_CASA

2014-02-14 Thread Sebastian Huber
The LEON3 processor has support for the CASA instruction which is normally only available for SPARC V9 processors. Binutils 2.24 and GCC 4.9 will support this instruction for LEON3. GCC uses it to generate C11 atomic operations. The CAS synthetic instruction uses an ASI of 0x80. If

Re: [Qemu-devel] [PATCH 1/2] block: gluster - code movements, state storage changes

2014-02-14 Thread Jeff Cody
On Fri, Feb 14, 2014 at 04:38:03PM +0100, Stefan Hajnoczi wrote: On Fri, Feb 14, 2014 at 09:41:46AM -0500, Jeff Cody wrote: On Fri, Feb 14, 2014 at 03:21:28PM +0100, Stefan Hajnoczi wrote: On Tue, Feb 04, 2014 at 02:26:58PM -0500, Jeff Cody wrote: @@ -291,23 +311,17 @@ static int

Re: [Qemu-devel] [PATCH v2 06/20] iscsi: correctly propagate errors in iscsi_open

2014-02-14 Thread Stefan Hajnoczi
On Tue, Feb 11, 2014 at 06:03:39PM +0100, Paolo Bonzini wrote: @@ -1349,14 +1350,15 @@ static int iscsi_reopen_prepare(BDRVReopenState *state, static int iscsi_truncate(BlockDriverState *bs, int64_t offset) { IscsiLun *iscsilun = bs-opaque; -int ret = 0; +Error *local_err =

Re: [Qemu-devel] [PATCH v4] target-sparc: Add and use CPU_FEATURE_CASA

2014-02-14 Thread Andreas Färber
Am 14.02.2014 17:06, schrieb Sebastian Huber: The LEON3 processor has support for the CASA instruction which is normally only available for SPARC V9 processors. Binutils 2.24 and GCC 4.9 will support this instruction for LEON3. GCC uses it to generate C11 atomic operations. The CAS

Re: [Qemu-devel] [PATCH 1/2] block: gluster - code movements, state storage changes

2014-02-14 Thread Kevin Wolf
Am 14.02.2014 um 15:41 hat Jeff Cody geschrieben: On Fri, Feb 14, 2014 at 03:21:28PM +0100, Stefan Hajnoczi wrote: On Tue, Feb 04, 2014 at 02:26:58PM -0500, Jeff Cody wrote: @@ -291,23 +311,17 @@ static int qemu_gluster_open(BlockDriverState *bs, QDict *options, filename =

Re: [Qemu-devel] Trying to write a new device / virtio-i2c ?

2014-02-14 Thread Andreas Färber
Am 14.02.2014 16:58, schrieb Paolo Bonzini: Il 13/02/2014 14:26, Alex David ha scritto: After reading code, documentation and available things, I've been trying to write something like a virtio-i2c : I wrote a virtio-i2c module for my kernel (I used some examples from virtio-pci and

Re: [Qemu-devel] [PATCH v2 00/20] Improve bdrv_open error messages

2014-02-14 Thread Stefan Hajnoczi
On Tue, Feb 11, 2014 at 06:03:33PM +0100, Paolo Bonzini wrote: Most of the block drivers are not using the Error** argument to bdrv_open, and instead just printing errors to stderr. This series improves that, using Error** instead of abusing errno numbers too. The only hurdle (caught by

Re: [Qemu-devel] [PATCH v2 09/35] target-arm: A64: Implement MSR (immediate) instructions

2014-02-14 Thread Peter Maydell
On 5 February 2014 06:23, Peter Crosthwaite peter.crosthwa...@xilinx.com wrote: On Sat, Feb 1, 2014 at 1:45 AM, Peter Maydell peter.mayd...@linaro.org wrote: +switch (op) { +case 0x05: /* SPSel */ +env-pstate = deposit32(env-pstate, 0, 1, imm); 0,1 hardcoded constants are a

Re: [Qemu-devel] Trying to write a new device / virtio-i2c ?

2014-02-14 Thread Paolo Bonzini
Il 14/02/2014 17:31, Andreas Färber ha scritto: While that is certainly possible in case host passthrough was desired, maybe virtio was mixed up with VFIO? I don't think so, VFIO is mostly about IOMMUs and protecting from DMA. Paolo

[Qemu-devel] [PATCH] net: Disable netmap backend when not supported

2014-02-14 Thread Vincenzo Maffione
This patch fixes configure so that netmap is not compiled in if the host doesn't support an API version = 11. Moreover, some modifications have been done to net/netmap.c in order to reflect the current netmap API (11). Signed-off-by: Vincenzo Maffione v.maffi...@gmail.com --- configure| 3

Re: [Qemu-devel] [PATCH v2 09/20] cow: correctly propagate errors

2014-02-14 Thread Kevin Wolf
Am 11.02.2014 um 18:03 hat Paolo Bonzini geschrieben: Signed-off-by: Paolo Bonzini pbonz...@redhat.com --- block/cow.c | 12 +++- 1 file changed, 3 insertions(+), 9 deletions(-) diff --git a/block/cow.c b/block/cow.c index 7fc0b12..43a2150 100644 --- a/block/cow.c +++

[Qemu-devel] [PATCH v3 06/20] iscsi: correctly propagate errors in iscsi_open

2014-02-14 Thread Paolo Bonzini
Before: $ ./qemu-io-old qemu-io-old open -r -o file.driver=iscsi,file.filename=foo Failed to parse URL : foo qemu-io-old: can't open device (null): Could not open 'foo': Invalid argument After: $ ./qemu-io qemu-io open -r -o file.driver=iscsi,file.filename=foo

Re: [Qemu-devel] [PATCH v2 00/20] Improve bdrv_open error messages

2014-02-14 Thread Paolo Bonzini
Il 14/02/2014 17:31, Stefan Hajnoczi ha scritto: 19 files changed, 302 insertions(+), 297 deletions(-) Looks good except for the memory leak that I commented on. Thanks! I sent v3 of that one patch. Paolo

Re: [Qemu-devel] [PATCH v2 01/20] nbd: produce a better error if neither host nor port is passed

2014-02-14 Thread Jeff Cody
On Tue, Feb 11, 2014 at 06:03:34PM +0100, Paolo Bonzini wrote: Before: $ qemu-io-old qemu-io-old open -r -o file.driver=nbd qemu-io-old: can't open device (null): Could not open image: Invalid argument $ ./qemu-io-old qemu-io-old open -r -o

Re: [Qemu-devel] [PATCH v2 09/20] cow: correctly propagate errors

2014-02-14 Thread Jeff Cody
On Fri, Feb 14, 2014 at 05:45:40PM +0100, Kevin Wolf wrote: Am 11.02.2014 um 18:03 hat Paolo Bonzini geschrieben: Signed-off-by: Paolo Bonzini pbonz...@redhat.com --- block/cow.c | 12 +++- 1 file changed, 3 insertions(+), 9 deletions(-) diff --git a/block/cow.c

Re: [Qemu-devel] [PATCH v2 09/20] cow: correctly propagate errors

2014-02-14 Thread Paolo Bonzini
Il 14/02/2014 17:45, Kevin Wolf ha scritto: -ret = bdrv_file_open(cow_bs, filename, NULL, NULL, BDRV_O_RDWR, - local_err); +ret = bdrv_file_open(cow_bs, filename, NULL, NULL, BDRV_O_RDWR, errp); if (ret 0) { -qerror_report_err(local_err); -

Re: [Qemu-devel] [PATCH v2] qcow2: Set zero flag for discarded clusters

2014-02-14 Thread Stefan Hajnoczi
On Sat, Feb 08, 2014 at 05:50:02PM +0100, Kevin Wolf wrote: Instead of making the backing file contents visible again after a discard request, set the zero flag if possible (i.e. on version = 3). Signed-off-by: Kevin Wolf kw...@redhat.com Reviewed-by: Max Reitz mre...@redhat.com ---

Re: [Qemu-devel] [PATCH v3] target-sparc: Add and use CPU_FEATURE_CASA

2014-02-14 Thread Fabien Chouteau
On 02/14/2014 04:33 PM, Andreas Färber wrote: As for the other one you'll need to sort our who sends a pull if Blue doesn't resurface - I didn't see any message about this. Does anyone know why he's not around? I note that qemu-trivial is not CC'ed here and the patch probably isn't anyway.

[Qemu-devel] [PULL 01/11] sdhci: Drop unnecessary #include

2014-02-14 Thread Stefan Hajnoczi
From: Kevin Wolf kw...@redhat.com Signed-off-by: Kevin Wolf kw...@redhat.com Reviewed-by: Fam Zheng f...@redhat.com Signed-off-by: Stefan Hajnoczi stefa...@redhat.com --- hw/sd/sdhci.c | 1 - 1 file changed, 1 deletion(-) diff --git a/hw/sd/sdhci.c b/hw/sd/sdhci.c index 0906a1d..a0b90ba 100644

[Qemu-devel] [PULL 02/11] blockdev: Remove 'type' parameter from blockdev_init()

2014-02-14 Thread Stefan Hajnoczi
From: Kevin Wolf kw...@redhat.com blockdev-add doesn't know about the device that the backend will be attached to, this is a legacy -drive concept. Move the remaining checks that use it to drive_init(). [Fam Zheng f...@redhat.com suggested line-wrapping to 80 chars as required by the coding

[Qemu-devel] [PULL 00/11] Block patches

2014-02-14 Thread Stefan Hajnoczi
The following changes since commit 0888a29caac6e1b668e498a0ad4d1fea15de012b: Merge remote-tracking branch 'remotes/mst/tags/for_upstream' into staging (2014-02-13 15:02:04 +) are available in the git repository at: git://github.com/stefanha/qemu.git tags/block-pull-request for you to

[Qemu-devel] [PULL 05/11] block: qemu-iotests - fix test 070 (vhdx)

2014-02-14 Thread Stefan Hajnoczi
From: Jeff Cody jc...@redhat.com VHDX test 070 failed, due to different output from qemu-io / qemu when opening an image read-only that contains a log file. Filter the output, and update the expected results to match the correct output. Signed-off-by: Jeff Cody jc...@redhat.com Signed-off-by:

[Qemu-devel] [PULL 07/11] qemu-iotests: Don't run 005 on vmdk split formats

2014-02-14 Thread Stefan Hajnoczi
From: Fam Zheng f...@redhat.com There would be too many extents that VMDK driver can't open all of them: 005 0s ... - output mismatch (see 005.out.bad) --- 005.out 2013-12-24 09:27:27.608181030 +0800 +++ 005.out.bad 2014-02-13 10:00:15.282184557 +0800 @@ -4,10 +4,10 @@

[Qemu-devel] [PULL 03/11] block: Add notes to iSCSI's .bdrv_open and .bdrv_reopen_prepare

2014-02-14 Thread Stefan Hajnoczi
From: Jeff Cody jc...@redhat.com iSCSI currently does not need to do any actions to support the current usage of bdrv_reopen(). However, it is important to note a couple of things: 1.) A connection will not be re-established to an iSCSI target, and 2.) If iscsi_open() is changed to parse

[Qemu-devel] [PULL 06/11] block: qemu-iotests - add vhdx log replay tests for qemu-img

2014-02-14 Thread Stefan Hajnoczi
From: Jeff Cody jc...@redhat.com VHDX logs can now be replayed via 'qemu-img check -r all'. Add tests to verify that the log replay is successful when using qemu-img. Signed-off-by: Jeff Cody jc...@redhat.com Signed-off-by: Stefan Hajnoczi stefa...@redhat.com --- tests/qemu-iotests/070 |

  1   2   >