Re: [Qemu-devel] [PATCH 1/1] virtio-rng: fix check for period_ms validity

2014-12-11 Thread Gonglei
On 2014/12/11 15:49, Amit Shah wrote: This was reported for this warning: hw/virtio/virtio-rng.c:150:31: warning: logical not is only applied to the left hand side of comparison [-Wlogical-not-parentheses] Reported-by: dcb Suggested-by: dcb Bug:

Re: [Qemu-devel] [RFC PATCH v6 08/32] icount: implement icount requesting

2014-12-11 Thread Pavel Dovgaluk
From: Paolo Bonzini [mailto:paolo.bonz...@gmail.com] On Behalf Of Paolo Bonzini On 10/12/2014 07:35, Pavel Dovgalyuk wrote: No, it worked well and I deleted _nocache version of that function. But I still need _raw one to get the instructions counter. Oh, great. This patch can also go

Re: [Qemu-devel] [PATCH 1/1] MAINTAINERS: Update for migrated migration code

2014-12-11 Thread Amit Shah
On (Wed) 10 Dec 2014 [11:03:54], Dr. David Alan Gilbert (git) wrote: From: Dr. David Alan Gilbert dgilb...@redhat.com My previous patches migrated the migration code into migration/ but didn't update MAINTAINERS. Note that does mean that the owner for block-migration.c changes, but I'll

[Qemu-devel] [PULL] Migration pull for 2.3

2014-12-11 Thread Amit Shah
The following changes since commit 7fb8da2b8861795e0013e6ee97acd0363d868a35: Open 2.3 development tree (2014-12-09 21:48:34 +) are available in the git repository at: git://git.kernel.org/pub/scm/virt/qemu/amit/migration.git tags/for-2.3-1 for you to fetch changes up to

Re: [Qemu-devel] [PATCH 0/5] bootdevice: Refactor and improvement

2014-12-11 Thread Gonglei
On 2014/12/4 19:19, Gonglei (Arei) wrote: From: Gonglei arei.gong...@huawei.com Patch 1 just move boot order related code to bootdevice.c. Patch 2,3,5 add an argument to corresponding functions. This way, we can propagate the error messages to the caller. Maybe somebody will say we will

Re: [Qemu-devel] [PATCH] vt82c686: avoid out-of-bounds read

2014-12-11 Thread zhanghailiang
On 2014/12/10 17:17, Paolo Bonzini wrote: superio_ioport_readb can read the 256th element of the array. Coverity reports an out-of-bounds write in superio_ioport_writeb, but it does not show the corresponding out-of-bounds read because it cannot prove that it can happen. Fix the root cause of

Re: [Qemu-devel] [PATCH 2/2] pc: acpi-build: make linker RSDP tables dynamic

2014-12-11 Thread Igor Mammedov
On Wed, 10 Dec 2014 22:18:53 +0200 Michael S. Tsirkin m...@redhat.com wrote: On Wed, Dec 10, 2014 at 08:43:55PM +0100, Igor Mammedov wrote: On Wed, 10 Dec 2014 20:28:01 +0200 Michael S. Tsirkin m...@redhat.com wrote: On Wed, Dec 10, 2014 at 06:39:49PM +0100, Igor Mammedov wrote: On

Re: [Qemu-devel] [PATCH for-2.3 0/2] block: Fix for trailing whitespace in qemu-img create and its tests

2014-12-11 Thread Markus Armbruster
Fam Zheng f...@redhat.com writes: On Wed, 12/10 13:50, Markus Armbruster wrote: Fam Zheng f...@redhat.com writes: This will make it easier to keep checkpatch.pl happy. Fam Zheng (2): qemu-iotests: Remove traling whitespaces in *.out block: Don't add trailing space in

Re: [Qemu-devel] [PATCH v2 04/10] vnc: switch to QemuOpts, allow multiple servers

2014-12-11 Thread Gerd Hoffmann
Hi, +fprintf(stderr, %s: id \%s\\n, __func__, id); A debug message, isn't it? Yes, dropped. + +vnc_display_init(id); +vnc_display_open(id, local_err); +if (local_err != NULL) { +error_report(Failed to start VNC server on `%s': %s, +

Re: [Qemu-devel] [PATCH RESEND for 2.3 5/6] migration: optimize xbzrle by reducing data copy

2014-12-11 Thread Dr. David Alan Gilbert
* ChenLiang (chenlian...@huawei.com) wrote: On 2014/12/10 18:39, Dr. David Alan Gilbert wrote: * Juan Quintela (quint...@redhat.com) wrote: arei.gong...@huawei.com wrote: From: ChenLiang chenlian...@huawei.com Signed-off-by: ChenLiang chenlian...@huawei.com Signed-off-by: Gonglei

Re: [Qemu-devel] [PATCH 4/4] block: vhdx - set .bdrv_has_zero_init to bdrv_has_zero_init_1

2014-12-11 Thread Max Reitz
On 2014-12-11 at 05:21, Lokesha, Amulya wrote: Hi, I raised a bug https://bugs.launchpad.net/qemu/+bug/1399191 in the qemu bugzilla and immediately started getting these patch mails. But, I am not seeing any update in the bugzilla site. Till now I have got 4 patch mails regarding the issue.

Re: [Qemu-devel] [PATCH v2 09/10] monitor: add query-vnc2 command

2014-12-11 Thread Gerd Hoffmann
Hi, +# @auth: The current authentication type used by the server +#'none' if no authentication is being used +#'vnc' if VNC authentication is being used +#'vencrypt+plain' if VEncrypt is used with plain text authentication +#'vencrypt+tls+none' if

Re: [Qemu-devel] [PATCH v2 10/10] monitor: add vnc websockets

2014-12-11 Thread Gerd Hoffmann
+# @websocket: #optional true in case the socket is a websocket (since 2.2). s/2.2/2.3/ Fixed. Is it optional because you omit it when false? Why not just always output the bool, so that clients know they are talking to a new-enough qemu that knows about websockets (and this is

Re: [Qemu-devel] [PATCH v2] rbd: print a clear error message when write beyond EOF

2014-12-11 Thread Kevin Wolf
Am 11.12.2014 um 07:25 hat Jun Li geschrieben: Currently, as rbd driver do not support dynamic growth when write beyond EOF, so just print a clear error message. Signed-off-by: Jun Li junm...@gmail.com --- v2: Just use rbd_aio_write to realize error detection. --- block/rbd.c | 4

Re: [Qemu-devel] [PATCH v2] rbd: print a clear error message when write beyond EOF

2014-12-11 Thread Max Reitz
On 2014-12-11 at 10:12, Kevin Wolf wrote: Am 11.12.2014 um 07:25 hat Jun Li geschrieben: Currently, as rbd driver do not support dynamic growth when write beyond EOF, so just print a clear error message. Signed-off-by: Jun Li junm...@gmail.com --- v2: Just use rbd_aio_write to realize error

[Qemu-devel] [PATCH] hpet: increase spelling precision

2014-12-11 Thread Stefan Hajnoczi
Signed-off-by: Stefan Hajnoczi stefa...@redhat.com --- hw/timer/hpet.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/timer/hpet.c b/hw/timer/hpet.c index e160e8f..d8bc231 100644 --- a/hw/timer/hpet.c +++ b/hw/timer/hpet.c @@ -1,5 +1,5 @@ /* - * High Precisition Event

Re: [Qemu-devel] [PATCH v2] pc: acpi-build: make linker RSDP tables dynamic

2014-12-11 Thread Marcel Apfelbaum
On Thu, 2014-12-11 at 09:10 +, Igor Mammedov wrote: linker and RSDP tables are build only once, so if later during rebuild sizes of other ACPI tables change pointers will be patched incorrectly due to wrong offsets. To fix it rebuild linker and RSDP tables along with the rest of ACPI

Re: [Qemu-devel] [PATCH 2/2] target-arm: Add checks that cpreg raw accesses are handled

2014-12-11 Thread Peter Maydell
On 10 December 2014 at 23:18, Greg Bellows greg.bell...@linaro.org wrote: On 10 December 2014 at 16:50, Peter Maydell peter.mayd...@linaro.org wrote: On 10 December 2014 at 22:26, Greg Bellows greg.bell...@linaro.org wrote: On 9 December 2014 at 13:46, Peter Maydell

Re: [Qemu-devel] [PATCH 1/1] virtio-rng: fix check for period_ms validity

2014-12-11 Thread Amos Kong
On Thu, Dec 11, 2014 at 01:19:27PM +0530, Amit Shah wrote: This was reported for this warning: hw/virtio/virtio-rng.c:150:31: warning: logical not is only applied to the left hand side of comparison [-Wlogical-not-parentheses] Reported-by: dcb Suggested-by: dcb Bug:

Re: [Qemu-devel] [PATCH v2 09/10] monitor: add query-vnc2 command

2014-12-11 Thread Daniel P. Berrange
On Wed, Dec 10, 2014 at 09:52:05AM -0700, Eric Blake wrote: On 12/10/2014 02:37 AM, Gerd Hoffmann wrote: Add new query vnc qmp command, for the lack of better ideas just name it query-vnc2. Changes over query-vnc: * It returns a list of vnc servers, so multiple vnc server instances

Re: [Qemu-devel] [PATCH 1/3] target-mips: Add n32/n64 configuration files

2014-12-11 Thread Peter Maydell
On 10 December 2014 at 23:25, Maciej W. Rozycki ma...@codesourcery.com wrote: On Wed, 10 Dec 2014, Peter Maydell wrote: Except that apart from coming to an agreement someone has to make it happen yet. ;) Ah, but I'm happy with the current state of the codebase... Ack. To clarify, that

Re: [Qemu-devel] [PATCH v2 09/10] monitor: add query-vnc2 command

2014-12-11 Thread Daniel P. Berrange
On Thu, Dec 11, 2014 at 10:07:24AM +0100, Gerd Hoffmann wrote: Hi, +# @auth: The current authentication type used by the server +#'none' if no authentication is being used +#'vnc' if VNC authentication is being used +#'vencrypt+plain' if VEncrypt is used

Re: [Qemu-devel] [PATCH v2] rbd: print a clear error message when write beyond EOF

2014-12-11 Thread jun muzi
Jun Li 2014-12-11 下午5:13于 Max Reitz mre...@redhat.com写道: On 2014-12-11 at 10:12, Kevin Wolf wrote: Am 11.12.2014 um 07:25 hat Jun Li geschrieben: Currently, as rbd driver do not support dynamic growth when write beyond EOF, so just print a clear error message. Signed-off-by: Jun Li

Re: [Qemu-devel] [PATCH v2] rbd: print a clear error message when write beyond EOF

2014-12-11 Thread Max Reitz
On 2014-12-11 at 10:54, jun muzi wrote: Jun Li 2014-12-11 下午5:13于 Max Reitz mre...@redhat.com mailto:mre...@redhat.com写道: On 2014-12-11 at 10:12, Kevin Wolf wrote: Am 11.12.2014 um 07:25 hat Jun Li geschrieben: Currently, as rbd driver do not support dynamic growth when write beyond

Re: [Qemu-devel] [PATCH RFC for-2.3 0/6] qga: add three logical memory hotplug related commands

2014-12-11 Thread zhanghailiang
Ping... ;) On 2014/12/6 14:59, zhanghailiang wrote: Hi, This patch series add three guest commands about memory block: guest-get-memory-blocks, guest-set-memory-blocks, guest-get-memory-block-size. With these three commands, we can get information about guest's memory block online/offline

Re: [Qemu-devel] [PATCH v2] pc: acpi-build: make linker RSDP tables dynamic

2014-12-11 Thread Michael S. Tsirkin
On Thu, Dec 11, 2014 at 09:10:53AM +, Igor Mammedov wrote: linker and RSDP tables are build only once, so if later s/build/built/ during rebuild sizes of other ACPI tables change pointers will be patched incorrectly due to wrong offsets. To fix it rebuild linker and RSDP tables along

[Qemu-devel] [PATCH 10/10] sdl2: move sdl2_2d_refresh to sdl2-2d.c

2014-12-11 Thread Gerd Hoffmann
Now that common event handling code is split off, we can move over sdl_refresh to sdl2-2d.c, and rename it to sdl2_2d_refresh. Signed-off-by: Gerd Hoffmann kra...@redhat.com --- include/ui/sdl2.h | 1 + ui/sdl2-2d.c | 9 + ui/sdl2.c | 10 +- 3 files changed, 11

[Qemu-devel] [PATCH 06/10] sdl2: overhaul window size handling

2014-12-11 Thread Gerd Hoffmann
Split do_sdl_resize function (which does alot more than just resizing) into three: sdl2_window_{create,destroy,resize}. Fix SDL_Renderer handling: must be guest display size not host window size, and SDL2 will magically handle all scaling for us. Make fullscreen actually enter fullscreen mode

[Qemu-devel] [PATCH 00/10] sdl2: fixes, cleanups and opengl preparation.

2014-12-11 Thread Gerd Hoffmann
Hi, This patch series is a brings a bunch of fixes and inprovements to the sdl2 ui code. Proper window scaling and working keyboard grabs are the most noteworthy ones. It also reorganizes the code in preparation for adding opengl support to sdl2. please review, Gerd Gerd Hoffmann (10):

[Qemu-devel] [PATCH 02/10] sdl2: rename sdl2_state to sdl2_console, move to header file

2014-12-11 Thread Gerd Hoffmann
Create sdl2.h header file, in preparation for sdl2 code splitup. Populate it with sdl2_console struct (renamed from sdl2_state). Signed-off-by: Gerd Hoffmann kra...@redhat.com --- include/ui/sdl2.h | 11 ++ ui/sdl2.c | 63 --- 2

[Qemu-devel] [PATCH 04/10] sdl2: turn on keyboard grabs

2014-12-11 Thread Gerd Hoffmann
Makes quite some keys actually go to the guest instead of being captured by the host window manager. Signed-off-by: Gerd Hoffmann kra...@redhat.com --- ui/sdl2.c | 7 --- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/ui/sdl2.c b/ui/sdl2.c index b8d592f..9b66017 100644 ---

[Qemu-devel] [PATCH 05/10] sdl2: move sdl_update to new sdl2-2d.c

2014-12-11 Thread Gerd Hoffmann
Create new sdl2-2d file for 2d display rendering. Move over sdl_update code, and rename to sdl2_2d_update. Signed-off-by: Gerd Hoffmann kra...@redhat.com --- include/ui/sdl2.h | 3 +++ ui/Makefile.objs | 2 +- ui/sdl2-2d.c | 61 +++

[Qemu-devel] [PATCH 09/10] sdl2: factor out sdl2_poll_events

2014-12-11 Thread Gerd Hoffmann
Create a new function to poll and handle sdl2 events, which is then just called from the refresh timer. Signed-off-by: Gerd Hoffmann kra...@redhat.com --- include/ui/sdl2.h | 1 + ui/sdl2.c | 23 +-- 2 files changed, 14 insertions(+), 10 deletions(-) diff --git

[Qemu-devel] [PATCH 08/10] sdl2: add+use sdl2_2d_redraw function.

2014-12-11 Thread Gerd Hoffmann
Add a new sdl2_2d_redraw function for a complete screen refresh, so we can stop using graphic_hw_invalidate for that. There is no need to bother console / gfx emulation code if we are just going to re-blit the screen after window resizes. Signed-off-by: Gerd Hoffmann kra...@redhat.com ---

[Qemu-devel] [PATCH 07/10] sdl2: move sdl_switch to sdl2-2d.c

2014-12-11 Thread Gerd Hoffmann
Move sdl_switch to sdl2-2d.c file, rename to sdl2_2d_switch. Signed-off-by: Gerd Hoffmann kra...@redhat.com --- include/ui/sdl2.h | 6 ++ ui/sdl2-2d.c | 42 ++ ui/sdl2.c | 50 -- 3 files

[Qemu-devel] [PATCH 01/10] sdl: move version logic from source code to makefile

2014-12-11 Thread Gerd Hoffmann
Compile sdl.c / sdl2.c depending on CONFIG_SDLABI instead of compiling both and have version #ifdefs in the source code. Signed-off-by: Gerd Hoffmann kra...@redhat.com --- ui/Makefile.objs | 7 ++- ui/sdl.c | 3 --- ui/sdl2.c| 3 --- 3 files changed, 6 insertions(+), 7

Re: [Qemu-devel] [PATCH v4 05/26] qcow2: Use unsigned addend for update_refcount()

2014-12-11 Thread Stefan Hajnoczi
On Wed, Dec 03, 2014 at 02:37:25PM +0100, Max Reitz wrote: @@ -530,8 +530,16 @@ found: } /* XXX: cache several refcount block clusters ? */ +/* In order to decrease refcounts, set @addend to the two's complement (giving a + * negative value and letting the implicit cast handle it is

Re: [Qemu-devel] [PATCH v4 05/26] qcow2: Use unsigned addend for update_refcount()

2014-12-11 Thread Max Reitz
On 2014-12-11 at 11:58, Stefan Hajnoczi wrote: On Wed, Dec 03, 2014 at 02:37:25PM +0100, Max Reitz wrote: @@ -530,8 +530,16 @@ found: } /* XXX: cache several refcount block clusters ? */ +/* In order to decrease refcounts, set @addend to the two's complement (giving a + * negative

Re: [Qemu-devel] [PATCH v4 06/26] qcow2: Use 64 bits for refcount values

2014-12-11 Thread Stefan Hajnoczi
On Wed, Dec 03, 2014 at 02:37:26PM +0100, Max Reitz wrote: Refcounts may have a width of up to 64 bits, so qemu should use the same width to represent refcount values internally. Signed-off-by: Max Reitz mre...@redhat.com --- block/qcow2-cluster.c | 2 +- block/qcow2-refcount.c | 42

[Qemu-devel] [RfC PATCH 3/3] sdl2: move SDL_* includes to sdl2.h

2014-12-11 Thread Gerd Hoffmann
Signed-off-by: Gerd Hoffmann kra...@redhat.com --- include/ui/sdl2.h | 7 +++ ui/sdl2-2d.c | 6 -- ui/sdl2-gl.c | 7 --- ui/sdl2-input.c | 6 -- ui/sdl2.c | 6 -- 5 files changed, 7 insertions(+), 25 deletions(-) diff --git a/include/ui/sdl2.h

[Qemu-devel] [RfC PATCH 2/3] sdl2: add support for display rendering using opengl.

2014-12-11 Thread Gerd Hoffmann
Add new sdl2-gl.c file, with display rendering functions using opengl. Signed-off-by: Gerd Hoffmann kra...@redhat.com --- include/ui/sdl2.h | 10 ui/Makefile.objs | 4 ++ ui/sdl2-2d.c | 6 +++ ui/sdl2-gl.c | 143 ++

[Qemu-devel] [RfC PATCH 1/3] configure: opengl overhaul

2014-12-11 Thread Gerd Hoffmann
Rename config option from glx to opengl, glx will not be the only option for opengl in near future. Also switch over to pkg-config for opengl support detection. Signed-off-by: Gerd Hoffmann kra...@redhat.com --- configure| 39 +--

Re: [Qemu-devel] [RFC PATCH v6 08/32] icount: implement icount requesting

2014-12-11 Thread Paolo Bonzini
On 11/12/2014 09:16, Pavel Dovgaluk wrote: No, it worked well and I deleted _nocache version of that function. But I still need _raw one to get the instructions counter. Oh, great. This patch can also go in early. What's the next? Will you upstream some of the patches to simplify

[Qemu-devel] [PATCH V2 9/9] pc: acpi-build: simplify PCI bus tree generation

2014-12-11 Thread Igor Mammedov
it basicaly does the same as original approach, * just without bus/notify tables tracking (less obscure) which is easier to follow. * drops unnecessary loops and bitmaps, creating devices and notification method in the same loop. * saves us ~100LOC Signed-off-by: Igor Mammedov

Re: [Qemu-devel] [PATCH v4 07/26] qcow2: Respect error in qcow2_alloc_bytes()

2014-12-11 Thread Stefan Hajnoczi
On Wed, Dec 03, 2014 at 02:37:27PM +0100, Max Reitz wrote: qcow2_update_cluster_refcount() may fail, and qcow2_alloc_bytes() should mind that case. Signed-off-by: Max Reitz mre...@redhat.com --- block/qcow2-refcount.c | 33 + 1 file changed, 21

Re: [Qemu-devel] [PATCH v4 08/26] qcow2: Refcount overflow and qcow2_alloc_bytes()

2014-12-11 Thread Stefan Hajnoczi
On Wed, Dec 03, 2014 at 02:37:28PM +0100, Max Reitz wrote: qcow2_alloc_bytes() may reuse a cluster multiple times, in which case the refcount is increased accordingly. However, if this would lead to an overflow the function should instead just not reuse this cluster and allocate a new one.

[Qemu-devel] [PATCH v2] pc: acpi-build: make linker RSDP tables dynamic

2014-12-11 Thread Igor Mammedov
linker and RSDP tables are build only once, so if later during rebuild sizes of other ACPI tables change pointers will be patched incorrectly due to wrong offsets. To fix it rebuild linker and RSDP tables along with the rest of ACPI tables so that they would have correct offsets. Here is a

Re: [Qemu-devel] [PATCH v3 3/5] block: Add driver methods to probe blocksizes and geometry

2014-12-11 Thread Ekaterina Tumanova
On 12/10/2014 04:14 PM, Thomas Huth wrote: On Fri, 5 Dec 2014 18:56:19 +0100 Ekaterina Tumanova tuman...@linux.vnet.ibm.com wrote: This patch introduces driver methods of defining disk blocksizes (physical and logical) and hard drive geometry. The method is only implemented for host_device.

[Qemu-devel] [PATCH] MAINTAINERS: Add migration/block* to block subsystem

2014-12-11 Thread Fam Zheng
We are moving block-migration.c to the separated migration directory, keep this file watched by block maintainers is a good idea. Signed-off-by: Fam Zheng f...@redhat.com --- MAINTAINERS | 1 + 1 file changed, 1 insertion(+) diff --git a/MAINTAINERS b/MAINTAINERS index bcb69e8..e1cc487 100644

Re: [Qemu-devel] [PATCH v2] pc: acpi-build: make linker RSDP tables dynamic

2014-12-11 Thread Igor Mammedov
On Thu, 11 Dec 2014 11:18:50 +0200 Marcel Apfelbaum marce...@redhat.com wrote: On Thu, 2014-12-11 at 09:10 +, Igor Mammedov wrote: linker and RSDP tables are build only once, so if later during rebuild sizes of other ACPI tables change pointers will be patched incorrectly due to wrong

Re: [Qemu-devel] [PATCH v4 09/26] qcow2: Helper for refcount array reallocation

2014-12-11 Thread Stefan Hajnoczi
On Wed, Dec 03, 2014 at 02:37:29PM +0100, Max Reitz wrote: Add a helper function for reallocating a refcount array, independent of the refcount order. The newly allocated space is zeroed and the function handles failed reallocations gracefully. The helper function will always align the

Re: [Qemu-devel] [PATCH v2 09/10] monitor: add query-vnc2 command

2014-12-11 Thread Gerd Hoffmann
Hi, That's not a correct interpretation of the auth values - tls and x509 are not separate auth codes. VNC has one set of primary auth codes really none, vnc, vencrypt Well, the source code also has (see vnc_auth_name in ui/vnc.c): ra2, ra2ne, tight, ultra, tls, sasl If using the

Re: [Qemu-devel] [PULL 0/2] vnc patch queue

2014-12-11 Thread Peter Maydell
On 10 December 2014 at 09:32, Gerd Hoffmann kra...@redhat.com wrote: Hi, Starting to flush queues after the 2.2 release, starting with two little vnc fixes. Well, keymap is strictly speaking not vnc, but vnc is the major user of keymap support, so I sticked it in here. please pull,

Re: [Qemu-devel] [PATCH v2] pc: acpi-build: make linker RSDP tables dynamic

2014-12-11 Thread Marcel Apfelbaum
On Thu, 2014-12-11 at 12:23 +0100, Igor Mammedov wrote: On Thu, 11 Dec 2014 11:18:50 +0200 Marcel Apfelbaum marce...@redhat.com wrote: On Thu, 2014-12-11 at 09:10 +, Igor Mammedov wrote: linker and RSDP tables are build only once, so if later during rebuild sizes of other ACPI

[Qemu-devel] [PATCH 1/1] Sort include/qemu/typedefs.h

2014-12-11 Thread Dr. David Alan Gilbert (git)
From: Dr. David Alan Gilbert dgilb...@redhat.com Mainly to make it less likely to conflict during merges. Signed-off-by: Dr. David Alan Gilbert dgilb...@redhat.com --- include/qemu/typedefs.h | 105 +++- 1 file changed, 50 insertions(+), 55

Re: [Qemu-devel] [PATCH v2 09/10] monitor: add query-vnc2 command

2014-12-11 Thread Daniel P. Berrange
On Thu, Dec 11, 2014 at 12:33:35PM +0100, Gerd Hoffmann wrote: Hi, That's not a correct interpretation of the auth values - tls and x509 are not separate auth codes. VNC has one set of primary auth codes really none, vnc, vencrypt Well, the source code also has (see

[Qemu-devel] [RfC PATCH 0/3] sdl2: add opengl rendering support

2014-12-11 Thread Gerd Hoffmann
Hi, This series add support for screen rendering using opengl. This only blits classic DisplaySurfaces to the screen using opengl, it does not (yet) enable gfx emulation use opengl for rendering. It depends on the sdl2: fixes, cleanups and opengl preparation series just posted. The big

[Qemu-devel] [PATCH] block-migration: fix pending() return value

2014-12-11 Thread Vladimir Sementsov-Ogievskiy
Because of wrong return value of .save_live_pending() in block-migration, migration finishes before the whole disk is transferred. Such situation occures when the migration process is fast enouth, for example when source and dest are on the same host. If in the bulk phase we return something

[Qemu-devel] [PATCH] Fix block migration bug

2014-12-11 Thread Vladimir Sementsov-Ogievskiy
Because of wrong return value of .save_live_pending() in block-migration, migration finishes before the whole disk is transferred. Such situation occures when the migration process is fast enouth, for example when source and dest are on the same host. It's easy to test this with the following:

Re: [Qemu-devel] [PULL 0/9] tricore patches

2014-12-11 Thread Peter Maydell
On 10 December 2014 at 11:36, Bastian Koppelmann kbast...@mail.uni-paderborn.de wrote: Hi, here is my first round of TriCore patches for 2.3. Cheers, Bastian The following changes since commit 7fb8da2b8861795e0013e6ee97acd0363d868a35: Open 2.3 development tree (2014-12-09 21:48:34

[Qemu-devel] [PULL 33/33] target-arm: Check error conditions on kvm_arm_reset_vcpu

2014-12-11 Thread Peter Maydell
From: Christoffer Dall christoffer.d...@linaro.org When resetting a VCPU we currently call both kvm_arm_vcpu_init() and write_kvmstate_to_list(), both of which can fail, but we never check the return value. The only choice here is to print an error an exit if the calls fail. Signed-off-by:

[Qemu-devel] [PULL 18/33] target-arm: make TTBR0/1 banked

2014-12-11 Thread Peter Maydell
From: Fabian Aggeler aggel...@ethz.ch Adds secure and non-secure bank register suport for TTBR0 and TTBR1. Changes include adding secure and non-secure instances of ttbr0 and ttbr1 as well as a CP register definition for TTBR0_EL3. Added a union containing both EL based array fields and secure

[Qemu-devel] [PULL 32/33] target-arm: Support save/load for 64 bit CPUs

2014-12-11 Thread Peter Maydell
For migration to work on 64 bit CPUs, we need to include both the 64-bit integer register file and the PSTATE. Everything else is either stored in the same place as existing 32-bit CPU state or handled by the generic sysreg mechanism. Signed-off-by: Peter Maydell peter.mayd...@linaro.org

[Qemu-devel] [PULL 24/33] target-arm: make PAR banked

2014-12-11 Thread Peter Maydell
From: Fabian Aggeler aggel...@ethz.ch When EL3 is running in AArch32 (or ARMv7 with Security Extensions) PAR has a secure and a non-secure instance. Signed-off-by: Fabian Aggeler aggel...@ethz.ch Signed-off-by: Greg Bellows greg.bell...@linaro.org Reviewed-by: Peter Maydell

[Qemu-devel] [PULL 00/33] target-arm queue

2014-12-11 Thread Peter Maydell
/pull-tricore-20141210' into staging (2014-12-11 11:41:11 +) are available in the git repository at: git://git.linaro.org/people/pmaydell/qemu-arm.git tags/pull-target-arm-20141211 for you to fetch changes up to 25f2895e0e437a3548f9794846001fb5d5ab853d: target-arm: Check error

[Qemu-devel] [PULL 28/33] hw/arm/realview.c: Fix memory leak in realview_init()

2014-12-11 Thread Peter Maydell
From: Nikita Belov zod...@ispras.ru Variable 'ram_lo' is allocated unconditionally, but used only in some cases. When it is unused pointer will be lost at function exit, resulting in a memory leak. Allocate memory for 'ram_lo' only if it is needed. Valgrind output: ==16879== 240 bytes in 1

[Qemu-devel] [PULL 21/33] target-arm: make IFSR banked

2014-12-11 Thread Peter Maydell
From: Fabian Aggeler aggel...@ethz.ch When EL3 is running in AArch32 (or ARMv7 with Security Extensions) IFSR has a secure and a non-secure instance. Adds IFSR32_EL2 definition and storage. Signed-off-by: Fabian Aggeler aggel...@ethz.ch Signed-off-by: Greg Bellows greg.bell...@linaro.org

[Qemu-devel] [PULL 25/33] target-arm: make VBAR banked

2014-12-11 Thread Peter Maydell
From: Greg Bellows greg.bell...@linaro.org When EL3 is running in Aarch32 (or ARMv7 with Security Extensions) VBAR has a secure and a non-secure instance, which are mapped to VBAR_EL1 and VBAR_EL3. Signed-off-by: Fabian Aggeler aggel...@ethz.ch Signed-off-by: Greg Bellows greg.bell...@linaro.org

[Qemu-devel] [PULL 29/33] hw/arm/boot: fix uninitialized scalar variable warning reported by coverity

2014-12-11 Thread Peter Maydell
From: zhanghailiang zhang.zhanghaili...@huawei.com Coverity reports the 'size' may be used uninitialized, but that can't happen, because the caller has checked if (binfo-dtb_filename || binfo-get_dtb) before call 'load_dtb'. Here we simply remove the 'if (binfo-get_dtb)' to satisfy coverity.

[Qemu-devel] [PULL 30/33] arm_gic_kvm: Tell kernel about number of IRQs

2014-12-11 Thread Peter Maydell
Newer kernels support a device attribute on the GIC which allows us to tell it how many IRQs this GIC instance is configured with; use it, if it exists. Signed-off-by: Peter Maydell peter.mayd...@linaro.org Reviewed-by: Christoffer Dall christoffer.d...@linaro.org Message-id:

[Qemu-devel] [PULL 10/33] target-arm: move AArch32 SCR into security reglist

2014-12-11 Thread Peter Maydell
From: Fabian Aggeler aggel...@ethz.ch Define a new ARM CP register info list for the ARMv7 Security Extension feature. Register that list only for ARM cores with Security Extension/EL3 support. Moving AArch32 SCR into Security Extension register group. Signed-off-by: Sergey Fedorov

[Qemu-devel] [PULL 31/33] target-arm/kvm: make reg sync code common between kvm32/64

2014-12-11 Thread Peter Maydell
From: Alex Bennée alex.ben...@linaro.org Before we launch a guest we query KVM for the list of co-processor registers it knows about. This is used to synchronize system register state for the bulk of coprocessor/system registers. Move this code from the 32-bit specific vcpu init function into a

[Qemu-devel] [PULL 26/33] target-arm: make c13 cp regs banked (FCSEIDR, ...)

2014-12-11 Thread Peter Maydell
From: Fabian Aggeler aggel...@ethz.ch When EL3 is running in AArch32 (or ARMv7 with Security Extensions) FCSEIDR, CONTEXTIDR, TPIDRURW, TPIDRURO and TPIDRPRW have a secure and a non-secure instance. Signed-off-by: Fabian Aggeler aggel...@ethz.ch Signed-off-by: Greg Bellows

[Qemu-devel] [PULL 27/33] target-arm: make MAIR0/1 banked

2014-12-11 Thread Peter Maydell
From: Greg Bellows greg.bell...@linaro.org Added CP register info entries for the ARMv7 MAIR0/1 secure banks. Signed-off-by: Greg Bellows greg.bell...@linaro.org Reviewed-by: Peter Maydell peter.mayd...@linaro.org Message-id: 1416242878-876-26-git-send-email-greg.bell...@linaro.org

[Qemu-devel] [PULL 07/33] target-arm: add CPREG secure state support

2014-12-11 Thread Peter Maydell
From: Fabian Aggeler aggel...@ethz.ch Prepare ARMCPRegInfo to support specifying two fieldoffsets per register definition. This will allow us to keep one register definition for banked registers (different offsets for secure/ non-secure world). Also added secure state tracking field and flags.

[Qemu-devel] [PULL 17/33] target-arm: make CSSELR banked

2014-12-11 Thread Peter Maydell
From: Fabian Aggeler aggel...@ethz.ch Rename CSSELR (cache size selection register) and add secure instance (AArch32). Signed-off-by: Fabian Aggeler aggel...@ethz.ch Signed-off-by: Greg Bellows greg.bell...@linaro.org Reviewed-by: Peter Maydell peter.mayd...@linaro.org Message-id:

[Qemu-devel] [PULL 23/33] target-arm: make IFAR/DFAR banked

2014-12-11 Thread Peter Maydell
From: Fabian Aggeler aggel...@ethz.ch When EL3 is running in AArch32 (or ARMv7 with Security Extensions) IFAR and DFAR have a secure and a non-secure instance. Signed-off-by: Fabian Aggeler aggel...@ethz.ch Signed-off-by: Greg Bellows greg.bell...@linaro.org Reviewed-by: Peter Maydell

[Qemu-devel] [PULL 16/33] target-arm: respect SCR.FW, SCR.AW and SCTLR.NMFI

2014-12-11 Thread Peter Maydell
From: Fabian Aggeler aggel...@ethz.ch Add checks of SCR AW/FW bits when performing writes of CPSR. These SCR bits are used to control whether the CPSR masking bits can be adjusted from non-secure state. Signed-off-by: Fabian Aggeler aggel...@ethz.ch Signed-off-by: Greg Bellows

[Qemu-devel] [PULL 19/33] target-arm: make TTBCR banked

2014-12-11 Thread Peter Maydell
From: Fabian Aggeler aggel...@ethz.ch Adds secure and non-secure bank register suport for TTBCR. Added new struct to compartmentalize the TCR data and masks. Removed old tcr/ttbcr data and added a 4 element array of the new structs in cp15. This allows for one entry per EL. Added a CP register

[Qemu-devel] [PULL 20/33] target-arm: make DACR banked

2014-12-11 Thread Peter Maydell
From: Fabian Aggeler aggel...@ethz.ch When EL3 is running in AArch32 (or ARMv7 with Security Extensions) DACR has a secure and a non-secure instance. Adds definition for DACR32_EL2. Signed-off-by: Fabian Aggeler aggel...@ethz.ch Signed-off-by: Greg Bellows greg.bell...@linaro.org Reviewed-by:

[Qemu-devel] [PULL 22/33] target-arm: make DFSR banked

2014-12-11 Thread Peter Maydell
From: Fabian Aggeler aggel...@ethz.ch When EL3 is running in AArch32 (or ARMv7 with Security Extensions) DFSR has a secure and a non-secure instance. Signed-off-by: Fabian Aggeler aggel...@ethz.ch Signed-off-by: Greg Bellows greg.bell...@linaro.org Reviewed-by: Peter Maydell

[Qemu-devel] [PULL 12/33] target-arm: add NSACR register

2014-12-11 Thread Peter Maydell
From: Fabian Aggeler aggel...@ethz.ch Implements NSACR register with corresponding read/write functions for ARMv7 and ARMv8. Signed-off-by: Sergey Fedorov s.fedo...@samsung.com Signed-off-by: Fabian Aggeler aggel...@ethz.ch Signed-off-by: Greg Bellows greg.bell...@linaro.org Reviewed-by: Peter

[Qemu-devel] [PULL 11/33] target-arm: implement IRQ/FIQ routing to Monitor mode

2014-12-11 Thread Peter Maydell
From: Fabian Aggeler aggel...@ethz.ch SCR.{IRQ/FIQ} bits allow to route IRQ/FIQ exceptions to monitor CPU mode. When taking IRQ exception to monitor mode FIQ exception is additionally masked. Signed-off-by: Sergey Fedorov s.fedo...@samsung.com Signed-off-by: Fabian Aggeler aggel...@ethz.ch

[Qemu-devel] [PATCH 03/10] sdl2: move keyboard input code to new sdl2-input.c

2014-12-11 Thread Gerd Hoffmann
Signed-off-by: Gerd Hoffmann kra...@redhat.com --- include/ui/sdl2.h | 4 +++ ui/Makefile.objs | 2 +- ui/sdl2-input.c | 106 ++ ui/sdl2.c | 75 ++ 4 files changed, 114 insertions(+), 73

[Qemu-devel] [PULL 14/33] target-arm: add MVBAR support

2014-12-11 Thread Peter Maydell
From: Fabian Aggeler aggel...@ethz.ch Use MVBAR register as exception vector base address for exceptions taken to CPU monitor mode. Signed-off-by: Sergey Fedorov s.fedo...@samsung.com Signed-off-by: Fabian Aggeler aggel...@ethz.ch Signed-off-by: Greg Bellows greg.bell...@linaro.org Reviewed-by:

[Qemu-devel] [PULL 02/33] Add the -semihosting-config option.

2014-12-11 Thread Peter Maydell
From: Liviu Ionescu i...@livius.net The usual semihosting behaviour is to process the system calls locally and return; unfortuantelly the initial implementation dinamically changed the target to GDB during debug sessions, which, for the usual arm-none-eabi-gdb, is not implemented. The result was

[Qemu-devel] [PULL 08/33] target-arm: add secure state bit to CPREG hash

2014-12-11 Thread Peter Maydell
Added additional NS-bit to CPREG hash encoding. Updated hash lookup locations to specify hash bit currently set to non-secure. Signed-off-by: Greg Bellows greg.bell...@linaro.org Reviewed-by: Peter Maydell peter.mayd...@linaro.org Message-id:

[Qemu-devel] [PULL 15/33] target-arm: add SCTLR_EL3 and make SCTLR banked

2014-12-11 Thread Peter Maydell
From: Fabian Aggeler aggel...@ethz.ch Implements SCTLR_EL3 and uses secure/non-secure instance when needed. Signed-off-by: Fabian Aggeler aggel...@ethz.ch Signed-off-by: Greg Bellows greg.bell...@linaro.org Reviewed-by: Peter Maydell peter.mayd...@linaro.org Message-id:

[Qemu-devel] [PULL 13/33] target-arm: add SDER definition

2014-12-11 Thread Peter Maydell
From: Greg Bellows greg.bell...@linaro.org Added CP register defintions for SDER and SDER32_EL3 as well as cp15.sder for register storage. Signed-off-by: Sergey Fedorov s.fedo...@samsung.com Signed-off-by: Fabian Aggeler aggel...@ethz.ch Signed-off-by: Greg Bellows greg.bell...@linaro.org

[Qemu-devel] [PULL 05/33] target-arm: add banked register accessors

2014-12-11 Thread Peter Maydell
From: Fabian Aggeler aggel...@ethz.ch If EL3 is in AArch32 state certain cp registers are banked (secure and non-secure instance). When reading or writing to coprocessor registers the following macros can be used. - A32_BANKED macros are used for choosing the banked register based on provided

[Qemu-devel] [PULL 09/33] target-arm: insert AArch32 cpregs twice into hashtable

2014-12-11 Thread Peter Maydell
From: Fabian Aggeler aggel...@ethz.ch Prepare for cp register banking by inserting every cp register twice, once for secure world and once for non-secure world. Signed-off-by: Fabian Aggeler aggel...@ethz.ch Signed-off-by: Greg Bellows greg.bell...@linaro.org Reviewed-by: Peter Maydell

[Qemu-devel] [PULL 01/33] Pass semihosting exit code back to system.

2014-12-11 Thread Peter Maydell
From: Liviu Ionescu i...@livius.net In order to run unit tests under semihosting, it is necessary to pass the application exit code back to the system. ARM defines only the code to be used for non-error application exit (ADP_Stopped_ApplicationExit), all other codes should return non-zero exit

Re: [Qemu-devel] [PATCH v2] pc: acpi-build: make linker RSDP tables dynamic

2014-12-11 Thread Igor Mammedov
On Thu, 11 Dec 2014 13:41:07 +0200 Marcel Apfelbaum marce...@redhat.com wrote: On Thu, 2014-12-11 at 12:23 +0100, Igor Mammedov wrote: On Thu, 11 Dec 2014 11:18:50 +0200 Marcel Apfelbaum marce...@redhat.com wrote: On Thu, 2014-12-11 at 09:10 +, Igor Mammedov wrote: linker and

[Qemu-devel] [PULL 06/33] target-arm: add non-secure Translation Block flag

2014-12-11 Thread Peter Maydell
From: Sergey Fedorov s.fedo...@samsung.com This patch is based on idea found in patch at git://github.com/jowinter/qemu-trustzone.git f3d955c6c0ed8c46bc0eb10b634201032a651dd2 by Johannes Winter johannes.win...@iaik.tugraz.at. The TBFLAG captures the SCR NS secure state at the time when a TB is

[Qemu-devel] [PULL 04/33] target-arm: add async excp target_el function

2014-12-11 Thread Peter Maydell
From: Greg Bellows greg.bell...@linaro.org Adds a dedicated function and a lookup table for determining the target exception level of IRQ and FIQ exceptions. The lookup table is taken from the ARMv7 and ARMv8 specification exception routing tables. Signed-off-by: Greg Bellows

Re: [Qemu-devel] [PATCH v2] pc: acpi-build: make linker RSDP tables dynamic

2014-12-11 Thread Michael S. Tsirkin
On Thu, Dec 11, 2014 at 01:21:13PM +0100, Igor Mammedov wrote: On Thu, 11 Dec 2014 13:41:07 +0200 Marcel Apfelbaum marce...@redhat.com wrote: On Thu, 2014-12-11 at 12:23 +0100, Igor Mammedov wrote: On Thu, 11 Dec 2014 11:18:50 +0200 Marcel Apfelbaum marce...@redhat.com wrote:

[Qemu-devel] [PULL 03/33] target-arm: extend async excp masking

2014-12-11 Thread Peter Maydell
From: Greg Bellows greg.bell...@linaro.org This patch extends arm_excp_unmasked() to use lookup tables for determining whether IRQ and FIQ exceptions are masked. The lookup tables are based on the ARMv8 and ARMv7 specification physical interrupt masking tables. If EL3 is using AArch64 IRQ/FIQ

Re: [Qemu-devel] [RfC PATCH 0/3] sdl2: add opengl rendering support

2014-12-11 Thread Daniel P. Berrange
On Thu, Dec 11, 2014 at 12:05:53PM +0100, Gerd Hoffmann wrote: Hi, This series add support for screen rendering using opengl. This only blits classic DisplaySurfaces to the screen using opengl, it does not (yet) enable gfx emulation use opengl for rendering. It depends on the sdl2:

Re: [Qemu-devel] [PATCH v2] pc: acpi-build: make linker RSDP tables dynamic

2014-12-11 Thread Igor Mammedov
On Thu, 11 Dec 2014 12:37:10 +0200 Michael S. Tsirkin m...@redhat.com wrote: On Thu, Dec 11, 2014 at 09:10:53AM +, Igor Mammedov wrote: linker and RSDP tables are build only once, so if later s/build/built/ during rebuild sizes of other ACPI tables change pointers will be patched

Re: [Qemu-devel] [PATCH v2] pc: acpi-build: make linker RSDP tables dynamic

2014-12-11 Thread Michael S. Tsirkin
On Thu, Dec 11, 2014 at 01:31:58PM +0100, Igor Mammedov wrote: On Thu, 11 Dec 2014 12:37:10 +0200 Michael S. Tsirkin m...@redhat.com wrote: On Thu, Dec 11, 2014 at 09:10:53AM +, Igor Mammedov wrote: linker and RSDP tables are build only once, so if later s/build/built/

  1   2   3   4   >