Re: [Qemu-devel] [edk2] Could not add PCI device with big memory to aarch64 VMs

2015-11-30 Thread Laszlo Ersek
On 11/30/15 19:45, liang yan wrote: > > > On 11/04/2015 05:53 PM, Laszlo Ersek wrote: >> On 11/04/15 23:22, liang yan wrote: >>> Hello, Laszlo, >>> >>> >>> (2)It also has a problem that once I use a memory bigger than 256M for >>> ivshmem, it could not get through UEFI, >>> the error message is

Re: [Qemu-devel] [PATCH] m25p80.c Added support for N25Q256 and N25Q512

2015-11-30 Thread Krzeminski, Marcin (Nokia - PL/Wroclaw)
> -Original Message- > From: EXT Peter Crosthwaite [mailto:crosthwaitepe...@gmail.com] > Sent: Monday, November 30, 2015 9:55 PM > To: Krzeminski, Marcin (Nokia - PL/Wroclaw) > Cc: qemu-devel@nongnu.org; g...@xilinx.com; Sai Pavan Boddu > Subject: Re: [Qemu-devel] [PATCH] m25p80.c Added

Re: [Qemu-devel] [PATCH v3 10/12] Dump: add qmp command "query-dump"

2015-11-30 Thread Eric Blake
On 11/30/2015 04:32 AM, Peter Xu wrote: > When dump-guest-memory is requested with detach flag, after its > return, user could query its status using "query-dump" command (with > no argument). The result for now contains: > > - status: current dump status > - written_bytes: bytes written in

Re: [Qemu-devel] [PATCH v3 02/12] dump-guest-memory: add "detach" flag for QMP/HMP interfaces.

2015-11-30 Thread Eric Blake
On 11/30/2015 04:32 AM, Peter Xu wrote: > This patch only adds the interfaces, but not implements them. > "detach" parameter is made optional, to make sure that all the old > dump-guest-memory requests will still be able to work. > > Signed-off-by: Peter Xu > --- > dump.c

Re: [Qemu-devel] [PATCH v3 08/12] dump-guest-memory: add qmp event DUMP_COMPLETED

2015-11-30 Thread Eric Blake
On 11/30/2015 04:32 AM, Peter Xu wrote: > One new QMP event DUMP_COMPLETED is added. It is used when user > specified "detach" in dump, and triggered when the dump finishes > (either succeeded or failed). If failed, one "err" data will be > passed with specific error message. > > Signed-off-by:

[Qemu-devel] Reminder: QEMU 2.5rc3 (final RC) planned for Thurs 1st Dec, please get bugfixes in before then

2015-11-30 Thread Peter Maydell
Hi; just a reminder that QEMU 2.5 rc3 is planned for this Thursday, the 1st December. (http://wiki.qemu.org/Planning/2.5#Release_Schedule) This is our last scheduled release candidate, so please make sure you get all outstanding bugfixes for 2.5 in before then. As usual I intend to only roll an

Re: [Qemu-devel] [Qemu-ppc] [PATCH 00/77] ppc: Add "native" POWER8 platform

2015-11-30 Thread Cédric Le Goater
On 11/30/2015 09:09 PM, Benjamin Herrenschmidt wrote: > On Mon, 2015-11-30 at 19:15 +0100, Cédric Le Goater wrote: >> The pnor file is compiled from github. The patch is below (without the dirty >> cut and paste I did in loader.c). The offset for the PAYLOAD and BOOTKERNEL >> partitions are hard

Re: [Qemu-devel] [PULL 0/5] ppc-for-2.5 queue 20151130

2015-11-30 Thread Peter Maydell
> > are available in the git repository at: > > git://github.com/dgibson/qemu.git tags/ppc-for-2.5-20151130 > > for you to fetch changes up to 7624789234cd63b671bce1b49b93b0b1c00ea407: > > target-ppc/fpu_helper: fix FPSCR_FX bit shi

Re: [Qemu-devel] [PATCH v3 03/12] dump-guest-memory: using static DumpState, add DumpStatus

2015-11-30 Thread Eric Blake
On 11/30/2015 04:32 AM, Peter Xu wrote: > Instead of malloc/free each time for DumpState, make it > static. Added DumpStatus to show status for dump. > > This is to be used for detach dump. s/detach/detached/ > > Signed-off-by: Peter Xu > --- > dump.c| 30

[Qemu-devel] [PATCH] exec: Stop using memory after free

2015-11-30 Thread Don Slutz
memory_region_unref(mr) can free memory. For example I got: Program received signal SIGSEGV, Segmentation fault. [Switching to Thread 0x7f43280d4700 (LWP 4462)] 0x7f43323283c0 in phys_section_destroy (mr=0x7f43259468b0) at /home/don/xen/tools/qemu-xen-dir/exec.c:1023 1023if

[Qemu-devel] [Bug 1054558] Re: 1366x768 resolution missing

2015-11-30 Thread Bug Watch Updater
** Changed in: debian Status: New => Confirmed -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1054558 Title: 1366x768 resolution missing Status in QEMU: New Status in Debian: Confirmed

[Qemu-devel] [PULL 3/5] hw/ppc/ppc405_boards: Fix infinite recursion by converting taihu_cpld from old_mmio

2015-11-30 Thread David Gibson
From: Peter Maydell The taihu_cpld_writel() function had an obvious typo that meant that if it was ever called it would go into an infinite recursion. Newer versions of clang will detect and warn about this: hw/ppc/ppc405_boards.c:481:1: warning: all paths through

[Qemu-devel] [PULL 4/5] target-ppc: Move the FPSCR bit update macros to cpu.h

2015-11-30 Thread David Gibson
From: Madhavan Srinivasan Move the FPSCR bit update macros defined in dfp_helper to cpu.h. This way, fpu_helper functions can also use them Signed-off-by: Madhavan Srinivasan Signed-off-by: David Gibson ---

[Qemu-devel] [PULL 0/5] ppc-for-2.5 queue 20151130

2015-11-30 Thread David Gibson
The following changes since commit 714487515dbe0c65d5904251e796cd3a5b3579fb: Merge remote-tracking branch 'remotes/jasowang/tags/net-pull-request' into staging (2015-11-27 10:44:42 +) are available in the git repository at: git://github.com/dgibson/qemu.git tags/ppc-for-2.5-20151130

Re: [Qemu-devel] [PATCH v8 0/5] implement vNVDIMM

2015-11-30 Thread Stefan Hajnoczi
On Mon, Nov 16, 2015 at 06:50:58PM +0800, Xiao Guangrong wrote: > This patchset can be found at: > https://github.com/xiaogr/qemu.git nvdimm-v8 > > It is based on pci branch on Michael's tree and the top commit is: > commit e3a4e177d9 (migration/ram: fix build on 32 bit hosts). > >

Re: [Qemu-devel] [PATCH v2 06/21] block: Exclude nested options only for children in append_open_options()

2015-11-30 Thread Kevin Wolf
Am 27.11.2015 um 18:58 hat Max Reitz geschrieben: > On 23.11.2015 16:59, Kevin Wolf wrote: > > Some drivers have nested options (e.g. blkdebug rule arrays), which > > don't belong to a child node and shouldn't be removed. Don't remove all > > options with "." in their name, but check for the

Re: [Qemu-devel] question: about exec/poison.h

2015-11-30 Thread Paolo Bonzini
On 30/11/2015 04:47, Peter Xu wrote: > > I met one problem when trying to add a new public function in dump.h > named "dump_state_get_global" and using it in hmp.c. Don't do that. :) hmp.c functions should in general use the QMP commands as the base. In your case, hmp_info_dump should call

Re: [Qemu-devel] question: about exec/poison.h

2015-11-30 Thread Markus Armbruster
Paolo Bonzini writes: > On 30/11/2015 04:47, Peter Xu wrote: >> >> I met one problem when trying to add a new public function in dump.h >> named "dump_state_get_global" and using it in hmp.c. > > Don't do that. :) > > hmp.c functions should in general use the QMP commands

Re: [Qemu-devel] [PATCH 05/40] virtio: read/write the VirtQueueElement a field at a time

2015-11-30 Thread Fam Zheng
On Tue, 11/24 19:00, Paolo Bonzini wrote: > Signed-off-by: Paolo Bonzini > --- > hw/virtio/virtio.c | 95 > -- > 1 file changed, 93 insertions(+), 2 deletions(-) > > diff --git a/hw/virtio/virtio.c b/hw/virtio/virtio.c >

Re: [Qemu-devel] question: about exec/poison.h

2015-11-30 Thread Peter Xu
On Mon, Nov 30, 2015 at 10:12:10AM +0100, Paolo Bonzini wrote: > > > On 30/11/2015 04:47, Peter Xu wrote: > > > > I met one problem when trying to add a new public function in dump.h > > named "dump_state_get_global" and using it in hmp.c. > > Don't do that. :) > > hmp.c functions should in

[Qemu-devel] [PATCH v5] bt: check struct sizes

2015-11-30 Thread Paolo Bonzini
See http://permalink.gmane.org/gmane.linux.bluez.kernel/36505. For historical reasons these do not use sizeof, and Coverity caught a mistake in EVT_ENCRYPT_CHANGE_SIZE. In addition: - remove status from create_conn_cancel_cp; the "status" field is only in rp structs. Note that this means that

Re: [Qemu-devel] question: about exec/poison.h

2015-11-30 Thread Peter Xu
On Mon, Nov 30, 2015 at 10:28:08AM +0100, Markus Armbruster wrote: > Paolo Bonzini writes: > > > On 30/11/2015 04:47, Peter Xu wrote: > >> > >> I met one problem when trying to add a new public function in dump.h > >> named "dump_state_get_global" and using it in hmp.c. > >

Re: [Qemu-devel] [PATCH v8 3/5] nvdimm acpi: build ACPI NFIT table

2015-11-30 Thread Michael S. Tsirkin
On Mon, Nov 16, 2015 at 06:51:01PM +0800, Xiao Guangrong wrote: > NFIT is defined in ACPI 6.0: 5.2.25 NVDIMM Firmware Interface Table (NFIT) > > Currently, we only support PMEM mode. Each device has 3 structures: > - SPA structure, defines the PMEM region info > > - MEM DEV structure, it has the

Re: [Qemu-devel] [PATCH v8 4/5] nvdimm acpi: build ACPI nvdimm devices

2015-11-30 Thread Michael S. Tsirkin
On Mon, Nov 16, 2015 at 06:51:02PM +0800, Xiao Guangrong wrote: > NVDIMM devices is defined in ACPI 6.0 9.20 NVDIMM Devices > > There is a root device under \_SB and specified NVDIMM devices are under the > root device. Each NVDIMM device has _ADR which returns its handle used to > associate

[Qemu-devel] [PATCH v2 0/9] KVM: Hyper-V SynIC timers

2015-11-30 Thread Andrey Smetanin
Per Hyper-V specification (and as required by Hyper-V-aware guests), SynIC provides 4 per-vCPU timers. Each timer is programmed via a pair of MSRs, and signals expiration by delivering a special format message to the configured SynIC message slot and triggering the corresponding synthetic

[Qemu-devel] [PATCH v2 5/9] kvm/x86: Rearrange func's declarations inside Hyper-V header

2015-11-30 Thread Andrey Smetanin
This rearrangement places functions declarations together according to their functionality, so future additions will be simplier. Signed-off-by: Andrey Smetanin Reviewed-by: Roman Kagan CC: Gleb Natapov CC: Paolo Bonzini

[Qemu-devel] [PATCH v2 7/9] kvm/x86: Hyper-V internal helper to read MSR HV_X64_MSR_TIME_REF_COUNT

2015-11-30 Thread Andrey Smetanin
This helper will be used also in Hyper-V SynIC timers implementation. Signed-off-by: Andrey Smetanin Reviewed-by: Roman Kagan CC: Gleb Natapov CC: Paolo Bonzini CC: "K. Y. Srinivasan" CC:

[Qemu-devel] [PATCH v3] vmxnet3: silence warning

2015-11-30 Thread Michael S. Tsirkin
vmxnet3 always produces a warning under qtest. This is not a user error, don't warn. Suggested-by: Paolo Bonzini Signed-off-by: Michael S. Tsirkin --- Now for real. hw/net/vmxnet3.c | 1 - 1 file changed, 1 deletion(-) diff --git a/hw/net/vmxnet3.c

Re: [Qemu-devel] [PATCH v9] block/raw-posix.c: Make physical devices usable in QEMU under Mac OS X host

2015-11-30 Thread Kevin Wolf
Am 30.11.2015 um 17:19 hat Eric Blake geschrieben: > On 11/27/2015 12:35 PM, Programmingkid wrote: > > >> Unusual indentation; more typical is: > >> > >> | static kern_return_t FindEjectableOpticalMedia(io_iterator_t > >> *mediaIterator, > >> | char *mediatType) > > > > I agree. I wanted the

[Qemu-devel] [PATCH v2 4/9] drivers/hv: Move struct hv_timer_message_payload into UAPI Hyper-V x86 header

2015-11-30 Thread Andrey Smetanin
This struct is required for Hyper-V SynIC timers implementation inside KVM and for upcoming Hyper-V VMBus support by userspace(QEMU). So place it into Hyper-V UAPI header. Signed-off-by: Andrey Smetanin CC: Gleb Natapov CC: Paolo Bonzini

[Qemu-devel] [PATCH v2 9/9] kvm/x86: Hyper-V SynIC timers

2015-11-30 Thread Andrey Smetanin
Per Hyper-V specification (and as required by Hyper-V-aware guests), SynIC provides 4 per-vCPU timers. Each timer is programmed via a pair of MSRs, and signals expiration by delivering a special format message to the configured SynIC message slot and triggering the corresponding synthetic

Re: [Qemu-devel] [PATCH v9] block/raw-posix.c: Make physical devices usable in QEMU under Mac OS X host

2015-11-30 Thread Programmingkid
On Nov 30, 2015, at 11:26 AM, Kevin Wolf wrote: > Am 30.11.2015 um 17:19 hat Eric Blake geschrieben: >> On 11/27/2015 12:35 PM, Programmingkid wrote: >> Unusual indentation; more typical is: | static kern_return_t FindEjectableOpticalMedia(io_iterator_t *mediaIterator,

[Qemu-devel] [PATCH for-2.5 v4 2/4] vhost-user-test: use unix port for migration

2015-11-30 Thread marcandre . lureau
From: Marc-André Lureau TCP port 1234 may be used by another process concurrently. Instead use a temporary unix socket. Signed-off-by: Marc-André Lureau --- tests/vhost-user-test.c | 8 +++- 1 file changed, 7 insertions(+), 1

[Qemu-devel] [PATCH for-2.5 v4 4/4] tests: add vhost-user-test when target is x64 only

2015-11-30 Thread marcandre . lureau
From: Marc-André Lureau check-qtest-x86_64-y is overwritten by the last assignment. Move vhost-user-test addition after. Reported-by: Alex Bennée Signed-off-by: Marc-André Lureau --- tests/Makefile | 6 +++---

Re: [Qemu-devel] [PATCH v9] block/raw-posix.c: Make physical devices usable in QEMU under Mac OS X host

2015-11-30 Thread Eric Blake
On 11/30/2015 09:38 AM, Programmingkid wrote: >> +/* if a working partition on the device was not found */ >> +if (partition_found == false) { >> +error_setg(errp, "Error: Failed to find a working partition on " >> +

Re: [Qemu-devel] [PATCH] mmap-alloc: use same backend for all mappings

2015-11-30 Thread Michael S. Tsirkin
On Mon, Nov 30, 2015 at 02:46:31PM +0100, Greg Kurz wrote: > On Mon, 30 Nov 2015 15:06:33 +0200 > "Michael S. Tsirkin" wrote: > > > On Mon, Nov 30, 2015 at 11:51:57AM +0100, Greg Kurz wrote: > > > Since commit 8561c9244ddf1122d "exec: allocate PROT_NONE pages on top of > > >

[Qemu-devel] [Bug 1450881] Re: qemu-system-sparc MUTEX_HELD assert and libC lock errors

2015-11-30 Thread Pierre L
Hi all, I also have this issue with my sparcstation installation : Emulated OS : SunOS 5.5.1 Emulated Processor : sparc Host machine OS : Linux RED HAT Do you manage to fix it ? -- You received this bug

[Qemu-devel] iSCSI options for IQN with colons

2015-11-30 Thread Pino Toscano
Hi, while testing the integration of QEMU with iSCSI, I was setting up an environment with both target and initiator IQNs with colons. Then I tried to connect to two different targets using two different initiator IQN, like the following: $ qemu ... \ -iscsi

[Qemu-devel] keycode error

2015-11-30 Thread hjenkins
Dear QEMU Developers, I'm trying to use QEMU to run Debian on OS X Yosemite on a MacBookPro (13-inch). I followed the instructions at https://wiki.debian.org/QEMU, downloaded a standard prefab iso, and issued these commands with this result: qemu-img create debian.img 2G qemu-system-x86_64 -hda

Re: [Qemu-devel] [PATCH v10] block/raw-posix.c: Make physical devices usable in QEMU under Mac OS X host

2015-11-30 Thread Eric Blake
On 11/30/2015 09:51 AM, Programmingkid wrote: >>> +++ b/block/raw-posix.c >>> @@ -42,9 +42,9 @@ >>> #include >>> #include >>> #include >>> -//#include >>> +#include >>> #include >>> -#endif >>> +#endif /* (__APPLE__) && (__MACH__) */ >>> >> >> I have now mentioned in both v8 and v9 that

Re: [Qemu-devel] [PULL 0/3] wxx: Last minute fixes for 2.5

2015-11-30 Thread Peter Maydell
are available in the git repository at: > > git://qemu.weilnetz.de/qemu.git tags/pull-wxx-20151130 > > for you to fetch changes up to 78e9d4ad11e7116376328860a58b96765ade7b62: > > w32: Use gcc option -mthreads (2015-11-30 06:47:02 +0100) > >

Re: [Qemu-devel] [PATCH v6 20/21] iotests: add incremental backup failure recovery test

2015-11-30 Thread John Snow
On 11/27/2015 12:14 PM, Kevin Wolf wrote: > Am 18.04.2015 um 01:50 hat John Snow geschrieben: >> Test the failure case for incremental backups. >> >> Signed-off-by: John Snow >> Reviewed-by: Max Reitz >> --- >> tests/qemu-iotests/124 | 57 >>

[Qemu-devel] [PATCH v2 2/9] drivers/hv: Move HV_SYNIC_STIMER_COUNT into Hyper-V UAPI x86 header

2015-11-30 Thread Andrey Smetanin
This constant is required for Hyper-V SynIC timers MSR's support by userspace(QEMU). Signed-off-by: Andrey Smetanin Acked-by: K. Y. Srinivasan Reviewed-by: Roman Kagan CC: Gleb Natapov CC: Paolo Bonzini

[Qemu-devel] [PATCH v2 6/9] kvm/x86: Added Hyper-V vcpu_to_hv_vcpu()/hv_vcpu_to_vcpu() helpers

2015-11-30 Thread Andrey Smetanin
Signed-off-by: Andrey Smetanin Reviewed-by: Roman Kagan CC: Gleb Natapov CC: Paolo Bonzini CC: "K. Y. Srinivasan" CC: Haiyang Zhang CC: Vitaly Kuznetsov

Re: [Qemu-devel] [PATCH v10] block/raw-posix.c: Make physical devices usable in QEMU under Mac OS X host

2015-11-30 Thread Eric Blake
On 11/27/2015 02:49 PM, Programmingkid wrote: > Mac OS X can be picky when it comes to allowing the user > to use physical devices in QEMU. Most mounted volumes > appear to be off limits to QEMU. If an issue is detected, > a message is displayed showing the user how to unmount a > volume. > >

Re: [Qemu-devel] [PATCH v3 1/4] pc: Remove redundant code from pc-*-2.3 machine classes

2015-11-30 Thread Thomas Huth
On 30/11/15 15:56, Eduardo Habkost wrote: > Remove the redundant 'alias = NULL' and 'is_default = 0' lines > from older machine-types. pc_*_2_4_machine_options() already > clear those fields, so they don't need to be cleared by > pc_*_2_3_machine_options(). > > Reviewed-by: Marcel Apfelbaum

[Qemu-devel] [PATCH] coverity: Model g_memdup()

2015-11-30 Thread Markus Armbruster
We model all the non-deprecated memory allocation functions from https://developer.gnome.org/glib/stable/glib-Memory-Allocation.html except for g_memdup(), g_clear_pointer(), g_steal_pointer(). We don't use the latter two. Model the former. Coverity now reports an OVERRUN vl.c:2317:

Re: [Qemu-devel] [PATCH v3 2/4] pc: Add pc-*-2.6 machine classes

2015-11-30 Thread Marcel Apfelbaum
On 11/30/2015 04:56 PM, Eduardo Habkost wrote: Add pc-i440fx-2.6 and pc-q35-2.6 machine classes. Signed-off-by: Eduardo Habkost --- Changes v1 -> v2: * Add missing backslash to PC_COMPAT_2_4 Changes v2 -> v3: * Add HW_COMPAT_2_5 to PC_COMPAT_2_5 --- hw/i386/pc_piix.c

Re: [Qemu-devel] [PATCH v3 3/4] pc: Change indentation of PC_COMPAT_* to 4 spaces

2015-11-30 Thread Thomas Huth
On 30/11/15 15:56, Eduardo Habkost wrote: > Cosmetic change only. > > Signed-off-by: Eduardo Habkost > --- > include/hw/i386/pc.h | 924 > +-- > 1 file changed, 462 insertions(+), 462 deletions(-) Reviewed-by: Thomas Huth

Re: [Qemu-devel] [PATCH v3 4/4] hw/compat.h: Change indentation of HW_COMPAT_* to 4 spaces

2015-11-30 Thread Thomas Huth
On 30/11/15 15:56, Eduardo Habkost wrote: > Cosmetic change only. > > Signed-off-by: Eduardo Habkost > --- > include/hw/compat.h | 136 > ++-- > 1 file changed, 68 insertions(+), 68 deletions(-) Reviewed-by: Thomas Huth

Re: [Qemu-devel] [PATCH v2 3/3] vhost-user-test: fix crash with glib < 2.36

2015-11-30 Thread Markus Armbruster
"Michael S. Tsirkin" writes: > On Mon, Nov 30, 2015 at 12:17:00PM +0100, marcandre.lur...@redhat.com wrote: >> From: Marc-André Lureau >> >> The prepare callback needs to be implemented with glib < 2.36. >> >> Signed-off-by: Marc-André Lureau

Re: [Qemu-devel] [PATCH v10] block/raw-posix.c: Make physical devices usable in QEMU under Mac OS X host

2015-11-30 Thread Programmingkid
On Nov 30, 2015, at 11:26 AM, Eric Blake wrote: > On 11/27/2015 02:49 PM, Programmingkid wrote: >> Mac OS X can be picky when it comes to allowing the user >> to use physical devices in QEMU. Most mounted volumes >> appear to be off limits to QEMU. If an issue is detected, >> a message is

Re: [Qemu-devel] [PATCH v7 14/24] nbd: Switch from close to eject notifier

2015-11-30 Thread Max Reitz
On 30.11.2015 16:36, Kevin Wolf wrote: > Am 09.11.2015 um 23:39 hat Max Reitz geschrieben: >> The NBD code uses the BDS close notifier to determine when a medium is >> ejected. However, now it should use the BB's BDS removal notifier for >> that instead of the BDS's close notifier. >> >>

[Qemu-devel] [PATCH v2 3/9] drivers/hv: Move struct hv_message into UAPI Hyper-V x86 header

2015-11-30 Thread Andrey Smetanin
This struct is required for Hyper-V SynIC timers implementation inside KVM and for upcoming Hyper-V VMBus support by userspace(QEMU). So place it into Hyper-V UAPI header. Signed-off-by: Andrey Smetanin Acked-by: K. Y. Srinivasan Reviewed-by: Roman

[Qemu-devel] [PATCH v2 1/9] drivers/hv: replace enum hv_message_type by u32

2015-11-30 Thread Andrey Smetanin
enum hv_message_type inside struct hv_message, hv_post_message is not size portable. Replace enum by u32. Signed-off-by: Andrey Smetanin CC: Gleb Natapov CC: Paolo Bonzini CC: "K. Y. Srinivasan" CC: Haiyang

[Qemu-devel] [PATCH v2 8/9] kvm/x86: Hyper-V SynIC message slot pending clearing at SINT ack

2015-11-30 Thread Andrey Smetanin
The SynIC message protocol mandates that the message slot is claimed by atomically setting message type to something other than HVMSG_NONE. If another message is to be delivered while the slot is still busy, message pending flag is asserted to indicate to the guest that the hypervisor wants to be

Re: [Qemu-devel] [PATCH v7 24/24] iotests: Add test for block jobs and BDS ejection

2015-11-30 Thread Kevin Wolf
Am 09.11.2015 um 23:39 hat Max Reitz geschrieben: > Suggested-by: Paolo Bonzini > Signed-off-by: Max Reitz > --- > tests/qemu-iotests/141 | 166 > + > tests/qemu-iotests/141.out | 47 + >

Re: [Qemu-devel] [PATCH v3 2/4] pc: Add pc-*-2.6 machine classes

2015-11-30 Thread Thomas Huth
On 30/11/15 15:56, Eduardo Habkost wrote: > Add pc-i440fx-2.6 and pc-q35-2.6 machine classes. > > Signed-off-by: Eduardo Habkost > --- > Changes v1 -> v2: > * Add missing backslash to PC_COMPAT_2_4 > > Changes v2 -> v3: > * Add HW_COMPAT_2_5 to PC_COMPAT_2_5 > --- >

Re: [Qemu-devel] [PATCH 01/40] 9pfs: allocate pdus with g_malloc/g_free

2015-11-30 Thread Greg Kurz
On Tue, 24 Nov 2015 19:00:52 +0100 Paolo Bonzini wrote: > Prepare for moving the allocation to virtqueue_pop. > > Signed-off-by: Paolo Bonzini > --- And aside from this series goal, it makes the code nicer :) > hw/9pfs/virtio-9p-device.c | 7

[Qemu-devel] [PATCH for-2.5 v4 0/4] vhost-user-test fixes

2015-11-30 Thread marcandre . lureau
From: Marc-André Lureau This series fixes a number of races and crashes on glib < 2.36 (with Travis build for ex). v3->v4: - add patch to include vhost-user-test when target list lacks 386. - add a code comment about <2.36 prepare callback. v2->v3: - quote glib

[Qemu-devel] [PATCH for-2.5 v4 1/4] vhost-user-test: fix chardriver race

2015-11-30 Thread marcandre . lureau
From: Marc-André Lureau vhost-user-tests uses a helper thread to dispatch the vhost-user servers sources. However the CharDriverState is not thread-safe. Therefore, when it's given to the thread, it shouldn't be manipulated concurrently. We dispatch cleaning the

[Qemu-devel] [PATCH for-2.5 v4 3/4] vhost-user-test: fix crash with glib < 2.36

2015-11-30 Thread marcandre . lureau
From: Marc-André Lureau The prepare callback needs to be implemented with glib < 2.36, quoting glib documentation: "Since 2.36 this may be NULL, in which case the effect is as if the function always returns FALSE with a timeout of -1." Signed-off-by: Marc-André

Re: [Qemu-devel] [PATCH for-2.5 v3 0/3] vhost-user-test fixes

2015-11-30 Thread Alex Bennée
marcandre.lur...@redhat.com writes: > From: Marc-André Lureau > > This series fixes a number of races and crashes on glib < 2.36 > (with Travis build for ex). When does this test get run normally? I don't see it when I do a "make check" with a my build:

Re: [Qemu-devel] [PATCH for-2.5 v3 0/3] vhost-user-test fixes

2015-11-30 Thread Marc-André Lureau
On Mon, Nov 30, 2015 at 4:14 PM, Alex Bennée wrote: > When does this test get run normally? I don't see it when I do a "make > check" with a my build: > > ./configure > --target-list=arm-softmmu,aarch64-softmmu,i386-softmmu,x86_64-softmmu That should work, as long as

Re: [Qemu-devel] [PATCH v7 14/24] nbd: Switch from close to eject notifier

2015-11-30 Thread Kevin Wolf
Am 09.11.2015 um 23:39 hat Max Reitz geschrieben: > The NBD code uses the BDS close notifier to determine when a medium is > ejected. However, now it should use the BB's BDS removal notifier for > that instead of the BDS's close notifier. > > Signed-off-by: Max Reitz > --- >

Re: [Qemu-devel] [PATCH v2 06/21] block: Exclude nested options only for children in append_open_options()

2015-11-30 Thread Max Reitz
On 30.11.2015 10:01, Kevin Wolf wrote: > Am 27.11.2015 um 18:58 hat Max Reitz geschrieben: >> On 23.11.2015 16:59, Kevin Wolf wrote: >>> Some drivers have nested options (e.g. blkdebug rule arrays), which >>> don't belong to a child node and shouldn't be removed. Don't remove all >>> options with

Re: [Qemu-devel] [PATCH v9] block/raw-posix.c: Make physical devices usable in QEMU under Mac OS X host

2015-11-30 Thread Eric Blake
On 11/27/2015 12:35 PM, Programmingkid wrote: >> Unusual indentation; more typical is: >> >> | static kern_return_t FindEjectableOpticalMedia(io_iterator_t >> *mediaIterator, >> | char *mediatType) > > I agree. I wanted the second long to be right justified with the 80 character > line count.

[Qemu-devel] [PATCH v3 4/4] hw/compat.h: Change indentation of HW_COMPAT_* to 4 spaces

2015-11-30 Thread Eduardo Habkost
Cosmetic change only. Signed-off-by: Eduardo Habkost --- include/hw/compat.h | 136 ++-- 1 file changed, 68 insertions(+), 68 deletions(-) diff --git a/include/hw/compat.h b/include/hw/compat.h index fae0d8e..24dd2c0 100644

Re: [Qemu-devel] [PATCH V3 3/3] hw/i386: extend pxb query for all PC machines

2015-11-30 Thread Eduardo Habkost
On Sun, Nov 29, 2015 at 10:46:03AM +0200, Marcel Apfelbaum wrote: > On 11/27/2015 07:28 PM, Eduardo Habkost wrote: > >On Thu, Nov 26, 2015 at 06:00:28PM +0200, Marcel Apfelbaum wrote: > >>Add bus property to PC machines and use it when looking > >>for primary PCI root bus (bus 0). > >> >

Re: [Qemu-devel] [RFC PATCH V2 0/3] IXGBE/VFIO: Add live migration support for SRIOV NIC

2015-11-30 Thread Alexander Duyck
On Sun, Nov 29, 2015 at 10:53 PM, Lan, Tianyu wrote: > On 11/26/2015 11:56 AM, Alexander Duyck wrote: >> >> > I am not saying you cannot modify the drivers, however what you are >> doing is far too invasive. Do you seriously plan on modifying all of >> the PCI device

[Qemu-devel] [PULL 1/2] fsdev-proxy-helper: avoid TOC/TOU race

2015-11-30 Thread Greg Kurz
From: Paolo Bonzini There is a minor time of check/time of use race between statfs and chroot. It can be fixed easily by stat-ing the root after it has been changed. Signed-off-by: Paolo Bonzini Reviewed-by: Greg Kurz

[Qemu-devel] [PULL 0/2] virtio-9p fixes for 2.5

2015-11-30 Thread Greg Kurz
The following changes since commit 714487515dbe0c65d5904251e796cd3a5b3579fb: Merge remote-tracking branch 'remotes/jasowang/tags/net-pull-request' into staging (2015-11-27 10:44:42 +) are available in the git repository at: https://github.com/gkurz/qemu.git tags/for-upstream for you

[Qemu-devel] [PATCH v3 3/4] pc: Change indentation of PC_COMPAT_* to 4 spaces

2015-11-30 Thread Eduardo Habkost
Cosmetic change only. Signed-off-by: Eduardo Habkost --- include/hw/i386/pc.h | 924 +-- 1 file changed, 462 insertions(+), 462 deletions(-) diff --git a/include/hw/i386/pc.h b/include/hw/i386/pc.h index 3226291..3a09ccd

[Qemu-devel] [PATCH v3 1/4] pc: Remove redundant code from pc-*-2.3 machine classes

2015-11-30 Thread Eduardo Habkost
Remove the redundant 'alias = NULL' and 'is_default = 0' lines from older machine-types. pc_*_2_4_machine_options() already clear those fields, so they don't need to be cleared by pc_*_2_3_machine_options(). Reviewed-by: Marcel Apfelbaum Signed-off-by: Eduardo Habkost

[Qemu-devel] [PATCH v3 0/4] pc: Add pc-*-2.6 machine classes

2015-11-30 Thread Eduardo Habkost
I am sending this earlier so it can be queued and used as base for patches that need to add compat code to the pc-2.5 machine types. Changes v1 -> v2: * Typo fix that I forgot to commit before submitting v1 Changes v2 -> v3: * Add HW_COMPAT_2_5 to PC_COMPAT_2_5 * Change indentation of

Re: [Qemu-devel] [Qemu-block] [PATCH v2 03/21] mirror: Error out when a BDS would get two BBs

2015-11-30 Thread Alberto Garcia
On Mon 23 Nov 2015 04:59:42 PM CET, Kevin Wolf wrote: > @@ -370,11 +371,22 @@ static void mirror_exit(BlockJob *job, void *opaque) > if (s->to_replace) { > to_replace = s->to_replace; > } > + > +/* This was checked in mirror_start_job(), but meanwhile one of

[Qemu-devel] [PATCH] MAINTAINERS: add maintainer to virtio-9p

2015-11-30 Thread Greg Kurz
As suggested by Paolo, I add myself as maintainer for virtio-9p. Signed-off-by: Greg Kurz --- MAINTAINERS |1 + 1 file changed, 1 insertion(+) diff --git a/MAINTAINERS b/MAINTAINERS index bb1f3e40622b..e8cee1e2668f 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@

[Qemu-devel] [PATCH v3 2/4] pc: Add pc-*-2.6 machine classes

2015-11-30 Thread Eduardo Habkost
Add pc-i440fx-2.6 and pc-q35-2.6 machine classes. Signed-off-by: Eduardo Habkost --- Changes v1 -> v2: * Add missing backslash to PC_COMPAT_2_4 Changes v2 -> v3: * Add HW_COMPAT_2_5 to PC_COMPAT_2_5 --- hw/i386/pc_piix.c| 16 +--- hw/i386/pc_q35.c | 13

[Qemu-devel] [PATCH] tests: add vhost-user-test when target is x64 only

2015-11-30 Thread marcandre . lureau
From: Marc-André Lureau check-qtest-x86_64-y is overwritten by the last assignment. Move vhost-user-test addition after. Reported-by: Alex Bennée Signed-off-by: Marc-André Lureau --- tests/Makefile | 6 +++---

[Qemu-devel] [PULL 2/2] virtio-9p: use QEMU thread pool

2015-11-30 Thread Greg Kurz
From: Paolo Bonzini The QEMU thread pool already has a mechanism to invoke callbacks in the main thread. It does not need an EventNotifier and it is more efficient too. Use it instead of GAsyncQueue + GThreadPool + glue. As a side effect, it silences Coverity's complaint

Re: [Qemu-devel] [PATCH v7 15/24] block: Remove BDS close notifier

2015-11-30 Thread Kevin Wolf
Am 09.11.2015 um 23:39 hat Max Reitz geschrieben: > It is unused now, so we can remove it. > > Signed-off-by: Max Reitz Reviewed-by: Kevin Wolf

Re: [Qemu-devel] [Qemu-block] [PATCH v2 05/21] block: Consider all block layer options in append_open_options

2015-11-30 Thread Alberto Garcia
On Mon 23 Nov 2015 04:59:44 PM CET, Kevin Wolf wrote: > The code already special-cased "node-name", which is currently the only > option passed in the QDict that isn't driver-specific. Generalise the > code to take all general block layer options into consideration. > > Signed-off-by: Kevin Wolf

Re: [Qemu-devel] Could not add PCI device with big memory to aarch64 VMs

2015-11-30 Thread liang yan
On 11/04/2015 05:53 PM, Laszlo Ersek wrote: On 11/04/15 23:22, liang yan wrote: Hello, Laszlo, (2)It also has a problem that once I use a memory bigger than 256M for ivshmem, it could not get through UEFI, the error message is PciBus: Discovered PCI @ [00|01|00] BAR[0]: Type = Mem32;

Re: [Qemu-devel] SPI EEPROM device model

2015-11-30 Thread Peter Crosthwaite
On Mon, Nov 30, 2015 at 12:53 AM, Krzeminski, Marcin (Nokia - PL/Wroclaw) wrote: > Hello, > > I need to write some SPI eeprom device model (probably AT25128B or AT93C56). > I can not see any such device in qemu, but this time I want to ask before I > start to

Re: [Qemu-devel] [PATCH 0/7] target-i386: MMReg struct cleanup

2015-11-30 Thread Richard Henderson
On 11/30/2015 10:21 AM, Eduardo Habkost wrote: This is an attempt to cleanup the MMXReg/XMMReg structs and make their names, fields and usage consistent. The last 2 patches use a bit of macro magic to generate the union definitions and ensure type safety when using the field helper macros, and

Re: [Qemu-devel] [Qemu-block] [PATCH for-2.5] blkdebug: silence warning under qtest

2015-11-30 Thread Max Reitz
On 30.11.2015 12:44, Michael S. Tsirkin wrote: > make check always outputs warnings, this > is not nice. Disable blkdebug warnings under qtest. > > Signed-off-by: Michael S. Tsirkin > --- > block/blkdebug.c | 9 +++-- > 1 file changed, 7 insertions(+), 2 deletions(-)

[Qemu-devel] [PATCH v2 2/3] target-i386: Use xsave structs for ext_save_area

2015-11-30 Thread Eduardo Habkost
This doesn't introduce any change in the code, as the offsets and struct sizes match what was present in the table. This can be validated by the QEMU_BUILD_BUG_ON lines on target-i386/cpu.h, which ensures the struct sizes and offsets match the existing values in ext_save_area. Signed-off-by:

[Qemu-devel] [PATCH v2 3/3] target-i386: kvm: Use X86XSaveArea struct for xsave save/load

2015-11-30 Thread Eduardo Habkost
Instead of using offset macros and bit operations in a uint32_t array, use the X86XSaveArea struct to perform the loading/saving operations in kvm_put_xsave() and kvm_get_xsave(). Signed-off-by: Eduardo Habkost --- Changes v1 -> v2: * Use uint8_t pointers when loading/saving

Re: [Qemu-devel] [PATCH v7 24/24] iotests: Add test for block jobs and BDS ejection

2015-11-30 Thread Max Reitz
On 30.11.2015 17:23, Kevin Wolf wrote: > Am 09.11.2015 um 23:39 hat Max Reitz geschrieben: >> Suggested-by: Paolo Bonzini >> Signed-off-by: Max Reitz >> --- >> tests/qemu-iotests/141 | 166 >> + >>

Re: [Qemu-devel] [PATCH v2 2/2] hmp: add support for system_suspend

2015-11-30 Thread Eric Blake
On 11/27/2015 08:01 PM, Chen Hanxiao wrote: > From: Chen Hanxiao > > This patch add support for system_suspend hmp command. > > Signed-off-by: Chen Hanxiao > --- > hmp-commands.hx | 14 ++ > hmp.c | 5 + > hmp.h

[Qemu-devel] [PATCH 6/7] [RFC] target-i386: Define MMREG_UNION macro

2015-11-30 Thread Eduardo Habkost
This will simplify the definitions of ZMMReg and MMXReg. Signed-off-by: Eduardo Habkost --- target-i386/cpu.h | 27 +++ 1 file changed, 11 insertions(+), 16 deletions(-) diff --git a/target-i386/cpu.h b/target-i386/cpu.h index 7519023..b189748

Re: [Qemu-devel] [PATCH v2 5/8] dump-query: add "dump-query" command to query dump status

2015-11-30 Thread Eric Blake
On 11/26/2015 07:48 PM, Peter Xu wrote: > This patch is only adding the QMP/HMP interface for "dump-query" > command, but not implementing them. This command could be used to > query background dump status. Please refer to the next patch to see > how dump status are defined. > > Currently, only

Re: [Qemu-devel] [PATCH v2 1/2] qmp: add support for system_suspend

2015-11-30 Thread Eric Blake
On 11/27/2015 08:01 PM, Chen Hanxiao wrote: > From: Chen Hanxiao > > This patch add support for system_suspend qmp command. > > Signed-off-by: Chen Hanxiao > --- > qapi-schema.json | 9 + > qmp-commands.hx | 21 + >

Re: [Qemu-devel] [Qemu-ppc] [PATCH 00/77] ppc: Add "native" POWER8 platform

2015-11-30 Thread Cédric Le Goater
On 11/28/2015 08:59 AM, Benjamin Herrenschmidt wrote: > On Fri, 2015-11-27 at 11:21 +0100, Alexander Graf wrote: >> >> How does real hardware store petitboot? If it's flash, you could pass it >> in using -pflash and thus model things even more closely and allow users >> to just take the ROM image

Re: [Qemu-devel] [PATCH v2 4/8] dump-guest-memory: add qmp event DUMP_COMPLETED

2015-11-30 Thread Eric Blake
On 11/26/2015 07:48 PM, Peter Xu wrote: > To get aligned with QMP interface, one new QMP event DUMP_COMPLETED > is added. It is used when user specified "detach" in dump, and > triggered when the dump finishes. Error message will be appended to > this event if the dump has failed. Why not emit

Re: [Qemu-devel] [PATCH v2 2/8] dump-guest-memory: add "detach" flag for QMP/HMP interfaces.

2015-11-30 Thread Eric Blake
On 11/26/2015 07:48 PM, Peter Xu wrote: > This patch only adds the interfaces, but not implements them. s/not implements/does not implement/ > "detach" parameter is made optional, to make sure that all the old > dump-guest-memory requests will still be able to work. > > Signed-off-by: Peter Xu

[Qemu-devel] [PATCH 1/7] target-i386/ops_sse.h: Use MMX_Q macro

2015-11-30 Thread Eduardo Habkost
We have a MMX_Q macro in addition to MMX_{B,W,L}. Use it. Signed-off-by: Eduardo Habkost --- target-i386/ops_sse.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/target-i386/ops_sse.h b/target-i386/ops_sse.h index 1780d1d..52ec0b0 100644 ---

[Qemu-devel] [PATCH 2/7] target-i386: Use a _q array on MMXReg too

2015-11-30 Thread Eduardo Habkost
Make MMXReg use the same field names used on XMMReg, so we can try to reuse macros and other code later. Signed-off-by: Eduardo Habkost --- target-i386/cpu.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/target-i386/cpu.h b/target-i386/cpu.h index

[Qemu-devel] [PATCH 5/7] target-i386: Define MMXReg._d field

2015-11-30 Thread Eduardo Habkost
Add a new field and reorder MMXReg fields, to make MMXReg and ZMMReg field lists look the same (except for the array sizes). Signed-off-by: Eduardo Habkost --- target-i386/cpu.h | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/target-i386/cpu.h

[Qemu-devel] [PATCH 7/7] [RFC] target-i386: Add suffixes to MMReg struct fields

2015-11-30 Thread Eduardo Habkost
This will ensure we never use the MMX_* and ZMM_* macros with the wrong struct type. Signed-off-by: Eduardo Habkost --- target-i386/cpu.h | 66 +++ 1 file changed, 33 insertions(+), 33 deletions(-) diff --git

  1   2   3   >