Re: [Qemu-devel] [PATCH 2/2] tests: Check serial output of firmware boot of some machines

On Fri, Jul 15, 2016 at 09:25:16AM +0200, Thomas Huth wrote: > On 15.07.2016 05:21, David Gibson wrote: > > On Thu, Jul 14, 2016 at 11:57:46AM +0200, Thomas Huth wrote: > >> Some of the machines that we have got a firmware image for write > >> some output to the serial console while booting up. We

Re: [Qemu-devel] [PATCH V2 1/1] linux-aio: prevent submitting more than MAX_EVENTS

On Wed, Jul 13, 2016 at 1:45 PM, Kevin Wolf wrote: > Am 13.07.2016 um 13:33 hat Roman Penyaev geschrieben: >> Just to be sure that we are on the same page: >> >> 1. We have this commit "linux-aio: Cancel BH if not needed" which >> >>a) introduces performance regression on my

Re: [Qemu-devel] [PATCH] ppc: Yet another fix for the huge page support detection mechanism

On Fri, 15 Jul 2016 10:10:25 +0200 Thomas Huth wrote: > Commit 86b50f2e1bef ("Disable huge page support if it is not available > for main RAM") already made sure that huge page support is not announced > to the guest if the normal RAM of non-NUMA configurations is not backed >

Re: [Qemu-devel] [PATCH for 2.7 resend] linux-aio: share one LinuxAioState within an AioContext

On Mon, Jul 04, 2016 at 06:33:20PM +0200, Paolo Bonzini wrote: > This has better performance because it executes fewer system calls > and does not use a bottom half per disk. > > Originally proposed by Ming Lei. > > Acked-by: Stefan Hajnoczi > Signed-off-by: Paolo Bonzini

Re: [Qemu-devel] [PATCH v3 12/14] virtio-gpu: Use migrate_add_blocker for virgl migration blocking

On Thu, 14 Jul 2016 18:22:54 +0100 "Dr. David Alan Gilbert (git)" wrote: > From: "Dr. David Alan Gilbert" > > virgl conditionally registers a vmstate as unmigratable when virgl > is enabled; instead use the migrate_add_blocker mechanism. > >

[Qemu-devel] [PATCH] net: fix incorrect access to pointer

This is not dereferencing the pointer, and instead checking only the value of the pointer. Signed-off-by: Paolo Bonzini --- net/eth.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/net/eth.c b/net/eth.c index 0be59c2..df81efb 100644 --- a/net/eth.c +++

[Qemu-devel] [PATCH] vnc-tight: fix regression with libxenstore

commit 095497ff added thread local storage for the color counting palette. Unfortunately, a VncPalette is about 7kB on a x86_64 system. This memory is reserved from the stack of every thread and it exhausted the stack space of a libxenstore thread. Fix this by allocating memory only for the VNC

Re: [Qemu-devel] [PATCH v3 12/14] virtio-gpu: Use migrate_add_blocker for virgl migration blocking

On Do, 2016-07-14 at 18:22 +0100, Dr. David Alan Gilbert (git) wrote: > From: "Dr. David Alan Gilbert" > > virgl conditionally registers a vmstate as unmigratable when virgl > is enabled; instead use the migrate_add_blocker mechanism. > > Signed-off-by: Dr. David Alan

Re: [Qemu-devel] [PATCH V2 1/1] linux-aio: prevent submitting more than MAX_EVENTS

On 15/07/2016 11:18, Roman Penyaev wrote: > Those 3 red spikes and a blue hill is what we have to focus on. The > blue hill at the right corner of the chart means that almost always the > ring buffer was observed as full, i.e. qemu_laio_completion_bh() got > a chance to reap completions not

Re: [Qemu-devel] [Qemu-block] [PATCH] aio_ctx_check: follow CODING_STYLE

On Fri, Jul 15, 2016 at 09:48:50AM +0800, Cao jin wrote: > On 07/14/2016 10:08 PM, Eric Blake wrote: > > On 07/14/2016 07:10 AM, Cao jin wrote: > > > replace tab with spaces > > > > > > Signed-off-by: Cao jin > > > --- > > > async.c | 2 +- > > > 1 file changed, 1

Re: [Qemu-devel] Regression with commit 095497ffc66b7f031

On 15/07/16 12:35, Paolo Bonzini wrote: > > > On 15/07/2016 12:12, Gerd Hoffmann wrote: >> On Fr, 2016-07-15 at 12:02 +0200, Paolo Bonzini wrote: >>> >>> On 15/07/2016 10:47, Juergen Gross wrote: Nothing scaring and no real difference between working and not working variant.

Re: [Qemu-devel] [PATCH V2 1/1] linux-aio: prevent submitting more than MAX_EVENTS

On Fri, Jul 15, 2016 at 12:17 PM, Roman Penyaev wrote: > On Fri, Jul 15, 2016 at 11:58 AM, Paolo Bonzini wrote: >> >> >> On 15/07/2016 11:18, Roman Penyaev wrote: >>> Those 3 red spikes and a blue hill is what we have to focus on. The >>>

Re: [Qemu-devel] Regression with commit 095497ffc66b7f031

On 15/07/16 09:39, Peter Lieven wrote: > Am 15.07.2016 um 08:32 schrieb Juergen Gross: >> Commit 095497ffc66b7f031ff2a17f1e50f5cb105ce588 ("vnc-enc-tight: use >> thread local storage for palette") introduced a regression with Xen: >> Since this commit qemu used as a device model is no longer

[Qemu-devel] [PATCH] exec: avoid realloc in phys_map_node_reserve

this is the first step in reducing the brk heap fragmentation created by the map->nodes memory allocation. Since the introduction of RCU the freeing of the PhysPageMaps is delayed so that sometimes several hundred are allocated at the same time. Even worse the memory for map->nodes is allocated

Re: [Qemu-devel] [PATCH] vnc-tight: fix regression with libxenstore

Am 15.07.2016 um 12:07 schrieb Gerd Hoffmann: > On Fr, 2016-07-15 at 11:45 +0200, Peter Lieven wrote: >> commit 095497ff added thread local storage for the color counting >> palette. Unfortunately, a VncPalette is about 7kB on a x86_64 system. >> This memory is reserved from the stack of every

Re: [Qemu-devel] [PATCH] aio_ctx_check: follow CODING_STYLE

On Thu, Jul 14, 2016 at 09:10:43PM +0800, Cao jin wrote: > replace tab with spaces > > Signed-off-by: Cao jin > --- > async.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Thanks, applied to my block tree: https://github.com/stefanha/qemu/commits/block

[Qemu-devel] [RFC PATCH V6 2/6] colo-base: add colo-base to define and handle packet

COLO-base used by colo-compare and filter-rewriter. this can share common data structure like:net packet, and share other functions. Signed-off-by: Zhang Chen Signed-off-by: Li Zhijian Signed-off-by: Wen Congyang

Re: [Qemu-devel] [PATCH v5 04/10] block: Support meta dirty bitmap

On 15.07.2016 14:04, Max Reitz wrote: > On 14.07.2016 22:00, John Snow wrote: >> On 06/22/2016 11:53 AM, Max Reitz wrote: >>> On 03.06.2016 06:32, Fam Zheng wrote: The added group of operations enables tracking of the changed bits in the dirty bitmap. Signed-off-by: Fam Zheng

[Qemu-devel] [PATCH] net: fix incorrect argument to iov_to_buf

Coverity reports a "suspicious sizeof" which is indeed wrong. Signed-off-by: Paolo Bonzini --- net/eth.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/net/eth.c b/net/eth.c index 95fe15c..0be59c2 100644 --- a/net/eth.c +++ b/net/eth.c @@ -418,7

Re: [Qemu-devel] Regression with commit 095497ffc66b7f031

On 15/07/16 11:03, Peter Lieven wrote: > Am 15.07.2016 um 10:47 schrieb Juergen Gross: >> On 15/07/16 09:39, Peter Lieven wrote: >>> Am 15.07.2016 um 08:32 schrieb Juergen Gross: Commit 095497ffc66b7f031ff2a17f1e50f5cb105ce588 ("vnc-enc-tight: use thread local storage for palette")

Re: [Qemu-devel] [PATCH] vnc-enc-tight: fix off-by-one bug

On Di, 2016-07-12 at 17:31 +0800, Herongguang (Stephen) wrote: > In tight_encode_indexed_rect32, buf(or src)’s size is count. In for loop, > the logic is supposed to be that i is an index into src, i should be > incremented when incrementing src. > > This is broken when src is incremented but i

Re: [Qemu-devel] Regression with commit 095497ffc66b7f031

On 15/07/2016 12:12, Gerd Hoffmann wrote: > On Fr, 2016-07-15 at 12:02 +0200, Paolo Bonzini wrote: >> >> On 15/07/2016 10:47, Juergen Gross wrote: >>> Nothing scaring and no real difference between working and not working >>> variant. >>> >>> Meanwhile I've been digging a little bit deeper and

Re: [Qemu-devel] [PATCH V2 1/1] linux-aio: prevent submitting more than MAX_EVENTS

On 15/07/2016 12:17, Roman Penyaev wrote: > On Fri, Jul 15, 2016 at 11:58 AM, Paolo Bonzini wrote: >> >> >> On 15/07/2016 11:18, Roman Penyaev wrote: >>> Those 3 red spikes and a blue hill is what we have to focus on. The >>> blue hill at the right corner of the chart

Re: [Qemu-devel] [Qemu-block] [PATCH] aio_ctx_check: follow CODING_STYLE

On 07/15/2016 06:40 PM, Stefan Hajnoczi wrote: On Fri, Jul 15, 2016 at 09:48:50AM +0800, Cao jin wrote: On 07/14/2016 10:08 PM, Eric Blake wrote: On 07/14/2016 07:10 AM, Cao jin wrote: replace tab with spaces Signed-off-by: Cao jin --- async.c | 2 +- 1 file

[Qemu-devel] [RFC PATCH V6 5/6] colo-compare: introduce packet comparison thread

If primary packet is same with secondary packet, we will send primary packet and drop secondary packet, otherwise notify COLO frame to do checkpoint. If primary packet comes and secondary packet not, after REGULAR_PACKET_CHECK_MS milliseconds we set the primary packet as old_packet,then do a

[Qemu-devel] [PATCH] e1000e: fix incorrect access to pointer

This is not dereferencing the pointer, and instead checking only the value of the pointer. Signed-off-by: Paolo Bonzini --- hw/net/e1000e_core.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/hw/net/e1000e_core.c b/hw/net/e1000e_core.c index

Re: [Qemu-devel] [PATCH 1/1] spapr: Ensure CPU cores are added contiguously and removed in LIFO order

On Fri, 15 Jul 2016 15:29:01 +1000 David Gibson wrote: > On Thu, Jul 14, 2016 at 10:27:15AM +0200, Igor Mammedov wrote: > > On Thu, 14 Jul 2016 10:51:27 +1000 > > David Gibson wrote: > > > > > On Wed, Jul 13, 2016 at 12:20:20PM +0530,

[Qemu-devel] [PATCH] checkpatch: consider git extended headers valid patches

Renames look like this with git-diff(1) when diff.renames = true is set: diff --git a/a b/b similarity index 100% rename from a rename to b This raises the "Does not appear to be a unified-diff format patch" error because checkpatch.pl only considers a diff valid if it contains at least

Re: [Qemu-devel] [PATCH 7/8] pc: acpi: memhp: nvdimm hotplug support

On Fri, Jul 15, 2016 at 03:49:12PM +0800, Xiao Guangrong wrote: > > > On 07/14/2016 08:17 PM, Stefan Hajnoczi wrote: > > On Mon, Jul 11, 2016 at 09:45:17PM +0800, Xiao Guangrong wrote: > > > diff --git a/hw/acpi/memory_hotplug.c b/hw/acpi/memory_hotplug.c > > > index 73fa62d..d1c2e92 100644 > >

Re: [Qemu-devel] [PATCH v3 13/14] virtio-gpu: Wrap in vmstate

On Do, 2016-07-14 at 18:22 +0100, Dr. David Alan Gilbert (git) wrote: > From: "Dr. David Alan Gilbert" > > Forcibly convert it to a vmstate wrapper; proper conversion > comes later. > > Signed-off-by: Dr. David Alan Gilbert > Reviewed-by: Cornelia

Re: [Qemu-devel] [PATCH v3 11/14] virtio-input: Wrap in vmstate

On Do, 2016-07-14 at 18:22 +0100, Dr. David Alan Gilbert (git) wrote: > From: "Dr. David Alan Gilbert" > > Forcibly convert it to a vmstate wrapper; proper conversion > comes later. > > Signed-off-by: Dr. David Alan Gilbert > Reviewed-by: Cornelia

[Qemu-devel] [PATCH v4] aio-posix: remove useless parameter

Parameter **errp of aio_context_setup() is useless, remove it and clean up the related code. Cc: Stefan Hajnoczi Cc: Fam Zheng Cc: Eric Blake Signed-off-by: Cao jin --- aio-posix.c | 3 ++- aio-win32.c

Re: [Qemu-devel] [PATCH] vnc-tight: fix regression with libxenstore

On 15/07/2016 12:10, Peter Lieven wrote: > Am 15.07.2016 um 12:07 schrieb Gerd Hoffmann: >> On Fr, 2016-07-15 at 11:45 +0200, Peter Lieven wrote: >>> commit 095497ff added thread local storage for the color counting >>> palette. Unfortunately, a VncPalette is about 7kB on a x86_64 system. >>>

[Qemu-devel] [RFC PATCH V6 1/6] colo-compare: introduce colo compare initialization

This a COLO net ascii figure: Primary qemu Secondary qemu +--+ ++ |

[Qemu-devel] [RFC PATCH V6 3/6] Jhash: add linux kernel jhashtable in qemu

Jhash used by colo-compare and filter-rewriter to save and lookup net connection info Signed-off-by: Zhang Chen Signed-off-by: Li Zhijian Signed-off-by: Wen Congyang --- include/qemu/jhash.h | 61

Re: [Qemu-devel] [PATCH] Move README to markdown

On Fri, Jul 15, 2016 at 12:31:11AM -0400, Pranith Kumar wrote: > Move the README file to markdown so that it makes the github page look > prettier. I know that github repo is a mirror and not the official > repo, but I think it doesn't hurt to have it in markdown format. > > Signed-off-by:

Re: [Qemu-devel] [SeaBIOS] [PATCH 5/5] [wip] sercon: initial split-output implementation

Hi, > I'm okay with the cut-and-paste. But, another option would be to use > the iretw at the end of the existing irqentry_extrastack to implement > the ljmpw into the main vgabios. Something like (totally untested): > > entry_10_hooked: > pushfw // Setup for

Re: [Qemu-devel] [PATCH v3 00/14] virtio migration: Flip outer layer to vmstate

On Thu, 14 Jul 2016 18:22:42 +0100 "Dr. David Alan Gilbert (git)" wrote: > From: "Dr. David Alan Gilbert" > > Hi, > This series converts the outer most layer of virtio to > use VMState macros; this is the easy bit, but I'm hoping that > having done

[Qemu-devel] [PATCH] AioContext: correct comments

Correct comments of field notify_me Cc: Kevin Wolf Cc: Max Reitz Signed-off-by: Cao jin --- include/block/aio.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/include/block/aio.h b/include/block/aio.h index

Re: [Qemu-devel] [PATCH] ppc: Yet another fix for the huge page support detection mechanism

On Fri, Jul 15, 2016 at 10:10:25AM +0200, Thomas Huth wrote: > Commit 86b50f2e1bef ("Disable huge page support if it is not available > for main RAM") already made sure that huge page support is not announced > to the guest if the normal RAM of non-NUMA configurations is not backed > by a huge

Re: [Qemu-devel] Regression with commit 095497ffc66b7f031

Am 15.07.2016 um 12:02 schrieb Paolo Bonzini: > > On 15/07/2016 10:47, Juergen Gross wrote: >> Nothing scaring and no real difference between working and not working >> variant. >> >> Meanwhile I've been digging a little bit deeper and found the reason: >> libxenstore is setting up a reader thread

Re: [Qemu-devel] [PATCH] vnc-tight: fix regression with libxenstore

On Fr, 2016-07-15 at 11:45 +0200, Peter Lieven wrote: > commit 095497ff added thread local storage for the color counting > palette. Unfortunately, a VncPalette is about 7kB on a x86_64 system. > This memory is reserved from the stack of every thread and it > exhausted the stack space of a

Re: [Qemu-devel] Regression with commit 095497ffc66b7f031

Am 15.07.2016 um 12:12 schrieb Paolo Bonzini: > > On 15/07/2016 12:07, Peter Lieven wrote: >> Am 15.07.2016 um 12:02 schrieb Paolo Bonzini: >>> On 15/07/2016 10:47, Juergen Gross wrote: Nothing scaring and no real difference between working and not working variant. Meanwhile

Re: [Qemu-devel] Regression with commit 095497ffc66b7f031

On 15/07/2016 12:07, Peter Lieven wrote: > Am 15.07.2016 um 12:02 schrieb Paolo Bonzini: >> >> On 15/07/2016 10:47, Juergen Gross wrote: >>> Nothing scaring and no real difference between working and not working >>> variant. >>> >>> Meanwhile I've been digging a little bit deeper and found the

[Qemu-devel] [PATCH] linux-user: Fix type for SIOCATMARK ioctl

The SIOCATMARK ioctl takes an argument which should be a pointer to an integer where the kernel will write the result. We were incorrectly declaring it as TYPE_NULL which would mean it would always fail (with EFAULT) when it should succeed. Correct the type. Signed-off-by: Peter Maydell

Re: [Qemu-devel] [PATCH v3 1/1] linux-aio: prevent submitting more than MAX_EVENTS

On Wed, Jul 13, 2016 at 03:03:24PM +0200, Roman Pen wrote: > Invoking io_setup(MAX_EVENTS) we ask kernel to create ring buffer for us > with specified number of events. But kernel ring buffer allocation logic > is a bit tricky (ring buffer is page size aligned + some percpu allocation > are

Re: [Qemu-devel] [PATCH v5 04/10] block: Support meta dirty bitmap

On 14.07.2016 22:00, John Snow wrote: > On 06/22/2016 11:53 AM, Max Reitz wrote: >> On 03.06.2016 06:32, Fam Zheng wrote: >>> The added group of operations enables tracking of the changed bits in >>> the dirty bitmap. >>> >>> Signed-off-by: Fam Zheng >>> --- >>>

Re: [Qemu-devel] [PATCH v6 5/6] tests: removed skipped flushes from block test traces

On 14.07.2016 19:06, Eric Blake wrote: On 07/14/2016 06:29 AM, Denis V. Lunev wrote: From: Evgeny Yakovlev bdrv_co_flush is now skipping flushes in case underlying media has no actual changes. This affected some blkdebug testcases that were expecting error logs from

[Qemu-devel] [PATCH] tap: fix memory leak on failure to create a multiqueue tap device

Reported by Coverity. Signed-off-by: Paolo Bonzini --- net/tap.c | 22 -- 1 file changed, 16 insertions(+), 6 deletions(-) diff --git a/net/tap.c b/net/tap.c index e9c32f3..6a2cedc 100644 --- a/net/tap.c +++ b/net/tap.c @@ -787,8 +787,8 @@ int

[Qemu-devel] [Bug 955379] Re: cmake hangs with qemu-arm-static

Please provide exact reproduction instructions -- I need enough information that I can completely replicate your setup and what you're doing: exactly how you've set up any chroot or whatever other guest setup you have, what cmake command you're running, and so on. -- You received this bug

Re: [Qemu-devel] [PATCH v4 05/16] pc: enforce adding CPUs contiguously and removing them in opposit order

On Thu, 14 Jul 2016 14:10:24 -0400 Bandan Das wrote: > Igor Mammedov writes: > > > it will still allow us to use cpu_index as migration instance_id > > since when CPUs are added contiguously (from the first to the last) > > and removed in opposite order,

Re: [Qemu-devel] [PATCH v2 12/13] virtio-gpu: Wrap in vmstate

Hi, > Hmm yes; I think the right fix here is to convert that into > migrate_add_blocker / migrate_del_blocker Oh, didn't notice we have that, yes that sounds good. cheers, Gerd

Re: [Qemu-devel] Regression with commit 095497ffc66b7f031

On Fr, 2016-07-15 at 12:02 +0200, Paolo Bonzini wrote: > > On 15/07/2016 10:47, Juergen Gross wrote: > > Nothing scaring and no real difference between working and not working > > variant. > > > > Meanwhile I've been digging a little bit deeper and found the reason: > > libxenstore is setting up

Re: [Qemu-devel] [PATCH V2 1/1] linux-aio: prevent submitting more than MAX_EVENTS

On Fri, Jul 15, 2016 at 11:58 AM, Paolo Bonzini wrote: > > > On 15/07/2016 11:18, Roman Penyaev wrote: >> Those 3 red spikes and a blue hill is what we have to focus on. The >> blue hill at the right corner of the chart means that almost always the >> ring buffer was

[Qemu-devel] [RFC PATCH V6 6/6] colo-compare: add TCP, UDP, ICMP packet comparison

We add TCP,UDP,ICMP packet comparison to replace IP packet comparison. This can increase the accuracy of the package comparison. less checkpoint more efficiency. Signed-off-by: Zhang Chen Signed-off-by: Li Zhijian Signed-off-by: Wen

Re: [Qemu-devel] [PATCH] ppc: Yet another fix for the huge page support detection mechanism

On 15.07.2016 10:35, David Gibson wrote: > On Fri, Jul 15, 2016 at 10:10:25AM +0200, Thomas Huth wrote: >> Commit 86b50f2e1bef ("Disable huge page support if it is not available >> for main RAM") already made sure that huge page support is not announced >> to the guest if the normal RAM of

Re: [Qemu-devel] [PATCH 3/7] hw/mips: fix PCI bus initialization

On Thu, Jul 14, 2016 at 04:43:42PM +0300, Marcel Apfelbaum wrote: > Delay the host-bridge 'realization' until the > PCI root bus is attached. > > Signed-off-by: Marcel Apfelbaum > --- > hw/mips/gt64xxx_pci.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Acked-by:

Re: [Qemu-devel] [PATCH V2 1/1] linux-aio: prevent submitting more than MAX_EVENTS

On 15/07/2016 13:35, Roman Penyaev wrote: > On Fri, Jul 15, 2016 at 12:17 PM, Roman Penyaev > wrote: >> On Fri, Jul 15, 2016 at 11:58 AM, Paolo Bonzini wrote: >>> >>> >>> On 15/07/2016 11:18, Roman Penyaev wrote: Those 3 red spikes and

[Qemu-devel] [kvm-unit-tests PATCH v3 08/10] arm/arm64: gicv2: add an IPI test

Signed-off-by: Andrew Jones --- v2: add more details in the output if a test fails, report spurious interrupts if we get them --- arm/Makefile.common | 6 +- arm/gic.c | 194 arm/unittests.cfg | 7 ++ 3

[Qemu-devel] [kvm-unit-tests PATCH v3 07/10] arm/arm64: add initial gicv3 support

Signed-off-by: Andrew Jones --- v2: configure irqs as NS GRP1 --- lib/arm/asm/arch_gicv3.h | 184 ++ lib/arm/asm/gic-v3.h | 321 + lib/arm/asm/gic.h | 1 + lib/arm/gic.c | 73

Re: [Qemu-devel] [PULL 1/1] Add optionrom compatible with fw_cfg DMA version

On Thu, Jul 14, 2016 at 2:52 PM, Paolo Bonzini wrote: > From: Marc Marí > > This optionrom is based on linuxboot.S. > > Signed-off-by: Marc Marí > Signed-off-by: Richard W.M. Jones > Message-Id:

[Qemu-devel] [PATCH Qemu] Change spice-server protocol for GL texture passing

--- ui/spice-core.c| 5 - ui/spice-display.c | 29 - 2 files changed, 8 insertions(+), 26 deletions(-) diff --git a/ui/spice-core.c b/ui/spice-core.c index da05054..f7647f7 100644 --- a/ui/spice-core.c +++ b/ui/spice-core.c @@ -828,11 +828,6 @@ void

Re: [Qemu-devel] Regression with commit 095497ffc66b7f031

On 15/07/2016 12:41, Juergen Gross wrote: > On 15/07/16 12:35, Paolo Bonzini wrote: >> >> >> On 15/07/2016 12:12, Gerd Hoffmann wrote: >>> On Fr, 2016-07-15 at 12:02 +0200, Paolo Bonzini wrote: On 15/07/2016 10:47, Juergen Gross wrote: > Nothing scaring and no real difference

[Qemu-devel] [kvm-unit-tests PATCH v3 06/10] arm/arm64: add initial gicv2 support

Add some gicv2 support. This just adds init and enable functions, allowing unit tests to start messing with it. Signed-off-by: Andrew Jones --- arm/Makefile.common| 1 + lib/arm/asm/gic-v2.h | 74 ++ lib/arm/asm/gic.h

[Qemu-devel] [kvm-unit-tests PATCH v3 00/10] arm/arm64: add gic framework

v3: - Rebased on latest master - Added Alex's r-b's v2: Rebased on latest master + my "populate argv[0]" series (will send a REPOST for that shortly. Additionally a few patches got fixes/features; 07/10 got same fix as kernel 7c9b973061 "irqchip/gic-v3: Configure all interrupts as

[Qemu-devel] [kvm-unit-tests PATCH v3 04/10] arm/arm64: add some delay routines

Allow a thread to wait some specified amount of time. Can specify in cycles, usecs, and msecs. Reviewed-by: Alex Bennée Signed-off-by: Andrew Jones --- lib/arm/asm/processor.h | 19 +++ lib/arm/processor.c | 15 +++

Re: [Qemu-devel] [PATCH v3 0/2] Report format specific info for LUKS block driver

On 14.06.2016 18:24, Daniel P. Berrange wrote: > This is a followup to: > > v1: https://lists.gnu.org/archive/html/qemu-devel/2016-06/msg01723.html > v2: https://lists.gnu.org/archive/html/qemu-devel/2016-06/msg03642.html > > The 'qemu-img info' tool has ability to print format specific >

[Qemu-devel] [PATCH v7 1/4] ide: refactor retry_unit set and clear into separate function

From: Evgeny Yakovlev Code to set and clear state associated with retry in moved into ide_set_retry and ide_clear_retry to make adding retry setups easier. Signed-off-by: Evgeny Yakovlev Signed-off-by: Denis V. Lunev

[Qemu-devel] [PATCH v7 0/4] block: ignore flush requests when storage is clean

Changes from v6: - squashed patches 5-6 into patch 4 to avoid test faults on git bissect - changed sector number from 0 to 1 in patch 3 Changes from v5: - Removed failed flush traces in block tests 026 071 089 - Changed BLOCK_JOB_READY event order in block tests 141 144 Changes from v4: - Moved

Re: [Qemu-devel] [PATCH v18 4/4] block/gluster: add support for multiple gluster servers

On Thu, Jul 14, 2016 at 5:35 PM, Markus Armbruster wrote: > Interface and error message review only. > > Prasanna Kumar Kalever writes: > >> This patch adds a way to specify multiple volfile servers to the gluster >> block backend of QEMU with

Re: [Qemu-devel] [PATCH v3 00/14] virtio migration: Flip outer layer to vmstate

On (Fri) 15 Jul 2016 [10:23:10], Cornelia Huck wrote: > On Thu, 14 Jul 2016 18:22:42 +0100 > "Dr. David Alan Gilbert (git)" wrote: > > > From: "Dr. David Alan Gilbert" > > > > Hi, > > This series converts the outer most layer of virtio to > > use

[Qemu-devel] [kvm-unit-tests PATCH v3 01/10] lib: xstr: allow multiple args

Make implementation equivalent to Linux's include/linux/stringify.h Signed-off-by: Andrew Jones --- lib/libcflat.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/lib/libcflat.h b/lib/libcflat.h index 72b1bf9668ef1..82005f5d014fb 100644 ---

[Qemu-devel] [kvm-unit-tests PATCH v3 02/10] arm64: fix get_"sysreg32" and make MPIDR 64bit

mrs is always 64bit, so we should always use a 64bit register. Sometimes we'll only want to return the lower 32, but not for MPIDR, as that does define fields in the upper 32. Reviewed-by: Alex Bennée Signed-off-by: Andrew Jones ---

[Qemu-devel] [kvm-unit-tests PATCH v3 03/10] arm/arm64: smp: support more than 8 cpus

Reviewed-by: Alex Bennée Signed-off-by: Andrew Jones --- arm/run | 19 --- arm/selftest.c| 5 - lib/arm/asm/processor.h | 9 +++-- lib/arm/asm/setup.h | 4 ++-- lib/arm/setup.c

[Qemu-devel] [kvm-unit-tests PATCH v3 05/10] arm/arm64: irq enable/disable

Reviewed-by: Alex Bennée Signed-off-by: Andrew Jones --- lib/arm/asm/processor.h | 10 ++ lib/arm64/asm/processor.h | 10 ++ 2 files changed, 20 insertions(+) diff --git a/lib/arm/asm/processor.h b/lib/arm/asm/processor.h index

[Qemu-devel] [PATCH v7 4/4] block: ignore flush requests when storage is clean

From: Evgeny Yakovlev Some guests (win2008 server for example) do a lot of unnecessary flushing when underlying media has not changed. This adds additional overhead on host when calling fsync/fdatasync. This change introduces a write generation scheme in

Re: [Qemu-devel] [PATCH Qemu] Change spice-server protocol for GL texture passing

Forgot to add RFC to the subject Frediano > > --- > ui/spice-core.c| 5 - > ui/spice-display.c | 29 - > 2 files changed, 8 insertions(+), 26 deletions(-) > > diff --git a/ui/spice-core.c b/ui/spice-core.c > index da05054..f7647f7 100644 > ---

[Qemu-devel] [PATCH 1/3] linux-user: Fix handling of iovec counts

In the kernel the length of an iovec is generally handled as an unsigned long, not an integer; fix the parameter to lock_iovec() accordingly. Signed-off-by: Peter Maydell --- linux-user/syscall.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git

[Qemu-devel] [PATCH 2/3] linux-user: Fix errno for sendrecvmsg with large iovec length

The sendmsg and recvmsg syscalls use a different errno to indicate an overlarge iovec length from readv and writev. Handle this special case in do_sendrcvmsg_locked() to avoid getting the default errno returned by lock_iovec(). Signed-off-by: Peter Maydell ---

Re: [Qemu-devel] [PATCH v3 01/11] util/qht: Document memory ordering assumptions

On 13/07/16 14:13, Paolo Bonzini wrote: > diff --git a/include/qemu/qht.h b/include/qemu/qht.h > index 70bfc68..f4f1d55 100644 > --- a/include/qemu/qht.h > +++ b/include/qemu/qht.h > @@ -69,6 +69,9 @@ void qht_destroy(struct qht *ht); > * Attempting to insert a NULL @p is a bug. > * Inserting

Re: [Qemu-devel] [PATCH v2] qcow2: do not allocate extra memory

On 14.07.2016 18:59, Vladimir Sementsov-Ogievskiy wrote: > There are no needs to allocate more than one cluster, as we set > avail_out for deflate to one cluster. > > Zlib docs (http://www.zlib.net/manual.html) says: > "deflate compresses as much data as possible, and stops when the input >

Re: [Qemu-devel] [PATCH v3 01/11] util/qht: Document memory ordering assumptions

On 15/07/2016 14:37, Sergey Fedorov wrote: > On 13/07/16 14:13, Paolo Bonzini wrote: >> diff --git a/include/qemu/qht.h b/include/qemu/qht.h >> index 70bfc68..f4f1d55 100644 >> --- a/include/qemu/qht.h >> +++ b/include/qemu/qht.h >> @@ -69,6 +69,9 @@ void qht_destroy(struct qht *ht); >> *

[Qemu-devel] [kvm-unit-tests PATCH v3 10/10] arm/arm64: gic: don't just use zero

Allow user to select who sends ipis and with which irq, rather than just always sending irq=0 from cpu0. Signed-off-by: Andrew Jones --- v2: actually check that the irq received was the irq sent, and (for gicv2) that the sender is the expected one. --- arm/gic.c | 80

[Qemu-devel] [kvm-unit-tests PATCH v3 09/10] arm/arm64: gicv3: add an IPI test

Signed-off-by: Andrew Jones --- v2: use IRM for gicv3 broadcast --- arm/gic.c | 157 ++ arm/unittests.cfg | 6 +++ 2 files changed, 154 insertions(+), 9 deletions(-) diff --git a/arm/gic.c b/arm/gic.c index

Re: [Qemu-devel] [Xen-devel] Regression with commit 095497ffc66b7f031

On 15/07/16 14:42, Paolo Bonzini wrote: > > > On 15/07/2016 12:41, Juergen Gross wrote: >> On 15/07/16 12:35, Paolo Bonzini wrote: >>> >>> >>> On 15/07/2016 12:12, Gerd Hoffmann wrote: On Fr, 2016-07-15 at 12:02 +0200, Paolo Bonzini wrote: > > On 15/07/2016 10:47, Juergen Gross

Re: [Qemu-devel] [PATCH v4 11/11] nbd-server: Allow node name for nbd-server-add

On 14.07.2016 23:36, Eric Blake wrote: > On 07/14/2016 07:28 AM, Kevin Wolf wrote: >> There is no reason why an NBD server couldn't be started for any node, >> even if it's not on the top level. This converts nbd-server-add to >> accept a node-name. >> >> Note that there is a semantic difference

[Qemu-devel] [PATCH v7 2/4] ide: set retry_unit for PIO and FLUSH requests

From: Evgeny Yakovlev The following sequence of tests discovered a problem in IDE emulation: 1. Send DMA write to IDE device 0 2. Send CMD_FLUSH_CACHE to same IDE device which will be failed by block layer using blkdebug script in tests/ide-test:test_retry_flush When

[Qemu-devel] [PATCH 0/3] linux-user: fix corner cases in sendrecvmsg

These patches fix some bugs in handling corner cases of sendrecvmsg; this allows us to pass the LTP 'recvmsg01' test case. thanks -- PMM Peter Maydell (3): linux-user: Fix handling of iovec counts linux-user: Fix errno for sendrecvmsg with large iovec length linux-user: Allow bad msg_name

Re: [Qemu-devel] [PATCH] qmp: add support for mixed typed input visitor

Eric Blake writes: > On 07/14/2016 08:39 AM, Daniel P. Berrange wrote: >> On Thu, Jul 14, 2016 at 08:23:18AM -0600, Eric Blake wrote: >>> On 07/14/2016 08:16 AM, Daniel P. Berrange wrote: Add a qmp_mixed_input_visitor_new() method which returns a QMP input visitor

Re: [Qemu-devel] [Qemu-block] [PATCH] AioContext: correct comments

On 15.07.2016 11:44, Cao jin wrote: > Correct comments of field notify_me > > Cc: Kevin Wolf > Cc: Max Reitz > Signed-off-by: Cao jin > --- > include/block/aio.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff

Re: [Qemu-devel] [PATCH v3 01/11] util/qht: Document memory ordering assumptions

On 15/07/16 15:51, Paolo Bonzini wrote: > > On 15/07/2016 14:37, Sergey Fedorov wrote: >> I understand why an implied wmb can be expected after the entry is >> removed: so that the caller can trash the contents of the object >> removed. However that would require double-check on lookup side to

[Qemu-devel] [PATCH v7 3/4] tests: in IDE and AHCI tests perform DMA write before flushing

From: Evgeny Yakovlev Due to changes in flush behaviour clean disks stopped generating flush_to_disk events and IDE and AHCI tests that test flush commands started to fail. This change adds additional DMA writes to affected tests before sending flush commands so that

Re: [Qemu-devel] [PATCH] linux-aio: keep processing events if MAX_EVENTS reached

On Tue, Jul 12, 2016 at 04:12:42PM +0200, Roman Penyaev wrote: > On Tue, Jun 28, 2016 at 11:42 AM, Stefan Hajnoczi wrote: > > On Mon, Jun 27, 2016 at 08:36:19PM +0200, Roman Penyaev wrote: > >> On Jun 27, 2016 6:37 PM, "Stefan Hajnoczi" wrote: > >> > > >>

Re: [Qemu-devel] [PATCH v2 0/2] trace: [*-user] Add commandline arguments to control tracing

On Wed, Jun 22, 2016 at 12:04:30PM +0200, Lluís Vilanova wrote: > Adds three commandline arguments to the main *-user programs, following what's > already available in softmmu: > > * -trace-enable > * -trace-events > * -trace-file > > > Changes in v2 > = > > * Tell user to use

[Qemu-devel] [RFC PATCH 0/4] translate: [tcg] Generic translation framework

This series proposes a generic (target-agnostic) instruction translation framework. It basically provides a generic main loop for instruction disassembly, which calls target-specific functions when necessary. This generalization makes inserting new code in the main loop easier, and helps in

[Qemu-devel] [PATCH 2/4] queue: Add macro for incremental traversal

Adds macro QTAILQ_FOREACH_CONTINUE to support incremental list traversal. Signed-off-by: Lluís Vilanova --- include/qemu/queue.h |5 + 1 file changed, 5 insertions(+) diff --git a/include/qemu/queue.h b/include/qemu/queue.h index f781aa2..c19f7ee 100644 ---

[Qemu-devel] [PATCH] test-logging: don't hard-code paths in /tmp

Since f6880b7f [qemu-log: support simple pid substitution for logs], test-logging creates files with hard-coded names in /tmp. In the best case, this prevents multiple developers from running "make check" on the same machine. In the worst case, it allows for symlink attacks, enabling an attacker

[Qemu-devel] [PATCH] compiler: never omit assertions if using a static analysis tool

Assertions help both Coverity and the clang static analyzer avoid false positives, but on the other hand both are confused when the condition is compiled as (void)(x != FOO). Always expand assertion macros when using Coverity or clang, through a new QEMU_STATIC_ANALYSIS preprocessor symbol. This

Re: [Qemu-devel] QOM: best way for parents to pass information to children? (was Re: [PATCH RFC 07/16] qom/cpu: make nr-cores, nr-threads real properties)

Am 15.07.2016 um 18:10 schrieb Eduardo Habkost: > On Fri, Jul 15, 2016 at 11:11:38AM +0200, Igor Mammedov wrote: >> On Fri, 15 Jul 2016 08:35:30 +0200 >> Andrew Jones wrote: >>> On Thu, Jul 14, 2016 at 05:07:43PM -0300, Eduardo Habkost wrote: First of all, sorry for

[Qemu-devel] [PATCH] migration: set state to post-migrate on failure

From: "Dr. David Alan Gilbert" If a migration fails/is cancelled during the postcopy stage we currently end up with the runstate as finish-migrate, where it should be post-migrate. There's a small window in precopy where I think the same thing can happen, but I've never seen

  1   2   3   >