Re: [Qemu-devel] [PATCH v7 1/7] linux-user: Fix TARGET_SIOCATMARK definition for Mips

Le 19/09/2016 à 13:44, Aleksandar Markovic a écrit : > From: Aleksandar Markovic > > This patch fixes wrong definition of TARGET_SIOCATMARK for mips, > alpha, and sh4. > > The current definition is: > > #define SIOCATMARK 0x8905 > > while the correct definition is: > > #define SIOC

Re: [Qemu-devel] [PATCH v7 5/7] linux-user: Fix certain argument alignment cases for Mips64

Le 19/09/2016 à 13:44, Aleksandar Markovic a écrit : > From: Aleksandar Markovic > > The function that is changed in this patch is supposed to indicate that > there was certain argument rearrangement related to 64-bit arguments on > 32-bit platforms. The background on such rearrangements can be

[Qemu-devel] [RFC] scripts: qmp: Introduce vcpu pinning helper script

This python script calls 'query-cpus' QMP command to retrieve vCPUs thread IDs. Thread IDs are then used by taskset to pin vCPUs to physical CPUs passed in command line. In case more vCPUs are present than the number of CPUs assigned in command line, multiple vCPUs get pinned to physical CPUs. Si

Re: [Qemu-devel] [Qemu-ppc] [PATCH v4 6/9] ppc/xics: Split ICS into ics-base and ics class

On 09/20/2016 08:29 AM, Nikunj A Dadhania wrote: > Cédric Le Goater writes: > >> On 09/20/2016 08:02 AM, Nikunj A Dadhania wrote: >>> Cédric Le Goater writes: >>> On 09/19/2016 08:29 AM, Nikunj A Dadhania wrote: > From: Benjamin Herrenschmidt > > The existing implementation rem

Re: [Qemu-devel] [PATCH v5 1/3] memory: introduce IOMMUNotifier and its caps

On Tue, Sep 20, 2016 at 04:12:05PM +1000, David Gibson wrote: > On Wed, Sep 14, 2016 at 04:25:46PM +0800, Peter Xu wrote: > > IOMMU Notifier list is used for notifying IO address mapping changes. > > Currently VFIO is the only user. > > > > However it is possible that future consumer like vhost wo

Re: [Qemu-devel] [PATCH v5 3/3] intel_iommu: allow UNMAP notifiers

On Tue, Sep 20, 2016 at 04:14:09PM +1000, David Gibson wrote: > On Wed, Sep 14, 2016 at 04:25:48PM +0800, Peter Xu wrote: > > Intel vIOMMU is still lacking of a complete IOMMU notifier mechanism. > > Before that is achieved, let's open a door for vhost DMAR support, which > > only requires cache in

Re: [Qemu-devel] [PATCH v2 2/3] target-i386: turn off CPU.l3-cache only for 2.7 and older machine types

On Mon, 19 Sep 2016 13:58:48 -0300 Eduardo Habkost wrote: > On Mon, Sep 19, 2016 at 10:32:34AM +0200, Igor Mammedov wrote: > > commit (14c985cff target-i386: present virtual L3 cache info for vcpus) > > misplaced compat property putting it in new 2.8 machine type > > which would effectively to di

Re: [Qemu-devel] [RFC 7/8] util/qht: atomically set b->hashes

On 19/09/2016 21:06, Emilio G. Cota wrote: > Let me then just point out that this comes at a small perf loss. > > Running 'taskset -c 0 tests/qht-bench -n 1 -d 10' (i.e. all lookups) 10 times, > we get: > > before the patch: > $ ./mean.pl 34.04 34.24 34.38 34.25 34.18 34.51 34.46 34.44 34.29 3

Re: [Qemu-devel] [PATCH] hmp: Improve 'info mtree' with optional parm for mapinfo

On 20/09/2016 02:51, Laszlo Ersek wrote: > Here's an example, from one of your sample outputs: you currently have > > ~ > 000c-000c3fff (prio 1, RW): alias pam-ram @pc.ram > 000c-000c3fff

Re: [Qemu-devel] [RFC 1/8] ui/vnc-enc-tight: add abort() for unexpected default

Hi On Mon, Sep 19, 2016 at 7:58 PM Alex Bennée wrote: > When enabling the sanitizer build it will complain about control > reaching a non-void function. Normally the compiler should detect that > there is only one possible exit given a static VNC_SERVER_FB_BYTES. > > As we should never get here

Re: [Qemu-devel] [RFC 2/8] tcg/optimize: move default return out of if statement

On Mon, Sep 19, 2016 at 7:56 PM Alex Bennée wrote: > This is to appease sanitizer builds which complain that: > > "error: control reaches end of non-void function" > > Signed-off-by: Alex Bennée > Reviewed-by: Marc-André Lureau > --- > tcg/optimize.c | 3 +-- > 1 file changed, 1 insertion

Re: [Qemu-devel] [RFC 3/8] new: blacklist.tsan

On Mon, Sep 19, 2016 at 8:01 PM Alex Bennée wrote: > A list of blacklists for tsan instrumentation. One hopes more can be > removed over time as tsan improves. > > The path needs to be absolute so it doesn't break when directories > change during the build: > > ./configure --with-coroutine=gthr

Re: [Qemu-devel] steps towards deprecation of old boards and devices

Peter Maydell writes: > If we're going to aim for deprecating and eventually removing > some of our unmaintained device and board models, it seems to > me that a good first step would be to come up with a definition > of what our baseline "needs to be at least this good" level is. > I'm guessing

Re: [Qemu-devel] [Qemu-ppc] [PATCH v4 6/9] ppc/xics: Split ICS into ics-base and ics class

Cédric Le Goater writes: > On 09/20/2016 08:29 AM, Nikunj A Dadhania wrote: >> Cédric Le Goater writes: >> >>> On 09/20/2016 08:02 AM, Nikunj A Dadhania wrote: Cédric Le Goater writes: > On 09/19/2016 08:29 AM, Nikunj A Dadhania wrote: >> From: Benjamin Herrenschmidt >>

Re: [Qemu-devel] [PATCH]MC146818 RTC: coordinate guest clock base to destination host after migration

On 20/09/2016 09:19, zhong...@sangfor.com.cn wrote: > qemu tracks guest time based on vector [base_rtc, last_update], in which > last_update stands for a monotonic tick which is actually uptime of the host. But last_update is not a monotonic tick, it's basically gettimeofday unless you're using

Re: [Qemu-devel] steps towards deprecation of old boards and devices

On 20/09/2016 10:08, Markus Armbruster wrote: > Peter Maydell writes: > >> If we're going to aim for deprecating and eventually removing >> some of our unmaintained device and board models, it seems to >> me that a good first step would be to come up with a definition >> of what our baseline "n

Re: [Qemu-devel] [RFC 1/8] ui/vnc-enc-tight: add abort() for unexpected default

On 20/09/2016 10:02, Marc-André Lureau wrote: > Hi > > On Mon, Sep 19, 2016 at 7:58 PM Alex Bennée > wrote: > > When enabling the sanitizer build it will complain about control > reaching a non-void function. Normally the compiler should detect that >

Re: [Qemu-devel] [RFC 5/8] qom/object: update class cache atomically

Hi On Mon, Sep 19, 2016 at 7:54 PM Alex Bennée wrote: > The idiom CPU_GET_CLASS(cpu) is fairly extensively used in various > threads and trips of ThreadSanitizer due to the fact it updates > obj->class->object_cast_cache behind the scenes. As this is just a > fast-path cache there is no need to

Re: [Qemu-devel] [PATCH]MC146818 RTC: coordinate guest clock base to destination host after migration

On 20/09/2016 10:34, zhong...@sangfor.com.cn wrote: > yes, the full options on clock is > '-rtc driftfix=slew,clock=rt,base=localtime' Good, then we should include a fixed patch that checks for clock=rt. Please remember to include the command-line options in the commit message. Thanks! Paolo

Re: [Qemu-devel] [PATCH v2 01/11] target-ppc: exceptions handling in icount mode

> From: David Gibson [mailto:da...@gibson.dropbear.id.au] > On Thu, Sep 15, 2016 at 11:09:59AM +0300, Pavel Dovgalyuk wrote: > > From: Pavel Dovgalyuk > > > > This patch fixes exception handling in PowerPC. > > Instructions generate several types of exceptions. > > When exception is generated, it

Re: [Qemu-devel] [PATCH v2 01/11] target-ppc: exceptions handling in icount mode

On Tue, 2016-09-20 at 11:42 +0300, Pavel Dovgalyuk wrote: > > > > From: David Gibson [mailto:da...@gibson.dropbear.id.au] > > On Thu, Sep 15, 2016 at 11:09:59AM +0300, Pavel Dovgalyuk wrote: > > > > > > From: Pavel Dovgalyuk > > > > > > This patch fixes exception handling in PowerPC. > > > Inst

Re: [Qemu-devel] [PATCH v2] add resolutions via command-line

On Tue, 2016-09-20 at 00:28 -0400, G 3 wrote: > + RegEntryID *entry_id; > + OSErr err; > + OSStatus os_status = noErr; > + Boolean is_done; > + void *value; > + RegPropertyValueSize property_size = -1; > + int index, res_set_count; > + char *set_str; > + > + #def

Re: [Qemu-devel] [PATCH v2] add resolutions via command-line

Also .. your patch was all HTML and email-damaged... On Tue, 2016-09-20 at 19:01 +1000, Benjamin Herrenschmidt wrote: > On Tue, 2016-09-20 at 00:28 -0400, G 3 wrote: > > > + RegEntryID *entry_id; > > + OSErr err; > > + OSStatus os_status = noErr; > > + Boolean is_done; > > + void *value

[Qemu-devel] [PATCH] build-sys: fix make install regression

From: Riku Voipio Since bd6092e Replace qmp-commands.hx by docs/qmp-commands.txt make install fails if building out of source-tree. Cc: Marc-André Lureau Cc: Markus Armbruster Signed-off-by: Riku Voipio --- Makefile | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Makefile

Re: [Qemu-devel] [PATCH v3] fsdev: add IO throttle support to fsdev devices

Hi Alberto, Thanks for having look at the patch. My replies are inline. On Fri 16 Sep 2016 10:33:36 AM CEST, Pradeep Jagadeesh wrote: Hi, first of all, sorry for the late reply! Here are my comments: No problem! --- a/fsdev/qemu-fsdev-opts.c +++ b/fsdev/qemu-fsdev-opts.c @@ -37,6 +37,82 @@

Re: [Qemu-devel] [Qemu-ppc] [PATCH v4 6/9] ppc/xics: Split ICS into ics-base and ics class

On 09/20/2016 10:10 AM, Nikunj A Dadhania wrote: > Cédric Le Goater writes: > >> On 09/20/2016 08:29 AM, Nikunj A Dadhania wrote: >>> Cédric Le Goater writes: >>> On 09/20/2016 08:02 AM, Nikunj A Dadhania wrote: > Cédric Le Goater writes: > >> On 09/19/2016 08:29 AM, Nikunj A D

Re: [Qemu-devel] [PATCH] build-sys: fix make install regression

Hi - Original Message - > From: Riku Voipio > > Since bd6092e Replace qmp-commands.hx by docs/qmp-commands.txt > make install fails if building out of source-tree. > > Cc: Marc-André Lureau > Cc: Markus Armbruster > Signed-off-by: Riku Voipio Reviewed-by: Marc-André Lureau > --- >

[Qemu-devel] [Bug 1624896] Re: [PPC] SegFault due to Stack Overflow in E500

Do you know what the DECAR SPR contains at that point in time? I guess it's 0 ... but what does that mean here? Should the decrementer be stopped? -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1624896

Re: [Qemu-devel] [PATCH v3 00/10] virtio: avoid exit() when device enters invalid states

On Mon, 19 Sep 2016 21:27:45 +0200 Laszlo Ersek wrote: > On 09/19/16 19:51, Michael S. Tsirkin wrote: > > On Mon, Sep 19, 2016 at 06:07:40PM +0200, Cornelia Huck wrote: > >> On Tue, 12 Apr 2016 14:25:24 +0100 > >> Stefan Hajnoczi wrote: > >> > >>> v3: > >>> * Patch 1: Fix typo and clarify c

Re: [Qemu-devel] [Bug 1625295] Re: qemu-arm dies with libarmmem inside ld.so.preload

On 20 September 2016 at 00:02, Stu wrote: > - I'm on Ubuntu 16.04, and it looks like it's 2.6.1 > > qemu-arm version 2.6.1 (Debian 1:2.6.1+dfsg-0~16.04), Copyright (c) > 2003-2008 Fabrice Bellard > > Is there a PPA for qemu 2.7 somewhere ? You'd need to ask the Ubuntu folks about that. Upstream w

Re: [Qemu-devel] [PATCH 1/6] iotests: throw away test timings if args change

On Mon, Sep 19, 2016 at 02:53:36PM -0500, Eric Blake wrote: > On 09/19/2016 12:35 PM, Daniel P. Berrange wrote: > > The 'check' program records timings for each test that > > is run. These timings are only valid, however, for a > > particular format/protocol combination. So if frequently > > runnin

Re: [Qemu-devel] [Qemu-ppc] [PATCH v4 6/9] ppc/xics: Split ICS into ics-base and ics class

Cédric Le Goater writes: > On 09/20/2016 10:10 AM, Nikunj A Dadhania wrote: -static void ics_reject(ICSState *ics, int nr); -static void ics_resend(ICSState *ics, int server); -static void ics_eoi(ICSState *ics, int nr); +static void ics_reject(ICSState *ics, ui

[Qemu-devel] [PATCH 0/2] Fixes to qemu-nbd (--offset/--image-size)

The two patches basically "fix" the usage of --offset in qemu-nbd. The first patch fixes the issue that when offset is used the device size is not updated and the client may request read/write beyond the end of the file. Second patch adds new argument --image-size to hard set the size of the devi

[Qemu-devel] [PATCH 1/2] qemu-nbd: Shrink image size by specified offset

When --offset is set the apparent device size has to be adjusted accordingly. Otherwise client may request read/write beyond the file end which would fail. Signed-off-by: Tomáš Golembiovský --- qemu-nbd.c | 7 +++ 1 file changed, 7 insertions(+) diff --git a/qemu-nbd.c b/qemu-nbd.c index 99

[Qemu-devel] [PATCH 2/2] qemu-nbd: Add --image-size option

When image is part of the file it makes sense to limit the length of the image in the file. Otherwise it is assumed that the image spans to the end of the file. This assumption may lead to reads/writes outside of the image and thus lead to errors or data corruption. To limit the assumed image size

[Qemu-devel] [PATCH v10 2/2] virtio-crypto: Add conformance clauses

Add the conformance targets and clauses for virtio-crypto device. Signed-off-by: Gonglei --- conformance.tex | 30 ++ 1 file changed, 30 insertions(+) diff --git a/conformance.tex b/conformance.tex index f59e360..615fe8c 100644 --- a/conformance.tex +++ b/conformance

Re: [Qemu-devel] [RFC v2] libvirt vGPU QEMU integration

On Tue, Sep 20, 2016 at 02:05:52AM +0530, Kirti Wankhede wrote: > > Hi libvirt experts, > > Thanks for valuable input on v1 version of RFC. > > Quick brief, VFIO based mediated device framework provides a way to > virtualize their devices without SR-IOV, like NVIDIA vGPU, Intel KVMGT > and IBM's

Re: [Qemu-devel] [Qemu-ppc] [PATCH v4 6/9] ppc/xics: Split ICS into ics-base and ics class

On 09/20/2016 11:41 AM, Nikunj A Dadhania wrote: > Cédric Le Goater writes: >> On 09/20/2016 10:10 AM, Nikunj A Dadhania wrote: > -static void ics_reject(ICSState *ics, int nr); > -static void ics_resend(ICSState *ics, int server); > -static void ics_eoi(ICSState *ics, int

[Qemu-devel] [PATCH v10 0/2] virtio-crypto: virtio crypto device specification

This is the specification about a new virtio crypto device. You can get the source code from the below website: [PATCH v3 00/10] virtio-crypto: introduce framework and device emulation https://lists.gnu.org/archive/html/qemu-devel/2016-09/msg04132.html Please help to review, thanks. CC: Michae

Re: [Qemu-devel] [Bug 1625295] Re: qemu-arm dies with libarmmem inside ld.so.preload

Cheers :) May as well close this, I'll re-open it if I try 2.7 and find the same bug. Testing involves trying stock raspbian in qemu. On 20 September 2016 at 10:26, Peter Maydell wrote: > On 20 September 2016 at 00:02, Stu wrote: > > - I'm on Ubuntu 16.04, and it looks like it's 2.6.1 > > >

[Qemu-devel] [PATCH v10 1/2] virtio-crypto: Add virtio crypto device specification

The virtio crypto device is a virtual crypto device (ie. hardware crypto accelerator card). The virtio crypto device can provide five crypto services: CIPHER, MAC, HASH, AEAD, KDF, ASYM, PRIMITIVE. In this patch, CIPHER, MAC, HASH, AEAD services are introduced. Signed-off-by: Gonglei CC: Michael

Re: [Qemu-devel] [Qemu-ppc] [PATCH v4 6/9] ppc/xics: Split ICS into ics-base and ics class

Cédric Le Goater writes: > On 09/20/2016 11:41 AM, Nikunj A Dadhania wrote: >> Cédric Le Goater writes: >>> On 09/20/2016 10:10 AM, Nikunj A Dadhania wrote: >> -static void ics_reject(ICSState *ics, int nr); >> -static void ics_resend(ICSState *ics, int server); >> -stati

Re: [Qemu-devel] [PATCH] build-sys: fix make install regression

riku.voi...@linaro.org writes: > From: Riku Voipio > > Since bd6092e Replace qmp-commands.hx by docs/qmp-commands.txt > make install fails if building out of source-tree. > > Cc: Marc-André Lureau > Cc: Markus Armbruster > Signed-off-by: Riku Voipio > --- > Makefile | 2 +- > 1 file changed,

[Qemu-devel] [Bug 1615823] Re: Windows 10 reports no compatible TPM found yet device manager shows it?

So I used the Windows Media Creation tool to generate a more recent ISO which resulted in a date stamp of July-16. Using this Win10Pro image my TPM is now recognised by the TPM Administrator, I re-tested my older ISO in the same guest and this still had the problem so conclusive enough for me. St

Re: [Qemu-devel] [PULL v3 01/18] tcg: Support arbitrary size + alignment

On Tue, Sep 13, 2016 at 5:09 AM, Richard Henderson wrote: > > Previously we allowed fully unaligned operations, but not operations > that are aligned but with less alignment than the operation size. > > In addition, arm32, ia64, mips, and sparc had been omitted from the > previous overalignment pa

Re: [Qemu-devel] [PULL 0/3] x86 queue, 2016-09-19

On 19 September 2016 at 19:38, Eduardo Habkost wrote: > The following changes since commit 33e1666b4289313306371fee0740f5c85517e406: > > Merge remote-tracking branch 'remotes/armbru/tags/pull-qapi-2016-09-19' > into staging (2016-09-19 18:06:52 +0100) > > are available in the git repository at:

[Qemu-devel] [Bug 1625295] Re: qemu-arm dies with libarmmem inside ld.so.preload

As I say, for providing reproduction instructions you have to assume I know nothing about raspbian, so "trying stock raspbian in qemu" is not detailed enough. I was looking for details more like "download this particular image from this website and then run this specific QEMU commandline, and then

Re: [Qemu-devel] [PATCH v2 2/3] target-i386: turn off CPU.l3-cache only for 2.7 and older machine types

On Tue, Sep 20, 2016 at 09:37:36AM +0200, Igor Mammedov wrote: > On Mon, 19 Sep 2016 13:58:48 -0300 > Eduardo Habkost wrote: > > > On Mon, Sep 19, 2016 at 10:32:34AM +0200, Igor Mammedov wrote: > > > commit (14c985cff target-i386: present virtual L3 cache info for vcpus) > > > misplaced compat pr

Re: [Qemu-devel] [PATCH] build-sys: fix make install regression

On 20 September 2016 at 11:05, Markus Armbruster wrote: > riku.voi...@linaro.org writes: > >> From: Riku Voipio >> >> Since bd6092e Replace qmp-commands.hx by docs/qmp-commands.txt >> make install fails if building out of source-tree. >> >> Cc: Marc-André Lureau >> Cc: Markus Armbruster >> Sign

Re: [Qemu-devel] steps towards deprecation of old boards and devices

Paolo Bonzini writes: > On 20/09/2016 10:08, Markus Armbruster wrote: >> Peter Maydell writes: >> >>> If we're going to aim for deprecating and eventually removing >>> some of our unmaintained device and board models, it seems to >>> me that a good first step would be to come up with a definiti

Re: [Qemu-devel] [PATCH v2 04/10] block: Accept device model name for blockdev-open/close-tray

Am 19.09.2016 um 21:28 hat Eric Blake geschrieben: > On 09/19/2016 11:54 AM, Kevin Wolf wrote: > > In order to remove the necessity to use BlockBackend names in the > > external API, we want to allow qdev device names in all device related > > commands. > > > > This converts blockdev-open/close-tr

[Qemu-devel] [PATCH] docker: Handle exceptions when looking for docker command

When trying to run docker tests on a host without the docker command, we get the following Python backtrace: $ make docker-test-quick@centos6 V=1 .../qemu/tests/docker/docker.py build qemu:centos6 .../qemu/tests/docker/dockerfiles/centos6.docker Traceback (most recent call last): File

Re: [Qemu-devel] [PATCH 2/2] qemu-nbd: Add --image-size option

On 20/09/2016 11:41, Tomáš Golembiovský wrote: > When image is part of the file it makes sense to limit the length of the > image in the file. Otherwise it is assumed that the image spans to the > end of the file. This assumption may lead to reads/writes outside of the > image and thus lead to er

Re: [Qemu-devel] [PATCH 1/2] qemu-nbd: Shrink image size by specified offset

On 20/09/2016 11:37, Tomáš Golembiovský wrote: > When --offset is set the apparent device size has to be adjusted > accordingly. Otherwise client may request read/write beyond the file end > which would fail. > > Signed-off-by: Tomáš Golembiovský > --- > qemu-nbd.c | 7 +++ > 1 file change

Re: [Qemu-devel] [PATCH 0/6] firmware-qemu_fw_cfg: Fine-tuning for four function implementations

On Sun, Sep 18, 2016 at 02:48:30PM +0200, SF Markus Elfring wrote: > From: Markus Elfring > Date: Sun, 18 Sep 2016 14:43:21 +0200 > > Some update suggestions were taken into account > from static source code analysis. > > Markus Elfring (6): > Use kmalloc_array() in fw_cfg_register_dir_entries

Re: [Qemu-devel] [PATCH 2/2] qemu-nbd: Add --image-size option

On Tue, Sep 20, 2016 at 11:59:28AM +0200, Paolo Bonzini wrote: > > > On 20/09/2016 11:41, Tomáš Golembiovský wrote: > > When image is part of the file it makes sense to limit the length of the > > image in the file. Otherwise it is assumed that the image spans to the > > end of the file. This ass

Re: [Qemu-devel] [PATCH] docker: Handle exceptions when looking for docker command

On Tue, 09/20 08:05, Eduardo Habkost wrote: > When trying to run docker tests on a host without the docker > command, we get the following Python backtrace: > > $ make docker-test-quick@centos6 V=1 > .../qemu/tests/docker/docker.py build qemu:centos6 > .../qemu/tests/docker/dockerfiles/cento

Re: [Qemu-devel] [PATCH v3 01/10] virtio: fix stray tab character

On Tue, 12 Apr 2016 14:25:25 +0100 Stefan Hajnoczi wrote: > Fix a single occurrence of a tab character in a file that otherwise uses > spaces for indentation. > > Signed-off-by: Stefan Hajnoczi > Reviewed-by: Fam Zheng > --- > v3: > * Fix typo and clarify commit description [Markus] > --- >

Re: [Qemu-devel] [PATCH v3 03/10] virtio: stop virtqueue processing if device is broken

On Tue, 12 Apr 2016 14:25:27 +0100 Stefan Hajnoczi wrote: > QEMU prints an error message and exits when the device enters an invalid > state. Terminating the process is heavy-handed. The guest may still be > able to function even if there is a bug in a virtio guest driver. > > Moreover, exitin

Re: [Qemu-devel] [PATCH 2/2] qemu-nbd: Add --image-size option

On Tue, 20 Sep 2016 11:59:28 +0200 Paolo Bonzini wrote: > On 20/09/2016 11:41, Tomáš Golembiovský wrote: > > When image is part of the file it makes sense to limit the length of the > > image in the file. Otherwise it is assumed that the image spans to the > > end of the file. This assumption may

Re: [Qemu-devel] [PATCH v3 04/10] virtio: migrate vdev->broken flag

On Tue, 12 Apr 2016 14:25:28 +0100 Stefan Hajnoczi wrote: > Send a subsection if the vdev->broken flag is set. This allows live > migration of broken virtio devices. > > The subsection is only sent if vdev->broken has been set. In most cases > the flag will be clear and no subsection will be s

[Qemu-devel] [PATCH v3 00/10] block: Accept qdev IDs in device level QMP commands

In order to remove the necessity to use BlockBackend names in the external API, we already converted all block layer QMP commands on the node level to accept node names instead of BlockBackend names. This series converts the second part, device level commands, to allow qdev device names instead of

[Qemu-devel] [PATCH v3 01/10] block: Add blk_by_dev()

This finds a BlockBackend given the device model that is attached to it. Signed-off-by: Kevin Wolf Reviewed-by: Eric Blake --- block/block-backend.c | 19 +++ include/sysemu/block-backend.h | 1 + 2 files changed, 20 insertions(+) diff --git a/block/block-backend.c b/

[Qemu-devel] [PATCH v3 05/10] block: Accept device model name for x-blockdev-insert-medium

In order to remove the necessity to use BlockBackend names in the external API, we want to allow qdev device names in all device related commands. This converts x-blockdev-insert-medium to accept a qdev device name. As the command is experimental, we can still remove the 'device' option that uses

[Qemu-devel] [PATCH v3 03/10] qdev-monitor: Add blk_by_qdev_id()

This finds the BlockBackend attached to the device model identified by its qdev ID. Signed-off-by: Kevin Wolf Reviewed-by: Eric Blake --- include/sysemu/block-backend.h | 1 + qdev-monitor.c | 18 ++ 2 files changed, 19 insertions(+) diff --git a/include/sysemu

[Qemu-devel] [PATCH v3 02/10] qdev-monitor: Factor out find_device_state()

Signed-off-by: Kevin Wolf Reviewed-by: Eric Blake --- qdev-monitor.c | 16 1 file changed, 12 insertions(+), 4 deletions(-) diff --git a/qdev-monitor.c b/qdev-monitor.c index e19617f..bc0213f 100644 --- a/qdev-monitor.c +++ b/qdev-monitor.c @@ -801,7 +801,7 @@ void qmp_device_a

[Qemu-devel] [PATCH v3 07/10] block: Accept device model name for eject

In order to remove the necessity to use BlockBackend names in the external API, we want to allow qdev device names in all device related commands. This converts eject to accept a qdev device name. Signed-off-by: Kevin Wolf --- blockdev.c| 10 +++--- docs/qmp-commands.txt | 8 ++

Re: [Qemu-devel] [PATCH v3 05/10] virtio: handle virtqueue_map_desc() errors

On Tue, 12 Apr 2016 14:25:29 +0100 Stefan Hajnoczi wrote: > Errors can occur during virtqueue_pop(), especially in > virtqueue_map_desc(). In order to handle this we must unmap iov[] > before returning NULL. The caller will consider the virtqueue empty and > the virtio_error() call will have ma

[Qemu-devel] [PATCH v3 06/10] block: Accept device model name for x-blockdev-remove-medium

In order to remove the necessity to use BlockBackend names in the external API, we want to allow qdev device names in all device related commands. This converts x-blockdev-remove-medium to accept a qdev device name. As the command is experimental, we can still remove the 'device' option that uses

[Qemu-devel] [PATCH v3 04/10] block: Accept device model name for blockdev-open/close-tray

In order to remove the necessity to use BlockBackend names in the external API, we want to allow qdev device names in all device related commands. This converts blockdev-open/close-tray to accept a qdev device name. Signed-off-by: Kevin Wolf --- blockdev.c| 61 ++

[Qemu-devel] [PATCH v3 10/10] qemu-iotests/118: Test media change with qdev name

We just added the option to use qdev device names in all device related block QMP commands. This patch converts some of the test cases in 118 to use qdev device names instead of BlockBackend names to cover the new way. It converts cases for each of the media change commands, but only for CD-ROM and

Re: [Qemu-devel] steps towards deprecation of old boards and devices

On 20/09/2016 13:04, Markus Armbruster wrote: > I'm not proposing to get rid of -serial. I'm proposing to use it as > indicator of old code in need of modernization. A properly QOMified > serial device should be "configurable with non-legacy means". Devices > that aren't are probably not QOMif

[Qemu-devel] [PATCH v3 09/10] block: Accept device model name for block_set_io_throttle

In order to remove the necessity to use BlockBackend names in the external API, we want to allow qdev device names in all device related commands. This converts block_set_io_throttle to accept a qdev device name. Signed-off-by: Kevin Wolf --- blockdev.c| 12 +++- docs/qmp-co

[Qemu-devel] [PATCH v3 08/10] block: Accept device model name for blockdev-change-medium

In order to remove the necessity to use BlockBackend names in the external API, we want to allow qdev device names in all device related commands. This converts blockdev-change-medium to accept a qdev device name. Signed-off-by: Kevin Wolf --- blockdev.c| 18 +++--- docs

Re: [Qemu-devel] [PATCH v3 07/10] virtio: use unsigned int for virtqueue_get_avail_bytes() index

On Tue, 12 Apr 2016 14:25:31 +0100 Stefan Hajnoczi wrote: > The virtio code uses int, unsigned int, and uint16_t for virtqueue > indices. The uint16_t is used for the low-level descriptor layout in > virtio_ring.h while code that isn't concerned with descriptor layout can > use unsigned int. >

Re: [Qemu-devel] [PATCH v5 1/3] target-ppc: add TLB_NEED_LOCAL_FLUSH flag

On Mon, Sep 19, 2016 at 11:52:10AM +0530, Nikunj A Dadhania wrote: > Introduces bit-flag in CPUPPCState::tlb_need_flush: > > TLB_NEED_LOCAL_FLUSH (0x1) - Flush local tlb > > This would indicate a pending local tlb flush (isync instructions, > interrupts, ...) > > Signed-off-by: Nikunj A Dadhan

Re: [Qemu-devel] steps towards deprecation of old boards and devices

Am 20.09.2016 um 10:08 schrieb Markus Armbruster: > Peter Maydell writes: > >> If we're going to aim for deprecating and eventually removing >> some of our unmaintained device and board models, it seems to >> me that a good first step would be to come up with a definition >> of what our baseline

Re: [Qemu-devel] [PATCH 2/2] qemu-nbd: Add --image-size option

On 20/09/2016 13:12, Daniel P. Berrange wrote: > On Tue, Sep 20, 2016 at 11:59:28AM +0200, Paolo Bonzini wrote: >> >> >> On 20/09/2016 11:41, Tomáš Golembiovský wrote: >>> When image is part of the file it makes sense to limit the length of the >>> image in the file. Otherwise it is assumed that

Re: [Qemu-devel] [PATCH v5 2/3] target-ppc: add flag in chech_tlb_flush()

On Mon, Sep 19, 2016 at 11:52:11AM +0530, Nikunj A Dadhania wrote: > We flush the qemu TLB lazily. check_tlb_flush is called whenever we hit > a context synchronizing event or instruction that requires a pending > flush to be performed. > > However, we fail to handle broadcast TLB flush operations

Re: [Qemu-devel] [PATCH v3 09/10] virtio: handle virtqueue_num_heads() errors

On Tue, 12 Apr 2016 14:25:33 +0100 Stefan Hajnoczi wrote: > If the avail ring index is bogus virtqueue_num_heads() must return > -EINVAL. > > The only caller is virtqueue_get_avail_bytes(). Return saying no bytes > are available when virtqueue_num_heads() fails. > > Signed-off-by: Stefan Hajno

Re: [Qemu-devel] [PATCH v3 08/10] virtio: handle virtqueue_read_next_desc() errors

On Tue, 12 Apr 2016 14:25:32 +0100 Stefan Hajnoczi wrote: > Stop processing the vring if an avail ring index is invalid. > > Signed-off-by: Stefan Hajnoczi > --- > hw/virtio/virtio.c | 45 - > 1 file changed, 32 insertions(+), 13 deletions(-) > Rev

[Qemu-devel] KVM-PR is broken with current QEMU

Hi, when I try to run my guest in KVM-PR mode, current QEMU refuses to start: $ sudo qemu-system-ppc64 -M pseries,accel=kvm,kvm-type=PR \ -nographic -vga none -cpu POWER8 qemu: fatal: Unknown MMU model 851972 ... followed by a useless register dump. I've bisected

Re: [Qemu-devel] [PATCH v3 00/10] virtio: avoid exit() when device enters invalid states

On Tue, 20 Sep 2016 11:26:57 +0200 Greg Kurz wrote: > Stefan's series still applies on the current head, except the virtio_config.h > patch which isn't needed anymore. I went through the patches, series generally looks good to me. > > And indeed there are a bunch of places where QEMU exits: M

Re: [Qemu-devel] [PATCH v3 06/10] virtio: handle virtqueue_get_avail_bytes() errors

On Tue, 12 Apr 2016 14:25:30 +0100 Stefan Hajnoczi wrote: > If the vring is invalid, tell the caller no bytes are available and mark > the device broken. > > Signed-off-by: Stefan Hajnoczi > --- > hw/virtio/virtio.c | 17 +++-- > 1 file changed, 11 insertions(+), 6 deletions(-) >

Re: [Qemu-devel] [PULL v3 0/8] Block layer patches

On 19 September 2016 at 22:45, Max Reitz wrote: > The following changes since commit 33e1666b4289313306371fee0740f5c85517e406: > > Merge remote-tracking branch 'remotes/armbru/tags/pull-qapi-2016-09-19' > into staging (2016-09-19 18:06:52 +0100) > > are available in the git repository at: > >

Re: [Qemu-devel] [PATCH v1] spapr: Introduce sPAPRCPUCoreClass

On Mon, Sep 12, 2016 at 01:27:20PM +0530, Bharata B Rao wrote: > Each spapr cpu core type defines an instance_init routine which just > populates the CPU class name. This can be done in the class_init > commonly for all core types which simplifies the registration. > This is inspired by how PowerNV

Re: [Qemu-devel] [PATCH v5 3/3] target-ppc: tlbie/tlbivax should have global effect

On Mon, Sep 19, 2016 at 11:52:12AM +0530, Nikunj A Dadhania wrote: > tlbie (BookS) and tlbivax (BookE) plus the H_CALLs(pseries) should have > a global effect. > > Introduces TLB_NEED_GLOBAL_FLUSH flag. During lazy tlb flush, after > taking care of pending local flushes, check broadcast flush(at c

Re: [Qemu-devel] [PATCH v3 01/10] ppc/pnv: add skeleton PowerNV platform

On Thu, Sep 15, 2016 at 02:45:51PM +0200, Cédric Le Goater wrote: > From: Benjamin Herrenschmidt > > The goal is to emulate a PowerNV system at the level of the skiboot > firmware, which loads the OS and provides some runtime services. Power > Systems have a lower firmware (HostBoot) that does lo

Re: [Qemu-devel] [PATCH v3 10/10] virtio: handle virtqueue_get_head() errors

On Tue, 12 Apr 2016 14:25:34 +0100 Stefan Hajnoczi wrote: > Stop processing the vring if virtqueue_get_head() fetches an > out-of-bounds head index. > > Signed-off-by: Stefan Hajnoczi > --- > hw/virtio/virtio.c | 26 -- > 1 file changed, 16 insertions(+), 10 deletions(-

[Qemu-devel] [PATCH] s390x/kvm: Fix potential deadlock in sigp handling

FYI, unless I find a better alternative, I plan to go with this patch. --snip-- [PATCH] s390x/kvm: Fix potential deadlock in sigp handling If two VCPUs exit at the same time and target each other with a sigp, both could run into a deadlock as run_on_cpu on CPU0 will free the BQL when star

Re: [Qemu-devel] [PATCH v4 0/2] block: allow flush on devices with open tray

Am 19.09.2016 um 22:58 hat Max Reitz geschrieben: > On 19.09.2016 18:44, John Snow wrote: > > Final re-send for wording. > > > > The move to blk_flush altered the behavior of migration and flushing > > nodes that are not reachable via the guest, but are still reachable > > via QEMU and may or may

Re: [Qemu-devel] KVM-PR is broken with current QEMU

On 09/20/2016 01:44 PM, Thomas Huth wrote: > Hi, > > when I try to run my guest in KVM-PR mode, current QEMU refuses to start: > > $ sudo qemu-system-ppc64 -M pseries,accel=kvm,kvm-type=PR \ >-nographic -vga none -cpu POWER8 > qemu: fatal: Unknown MMU model 851972

[Qemu-devel] [PATCH v3 3/8] block: don't make snapshots for filters

This patch disables snapshotting for block driver filters. It is needed, because snapshots should be created in underlying disk images, not in filters itself. Signed-off-by: Pavel Dovgalyuk --- block/snapshot.c |3 +++ 1 file changed, 3 insertions(+) diff --git a/block/snapshot.c b/block/sn

[Qemu-devel] [PATCH v3 1/8] record/replay: add network support

This patch adds support of recording and replaying network packets in irount rr mode. Record and replay for network interactions is performed with the network filter. Each backend must have its own instance of the replay filter as follows: -netdev user,id=net1 -device rtl8139,netdev=net1 -object

[Qemu-devel] [PATCH v3 0/8] replay additions

This set of patches includes several fixes for replay and adds network record/replay for network devices. It also makes possible saving/restoring vmstate in replay mode. Record and replay for network interactions is performed with the network filter. Each backend must have its own instance of the

[Qemu-devel] [PATCH v3 4/8] replay: save/load initial state

This patch implements initial vmstate creation or loading at the start of record/replay. It is needed for rewinding the execution in the replay mode. v3 changes: - added rrsnapshot option Signed-off-by: Pavel Dovgalyuk --- docs/replay.txt | 12 include/sysemu/replay.h

[Qemu-devel] [PATCH v3 2/8] block: set snapshot option for block devices in blkreplay module

This patch adds overlay option for blkreplay filter. It allows creating persistent overlay file for saving and reloading VM snapshots in record/replay modes. Signed-off-by: Pavel Dovgalyuk --- block/blkreplay.c | 119 + docs/replay.txt |

[Qemu-devel] [PATCH v3 5/8] replay: move internal data to the structure

This patch moves replay static variables into the structure to allow saving and loading them with savevm/loadvm. Reviewed-by: Paolo Bonzini Signed-off-by: Pavel Dovgalyuk --- replay/replay-events.c |2 +- replay/replay-internal.c | 19 --- replay/replay-internal.h |

Re: [Qemu-devel] [PATCH v3 4/8] replay: save/load initial state

On 20/09/2016 14:31, Pavel Dovgalyuk wrote: > @@ -291,6 +292,8 @@ void replay_configure(QemuOpts *opts) > exit(1); > } > > +replay_snapshot = g_strdup(qemu_opt_get(opts, "rrsnapshot")); > + > replay_enable(fname, mode); > Should you set snapshot = 1 here if there is no

Re: [Qemu-devel] [PATCH v3 2/8] block: set snapshot option for block devices in blkreplay module

On 20/09/2016 14:31, Pavel Dovgalyuk wrote: > /* Open the image file */ > bs->file = bdrv_open_child(NULL, options, "image", > @@ -40,6 +112,43 @@ static int blkreplay_open(BlockDriverState *bs, QDict > *options, int flags, > goto fail; > } > > +opts = qemu_opts_cre

  1   2   3   4   5   >