[Qemu-devel] [PATCH 2/8] s390x/pci: assign msix io region for each pci device

2016-09-27 Thread Christian Borntraeger
From: Yi Min Zhao For efficiency we now assign one msix io region for each pci device and provide it with the pointer to the zPCI device as opaque parameter. In addition, we remove msix address space and add msix io region as a subregion to the root memory region of

[Qemu-devel] [PATCH 5/8] pc-bios/s390-ccw: enable subchannel for IPL I/O devices

2016-09-27 Thread Christian Borntraeger
From: Dong Jia Shi IPL should cause the IPL I/O device to become enabled. So when handling the IPL program, we should set the E (Enable) bit. However, virtio-ccw does not know whether it's dealing with an IPL device or not. Since trying to perform I/O on a disabled

[Qemu-devel] [PATCH 8/8] s390x/kvm: fix build against qemu_uuid

2016-09-27 Thread Christian Borntraeger
commit 9c5ce8db2e5c ("vl: Switch qemu_uuid to QemuUUID") changed most users of qemu_uuid but not all. Fix a build error on s390/kvm. Cc: Fam Zheng Signed-off-by: Christian Borntraeger --- target-s390x/kvm.c | 2 +- 1 file changed, 1 insertion(+), 1

[Qemu-devel] [PATCH v3 2/2] vmstateify tsc210x

2016-09-27 Thread Dr. David Alan Gilbert (git)
From: "Dr. David Alan Gilbert" I'm now saving all 3 of the pll entries; only 2 were saved before. There are a couple of times that were previously stored as offsets from 'now' calculated before saving; with vmstate it's easier to store the 'now' and fix it up on reload.

Re: [Qemu-devel] [SeaBIOS] [PATCH 5/5] [wip] sercon: initial split-output implementation

2016-09-27 Thread Gerd Hoffmann
On Fr, 2016-07-15 at 10:35 -0400, Kevin O'Connor wrote: > On Fri, Jul 15, 2016 at 01:49:49PM +0200, Gerd Hoffmann wrote: > > > Finally, one high level observation is that we know there are a number > > > of quirks in various vgabios emulators. For example, we know some > > > emulators don't

[Qemu-devel] [PATCH 1/6] aspeed: rename the smc object to fmc

2016-09-27 Thread Cédric Le Goater
The Aspeed SoC has three different types of SMC (Static Memory Controller) controllers: the SMC (legacy), the FMC (the new one) and the SPI for the host PNOR. The FMC and the SPI models are now converging on the AST2500 SoC and the SMC, which was still available on the AST2400 SoC, was removed.

[Qemu-devel] [PATCH 4/6] aspeed: add support for the AST2500 SoC SMC controllers

2016-09-27 Thread Cédric Le Goater
The SMC controllers on the Aspeed AST2500 SoC are very similar to the ones found on the AST2400. The differences are on the number of supported flash modules and their default mappings in the SoC address space. The Aspeed AST2500 has one SPI controller for the BMC firmware and two for the host

Re: [Qemu-devel] [PATCH] util: secure memfd_create fallback mechanism

2016-09-27 Thread Daniel P. Berrange
On Tue, Sep 27, 2016 at 07:13:55AM -0400, Marc-André Lureau wrote: > Hi > > - Original Message - > > > > > On Sep 27, 2016, at 05:36, Daniel P. Berrange wrote: > > > > > > On Tue, Sep 27, 2016 at 03:06:21AM +, Rafael David Tinoco wrote: > > > We should not have

[Qemu-devel] [PATCH v14 11/19] qapi: add integer range support for QObjectInputVisitor

2016-09-27 Thread Daniel P. Berrange
The traditional CLI arg syntax allows two ways to specify integer lists, either one value per key, or a range of values per key. eg the following are identical: -arg foo=5,foo=6,foo=7 -arg foo=5-7 This extends the QObjectInputVisitor so that it is able to parse ranges and turn them into

[Qemu-devel] [PATCH v14 12/19] qapi: allow QObjectInputVisitor to be created with QemuOpts

2016-09-27 Thread Daniel P. Berrange
Instead of requiring all callers to go through the mutli-step process of turning QemuOpts into a suitable QObject for visiting, add a new constructor that encapsulates this logic. This will allow QObjectInputVisitor to be a drop-in replacement for the existing OptsVisitor with minimal code changes

[Qemu-devel] [PATCH v14 08/19] qapi: permit scalar type conversions in QObjectInputVisitor

2016-09-27 Thread Daniel P. Berrange
Currently the QObjectInputVisitor assumes that all scalar values are directly represented as the final types declared by the thing being visited. ie it assumes an 'int' is using QInt, and a 'bool' is using QBool, etc. This is good when QObjectInputVisitor is fed a QObject that came from a JSON

[Qemu-devel] [PATCH v14 09/19] qapi: permit auto-creating single element lists

2016-09-27 Thread Daniel P. Berrange
When converting QemuOpts to a QObject, there is no information about compound types available, so when visiting a list, the corresponding QObject is not guaranteed to be a QList. We therefore need to be able to auto-create a single element QList from whatever type we find. This mode should only

Re: [Qemu-devel] [PATCH v3] block: Turn on "unmap" in active commit

2016-09-27 Thread Eric Blake
On 09/27/2016 06:14 AM, Fam Zheng wrote: > We already specified BDRV_O_UNMAP when opening images in 'qemu-img > commit', but didn't turn on the "unmap" in the active commit job. This > patch fixes that so that zeroed clusters in top image can be discarded > which is desired in the virt-sparsify

Re: [Qemu-devel] [PATCH] m68k: change default system clock for m5208evb

2016-09-27 Thread Greg Ungerer
Hi Thomas, On 27/09/16 17:33, Thomas Huth wrote: On 27.09.2016 03:29, Greg Ungerer wrote: The shipping default setting for the Freescale M5208EVB board is to run the CPU at 166MHz. The current qemu emulation code for this board is defaulting to 66MHz. This results in time appearing to run way

[Qemu-devel] [PATCH v2 2/2] virtio-serial: enable virtio console emergency write feature

2016-09-27 Thread Sascha Silbe
Add support for enabling the virtio 1.0 "emergency write" (VIRTIO_CONSOLE_F_EMERG_WRITE) feature. The previous patch introduced the plumbing required for this; now we expose the virtio feature to the guest. The feature is disabled for compatibility machines to avoid exposing a new feature to

[Qemu-devel] [PULL 13/18] coroutine-sigaltstack: rename coroutine struct appropriately

2016-09-27 Thread Kevin Wolf
From: Peter Lieven The name of the sigaltstack coroutine struct was misleading. Signed-off-by: Peter Lieven Signed-off-by: Kevin Wolf --- util/coroutine-sigaltstack.c | 16 1 file changed, 8 insertions(+), 8 deletions(-) diff

[Qemu-devel] [PULL 08/18] block: Parse 'detect-zeroes' in bdrv_open_common()

2016-09-27 Thread Kevin Wolf
Amongst others, this means that you can now use the 'detect-zeroes' option for non-top-level nodes in blockdev-add, like the QAPI schema promises. Signed-off-by: Kevin Wolf Reviewed-by: Eric Blake Reviewed-by: Max Reitz --- block.c|

Re: [Qemu-devel] [PATCH] build-sys: fix find-in-path

2016-09-27 Thread Marc-André Lureau
Hi - Original Message - > Marc-André Lureau writes: > > > Fix spelling, the GNU make text functions is not called "find-string" > > but "findstring". > > > > Signed-off-by: Marc-André Lureau > > --- > > rules.mak | 2 +- > > 1

Re: [Qemu-devel] [PATCH] build-sys: fix find-in-path

2016-09-27 Thread Markus Armbruster
Marc-André Lureau writes: > Fix spelling, the GNU make text functions is not called "find-string" > but "findstring". > > Signed-off-by: Marc-André Lureau > --- > rules.mak | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > >

[Qemu-devel] [PATCH 2/3] test-coroutine: test qemu_coroutine_entered()

2016-09-27 Thread Stefan Hajnoczi
Signed-off-by: Stefan Hajnoczi --- tests/test-coroutine.c | 42 ++ 1 file changed, 42 insertions(+) diff --git a/tests/test-coroutine.c b/tests/test-coroutine.c index 6431dd6..abd97c2 100644 --- a/tests/test-coroutine.c +++

[Qemu-devel] [PATCH v14 15/19] numa: convert to use QObjectInputVisitor for -numa

2016-09-27 Thread Daniel P. Berrange
Switch away from using OptsVisitor to parse the -numa argument processing. This enables use of the modern list syntax for specifying CPUs. e.g. the old syntax -numa node,nodeid=0,cpus=0-3,cpus=8-11,mem=107 is equivalent to -numa node,nodeid=0,cpus.0=0,cpus.1=1,cpus.2=2,cpus.3=3,\

Re: [Qemu-devel] [PATCH] m68k: change default system clock for m5208evb

2016-09-27 Thread Laurent Vivier
Le 27/09/2016 à 15:22, Greg Ungerer a écrit : > Hi Laurent, > > On 27/09/16 18:11, Laurent Vivier wrote: >> Le 27/09/2016 à 09:33, Thomas Huth a écrit : >>> On 27.09.2016 03:29, Greg Ungerer wrote: The shipping default setting for the Freescale M5208EVB board is to run the CPU at

[Qemu-devel] [PULL 10/18] block: Move 'discard' option to bdrv_open_common()

2016-09-27 Thread Kevin Wolf
This enables its use for nested child nodes. The compatibility between the 'discard' and 'detect-zeroes' setting is checked in bdrv_open_common() now as the former setting isn't available before calling bdrv_open() any more. Signed-off-by: Kevin Wolf Reviewed-by: Eric Blake

[Qemu-devel] [PULL 02/18] qemu: use bdrv_flush_all for vm_stop et al

2016-09-27 Thread Kevin Wolf
From: John Snow Reimplement bdrv_flush_all for vm_stop. In contrast to blk_flush_all, bdrv_flush_all does not have device model restrictions. This allows us to flush and halt unconditionally without error. This allows us to do things like migrate when we have a device with an

[Qemu-devel] [PULL 07/18] block/qapi: Move 'aio' option to file driver

2016-09-27 Thread Kevin Wolf
The option whether or not to use a native AIO interface really isn't a generic option for all drivers, but only applies to the native file protocols. This patch moves the option in blockdev-add to the appropriate places (raw-posix and raw-win32). We still have to keep the flag BDRV_O_NATIVE_AIO

[Qemu-devel] [PULL 03/18] block-backend: remove blk_flush_all

2016-09-27 Thread Kevin Wolf
From: John Snow We can teach Xen to drain and flush each device as it needs to, instead of trying to flush ALL devices. This removes the last user of blk_flush_all. The function is therefore removed under the premise that any new uses of blk_flush_all would be the wrong

[Qemu-devel] [PULL 06/18] block/qapi: Use separate options type for curl driver

2016-09-27 Thread Kevin Wolf
We're going to add an option to the file drivers which doesn't apply to the curl drivers, so give them a separate option type. Signed-off-by: Kevin Wolf Reviewed-by: Eric Blake Reviewed-by: Max Reitz --- qapi/block-core.json | 25

[Qemu-devel] [PULL 12/18] oslib-posix: add helpers for stack alloc and free

2016-09-27 Thread Kevin Wolf
From: Peter Lieven the allocated stack will be adjusted to the minimum supported stack size by the OS and rounded up to be a multiple of the system pagesize. Additionally an architecture dependent guard page is added to the stack to catch stack overflows. Signed-off-by: Peter

Re: [Qemu-devel] [PATCH v5 7/9] block: don't make snapshots for filters

2016-09-27 Thread Pavel Dovgalyuk
> From: Kevin Wolf [mailto:kw...@redhat.com] > Am 26.09.2016 um 11:51 hat Pavel Dovgalyuk geschrieben: > > > From: Kevin Wolf [mailto:kw...@redhat.com] > > > Am 26.09.2016 um 10:08 hat Pavel Dovgalyuk geschrieben: > > > > This patch disables snapshotting for block driver filters. > > > > It is

[Qemu-devel] [PULL 16/18] coroutine-sigaltstack: use helper for allocating stack memory

2016-09-27 Thread Kevin Wolf
From: Peter Lieven Signed-off-by: Peter Lieven Signed-off-by: Kevin Wolf --- util/coroutine-sigaltstack.c | 9 + 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/util/coroutine-sigaltstack.c b/util/coroutine-sigaltstack.c

Re: [Qemu-devel] [PATCH 2/5] apic: add send_msi() to APICCommonClass

2016-09-27 Thread Radim Krčmář
2016-09-26 14:38+0200, Igor Mammedov: > On Thu, 22 Sep 2016 23:04:29 +0200 > Radim Krčmář wrote: > >> The MMIO based interface to APIC doesn't work well with MSIs that have >> upper address bits set (remapped x2APIC MSIs). A specialized interface >> is a quick and dirty way

Re: [Qemu-devel] [PATCH] proto: add 'shift' extension.

2016-09-27 Thread Denis V. Lunev
On 09/27/2016 03:07 PM, Paolo Bonzini wrote: > > - Original Message - >> From: "Denis V. Lunev" >> To: "Paolo Bonzini" >> Cc: "Vladimir Sementsov-Ogievskiy" , >> qemu-devel@nongnu.org, qemu-bl...@nongnu.org, >>

Re: [Qemu-devel] [PATCH 3/5] intel_iommu: pass whole remapped addresses to apic

2016-09-27 Thread Igor Mammedov
On Thu, 22 Sep 2016 23:04:30 +0200 Radim Krčmář wrote: > The MMIO interface to APIC only allowed 8 bit addresses, which is not > enough for 32 bit addresses from EIM remapping. > Intel stored upper 24 bits in the high MSI address, so use the same > technique. The technique is

[Qemu-devel] [PATCH 3/3] linux-aio: fix re-entrant completion processing

2016-09-27 Thread Stefan Hajnoczi
Commit 0ed93d84edabc7656f5c998ae1a346fe8b94ca54 ("linux-aio: process completions from ioq_submit()") added an optimization that processes completions each time ioq_submit() returns with requests in flight. This commit introduces a "Co-routine re-entered recursively" error which can be triggered

[Qemu-devel] [PATCH v14 01/19] qdict: implement a qdict_crumple method for un-flattening a dict

2016-09-27 Thread Daniel P. Berrange
The qdict_flatten() method will take a dict whose elements are further nested dicts/lists and flatten them by concatenating keys. The qdict_crumple() method aims to do the reverse, taking a flat qdict, and turning it into a set of nested dicts/lists. It will apply nesting based on the key name,

[Qemu-devel] [PATCH v14 00/19] QAPI/QOM work for non-scalar object properties

2016-09-27 Thread Daniel P. Berrange
An update of a series previously posted v1: https://lists.gnu.org/archive/html/qemu-devel/2016-02/msg04618.html v2: https://lists.gnu.org/archive/html/qemu-devel/2016-03/msg01454.html v3: https://lists.gnu.org/archive/html/qemu-devel/2016-03/msg02498.html v4:

[Qemu-devel] [PATCH v14 06/19] qapi: rename QmpOutputVisitor to QObjectOutputVisitor

2016-09-27 Thread Daniel P. Berrange
The QmpOutputVisitor has no direct dependency on QMP. It is valid to use it anywhere that one wants a QObject. Rename it to better reflect its functionality as a generic QAPI to QObject converter. Reviewed-by: Kevin Wolf Reviewed-by: Eric Blake

[Qemu-devel] [PATCH v14 10/19] qapi: permit auto-creating nested structs

2016-09-27 Thread Daniel P. Berrange
Some of the historical command line opts that had their keys in in a completely flat namespace are now represented by QAPI schemas that use a nested structs. When converting the QemuOpts to QObject, there is no information about compound types available, so the QObject will be completely flat,

[Qemu-devel] [PATCH v14 14/19] hmp: support non-scalar properties with object_add

2016-09-27 Thread Daniel P. Berrange
The current object_add HMP syntax only allows for creation of objects with scalar properties, or a list with a fixed scalar element type. Objects which have properties that are represented as structs in the QAPI schema cannot be created using -object. This is a design limitation of the way the

Re: [Qemu-devel] [PATCH v3] block: Turn on "unmap" in active commit

2016-09-27 Thread Eric Blake
On 09/27/2016 06:14 AM, Fam Zheng wrote: > We already specified BDRV_O_UNMAP when opening images in 'qemu-img > commit', but didn't turn on the "unmap" in the active commit job. This > patch fixes that so that zeroed clusters in top image can be discarded > which is desired in the virt-sparsify

Re: [Qemu-devel] [PATCH] m68k: change default system clock for m5208evb

2016-09-27 Thread Greg Ungerer
Hi Laurent, On 27/09/16 18:11, Laurent Vivier wrote: Le 27/09/2016 à 09:33, Thomas Huth a écrit : On 27.09.2016 03:29, Greg Ungerer wrote: The shipping default setting for the Freescale M5208EVB board is to run the CPU at 166MHz. The current qemu emulation code for this board is defaulting to

[Qemu-devel] [PATCH v14 19/19] qapi: delete unused OptsVisitor code

2016-09-27 Thread Daniel P. Berrange
Now that all code has been converted to QObjectInputVisitor's QemuOpts compatibility mode, there is no longer any reason to keep OptsVisitor alive. Signed-off-by: Daniel P. Berrange --- include/qapi/opts-visitor.h | 40 qapi/Makefile.objs | 2 +-

Re: [Qemu-devel] [PATCH 1/5] apic: add global apic_get_class()

2016-09-27 Thread Radim Krčmář
2016-09-23 17:17+0800, Peter Xu: > On Thu, Sep 22, 2016 at 11:04:28PM +0200, Radim Krčmář wrote: >> Every configuration has only up to one APIC class and we'll be extending >> the class with a function that can be called without an instanced >> object, so a direct access to the class is

Re: [Qemu-devel] [PATCH 3/5] intel_iommu: pass whole remapped addresses to apic

2016-09-27 Thread Radim Krčmář
2016-09-23 17:41+0800, Peter Xu: > On Thu, Sep 22, 2016 at 11:04:30PM +0200, Radim Krčmář wrote: > > [...] > >> @@ -279,18 +280,16 @@ static void vtd_update_iotlb(IntelIOMMUState *s, >> uint16_t source_id, >> static void vtd_generate_interrupt(IntelIOMMUState *s, hwaddr mesg_addr_reg, >>

[Qemu-devel] [PULL 04/18] block: Fix error path in qmp_blockdev_change_medium()

2016-09-27 Thread Kevin Wolf
Commit 00949bab incorrectly changed one instance of into errp while touching the line. Change it back. Signed-off-by: Kevin Wolf Reviewed-by: Max Reitz --- blockdev.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/blockdev.c

[Qemu-devel] [PULL 17/18] oslib-posix: add a configure switch to debug stack usage

2016-09-27 Thread Kevin Wolf
From: Peter Lieven this adds a knob to track the maximum stack usage of stacks created by qemu_alloc_stack. Signed-off-by: Peter Lieven Signed-off-by: Kevin Wolf --- configure | 19 +++ util/oslib-posix.c | 35

[Qemu-devel] [PATCH] MAINTAINERS: Add some more pattern to recognize all win32 related files

2016-09-27 Thread Thomas Huth
The get_maintainer.pl script currently thinks that the win32 related files in the util and include folders are currently unmaintained. Thus let's add some additional wildcards to match these files. Signed-off-by: Thomas Huth --- MAINTAINERS | 2 ++ 1 file changed, 2

[Qemu-devel] [PATCH 1/3] coroutine: add qemu_coroutine_entered() function

2016-09-27 Thread Stefan Hajnoczi
See the doc comments for a description of this new coroutine API. Signed-off-by: Stefan Hajnoczi --- include/qemu/coroutine.h | 13 + util/qemu-coroutine.c| 5 + 2 files changed, 18 insertions(+) diff --git a/include/qemu/coroutine.h

[Qemu-devel] [PATCH v14 13/19] qom: support non-scalar properties with -object

2016-09-27 Thread Daniel P. Berrange
The current -object command line syntax only allows for creation of objects with scalar properties, or a list with a fixed scalar element type. Objects which have properties that are represented as structs in the QAPI schema cannot be created using -object. This is a design limitation of the way

[Qemu-devel] [PATCH v14 18/19] net: convert to QObjectInputVisitor for -net/-netdev parsing

2016-09-27 Thread Daniel P. Berrange
The -net/-netdev command line parsing code uses OptsVisitor for parsing options to populate NetLegacy or NetDev struct respectively. Although those structs have nesting, the OptsVisitor flattens them, so we must enable compatibility options to auto-create structs. This allows the legacy syntax

[Qemu-devel] [PATCH v2 1/2] virtio-serial: add plumbing for virtio console emergency write support

2016-09-27 Thread Sascha Silbe
Add the infrastructure required for the virtio 1.0 "emergency write" (VIRTIO_CONSOLE_F_EMERG_WRITE) feature. Because we don't touch the size of the configuration area, guests will not be able to actually make use of this without further patches. Reviewed-by: Cornelia Huck

[Qemu-devel] [PULL 05/18] block: Drop aio/cache consistency check from qmp_blockdev_add()

2016-09-27 Thread Kevin Wolf
The TODO comment has been addressed a while ago and this is now checked in raw-posix, so we don't have to special case this in blockdev-add any more. Signed-off-by: Kevin Wolf Reviewed-by: Eric Blake Reviewed-by: Max Reitz --- blockdev.c

Re: [Qemu-devel] [PATCH v2 10/14] pc: kvm_apic: pass APIC ID depending on xAPIC/x2APIC mode

2016-09-27 Thread Igor Mammedov
On Mon, 26 Sep 2016 11:47:38 +0200 Igor Mammedov wrote: > On Thu, 22 Sep 2016 21:57:39 +0200 > Radim Krčmář wrote: > > > 2016-09-22 16:36+0200, Paolo Bonzini: > > > On 22/09/2016 14:50, Igor Mammedov wrote: > > >> +#ifdef KVM_CAP_X2APIC_API > > >>

[Qemu-devel] [PULL 09/18] block: Use 'detect-zeroes' option for 'blockdev-change-medium'

2016-09-27 Thread Kevin Wolf
Instead of modifying the new BDS after it has been opened, use the newly supported 'detect-zeroes' option in bdrv_open_common() so that all requirements are checked (detect-zeroes=unmap requires discard=unmap). Signed-off-by: Kevin Wolf Reviewed-by: Eric Blake

[Qemu-devel] [PULL 18/18] coroutine: reduce stack size to 60kB

2016-09-27 Thread Kevin Wolf
From: Peter Lieven evaluation with the recently introduced maximum stack usage monitoring revealed that the actual used stack size was never above 4kB so allocating 1MB stack for each coroutine is a lot of wasted memory. So reduce the stack size to 60kB which should still give

Re: [Qemu-devel] [PATCH 5/5] intel_iommu: do not allow EIM without KVM support

2016-09-27 Thread Radim Krčmář
2016-09-23 11:27+0200, Paolo Bonzini: > Since the whole IOMMU feature is new and somewhat experimental, I think > it's okay to just make EIM the default for >=2.8 machine types if KVM is > on (using DEFINE_PROP_ON_OFF_AUTO; auto means true if KVM is on and Sounds good. > false otherwise, and

[Qemu-devel] [PATCH v14 16/19] block: convert crypto driver to use QObjectInputVisitor

2016-09-27 Thread Daniel P. Berrange
The crypto block driver currently uses OptsVisitor to convert from the block driver open/create options into QCryptoBlockOpenOptions/QCryptoBlockCreateOptions. This is easily replaced by use of QObjectInputVisitor with no need to enable any compatibility options, since the structs dealt with

[Qemu-devel] [PULL 01/18] block: reintroduce bdrv_flush_all

2016-09-27 Thread Kevin Wolf
From: John Snow Commit fe1a9cbc moved the flush_all routine from the bdrv layer to the block-backend layer. In doing so, however, the semantics of the routine changed slightly such that flush_all now used blk_flush instead of bdrv_flush. blk_flush can fail if the attached

[Qemu-devel] [PULL 11/18] block: Remove qemu_root_bds_opts

2016-09-27 Thread Kevin Wolf
The remaining options in qemu_root_bds_opts (aio and copy-on-read) aren't used any more, the QAPI schema doesn't contain them. Therefore all the code processing qemu_root_bds_opts options is dead and can be removed. Signed-off-by: Kevin Wolf Reviewed-by: Eric Blake

Re: [Qemu-devel] [PATCH v11 0/8] Add a generic loader

2016-09-27 Thread Paolo Bonzini
It does whatever cpu_physical_memory_write_rom (and hence cpu_memory_rw_debug, which has more callers) do. > What happens when you try to monkey-patch and address that isn't > connected to anything? /dev/null > What happens when you try to monkey-patch some device's ROM? Overwritten. >

[Qemu-devel] [PATCH 0/3] linux-aio: fix "Co-routine re-entered recursively" error

2016-09-27 Thread Stefan Hajnoczi
It's possible to hit the "Co-routine re-entered recursively" error with -drive format=qcow2,aio=native. This is a regression introduced by a linux-aio.c optimization. See Patch 3 for details. Patches 1 & 2 add a new coroutine API called qemu_coroutine_entered() for checking whether a coroutine

[Qemu-devel] [PATCH] MAINTAINERS: Add some more rocker related files

2016-09-27 Thread Thomas Huth
The files in tests/rocker/ and docs/specs/rocker.txt should be listed in the Rocker section of MAINTAINERS. Signed-off-by: Thomas Huth --- MAINTAINERS | 2 ++ 1 file changed, 2 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index a5dec30..048a944 100644 ---

[Qemu-devel] [PATCH v14 04/19] qapi: add trace events for visitor

2016-09-27 Thread Daniel P. Berrange
Allow tracing of the operation of visitors Signed-off-by: Daniel P. Berrange --- Makefile.objs | 1 + qapi/qapi-visit-core.c | 27 +++ qapi/trace-events | 33 + 3 files changed, 61 insertions(+) create

[Qemu-devel] [PATCH v14 07/19] qapi: don't pass two copies of TestInputVisitorData to tests

2016-09-27 Thread Daniel P. Berrange
The input_visitor_test_add() method was accepting an instance of 'TestInputVisitorData' and passing it as the 'user_data' parameter to test functions. The main 'TestInputVisitorData' instance that was actually used, was meanwhile being allocated automatically by the test framework fixture setup.

Re: [Qemu-devel] [PATCH v11 0/8] Add a generic loader

2016-09-27 Thread Markus Armbruster
Paolo Bonzini writes: > On 23/09/2016 10:10, Markus Armbruster wrote: >> For me, the similarity (at the conceptual level) to the persistent >> memory case is striking: in both cases, we need a backend to manage >> memory contents. The difference is that for persistent

[Qemu-devel] [PATCH v14 17/19] acpi: convert to QObjectInputVisitor for -acpi parsing

2016-09-27 Thread Daniel P. Berrange
The -acpi command line option parsing uses the OptsVisitor currently. This is easily replaced by the QObjectInputVisitor instead. There is no need to enable any of the compatibility options, since the AcpiTableOptions QAPI struct only contains scalar properties. Signed-off-by: Daniel P. Berrange

[Qemu-devel] [PULL 00/18] Block layer patches

2016-09-27 Thread Kevin Wolf
The following changes since commit 7cfdc02dae0d2ff58c897496cfdbbafc0eda0f3f: Merge remote-tracking branch 'remotes/mst/tags/for_upstream' into staging (2016-09-26 19:47:00 +0100) are available in the git repository at: git://repo.or.cz/qemu/kevin.git tags/for-upstream for you to fetch

Re: [Qemu-devel] [PATCH] checkpatch.pl: disable arch-specific test for linux-user

2016-09-27 Thread Riku Voipio
On 27 September 2016 at 14:58, Paolo Bonzini wrote: > > > On 26/09/2016 21:58, riku.voi...@linaro.org wrote: >> From: Riku Voipio >> >> Linux-user and bsd-user code needs lots of arch-specific ifdefs, >> so disable the warning. >> >> Signed-off-by:

[Qemu-devel] [PULL 14/18] coroutine: add a macro for the coroutine stack size

2016-09-27 Thread Kevin Wolf
From: Peter Lieven Signed-off-by: Peter Lieven Reviewed-by: Paolo Bonzini Reviewed-by: Richard Henderson Signed-off-by: Kevin Wolf --- include/qemu/coroutine_int.h | 2 ++ util/coroutine-sigaltstack.c | 2

[Qemu-devel] [PATCH v2 0/2] virtio-serial: virtio console emergency write support

2016-09-27 Thread Sascha Silbe
This series adds support for the virtio 1.0 "emergency write" (VIRTIO_CONSOLE_F_EMERG_WRITE) virtio feature. This is useful for early guest debugging and might be used in cases where the guest crashes so badly that it cannot use virtqueues. v1→v2: - rebased on current master (resolved conflict:

[Qemu-devel] [PULL 15/18] coroutine-ucontext: use helper for allocating stack memory

2016-09-27 Thread Kevin Wolf
From: Peter Lieven Signed-off-by: Peter Lieven Signed-off-by: Kevin Wolf --- util/coroutine-ucontext.c | 11 ++- 1 file changed, 6 insertions(+), 5 deletions(-) diff --git a/util/coroutine-ucontext.c b/util/coroutine-ucontext.c index

Re: [Qemu-devel] [PATCH 0/2] Add error reporting in migration

2016-09-27 Thread John Snow
On 09/27/2016 02:56 PM, Dr. David Alan Gilbert (git) wrote: From: "Dr. David Alan Gilbert" At the moment if you use a VMSTATE_*_EQUAL macro and the value doesn't match you just get an error about the section that failed e.g. qemu-system-ppc64: error while loading

Re: [Qemu-devel] [PATCH v14 01/19] qdict: implement a qdict_crumple method for un-flattening a dict

2016-09-27 Thread Eric Blake
On 09/27/2016 08:13 AM, Daniel P. Berrange wrote: > The qdict_flatten() method will take a dict whose elements are > further nested dicts/lists and flatten them by concatenating > keys. > > The qdict_crumple() method aims to do the reverse, taking a flat > qdict, and turning it into a set of

[Qemu-devel] [PATCH 0/2] tcg: Add tcg_gen_mulsu2_*

2016-09-27 Thread Richard Henderson
While reviewing the recent riscv patch set, I made a suggestion to copy some of the bits from tcg_gen_muls2_i64 in order to implement the mulhsu instruction. However, I noticed that the same operation is present in another target, so I thought that it would be better to have this as a standard

[Qemu-devel] [PATCH 2/2] target-microblaze: Cleanup dec_mul

2016-09-27 Thread Richard Henderson
Use tcg_gen_mul_tl for muli and mul instructions. Use tcg_gen_muls2_tl for mulh instruction. Use tcg_gen_mulu2_tl for mulhu instruction. Use tcg_gen_mulsu2_tl for mulhsu instruction. Note that this last fixes a bug, in that mulhsu was previously treating both operands as signed, instead of

[Qemu-devel] [PATCH 1/2] tcg: Add tcg_gen_mulsu2_{i32,i64,tl}

2016-09-27 Thread Richard Henderson
This multiply has one signed input and one unsigned input, producing the full double-width result. Signed-off-by: Richard Henderson --- tcg/tcg-op.c | 43 +++ tcg/tcg-op.h | 4 2 files changed, 47 insertions(+) diff --git

Re: [Qemu-devel] [PATCH 5/5] intel_iommu: do not allow EIM without KVM support

2016-09-27 Thread Paolo Bonzini
- Original Message - > From: "Radim Krčmář" > To: "Paolo Bonzini" > Cc: qemu-devel@nongnu.org, "Peter Xu" , "Igor Mammedov" > , "Richard Henderson" > , "Eduardo Habkost"

Re: [Qemu-devel] [Qemu-ppc] [PATCH 2/4] libqos: add PCI management in qtest_vboot()/qtest_shutdown()

2016-09-27 Thread David Gibson
On Tue, Sep 27, 2016 at 09:33:58AM +0200, Laurent Vivier wrote: > > > On 27/09/2016 05:48, David Gibson wrote: > > On Mon, Sep 26, 2016 at 04:10:47PM +0200, Laurent Vivier wrote: > >> Signed-off-by: Laurent Vivier > >> --- > >> tests/e1000e-test.c | 2 +- > >>

[Qemu-devel] [PATCH V9 0/7] coroutine: mmap stack memory and stack size

2016-09-27 Thread Peter Lieven
I decided to split this from the rest of the Qemu RSS usage series as it contains the more or less non contentious patches. I omitted the MAP_GROWSDOWN flag in mmap as we are not 100% sure which side effects it has. I kept the guard page which is now nicely makes the stacks visible in smaps. The

[Qemu-devel] [PATCH V9 7/7] coroutine: reduce stack size to 60kB

2016-09-27 Thread Peter Lieven
evaluation with the recently introduced maximum stack usage monitoring revealed that the actual used stack size was never above 4kB so allocating 1MB stack for each coroutine is a lot of wasted memory. So reduce the stack size to 60kB which should still give enough head room. The guard page added

[Qemu-devel] [PATCH V9 4/7] coroutine-ucontext: use helper for allocating stack memory

2016-09-27 Thread Peter Lieven
Signed-off-by: Peter Lieven --- util/coroutine-ucontext.c | 11 ++- 1 file changed, 6 insertions(+), 5 deletions(-) diff --git a/util/coroutine-ucontext.c b/util/coroutine-ucontext.c index 31254ab..6621f3f 100644 --- a/util/coroutine-ucontext.c +++

[Qemu-devel] [PATCH V9 3/7] coroutine: add a macro for the coroutine stack size

2016-09-27 Thread Peter Lieven
Signed-off-by: Peter Lieven Reviewed-by: Paolo Bonzini Reviewed-by: Richard Henderson --- include/qemu/coroutine_int.h | 2 ++ util/coroutine-sigaltstack.c | 2 +- util/coroutine-ucontext.c| 2 +- util/coroutine-win32.c | 2 +- 4

Re: [Qemu-devel] Live migration without bdrv_drain_all()

2016-09-27 Thread Dr. David Alan Gilbert
* Stefan Hajnoczi (stefa...@gmail.com) wrote: > On Mon, Aug 29, 2016 at 06:56:42PM +, Felipe Franciosi wrote: > > Heya! > > > > > On 29 Aug 2016, at 08:06, Stefan Hajnoczi wrote: > > > > > > At KVM Forum an interesting idea was proposed to avoid > > > bdrv_drain_all()

[Qemu-devel] [PULL V2 08/27] colo-compare: introduce packet comparison thread

2016-09-27 Thread Jason Wang
From: Zhang Chen If primary packet is same with secondary packet, we will send primary packet and drop secondary packet, otherwise notify COLO frame to do checkpoint. If primary packet comes but secondary packet does not, after REGULAR_PACKET_CHECK_MS milliseconds

[Qemu-devel] [PULL V2 04/27] colo-compare: introduce colo compare initialization

2016-09-27 Thread Jason Wang
From: Zhang Chen This a COLO net ascii figure: Primary qemu Secondary qemu +--+

[Qemu-devel] [PULL V2 03/27] qemu-char: Add qemu_chr_add_handlers_full() for GMaincontext

2016-09-27 Thread Jason Wang
From: Zhang Chen Add qemu_chr_add_handlers_full() API, we can use this API pass in a GMainContext,make handler run in the context rather than main_loop. This comments from Daniel P . Berrange. Signed-off-by: Zhang Chen

[Qemu-devel] [PULL V2 15/27] e1000: fix buliding complaint

2016-09-27 Thread Jason Wang
From: Gonglei hw/net/e1000e_core.c:56: warning: e1000e_set_interrupt_cause declared inline after being called hw/net/e1000e_core.c:56: warning: previous declaration of e1000e_set_interrupt_cause was here Signed-off-by: Gonglei Reviewed-by:

[Qemu-devel] [PULL V2 26/27] mcf_fec: fix error in qemu_send_packet argument

2016-09-27 Thread Jason Wang
From: Paolo Bonzini This uses the wrong frame size for packets composed of multiple descriptors. Signed-off-by: Paolo Bonzini Signed-off-by: Jason Wang --- hw/net/mcf_fec.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)

Re: [Qemu-devel] [Qemu-stable] [ANNOUNCE] QEMU 2.6.1 Stable released

2016-09-27 Thread Peter Lieven
Am 27.09.2016 um 12:28 schrieb Peter Lieven: Am 16.09.2016 um 15:56 schrieb Peter Lieven: Am 13.09.2016 um 20:04 schrieb Michael Roth: Quoting Peter Lieven (2016-09-13 10:52:04) Am 13.09.2016 um 17:42 schrieb Stefan Hajnoczi: On Thu, Sep 08, 2016 at 03:58:26PM -0500,

[Qemu-devel] [PATCH 4/8] s390x/kvm: Fix potential deadlock in sigp handling

2016-09-27 Thread Christian Borntraeger
If two VCPUs exit at the same time and target each other with a sigp, both could run into a deadlock as run_on_cpu on CPU0 will free the BQL when starting the CPU1 target routine. CPU1 will run its sigp initiater for CPU0 before handling the run_on_cpu requests, thus resulting in a dead lock. As

[Qemu-devel] [PATCH 0/6] aspeed: add support for the ast2500 SMC controllers

2016-09-27 Thread Cédric Le Goater
Hello, The Aspeed AST2500 has one 'SPI' controller for the BMC firmware and two 'SPI' for the host firmware. All controllers have now the same set of registers compatible with the AST2400 'FMC' controller and the legacy 'SMC' controller is fully gone. This serie adds support for the second SPI

Re: [Qemu-devel] [Qemu-ppc] [PATCH 4/4] tests: enable ohci/uhci/xhci tests on PPC64

2016-09-27 Thread Laurent Vivier
On 27/09/2016 09:43, Laurent Vivier wrote: > > > On 27/09/2016 05:53, David Gibson wrote: >> On Mon, Sep 26, 2016 at 04:10:49PM +0200, Laurent Vivier wrote: > >>> void qusb_pci_init_one(QPCIBus *pcibus, struct qhc *hc, uint32_t devfn, >>> int bar) >>> { >>> hc->dev =

Re: [Qemu-devel] [PATCH v2] block/iscsi: Adding iser support in Libiscsi-QEMU

2016-09-27 Thread Paolo Bonzini
> On 9/27/2016 2:52 PM, Paolo Bonzini wrote: > > On 27/09/2016 13:37, Roy Shterman wrote: > > > > > +iscsi_url = iscsi_parse_full_url(iscsi, > > > > > uri_string_unescape(filename, -1, NULL)); > > > > >if (iscsi_url == NULL) { > > > > > -error_setg(errp, "Failed to parse URL :

Re: [Qemu-devel] [PATCH v2] block/iscsi: Adding iser support in Libiscsi-QEMU

2016-09-27 Thread Peter Lieven
Am 27.09.2016 um 13:37 schrieb Roy Shterman: On 9/27/2016 1:28 PM, Stefan Hajnoczi wrote: On Wed, Sep 21, 2016 at 09:19:44PM +0300, Roy Shterman wrote: iSER is a new transport layer supported in Libiscsi, iSER provides a zero-copy RDMA capable interface that can improve performance. New API

Re: [Qemu-devel] [PATCH v2] block/iscsi: Adding iser support in Libiscsi-QEMU

2016-09-27 Thread Paolo Bonzini
On 27/09/2016 13:37, Roy Shterman wrote: >>> >>> +iscsi_url = iscsi_parse_full_url(iscsi, >>> uri_string_unescape(filename, -1, NULL)); >>> if (iscsi_url == NULL) { >>> -error_setg(errp, "Failed to parse URL : %s", filename); >>> +error_setg(errp, "Failed to parse URL :

[Qemu-devel] [PATCH v3 1/2] vmstateify tsc2005

2016-09-27 Thread Dr. David Alan Gilbert (git)
From: "Dr. David Alan Gilbert" I've converted the fields in it's main data structure to fixed size types in ways that look sane. Signed-off-by: Dr. David Alan Gilbert --- Note I haven't got one of these devices to compare with or know much about them.

Re: [Qemu-devel] [PATCH] util: secure memfd_create fallback mechanism

2016-09-27 Thread Marc-André Lureau
Hi - Original Message - > On Tue, Sep 27, 2016 at 07:13:55AM -0400, Marc-André Lureau wrote: > > Hi > > > > - Original Message - > > > > > > > On Sep 27, 2016, at 05:36, Daniel P. Berrange > > > > wrote: > > > > > > > > On Tue, Sep 27, 2016 at 03:06:21AM

[Qemu-devel] [PULL V2 02/27] net: hmp_host_net_remove: Del the -net option of the removed host_net

2016-09-27 Thread Jason Wang
From: Shmulik Ladkani Upon hmp_host_net_remove(), the appropriate -net client is deleted (according to the given vlan_id and device id), as well as the corresponsing hub port. However, the relevant '-net' option that was added by former hmp_host_net_add() call is

[Qemu-devel] [PULL V2 00/27] Net patches

2016-09-27 Thread Jason Wang
The following changes since commit 7cfdc02dae0d2ff58c897496cfdbbafc0eda0f3f: Merge remote-tracking branch 'remotes/mst/tags/for_upstream' into staging (2016-09-26 19:47:00 +0100) are available in the git repository at: https://github.com/jasowang/qemu.git tags/net-pull-request for you to

Re: [Qemu-devel] [PATCH 1/3] virtio: add virtio_detach_element()

2016-09-27 Thread Stefan Hajnoczi
On Tue, Sep 27, 2016 at 09:32:40AM +0200, Ladi Prosek wrote: > On Mon, Sep 19, 2016 at 3:28 PM, Stefan Hajnoczi wrote: > > During device res> > +/* virtqueue_discard: > > + * @vq: The #VirtQueue > > + * @elem: The #VirtQueueElement > > + * @len: number of bytes written > > +

  1   2   3   4   5   >