[Qemu-devel] vfio/pci: IGD assignment

2016-10-06 Thread nicolas prochazka
Hello, Since I upgrade my linux kernel from linux 4.8rc1 to 4.8.0, I can observe regression with VFIO/PCI IGD Assignment . All works very well with linux 4.8rc1 ( broadwell/skylake cpu + win10 guest / Linux Guest ) . Since linux 4.8.0, Windows guest screen is a " blink pixel , multi color blink ,

Re: [Qemu-devel] [PATCH v2 1/5] msix_init: assert programming error

2016-10-06 Thread Cao jin
On 09/30/2016 10:06 PM, Markus Armbruster wrote: Alex Williamson writes: Once there's a need to handle a certain condition as an error, we should do that, no argument. This also provides a way to test the error path. However, I wouldn't buy an argument that

Re: [Qemu-devel] [RFC 1/4] spapr_pci: Delegate placement of PCI host bridges to machine type

2016-10-06 Thread Laurent Vivier
On 06/10/2016 05:03, David Gibson wrote: > The 'spapr-pci-host-bridge' represents the virtual PCI host bridge (PHB) > for a PAPR guest. Unlike on x86, it's routine on Power (both bare metal > and PAPR guests) to have numerous independent PHBs, each controlling a > separate PCI domain. > >

Re: [Qemu-devel] [PATCH v2 02/11] blockjob: centralize QMP event emissions

2016-10-06 Thread Kevin Wolf
Am 05.10.2016 um 20:49 hat John Snow geschrieben: > On 10/05/2016 09:43 AM, Kevin Wolf wrote: > >Am 01.10.2016 um 00:00 hat John Snow geschrieben: > >>@@ -3136,10 +3111,10 @@ void qmp_block_commit(bool has_job_id, const char > >>*job_id, const char *device, > >> goto out; > >>

Re: [Qemu-devel] [PATCH 0/3] qht fixes

2016-10-06 Thread Dr. David Alan Gilbert
* Emilio G. Cota (c...@braap.org) wrote: > Patch 1 fixes a warning that gcc may unnecessarily emit. > > Patch 2 fixes a real bug that sometimes shows up as a segfault in test-qht. > Daniel reported it yesterday on IRC; the trick to easily trigger it is to > run on RHEL6 (or CentOS6). > It is very

Re: [Qemu-devel] [PATCH] qtest: add read/write accessors with a specific endianness

2016-10-06 Thread Paolo Bonzini
On 06/10/2016 05:45, David Gibson wrote: > qtest is about testing hardware, not the guest cpu, and whether you're > accessing MMIO space or buffers the hardware will read via DMA, it's > the hardware which determines the correct endianness, not the guest > cpu. Well, sort of... qtest writes are

Re: [Qemu-devel] [PATCH] qtest: add read/write accessors with a specific endianness

2016-10-06 Thread David Gibson
On Thu, Oct 06, 2016 at 02:38:36PM +1100, David Gibson wrote: > On Wed, Oct 05, 2016 at 05:31:07AM -0700, Peter Maydell wrote: > > On 4 October 2016 at 16:43, David Gibson > > wrote: > > > On Tue, Oct 04, 2016 at 01:36:09PM +0100, Peter Maydell wrote: > > >> The

Re: [Qemu-devel] [PATCH v3 1/1] docs/generic-loader: Update the document

2016-10-06 Thread Markus Armbruster
Alistair Francis writes: > This patch does three things: > - It adds a list of restrictions and ToDos > - It corrects the header --- lines to match the length of the header > - It clarifies the force-raw option > > Signed-off-by: Alistair Francis

Re: [Qemu-devel] QEMU - Security Research Questions #2

2016-10-06 Thread Paolo Bonzini
On 06/10/2016 05:44, Joey Connelly wrote: > Hey QEMU dev group, > > I'm a graduate student at Boise State University working on my thesis > involving Virtualization/Cloud Computing Security and I wanted to ask > another IN-DEPTH question I've been trying to solve. If you have some time > it

Re: [Qemu-devel] [PATCH 16/19] target-tilegx: move cpu_exec_realize() to realize function

2016-10-06 Thread Laurent Vivier
On 06/10/2016 01:57, Chen Gang wrote: > > On 10/6/16 03:38, Laurent Vivier wrote: >> I've removed the cannot_destroy_with_object_finalize_yet field as >> cpu_exec_init() is not called by tilegx_cpu_initfn() anymore >> (not tested with QOM command as tilegx is only available in linux-user >>

Re: [Qemu-devel] [PATCH v6 00/20] Refactor trace to allow modular build

2016-10-06 Thread Daniel P. Berrange
On Wed, Oct 05, 2016 at 04:31:27PM +0100, Stefan Hajnoczi wrote: > Hmm...the SystemTap simpletrace script does not work anymore for me. But I've > tested qemu.git/master and get the same results. > > Did you test it successfully somehow? Yes, I had tested this, but lemme go back and test again

Re: [Qemu-devel] QEMU - Security Research Questions

2016-10-06 Thread Paolo Bonzini
On 06/10/2016 02:10, Joey Connelly wrote: > Hey QEMU dev group, > I'm a graduate student at Boise State University working on my thesis > involving Virtualization/Cloud Computing Security and I wanted to ask a few > questions: > > *[QUESTION#1.]* From within a guest KVM/QEMU process

Re: [Qemu-devel] [RFC 2/4] spapr: Adjust placement of PCI host bridge to allow > 1TiB RAM

2016-10-06 Thread Laurent Vivier
On 06/10/2016 05:03, David Gibson wrote: > Currently the default PCI host bridge for the 'pseries' machine type is > constructed with its IO windows in the 1TiB..(1TiB + 64GiB) range in > guest memory space. This means that if > 1TiB of guest RAM is specified, > the RAM will collide with the

Re: [Qemu-devel] QEMU - Security Research Questions

2016-10-06 Thread Markus Armbruster
Paolo Bonzini writes: > On 06/10/2016 02:10, Joey Connelly wrote: >> Hey QEMU dev group, >> I'm a graduate student at Boise State University working on my thesis >> involving Virtualization/Cloud Computing Security and I wanted to ask a few >> questions: >> >>

Re: [Qemu-devel] [RFC 1/4] spapr_pci: Delegate placement of PCI host bridges to machine type

2016-10-06 Thread David Gibson
On Thu, Oct 06, 2016 at 09:10:41AM +0200, Laurent Vivier wrote: > > > On 06/10/2016 05:03, David Gibson wrote: > > The 'spapr-pci-host-bridge' represents the virtual PCI host bridge (PHB) > > for a PAPR guest. Unlike on x86, it's routine on Power (both bare metal > > and PAPR guests) to have

Re: [Qemu-devel] [PATCH] block: Add bdrv_runtime_opts to query-command-line-options

2016-10-06 Thread Michal Privoznik
On 06.10.2016 11:40, Kevin Wolf wrote: > Recently we moved a few options from QemuOptsLists in blockdev.c to > bdrv_runtime_opts in block.c in order to make them accissble using > blockdev-add. However, this has the side effect that these options are > missing from query-command-line-options now,

Re: [Qemu-devel] [PATCH] qtest: add read/write accessors with a specific endianness

2016-10-06 Thread Cédric Le Goater
On 10/06/2016 11:40 AM, Paolo Bonzini wrote: > > > On 06/10/2016 10:37, David Gibson wrote: >> On Thu, Oct 06, 2016 at 09:23:11AM +0200, Paolo Bonzini wrote: >>> >>> >>> On 06/10/2016 05:45, David Gibson wrote: qtest is about testing hardware, not the guest cpu, and whether you're

Re: [Qemu-devel] [PATCH 01/12] virtio: add VIRTIO_DEF_DEVICE_VMSD macro

2016-10-06 Thread Halil Pasic
On 10/05/2016 05:52 PM, Paolo Bonzini wrote: > > On 05/10/2016 16:29, Dr. David Alan Gilbert wrote: >> > The virtio-input conversion especially is nice and simple. >> > The only weird case is virtio-gpu, and well virtio-gpu is the one that's >> > odd here (compared to the rest of virtio). >

Re: [Qemu-devel] Monitor brain dump

2016-10-06 Thread Paolo Bonzini
On 06/10/2016 13:10, Peter Maydell wrote: > On 6 October 2016 at 12:07, Paolo Bonzini wrote: >> My hunch is that it would be a drop in the sea if monitor.c were >> refactored properly. > > Speaking of refactoring, is there scope for splitting things > up so that if the foo

Re: [Qemu-devel] [PATCH] trace: Add missing execution mode of guest events

2016-10-06 Thread Stefan Hajnoczi
On Wed, Oct 05, 2016 at 02:03:29PM +0200, Lluís Vilanova wrote: > Add missing execution mode documentation for the 'guest_cpu_enter' and > 'guest_cpu_reset' events. > > Signed-off-by: Lluís Vilanova > --- > trace-events |2 ++ > 1 file changed, 2 insertions(+) Thanks,

Re: [Qemu-devel] [RFC 2/4] spapr: Adjust placement of PCI host bridge to allow > 1TiB RAM

2016-10-06 Thread Laurent Vivier
On 06/10/2016 05:03, David Gibson wrote: > Currently the default PCI host bridge for the 'pseries' machine type is > constructed with its IO windows in the 1TiB..(1TiB + 64GiB) range in > guest memory space. This means that if > 1TiB of guest RAM is specified, > the RAM will collide with the

Re: [Qemu-devel] [PULL 0/1] HMP queue

2016-10-06 Thread Peter Maydell
On 4 October 2016 at 18:49, Dr. David Alan Gilbert (git) wrote: > From: "Dr. David Alan Gilbert" > > The following changes since commit bbc4c3f4f3c624e2de64fdcb79f4dd8c1a508e9d: > > Merge remote-tracking branch 'remotes/kevin/tags/for-upstream' into

[Qemu-devel] [RFC v3 3/8] hw: vfio: common: Introduce vfio_register_msi_iova

2016-10-06 Thread Eric Auger
vfio_register_msi_iova allows to register the MSI IOVA region. This IOVA window will be used by the kernel to map MSI doorbells. The function will become static in subsequent patches. However, since there is no user yet, the compiler argues; the function is currently not static and a dummy

[Qemu-devel] [RFC v3 6/8] hw: platform-bus: Enable to map any memory region onto the platform-bus

2016-10-06 Thread Eric Auger
The platform bus is currently used to map dynamically instantiable platform device MMIO regions. The platform bus also can be seen as a pool of free guest physical addresses. We would like to use that pool to allocate a contiguous reserved IOVA region usable for MSI message address IOMMU mapping.

Re: [Qemu-devel] [QEMU PATCH v5 4/6] migration: migrate QTAILQ

2016-10-06 Thread Paolo Bonzini
On 05/10/2016 18:56, Dr. David Alan Gilbert wrote: > * Jianjun Duan (du...@linux.vnet.ibm.com) wrote: >> Currently we cannot directly transfer a QTAILQ instance because of the >> limitation in the migration code. Here we introduce an approach to >> transfer such structures. In our approach such

Re: [Qemu-devel] Monitor brain dump

2016-10-06 Thread Peter Maydell
On 6 October 2016 at 12:07, Paolo Bonzini wrote: > My hunch is that it would be a drop in the sea if monitor.c were > refactored properly. Speaking of refactoring, is there scope for splitting things up so that if the foo subsystem needs to implement a monitor command it can

[Qemu-devel] [PATCH] block: Add bdrv_runtime_opts to query-command-line-options

2016-10-06 Thread Kevin Wolf
Recently we moved a few options from QemuOptsLists in blockdev.c to bdrv_runtime_opts in block.c in order to make them accissble using blockdev-add. However, this has the side effect that these options are missing from query-command-line-options now, and libvirt consequently disables the

[Qemu-devel] [RFC v3 7/8] hw: vfio: common: vfio_prepare_msi_mapping

2016-10-06 Thread Eric Auger
Introduce an helper function to retrieve the iommu type1 capability chain info. The first capability ready to be exploited is the msi geometry capability. vfio_prepare_msi_mapping allocates a MemoryRegion dedicated to host MSI IOVA mapping. Its size matches the host needs. This region is mapped

Re: [Qemu-devel] [PATCH] qtest: add read/write accessors with a specific endianness

2016-10-06 Thread Peter Maydell
On 6 October 2016 at 04:45, David Gibson wrote: > On Wed, Oct 05, 2016 at 07:20:52AM -0700, Peter Maydell wrote: >> On 5 October 2016 at 07:00, Cédric Le Goater wrote: >> > On 10/05/2016 03:53 PM, Peter Maydell wrote: >> >> Which tswap? Last time I

Re: [Qemu-devel] [PATCH 0/3] qht fixes

2016-10-06 Thread Paolo Bonzini
On 06/10/2016 00:34, Emilio G. Cota wrote: > Patch 1 fixes a warning that gcc may unnecessarily emit. > > Patch 2 fixes a real bug that sometimes shows up as a segfault in test-qht. > Daniel reported it yesterday on IRC; the trick to easily trigger it is to > run on RHEL6 (or CentOS6). > It is

Re: [Qemu-devel] [PATCH] block: Add bdrv_runtime_opts to query-command-line-options

2016-10-06 Thread Kevin Wolf
Am 06.10.2016 um 12:58 hat Martin Kletzander geschrieben: > On Thu, Oct 06, 2016 at 11:40:36AM +0200, Kevin Wolf wrote: > >Recently we moved a few options from QemuOptsLists in blockdev.c to > >bdrv_runtime_opts in block.c in order to make them accissble using > >blockdev-add. However, this has

Re: [Qemu-devel] [RFC 1/4] spapr_pci: Delegate placement of PCI host bridges to machine type

2016-10-06 Thread Laurent Vivier
On 06/10/2016 05:03, David Gibson wrote: > The 'spapr-pci-host-bridge' represents the virtual PCI host bridge (PHB) > for a PAPR guest. Unlike on x86, it's routine on Power (both bare metal > and PAPR guests) to have numerous independent PHBs, each controlling a > separate PCI domain. > >

[Qemu-devel] [RFC v3 4/8] memory: Add reserved_iova region type

2016-10-06 Thread Eric Auger
Introduce a new reserved_iova region type. This type of iova region is bound to be used by the kernel to map some host physical addresses (typically MSI frames). A new initializer, memory_region_init_reserved_iova is introduced, as well as a test function, memory_region_is_reserved_iova.

[Qemu-devel] [PATCH] target-mips: Don't stop on [d]mtc0 DESAVE/KScratch

2016-10-06 Thread James Hogan
Writing to the MIPS DESAVE register (and now the KScratch registers) will stop translation, supposedly due to risk of execution mode switches. However these registers are basically RW scratch registers with no side effects so there is no risk of them triggering execution mode changes. Drop the

[Qemu-devel] [RFC v3 2/8] hw: vfio: common: vfio_get_iommu_type1_info

2016-10-06 Thread Eric Auger
Introduce vfio_get_iommu_type1_info helper that allows to handle variable size vfio_iommu_type1_info allocation with capability chain support. Besides, fixes a checkpatch warning on vfio_host_win_add's call. Signed-off-by: Eric Auger --- hw/vfio/common.c | 33

Re: [Qemu-devel] [PULL 00/15] Migration

2016-10-06 Thread Peter Maydell
On 5 October 2016 at 14:44, Juan Quintela wrote: > From: Juan Quintela > > The following changes since commit bbc4c3f4f3c624e2de64fdcb79f4dd8c1a508e9d: > > Merge remote-tracking branch 'remotes/kevin/tags/for-upstream' into staging > (2016-10-04

Re: [Qemu-devel] Monitor brain dump

2016-10-06 Thread Paolo Bonzini
On 05/10/2016 19:43, Dr. David Alan Gilbert wrote: > > Speaking of the pocket calculator: my recommendation would be "nuke from > > orbit". It adds surprising corner cases to the HMP language, and > > provides next to no value. > > Huh, didn't realise that existed - I assume you mean get_expr

Re: [Qemu-devel] Monitor brain dump

2016-10-06 Thread Marc-André Lureau
Hi On Thu, Oct 6, 2016 at 3:14 PM Paolo Bonzini wrote: > > > On 06/10/2016 13:10, Peter Maydell wrote: > > On 6 October 2016 at 12:07, Paolo Bonzini wrote: > >> My hunch is that it would be a drop in the sea if monitor.c were > >> refactored properly.

Re: [Qemu-devel] [PATCH] qtest: add read/write accessors with a specific endianness

2016-10-06 Thread David Gibson
On Thu, Oct 06, 2016 at 09:23:11AM +0200, Paolo Bonzini wrote: > > > On 06/10/2016 05:45, David Gibson wrote: > > qtest is about testing hardware, not the guest cpu, and whether you're > > accessing MMIO space or buffers the hardware will read via DMA, it's > > the hardware which determines the

Re: [Qemu-devel] [RFC 2/4] spapr: Adjust placement of PCI host bridge to allow > 1TiB RAM

2016-10-06 Thread David Gibson
On Thu, Oct 06, 2016 at 09:21:56AM +0200, Laurent Vivier wrote: > > > On 06/10/2016 05:03, David Gibson wrote: > > Currently the default PCI host bridge for the 'pseries' machine type is > > constructed with its IO windows in the 1TiB..(1TiB + 64GiB) range in > > guest memory space. This means

Re: [Qemu-devel] [PATCH 01/12] virtio: add VIRTIO_DEF_DEVICE_VMSD macro

2016-10-06 Thread Paolo Bonzini
On 05/10/2016 21:00, Dr. David Alan Gilbert wrote: > * Paolo Bonzini (pbonz...@redhat.com) wrote: >> >> >> On 05/10/2016 16:29, Dr. David Alan Gilbert wrote: >>> The virtio-input conversion especially is nice and simple. >>> The only weird case is virtio-gpu, and well virtio-gpu is the one

[Qemu-devel] [RFC v3 8/8] hw: vfio: common: Adapt vfio_listeners for reserved_iova region

2016-10-06 Thread Eric Auger
In case of reserved iova region, let's declare this region to the kernel so that it can use it for IOVA/HPA bindings. Signed-off-by: Eric Auger --- hw/vfio/common.c | 48 +--- 1 file changed, 29 insertions(+), 19 deletions(-)

Re: [Qemu-devel] [PATCH 01/19] exec: split cpu_exec_init()

2016-10-06 Thread Peter Maydell
On 6 October 2016 at 06:02, David Gibson wrote: > On Wed, Oct 05, 2016 at 01:13:18PM -0700, Peter Maydell wrote: >> I think cpu_list_add() needs to be in init, because >> this is where we set cpu->cpu_index, and (after patch 5) >> target-arm assumes that cpu_index has

Re: [Qemu-devel] [RFC v3 7/8] hw: vfio: common: vfio_prepare_msi_mapping

2016-10-06 Thread Auger Eric
Hi, On 06/10/2016 11:50, Eric Auger wrote: > Introduce an helper function to retrieve the iommu type1 capability > chain info. > > The first capability ready to be exploited is the msi geometry > capability. vfio_prepare_msi_mapping allocates a MemoryRegion > dedicated to host MSI IOVA mapping.

Re: [Qemu-devel] [PATCH] block: Add bdrv_runtime_opts to query-command-line-options

2016-10-06 Thread Martin Kletzander
On Thu, Oct 06, 2016 at 11:40:36AM +0200, Kevin Wolf wrote: Recently we moved a few options from QemuOptsLists in blockdev.c to bdrv_runtime_opts in block.c in order to make them accissble using blockdev-add. However, this has the side effect that these options are missing from

Re: [Qemu-devel] [PATCH v6 00/20] Refactor trace to allow modular build

2016-10-06 Thread Daniel P. Berrange
On Wed, Oct 05, 2016 at 04:31:27PM +0100, Stefan Hajnoczi wrote: > Hmm...the SystemTap simpletrace script does not work anymore for me. But I've > tested qemu.git/master and get the same results. > > Did you test it successfully somehow? > > $ cat x86_64-softmmu/qemu-system-x86_64.stp \ >

Re: [Qemu-devel] [PATCH] qtest: add read/write accessors with a specific endianness

2016-10-06 Thread Paolo Bonzini
On 06/10/2016 10:37, David Gibson wrote: > On Thu, Oct 06, 2016 at 09:23:11AM +0200, Paolo Bonzini wrote: >> >> >> On 06/10/2016 05:45, David Gibson wrote: >>> qtest is about testing hardware, not the guest cpu, and whether you're >>> accessing MMIO space or buffers the hardware will read via

Re: [Qemu-devel] [PATCH v3 8/8] vmxnet3: remove unnecessary internal msix state flag

2016-10-06 Thread Dmitry Fleytman
> On 30 Sep 2016, at 15:08 PM, Markus Armbruster wrote: > > Cao jin writes: > >> On 09/29/2016 10:42 PM, Markus Armbruster wrote: >>> Cao jin writes: >>> >> static int vmxnet3_post_load(void *opaque, int

[Qemu-devel] [RFC v3 1/8] linux-headers: Partial update for MSI IOVA handling

2016-10-06 Thread Eric Auger
This is a partial update aiming at enhancing the VFIO user API with IOMMU info capability chain, msi_geometry reporting and MSI IOVA window registration. The kernel code is not yet upstreamed. It is available at https://github.com/eauger/linux/tree/generic-v7-passthrough-v13 ([PATCH v13 00/15]

[Qemu-devel] [RFC v3 5/8] memory: memory_region_find_by_name

2016-10-06 Thread Eric Auger
This new helper makes possible to search for a MemoryRegion matching a given name within a root MemoryRegion. Signed-off-by: Eric Auger --- include/exec/memory.h | 11 +++ memory.c | 16 2 files changed, 27 insertions(+) diff --git

[Qemu-devel] [RFC v3 0/8] KVM PCI/MSI passthrough with mach-virt

2016-10-06 Thread Eric Auger
On ARM, MSI transactions emitted by passthrough'ed devices are translated by the IOMMU. So the host must allocate IOVAs and map them to the host MSI frame physical addresses. Those IOVAs must be allocated within safe GPA slots, unused by the guest. The QEMU VFIO device retrieves the size if the

Re: [Qemu-devel] [PATCH v2] qemu-nbd: Shrink image size by specified offset

2016-10-06 Thread Paolo Bonzini
On 05/10/2016 23:40, Tomáš Golembiovský wrote: > When --offset is set the apparent device size has to be adjusted > accordingly. Otherwise client may request read/write beyond the file end > which would fail. > > Signed-off-by: Tomáš Golembiovský Queued, thanks. Paolo >

Re: [Qemu-devel] [PATCH] qtest: add read/write accessors with a specific endianness

2016-10-06 Thread Peter Maydell
On 6 October 2016 at 04:38, David Gibson wrote: > On Wed, Oct 05, 2016 at 05:31:07AM -0700, Peter Maydell wrote: >> On 4 October 2016 at 16:43, David Gibson wrote: >> > On Tue, Oct 04, 2016 at 01:36:09PM +0100, Peter Maydell wrote: >> >>

Re: [Qemu-devel] [PATCH 4/4] linux-user: Fix fadvise64() syscall support for Mips32

2016-10-06 Thread Aleksandar Markovic
Sure, Peter, I am going to take your hints and address all your concerns in the v2 of this series, which is planned to be posted soon. I appreciate your guidance, Aleksandar From: Peter Maydell [peter.mayd...@linaro.org] Sent: Wednesday, October 05, 2016

Re: [Qemu-devel] [PATCH 01/12] virtio: add VIRTIO_DEF_DEVICE_VMSD macro

2016-10-06 Thread Halil Pasic
On 10/05/2016 09:00 PM, Dr. David Alan Gilbert wrote: > * Paolo Bonzini (pbonz...@redhat.com) wrote: >> >> >> On 05/10/2016 16:29, Dr. David Alan Gilbert wrote: >>> The virtio-input conversion especially is nice and simple. >>> The only weird case is virtio-gpu, and well virtio-gpu is the one

[Qemu-devel] [PATCH 3/3] linux-user: added support for pwritev() system call.

2016-10-06 Thread Dejan Jovicevic
This system call performs the same task as the writev system call, with the exception of having the fourth argument, offset, which specifes the file offset at which the input operation is to be performed. This implementation is based on the existing writev implementation. Signed-off-by: Dejan

[Qemu-devel] [PATCH 1/3] linux-user: detect pwritev support on configure

2016-10-06 Thread Dejan Jovicevic
Modified the configure file so that, during configuration, a check is performed to determine if the system call pwritev is supported by the host. The check for preadv support already exists. Signed-off-by: Dejan Jovicevic --- configure | 17

Re: [Qemu-devel] [PATCH 2/3] linux-user: added support for preadv() system call.

2016-10-06 Thread Peter Maydell
On 6 October 2016 at 14:59, Dejan Jovicevic wrote: > This system call performs the same task as the readv system call, > with the exception of having the fourth argument, offset, which > specifes the file offset at which the input operation is to be performed. > > This

Re: [Qemu-devel] Adding Save States menu items

2016-10-06 Thread Peter Maydell
On 6 October 2016 at 15:22, Programmingkid wrote: > Would you accept a patch that added "Save State" and > "Restore State" menu items to the cocoa interface? They would > allow the user to save the running state of the emulator. If you can get consensus on first adding

Re: [Qemu-devel] [Qemu-block] [PATCH] qcow2: Optimize L2 table cache size based on image and cluster sizes

2016-10-06 Thread Alberto Garcia
On Wed 05 Oct 2016 05:35:20 PM CEST, Max Reitz wrote: >>> Apart from that, I have to say I think it would be a bit more useful >>> if one would specify the area covered by the metadata caches as an >>> absolute number instead of a relative one (I guess it's generally >>>

[Qemu-devel] [PATCH v5 04/14] cryptodev: introduce a new cryptodev backend

2016-10-06 Thread Gonglei
The new cryptodev backend named cryptodev-builtin, which realized by QEMU cipher APIS. These APIs can be backed by either nettle or gcrypt. Signed-off-by: Gonglei --- backends/Makefile.objs | 1 + backends/cryptodev-builtin.c | 345

[Qemu-devel] [PATCH v5 07/14] virtio-crypto: set capacity of algorithms supported

2016-10-06 Thread Gonglei
Expose the capacity of algorithms supported by virtio crypto device to the frontend driver using pci configuration space. Signed-off-by: Gonglei --- hw/virtio/virtio-crypto.c | 40 ++- include/hw/virtio/virtio-crypto.h | 14

Re: [Qemu-devel] [PATCH 2/3] block-backend: Remember if attached device is non-qdev

2016-10-06 Thread Kevin Wolf
Am 05.10.2016 um 20:01 hat Max Reitz geschrieben: > On 05.10.2016 11:26, Kevin Wolf wrote: > > Almost all block devices are qdevified by now. This allows us to go back > > from the BlockBackend to the DeviceState. xen_disk is the last device > > that is missing. We'll remember in the BlockBackend

[Qemu-devel] [PATCH v5 08/14] virtio-crypto: add control queue handler

2016-10-06 Thread Gonglei
Realize the symmetric algorithm control queue handler, including plain cipher and chainning algorithms. Currently the control queue is used to create and close session for symmetric algorithm. Signed-off-by: Gonglei --- hw/virtio/virtio-crypto.c | 277

Re: [Qemu-devel] [PATCH v2] rules.mak: quiet-command: Split command name and args to print

2016-10-06 Thread Peter Maydell
On 4 October 2016 at 20:55, Eric Blake wrote: > On 10/04/2016 11:27 AM, Peter Maydell wrote: >> The quiet-command make rule currently takes two arguments: >> the command and arguments to run, and a string to print if >> the V flag is not set (ie we are not being verbose). >> By

[Qemu-devel] [PULL 19/29] MAINTAINERS: Add two more ppc related files

2016-10-06 Thread David Gibson
From: Thomas Huth The file hw/intc/heathrow_pic.c belongs to the Old World Mac machine, and pc-bios/ppc_rom.bin belongs to the PReP machine. Signed-off-by: Thomas Huth Signed-off-by: David Gibson --- MAINTAINERS | 2 ++ 1 file

[Qemu-devel] [PULL 12/29] target-ppc: add stxvh8x instruction

2016-10-06 Thread David Gibson
From: Nikunj A Dadhania stxvh8x: Store VSX Vector Halfword*8 Vector (16-bit elements): +--+--+--+--+--+--+--+--+ | 0001 | 1011 | 2021 | 3031 | 4041 | 5051 | 6061 | 7071 | +--+--+--+--+--+--+--+--+ Store

Re: [Qemu-devel] [PATCH v4 00/17] Convert VFIO-PCI to realize

2016-10-06 Thread Auger Eric
Hi Markus, On 04/10/2016 15:20, Markus Armbruster wrote: > Eric Auger writes: > >> This series converts VFIO-PCI to realize. It also aims at improving >> the error reporting in case of QMP hot-plug. >> >> Before the series, a device_add failure would have reported: >>

[Qemu-devel] [PATCH v2 09/12] virtio-balloon: convert VMSTATE_VIRTIO_DEVICE

2016-10-06 Thread Halil Pasic
Use the new VMSTATE_VIRTIO_DEVICE macro. Signed-off-by: Halil Pasic --- hw/virtio/virtio-balloon.c | 17 +++-- 1 file changed, 11 insertions(+), 6 deletions(-) diff --git a/hw/virtio/virtio-balloon.c b/hw/virtio/virtio-balloon.c index 49a2f4a..1014ec6

[Qemu-devel] [PATCH v10 00/16] Support streaming to an intermediate layer

2016-10-06 Thread Alberto Garcia
Hi all, 6 months after v9, and more than a year after v8, here's the new version of the intermediate block streaming series. There have been so many changes in QEMU since then that all patches in this series are either new or have changed. Still, some of the most important changes have been

[Qemu-devel] [PATCH v2 12/12] virtio: cleanup VMSTATE_VIRTIO_DEVICE

2016-10-06 Thread Halil Pasic
Now all the usages of the old version of VMSTATE_VIRTIO_DEVICE are gone, so we can get rid of the conditionals, and the old macro. Signed-off-by: Halil Pasic --- We could also make virtio_load/save static (private) at this point. I think we should. Opinions? ---

[Qemu-devel] [PATCH 2/3] target-arm: Add trace events for the generic timers

2016-10-06 Thread Peter Maydell
Add some useful trace events for the ARM generic timers (notably the various register writes and the resulting IRQ line state). Signed-off-by: Peter Maydell --- Makefile.objs | 1 + target-arm/helper.c | 20 2 files changed, 17

Re: [Qemu-devel] [PATCH v4 3/3] tests: start generic qemu-qmp tests

2016-10-06 Thread Markus Armbruster
Marc-André Lureau writes: > Hi > > - Original Message - >> Marc-André Lureau writes: >> >> > Hi >> > >> > - Original Message - >> > -snip- >> > >> >> >> >> I'd be willing to take this as is with a suitable TODO comment >> >> explaining

[Qemu-devel] [PATCH 1/3] target-arm: Implement dummy MDCCINT_EL1

2016-10-06 Thread Peter Maydell
MDCCINT_EL1 is part of the DCC debugger communication channel between the CPU and an attached external debugger. QEMU doesn't implement this, but since Linux may try to access this register we need to provide at least a dummy implementation. Signed-off-by: Peter Maydell

Re: [Qemu-devel] [PATCH v2] qmp: Disable query-cpu-* commands when they're unavailable

2016-10-06 Thread Markus Armbruster
Eduardo Habkost writes: > Instead of requiring clients to actually call the query-cpu-* > commands to find out if they are implemented, remove them from > the output of "query-commands", so clients know they are not > available. > > This is implemented by extending the

Re: [Qemu-devel] [PATCH v3 0/3] qapi: return 'missing parameter' error

2016-10-06 Thread Markus Armbruster
Marc-André Lureau writes: > Hi, > > 'monitor: use qmp_dispatch()' patch broke some iotests expecting a > 'missing parameter' error. This series fixes qapi visitors to return > this error for all types. > > This series should go on top of: >

Re: [Qemu-devel] [PULL 00/29] ppc-for-2.8 queue 20161006

2016-10-06 Thread Peter Maydell
are available in the git repository at: > > git://github.com/dgibson/qemu.git tags/ppc-for-2.8-20161006 > > for you to fetch changes up to 3daa4a9f9580ffda47df93c7c53371af226bf970: > > hw/ppc/spapr: Use POWER8 by default for the pseries

Re: [Qemu-devel] [PATCH v2] qemu_opt_foreach: Fix crasher

2016-10-06 Thread Daniel P. Berrange
On Thu, Oct 06, 2016 at 02:10:17PM +0100, Peter Maydell wrote: > On 6 October 2016 at 14:02, Peter Maydell wrote: > > On 6 October 2016 at 13:39, Michal Privoznik wrote: > >> diff --git a/include/sysemu/char.h b/include/sysemu/char.h > >> index

Re: [Qemu-devel] [PATCH v3 0/3] qapi: return 'missing parameter' error

2016-10-06 Thread Marc-André Lureau
Hi On Thu, Oct 6, 2016 at 5:48 PM Markus Armbruster wrote: > Marc-André Lureau writes: > > > Hi, > > > > 'monitor: use qmp_dispatch()' patch broke some iotests expecting a > > 'missing parameter' error. This series fixes qapi visitors to return >

[Qemu-devel] [PATCH 2/3] linux-user: added support for preadv() system call.

2016-10-06 Thread Dejan Jovicevic
This system call performs the same task as the readv system call, with the exception of having the fourth argument, offset, which specifes the file offset at which the input operation is to be performed. This implementation is based on the existing readv implementation. Signed-off-by: Dejan

Re: [Qemu-devel] [PATCH] qtest: add read/write accessors with a specific endianness

2016-10-06 Thread Greg Kurz
On Thu, 6 Oct 2016 12:03:34 +0100 Peter Maydell wrote: > On 6 October 2016 at 04:38, David Gibson wrote: > > On Wed, Oct 05, 2016 at 05:31:07AM -0700, Peter Maydell wrote: > >> On 4 October 2016 at 16:43, David Gibson

[Qemu-devel] Adding Save States menu items

2016-10-06 Thread Programmingkid
Would you accept a patch that added "Save State" and "Restore State" menu items to the cocoa interface? They would allow the user to save the running state of the emulator.

Re: [Qemu-devel] Monitor brain dump

2016-10-06 Thread Markus Armbruster
"Dr. David Alan Gilbert" writes: > * Markus Armbruster (arm...@redhat.com) wrote: > > Thanks for this. > >> In the beginning, there was only monitor.c, and it provided what we >> today call HMP, at just under 500 SLOC. >> >> Since then, most (but not all) HMP commands have

[Qemu-devel] [PATCH v5 14/14] cryptodev: rename cryptodev stuff

2016-10-06 Thread Gonglei
Remove qcrypto and/or QCRYPTO prefix in order to make the name shorter because it doesn't repeat any information. Signed-off-by: Gonglei --- backends/cryptodev-builtin.c | 84 backends/cryptodev.c | 106

[Qemu-devel] [PATCH v5 06/14] virtio-crypto-pci: add virtio crypto pci support

2016-10-06 Thread Gonglei
This patch adds virtio-crypto-pci, which is the pci proxy for the virtio crypto device. Signed-off-by: Gonglei --- hw/virtio/Makefile.objs | 1 + hw/virtio/virtio-crypto-pci.c | 77 +++ hw/virtio/virtio-pci.h| 15

[Qemu-devel] [PATCH v5 10/14] cryptodev: introduce an unified wrapper for crypto operation

2016-10-06 Thread Gonglei
We use an opaque point to the VirtIOCryptoReq which can support different packets based on different algorithms. Signed-off-by: Gonglei --- backends/cryptodev-builtin.c | 2 +- backends/cryptodev.c | 28 ++-- hw/virtio/virtio-crypto.c

[Qemu-devel] [RFC v4 1/8] linux-headers: Partial update for MSI IOVA handling

2016-10-06 Thread Eric Auger
This is a partial update aiming at enhancing the VFIO user API with IOMMU info capability chain, msi_geometry reporting and MSI IOVA window registration. The kernel code is not yet upstreamed. It is available at https://github.com/eauger/linux/tree/generic-v7-passthrough-v13 ([PATCH v13 00/15]

[Qemu-devel] [PULL 04/29] hw/ppc/spapr: Move code related to "ibm, pa-features" to a separate function

2016-10-06 Thread David Gibson
From: Thomas Huth The function spapr_populate_cpu_dt() has become quite big already, and since we likely have to extend the pa-features property for every new processor generation, it is nicer if we put the related code into a separate function. Signed-off-by: Thomas Huth

[Qemu-devel] [PULL 13/29] target-ppc: add lxvb16x instruction

2016-10-06 Thread David Gibson
From: Nikunj A Dadhania lxvb16x: Load VSX Vector Byte*16 Little/Big-endian Storage +--+--+--+--+--+--+--+--+--+--+--+--+--+--+--+--+ |F0|F1|F2|F3|F4|F5|F6|F7|E0|E1|E2|E3|E4|E5|E6|E7| +--+--+--+--+--+--+--+--+--+--+--+--+--+--+--+--+ Vector load results in (8-bit

[Qemu-devel] [PULL 29/29] hw/ppc/spapr: Use POWER8 by default for the pseries-2.8 machine

2016-10-06 Thread David Gibson
From: Thomas Huth A couple of distributors are compiling their distributions with "-mcpu=power8" for ppc64le these days, so the user sooner or later runs into a crash there when not explicitely specifying the "-cpu POWER8" option to QEMU (which is currently using POWER7 for the

[Qemu-devel] [PULL 26/29] tests: enable ohci/uhci/xhci tests on PPC64

2016-10-06 Thread David Gibson
From: Laurent Vivier Signed-off-by: Laurent Vivier Signed-off-by: David Gibson --- tests/Makefile.include| 8 +++- tests/usb-hcd-uhci-test.c | 24 2 files changed, 23 insertions(+), 9

Re: [Qemu-devel] [PATCH 2/2] migration: send and check the devices between source and distination at the begining

2016-10-06 Thread Dr. David Alan Gilbert
* Li Zhijian (lizhij...@cn.fujitsu.com) wrote: > > > On 09/30/2016 05:58 PM, Dr. David Alan Gilbert wrote: > > * Li Zhijian (lizhij...@cn.fujitsu.com) wrote: > > > > > > > > > On 09/30/2016 02:15 PM, Amit Shah wrote: > > > > Hi, > > > > > > > > On (Thu) 29 Sep 2016 [19:06:32], Li Zhijian

[Qemu-devel] [PULL 27/29] spapr: fix check of cpu alias name in spapr_get_cpu_core_type()

2016-10-06 Thread David Gibson
From: Greg Kurz If the user passes an alias name and a property to -cpu, QEMU fails to find the CPU definition and exits. $ qemu-system-ppc64 -cpu POWER8E,compat=power7 qemu-system-ppc64: Unable to find sPAPR CPU Core definition This happens because spapr_get_cpu_core_type()

[Qemu-devel] [PULL 01/29] spapr_vscsi: fix build error introduced by f19661c8

2016-10-06 Thread David Gibson
From: Felipe Franciosi A typo introduced in f19661c8 prevents qemu from building when configured with --enable-trace-backend=dtrace. Signed-off-by: Felipe Franciosi Reviewed-by: Laurent Vivier Signed-off-by: David Gibson

[Qemu-devel] [PATCH v2 01/12] virtio: prepare change VMSTATE_VIRTIO_DEVICE macro

2016-10-06 Thread Halil Pasic
In most cases the functions passed to VMSTATE_VIRTIO_DEVICE only call the virtio_load and virtio_save wrappers. Some include some pre- and post- massaging too. The massaging is better expressed as such in the VMStateDescription. Let us prepare for changing the semantic of the

[Qemu-devel] [PATCH v10 03/16] block: Use block_job_add_bdrv() in mirror_start_job()

2016-10-06 Thread Alberto Garcia
Use block_job_add_bdrv() instead of blocking all operations in mirror_start_job() and unblocking them in mirror_exit(). Signed-off-by: Alberto Garcia --- block/mirror.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/block/mirror.c b/block/mirror.c index

[Qemu-devel] [PATCH v10 09/16] block: Add QMP support for streaming to an intermediate layer

2016-10-06 Thread Alberto Garcia
This patch makes the 'device' parameter of the 'block-stream' command accept a node name that is not a root node. In addition to that, operation blockers will be checked in all intermediate nodes between the top and the base node. Signed-off-by: Alberto Garcia --- blockdev.c

[Qemu-devel] [PATCH v10 01/16] block: Pause all jobs during bdrv_reopen_multiple()

2016-10-06 Thread Alberto Garcia
When a BlockDriverState is about to be reopened it can trigger certain operations that need to write to disk. During this process a different block job can be woken up. If that block job completes and also needs to call bdrv_reopen() it can happen that it needs to do it on the same

[Qemu-devel] [PATCH v10 15/16] qemu-iotests: Add iotests.supports_quorum()

2016-10-06 Thread Alberto Garcia
There's many tests that need Quorum support in order to run. At the moment each test implements its own check to see if Quorum is enabled. This patch centralizes all those checks in a new function called iotests.supports_quorum(). Signed-off-by: Alberto Garcia ---

[Qemu-devel] [PATCH v5 00/14] virtio-crypto: introduce framework and device emulation

2016-10-06 Thread Gonglei
The virtio crypto is a virtual crypto device as well as a kind of virtual hardware accelerator for virtual machines. The encryption and decryption requests are placed in the data queue and handled by the real crypto accelerators finally. The second queue is the control queue used to create or

  1   2   3   4   >