Re: [Qemu-devel] [PATCH RFC v3 11/14] intel_iommu: provide its own replay() callback

2017-01-16 Thread Peter Xu
On Mon, Jan 16, 2017 at 03:47:08PM +0800, Jason Wang wrote: > > > On 2017年01月16日 15:31, Peter Xu wrote: > >On Fri, Jan 13, 2017 at 05:26:06PM +0800, Jason Wang wrote: > >> > >>On 2017年01月13日 11:06, Peter Xu wrote: > >>>The default replay() don't work for VT-d since vt-d will have a huge >

Re: [Qemu-devel] [PATCH] hw/core/null-machine: Add the possibility to instantiate a CPU, RAM and kernel

2017-01-16 Thread Thomas Huth
On 14.01.2017 12:03, Laurent Vivier wrote: > Le 14/01/2017 à 07:51, Thomas Huth a écrit : >> Sometimes it is useful to have just a machine with CPU and RAM, without >> any further hardware in it, e.g. if you just want to do some instruction >> debugging for TCG with a remote GDB attached to QEMU,

Re: [Qemu-devel] [PATCH RFC v3 12/14] intel_iommu: do replay when context invalidate

2017-01-16 Thread Peter Xu
On Mon, Jan 16, 2017 at 03:52:10PM +0800, Jason Wang wrote: > > > On 2017年01月16日 15:43, Peter Xu wrote: > >On Mon, Jan 16, 2017 at 01:53:54PM +0800, Jason Wang wrote: > >> > >>On 2017年01月13日 11:06, Peter Xu wrote: > >>>Before this one we only invalidate context cache when we receive context >

Re: [Qemu-devel] [PATCH v2 11/11] aspeed/smc: handle dummy bytes when doing fast reads in command mode

2017-01-16 Thread Cédric Le Goater
> I did not notice that this function is also called in writes, isn't it? > If yes, dummy cycles are used only during reads so probably CTRL_FREADMODE > needs to be tested. yes. I can take care of that in a follow up patchset for dummy support. Dummies in user mode is a bit painful to

Re: [Qemu-devel] [PATCH RFC v3 13/14] intel_iommu: allow dynamic switch of IOMMU region

2017-01-16 Thread Jason Wang
On 2017年01月16日 16:12, Peter Xu wrote: On Mon, Jan 16, 2017 at 04:01:00PM +0800, Jason Wang wrote: On 2017年01月16日 15:50, Peter Xu wrote: On Mon, Jan 16, 2017 at 02:20:31PM +0800, Jason Wang wrote: [...] diff --git a/hw/i386/intel_iommu.c b/hw/i386/intel_iommu.c index fd75112..2596f11

[Qemu-devel] [PATCH v4 2/2] memory: hmp: add "-f" for "info mtree"

2017-01-16 Thread Peter Xu
Adding one more option "-f" for "info mtree" to dump the flat views of all the address spaces. This will be useful to debug the memory rendering logic, also it'll be much easier with it to know what memory region is handling what address range. Signed-off-by: Peter Xu ---

Re: [Qemu-devel] [PATCH v8 15/21] qapi: add qapi2texi script

2017-01-16 Thread Markus Armbruster
Marc-André Lureau writes: > As the name suggests, the qapi2texi script converts JSON QAPI > description into a texi file suitable for different target > formats (info/man/txt/pdf/html...). > > It parses the following kind of blocks: > > Free-form: > > ## > # =

Re: [Qemu-devel] [PATCH RFC v3 12/14] intel_iommu: do replay when context invalidate

2017-01-16 Thread Peter Xu
On Mon, Jan 16, 2017 at 03:52:10PM +0800, Jason Wang wrote: > > > On 2017年01月16日 15:43, Peter Xu wrote: > >On Mon, Jan 16, 2017 at 01:53:54PM +0800, Jason Wang wrote: > >> > >>On 2017年01月13日 11:06, Peter Xu wrote: > >>>Before this one we only invalidate context cache when we receive context >

[Qemu-devel] [PATCH RFC 5/6] arm: virt: Enable generic type CPU in virt machine

2017-01-16 Thread Shannon Zhao
From: Shannon Zhao Signed-off-by: Shannon Zhao --- hw/arm/virt.c | 1 + 1 file changed, 1 insertion(+) diff --git a/hw/arm/virt.c b/hw/arm/virt.c index 4b301c2..49b7b65 100644 --- a/hw/arm/virt.c +++ b/hw/arm/virt.c @@ -166,6 +166,7 @@ static

Re: [Qemu-devel] [PATCH RFC 0/6] target-arm: KVM64: Cross type vCPU support

2017-01-16 Thread no-reply
Hi, Your series seems to have some coding style problems. See output below for more information: Type: series Message-id: 1484558821-15512-1-git-send-email-zhaoshengl...@huawei.com Subject: [Qemu-devel] [PATCH RFC 0/6] target-arm: KVM64: Cross type vCPU support === TEST SCRIPT BEGIN ===

Re: [Qemu-devel] [PATCH RFC v3 11/14] intel_iommu: provide its own replay() callback

2017-01-16 Thread Peter Xu
On Mon, Jan 16, 2017 at 04:03:22PM +0800, Jason Wang wrote: [...] > >>>Though I haven't tested with huge pages yet, but this patch should > >>>both solve above issue? I don't know whether you went over the page > >>>walk logic - it should both support huge page, and it will skip > >>>unmapped

Re: [Qemu-devel] [PULL 000/180] QAPI patches for 2017-01-13

2017-01-16 Thread Markus Armbruster
Eric Blake writes: > On 01/13/2017 10:44 AM, Markus Armbruster wrote: >> This is Marc-André's "[PATCH v8 00/21] qapi doc generation (whole >> version, squashed)" with a few commit messages tweaked, and "[PATCH v8 >> 14/21] (SQUASHED) move doc to schema" unsquashed into 161

Re: [Qemu-devel] Virtual Machine Generation ID

2017-01-16 Thread Igor Mammedov
On Sat, 14 Jan 2017 22:17:53 -0800 Ben Warren wrote: > Hi Michael, > > > On Dec 10, 2016, at 7:28 PM, Michael S. Tsirkin wrote: > > > > On Tue, Dec 06, 2016 at 06:15:34PM -0800, Ben Warren wrote: > >> Hi Michael, > >> > >> I’m well on my way to

[Qemu-devel] [Bug 1578192] Re: GTK+ interface doesn't translate keycodes properly with Wayland backend

2017-01-16 Thread Daniel Berrange
This issue was fixed already in git master with: commit a8ffb372a2202c65f42fdb69891ea68a2f274b55 Author: Daniel P. Berrange Date: Thu Dec 1 09:41:17 2016 + ui: use evdev keymap when running under wayland Wayland always uses evdev as its input source, so

Re: [Qemu-devel] [PATCH RFC v3 13/14] intel_iommu: allow dynamic switch of IOMMU region

2017-01-16 Thread Jason Wang
On 2017年01月16日 15:50, Peter Xu wrote: On Mon, Jan 16, 2017 at 02:20:31PM +0800, Jason Wang wrote: [...] diff --git a/hw/i386/intel_iommu.c b/hw/i386/intel_iommu.c index fd75112..2596f11 100644 --- a/hw/i386/intel_iommu.c +++ b/hw/i386/intel_iommu.c @@ -1343,9 +1343,49 @@ static void

Re: [Qemu-devel] [PATCH RFC v3 12/14] intel_iommu: do replay when context invalidate

2017-01-16 Thread Jason Wang
On 2017年01月16日 16:18, Peter Xu wrote: On Mon, Jan 16, 2017 at 03:52:10PM +0800, Jason Wang wrote: On 2017年01月16日 15:43, Peter Xu wrote: On Mon, Jan 16, 2017 at 01:53:54PM +0800, Jason Wang wrote: On 2017年01月13日 11:06, Peter Xu wrote: Before this one we only invalidate context cache when

[Qemu-devel] [PATCH RFC 1/6] headers: update linux headers

2017-01-16 Thread Shannon Zhao
From: Shannon Zhao Signed-off-by: Shannon Zhao --- linux-headers/asm-arm64/kvm.h | 1 + linux-headers/linux/kvm.h | 2 ++ 2 files changed, 3 insertions(+) diff --git a/linux-headers/asm-arm64/kvm.h b/linux-headers/asm-arm64/kvm.h index

[Qemu-devel] [PATCH RFC 6/6] target-arm: cpu64: Add support for Cortex-A72

2017-01-16 Thread Shannon Zhao
From: Shannon Zhao Add the ARM Cortex-A72 processor definition. It's similar to A57. Signed-off-by: Shannon Zhao --- hw/arm/virt.c | 1 + target/arm/cpu64.c | 56 ++ 2 files changed, 57

Re: [Qemu-devel] [PATCH RFC v3 14/14] intel_iommu: enable vfio devices

2017-01-16 Thread Jason Wang
On 2017年01月16日 17:18, Peter Xu wrote: static void vtd_iotlb_page_invalidate(IntelIOMMUState *s, uint16_t domain_id, hwaddr addr, uint8_t am) { @@ -1222,6 +1251,7 @@ static void vtd_iotlb_page_invalidate(IntelIOMMUState *s, uint16_t domain_id,

Re: [Qemu-devel] [PATCH RFC v3 11/14] intel_iommu: provide its own replay() callback

2017-01-16 Thread Jason Wang
On 2017年01月16日 15:59, Peter Xu wrote: On Mon, Jan 16, 2017 at 03:47:08PM +0800, Jason Wang wrote: On 2017年01月16日 15:31, Peter Xu wrote: On Fri, Jan 13, 2017 at 05:26:06PM +0800, Jason Wang wrote: On 2017年01月13日 11:06, Peter Xu wrote: The default replay() don't work for VT-d since vt-d

Re: [Qemu-devel] [PATCH RFC v3 13/14] intel_iommu: allow dynamic switch of IOMMU region

2017-01-16 Thread Peter Xu
On Mon, Jan 16, 2017 at 04:01:00PM +0800, Jason Wang wrote: > > > On 2017年01月16日 15:50, Peter Xu wrote: > >On Mon, Jan 16, 2017 at 02:20:31PM +0800, Jason Wang wrote: > > > >[...] > > > >>>diff --git a/hw/i386/intel_iommu.c b/hw/i386/intel_iommu.c > >>>index fd75112..2596f11 100644 > >>>---

Re: [Qemu-devel] [PATCH v5 3/4] migration: disallow migrate_add_blocker during migration

2017-01-16 Thread Ashijeet Acharya
On Mon, Jan 16, 2017 at 1:17 AM, Greg Kurz wrote: > On Thu, 12 Jan 2017 21:22:33 +0530 > Ashijeet Acharya wrote: > >> If a migration is already in progress and somebody attempts >> to add a migration blocker, this should rightly fail. >> >> Add an errp

Re: [Qemu-devel] [PULL 10/65] tcg/s390: Expose host facilities to tcg-target.h

2017-01-16 Thread Christian Borntraeger
On 01/13/2017 10:18 AM, Christian Borntraeger wrote: > On 01/11/2017 03:17 AM, Richard Henderson wrote: >> This lets us expose facilities to TCG_TARGET_HAS_* defines >> directly, rather than hiding behind function calls. >> >> Signed-off-by: Richard Henderson >> --- >>

[Qemu-devel] Towards an ivshmem 2.0?

2017-01-16 Thread Jan Kiszka
Hi, some of you may know that we are using a shared memory device similar to ivshmem in the partitioning hypervisor Jailhouse [1]. We started as being compatible to the original ivshmem that QEMU implements, but we quickly deviated in some details, and in the recent months even more. Some of the

Re: [Qemu-devel] [PATCH RFC v3 14/14] intel_iommu: enable vfio devices

2017-01-16 Thread Peter Xu
On Mon, Jan 16, 2017 at 02:30:20PM +0800, Jason Wang wrote: [...] > > } > > /* Flush IOTLB > >@@ -2244,15 +2274,34 @@ static void > >vtd_iommu_notify_flag_changed(MemoryRegion *iommu, > >IOMMUNotifierFlag new) > > { > > VTDAddressSpace *vtd_as

[Qemu-devel] [PULL v2 000/180] QAPI patches for 2017-01-16

2017-01-16 Thread Markus Armbruster
This is Marc-André's "[PATCH v8 00/21] qapi doc generation (whole version, squashed)" with a few commit messages tweaked, and "[PATCH v8 14/21] (SQUASHED) move doc to schema" unsquashed into 161 patches. We did all the respins with in this squashed form to reduce noise. However, since the

[Qemu-devel] [PATCH RFC 2/6] target: arm: Add the qemu target for KVM_ARM_TARGET_GENERIC_V8

2017-01-16 Thread Shannon Zhao
From: Shannon Zhao Signed-off-by: Shannon Zhao --- target/arm/kvm-consts.h | 2 ++ 1 file changed, 2 insertions(+) diff --git a/target/arm/kvm-consts.h b/target/arm/kvm-consts.h index a2c9518..fc01ac5 100644 --- a/target/arm/kvm-consts.h +++

[Qemu-devel] [PATCH RFC 4/6] target: arm: Add a generic type cpu

2017-01-16 Thread Shannon Zhao
From: Shannon Zhao Add a generic type cpu, it's useful for migration when running on different hardwares. Signed-off-by: Shannon Zhao --- target/arm/cpu64.c | 54 ++ 1 file changed, 54

[Qemu-devel] [PATCH RFC 3/6] arm: kvm64: Check if kvm supports cross type vCPU

2017-01-16 Thread Shannon Zhao
From: Shannon Zhao If user requests a specific type vCPU which is not same with the physical ones and if kvm supports cross type vCPU, we set the KVM_ARM_VCPU_CROSS bit and set the CPU ID registers. Signed-off-by: Shannon Zhao ---

Re: [Qemu-devel] [PULL 00/30] target-sparc sun4v support

2017-01-16 Thread Artyom Tarasenko
On Fri, Jan 13, 2017 at 3:01 PM, Peter Maydell wrote: > On 12 January 2017 at 02:55, Richard Henderson wrote: >> Mark Cave-Ayland asked me to handle the merge of this patch set >> while he is traveling. >> >> This is the v2 that Artyom posted today. I

Re: [Qemu-devel] [PATCH RFC v3 11/14] intel_iommu: provide its own replay() callback

2017-01-16 Thread Jason Wang
On 2017年01月16日 16:06, Peter Xu wrote: On Mon, Jan 16, 2017 at 04:03:22PM +0800, Jason Wang wrote: [...] Though I haven't tested with huge pages yet, but this patch should both solve above issue? I don't know whether you went over the page walk logic - it should both support huge page, and

Re: [Qemu-devel] [PATCH RFC v3 13/14] intel_iommu: allow dynamic switch of IOMMU region

2017-01-16 Thread Peter Xu
On Mon, Jan 16, 2017 at 04:25:35PM +0800, Jason Wang wrote: > > > On 2017年01月16日 16:12, Peter Xu wrote: > >On Mon, Jan 16, 2017 at 04:01:00PM +0800, Jason Wang wrote: > >> > >>On 2017年01月16日 15:50, Peter Xu wrote: > >>>On Mon, Jan 16, 2017 at 02:20:31PM +0800, Jason Wang wrote: > >>> > >>>[...]

[Qemu-devel] [PATCH v4 1/2] memory: tune mtree_print_mr() to dump mr type

2017-01-16 Thread Peter Xu
We were dumping RW bits for each memory region, that might be confusing. It'll make more sense to dump the memory region type directly rather than the RW bits since that's how the bits are derived. Meanwhile, with some slight cleanup in the function. Signed-off-by: Peter Xu

[Qemu-devel] [PATCH v4 0/2] memory: extend "info mtree" with flat view dump

2017-01-16 Thread Peter Xu
v4: - do unref of flatview when no view is there [Dave] v3: - rather than dump flatview directly in "info mtree", provide a new parameter "-f" for it. [Paolo] - replace "RW" chars with the type of memory region [Paolo] - (cc dave as well since it touches HMP interface) v2: - fix a size error

Re: [Qemu-devel] [PATCH RFC v3 14/14] intel_iommu: enable vfio devices

2017-01-16 Thread Peter Xu
On Mon, Jan 16, 2017 at 02:30:20PM +0800, Jason Wang wrote: > > > On 2017年01月13日 11:06, Peter Xu wrote: > >This patch is based on Aviv Ben-David ()'s patch > >upstream: > > > > "IOMMU: enable intel_iommu map and unmap notifiers" > >

Re: [Qemu-devel] [PULL v2 02/11] ui: use evdev keymap when running under wayland

2017-01-16 Thread Daniel P. Berrange
CC qemu-stable This patch should go into active stable branches given that wayland is now the default on some OS distro On Mon, Jan 09, 2017 at 02:09:36PM +0100, Gerd Hoffmann wrote: > From: "Daniel P. Berrange" > > Wayland always uses evdev as its input source, so

[Qemu-devel] [PATCH RFC 0/6] target-arm: KVM64: Cross type vCPU support

2017-01-16 Thread Shannon Zhao
From: Shannon Zhao This patch set support use cross type vCPU when using KVM on ARM and add two new CPU types: generic and cortex-a72. You can test this patch set with QEMU using -cpu cortex-a53/cortex-a57/generic/cortex-a72 These patches can be fetched from:

Re: [Qemu-devel] [PATCH 0/2] virtio: revert virtio_queue_set_notification() nesting

2017-01-16 Thread Stefan Hajnoczi
On Fri, Jan 13, 2017 at 09:15:49AM -0600, Doug Goldstein wrote: > On 1/13/17 6:02 AM, Stefan Hajnoczi wrote: > > On Thu, Jan 12, 2017 at 10:57:53AM -0600, Doug Goldstein wrote: > >> On 1/12/17 5:46 AM, Stefan Hajnoczi wrote: > >>> The virtio_queue_set_notification() nesting introduced for

Re: [Qemu-devel] [PATCH 04/16] io: add methods to set I/O handlers on AioContext

2017-01-16 Thread Fam Zheng
On Fri, 01/13 14:17, Paolo Bonzini wrote: > This is in preparation for making qio_channel_yield work on > AioContexts other than the main one. > > Signed-off-by: Paolo Bonzini > --- > include/io/channel.h | 30 ++ > io/channel-command.c | 13

Re: [Qemu-devel] [PATCH 05/16] io: make qio_channel_yield aware of AioContexts

2017-01-16 Thread Fam Zheng
On Fri, 01/13 14:17, Paolo Bonzini wrote: > Support separate coroutines for reading and writing, and place the > read/write handlers on the AioContext that the QIOChannel is registered > with. > > Signed-off-by: Paolo Bonzini > --- > include/io/channel.h | 37

Re: [Qemu-devel] [PATCH] Further tidy-up on block status

2017-01-16 Thread Vladimir Sementsov-Ogievskiy
13.01.2017 13:29, Alex Bligh wrote: On 13 Jan 2017, at 09:48, Vladimir Sementsov-Ogievskiy wrote: 12.01.2017 16:11, Alex Bligh wrote: On 12 Jan 2017, at 07:05, Vladimir Sementsov-Ogievskiy wrote: Yes this is better. But is it actually

Re: [Qemu-devel] [PATCH] target-i386: Remove AMD feature flag aliases from Opteron models

2017-01-16 Thread Igor Mammedov
On Fri, 13 Jan 2017 17:00:57 -0200 Eduardo Habkost wrote: > When CPU vendor is set to AMD, the AMD feature alias bits on > CPUID[0x8001].EDX are already automatically copied from CPUID[1].EDX > on x86_cpu_realizefn(). When CPU vendor is Intel, those bits are > reserved

[Qemu-devel] [PATCH v6 0/5] Introduce a new --only-migratable option

2017-01-16 Thread Ashijeet Acharya
Previously posted series patches: http://lists.nongnu.org/archive/html/qemu-devel/2017-01/msg02324.html http://lists.nongnu.org/archive/html/qemu-devel/2017-01/msg01277.html http://lists.nongnu.org/archive/html/qemu-devel/2017-01/msg00320.html

[Qemu-devel] [PATCH v6 1/5] block/vvfat: Remove the undesirable comment

2017-01-16 Thread Ashijeet Acharya
Remove the "// assert(is_consistent(s))" comment in block/vvfat.c Signed-off-by: Ashijeet Acharya --- block/vvfat.c | 1 - 1 file changed, 1 deletion(-) diff --git a/block/vvfat.c b/block/vvfat.c index ded2109..7b706dc 100644 --- a/block/vvfat.c +++ b/block/vvfat.c

Re: [Qemu-devel] [RFC PATCH 02/17] hw/ppc/spapr: Add POWER9 to pseries cpu models

2017-01-16 Thread David Gibson
On Fri, Jan 13, 2017 at 05:28:08PM +1100, Suraj Jitindar Singh wrote: > Add POWER9 cpu to list of spapr core models which allows it to be specified > as the cpu model for a pseries guest (e.g. -machine pseries -cpu POWER9). > > Signed-off-by: Suraj Jitindar Singh I

Re: [Qemu-devel] Towards an ivshmem 2.0?

2017-01-16 Thread Marc-André Lureau
Hi On Mon, Jan 16, 2017 at 12:37 PM Jan Kiszka wrote: > Hi, > > some of you may know that we are using a shared memory device similar to > ivshmem in the partitioning hypervisor Jailhouse [1]. > > We started as being compatible to the original ivshmem that QEMU >

Re: [Qemu-devel] [PULL 0/4] tcg fixes

2017-01-16 Thread Peter Maydell
On 13 January 2017 at 20:05, Richard Henderson wrote: > Two problems found with my most recent tcg-2.9 queued patches; > two patches for tcg/aarch64 that had been submitted but somehow > dropped off the patch queue. > > With this, aarch64 risu passes on aarch64 again. > > > r~ >

Re: [Qemu-devel] [PATCH 01/16] aio: introduce aio_co_schedule and aio_co_wake

2017-01-16 Thread Fam Zheng
On Fri, 01/13 14:17, Paolo Bonzini wrote: > aio_co_wake provides the infrastructure to start a coroutine on a "home" > AioContext. It will be used by CoMutex and CoQueue, so that coroutines > don't jump from one context to another when they go to sleep on a > mutex or waitqueue. However, it can

[Qemu-devel] [PATCH v6 4/5] migration: disallow migrate_add_blocker during migration

2017-01-16 Thread Ashijeet Acharya
If a migration is already in progress and somebody attempts to add a migration blocker, this should rightly fail. Add an errp parameter and a retcode return value to migrate_add_blocker. Signed-off-by: John Snow Signed-off-by: Ashijeet Acharya ---

[Qemu-devel] [PATCH v6 5/5] migration: Fail migration blocker for --only-migratable

2017-01-16 Thread Ashijeet Acharya
migrate_add_blocker should rightly fail if the '--only-migratable' option was specified and the device in use should not be able to perform the action which results in an unmigratable VM. Make migrate_add_blocker return -EACCES in this case. Signed-off-by: Ashijeet Acharya

[Qemu-devel] [Bug 1625987] Re: target-arm/translate-a64.c:2028: possible coding error ?

2017-01-16 Thread Thomas Huth
Released with v2.8 ** Changed in: qemu Status: Fix Committed => Fix Released -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1625987 Title: target-arm/translate-a64.c:2028: possible coding

Re: [Qemu-devel] [PATCH] Drop duplicate display option documentation

2017-01-16 Thread Paolo Bonzini
Cc: qemu-triv...@nongnu.org On 15/01/2017 21:30, Samuel Thibault wrote: > The curses and none possibilities are already documented on a separate line, > so documenting it on the sdl line was both unneeded and confusing. > > Signed-off-by: Samuel Thibault > > diff

Re: [Qemu-devel] [PATCH v4 6/6] hypertrace: Add guest-side Linux module

2017-01-16 Thread Stefan Hajnoczi
On Sun, Jan 15, 2017 at 03:10:13AM +0100, Lluís Vilanova wrote: > Stefan Hajnoczi writes: > > On Mon, Dec 26, 2016 at 09:35:10PM +0100, Lluís Vilanova wrote: > >> Provides guest Linux kernel module "qemu-hypertrace.ko" to abstract > >> access to the hypertrace channel. > >> > >> Signed-off-by:

[Qemu-devel] [PATCH v6 2/5] migration: Add a new option to enable only-migratable

2017-01-16 Thread Ashijeet Acharya
Add a new option "--only-migratable" in qemu which will allow to add only those devices which will not fail qemu after migration. Devices set with the flag 'unmigratable' cannot be added when this option will be used. Signed-off-by: Ashijeet Acharya ---

[Qemu-devel] [PATCH v6 3/5] migration: Allow "device add" options to only add migratable devices

2017-01-16 Thread Ashijeet Acharya
Introduce checks for the unmigratable flag in the VMStateDescription structs of respective devices when user attempts to add them. If the "--only-migratable" was specified, all unmigratable devices will rightly fail to add. This feature is made compatible for both "-device" and "-usbdevice"

[Qemu-devel] [Bug 1643537] Re: target-ppc/int_helper.c: 2 * bad array index

2017-01-16 Thread Thomas Huth
Released with version 2.8 ** Changed in: qemu Status: Fix Committed => Fix Released -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1643537 Title: target-ppc/int_helper.c: 2 * bad array

[Qemu-devel] [Bug 1630527] Re: qemu/hw/i386/amd_iommu.c:188: possible bad shift ?

2017-01-16 Thread Thomas Huth
Released with v2.8 ** Changed in: qemu Status: Fix Committed => Fix Released -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1630527 Title: qemu/hw/i386/amd_iommu.c:188: possible bad shift ?

[Qemu-devel] [Bug 1640525] Re: -net socket, connect/listen does not work in 2.7.0

2017-01-16 Thread Thomas Huth
Fix has been released with QEMU v2.8 ** Changed in: qemu Status: Fix Committed => Fix Released -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1640525 Title: -net socket,connect/listen does

Re: [Qemu-devel] [PATCH] Drop duplicate display option documentation

2017-01-16 Thread Marc-André Lureau
Hi On Mon, Jan 16, 2017 at 12:30 AM Samuel Thibault wrote: > The curses and none possibilities are already documented on a separate > line, > so documenting it on the sdl line was both unneeded and confusing. > > Signed-off-by: Samuel Thibault

Re: [Qemu-devel] [PATCH 05/16] io: make qio_channel_yield aware of AioContexts

2017-01-16 Thread Paolo Bonzini
On 16/01/2017 12:38, Fam Zheng wrote: >> +void qio_channel_detach_aio_context(QIOChannel *ioc) >> +{ >> +ioc->read_coroutine = NULL; >> +ioc->write_coroutine = NULL; >> +qio_channel_set_aio_fd_handlers(ioc); >> +ioc->ctx = NULL; > > Why is qio_channel_set_aio_fd_handler not

Re: [Qemu-devel] [PATCH] pflash_cfi01: fix per device sector length in CFI table

2017-01-16 Thread Dr. David Alan Gilbert
* Andrew Jones (drjo...@redhat.com) wrote: > On Thu, Jan 12, 2017 at 10:42:41AM +, Peter Maydell wrote: > > On 12 January 2017 at 10:35, David Engraf wrote: > > > The CFI entry for sector length must be set to sector length per device. > > > This is important for

Re: [Qemu-devel] [PATCH] hw/i386: check if nvdimm is enabled before plugging

2017-01-16 Thread Stefan Hajnoczi
On Mon, Jan 16, 2017 at 01:55:34PM +0800, Xiao Guangrong wrote: > > > On 01/14/2017 02:02 AM, Eduardo Habkost wrote: > > On Fri, Jan 13, 2017 at 01:17:27PM +, Stefan Hajnoczi wrote: > > > On Fri, Jan 13, 2017 at 07:56:51PM +0800, Haozhong Zhang wrote: > > > > The missing of 'nvdimm' in the

[Qemu-devel] [Bug 1194954] Re: Windows 95 guest reboots itself on qemu 1.5.0 & 1.5.50 (GIT)

2017-01-16 Thread Thomas Huth
Triaging old bug tickets ... can you still reproduce this problem with the latest version of QEMU (currently v2.8)? ** Changed in: qemu Status: New => Incomplete -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU.

[Qemu-devel] [Bug 1626972] Re: QEMU memfd_create fallback mechanism change for security drivers

2017-01-16 Thread Thomas Huth
Commit 0d34fbabc13 has been released with QEMU v2.8 ** Changed in: qemu Status: Fix Committed => Fix Released -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1626972 Title: QEMU memfd_create

Re: [Qemu-devel] [PATCH 01/16] aio: introduce aio_co_schedule and aio_co_wake

2017-01-16 Thread Paolo Bonzini
On 16/01/2017 12:09, Fam Zheng wrote: > On Fri, 01/13 14:17, Paolo Bonzini wrote: >> aio_co_wake provides the infrastructure to start a coroutine on a "home" >> AioContext. It will be used by CoMutex and CoQueue, so that coroutines >> don't jump from one context to another when they go to sleep

[Qemu-devel] [Bug 1568356] Re: ERROR:ui/sdl2-2d.c:120:sdl2_2d_switch:

2017-01-16 Thread Thomas Huth
Commit 435deffefbb07d9a0cafef4 has been released with QEMU v2.7.0 already ** Changed in: qemu Status: Fix Committed => Fix Released -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1568356

Re: [Qemu-devel] [PATCH 05/16] io: make qio_channel_yield aware of AioContexts

2017-01-16 Thread Daniel P. Berrange
On Fri, Jan 13, 2017 at 02:17:20PM +0100, Paolo Bonzini wrote: > Support separate coroutines for reading and writing, and place the > read/write handlers on the AioContext that the QIOChannel is registered > with. > > Signed-off-by: Paolo Bonzini > --- >

Re: [Qemu-devel] [PATCH 05/16] io: make qio_channel_yield aware of AioContexts

2017-01-16 Thread Daniel P. Berrange
On Mon, Jan 16, 2017 at 08:47:28PM +0800, Fam Zheng wrote: > On Mon, 01/16 13:24, Paolo Bonzini wrote: > > > > > > On 16/01/2017 12:38, Fam Zheng wrote: > > >> +void qio_channel_detach_aio_context(QIOChannel *ioc) > > >> +{ > > >> +ioc->read_coroutine = NULL; > > >> +ioc->write_coroutine

Re: [Qemu-devel] [PATCH] nvdimm: allow read/write zero-size namespace label

2017-01-16 Thread Stefan Hajnoczi
On Sat, Jan 14, 2017 at 07:22:28PM +0800, Li Qiang wrote: > Hello Guangrong, > > > 2017-01-13 17:00 GMT+08:00 Xiao Guangrong : > > > > > > > On 01/13/2017 11:02 AM, Li Qiang wrote: > > > >> From: Li Qiang > >> > >> The spec doesn't say the

Re: [Qemu-devel] [PATCH 10/16] block: explicitly acquire aiocontext in timers that need it

2017-01-16 Thread Paolo Bonzini
On 16/01/2017 14:07, Fam Zheng wrote: > On Fri, 01/13 14:17, Paolo Bonzini wrote: >> diff --git a/block/qed.c b/block/qed.c >> index 7f1c508..a21d025 100644 >> --- a/block/qed.c >> +++ b/block/qed.c >> @@ -345,10 +345,22 @@ static void qed_need_check_timer_cb(void *opaque) >> >>

[Qemu-devel] [PULL 04/11] aio: make ctx->list_lock a QemuLockCnt, subsuming ctx->walking_bh

2017-01-16 Thread Stefan Hajnoczi
From: Paolo Bonzini This will make it possible to walk the list of bottom halves without holding the AioContext lock---and in turn to call bottom half handlers without holding the lock. Reviewed-by: Stefan Hajnoczi Signed-off-by: Paolo Bonzini

[Qemu-devel] [PULL 05/11] qemu-thread: optimize QemuLockCnt with futexes on Linux

2017-01-16 Thread Stefan Hajnoczi
From: Paolo Bonzini This is complex, but I think it is reasonably documented in the source. Signed-off-by: Paolo Bonzini Reviewed-by: Fam Zheng Reviewed-by: Stefan Hajnoczi Message-id:

Re: [Qemu-devel] [PATCH 10/16] block: explicitly acquire aiocontext in timers that need it

2017-01-16 Thread Fam Zheng
On Mon, 01/16 14:32, Paolo Bonzini wrote: > > Why cannot these be local (static) functions, in block/qed.c? > > Patch 13 uses them elsewhere. Should I put them in a separate patch? Thanks, this is fine! Fam

Re: [Qemu-devel] [PATCH] qtest: virtio: zeroed last VRingDesc after allocate

2017-01-16 Thread Stefan Hajnoczi
On Sat, Jan 14, 2017 at 05:59:36PM +0800, Longpeng(Mike) wrote: > As qvring_indirect_desc_setup() wouldn't initialize last VRingDesc, > so it's filled with dirty data, this might cause virtio backend broken. > > For example, the last bit of this VRingDesc's flags might be 1, so >

Re: [Qemu-devel] [virtio-dev] Re: [PATCH v15 0/2] virtio-crypto: virtio crypto device specification

2017-01-16 Thread Gonglei (Arei)
Hi Michael and others, I'd like to redefine struct virtio_crypto_op_data_req is as below: struct virtio_crypto_op_data_req { struct virtio_crypto_op_header header; union { struct virtio_crypto_sym_data_req sym_req; struct virtio_crypto_hash_data_req hash_req;

Re: [Qemu-devel] [PATCH 06/16] nbd: do not block on partial reply header reads

2017-01-16 Thread Fam Zheng
On Fri, 01/13 14:17, Paolo Bonzini wrote: > Read the replies from a coroutine, switching the read side between the > "read header" coroutine and the I/O coroutine that reads the body of > the reply. > > qio_channel_yield is used so that the right coroutine is restarted > automatically,

Re: [Qemu-devel] Towards an ivshmem 2.0?

2017-01-16 Thread Jan Kiszka
Hi Marc-André, On 2017-01-16 13:41, Marc-André Lureau wrote: > Hi > > On Mon, Jan 16, 2017 at 12:37 PM Jan Kiszka > wrote: > > Hi, > > some of you may know that we are using a shared memory device similar to > ivshmem in the

Re: [Qemu-devel] [PULL 0/4] M68k for 2.9 patches

2017-01-16 Thread Peter Maydell
On 12 January 2017 at 18:08, Laurent Vivier wrote: > The following changes since commit 4201e616c0fa48de99a505a6ade979f0c2c65e28: > > Merge remote-tracking branch 'remotes/kraxel/tags/pull-audio-20170111-1' > into staging (2017-01-12 15:57:18 +) > > are available in the

Re: [Qemu-devel] [PATCH] virtio: drop an obsolete comment

2017-01-16 Thread Stefan Hajnoczi
On Thu, Jan 12, 2017 at 11:31:56PM +0200, Michael S. Tsirkin wrote: > virtio core has code to revert queue number > to maximum on reset. Drop TODO to add that. > > Signed-off-by: Michael S. Tsirkin > --- > hw/virtio/virtio-pci.c | 1 - > 1 file changed, 1 deletion(-)

[Qemu-devel] [PULL 00/11] Block patches

2017-01-16 Thread Stefan Hajnoczi
The following changes since commit 2ccede18bd24fce5db83fef3674563a1f256717b: Merge remote-tracking branch 'remotes/vivier/tags/m68k-for-2.9-pull-request' into staging (2017-01-16 12:41:35 +) are available in the git repository at: git://github.com/stefanha/qemu.git

[Qemu-devel] [PULL 03/11] qemu-thread: introduce QemuLockCnt

2017-01-16 Thread Stefan Hajnoczi
From: Paolo Bonzini A QemuLockCnt comprises a counter and a mutex, with primitives to increment and decrement the counter, and to take and release the mutex. It can be used to do lock-free visits to a data structure whenever mutexes would be too heavy-weight and the

[Qemu-devel] [PULL 09/11] aio-win32: remove walking_handlers, protecting AioHandler list with list_lock

2017-01-16 Thread Stefan Hajnoczi
From: Paolo Bonzini Reviewed-by: Stefan Hajnoczi Signed-off-by: Paolo Bonzini Reviewed-by: Fam Zheng Message-id: 20170112180800.21085-9-pbonz...@redhat.com Signed-off-by: Stefan Hajnoczi ---

[Qemu-devel] [PULL 3/4] trace: Fix dynamic event state on vCPU hot-unplug

2017-01-16 Thread Stefan Hajnoczi
From: Lluís Vilanova We need to disable per-vCPU events on a vCPU that is hot-unplugged to keep the dynamic event state global counters consistent. Signed-off-by: Lluís Vilanova Message-id: 148278748055.1404.1570530281528619895.st...@fimbulvetr.bsc.es

Re: [Qemu-devel] Virtual Machine Generation ID

2017-01-16 Thread Michael S. Tsirkin
On Sat, Jan 14, 2017 at 10:17:53PM -0800, Ben Warren wrote: > Hi Michael, > > > On Dec 10, 2016, at 7:28 PM, Michael S. Tsirkin wrote: > > On Tue, Dec 06, 2016 at 06:15:34PM -0800, Ben Warren wrote: > > Hi Michael, > > I’m well on my way to

Re: [Qemu-devel] [PATCH 01/16] aio: introduce aio_co_schedule and aio_co_wake

2017-01-16 Thread Fam Zheng
On Mon, 01/16 13:19, Paolo Bonzini wrote: > >> +static void co_schedule_bh_cb(void *opaque) > >> +{ > >> +AioContext *ctx = opaque; > >> +QSLIST_HEAD(, Coroutine) straight, reversed; > >> + > >> +QSLIST_MOVE_ATOMIC(, >scheduled_coroutines); > >> +QSLIST_INIT(); > > > > Worth

Re: [Qemu-devel] [PATCH 05/16] io: make qio_channel_yield aware of AioContexts

2017-01-16 Thread Daniel P. Berrange
On Mon, Jan 16, 2017 at 07:38:24PM +0800, Fam Zheng wrote: > On Fri, 01/13 14:17, Paolo Bonzini wrote: > > Support separate coroutines for reading and writing, and place the > > read/write handlers on the AioContext that the QIOChannel is registered > > with. > > > > Signed-off-by: Paolo Bonzini

Re: [Qemu-devel] [PATCH 3/3] nbd: do not block on partial reply header reads

2017-01-16 Thread Stefan Hajnoczi
On Fri, Dec 23, 2016 at 07:26:41PM +0100, Paolo Bonzini wrote: > @@ -65,54 +67,34 @@ static void nbd_teardown_connection(BlockDriverState *bs) > client->ioc = NULL; > } > > -static void nbd_reply_ready(void *opaque) > +static void nbd_read_reply_entry(void *opaque) Please use the

Re: [Qemu-devel] [PATCH 06/16] nbd: do not block on partial reply header reads

2017-01-16 Thread Paolo Bonzini
On 16/01/2017 13:52, Fam Zheng wrote: > +/* Kick the read_reply_co to get the next reply. */ > +aio_co_wake(s->read_reply_co); > > Can't s->read_reply_co be NULL? nbd_read_reply_entry unsets it. (Surprisingly > this file is rather unfamiliar to me, it's possible I'm missing something.)

[Qemu-devel] [PULL 01/11] block: get rid of bdrv_io_unplugged_begin/end

2017-01-16 Thread Stefan Hajnoczi
From: Paolo Bonzini bdrv_io_plug and bdrv_io_unplug are only called (via their BlockBackend equivalents) after starting asynchronous I/O. bdrv_drain is not going to be called while they are running, because---even if a coroutine runs for some reason---it will only drain in

[Qemu-devel] [PULL 2/4] trace: Lock vCPU list when initializing dynamic tracing state

2017-01-16 Thread Stefan Hajnoczi
From: Lluís Vilanova Fixes potential corruption when a vCPU is hot-(un)plugged while initializing the current one. Signed-off-by: Lluís Vilanova Message-id: 148278747515.1404.6538173443841279200.st...@fimbulvetr.bsc.es Signed-off-by: Stefan Hajnoczi

Re: [Qemu-devel] [virtio-dev] Re: [PATCH v15 0/2] virtio-crypto: virtio crypto device specification

2017-01-16 Thread Halil Pasic
On 01/16/2017 01:43 PM, Gonglei (Arei) wrote: > Hi Michael and others, > > I'd like to redefine struct virtio_crypto_op_data_req is as below: > > struct virtio_crypto_op_data_req { > struct virtio_crypto_op_header header; > > union { > struct virtio_crypto_sym_data_req

[Qemu-devel] [PULL 4/4] trace: Add event "guest_cpu_exit"

2017-01-16 Thread Stefan Hajnoczi
From: Lluís Vilanova Signals the hot-unplugging of a virtual (guest) CPU. Signed-off-by: Lluís Vilanova Message-id: 148278748597.1404.10546320797997984932.st...@fimbulvetr.bsc.es Signed-off-by: Stefan Hajnoczi --- trace/control.c

Re: [Qemu-devel] Towards an ivshmem 2.0?

2017-01-16 Thread Stefan Hajnoczi
On Mon, Jan 16, 2017 at 09:36:51AM +0100, Jan Kiszka wrote: > some of you may know that we are using a shared memory device similar to > ivshmem in the partitioning hypervisor Jailhouse [1]. > > We started as being compatible to the original ivshmem that QEMU > implements, but we quickly deviated

Re: [Qemu-devel] [PATCH 05/16] io: make qio_channel_yield aware of AioContexts

2017-01-16 Thread Fam Zheng
On Mon, 01/16 13:24, Paolo Bonzini wrote: > > > On 16/01/2017 12:38, Fam Zheng wrote: > >> +void qio_channel_detach_aio_context(QIOChannel *ioc) > >> +{ > >> +ioc->read_coroutine = NULL; > >> +ioc->write_coroutine = NULL; > >> +qio_channel_set_aio_fd_handlers(ioc); > >> +ioc->ctx

Re: [Qemu-devel] [PATCH 04/16] io: add methods to set I/O handlers on AioContext

2017-01-16 Thread Daniel P. Berrange
On Fri, Jan 13, 2017 at 02:17:19PM +0100, Paolo Bonzini wrote: > This is in preparation for making qio_channel_yield work on > AioContexts other than the main one. > > Signed-off-by: Paolo Bonzini Reviewed-by: Daniel P. Berrange > diff --git

Re: [Qemu-devel] [PATCH 04/16] io: add methods to set I/O handlers on AioContext

2017-01-16 Thread Daniel P. Berrange
On Fri, Jan 13, 2017 at 02:17:19PM +0100, Paolo Bonzini wrote: > This is in preparation for making qio_channel_yield work on > AioContexts other than the main one. > > Signed-off-by: Paolo Bonzini > --- > include/io/channel.h | 30 ++ >

Re: [Qemu-devel] [PATCH 10/16] block: explicitly acquire aiocontext in timers that need it

2017-01-16 Thread Fam Zheng
On Fri, 01/13 14:17, Paolo Bonzini wrote: > diff --git a/block/qed.c b/block/qed.c > index 7f1c508..a21d025 100644 > --- a/block/qed.c > +++ b/block/qed.c > @@ -345,10 +345,22 @@ static void qed_need_check_timer_cb(void *opaque) > > trace_qed_need_check_timer_cb(s); > > +

Re: [Qemu-devel] Performance about x-data-plane

2017-01-16 Thread Stefan Hajnoczi
On Tue, Jan 03, 2017 at 12:02:14PM -0500, Weiwei Jia wrote: > > The expensive part is the virtqueue kick. Recently we tried polling the > > virtqueue instead of waiting for the ioeventfd file descriptor and got > > double-digit performance improvements: > >

Re: [Qemu-devel] [PATCH v15 1/2] virtio-crypto: Add virtio crypto device specification

2017-01-16 Thread Stefan Hajnoczi
On Wed, Jan 04, 2017 at 06:03:04PM +0800, Gonglei wrote: > +The general header of dataq: > + > +\begin{lstlisting} > +struct virtio_crypto_op_header { > +#define VIRTIO_CRYPTO_CIPHER_ENCRYPT \ > +VIRTIO_CRYPTO_OPCODE(VIRTIO_CRYPTO_SERVICE_CIPHER, 0x00) > +#define VIRTIO_CRYPTO_CIPHER_DECRYPT \

Re: [Qemu-devel] [Bug 1656234] [NEW] Qemu core dumped if using virtio-net

2017-01-16 Thread Stefan Hajnoczi
On Fri, Jan 13, 2017 at 08:40:22AM -, Robert Hu wrote: > Public bug reported: > > System Environment > === > Qemu commit/branch: e92fbc75 > Host OS: RHEL7.2 ia32e > Host Kernel: 4.9.0 > Guest OS: RHEL7.2 ia32e > Guest Kernel: 4.9.0 > > Bug detailed description > === > While create a

  1   2   3   4   >